Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2025-01-24 09:11:24 +01:00
Code Issues Projects Releases Wiki Activity

Menus: Prevent non-published posts/pages from being returned in search results for adding as nav menu items.

Browse Source 
Re-use the same query vars in searching as when listing posts. Aligns with behavior of nav menus in customizer.

Fixes #33742.
Props welcher, westonruter.

Built from https://develop.svn.wordpress.org/trunk@38584


git-svn-id: http://core.svn.wordpress.org/trunk@38527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Weston Ruter 2016-09-09 04:59:31 +00:00
parent e482549183
commit 84f9592f88
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
wp-admin/includes/nav-menu.php
View File

@ -70,14 +70,19 @@ function _wp_ajax_menu_quick_search( $request = array() ) {
} elseif ( preg_match('/quick-search-(posttype|taxonomy)-([a-zA-Z_-]*\b)/', $type, $matches) ) { } elseif ( preg_match('/quick-search-(posttype|taxonomy)-([a-zA-Z_-]*\b)/', $type, $matches) ) {
if ( 'posttype' == $matches[1] && get_post_type_object( $matches[2] ) ) { if ( 'posttype' == $matches[1] && get_post_type_object( $matches[2] ) ) {
$search_results_query = new WP_Query( array( $post_type_obj = _wp_nav_menu_meta_box_object( get_post_type_object( $matches[2] ) );
$args = array(
'no_found_rows' => true, 'no_found_rows' => true,
'update_post_meta_cache' => false, 'update_post_meta_cache' => false,
'update_post_term_cache' => false, 'update_post_term_cache' => false,
'posts_per_page' => 10, 'posts_per_page' => 10,
'post_type' => $matches[2], 'post_type' => $matches[2],
's' => $query, 's' => $query,
) ); );
if ( isset( $post_type_obj->_default_query ) ) {
$args = array_merge( $args, (array) $post_type_obj->_default_query );
}
$search_results_query = new WP_Query( $args );
if ( ! $search_results_query->have_posts() ) { if ( ! $search_results_query->have_posts() ) {
return; return;
} }

2
wp-includes/version.php
View File

@ -4,7 +4,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '4.7-alpha-38583'; $wp_version = '4.7-alpha-38584';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.