Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-23 01:27:36 +01:00
Code Issues Projects Releases Wiki Activity

Twenty Nineteen: Make sure links are followed on touchend, not touchstart.

Browse Source 
The theme's original navigation JavaScript was making it so all links on a site were immediately followed on touchstart when using a touch-enabled device. This update makes sure links are followed at touchend, to improve usability and menu behavior.

Already committed to the 5.0 branch in [44357].

Props anevins, panchen, kjellr.
Fixes #45510.


Built from https://develop.svn.wordpress.org/trunk@44358


git-svn-id: http://core.svn.wordpress.org/trunk@44188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
laurelfulford 2018-12-21 21:36:49 +00:00
parent 0211420001
commit 8e54c18d0d
2 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
wp-content/themes/twentynineteen/js/touch-keyboard-navigation.js
View File

@ -219,19 +219,9 @@
var url = event.target.getAttribute( 'href' ) ? event.target.getAttribute( 'href' ) : '';
// If there’s a link, go to it on touchend
if ( '#' !== url && '' !== url ) {
window.location = url;
// Open submenu if url is #
} else if ( '#' === url && event.target.nextSibling.matches('.submenu-expand') ) {
if ( '#' === url && event.target.nextSibling.matches('.submenu-expand') ) {
openSubMenu( event.target );
// Prevent default touch events
} else {
event.preventDefault();
}
}

2
wp-includes/version.php
View File

@ -13,7 +13,7 @@
*
* @global string $wp_version
*/
$wp_version = '5.1-alpha-44356';
$wp_version = '5.1-alpha-44358';
/**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.