Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-09-27 14:53:08 +02:00
Code Issues Projects Releases Wiki Activity

Taxonomy: Stop warming term meta cache unnecessarily.

Browse Source 
Prevent several core function calls to `get_terms()` from warming the term meta cache.

Props peterwilsoncc, boonebgorges, jrf.
Fixes #43142.


Built from https://develop.svn.wordpress.org/trunk@42649


git-svn-id: http://core.svn.wordpress.org/trunk@42478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Peter Wilson 2018-02-05 04:10:30 +00:00
parent 0d39b35c11
commit 8f0ab2efb8
2 changed files with 23 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
wp-includes/taxonomy.php
View File

@ -2147,9 +2147,10 @@ function wp_insert_term( $term, $taxonomy, $args = array() ) {
*/ */
$name_matches = get_terms( $name_matches = get_terms(
$taxonomy, array( $taxonomy, array(
'name' => $name, 'name' => $name,
'hide_empty' => false, 'hide_empty' => false,
'parent' => $args['parent'], 'parent' => $args['parent'],
'update_term_meta_cache' => false,
) )
); );
@ -2173,8 +2174,9 @@ function wp_insert_term( $term, $taxonomy, $args = array() ) {
if ( is_taxonomy_hierarchical( $taxonomy ) ) { if ( is_taxonomy_hierarchical( $taxonomy ) ) {
$siblings = get_terms( $siblings = get_terms(
$taxonomy, array( $taxonomy, array(
'get' => 'all', 'get' => 'all',
'parent' => $parent, 'parent' => $parent,
'update_term_meta_cache' => false,
) )
); );
@ -2364,8 +2366,9 @@ function wp_set_object_terms( $object_id, $terms, $taxonomy, $append = false ) {
if ( ! $append ) { if ( ! $append ) {
$old_tt_ids = wp_get_object_terms( $old_tt_ids = wp_get_object_terms(
$object_id, $taxonomy, array( $object_id, $taxonomy, array(
'fields' => 'tt_ids', 'fields' => 'tt_ids',
'orderby' => 'none', 'orderby' => 'none',
'update_term_meta_cache' => false,
) )
); );
} else { } else {
@ -2454,7 +2457,14 @@ function wp_set_object_terms( $object_id, $terms, $taxonomy, $append = false ) {
if ( ! $append && isset( $t->sort ) && $t->sort ) { if ( ! $append && isset( $t->sort ) && $t->sort ) {
$values = array(); $values = array();
$term_order = 0; $term_order = 0;
$final_tt_ids = wp_get_object_terms( $object_id, $taxonomy, array( 'fields' => 'tt_ids' ) ); $final_tt_ids = wp_get_object_terms(
$object_id,
$taxonomy,
array(
'fields' => 'tt_ids',
'update_term_meta_cache' => false,
)
);
foreach ( $tt_ids as $tt_id ) { foreach ( $tt_ids as $tt_id ) {
if ( in_array( $tt_id, $final_tt_ids ) ) { if ( in_array( $tt_id, $final_tt_ids ) ) {
$values[] = $wpdb->prepare( '(%d, %d, %d)', $object_id, $tt_id, ++$term_order ); $values[] = $wpdb->prepare( '(%d, %d, %d)', $object_id, $tt_id, ++$term_order );
@ -3382,9 +3392,10 @@ function _get_term_hierarchy( $taxonomy ) {
$children = array(); $children = array();
$terms = get_terms( $terms = get_terms(
$taxonomy, array( $taxonomy, array(
'get' => 'all', 'get' => 'all',
'orderby' => 'id', 'orderby' => 'id',
'fields' => 'id=>parent', 'fields' => 'id=>parent',
'update_term_meta_cache' => false,
) )
); );
foreach ( $terms as $term_id => $parent ) { foreach ( $terms as $term_id => $parent ) {

2
wp-includes/version.php
View File

@ -4,7 +4,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '5.0-alpha-42648'; $wp_version = '5.0-alpha-42649';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.