Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2025-02-07 08:01:54 +01:00
Code Issues Projects Releases Wiki Activity

Stop cleaning the cache of a post's children. Ancestors are no longer cached against the post object, which means this kind of walking is unnecessary. It is also prohibitively expensive with large hierarchies.

Browse Source 
We need to remove post_ancestors non-persistent caching for this. get_post_ancestors() can simply rely on the caching of get_post() instead. Previously, it was a direct query, hence the extra layers of caching and clearing.

Child cache clearing stays in wp_delete_post() as children get a new parent.

fixes #11399.



git-svn-id: http://core.svn.wordpress.org/trunk@21952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Andrew Nacin 2012-09-22 15:55:02 +00:00
parent d80d004b10
commit a42ce2353a
2 changed files with 3 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
wp-includes/load.php
View File

@ -410,7 +410,7 @@ function wp_start_object_cache() {
if ( function_exists( 'wp_cache_add_global_groups' ) ) {
wp_cache_add_global_groups( array( 'users', 'userlogins', 'usermeta', 'user_meta', 'site-transient', 'site-options', 'site-lookup', 'blog-lookup', 'blog-details', 'rss', 'global-posts' ) );
wp_cache_add_non_persistent_groups( array( 'comment', 'counts', 'plugins', 'post_ancestors' ) );
wp_cache_add_non_persistent_groups( array( 'comment', 'counts', 'plugins' ) );
}
}

17
wp-includes/post.php
View File

@ -557,7 +557,6 @@ function get_post_ancestors( $post ) {
$post = get_post( $post );
if ( ! $ancestors = wp_cache_get( $post->ID, 'post_ancestors' ) ) {
$ancestors = array();
if ( !empty( $post->post_parent ) && $post->ID != $post->post_parent ) {
@ -572,9 +571,6 @@ function get_post_ancestors( $post ) {
}
}
wp_cache_add( $post->ID, $ancestors, 'post_ancestors' );
}
return $ancestors;
}
@ -2218,8 +2214,8 @@ function wp_delete_post( $postid = 0, $force_delete = false ) {
clean_post_cache( $post );
if ( is_post_type_hierarchical( $post->post_type ) ) {
foreach ( (array) $children as $child )
if ( is_post_type_hierarchical( $post->post_type ) && $children ) {
foreach ( $children as $child )
clean_post_cache( $child );
}
@ -4500,15 +4496,6 @@ function clean_post_cache( $post ) {
wp_cache_delete( 'all_page_ids', 'posts' );
do_action( 'clean_page_cache', $post->ID );
}
if ( $children = $wpdb->get_results( $wpdb->prepare("SELECT ID, post_type FROM $wpdb->posts WHERE post_parent = %d", $post->ID) ) ) {
foreach ( $children as $child ) {
// Loop detection
if ( $child->ID == $post->ID )
continue;
clean_post_cache( $child );
}
}
}
/**