mirror of
https://github.com/WordPress/WordPress.git
synced 2025-01-08 01:17:59 +01:00
HTML API: Indicate when WordPress rejects attribute updates.
When setting an an attribute value in the HTML API, WordPress may reject an update based on rules in `kses`. In these cases, the return value from an escaping function will be an empty string, and the HTML API should reject the update. Unfortunately, it currently reports that it updates the attribute but sets an empty string value, which is misleading. In this changeset, the HTML API will refuse the attribute update and return false to indicate as much when WordPress rejects the updates. Reviewed by jorbin, hellofromTonya. Merges [58844] to the 6.6 branch. Follow-up to [58472]. Props amitraj2203, dmsnell, mukesh27. Fixes #61719. Built from https://develop.svn.wordpress.org/branches/6.6@58980 git-svn-id: http://core.svn.wordpress.org/branches/6.6@58376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
parent
fd299ecfd5
commit
b0aca7258d
@ -2980,6 +2980,12 @@ class WP_HTML_Tag_Processor {
|
||||
* @see https://html.spec.whatwg.org/#attributes-3
|
||||
*/
|
||||
$escaped_new_value = in_array( $comparable_name, wp_kses_uri_attributes() ) ? esc_url( $value ) : esc_attr( $value );
|
||||
|
||||
// If the escaping functions wiped out the update, reject it and indicate it was rejected.
|
||||
if ( '' === $escaped_new_value && '' !== $value ) {
|
||||
return false;
|
||||
}
|
||||
|
||||
$updated_attribute = "{$name}=\"{$escaped_new_value}\"";
|
||||
}
|
||||
|
||||
|
@ -16,7 +16,7 @@
|
||||
*
|
||||
* @global string $wp_version
|
||||
*/
|
||||
$wp_version = '6.6.2-alpha-58979';
|
||||
$wp_version = '6.6.2-alpha-58980';
|
||||
|
||||
/**
|
||||
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.
|
||||
|
Loading…
Reference in New Issue
Block a user