List tables: Select All should not be a column header.

It sets a redundant relationship with all checkboxes in its column and also conveys wrong information for screen readers.

props afercia, valendesigns.
see #31654.
Built from https://develop.svn.wordpress.org/trunk@32984


git-svn-id: http://core.svn.wordpress.org/trunk@32955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Sergey Biryukov 2015-06-28 05:46:25 +00:00
parent 275fc220ef
commit b26accf35a
16 changed files with 156 additions and 108 deletions

View File

@ -471,11 +471,13 @@ code {
padding: 8px 10px; padding: 8px 10px;
} }
.widefat thead th { .widefat thead th,
.widefat thead td {
border-bottom: 1px solid #e1e1e1; border-bottom: 1px solid #e1e1e1;
} }
.widefat tfoot th { .widefat tfoot th,
.widefat tfoot td {
border-top: 1px solid #e1e1e1; border-top: 1px solid #e1e1e1;
border-bottom: none; border-bottom: none;
} }
@ -496,13 +498,17 @@ code {
line-height: 1.5em; line-height: 1.5em;
} }
.widefat th { .widefat th,
.widefat thead td,
.widefat tfoot td {
text-align: right; text-align: right;
line-height: 1.3em; line-height: 1.3em;
font-size: 14px; font-size: 14px;
} }
.widefat th input { .widefat th input,
.widefat thead td input,
.widefat tfoot td input {
margin: 0 8px 0 0; margin: 0 8px 0 0;
padding: 0; padding: 0;
vertical-align: text-top; vertical-align: text-top;
@ -514,7 +520,9 @@ code {
vertical-align: top; vertical-align: top;
} }
.widefat th input[type=checkbox] { .widefat th input[type=checkbox],
.widefat thead td input[type=checkbox],
.widefat tfoot td input[type=checkbox] {
margin-top: -1px; margin-top: -1px;
} }
@ -526,13 +534,14 @@ code {
padding-top: 8px; padding-top: 8px;
} }
.widefat thead th.check-column, .widefat thead td.check-column,
.widefat tbody th.check-column, .widefat tbody th.check-column,
.widefat tfoot th.check-column { .widefat tfoot td.check-column {
padding: 11px 3px 0 0; padding: 11px 3px 0 0;
} }
.widefat thead th.check-column { .widefat thead td.check-column,
.widefat tfoot td.check-column {
padding-top: 10px; padding-top: 10px;
} }
@ -714,7 +723,9 @@ img.emoji {
.side-info, .side-info,
#your-profile #rich_editing, #your-profile #rich_editing,
.widefat thead th, .widefat thead th,
.widefat tfoot th { .widefat thead td,
.widefat tfoot th,
.widefat tfoot td {
line-height: 1.4em; line-height: 1.4em;
} }
@ -1687,12 +1698,16 @@ html.wp-toolbar {
color: #555; color: #555;
} }
.widefat th { .widefat th,
.widefat thead td,
.widefat tfoot td {
font-weight: normal; font-weight: normal;
} }
.widefat thead tr th, .widefat thead tr th,
.widefat tfoot tr th { .widefat thead tr td,
.widefat tfoot tr th,
.widefat tfoot tr td {
color: #32373c; color: #32373c;
} }

View File

@ -471,11 +471,13 @@ code {
padding: 8px 10px; padding: 8px 10px;
} }
.widefat thead th { .widefat thead th,
.widefat thead td {
border-bottom: 1px solid #e1e1e1; border-bottom: 1px solid #e1e1e1;
} }
.widefat tfoot th { .widefat tfoot th,
.widefat tfoot td {
border-top: 1px solid #e1e1e1; border-top: 1px solid #e1e1e1;
border-bottom: none; border-bottom: none;
} }
@ -496,13 +498,17 @@ code {
line-height: 1.5em; line-height: 1.5em;
} }
.widefat th { .widefat th,
.widefat thead td,
.widefat tfoot td {
text-align: left; text-align: left;
line-height: 1.3em; line-height: 1.3em;
font-size: 14px; font-size: 14px;
} }
.widefat th input { .widefat th input,
.widefat thead td input,
.widefat tfoot td input {
margin: 0 0 0 8px; margin: 0 0 0 8px;
padding: 0; padding: 0;
vertical-align: text-top; vertical-align: text-top;
@ -514,7 +520,9 @@ code {
vertical-align: top; vertical-align: top;
} }
.widefat th input[type=checkbox] { .widefat th input[type=checkbox],
.widefat thead td input[type=checkbox],
.widefat tfoot td input[type=checkbox] {
margin-top: -1px; margin-top: -1px;
} }
@ -526,13 +534,14 @@ code {
padding-top: 8px; padding-top: 8px;
} }
.widefat thead th.check-column, .widefat thead td.check-column,
.widefat tbody th.check-column, .widefat tbody th.check-column,
.widefat tfoot th.check-column { .widefat tfoot td.check-column {
padding: 11px 0 0 3px; padding: 11px 0 0 3px;
} }
.widefat thead th.check-column { .widefat thead td.check-column,
.widefat tfoot td.check-column {
padding-top: 10px; padding-top: 10px;
} }
@ -714,7 +723,9 @@ img.emoji {
.side-info, .side-info,
#your-profile #rich_editing, #your-profile #rich_editing,
.widefat thead th, .widefat thead th,
.widefat tfoot th { .widefat thead td,
.widefat tfoot th,
.widefat tfoot td {
line-height: 1.4em; line-height: 1.4em;
} }
@ -1687,12 +1698,16 @@ html.wp-toolbar {
color: #555; color: #555;
} }
.widefat th { .widefat th,
.widefat thead td,
.widefat tfoot td {
font-weight: normal; font-weight: normal;
} }
.widefat thead tr th, .widefat thead tr th,
.widefat tfoot tr th { .widefat thead tr td,
.widefat tfoot tr th,
.widefat tfoot tr td {
color: #32373c; color: #32373c;
} }

View File

@ -944,16 +944,24 @@ table.form-table td .updated p {
padding-top: 10px; padding-top: 10px;
} }
input[type="checkbox"], .widefat th input[type="checkbox"] { input[type="checkbox"],
.widefat th input[type="checkbox"],
.widefat thead td input[type="checkbox"],
.widefat tfoot td input[type="checkbox"] {
-webkit-appearance: none; -webkit-appearance: none;
padding: 10px; padding: 10px;
} }
.widefat th input[type="checkbox"] { .widefat th input[type="checkbox"],
.widefat thead td input[type="checkbox"],
.widefat tfoot td input[type="checkbox"] {
margin-bottom: 8px; margin-bottom: 8px;
} }
input[type="checkbox"]:checked:before, .widefat th input[type="checkbox"]:before { input[type="checkbox"]:checked:before,
.widefat th input[type="checkbox"]:before,
.widefat thead td input[type="checkbox"]:before,
.widefat tfoot td input[type="checkbox"]:before {
font: normal 30px/1 'Dashicons'; font: normal 30px/1 'Dashicons';
margin: -3px -5px; margin: -3px -5px;
} }

View File

@ -944,16 +944,24 @@ table.form-table td .updated p {
padding-top: 10px; padding-top: 10px;
} }
input[type="checkbox"], .widefat th input[type="checkbox"] { input[type="checkbox"],
.widefat th input[type="checkbox"],
.widefat thead td input[type="checkbox"],
.widefat tfoot td input[type="checkbox"] {
-webkit-appearance: none; -webkit-appearance: none;
padding: 10px; padding: 10px;
} }
.widefat th input[type="checkbox"] { .widefat th input[type="checkbox"],
.widefat thead td input[type="checkbox"],
.widefat tfoot td input[type="checkbox"] {
margin-bottom: 8px; margin-bottom: 8px;
} }
input[type="checkbox"]:checked:before, .widefat th input[type="checkbox"]:before { input[type="checkbox"]:checked:before,
.widefat th input[type="checkbox"]:before,
.widefat thead td input[type="checkbox"]:before,
.widefat tfoot td input[type="checkbox"]:before {
font: normal 30px/1 'Dashicons'; font: normal 30px/1 'Dashicons';
margin: -3px -5px; margin: -3px -5px;
} }

View File

@ -484,12 +484,16 @@ table.ie-fixed {
} }
.widefat tr, .widefat tr,
.widefat th { .widefat th,
.widefat thead td,
.widefat tfoot td {
margin-bottom: 0; margin-bottom: 0;
border-spacing: 0; border-spacing: 0;
} }
.widefat th input { .widefat th input,
.widefat thead td input,
.widefat tfoot td input {
margin: 0 5px 0 0; margin: 0 5px 0 0;
} }

File diff suppressed because one or more lines are too long

View File

@ -484,12 +484,16 @@ table.ie-fixed {
} }
.widefat tr, .widefat tr,
.widefat th { .widefat th,
.widefat thead td,
.widefat tfoot td {
margin-bottom: 0; margin-bottom: 0;
border-spacing: 0; border-spacing: 0;
} }
.widefat th input { .widefat th input,
.widefat thead td input,
.widefat tfoot td input {
margin: 0 0 0 5px; margin: 0 0 0 5px;
} }

File diff suppressed because one or more lines are too long

View File

@ -369,7 +369,8 @@ table.media .column-title .media-info p {
border: 0 none; border: 0 none;
} }
#commentsdiv .comments-box thead th { #commentsdiv .comments-box thead th,
#commentsdiv .comments-box thead td {
background: transparent; background: transparent;
padding: 0 7px 4px; padding: 0 7px 4px;
font-style: italic; font-style: italic;
@ -1085,14 +1086,14 @@ ul.cat-checklist {
font-size: 14px; font-size: 14px;
} }
.plugins thead th.check-column, .plugins thead td.check-column,
.plugins tfoot th.check-column, .plugins tfoot td.check-column,
.plugins .inactive th.check-column { .plugins .inactive th.check-column {
padding-right: 6px; padding-right: 6px;
} }
#update-plugins-table thead th.check-column, #update-plugins-table thead td.check-column,
#update-plugins-table tfoot th.check-column { #update-plugins-table tfoot td.check-column {
padding-top: 11px; padding-top: 11px;
} }
@ -1235,9 +1236,8 @@ tr.active.update + tr.plugin-update-tr .plugin-update {
.plugin-update-tr .update-message { .plugin-update-tr .update-message {
font-size: 13px; font-size: 13px;
font-weight: normal; font-weight: normal;
margin: 6px 12px 12px;
padding: 6px 12px;
margin: 0 31px 8px 10px; margin: 0 31px 8px 10px;
padding: 6px 40px 8px 12px;
background-color: #f7f7f7; background-color: #f7f7f7;
background-color: rgba(0,0,0,0.03); background-color: rgba(0,0,0,0.03);
} }
@ -1260,7 +1260,7 @@ tr.active.update + tr.plugin-update-tr .plugin-update {
} }
.plugin-update-tr .update-message:before { .plugin-update-tr .update-message:before {
margin: 0 -2px 0 8px; margin: 0 -30px 0 10px;
} }
.plugin-card .update-now:before, .plugin-card .update-now:before,
@ -1833,11 +1833,10 @@ div.action-links,
/* Plugin/Theme Management Page */ /* Plugin/Theme Management Page */
.wp-list-table.plugins { .wp-list-table.plugins {
position: relative; position: relative;
margin-top: 35px; margin-bottom: 15px;
margin-bottom: 50px;
} }
.wp-list-table.plugins thead .column-description, #wpbody-content .wp-list-table.plugins thead .column-description,
#wpbody-content .wp-list-table.plugins tfoot .column-description, #wpbody-content .wp-list-table.plugins tfoot .column-description,
.wp-list-table.plugins th#description { .wp-list-table.plugins th#description {
display: none; display: none;
@ -1856,21 +1855,6 @@ div.action-links,
width: auto; width: auto;
} }
.wp-list-table.plugins thead,
.wp-list-table.plugins tfoot {
position: absolute;
top: -35px;
right: 0;
left: 0;
width: auto;
height: 35px;
}
.wp-list-table.plugins tfoot {
bottom: -35px;
top: auto;
}
.active, .inactive { .active, .inactive {
padding-top: 0; padding-top: 0;
} }
@ -1916,11 +1900,22 @@ div.action-links,
padding-right: 46px; padding-right: 46px;
} }
.wp-list-table.plugins .manage-column.column-name {
padding-top: 11px;
padding-bottom: 12px;
}
.wp-list-table.plugins .manage-column.column-name.sortable {
padding: 4px 36px 4px 12px;
}
.wp-list-table.plugins tr { .wp-list-table.plugins tr {
position: relative; position: relative;
} }
.wp-list-table.plugins th.check-column, .wp-list-table.plugins th.check-column,
.wp-list-table.plugins thead td.check-column,
.wp-list-table.plugins tfoot td.check-column,
.wp-list-table.plugins tr.update th.check-column { .wp-list-table.plugins tr.update th.check-column {
position: absolute; position: absolute;
height: auto; height: auto;
@ -1931,26 +1926,27 @@ div.action-links,
padding-top: 18px; padding-top: 18px;
} }
.wp-list-table.plugins thead th.check-column, .wp-list-table.plugins thead td.check-column,
.wp-list-table.plugins tfoot th.check-column { .wp-list-table.plugins tfoot td.check-column {
padding-right: 3px; padding-right: 3px;
padding-top: 11px; padding-top: 11px;
background: none; background: none;
} }
.widefat tbody th.check-column input[type="checkbox"] { .plugins tbody th.check-column input[type="checkbox"] {
margin-top: -3px; margin-top: -3px;
margin-right: 8px; margin-right: 9px;
} }
.wp-list-table.plugins .active .check-column input, .plugins tbody .active th.check-column input[type="checkbox"],
.wp-list-table.plugins .update .check-column input { .plugins tbody .active.update th.check-column input[type="checkbox"] {
margin-right: 5px; margin-right: 5px;
} }
.wp-list-table.plugins thead .check-column input, .wp-list-table.plugins thead .check-column input,
.wp-list-table.plugins tfoot .check-column input { .wp-list-table.plugins tfoot .check-column input {
margin-top: -6px; margin-top: -2px;
margin-right: 8px;
} }
.wp-list-table.plugins .active th.check-column { .wp-list-table.plugins .active th.check-column {

View File

@ -369,7 +369,8 @@ table.media .column-title .media-info p {
border: 0 none; border: 0 none;
} }
#commentsdiv .comments-box thead th { #commentsdiv .comments-box thead th,
#commentsdiv .comments-box thead td {
background: transparent; background: transparent;
padding: 0 7px 4px; padding: 0 7px 4px;
font-style: italic; font-style: italic;
@ -1085,14 +1086,14 @@ ul.cat-checklist {
font-size: 14px; font-size: 14px;
} }
.plugins thead th.check-column, .plugins thead td.check-column,
.plugins tfoot th.check-column, .plugins tfoot td.check-column,
.plugins .inactive th.check-column { .plugins .inactive th.check-column {
padding-left: 6px; padding-left: 6px;
} }
#update-plugins-table thead th.check-column, #update-plugins-table thead td.check-column,
#update-plugins-table tfoot th.check-column { #update-plugins-table tfoot td.check-column {
padding-top: 11px; padding-top: 11px;
} }
@ -1235,9 +1236,8 @@ tr.active.update + tr.plugin-update-tr .plugin-update {
.plugin-update-tr .update-message { .plugin-update-tr .update-message {
font-size: 13px; font-size: 13px;
font-weight: normal; font-weight: normal;
margin: 6px 12px 12px;
padding: 6px 12px;
margin: 0 10px 8px 31px; margin: 0 10px 8px 31px;
padding: 6px 12px 8px 40px;
background-color: #f7f7f7; background-color: #f7f7f7;
background-color: rgba(0,0,0,0.03); background-color: rgba(0,0,0,0.03);
} }
@ -1260,7 +1260,7 @@ tr.active.update + tr.plugin-update-tr .plugin-update {
} }
.plugin-update-tr .update-message:before { .plugin-update-tr .update-message:before {
margin: 0 8px 0 -2px; margin: 0 10px 0 -30px;
} }
.plugin-card .update-now:before, .plugin-card .update-now:before,
@ -1833,11 +1833,10 @@ div.action-links,
/* Plugin/Theme Management Page */ /* Plugin/Theme Management Page */
.wp-list-table.plugins { .wp-list-table.plugins {
position: relative; position: relative;
margin-top: 35px; margin-bottom: 15px;
margin-bottom: 50px;
} }
.wp-list-table.plugins thead .column-description, #wpbody-content .wp-list-table.plugins thead .column-description,
#wpbody-content .wp-list-table.plugins tfoot .column-description, #wpbody-content .wp-list-table.plugins tfoot .column-description,
.wp-list-table.plugins th#description { .wp-list-table.plugins th#description {
display: none; display: none;
@ -1856,21 +1855,6 @@ div.action-links,
width: auto; width: auto;
} }
.wp-list-table.plugins thead,
.wp-list-table.plugins tfoot {
position: absolute;
top: -35px;
left: 0;
right: 0;
width: auto;
height: 35px;
}
.wp-list-table.plugins tfoot {
bottom: -35px;
top: auto;
}
.active, .inactive { .active, .inactive {
padding-top: 0; padding-top: 0;
} }
@ -1916,11 +1900,22 @@ div.action-links,
padding-left: 46px; padding-left: 46px;
} }
.wp-list-table.plugins .manage-column.column-name {
padding-top: 11px;
padding-bottom: 12px;
}
.wp-list-table.plugins .manage-column.column-name.sortable {
padding: 4px 12px 4px 36px;
}
.wp-list-table.plugins tr { .wp-list-table.plugins tr {
position: relative; position: relative;
} }
.wp-list-table.plugins th.check-column, .wp-list-table.plugins th.check-column,
.wp-list-table.plugins thead td.check-column,
.wp-list-table.plugins tfoot td.check-column,
.wp-list-table.plugins tr.update th.check-column { .wp-list-table.plugins tr.update th.check-column {
position: absolute; position: absolute;
height: auto; height: auto;
@ -1931,26 +1926,27 @@ div.action-links,
padding-top: 18px; padding-top: 18px;
} }
.wp-list-table.plugins thead th.check-column, .wp-list-table.plugins thead td.check-column,
.wp-list-table.plugins tfoot th.check-column { .wp-list-table.plugins tfoot td.check-column {
padding-left: 3px; padding-left: 3px;
padding-top: 11px; padding-top: 11px;
background: none; background: none;
} }
.widefat tbody th.check-column input[type="checkbox"] { .plugins tbody th.check-column input[type="checkbox"] {
margin-top: -3px; margin-top: -3px;
margin-left: 8px; margin-left: 9px;
} }
.wp-list-table.plugins .active .check-column input, .plugins tbody .active th.check-column input[type="checkbox"],
.wp-list-table.plugins .update .check-column input { .plugins tbody .active.update th.check-column input[type="checkbox"] {
margin-left: 5px; margin-left: 5px;
} }
.wp-list-table.plugins thead .check-column input, .wp-list-table.plugins thead .check-column input,
.wp-list-table.plugins tfoot .check-column input { .wp-list-table.plugins tfoot .check-column input {
margin-top: -6px; margin-top: -2px;
margin-left: 8px;
} }
.wp-list-table.plugins .active th.check-column { .wp-list-table.plugins .active th.check-column {

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

View File

@ -993,12 +993,14 @@ class WP_List_Table {
$column_display_name = '<a href="' . esc_url( add_query_arg( compact( 'orderby', 'order' ), $current_url ) ) . '"><span>' . $column_display_name . '</span><span class="sorting-indicator"></span></a>'; $column_display_name = '<a href="' . esc_url( add_query_arg( compact( 'orderby', 'order' ), $current_url ) ) . '"><span>' . $column_display_name . '</span><span class="sorting-indicator"></span></a>';
} }
$tag = ( 'cb' === $column_key ) ? 'td' : 'th';
$scope = ( 'th' === $tag ) ? 'scope="col"' : '';
$id = $with_id ? "id='$column_key'" : ''; $id = $with_id ? "id='$column_key'" : '';
if ( !empty( $class ) ) if ( !empty( $class ) )
$class = "class='" . join( ' ', $class ) . "'"; $class = "class='" . join( ' ', $class ) . "'";
echo "<th scope='col' $id $class>$column_display_name</th>"; echo "<$tag $scope $id $class>$column_display_name</$tag>";
} }
} }

View File

@ -4,7 +4,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '4.3-alpha-32983'; $wp_version = '4.3-alpha-32984';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.