Block Editor: Show privacy help notice on Privacy Policy page.

When editing a page set to be the Privacy Policy page, display a help notice
containing a link to the Privacy Policy guide.

This changeset ports this functionality to the new Block Editor.

Props desrosj.
Fixes #45057.


Built from https://develop.svn.wordpress.org/branches/5.0@43920


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43752 1a063a9b-81f0-0310-95a4-ce76da25c4cd

wp-admin/includes/admin-filters.php

@@ -144,7 +144,7 @@ add_action( 'wp_privacy_personal_data_erased', '_wp_privacy_send_erasure_fulfill
 add_action( 'admin_init', array( 'WP_Privacy_Policy_Content', 'text_change_check' ), 100 );
 
 // Show a "postbox" with the text suggestions for a privacy policy.
-add_action( 'edit_form_after_title', array( 'WP_Privacy_Policy_Content', 'notice' ) );
+add_action( 'admin_notices', array( 'WP_Privacy_Policy_Content', 'notice' ) );
 
 // Add the suggested policy text from WordPress.
 add_action( 'admin_init', array( 'WP_Privacy_Policy_Content', 'add_suggested_content' ), 1 );

wp-admin/includes/misc.php

@@ -1540,10 +1540,13 @@ final class WP_Privacy_Policy_Content {
 	 * Add a notice with a link to the guide when editing the privacy policy page.
 	 *
 	 * @since 4.9.6
+	 * @since 5.0.0 The $post parameter is now optional.
 	 *
-	 * @param WP_Post $post The currently edited post.
+	 * @param WP_Post|null $post The currently edited post. Default null.
 	 */
-	public static function notice( $post ) {
+	public static function notice( $post = null ) {
+		$post = get_post( $post );
+
 		if ( ! ( $post instanceof WP_Post ) ) {
 			return;
 		}

wp-includes/blocks/archives.php

@@ -32,7 +32,7 @@ function render_block_core_archives( $attributes ) {
 		$class .= ' wp-block-archives-dropdown';
 
 		$dropdown_id = esc_attr( uniqid( 'wp-block-archives-' ) );
-		$title       = __( 'Archives' );
+		$title       = __( 'Archives', 'default' );
 
 		/** This filter is documented in wp-includes/widgets/class-wp-widget-archives.php */
 		$dropdown_args = apply_filters(
@@ -50,19 +50,19 @@ function render_block_core_archives( $attributes ) {
 
 		switch ( $dropdown_args['type'] ) {
 			case 'yearly':
-				$label = __( 'Select Year' );
+				$label = __( 'Select Year', 'default' );
 				break;
 			case 'monthly':
-				$label = __( 'Select Month' );
+				$label = __( 'Select Month', 'default' );
 				break;
 			case 'daily':
-				$label = __( 'Select Day' );
+				$label = __( 'Select Day', 'default' );
 				break;
 			case 'weekly':
-				$label = __( 'Select Week' );
+				$label = __( 'Select Week', 'default' );
 				break;
 			default:
-				$label = __( 'Select Post' );
+				$label = __( 'Select Post', 'default' );
 				break;
 		}
 
@@ -101,7 +101,7 @@ function render_block_core_archives( $attributes ) {
 			$block_content = sprintf(
 				'<div class="%1$s">%2$s</div>',
 				$classnames,
-				__( 'No archives to show.' )
+				__( 'No archives to show.', 'default' )
 			);
 		} else {
 

wp-includes/blocks/categories.php

@@ -27,7 +27,7 @@ function render_block_core_categories( $attributes ) {
 	if ( ! empty( $attributes['displayAsDropdown'] ) ) {
 		$id                       = 'wp-block-categories-' . $block_id;
 		$args['id']               = $id;
-		$args['show_option_none'] = __( 'Select Category' );
+		$args['show_option_none'] = __( 'Select Category', 'default' );
 		$wrapper_markup           = '<div class="%1$s">%2$s</div>';
 		$items_markup             = wp_dropdown_categories( $args );
 		$type                     = 'dropdown';

wp-includes/blocks/latest-comments.php

@@ -29,7 +29,7 @@ if ( ! function_exists( 'gutenberg_draft_or_post_title' ) ) {
 	function gutenberg_draft_or_post_title( $post = 0 ) {
 		$title = get_the_title( $post );
 		if ( empty( $title ) ) {
-			$title = __( '(no title)' );
+			$title = __( '(no title)', 'default' );
 		}
 		return esc_html( $title );
 	}
@@ -98,7 +98,7 @@ function gutenberg_render_block_core_latest_comments( $attributes = array() ) {
 
 			$list_items_markup .= sprintf(
 				/* translators: 1: author name (inside <a> or <span> tag, based on if they have a URL), 2: post title related to this comment */
-				__( '%1$s on %2$s' ),
+				__( '%1$s on %2$s', 'default' ),
 				$author_markup,
 				$post_title
 			);
@@ -143,7 +143,7 @@ function gutenberg_render_block_core_latest_comments( $attributes = array() ) {
 	) : sprintf(
 		'<div class="%1$s">%2$s</div>',
 		$classnames,
-		__( 'No comments to show.' )
+		__( 'No comments to show.', 'default' )
 	);
 
 	return $block_content;

wp-includes/blocks/latest-posts.php

@@ -33,7 +33,7 @@ function render_block_core_latest_posts( $attributes ) {
 
 		$title = get_the_title( $post_id );
 		if ( ! $title ) {
-			$title = __( '(Untitled)' );
+			$title = __( '(Untitled)', 'default' );
 		}
 		$list_items_markup .= sprintf(
 			'<li><a href="%1$s">%2$s</a>',

wp-includes/version.php

@@ -4,7 +4,7 @@
  *
  * @global string $wp_version
  */
-$wp_version = '5.0-beta5-43919';
+$wp_version = '5.0-beta5-43920';
 
 /**
  * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.