From babd60d5d5dc5f31973cf8aed7156fe664b4dc05 Mon Sep 17 00:00:00 2001 From: scribu Date: Sun, 5 Sep 2010 14:54:55 +0000 Subject: [PATCH] Don't suppress errors in _wp_meta_sql(). See #14572 git-svn-id: http://svn.automattic.com/wordpress/trunk@15568 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/functions.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/wp-includes/functions.php b/wp-includes/functions.php index 7ea31f86a9..4fab3b4432 100644 --- a/wp-includes/functions.php +++ b/wp-includes/functions.php @@ -4234,12 +4234,12 @@ function _wp_meta_sql( $queries, $meta_id_column, $table ) { $clauses = array(); - foreach ( $queries as $query ) { - $meta_key = trim( @$query['meta_key'] ); - $meta_value = trim( @$query['meta_value'] ); - $meta_compare = @$query['meta_compare']; + foreach ( $queries as $q ) { + $meta_key = isset( $q['meta_key'] ) ? trim( $q['meta_key'] ) : ''; + $meta_value = isset( $q['meta_value'] ) ? trim( $q['meta_value'] ) : ''; + $meta_compare = isset( $q['meta_compare'] ) ? $q['meta_compare'] : '='; - if ( empty( $meta_compare ) || !in_array( $meta_compare, array( '=', '!=', '>', '>=', '<', '<=', 'like' ) ) ) + if ( !in_array( $meta_compare, array( '=', '!=', '>', '>=', '<', '<=', 'like' ) ) ) $meta_compare = '='; if ( empty( $meta_key ) )