From ca3e65e20e3cdf1b03c1903783293f19a3358fa6 Mon Sep 17 00:00:00 2001 From: Dominik Schilling Date: Sun, 20 Sep 2015 08:59:24 +0000 Subject: [PATCH] Upgrader: Avoid using an HTML tag in a translation string, add translator comments. Props ramiy for initial patch. Fixes #31860. Built from https://develop.svn.wordpress.org/trunk@34352 git-svn-id: http://core.svn.wordpress.org/trunk@34316 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-admin/includes/class-wp-upgrader-skins.php | 12 ++++++++---- wp-includes/version.php | 2 +- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/wp-admin/includes/class-wp-upgrader-skins.php b/wp-admin/includes/class-wp-upgrader-skins.php index ad2cb89987..b0a5080b84 100644 --- a/wp-admin/includes/class-wp-upgrader-skins.php +++ b/wp-admin/includes/class-wp-upgrader-skins.php @@ -281,8 +281,11 @@ class Bulk_Upgrader_Skin extends WP_Upgrader_Skin { */ public function add_strings() { $this->upgrader->strings['skin_upgrade_start'] = __('The update process is starting. This process may take a while on some hosts, so please be patient.'); - $this->upgrader->strings['skin_update_failed_error'] = __('An error occurred while updating %1$s: %2$s'); + /* translators: 1: Title of an update, 2: Error message */ + $this->upgrader->strings['skin_update_failed_error'] = __('An error occurred while updating %1$s: %2$s'); + /* translators: 1: Title of an update */ $this->upgrader->strings['skin_update_failed'] = __('The update of %1$s failed.'); + /* translators: 1: Title of an update */ $this->upgrader->strings['skin_update_successful'] = __( '%1$s updated successfully.' ) . ' ' . __( 'Show Details' ) . ''; $this->upgrader->strings['skin_upgrade_end'] = __('All updates have been completed.'); } @@ -379,10 +382,11 @@ class Bulk_Upgrader_Skin extends WP_Upgrader_Skin { public function after($title = '') { echo '

'; if ( $this->error || ! $this->result ) { - if ( $this->error ) - echo '

' . sprintf($this->upgrader->strings['skin_update_failed_error'], $title, $this->error) . '

'; - else + if ( $this->error ) { + echo '

' . sprintf($this->upgrader->strings['skin_update_failed_error'], $title, '' . $this->error . '' ) . '

'; + } else { echo '

' . sprintf($this->upgrader->strings['skin_update_failed'], $title) . '

'; + } echo ''; } diff --git a/wp-includes/version.php b/wp-includes/version.php index f79bc3b821..7842e68a51 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -4,7 +4,7 @@ * * @global string $wp_version */ -$wp_version = '4.4-alpha-34351'; +$wp_version = '4.4-alpha-34352'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.