From caa75a04a85240f3f6159efe4497da5e6d9f0926 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Mon, 19 Oct 2020 22:45:03 +0000 Subject: [PATCH] Themes: Add a return value to `set_theme_mod()` to allow for error handling. Props latifi, hareesh-pillai. Fixes #51296. Built from https://develop.svn.wordpress.org/trunk@49214 git-svn-id: http://core.svn.wordpress.org/trunk@48976 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/theme.php | 8 +++++++- wp-includes/version.php | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/wp-includes/theme.php b/wp-includes/theme.php index a6ecad3ffe..8e8a5779d4 100644 --- a/wp-includes/theme.php +++ b/wp-includes/theme.php @@ -1038,9 +1038,11 @@ function get_theme_mod( $name, $default = false ) { * Updates theme modification value for the current theme. * * @since 2.1.0 + * @since 5.6.0 A return value was added. * * @param string $name Theme modification name. * @param mixed $value Theme modification value. + * @return bool True if the value was updated, false otherwise. */ function set_theme_mod( $name, $value ) { $mods = get_theme_mods(); @@ -1061,7 +1063,8 @@ function set_theme_mod( $name, $value ) { $mods[ $name ] = apply_filters( "pre_set_theme_mod_{$name}", $value, $old_value ); $theme = get_option( 'stylesheet' ); - update_option( "theme_mods_$theme", $mods ); + + return update_option( "theme_mods_$theme", $mods ); } /** @@ -1087,7 +1090,9 @@ function remove_theme_mod( $name ) { remove_theme_mods(); return; } + $theme = get_option( 'stylesheet' ); + update_option( "theme_mods_$theme", $mods ); } @@ -1104,6 +1109,7 @@ function remove_theme_mods() { if ( false === $theme_name ) { $theme_name = wp_get_theme()->get( 'Name' ); } + delete_option( 'mods_' . $theme_name ); } diff --git a/wp-includes/version.php b/wp-includes/version.php index fce2f8ab1c..0459d9639f 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -13,7 +13,7 @@ * * @global string $wp_version */ -$wp_version = '5.6-alpha-49213'; +$wp_version = '5.6-alpha-49214'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.