From d0a0c31b1f9b464fdd0c5831c3f9e046a340450f Mon Sep 17 00:00:00 2001 From: ryan Date: Thu, 30 Dec 2010 19:04:32 +0000 Subject: [PATCH] Clean up admin bar node removal. Make it PHP4 safe and prevent display of blank spots. Props sorich87, SergeyBiryukov. fixes #16005 git-svn-id: http://svn.automattic.com/wordpress/trunk@17184 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/class-wp-admin-bar.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/wp-includes/class-wp-admin-bar.php b/wp-includes/class-wp-admin-bar.php index dab409f905..1ede11e590 100644 --- a/wp-includes/class-wp-admin-bar.php +++ b/wp-includes/class-wp-admin-bar.php @@ -190,12 +190,12 @@ class WP_Admin_Bar { } function remove_node( $id, &$menu ) { - foreach( $menu as $menu_item_id => &$menu_item ) { - if ( $menu_item_id == $id ) { - $menu_item = null; - return true; - } + if ( isset( $menu->$id ) ) { + unset( $menu->$id ); + return true; + } + foreach( $menu as $menu_item_id => $menu_item ) { if ( ! empty( $menu->{$menu_item_id}['children'] ) ) $this->remove_node( $id, $menu->{$menu_item_id}['children'] ); }