Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2025-01-18 14:21:25 +01:00
Code Issues Projects Releases Wiki Activity

Users: prevent saving empty passwords, trim space from password ends on save.

Browse Source 
Fix an issue where users could save a password with only spaces, or spaces at the beginning or end of their password, preventing them from logging in.

Props ronakganatra, 1naveengiri, ajensen, oolleegg55, bookdude13, nrqsnchz, aristath.
Fixes #42766.


Built from https://develop.svn.wordpress.org/trunk@49118


git-svn-id: http://core.svn.wordpress.org/trunk@48880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Adam Silverstein 2020-10-10 16:51:07 +00:00
parent 3e10f5a7e8
commit e3d280ffd8
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
wp-admin/includes/user.php
View File

@ -47,10 +47,10 @@ function edit_user( $user_id = 0 ) {
$pass1 = ''; $pass1 = '';
$pass2 = ''; $pass2 = '';
if ( isset( $_POST['pass1'] ) ) { if ( isset( $_POST['pass1'] ) ) {
$pass1 = $_POST['pass1']; $pass1 = trim( $_POST['pass1'] );
} }
if ( isset( $_POST['pass2'] ) ) { if ( isset( $_POST['pass2'] ) ) {
$pass2 = $_POST['pass2']; $pass2 = trim( $_POST['pass2'] );
} }
if ( isset( $_POST['role'] ) && current_user_can( 'promote_users' ) && ( ! $user_id || current_user_can( 'promote_user', $user_id ) ) ) { if ( isset( $_POST['role'] ) && current_user_can( 'promote_users' ) && ( ! $user_id || current_user_can( 'promote_user', $user_id ) ) ) {

2
wp-admin/js/user-profile.js
View File

@ -215,7 +215,7 @@
var pass1 = $('#pass1').val(), strength; var pass1 = $('#pass1').val(), strength;
$('#pass-strength-result').removeClass('short bad good strong empty'); $('#pass-strength-result').removeClass('short bad good strong empty');
if ( ! pass1 ) { if ( ! pass1 || '' === pass1.trim() ) {
$( '#pass-strength-result' ).addClass( 'empty' ).html( ' ' ); $( '#pass-strength-result' ).addClass( 'empty' ).html( ' ' );
return; return;
} }

2
wp-admin/js/user-profile.min.js vendored
View File

File diff suppressed because one or more lines are too long

2
wp-includes/version.php
View File

@ -13,7 +13,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '5.6-alpha-49117'; $wp_version = '5.6-alpha-49118';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.