Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2025-01-11 02:49:04 +01:00
Code Issues Projects Releases Wiki Activity

Improve switching between browser and upload state.

Browse Source 
Props koopersmith
fixes #22628


git-svn-id: http://core.svn.wordpress.org/trunk@22945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Ryan Boren 2012-11-30 06:01:47 +00:00
parent 1e8f12020b
commit e656d19a30
2 changed files with 44 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
wp-includes/css/media-views.css
View File

@ -726,7 +726,8 @@
margin-top: 10px;
}
.attachments-browser .attachments {
.attachments-browser .attachments,
.attachments-browser .uploader-inline {
position: absolute;
top: 50px;
left: 0;
@ -931,7 +932,7 @@
display: block;
}
.region-content.uploader-inline {
.media-frame .uploader-inline {
margin: 20px;
padding: 20px;
text-align: center;
@ -1373,6 +1374,7 @@
}
.attachments-browser .attachments,
.attachments-browser .uploader-inline,
.attachments-browser .media-toolbar {
right: 180px;
}

77
wp-includes/js/media-views.js
View File

@ -262,6 +262,7 @@
describe: false,
toolbar: 'main-attachments',
sidebar: 'settings',
content: 'browse',
searchable: true,
filterable: false,
uploads: true
@ -304,19 +305,11 @@
selection.on( 'add remove reset', this.refreshSelection, this );
this._updateEmpty();
library.on( 'add remove reset', this._updateEmpty, this );
this.on( 'change:empty', this.refresh, this );
this.refresh();
this.on( 'insert', this._insertDisplaySettings, this );
},
deactivate: function() {
this.off( 'change:empty', this.refresh, this );
this.get('library').off( 'add remove reset', this._updateEmpty, this );
// Unbind all event handlers that use this state as the context
// from the selection.
this.get('selection').off( null, null, this );
@ -334,23 +327,7 @@
this.resetDisplays();
},
content: function() {
var frame = this.frame;
if ( this.get('empty') ) {
// Attempt to fetch any Attachments we don't already have.
this.get('library').more();
// In the meantime, render an inline uploader.
frame.content.mode('upload');
} else {
// Browse our library of attachments.
frame.content.mode('browse');
}
},
refresh: function() {
this.frame.$el.toggleClass( 'hide-toolbar', this.get('empty') );
this.content();
this.refreshSelection();
},
@ -389,17 +366,6 @@
setUserSetting( 'urlbutton', display.link );
},
_updateEmpty: function() {
var library = this.get('library'),
props = library.props;
// If we're filtering the library, bail.
if ( this.get('filterable') && ( props.get('type') || props.get('parent') ) )
return;
this.set( 'empty', ! library.length && ! library.props.get('search') );
},
refreshSelection: function() {
var selection = this.get('selection'),
mode = this.frame.content.mode();
@ -524,7 +490,8 @@
editing: false,
sortable: true,
searchable: false,
toolbar: 'gallery-edit'
toolbar: 'gallery-edit',
content: 'browse'
},
initialize: function() {
@ -1301,6 +1268,8 @@
browseContent: function() {
var state = this.state();
this.$el.removeClass('hide-toolbar');
// Browse our library of attachments.
this.content.view( new media.view.AttachmentsBrowser({
controller: this,
@ -3017,8 +2986,10 @@
});
this.createToolbar();
this.createAttachments();
this.updateContent();
this.createSidebar();
this.collection.on( 'add remove reset', this.updateContent, this );
},
dispose: function() {
@ -3066,7 +3037,39 @@
}
},
updateContent: function() {
var view = this;
if( ! this.attachments )
this.createAttachments();
if ( ! this.collection.length ) {
this.collection.more().done( function() {
if ( ! view.collection.length )
view.createUploader();
});
}
},
createUploader: function() {
if ( this.attachments ) {
this.attachments.remove();
delete this.attachments;
}
this.uploader = new media.view.UploaderInline({
controller: this.controller
});
this.views.add( this.uploader );
},
createAttachments: function() {
if ( this.uploader ) {
this.uploader.remove();
delete this.uploader;
}
this.attachments = new media.view.Attachments({
controller: this.controller,
collection: this.collection,