From e6dd5fbf4861b5120537bd1e6b64e113245be826 Mon Sep 17 00:00:00 2001 From: Andrew Ozz Date: Wed, 4 Dec 2013 04:13:11 +0000 Subject: [PATCH] Svg-painter: - Clean up the JS, better names, etc. - Convert the base64 encode/decode code from jQuery plugin to local use. - Add missing icon colors for the default theme. - Make it more error-proof. Fixes #26333. Built from https://develop.svn.wordpress.org/trunk@26601 git-svn-id: http://core.svn.wordpress.org/trunk@26491 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-admin/includes/misc.php | 8 +- wp-admin/js/user-profile.js | 13 +- wp-admin/js/user-profile.min.js | 2 +- wp-includes/general-template.php | 3 +- wp-includes/js/svg-painter.js | 268 +++++++++++++++--------------- wp-includes/js/svg-painter.min.js | 2 +- wp-includes/script-loader.php | 4 +- 7 files changed, 152 insertions(+), 148 deletions(-) diff --git a/wp-admin/includes/misc.php b/wp-admin/includes/misc.php index 641e2d4488..6f0ad5e40c 100644 --- a/wp-admin/includes/misc.php +++ b/wp-admin/includes/misc.php @@ -613,16 +613,16 @@ function admin_color_scheme_picker() { icon_colors ) ) { - echo '\n"; + if ( ! empty( $_wp_admin_css_colors[ $color_scheme ]->icon_colors ) ) { + echo '\n"; } } -add_action( 'admin_head', 'set_color_scheme_json' ); +add_action( 'admin_head', 'wp_color_scheme_settings' ); function _ipad_meta() { if ( wp_is_mobile() ) { diff --git a/wp-admin/js/user-profile.js b/wp-admin/js/user-profile.js index 0f1dbee38b..93574e2012 100644 --- a/wp-admin/js/user-profile.js +++ b/wp-admin/js/user-profile.js @@ -83,7 +83,8 @@ current_user_id = $( 'input[name="checkuser_id"]' ).val(); $colorpicker.on( 'click.colorpicker', '.color-option', function() { - var $this = $(this); + var colors, + $this = $(this); if ( $this.hasClass( 'selected' ) ) { return; @@ -99,8 +100,14 @@ // repaint icons if ( typeof window.svgPainter !== 'undefined' ) { - svgPainter.setColors( $.parseJSON( $this.children( '.icon_colors' ).val() ) ); - svgPainter.paint(); + try { + colors = $.parseJSON( $this.children( '.icon_colors' ).val() ); + } catch ( error ) {} + + if ( colors ) { + svgPainter.setColors( colors ); + svgPainter.paint(); + } } // update user option diff --git a/wp-admin/js/user-profile.min.js b/wp-admin/js/user-profile.min.js index 3da7771e78..4f292ae664 100644 --- a/wp-admin/js/user-profile.min.js +++ b/wp-admin/js/user-profile.min.js @@ -1 +1 @@ -!function(a){function b(){var b,c=a("#pass1").val(),d=a("#pass2").val();if(a("#pass-strength-result").removeClass("short bad good strong"),!c)return a("#pass-strength-result").html(pwsL10n.empty),void 0;switch(b=wp.passwordStrength.meter(c,wp.passwordStrength.userInputBlacklist(),d)){case 2:a("#pass-strength-result").addClass("bad").html(pwsL10n.bad);break;case 3:a("#pass-strength-result").addClass("good").html(pwsL10n.good);break;case 4:a("#pass-strength-result").addClass("strong").html(pwsL10n.strong);break;case 5:a("#pass-strength-result").addClass("short").html(pwsL10n.mismatch);break;default:a("#pass-strength-result").addClass("short").html(pwsL10n["short"])}}a(document).ready(function(){var c,d,e,f,g=a("#display_name");a("#pass1").val("").keyup(b),a("#pass2").val("").keyup(b),a("#pass-strength-result").show(),a(".color-palette").click(function(){a(this).siblings('input[name="admin_color"]').prop("checked",!0)}),g.length&&a("#first_name, #last_name, #nickname").bind("blur.user_profile",function(){var b=[],c={display_nickname:a("#nickname").val()||"",display_username:a("#user_login").val()||"",display_firstname:a("#first_name").val()||"",display_lastname:a("#last_name").val()||""};c.display_firstname&&c.display_lastname&&(c.display_firstlast=c.display_firstname+" "+c.display_lastname,c.display_lastfirst=c.display_lastname+" "+c.display_firstname),a.each(a("option",g),function(a,c){b.push(c.value)}),a.each(c,function(d,e){if(e){var f=e.replace(/<\/?[a-z][^>]*>/gi,"");c[d].length&&-1===a.inArray(f,b)&&(b.push(f),a("