From ea6ccb240cece59c57026bd7ff11a6437396c12e Mon Sep 17 00:00:00 2001 From: hellofromTonya Date: Thu, 30 Nov 2023 14:54:24 +0000 Subject: [PATCH] REST API: Restore site logo and icon in index. Restores setting the site's logo, icon, and wp-admin's back button image (which defaults to W). Prior to [56566], the site logo and icon were unconditionally added to the index. [56566] changed this by conditionally adding them if either the `_links` or `_embedded` fields were included. However, these fields are not included when using the Site Logo block, as it uses the `site_logo`, `site_icon`, and `site_icon_url` fields instead. This changeset restores the functionality by checking specifically for the `site_*` fields when neither of the `_links` or `_embedded` fields are present. Follow up to [56566]. Props antonvlasenko, hellofromTonya, ironprogrammer, priethor, wildworks. Fixes #59935. Built from https://develop.svn.wordpress.org/trunk@57147 git-svn-id: http://core.svn.wordpress.org/trunk@56658 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/rest-api/class-wp-rest-server.php | 7 +++++++ wp-includes/version.php | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/wp-includes/rest-api/class-wp-rest-server.php b/wp-includes/rest-api/class-wp-rest-server.php index eeb6575735..6838579ce8 100644 --- a/wp-includes/rest-api/class-wp-rest-server.php +++ b/wp-includes/rest-api/class-wp-rest-server.php @@ -1296,6 +1296,13 @@ class WP_REST_Server { $this->add_active_theme_link_to_index( $response ); $this->add_site_logo_to_index( $response ); $this->add_site_icon_to_index( $response ); + } else { + if ( rest_is_field_included( 'site_logo', $fields ) ) { + $this->add_site_logo_to_index( $response ); + } + if ( rest_is_field_included( 'site_icon', $fields ) || rest_is_field_included( 'site_icon_url', $fields ) ) { + $this->add_site_icon_to_index( $response ); + } } /** diff --git a/wp-includes/version.php b/wp-includes/version.php index 5f1b49f398..255dd662d5 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -16,7 +16,7 @@ * * @global string $wp_version */ -$wp_version = '6.5-alpha-57146'; +$wp_version = '6.5-alpha-57147'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.