Upstream
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Plugins: Output plugin card elements in the order they're displayed. 

Previously, the notice for listing dependencies in a plugin card was styled with the CSS `order` properties. This created a mismatch between the visual order and DOM order of elements in the plugin card.

For accessibility, visual order and DOM order must always match when they affect meaning and functionality.

This removes the CSS `order` properties and outputs the dependencies notice later, making the visual and DOM order match. Some unused/empty CSS is also removed.

Follow-up to [57545].

Props afercia, afragen, bosskhj, huzaifaalmesbah, mukesh27, costdev.
Fixes #60488.
Built from https://develop.svn.wordpress.org/trunk@57679


git-svn-id: http://core.svn.wordpress.org/trunk@57180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
costdev 2024-02-21 17:34:13 +00:00
parent a6c914d46b
commit f023a4a635
6 changed files with 4 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
wp-admin/css/list-tables-rtl.css
View File

@ -1592,14 +1592,6 @@ div.action-links,
margin-top: 0;
}
.plugin-card .column-description .authors {
order: 1;
}
.plugin-card .column-description .plugin-dependencies {
order: 2;
}
.plugin-card .column-description p:empty {
display: none;
}
@ -1645,8 +1637,6 @@ div.action-links,
.plugin-card .plugin-dependency-name {
flex-basis: 69%;
}
.plugin-card .plugin-dependency .more-details-link {
}
}
.plugins #the-list .required-by,

2
wp-admin/css/list-tables-rtl.min.css vendored
View File

File diff suppressed because one or more lines are too long

10
wp-admin/css/list-tables.css
View File

@ -1591,14 +1591,6 @@ div.action-links,
margin-top: 0;
}
.plugin-card .column-description .authors {
order: 1;
}
.plugin-card .column-description .plugin-dependencies {
order: 2;
}
.plugin-card .column-description p:empty {
display: none;
}
@ -1644,8 +1636,6 @@ div.action-links,
.plugin-card .plugin-dependency-name {
flex-basis: 69%;
}
.plugin-card .plugin-dependency .more-details-link {
}
}
.plugins #the-list .required-by,

2
wp-admin/css/list-tables.min.css vendored
View File

File diff suppressed because one or more lines are too long

3
wp-admin/includes/class-wp-plugin-install-list-table.php
View File

@ -525,8 +525,6 @@ class WP_Plugin_Install_List_Table extends WP_List_Table {
// Remove any HTML from the description.
$description = strip_tags( $plugin['short_description'] );
$description .= $this->get_dependencies_notice( $plugin );
/**
* Filters the plugin card description on the Add Plugins screen.
*
@ -675,6 +673,7 @@ class WP_Plugin_Install_List_Table extends WP_List_Table {
<p><?php echo $description; ?></p>
<p class="authors"><?php echo $author; ?></p>
</div>
<?php echo $this->get_dependencies_notice( $plugin ); ?>
</div>
<div class="plugin-card-bottom">
<div class="vers column-rating">

2
wp-includes/version.php
View File

@ -16,7 +16,7 @@
*
* @global string $wp_version
*/
$wp_version = '6.5-beta2-57678';
$wp_version = '6.5-beta2-57679';
/**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.