From f19b2b46354e52d1b7c5e2f3d63e1247a609b830 Mon Sep 17 00:00:00 2001 From: John Blackbourn Date: Wed, 29 Nov 2017 16:25:07 +0000 Subject: [PATCH] Hardening: Use a properly generated hash for the `newbloguser` key instead of a determinate substring. Merges [42258] to the 4.5 branch. Built from https://develop.svn.wordpress.org/branches/4.5@42280 git-svn-id: http://core.svn.wordpress.org/branches/4.5@42109 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-admin/user-new.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wp-admin/user-new.php b/wp-admin/user-new.php index 4239ed5fff..a5b554ed55 100644 --- a/wp-admin/user-new.php +++ b/wp-admin/user-new.php @@ -70,7 +70,7 @@ if ( isset($_REQUEST['action']) && 'adduser' == $_REQUEST['action'] ) { add_existing_user_to_blog( array( 'user_id' => $user_id, 'role' => $_REQUEST[ 'role' ] ) ); $redirect = add_query_arg( array( 'update' => 'addnoconfirmation' , 'user_id' => $user_id ), 'user-new.php' ); } else { - $newuser_key = substr( md5( $user_id ), 0, 5 ); + $newuser_key = wp_generate_password( 20, false ); add_option( 'new_user_' . $newuser_key, array( 'user_id' => $user_id, 'email' => $user_details->user_email, 'role' => $_REQUEST[ 'role' ] ) ); $roles = get_editable_roles();