Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-09-28 15:17:42 +02:00
Code Issues Projects Releases Wiki Activity

In wp_import_handle_upload():

Browse Source 
`$file` was essentially getting declared/overwritten 3 times. In lieu of this, return an array containing the error immediately instead of doing a short-circuit array key assignment on error. Rename the local variable to `$upload` and use its properties instead of creating 3 new local vars, one of which stomped the array.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@30980


git-svn-id: http://core.svn.wordpress.org/trunk@30966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Scott Taylor 2014-12-20 21:10:24 +00:00
parent 42f5acd869
commit f19bec8754
1 changed files with 15 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
wp-admin/includes/import.php
View File

@ -76,34 +76,32 @@ function wp_import_cleanup( $id ) {
* @return array Uploaded file's details on success, error message on failure * @return array Uploaded file's details on success, error message on failure
*/ */
function wp_import_handle_upload() { function wp_import_handle_upload() {
if ( !isset($_FILES['import']) ) { if ( ! isset( $_FILES['import'] ) ) {
$file['error'] = __( 'File is empty. Please upload something more substantial. This error could also be caused by uploads being disabled in your php.ini or by post_max_size being defined as smaller than upload_max_filesize in php.ini.' ); return array(
return $file; 'error' => __( 'File is empty. Please upload something more substantial. This error could also be caused by uploads being disabled in your php.ini or by post_max_size being defined as smaller than upload_max_filesize in php.ini.' )
);
} }
$overrides = array( 'test_form' => false, 'test_type' => false ); $overrides = array( 'test_form' => false, 'test_type' => false );
$_FILES['import']['name'] .= '.txt'; $_FILES['import']['name'] .= '.txt';
$file = wp_handle_upload( $_FILES['import'], $overrides ); $upload = wp_handle_upload( $_FILES['import'], $overrides );
if ( isset( $file['error'] ) ) if ( isset( $upload['error'] ) ) {
return $file; return $upload;
}
$url = $file['url'];
$type = $file['type'];
$file = $file['file'];
$filename = basename( $file );
// Construct the object array // Construct the object array
$object = array( 'post_title' => $filename, $object = array(
'post_content' => $url, 'post_title' => basename( $upload['file'] ),
'post_mime_type' => $type, 'post_content' => $upload['url'],
'guid' => $url, 'post_mime_type' => $upload['type'],
'guid' => $upload['url'],
'context' => 'import', 'context' => 'import',
'post_status' => 'private' 'post_status' => 'private'
); );
// Save the data // Save the data
$id = wp_insert_attachment( $object, $file ); $id = wp_insert_attachment( $object, $upload['file'] );
/* /*
* Schedule a cleanup for one day from now in case of failed * Schedule a cleanup for one day from now in case of failed
@ -111,7 +109,7 @@ function wp_import_handle_upload() {
*/ */
wp_schedule_single_event( time() + DAY_IN_SECONDS, 'importer_scheduled_cleanup', array( $id ) ); wp_schedule_single_event( time() + DAY_IN_SECONDS, 'importer_scheduled_cleanup', array( $id ) );
return array( 'file' => $file, 'id' => $id ); return array( 'file' => $upload['file'], 'id' => $id );
} }
/** /**