diff --git a/wp-admin/custom-header.php b/wp-admin/custom-header.php index 14d3472245..9d2be69d57 100644 --- a/wp-admin/custom-header.php +++ b/wp-admin/custom-header.php @@ -882,19 +882,11 @@ wp_nonce_field( 'custom-header-options', '_wpnonce-custom-header-options' ); ?> // Cleanup. $medium = str_replace( basename( $original ), 'midsize-' . basename( $original ), $original ); if ( file_exists( $medium ) ) { - /** - * Filter the path of the file to delete. - * - * @since 2.1.0 - * - * @param string $medium Path to the file to delete. - */ - @unlink( apply_filters( 'wp_delete_file', $medium ) ); + wp_delete_file( $medium ); } if ( empty( $_POST['create-new-attachment'] ) && empty( $_POST['skip-cropping'] ) ) { - /** This filter is documented in wp-admin/custom-header.php */ - @unlink( apply_filters( 'wp_delete_file', $original ) ); + wp_delete_file( $original ); } return $this->finished(); diff --git a/wp-admin/includes/image-edit.php b/wp-admin/includes/image-edit.php index 390465752f..5a82b4155f 100644 --- a/wp-admin/includes/image-edit.php +++ b/wp-admin/includes/image-edit.php @@ -616,10 +616,7 @@ function wp_restore_image($post_id) { // Delete only if it's edited image. if ( preg_match('/-e[0-9]{13}\./', $parts['basename']) ) { - - /** This filter is documented in wp-admin/custom-header.php */ - $delpath = apply_filters( 'wp_delete_file', $file ); - @unlink($delpath); + wp_delete_file( $file ); } } elseif ( isset( $meta['width'], $meta['height'] ) ) { $backup_sizes["full-$suffix"] = array('width' => $meta['width'], 'height' => $meta['height'], 'file' => $parts['basename']); @@ -642,9 +639,8 @@ function wp_restore_image($post_id) { // Delete only if it's edited image if ( preg_match('/-e[0-9]{13}-/', $meta['sizes'][$default_size]['file']) ) { - /** This filter is documented in wp-admin/custom-header.php */ - $delpath = apply_filters( 'wp_delete_file', path_join($parts['dirname'], $meta['sizes'][$default_size]['file']) ); - @unlink($delpath); + $delete_file = path_join( $parts['dirname'], $meta['sizes'][$default_size]['file'] ); + wp_delete_file( $delete_file ); } } else { $backup_sizes["$default_size-{$suffix}"] = $meta['sizes'][$default_size]; @@ -857,10 +853,7 @@ function wp_save_image( $post_id ) { } if ( $delete ) { - - /** This filter is documented in wp-admin/custom-header.php */ - $delpath = apply_filters( 'wp_delete_file', $new_path ); - @unlink( $delpath ); + wp_delete_file( $new_path ); } $return->msg = esc_js( __('Image saved') ); diff --git a/wp-includes/functions.php b/wp-includes/functions.php index 065bea6cce..b150598d27 100644 --- a/wp-includes/functions.php +++ b/wp-includes/functions.php @@ -4813,3 +4813,24 @@ function wp_validate_boolean( $var ) { return (bool) $var; } + +/** + * Delete a file + * + * @since 4.2.0 + * + * @param string $file The path to the file to delete. + */ +function wp_delete_file( $file ) { + /** + * Filter the path of the file to delete. + * + * @since 2.1.0 + * + * @param string $medium Path to the file to delete. + */ + $delete = apply_filters( 'wp_delete_file', $file ); + if ( ! empty( $delete ) ) { + @unlink( $delete ); + } +} diff --git a/wp-includes/post.php b/wp-includes/post.php index 04a6cb77a3..05f88cf2b9 100644 --- a/wp-includes/post.php +++ b/wp-includes/post.php @@ -4847,7 +4847,7 @@ function wp_delete_attachment( $post_id, $force_delete = false ) { // Don't delete the thumb if another attachment uses it. if (! $wpdb->get_row( $wpdb->prepare( "SELECT meta_id FROM $wpdb->postmeta WHERE meta_key = '_wp_attachment_metadata' AND meta_value LIKE %s AND post_id <> %d", '%' . $wpdb->esc_like( $meta['thumb'] ) . '%', $post_id)) ) { $thumbfile = str_replace(basename($file), $meta['thumb'], $file); - /** This filter is documented in wp-admin/custom-header.php */ + /** This filter is documented in wp-includes/functions.php */ $thumbfile = apply_filters( 'wp_delete_file', $thumbfile ); @ unlink( path_join($uploadpath['basedir'], $thumbfile) ); } @@ -4857,7 +4857,7 @@ function wp_delete_attachment( $post_id, $force_delete = false ) { if ( isset( $meta['sizes'] ) && is_array( $meta['sizes'] ) ) { foreach ( $meta['sizes'] as $size => $sizeinfo ) { $intermediate_file = str_replace( basename( $file ), $sizeinfo['file'], $file ); - /** This filter is documented in wp-admin/custom-header.php */ + /** This filter is documented in wp-includes/functions.php */ $intermediate_file = apply_filters( 'wp_delete_file', $intermediate_file ); @ unlink( path_join( $uploadpath['basedir'], $intermediate_file ) ); } @@ -4866,17 +4866,13 @@ function wp_delete_attachment( $post_id, $force_delete = false ) { if ( is_array($backup_sizes) ) { foreach ( $backup_sizes as $size ) { $del_file = path_join( dirname($meta['file']), $size['file'] ); - /** This filter is documented in wp-admin/custom-header.php */ + /** This filter is documented in wp-includes/functions.php */ $del_file = apply_filters( 'wp_delete_file', $del_file ); @ unlink( path_join($uploadpath['basedir'], $del_file) ); } } - /** This filter is documented in wp-admin/custom-header.php */ - $file = apply_filters( 'wp_delete_file', $file ); - - if ( ! empty($file) ) - @ unlink($file); + wp_delete_file( $file ); clean_post_cache( $post ); diff --git a/wp-includes/version.php b/wp-includes/version.php index 4f41878f7f..287a5b0d66 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -4,7 +4,7 @@ * * @global string $wp_version */ -$wp_version = '4.2-alpha-31574'; +$wp_version = '4.2-alpha-31575'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.