Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-05 10:22:23 +01:00
Code Issues Projects Releases Wiki Activity

Formatting: Introduce the document_title filter.

Browse Source 
In `wp_get_document_title(), the returned value is currently passed directly through `wptexturize()`, `convert_chars()`, and `capital_P_dangit()`, and is done so after the `document_title_parts` filter is run.

This makes it impossible to fully control the output of `wp_get_document_title()` and is inconsistent with how other similar text is processed with these functions.

This commit introduces the `document_title` filter, which is run immediately before returning the results of the `wp_get_document_title()` function and moves the three formatting functions mentioned above to the new filter hook. This allows developers to further modify the title after being prepared by WordPress, or to modify the functions hooked to this filter as they wish.

Props dragunoff, jeremyfelt, paaggeli, audrasjb.
Fixes #51643.
Built from https://develop.svn.wordpress.org/trunk@51019


git-svn-id: http://core.svn.wordpress.org/trunk@50628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
desrosj 2021-05-25 23:43:57 +00:00
parent 9c0dc03f90
commit f8947ceb0b
3 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
wp-includes/default-filters.php
View File

@ -131,14 +131,14 @@ foreach ( array( 'content_save_pre', 'excerpt_save_pre', 'comment_save_pre', 'pr
add_action( 'init', 'wp_init_targeted_link_rel_filters' ); add_action( 'init', 'wp_init_targeted_link_rel_filters' );
// Format strings for display. // Format strings for display.
foreach ( array( 'comment_author', 'term_name', 'link_name', 'link_description', 'link_notes', 'bloginfo', 'wp_title', 'widget_title' ) as $filter ) { foreach ( array( 'comment_author', 'term_name', 'link_name', 'link_description', 'link_notes', 'bloginfo', 'wp_title', 'document_title', 'widget_title' ) as $filter ) {
add_filter( $filter, 'wptexturize' ); add_filter( $filter, 'wptexturize' );
add_filter( $filter, 'convert_chars' ); add_filter( $filter, 'convert_chars' );
add_filter( $filter, 'esc_html' ); add_filter( $filter, 'esc_html' );
} }
// Format WordPress. // Format WordPress.
foreach ( array( 'the_content', 'the_title', 'wp_title' ) as $filter ) { foreach ( array( 'the_content', 'the_title', 'wp_title', 'document_title' ) as $filter ) {
add_filter( $filter, 'capital_P_dangit', 11 ); add_filter( $filter, 'capital_P_dangit', 11 );
} }
add_filter( 'comment_text', 'capital_P_dangit', 31 ); add_filter( 'comment_text', 'capital_P_dangit', 31 );

13
wp-includes/general-template.php
View File

@ -1238,10 +1238,15 @@ function wp_get_document_title() {
$title = apply_filters( 'document_title_parts', $title ); $title = apply_filters( 'document_title_parts', $title );
$title = implode( " $sep ", array_filter( $title ) ); $title = implode( " $sep ", array_filter( $title ) );
$title = wptexturize( $title );
$title = convert_chars( $title ); /**
$title = esc_html( $title ); * Filters the document title.
$title = capital_P_dangit( $title ); *
* @since 5.8.0
*
* @param string $title Document title.
*/
$title = apply_filters( 'document_title', $title );
return $title; return $title;
} }

2
wp-includes/version.php
View File

@ -13,7 +13,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '5.8-alpha-51018'; $wp_version = '5.8-alpha-51019';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.