Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2025-02-08 08:31:48 +01:00
Code Issues Projects Releases Wiki Activity

XMLRPC: Fix bugs in mw_editPost hilighted by tests in [UT593]

Browse Source 
* Feature image code did not actually set the feature image - See #18429
 * This api call could trash post data - Fixes #20321.


git-svn-id: http://svn.automattic.com/wordpress/trunk@20322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
westi 2012-03-29 11:59:51 +00:00
parent 944af3e88b
commit fabdd204c0
1 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
wp-includes/class-wp-xmlrpc-server.php
View File

@ -3975,8 +3975,11 @@ class wp_xmlrpc_server extends IXR_Server {
} }
} }
$post_title = isset( $content_struct['title'] ) ? $content_struct['title'] : null; if ( isset( $content_struct['title'] ) )
$post_content = isset( $content_struct['description'] ) ? $content_struct['description'] : null; $post_title = $content_struct['title'];
if ( isset( $content_struct['description'] ) )
$post_content = $content_struct['description'];
$post_category = array(); $post_category = array();
if ( isset( $content_struct['categories'] ) ) { if ( isset( $content_struct['categories'] ) ) {
@ -3988,8 +3991,11 @@ class wp_xmlrpc_server extends IXR_Server {
} }
} }
$post_excerpt = isset( $content_struct['mt_excerpt'] ) ? $content_struct['mt_excerpt'] : null; if ( isset( $content_struct['mt_excerpt'] ) )
$post_more = isset( $content_struct['mt_text_more'] ) ? $content_struct['mt_text_more'] : null; $post_excerpt = $content_struct['mt_excerpt'];
if ( isset( $content_struct['mt_text_more'] ) )
$post_more = $content_struct['mt_text_more'];
$post_status = $publish ? 'publish' : 'draft'; $post_status = $publish ? 'publish' : 'draft';
if ( isset( $content_struct["{$post_type}_status"] ) ) { if ( isset( $content_struct["{$post_type}_status"] ) ) {
@ -4060,13 +4066,12 @@ class wp_xmlrpc_server extends IXR_Server {
if ( isset($content_struct['custom_fields']) ) if ( isset($content_struct['custom_fields']) )
$this->set_custom_fields($post_ID, $content_struct['custom_fields']); $this->set_custom_fields($post_ID, $content_struct['custom_fields']);
if ( isset ( $post_data['wp_featured_image'] ) ) { if ( isset ( $content_struct['wp_featured_image'] ) ) {
// empty value deletes, non-empty value adds/updates // empty value deletes, non-empty value adds/updates
if ( empty( $post_data['wp_featured_image'] ) ) { if ( empty( $content_struct['wp_featured_image'] ) ) {
delete_post_thumbnail( $post_ID ); delete_post_thumbnail( $post_ID );
} } else {
else { if ( set_post_thumbnail( $post_ID, $content_struct['wp_featured_image'] ) === false )
if ( set_post_thumbnail( $post_ID, $post_data['wp_featured_image'] ) === false )
return new IXR_Error( 404, __( 'Invalid attachment ID.' ) ); return new IXR_Error( 404, __( 'Invalid attachment ID.' ) );
} }
unset( $content_struct['wp_featured_image'] ); unset( $content_struct['wp_featured_image'] );