mirror of
https://github.com/WordPress/WordPress.git
synced 2024-09-28 15:17:42 +02:00
Eliminate use of extract()
in wp_widget_rss_form()
.
See #22400. Built from https://develop.svn.wordpress.org/trunk@28449 git-svn-id: http://core.svn.wordpress.org/trunk@28276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
parent
463b7c4620
commit
fdaea6b7f2
@ -1106,24 +1106,23 @@ function wp_widget_rss_output( $rss, $args = array() ) {
|
|||||||
* @param array $inputs Override default display options.
|
* @param array $inputs Override default display options.
|
||||||
*/
|
*/
|
||||||
function wp_widget_rss_form( $args, $inputs = null ) {
|
function wp_widget_rss_form( $args, $inputs = null ) {
|
||||||
|
|
||||||
$default_inputs = array( 'url' => true, 'title' => true, 'items' => true, 'show_summary' => true, 'show_author' => true, 'show_date' => true );
|
$default_inputs = array( 'url' => true, 'title' => true, 'items' => true, 'show_summary' => true, 'show_author' => true, 'show_date' => true );
|
||||||
$inputs = wp_parse_args( $inputs, $default_inputs );
|
$inputs = wp_parse_args( $inputs, $default_inputs );
|
||||||
extract( $args );
|
|
||||||
extract( $inputs, EXTR_SKIP );
|
|
||||||
|
|
||||||
$number = esc_attr( $number );
|
$number = esc_attr( $args['number'] );
|
||||||
$title = esc_attr( $title );
|
$title = isset( $args['title'] ) ? esc_attr( $args['title'] ) : '';
|
||||||
$url = esc_url( $url );
|
$url = isset( $args['url'] ) ? esc_url( $args['url'] ) : '';
|
||||||
$items = (int) $items;
|
$items = isset( $args['items'] ) ? (int) $args['items'] : 0;
|
||||||
if ( $items < 1 || 20 < $items )
|
if ( $items < 1 || 20 < $items ) {
|
||||||
$items = 10;
|
$items = 10;
|
||||||
$show_summary = (int) $show_summary;
|
}
|
||||||
$show_author = (int) $show_author;
|
$show_summary = isset( $args['show_summary'] ) ? (int) $args['show_summary'] : (int) $inputs['show_summary'];
|
||||||
$show_date = (int) $show_date;
|
$show_author = isset( $args['show_author'] ) ? (int) $args['show_author'] : (int) $inputs['show_author'];
|
||||||
|
$show_date = isset( $args['show_date'] ) ? (int) $args['show_date'] : (int) $inputs['show_date'];
|
||||||
|
|
||||||
if ( !empty($error) )
|
if ( ! empty( $args['error'] ) ) {
|
||||||
echo '<p class="widget-error"><strong>' . sprintf( __('RSS Error: %s'), $error) . '</strong></p>';
|
echo '<p class="widget-error"><strong>' . sprintf( __( 'RSS Error: %s' ), $args['error'] ) . '</strong></p>';
|
||||||
|
}
|
||||||
|
|
||||||
if ( $inputs['url'] ) :
|
if ( $inputs['url'] ) :
|
||||||
?>
|
?>
|
||||||
|
Loading…
Reference in New Issue
Block a user