Commit Graph

74 Commits

Author SHA1 Message Date
desrosj
fb3fb535c7 Build/Test Tools: Backport GitHub Action and build improvements to the 4.4 branch.
This backports several build and test tool improvements to the 4.4 branch. Most notably, this includes:

- The changes required to allow each workflow to be triggered by the `workflow_dispatch` event so that tests can be run on a schedule [50590].
- Splitting single site and multisite tests into parallel jobs [50379].
- Split slow tests into separate, parallel jobs for PHP <= 5.6 [50444].
- Better branch and path scoping for GitHub Action workflows when running on `pull_request` [50432,50479].
- Several `devDependency` updates.

Merges [50379,50387,50416,50432,50435,50436,50444,50446,50473,50474,50476,50479,50485,50486,50487,50545,50579,50590] to the 4.4 branch.
See #50401, #51801, #51802, #52548, #52612, #52624, #52625, #52645, #52653, #52658, #52660, #52667.
Built from https://develop.svn.wordpress.org/branches/4.4@50639


git-svn-id: http://core.svn.wordpress.org/branches/4.4@50251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-02 15:43:22 +00:00
desrosj
a64be2cd83 Build/Test Tools: Support NodeJS 14.x in the 4.4 branch.
This updates the 4.4 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.

Because older branches use (really) old versions of NodeJS, the local Docker environment cannot be backported since the needed dependencies will not run on these older versions (see #48301). This also blocks the ability to move automated testing over to GitHub Actions (see #50401).

This also replaces the `npm-shrinkwrap.json` with a `package-lock.json` file. Lock files were not supported in earlier versions of NPM, but can now be used.

In addition to backporting the package updates that happened after branching 4.4, dependencies that were removed in future releases have also been updated to their latest versions.

Props desrosj, dd32, netweb, jorbin.
Merges [35859,35862,36860-36865,36935,36978-36979,37017,37019-37020,37212,37612,38111,38688,39110,39113-39119,39478,42460-42461,42463,42887,43320,43323,43977,44219,44233,44728,45321,45765,46404,46408-46409,47404,47867-47869,47872-47873,48705,49636,49933,49937,49939,50017,50126,50176,50185,50192] to the 4.4 branch.
See #52341.
Built from https://develop.svn.wordpress.org/branches/4.4@50210


git-svn-id: http://core.svn.wordpress.org/branches/4.4@49881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-05 04:23:43 +00:00
Aaron Jorbin
d507b5636f Set cssmin compatibility to ie7
This matches the autoprefixer setting. This changes all compiled CSS.

Fixes #34540.
Props christophherr, peterwilsoncc, netweb


Built from https://develop.svn.wordpress.org/trunk@35684


git-svn-id: http://core.svn.wordpress.org/trunk@35648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:28:25 +00:00
Aaron Jorbin
627844ca34 Bump grunt-contrib-cssmin to 0.14.0
This updates the underlying version of cssmin

Fixes #34177


Built from https://develop.svn.wordpress.org/trunk@35541


git-svn-id: http://core.svn.wordpress.org/trunk@35505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-05 17:58:28 +00:00
Helen Hou-Sandí
28c77bec72 RIP #21759b, the old WordPress Blue.
The final lingering instances were all for hidden accessibility helper text.

fixes #34388.

Built from https://develop.svn.wordpress.org/trunk@35340


git-svn-id: http://core.svn.wordpress.org/trunk@35306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 18:36:28 +00:00
Andrea Fercia
579246ab4a Multisite: Improve the Admin Bar parent menu items color on hover and focus.
Props Nikschavan for the initial patch.
Fixes #34040.
Built from https://develop.svn.wordpress.org/trunk@35265


git-svn-id: http://core.svn.wordpress.org/trunk@35231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 16:22:24 +00:00
Sergey Biryukov
e19cda5c2d Toolbar: Improve padding of toolbar submenu items on small screens.
Props tillkruess.
Fixes #28608.
Built from https://develop.svn.wordpress.org/trunk@35132


git-svn-id: http://core.svn.wordpress.org/trunk@35097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 07:40:25 +00:00
Scott Taylor
596431bd21 Admin Bar: fix the alignment of secondary menu item arrows.
Props juhise.
Fixes #33836.

Built from https://develop.svn.wordpress.org/trunk@35125


git-svn-id: http://core.svn.wordpress.org/trunk@35090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 03:54:24 +00:00
John Blackbourn
bc6af23302 Update links to the user profile editing screen in the admin toolbar when the current logged in user has no role on the current site. Covers single site and Multisite and introduces tests.
Fixes #25162

Built from https://develop.svn.wordpress.org/trunk@34122


git-svn-id: http://core.svn.wordpress.org/trunk@34090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 17:10:26 +00:00
Scott Taylor
d22fbc7545 Grunt RTL CSS: swap-dashicons-left-right-arrows in rtlcss:properties expects double-quoted content strings in CSS. It doesn't swap single-quoted values.
Props Ankit K Gupta, yoavf, netweb.
Fixes #33786.

Built from https://develop.svn.wordpress.org/trunk@34011


git-svn-id: http://core.svn.wordpress.org/trunk@33980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 20:22:25 +00:00
Sergey Biryukov
b4fbbf53cf Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/user-new.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33678. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33884


git-svn-id: http://core.svn.wordpress.org/trunk@33853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 08:46:52 +00:00
Helen Hou-Sandí
28c1600e6e Toolbar: Disambiguate links to the dashboard vs. to the customizer.
All links in the site name menu now point to admin screens, and Customize is its own top-level link. This makes it clear which context you are about to enter.

fixes #32924. see #32678.

Built from https://develop.svn.wordpress.org/trunk@33130


git-svn-id: http://core.svn.wordpress.org/trunk@33101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 20:03:24 +00:00
Helen Hou-Sandí
f85306c65a Toolbar: Allow submenus to be closed with a second tap on touch devices.
Also closes submenus when the admin menu is toggled open, as it opens below and thus can be obscured.

props stephdau, seanchayes.
see #29906.

Built from https://develop.svn.wordpress.org/trunk@33056


git-svn-id: http://core.svn.wordpress.org/trunk@33027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 03:29:25 +00:00
Aaron Jorbin
c9307fc95a Update Grunt dev-dependencies
grunt-browserify : minor version update
grunt-contrib-cssmin : minor version update
grunt-contrib-imagemin : patch version update
grunt-contrib-jshint : patch version update
grunt-contrib-uglify : minor version update (causes some changes to minified JS)
grunt-includes : minor version update
grunt-sass : major version update ( underlying libsass update ).

Props wonderboymusic
See #31700


Built from https://develop.svn.wordpress.org/trunk@32988


git-svn-id: http://core.svn.wordpress.org/trunk@32959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 14:51:30 +00:00
Helen Hou-Sandí
2636199e54 Toolbar: Search item consistency for focus state and IE8.
props afercia.
fixes #31322.

Built from https://develop.svn.wordpress.org/trunk@32074


git-svn-id: http://core.svn.wordpress.org/trunk@32053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 16:08:28 +00:00
Helen Hou-Sandí
bfda508c18 Update more instances of default admin blues and grays.
props hugobaeta.
fixes #31234.

Built from https://develop.svn.wordpress.org/trunk@32051


git-svn-id: http://core.svn.wordpress.org/trunk@32030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-05 21:20:27 +00:00
Helen Hou-Sandí
0d870b2d4e Toolbar: Protect against Firefox font rendering interference by themes.
props cbaldelomar.
fixes #30021.

Built from https://develop.svn.wordpress.org/trunk@31824


git-svn-id: http://core.svn.wordpress.org/trunk@31806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 22:04:27 +00:00
Helen Hou-Sandí
bcda24004a Update the default admin color scheme for more unity and refinement.
This removes the red channel from blues and cools the grays a bit for a more cohesive and purposeful color scheme.

props hugobaeta.
fixes #31234.

Built from https://develop.svn.wordpress.org/trunk@31422


git-svn-id: http://core.svn.wordpress.org/trunk@31403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 22:18:26 +00:00
Andrew Ozz
1e9f5755aa Admin toolbar: remove unneeded overrides of z-index and left on screens narrower than 782px. Props avryl, babbardel. Fixes #29867.
Built from https://develop.svn.wordpress.org/trunk@30764


git-svn-id: http://core.svn.wordpress.org/trunk@30754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 03:01:24 +00:00
Dominik Schilling
c2d9591122 Toolbar: Make Customize support classes work on narrow viewports too.
fixes #30571.
Built from https://develop.svn.wordpress.org/trunk@30713


git-svn-id: http://core.svn.wordpress.org/trunk@30703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 22:01:26 +00:00
John Blackbourn
a5fa87325b Don't fix the position of the admin toolbar submenus when the viewport is below 600px. This avoids them becoming detached from the admin toolbar when scrolling.
Fixes #29905
Props avryl

Built from https://develop.svn.wordpress.org/trunk@30706


git-svn-id: http://core.svn.wordpress.org/trunk@30696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 06:49:22 +00:00
Helen Hou-Sandí
06201646c3 Use a brighter blue against dark backgrounds in the admin menu and toolbar.
Not only does this pass contrast guidelines, but it also visually appears closer to the original highlight blue used against light backgrounds.

props melchoyce. fixes #30323.

Built from https://develop.svn.wordpress.org/trunk@30313


git-svn-id: http://core.svn.wordpress.org/trunk@30312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 20:28:22 +00:00
Dominik Schilling
de8961d631 Update the versions of several devDependencies in package.json.
Run `npm update` in the project root to receive updates.

props mjbanks, jorbin, netweb.
see #27340.
Built from https://develop.svn.wordpress.org/trunk@29270


git-svn-id: http://core.svn.wordpress.org/trunk@29052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 20:41:44 +00:00
Helen Hou-Sandí
2f399f18b7 Remove a toolbar CSS hack for a Chrome bug that no longer appears to exist. props avryl. fixes #28606. see #18868.
Built from https://develop.svn.wordpress.org/trunk@28981


git-svn-id: http://core.svn.wordpress.org/trunk@28770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-03 20:20:15 +00:00
Helen Hou-Sandí
3f1deae10b Don't use the box shadow focus styling for the admin menu or toolbar. see #28267.
Built from https://develop.svn.wordpress.org/trunk@28616


git-svn-id: http://core.svn.wordpress.org/trunk@28440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-29 14:23:15 +00:00
Sergey Biryukov
e269d48b99 Display Dashboard icon instead of the home icon in toolbar when the link leads to Dashboard.
props ghost1227.
fixes #26754.
Built from https://develop.svn.wordpress.org/trunk@28599


git-svn-id: http://core.svn.wordpress.org/trunk@28424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-28 13:42:14 +00:00
Andrew Nacin
11c3695c77 Dev/build tools: Use grunt-autoprefixer for CSS vendor prefixes.
We'll be using it for two distinct tasks:
 * Core CSS files will keep prefixes. `grunt autoprefixer:core` will update files directly in src/ as a pre-commit step, rather than doing it on build.
 * Color CSS files will receive prefixes when they are built.

This commit:
 * Adds prefixes we were missing to core CSS.
 * Removes prefixes that we no longer need from core CSS.
 * Removes all prefixes from colors CSS.

props ocean90.
fixes #27078.

Built from https://develop.svn.wordpress.org/trunk@27174


git-svn-id: http://core.svn.wordpress.org/trunk@27038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-13 08:30:17 +00:00
Scott Taylor
0347a8944e Update the versions of several devDependencies in package.json. grunt-cssjanus has been updated to 0.2.2, we no longer need the fork. Run npm install to receive updates for node_modules in the project root.
Props yoavf, TobiasBg.
Fixes #26073.


Built from https://develop.svn.wordpress.org/trunk@27053


git-svn-id: http://core.svn.wordpress.org/trunk@26927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-29 04:43:30 +00:00
Matt Thomas
7d002a5e84 Responsive improvements to submenus in the adminbar:
- Remove .ab-sub-wrapper rules in the 782px media query, as they're duplicates of the rules set on line 161.
- Reposition the arrows for submenus at responsive sizes where the menus are taller.
- Set the submenu position to static at smartphone sizes, so it's not positioned outside of its parent (and thus offscreen).

Fixes #26720, props undergroundnetwork, iammattthomas.



Built from https://develop.svn.wordpress.org/trunk@27006


git-svn-id: http://core.svn.wordpress.org/trunk@26883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 18:38:24 +00:00
Dominik Schilling
dea41019ef Dashicons: Update to the latest dashicons files.
props empireoflight, melchoyce.
see #26518 for trunk.
Built from https://develop.svn.wordpress.org/trunk@26925


git-svn-id: http://core.svn.wordpress.org/trunk@26806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-08 22:26:10 +00:00
Andrew Nacin
ee5fec7c6c Adjust widths of toolbar items at mobile sizes for better fitting on narrow screens. Fixes toolbar wrapping when using multisite.
props iammattthomas.
see #26537 for trunk.

Built from https://develop.svn.wordpress.org/trunk@26920


git-svn-id: http://core.svn.wordpress.org/trunk@26801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-08 21:24:12 +00:00
Andrew Ozz
448a401f77 Make older mobile browsers and IE7 usable:
- Text labels in the toolbar.
- Image icons in the visual editor.
- Some IE7 structural css fixes.
Fixes #26369.
Built from https://develop.svn.wordpress.org/trunk@26819


git-svn-id: http://core.svn.wordpress.org/trunk@26706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 02:41:10 +00:00
Andrew Nacin
1154c059ef RTL font-family overrides. (Tahoma generally, and Arial for Hebrew.)
props yoavf.
fixes #24977.

Built from https://develop.svn.wordpress.org/trunk@26816


git-svn-id: http://core.svn.wordpress.org/trunk@26703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 01:31:11 +00:00
Matt Thomas
4d48df2d58 Change the site menu icon from a globe to home, which is a better metaphor for what it does. Fixes #25971.
Built from https://develop.svn.wordpress.org/trunk@26812


git-svn-id: http://core.svn.wordpress.org/trunk@26699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 00:41:09 +00:00
Matt Thomas
01b1a66317 Make the padding added for top-level toolbar items in r26675 more specific and reinstate the previous 10px padding for links within dropdown menus. Fixes #26484.
Built from https://develop.svn.wordpress.org/trunk@26808


git-svn-id: http://core.svn.wordpress.org/trunk@26695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-08 20:44:10 +00:00
Andrew Ozz
f7c176ca46 Toolbar:
- Fix submenus in responsive mode (were ignoring the .hover class on a parent).
- Improve top level items hiding.
Fixes #26476.
Built from https://develop.svn.wordpress.org/trunk@26803


git-svn-id: http://core.svn.wordpress.org/trunk@26690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-08 17:15:11 +00:00
Matt Thomas
4d1b5e1c32 Comment out these touch-related styles as they break toolbar dropdowns in Chrome for Android. Fixes #25972.
Built from https://develop.svn.wordpress.org/trunk@26770


git-svn-id: http://core.svn.wordpress.org/trunk@26658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 04:59:13 +00:00
Matt Thomas
03ab0cc95f Provide a default generic avatar icon in the My Account menu if avatars are disabled, ensuring that the link is visible at responsive sizes. See #25858.
Built from https://develop.svn.wordpress.org/trunk@26744


git-svn-id: http://core.svn.wordpress.org/trunk@26633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 21:23:10 +00:00
Matt Thomas
c74da427f4 Add new fit-content rules to accompany intrinsic width on adminbar dropdown wrappers. Fixes #26430, props Jayjdk.
Built from https://develop.svn.wordpress.org/trunk@26735


git-svn-id: http://core.svn.wordpress.org/trunk@26624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 19:16:10 +00:00
Matt Thomas
c31444d1be Make toolbar dropdown submenu links tappable. See #25972, props ninnypants.
Built from https://develop.svn.wordpress.org/trunk@26716


git-svn-id: http://core.svn.wordpress.org/trunk@26605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 05:28:11 +00:00
Matt Thomas
4352cd7a12 At responsive sizes, remove the hard-coded fixed positioning for Comments and Add New in the toolbar. Make links slightly wider to better fill small-screen devices. Fixes #26432.
Built from https://develop.svn.wordpress.org/trunk@26710


git-svn-id: http://core.svn.wordpress.org/trunk@26599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 01:02:12 +00:00
Matt Thomas
6202106205 Un-hide dropdown submenus at responsive sizes, make submenus within dropdowns appear as inline lists at mobile device sizes. See #25972.
Built from https://develop.svn.wordpress.org/trunk@26687


git-svn-id: http://core.svn.wordpress.org/trunk@26577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 19:58:10 +00:00
Matt Thomas
8a2e7789f0 Allow dropdown lists to appear in responsive states; reset the minimum width of dropdowns at responsive sizes. See #26430.
Built from https://develop.svn.wordpress.org/trunk@26680


git-svn-id: http://core.svn.wordpress.org/trunk@26570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 18:38:12 +00:00
Matt Thomas
b711d6b347 By default, hide all adminbar links at responsive sizes and selectively un-hide just the essential core items. Fixes #26430.
Built from https://develop.svn.wordpress.org/trunk@26678


git-svn-id: http://core.svn.wordpress.org/trunk@26568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 18:28:11 +00:00
Matt Thomas
48f6631c4e Line up ALL the things:
* Make folded adminmenu icons line up with the W icon in the toolbar
* Make the W link in the toolbar the same width as the folded adminmenu
* Reduce padding on toolbar links to match reduced padding between W and Globe icons
* Reduce right-side padding on toolbar links to account for 1px of extra padding around icons on the left

See #25858.


Built from https://develop.svn.wordpress.org/trunk@26675


git-svn-id: http://core.svn.wordpress.org/trunk@26565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 18:03:10 +00:00
Matt Thomas
2bac800656 Correct the alignment of the W logo within its container. See #25858.
Built from https://develop.svn.wordpress.org/trunk@26670


git-svn-id: http://core.svn.wordpress.org/trunk@26560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 17:37:10 +00:00
Andrew Nacin
10f58cded3 Restore min-width for toolbar menus. This allows the menus to expand to the width of the element above them.
props nvwd.
fixes #26389.

Built from https://develop.svn.wordpress.org/trunk@26612


git-svn-id: http://core.svn.wordpress.org/trunk@26502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 17:00:10 +00:00
Matt Thomas
82540b9648 Add .ab-empty-item to the responsive adminbar sizing adjustments. Ensure that hidden text in responsive adminbar stays properly hidden in Firefox. See #26299.
Built from https://develop.svn.wordpress.org/trunk@26595


git-svn-id: http://core.svn.wordpress.org/trunk@26485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 21:53:10 +00:00
Matt Thomas
d64d9058c1 Changes to the mobile adminbar:
- Unhide the Edit link
- Hide the W menu link
- Hide the Updates link

This ensures that Network (when available), Site, Edit, Comments, New, and Account are always visible. Fixes #26071.


Built from https://develop.svn.wordpress.org/trunk@26575


git-svn-id: http://core.svn.wordpress.org/trunk@26466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 18:38:10 +00:00
Matt Thomas
32f55716df Give the adminbar Edit Post link an icon, and make it visible on small screen responsive states. See #26071.
Built from https://develop.svn.wordpress.org/trunk@26559


git-svn-id: http://core.svn.wordpress.org/trunk@26450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 17:25:10 +00:00