Upstream
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
34,157 Commits 48 Branches 718 Tags 906 MiB
Commit Graph

166 Commits

Author SHA1 Message Date
Aaron Campbell 1bed90114d Add nonce for widget accessibility mode. 
Props vortfu.

See #23328.

Merges [39760] to 4.5 branch.

Built from https://develop.svn.wordpress.org/branches/4.5@39763


git-svn-id: http://core.svn.wordpress.org/branches/4.5@39701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-01-11 01:44:31 +00:00
Andrea Fercia 62d8fda8dd After [36171] remove all the occurrences of the old CSS clearfix. 
The old clearfix was applied to very specific items and defined multiple times
across CSS files. Uses the new generic `.wp-clearfix` utility class instead.

See #26396.
Built from https://develop.svn.wordpress.org/trunk@36422


git-svn-id: http://core.svn.wordpress.org/trunk@36389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-30 13:46:27 +00:00
Dominik Schilling 23133b0b06 Widgets: Show the "Clear Inactive Widgets" button only after the sidebar with inactive widgets. 
Fixes #35447.
Built from https://develop.svn.wordpress.org/trunk@36368


git-svn-id: http://core.svn.wordpress.org/trunk@36335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-20 21:54:26 +00:00
Sergey Biryukov ff36a54824 Widgets: Add missing closing tag for spinner after [35317]. 
Props rabmalin.
Fixes #35150.
Built from https://develop.svn.wordpress.org/trunk@36001


git-svn-id: http://core.svn.wordpress.org/trunk@35966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-18 12:02:28 +00:00
Andrew Ozz 71ac079074 Widgets: add a button to delete all inactive widgets simultaneously for better UX. 
Props cdog.
Fixes #19159.
Built from https://develop.svn.wordpress.org/trunk@35317


git-svn-id: http://core.svn.wordpress.org/trunk@35283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-21 05:23:26 +00:00
Scott Taylor aa92c9555a Widgets: add a function, `is_registered_sidebar()` - helps us avoid touching the `$wp_registered_sidebars` global. 
Props GaryJ, wonderboymusic.
Fixes #24878.

Built from https://develop.svn.wordpress.org/trunk@35102


git-svn-id: http://core.svn.wordpress.org/trunk@35067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 01:33:25 +00:00
Andrea Fercia 6b449abadc Accessibility: bump headings one level up on the Appearance > Widgets screen for a better headings hierarchy. 
Props mrahmadawais, afercia.
Fixes #33659.
Built from https://develop.svn.wordpress.org/trunk@35015


git-svn-id: http://core.svn.wordpress.org/trunk@34980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 16:34:25 +00:00
Drew Jaynes 5ec1077a38 Widgets: Introduce a `delete_widget` action, which fires after a widget has been marked for deletion. 
Props afercia for the initial patch.
Fixes #27444.

Built from https://develop.svn.wordpress.org/trunk@34714


git-svn-id: http://core.svn.wordpress.org/trunk@34678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 03:21:26 +00:00
Drew Jaynes 783876bd1a Docs: The Widget API is singular. 
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34392


git-svn-id: http://core.svn.wordpress.org/trunk@34356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 12:28:27 +00:00
Scott Taylor f8d7a43920 Move `wp_widgets_access_body_class()` (a hook callback) from `wp-admin/widgets.php` to `wp-admin/includes/widgets.php`. 
See #33813.

Built from https://develop.svn.wordpress.org/trunk@34017


git-svn-id: http://core.svn.wordpress.org/trunk@33986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 21:22:23 +00:00
Sergey Biryukov c4ce11422c Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/widgets.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33680. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33886


git-svn-id: http://core.svn.wordpress.org/trunk@33855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 08:56:24 +00:00
Konstantin Obenland bd974d7bf2 Use a less element-specific class name for links within page titles. 
After [32974] these links are no longer within an `h2`, making the class name
inaccurate. `add-new-h1` has the potential to expose the same problem for in a
possible future change.

Fixes #31650.


Built from https://develop.svn.wordpress.org/trunk@33067


git-svn-id: http://core.svn.wordpress.org/trunk@33038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-03 16:42:24 +00:00
Konstantin Obenland 7dc1d06e64 Proper heading for admin screens. 
First step towards restoring a good heading structure in wp-admin.
The previous `<h1>` contained the site title and a link to the front page and was removed with the toolbar refactoring in 3.2.

Props joedolson, afercia.
Fixes #31650.


Built from https://develop.svn.wordpress.org/trunk@32974


git-svn-id: http://core.svn.wordpress.org/trunk@32945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 15:41:25 +00:00
Scott Taylor c6a4512b1b Add missing doc blocks to `wp-admin/includes/*`. 
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32654


git-svn-id: http://core.svn.wordpress.org/trunk@32624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 20:17:26 +00:00
Dominik Schilling 64fc7294b6 Use HTTPS URLs for codex.wordpress.org. 
see #27115.
Built from https://develop.svn.wordpress.org/trunk@32116


git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-12 21:29:32 +00:00
Helen Hou-Sandí d85f8fe326 Admin notices: Make (most) core notices dismissible. 
These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. This is particularly important on the post edit screen when DFW is triggered, but pretty much all notices can be dismissed if needed. A post on Make/Core will follow with information on how this can be leveraged in plugins.

props valendesigns, afercia, paulwilde, adamsilverstein, helen.
fixes #31233. see #23367.

Built from https://develop.svn.wordpress.org/trunk@31973


git-svn-id: http://core.svn.wordpress.org/trunk@31952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-01 22:06:28 +00:00
Scott Taylor bce851dcf2 Replace `array_shift()` with `reset()` where appropriate for performance. 
Props SergeyBiryukov.
Fixes #31259.

Built from https://develop.svn.wordpress.org/trunk@31829


git-svn-id: http://core.svn.wordpress.org/trunk@31811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-19 03:56:27 +00:00
Dominik Schilling 46f98473d1 Widgets: Add return param for widgets admin page to the "Manage in Customizer" link. 
props tywayne.
fixes #30888.
Built from https://develop.svn.wordpress.org/trunk@31420


git-svn-id: http://core.svn.wordpress.org/trunk@31401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-11 20:57:26 +00:00
Scott Taylor 7f8b548df1 In HTML5, the `action` attribute is no longer required. Remove this attribute when empty. 
The admin HTML is served with the HTML5 doctype.

"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces." 
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action

Props voldemortensen.
Fixes #30126.

Built from https://develop.svn.wordpress.org/trunk@31200


git-svn-id: http://core.svn.wordpress.org/trunk@31181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 04:16:24 +00:00
Dominik Schilling cffba3c1ba Customizer: Use deep-links for Backgrounds, Headers, and Widgets. 
Replace links in admin menu and toolbar to Custom Background/Header screen with deep-links to the Customizer section.
On the Widgets screen display a link to the Customizer widgets panel.

props topher1kenobe, rzen, celloexpressions, westonruter
fixes #25569, #25571, #28032.
Built from https://develop.svn.wordpress.org/trunk@30459


git-svn-id: http://core.svn.wordpress.org/trunk@30450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 15:29:23 +00:00
John Blackbourn d88ed475b0 Switch to a `403` response code in places where it is more appropriate than a `500` due to permissions errors. 
Fixes #10551
Props nacin

Built from https://develop.svn.wordpress.org/trunk@30356


git-svn-id: http://core.svn.wordpress.org/trunk@30355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-16 06:16:22 +00:00
Drew Jaynes 097dc8ee15 Fix syntax for single- and multi-line comments in wp-admin-directory files. 
See #28931.

Built from https://develop.svn.wordpress.org/trunk@29206


git-svn-id: http://core.svn.wordpress.org/trunk@28990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-17 09:14:16 +00:00
Drew Jaynes 5613b40981 The `sidebar_admin_setup` hook should only be documented once in wp-admin/widgets.php. All others are duplicates. 
See #25374, #25501, #27531.

Built from https://develop.svn.wordpress.org/trunk@27823


git-svn-id: http://core.svn.wordpress.org/trunk@27657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-28 19:47:15 +00:00
Andrew Nacin dce0b9adea Use SSL when linking to WordPress.org. see #27115. 
Built from https://develop.svn.wordpress.org/trunk@27469


git-svn-id: http://core.svn.wordpress.org/trunk@27314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-08 04:14:15 +00:00
Matt Thomas baefdf5bf8 Revert r26593 so Available and Inactive widgets are once again collapsible. Make the arrows only appear on hover when uncollapsed. Fixes #26327, props nacin. 
Built from https://develop.svn.wordpress.org/trunk@26608


git-svn-id: http://core.svn.wordpress.org/trunk@26498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-04 16:31:10 +00:00
Matt Thomas 26a22db98e Set Available and Inactive Widget areas to not collapse, since they don't look like collapsing elements. Fixes #26327, props MikeHansenMe. 
Built from https://develop.svn.wordpress.org/trunk@26593


git-svn-id: http://core.svn.wordpress.org/trunk@26483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-03 21:32:10 +00:00
Andrew Ozz 8d6059b383 Remove all screen_icon() calls and deprecate the functions, props TobiasBg, fixes #26119 
Built from https://develop.svn.wordpress.org/trunk@26518


git-svn-id: http://core.svn.wordpress.org/trunk@26411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-02 03:53:11 +00:00
Andrew Ozz db074f8e65 Widgets: improve the help text on the Widgets screen, props siobhan, props Hanni, fixes #26244. 
Built from https://develop.svn.wordpress.org/trunk@26505


git-svn-id: http://core.svn.wordpress.org/trunk@26399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-01 18:29:09 +00:00
Andrew Ozz f46e743343 Widgets: drop onto closed sidebars. 
- Make dropping a widget easier by preventing the source sidebar from resizing while the widget is being dragged.
- Move widgets dropped on closed sidebars to the top. UI Sortable places them randomly near the bottom.
- Fix possible regression in wp_list_widget_controls(), add an optional argument to output the sidebar name inside the sortable container.
- Updated styles for sidebar description and widget-hover class.
Part props shaunandrews, fixes #25952.
Built from https://develop.svn.wordpress.org/trunk@26426


git-svn-id: http://core.svn.wordpress.org/trunk@26326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-27 01:30:10 +00:00
Andrew Ozz c944323a4f Widgets: 
- Don't deactivate "draggable" on the widget when the chooser is open. Makes it possible to still drag the "widget-in-question".
- Change the chooser's HTML id to a class to avoid collisions when cloning.
- Refresh the "sortable" positions when an open widget is dragged. Fixes problems moving the widget up or down in the same sidebar.
See #25821
Built from https://develop.svn.wordpress.org/trunk@26366


git-svn-id: http://core.svn.wordpress.org/trunk@26267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-24 22:07:10 +00:00
Matt Thomas f26fea70c5 Making improvements to new styles added in the MP6 merge, and addressing visual feedback from core team. 
Improved and more consistent styling on the widgets & menus pages:

* Use the same visual treatment for both widgets and menus.
* Re-use existing styles from input:focus for draggable elements.
* Use the standard H3 size for widget area titles.
* Re-style the Widgets page drop zone to match drop zone from dashboard.
* Replace the gear icon on Widgets with the standard open/close arrows.
* Remove "Choose a sidebar" header from widget area chooser.

Make open/close arrows more consistent:

* Use the same arrow direction everywhere: pointing down when its container is closed, pointing up when open (following the Dashboard example).
* Set a consistent color for open/close arrows.
* Add a hover color for open/close arrows.
* Make open/close arrows permanently visible; :hover states don't exist on touch.

Make typography and color more consistent:

* Switch all declarations of #dedede to #ddd for simplicity's sake.
* Make H3s the same weight and color as H2s.
* Make select elements the same color as text inputs.
* Make paragraph text #444 so it doesn't look washed out on grey backgrounds.

General improvements:

* Eliminate the border between rows in settings tables.
* Make text and buttons line up in the Customizer.

See #25858.


Built from https://develop.svn.wordpress.org/trunk@26293


git-svn-id: http://core.svn.wordpress.org/trunk@26198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-20 22:48:09 +00:00
Andrew Ozz c39f333b06 Widgets: fix html for sidebars columns when the theme has only one sidebar. See #25952. 
Built from https://develop.svn.wordpress.org/trunk@26286


git-svn-id: http://core.svn.wordpress.org/trunk@26191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-20 05:09:10 +00:00
Andrew Ozz 30b1c76a01 Widgets: split the sidebars in two containers so there are no empty spaces when they are shown in two columns and some are open, other closed. See #25952. 
Built from https://develop.svn.wordpress.org/trunk@26285


git-svn-id: http://core.svn.wordpress.org/trunk@26190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-20 04:45:10 +00:00
Andrew Ozz c19660468b Widgets: move the chooser inside the selected widget so it inherits the width, add some keyboard shortcuts: tab to select, enter to append and escape to cancel. Props shaunandrews, see #25821 
Built from https://develop.svn.wordpress.org/trunk@26271


git-svn-id: http://core.svn.wordpress.org/trunk@26176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-19 18:03:09 +00:00
Andrew Ozz 753e745796 Merge the Widgets Area Chooser feature plugin. First run, see #25821 
Built from https://develop.svn.wordpress.org/trunk@26054


git-svn-id: http://core.svn.wordpress.org/trunk@25979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-08 23:05:10 +00:00
Andrew Nacin 70fd806759 Revert r25824:25875 from the core.svn.wordpress.org repository. 
These commits were accidentally re-synced commits from develop.svn.wordpress.org due to a race condition. Thankfully, the history of this repository matters fairly little. It also happened only for trunk.


git-svn-id: http://core.svn.wordpress.org/trunk@25876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-25 02:29:52 +00:00
Andrew Nacin 8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone. 
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-24 22:53:14 +00:00
Ryan Boren b87d4b77e5 Pinking shears 
Built from https://develop.svn.wordpress.org/trunk@25880


git-svn-id: http://core.svn.wordpress.org/trunk@25792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-23 14:38:10 +00:00
Drew Jaynes c100d28a25 Inline documentation for hooks in wp-admin/widgets.php. 
Props r3df, kpdesign.
Fixes #25501.

Built from https://develop.svn.wordpress.org/trunk@25734


git-svn-id: http://core.svn.wordpress.org/trunk@25647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-08 20:27:08 +00:00
Andrew Nacin fd57b239d2 Don't rely on include_path to include files. 
Always use dirname() or, once available, ABSPATH.

props ketwaroo, hakre.
fixes #17092.

Built from https://develop.svn.wordpress.org/trunk@25616


git-svn-id: http://core.svn.wordpress.org/trunk@25533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-25 00:18:11 +00:00
Sergey Biryukov a9cb64b537 Avoid 'Only variables should be passed by reference' notice on Widgets screen. props jdgrimes. fixes #25225. 
Built from https://develop.svn.wordpress.org/trunk@25226


git-svn-id: http://core.svn.wordpress.org/trunk@25196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-04 05:11:09 +00:00
Andrew Nacin 9bba27f4e5 Fix various typos and omissions across a number of help tabs. props DrewAPicture, Ipstenu. see #22451. 
git-svn-id: http://core.svn.wordpress.org/trunk@22812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-22 08:45:15 +00:00
Andrew Nacin 1acd8b556f New HiDPI spinner. Uses clean <span class="spinner"></span> markup. 
Be on the lookout for weirdness.
props lessbloat. see #21456.



git-svn-id: http://core.svn.wordpress.org/trunk@22019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-26 19:57:44 +00:00
Andrew Nacin 9f6fe3c4ff Don't show Appearance > Widgets if the theme has no sidebars defined. props SergeyBiryukov for the initial patch. fixes #21761. 
git-svn-id: http://core.svn.wordpress.org/trunk@21825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-12 02:16:46 +00:00
Andrew Ozz e00b17aac6 Replace the dark spinner with the light on the widgets screen and retire wpspin_dark.gif, props helenyhou and lessbloat, fixes #20957 
git-svn-id: http://core.svn.wordpress.org/trunk@21577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-22 02:02:37 +00:00
azaozz 618fdf1535 Widgets: ensure the "drop zone" matches the height of the Inactive Widgets container, fixes #21250 
git-svn-id: http://core.svn.wordpress.org/trunk@21270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-13 01:47:16 +00:00
azaozz 6aaf0dad43 Add the jQuery UI Touch Punch plugin to handle dragging on mobile devices, props georgestephanis, see #20014 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-11 02:20:51 +00:00
nacin ee72413797 Don't use esc_attr_e() function for a non-translatable context. props zeo. fixes #19479. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-08 17:56:03 +00:00
ryan 837d46fe67 Don't use a gettext function for a non-translatable context. Props nacin. fixes #19479 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-08 16:51:52 +00:00
ryan 6bba5a265b Pinking shears 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-01 04:51:35 +00:00