Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-14 22:56:19 +01:00
Code Issues Projects Releases Wiki Activity
36,795 Commits 50 Branches 748 Tags 792 MiB
4.8-branch
Commit Graph

16463 Commits

Author SHA1 Message Date
Weston Ruter
fd423f720e Widgets: Rename Text widget's legacy mode to non-visual mode, restore boolean filter prop, and improve compatibility for widget_text filters applied in Custom HTML widget. 
Merges [41132] onto 4.8 branch.
Amends [41050].
Props westonruter, obenland, timmydcrawford for testing.
See #35243, #40951, #40907.
Fixes #41394 for 4.8.1.

Built from https://develop.svn.wordpress.org/branches/4.8@41133


git-svn-id: http://core.svn.wordpress.org/branches/4.8@40973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-07-24 22:54:34 +00:00
Weston Ruter
ff0656e37c Widgets: Improve Text widget's reliability in syncing Visual tab's contents with Text tab and with hidden sync inputs. 
Merges [41094] onto 4.8 branch.
Amends [40631].
Props azaozz, westonruter, rinkuyadav999 for testing.
See #35243.
Fixes #40974 for 4.8.1.

Built from https://develop.svn.wordpress.org/branches/4.8@41095


git-svn-id: http://core.svn.wordpress.org/branches/4.8@40935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-07-19 20:51:33 +00:00
Weston Ruter
aef4b48187 Widgets: Check for existence of wp.customize.state before attempting to access in Text widget. 
Merges [41088] onto 4.8 branch.
Amends [40631].
See #35243.
Fixes #41361 for 4.8.1.

Built from https://develop.svn.wordpress.org/branches/4.8@41089


git-svn-id: http://core.svn.wordpress.org/branches/4.8@40929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-07-18 22:40:37 +00:00
Weston Ruter
e875520cec Widgets: Bump the TinyMCE panels' base z-index to 500001 so they show in the Customizer (such as in the Text widget). 
Merges [40990] and [40995] onto 4.8 branch.
Props greuben, westonruter.
Fixes #41158 for 4.8.1.

Built from https://develop.svn.wordpress.org/branches/4.8@41068


git-svn-id: http://core.svn.wordpress.org/branches/4.8@40920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-07-18 03:23:33 +00:00
Weston Ruter
d68bbe13cb TinyMCE: respect the Disable the visual editor when writing user setting and don't output the TinyMCE components when using wp_enqueue_editor(). 
Merges [40991] onto 4.8 branch.
Props azaozz.
Fixes #40960 for 4.8.1.

Built from https://develop.svn.wordpress.org/branches/4.8@41067


git-svn-id: http://core.svn.wordpress.org/branches/4.8@40919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-07-18 01:55:32 +00:00
Weston Ruter
3f4babe28b Customize: Restrict click target of menu deletion, moving to button from its container. 
Merges [41020] onto 4.8 branch.
Props westonruter, afercia.
Fixes #40981 for 4.8.1.

Built from https://develop.svn.wordpress.org/branches/4.8@41057


git-svn-id: http://core.svn.wordpress.org/branches/4.8@40907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-07-14 17:44:33 +00:00
Weston Ruter
d32185545b Widgets: Forcibly limit Video widget to only accept oEmbed URLs from YouTube and Vimeo (for now). 
Merges [40939] onto 4.8 branch.
Amends [40640].
Props timmydcrawford.
See #34115, #39994.
Fixes #40935 for 4.8.1.

Built from https://develop.svn.wordpress.org/branches/4.8@41056


git-svn-id: http://core.svn.wordpress.org/branches/4.8@40906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-07-14 17:41:32 +00:00
Weston Ruter
dbdd48e05e Customize: Restore right border on footer actions. 
Fixes regression introduced in [40511].

Merges [40896] onto 4.8 branch.
Props timmydcrawford.
See #32296.
Fixes #40978 for 4.8.1.

Built from https://develop.svn.wordpress.org/branches/4.8@41055


git-svn-id: http://core.svn.wordpress.org/branches/4.8@40905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-07-14 17:38:34 +00:00
Weston Ruter
c4ac9d0ade Widgets: Add legacy mode for Text widget and add usage pointers to default visual mode. 
The Text widget in legacy mode omits TinyMCE and retains old behavior for matching pre-existing Text widgets. Usage pointers added to default visual mode appear when attempting to paste HTML code into the Visual tab and when clicking on the Text tab, informing users of the new Custom HTML widget.

Merges [41050] to 4.8 branch.
Props westonruter, melchoyce, gitlost for testing, obenland for testing, dougal for testing, afercia for testing.
See #35243.
Fixes #40951 for 4.8.1.

Built from https://develop.svn.wordpress.org/branches/4.8@41053


git-svn-id: http://core.svn.wordpress.org/branches/4.8@40903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-07-14 17:28:32 +00:00
Weston Ruter
2e43bdea3e Widgets: Add accessibility mode support for TinyMCE-enhanced Text and Media widgets (Video, Audio, Images). 
Merges [40941] to 4.8 branch.
Amends [40640], [40631].
Props westonruter, afercia.
See #35243, #32417.
Fixes #40986 for 4.8.1.

Built from https://develop.svn.wordpress.org/branches/4.8@41051


git-svn-id: http://core.svn.wordpress.org/branches/4.8@40901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-07-14 17:17:33 +00:00
Sergey Biryukov
e88ec329f7 Accessibility: Avoid a keyboard trap on the permalink custom structure setting. 
Using the `focus` event on the permalink custom structure field made impossible
to navigate through all the form fields using only the keyboard without actually
selecting the custom structure setting. Instead, using click and input preserves
the original functionality when using any kind of pointing or input device.

Also changes `attr()` to `prop()` as recommended for a `checked` property.

Props afercia.
Fixes #40982.

Merges [40897] to the 4.8 branch.
Built from https://develop.svn.wordpress.org/branches/4.8@41024


git-svn-id: http://core.svn.wordpress.org/branches/4.8@40874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-07-10 23:16:32 +00:00
Sergey Biryukov
b59b5b9ab8 Comments: In WP_Comments_List_Table::extra_tablenav(), save the state of ::has_items() to a static variable, so that the value is consistent between top and bottom navigation. 
This prevents "Empty Spam" and "Empty Trash" buttons from disappearing if there's only one page of comments in Spam/Trash.

Fixes #40975.

Merges [41022] to the 4.8 branch.
Built from https://develop.svn.wordpress.org/branches/4.8@41023


git-svn-id: http://core.svn.wordpress.org/branches/4.8@40873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-07-10 23:09:34 +00:00
Aaron Jorbin
408dae699e About: Swap out images and videos for CDN versions, and add responsive images. 
Backports [40881] from trunk to 4.8.

Props: melchoyce, joemcgill, pento.

See #40721.


Built from https://develop.svn.wordpress.org/branches/4.8@40887


git-svn-id: http://core.svn.wordpress.org/branches/4.8@40737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-08 05:25:33 +00:00
Aaron Jorbin
0d820bf585 About Page: update CSS with prefixes 
Backports [40885] from trunk to 4.8.

Seconded by melchoyce.

See #40721.

Built from https://develop.svn.wordpress.org/branches/4.8@40886


git-svn-id: http://core.svn.wordpress.org/branches/4.8@40736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-08 04:53:32 +00:00
Dominik Schilling
439478f087 Upgrade: Add wp-includes/js/tinymce/plugins/wpembed to $_old_files. 
Merge of [40879] to the 4.8 branch.

See #39513, #40942.
Built from https://develop.svn.wordpress.org/branches/4.8@40880


git-svn-id: http://core.svn.wordpress.org/branches/4.8@40730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-07 21:36:33 +00:00
John Blackbourn
97dcac413f Build/Test Tools: Fix PHP 5.2 compatibility for grandchild methods which expect exceptions to be raised. 
This is due to `is_callable( 'parent::setExpectedException' )` not being supported on PHP 5.2 when the method being checked only exists on the grandparent class.

See #39822

Merges [40872] and [40873] to the 4.8 branch.

Built from https://develop.svn.wordpress.org/branches/4.8@40875


git-svn-id: http://core.svn.wordpress.org/branches/4.8@40725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-05 10:41:22 +00:00
Dominik Schilling
55497ccfd1 I18N: Improve translator comments for strings in the community events widget. 
Props dimadin, iandunn.
Fixes #40865.
Built from https://develop.svn.wordpress.org/trunk@40866


git-svn-id: http://core.svn.wordpress.org/trunk@40716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-01 09:49:42 +00:00
Dominik Schilling
7737e48a21 About: Sync tagline from about page with credits and freedoms. 
See #40721.
Built from https://develop.svn.wordpress.org/trunk@40865


git-svn-id: http://core.svn.wordpress.org/trunk@40715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-01 09:24:43 +00:00
Dominik Schilling
0e82284d87 Multisite: Revert indentation of the sample page content added in [40296]. 
Props swissspidy.
Fixes #40895.
Built from https://develop.svn.wordpress.org/trunk@40864


git-svn-id: http://core.svn.wordpress.org/trunk@40714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-01 09:16:40 +00:00
Mel Choyce
d69e67581f About: Finalize strings. 
Props: bridgetwillard, jenblogs4u, michelleweber, flixos90, johnbillion, francina, voldemortensen, melchoyce.
See #40721.

Built from https://develop.svn.wordpress.org/trunk@40863


git-svn-id: http://core.svn.wordpress.org/trunk@40713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-01 03:14:41 +00:00
Mel Choyce
69a7ab7d37 About: Add Link Boundary video and update poster image. 
See #40721.

Built from https://develop.svn.wordpress.org/trunk@40861


git-svn-id: http://core.svn.wordpress.org/trunk@40711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-31 18:02:44 +00:00
Mel Choyce
530577a670 About: Introduce design and add link to Media Widgets API dev note. 
Props: ryelle rclations melchoyce westonruter.
See #40721.

Built from https://develop.svn.wordpress.org/trunk@40849


git-svn-id: http://core.svn.wordpress.org/trunk@40700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-27 15:04:43 +00:00
Andrew Ozz
b015889bb8 About: Further polish for Under The Hood. 
Props: melchoyce apmarshall obenland. General props for the About page: hedgefield reportermike.
See #40721.
Built from https://develop.svn.wordpress.org/trunk@40841


git-svn-id: http://core.svn.wordpress.org/trunk@40692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-25 17:53:40 +00:00
Adam Silverstein
5f411ba353 Plugins: fix regression in search input field size. 
Fix a formatting regression introduced in [40792] which attempted to resize the input for mobile, see #40130.

Props leemon, juhise, voldemortensen.
Fixes #40857. 


Built from https://develop.svn.wordpress.org/trunk@40840


git-svn-id: http://core.svn.wordpress.org/trunk@40691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-25 15:22:42 +00:00
Konstantin Obenland
25c2b2cab7 About: Further polish for feature descriptions. 
Also adds Under The Hood content.

Props apmarshall, azaozz, iandunn, bridgetwillard, melchoyce.
See #40721.


Built from https://develop.svn.wordpress.org/trunk@40838


git-svn-id: http://core.svn.wordpress.org/trunk@40689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-25 15:11:42 +00:00
Weston Ruter
bb2e8b0d63 Widgets: Ensure that audio and video files appear in media library browser upon upload. 
Props timmydcrawford.
Amends [40640].
See #32417, #39994, #39995.
Fixes #40803.

Built from https://develop.svn.wordpress.org/trunk@40836


git-svn-id: http://core.svn.wordpress.org/trunk@40687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-25 03:20:41 +00:00
Weston Ruter
478d7730b6 Widgets: Prevent multiple items from being selectable when first populating a media widget. 
Amends [40640].
Props obenland, timmydcrawford.
See #32417.

Built from https://develop.svn.wordpress.org/trunk@40827


git-svn-id: http://core.svn.wordpress.org/trunk@40684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-24 05:31:42 +00:00
Adam Silverstein
5cc6c39430 Themes: improve browser history support on new themes page. 
When closing the theme preview, restore the previously selected tab. Avoid an issue where duplicate entries in the history prevented navigation. When re-opening the preview, remove bound event handlers before re-adding them.

Props afercia.
Fixes #36613.

Built from https://develop.svn.wordpress.org/trunk@40824


git-svn-id: http://core.svn.wordpress.org/trunk@40681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-23 20:32:44 +00:00
Andrea Fercia
3aabc09e9c Administration: Fix some HTML validation errors. 
Fixes some minor HTML issues in the admin and, most notably, changes the rel
attribute used in the List Tables from `rel="permalink"` to `rel="bookmark"`.

Props mihai2u, pento, arena, topher1kenobe, michalzuber, stubgo.
Fixes #37004.

Built from https://develop.svn.wordpress.org/trunk@40823


git-svn-id: http://core.svn.wordpress.org/trunk@40680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-23 17:58:43 +00:00
Sergey Biryukov
da0a505497 Administration: Update the docs for wp_check_browser_version(). 
Correct `update_url` key name, add missing `platform` key.

Props coffee2code.
Fixes #40839.
Built from https://develop.svn.wordpress.org/trunk@40822


git-svn-id: http://core.svn.wordpress.org/trunk@40679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-23 00:17:42 +00:00
Weston Ruter
6e935e7f20 Widgets: Further refine WP JS coding style in media widgets code. 
Props afercia.
See #32417.

Built from https://develop.svn.wordpress.org/trunk@40821


git-svn-id: http://core.svn.wordpress.org/trunk@40678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-22 22:05:42 +00:00
Dominik Schilling
24a7666e69 About: Remove a stray quotation mark. 
Props odysseygate.
See #40721.
Fixes #40837.
Built from https://develop.svn.wordpress.org/trunk@40814


git-svn-id: http://core.svn.wordpress.org/trunk@40672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-22 15:02:43 +00:00
Dominik Schilling
96549c5022 Widgets: Remove unused JS variable to fix JSHint error introduced in [40640]. 
See #39994.
Built from https://develop.svn.wordpress.org/trunk@40811


git-svn-id: http://core.svn.wordpress.org/trunk@40669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-20 09:45:42 +00:00
Weston Ruter
039397721e Widgets: Introduce isHostedVideo method on VideoWidgetControl to allow plugins to extend for recognizing services beyond YouTube and Vimeo. 
Also update jshint configuration in Gruntfile to include the widget scripts among the JS files linted.

Props timmydcrawford.
See #39994.
Fixes #40808.

Built from https://develop.svn.wordpress.org/trunk@40810


git-svn-id: http://core.svn.wordpress.org/trunk@40668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-20 04:18:41 +00:00
Sergey Biryukov
2c5e9a34b2 Dashboard: Change the cache key for dashboard RSS widget; remove the unnecessary database upgrade routine. 
Props iandunn, ocean90.
See #40702.
Built from https://develop.svn.wordpress.org/trunk@40803


git-svn-id: http://core.svn.wordpress.org/trunk@40661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-19 19:14:42 +00:00
Sergey Biryukov
a2788b09d5 Dashboard: Append the current locale to dashboard RSS widget cache key in wp_dashboard_rss_control(), for consistency with the changes to wp_dashboard_cached_rss_widget() in [33183] and [33192]. 
See #32804, #40702.
Built from https://develop.svn.wordpress.org/trunk@40802


git-svn-id: http://core.svn.wordpress.org/trunk@40660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-19 19:00:44 +00:00
Joe McGill
7d43d71800 Media: Ensure WP_Screen sets post type on wp-admin/upload.php. 
The post type property is set to 'attachment' when on the upload screen.

Props postpostmodern.
Fixes #39509.

Built from https://develop.svn.wordpress.org/trunk@40800


git-svn-id: http://core.svn.wordpress.org/trunk@40658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-19 18:29:42 +00:00
Andrea Fercia
1a8f7ab144 Dashboard: Don't trigger an Events search when the search field is empty. 
Fixes #40816.

Built from https://develop.svn.wordpress.org/trunk@40799


git-svn-id: http://core.svn.wordpress.org/trunk@40657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-19 17:27:43 +00:00
Konstantin Obenland
92642624fd About: Optimize strings for l10n 
Uses html entities for quotes and adds translator comment for event links.

Props ocean90.
See #40721.


Built from https://develop.svn.wordpress.org/trunk@40798


git-svn-id: http://core.svn.wordpress.org/trunk@40656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-19 16:45:44 +00:00
Andrea Fercia
e008a5c7db Themes: Improve the theme installer Favorites and Feature Filter tabs alignment. 
Props nitin kevadiya, darshan02, mp518.
Fixes #40315.

Built from https://develop.svn.wordpress.org/trunk@40797


git-svn-id: http://core.svn.wordpress.org/trunk@40655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-19 16:18:41 +00:00
Konstantin Obenland
359cc45e08 Docs: Improve inline docs for inlineEditPost. 
Props jjcomack, rensw90.
Fixes #39823.

Built from https://develop.svn.wordpress.org/trunk@40796


git-svn-id: http://core.svn.wordpress.org/trunk@40654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-19 15:45:42 +00:00
Andrea Fercia
36d25d3960 Dashboard: Improve the Events widget spinner position after [40789]. 
Props iandunn.
Fixes #40735.

Built from https://develop.svn.wordpress.org/trunk@40794


git-svn-id: http://core.svn.wordpress.org/trunk@40652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-19 14:44:41 +00:00
Dominik Schilling
97e98a80f6 Dashboard: Use get_user_locale() for the news feed cache key. 
Since the feed URL can be localized the cache key has to be built with the same locale as the current user is using.

Props iandunn.
Fixes #40417.
Built from https://develop.svn.wordpress.org/trunk@40793


git-svn-id: http://core.svn.wordpress.org/trunk@40651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-19 14:36:42 +00:00
Adam Silverstein
5ddd3f92e8 Media: make search input full width on mobile. 
Props abhishekfdd.
Fixes #40130.

Built from https://develop.svn.wordpress.org/trunk@40792


git-svn-id: http://core.svn.wordpress.org/trunk@40650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-19 13:45:42 +00:00
Konstantin Obenland
34e2a6110e About: Let's get a headstart on 4.8 about strings 
Strings have been reviewed and are ready for translation—design will come soon.

Props bridgetwillard, jenblogs4u, michelleweber, ryelle, melchoyce.
See #40721.


Built from https://develop.svn.wordpress.org/trunk@40791


git-svn-id: http://core.svn.wordpress.org/trunk@40649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-19 11:55:44 +00:00
Andrew Ozz
7a9ce6d03f Dashboard: Improve the handling of locations determined by geolocating the IP address and by entering a city name. Fix couple of edge cases, and some names. 
Props iandunn coreymckrill.
Fixes #40702.
Built from https://develop.svn.wordpress.org/trunk@40790


git-svn-id: http://core.svn.wordpress.org/trunk@40648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-19 05:48:42 +00:00
Andrew Ozz
daab579a88 Dashboard: 
- Close the form after obtaining a valid location.
- Fix focusing the toggle button after closing the form.
- Fix aria attribute values.
- Fix positions in IE11.
- Some JS and CSS cleanup.

Props afercia, coreymckrill.
Fixes #40735.
Built from https://develop.svn.wordpress.org/trunk@40789


git-svn-id: http://core.svn.wordpress.org/trunk@40647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-19 04:01:41 +00:00
Weston Ruter
bd990d7c4e Docs: Add missing @since tags and phpdoc descriptions to the Custom_Image_Header class. 
Amends [27497].
Props tejas5989, riddhiehta02, westonruter.
See #21785.
Fixes #40231.

Built from https://develop.svn.wordpress.org/trunk@40788


git-svn-id: http://core.svn.wordpress.org/trunk@40646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-19 03:53:43 +00:00
Andrew Ozz
d7c37de2de Editor: When stripping paragraph tags, and there is a <br> at the beginning or the end, merge them and keep the paragraph, not the <br>. 
Props rellect.
Fixes #37066.
Built from https://develop.svn.wordpress.org/trunk@40787


git-svn-id: http://core.svn.wordpress.org/trunk@40645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-18 22:55:42 +00:00
Weston Ruter
e62f6ac8fe Widgets: Ensure title field for media widget will update with sanitized value after change event in addition to input event. 
Aligns behavior of field with Text widget and other widgets whereby the server-sanitized title (via the `widget-update` request) is supplied into the field after the `change` event.

See #32417.
Fixes #40805.

Built from https://develop.svn.wordpress.org/trunk@40785


git-svn-id: http://core.svn.wordpress.org/trunk@40643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-18 21:04:41 +00:00
Konstantin Obenland
8ef02e5ec7 Dashboard: Combine methods to retreive IP 
They're only used in one place, no reason to be so verbose about it.

See #40702.

Built from https://develop.svn.wordpress.org/trunk@40781


git-svn-id: http://core.svn.wordpress.org/trunk@40639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-18 17:34:42 +00:00
Jeremy Felt
fd63ede892 Multisite: Handle both role change selections in site-users.php. 
Previously, a role selected below the list table would not apply on save. This aligns the behavior with `wp-admin/users.php` and allows role changes from both selections, deferring to the bottom selection when both are populated.

Props desrosj.
Fixes #40113.

Built from https://develop.svn.wordpress.org/trunk@40780


git-svn-id: http://core.svn.wordpress.org/trunk@40638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-18 17:08:43 +00:00
Andrea Fercia
591f423132 Administration: Use consistent spacing for form elements in the Discussion Settings screen. 
Props sagarjadhav.
Fixes #31594.

Built from https://develop.svn.wordpress.org/trunk@40779


git-svn-id: http://core.svn.wordpress.org/trunk@40637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-18 15:55:44 +00:00
John Blackbourn
64d65f007d Login and Registration: Add some margin to notices on the login screen so multiple notices remain separated. 
Fixes #39971

Built from https://develop.svn.wordpress.org/trunk@40778


git-svn-id: http://core.svn.wordpress.org/trunk@40636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-18 15:40:41 +00:00
Konstantin Obenland
83187e8ea0 Dashboard: Document request proxy for events. 
Documents the reason why the request is proxied through WP, instead of being
made directly to api.wordpress.org.

Props iandunn, michelleweber.
See #40702.


Built from https://develop.svn.wordpress.org/trunk@40777


git-svn-id: http://core.svn.wordpress.org/trunk@40635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-18 14:44:43 +00:00
Konstantin Obenland
9bbbc719d4 Dashboard: Properly localize data for events 
Moves localization to script-loader and removes dependency for two strings.

Props dd32, iandunn.
See #40702.

Built from https://develop.svn.wordpress.org/trunk@40776


git-svn-id: http://core.svn.wordpress.org/trunk@40634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-18 14:34:43 +00:00
Konstantin Obenland
7cae389acc Dashboard: Always pass the IP when getting events 
Allows the API to determine event locations more accurately.

Props iandunn.
See #40702.

Built from https://develop.svn.wordpress.org/trunk@40774


git-svn-id: http://core.svn.wordpress.org/trunk@40632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-18 07:31:43 +00:00
Konstantin Obenland
71adf97a35 Upgrade: Use correct commit no. to trigger upgrade 
Props iandunn.
See [40607], #40702.

Built from https://develop.svn.wordpress.org/trunk@40773


git-svn-id: http://core.svn.wordpress.org/trunk@40631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-17 22:03:46 +00:00
Weston Ruter
764d8b521f Media: Trim whitespace in URLs provided for external embeds. 
Also avoid showing error notice in media widget when URL field is empty.

Props timmydcrawford, westonruter.
Fixes #40771.

Built from https://develop.svn.wordpress.org/trunk@40772


git-svn-id: http://core.svn.wordpress.org/trunk@40630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-17 01:59:42 +00:00
Aaron Campbell
38347d7c58 Add nonce for updating file system credentials. 
Built from https://develop.svn.wordpress.org/trunk@40723


git-svn-id: http://core.svn.wordpress.org/trunk@40581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-16 14:48:44 +00:00
Dominik Schilling
3d10fef22d Customize: Igore invalid customization sessions. 
Built from https://develop.svn.wordpress.org/trunk@40704


git-svn-id: http://core.svn.wordpress.org/trunk@40567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-16 12:07:43 +00:00
Mel Choyce
66d3a486f6 Plugins: Fix plugin name display on Chrome 58 and above. 
On Chrome 58 and above, plugin names within the plugin details modal were collapsed down into an ellipsis. This fix rewrites the CSS to make sure the titles are always shown.

Props mrwweb, afercia, Presskopp.
Fixes #40579.

Built from https://develop.svn.wordpress.org/trunk@40672


git-svn-id: http://core.svn.wordpress.org/trunk@40535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-15 20:13:42 +00:00
Weston Ruter
9cb2cbc26f Customize: Fix alignment of natural-width media buttons in site icon control. 
Amends [40653].
Props afercia.
Fixes #40220.

Built from https://develop.svn.wordpress.org/trunk@40671


git-svn-id: http://core.svn.wordpress.org/trunk@40534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-15 18:51:41 +00:00
Weston Ruter
8a29b28a98 Widgets: Prevent image title attribute from being populated from attachment title by default upon selection. 
Props westonruter, timmydcrawford.
See #39993.

Built from https://develop.svn.wordpress.org/trunk@40670


git-svn-id: http://core.svn.wordpress.org/trunk@40533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-15 18:42:44 +00:00
Konstantin Obenland
68588821c3 Dashboard: Community events formatting improvements 
Props Soean.
See #40702.

Built from https://develop.svn.wordpress.org/trunk@40669


git-svn-id: http://core.svn.wordpress.org/trunk@40532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-15 09:44:43 +00:00
Rachel Baker
580cf33c81 Taxonomy: Remove extraneous ' included in Term delete markup. 
Unmatched single quotation mark after the delete link href was introduced in r40655.

Props Chouby.
Fixes #9777.

Built from https://develop.svn.wordpress.org/trunk@40668


git-svn-id: http://core.svn.wordpress.org/trunk@40531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-14 19:50:44 +00:00
Weston Ruter
3ce794812d Widgets: Fix deferred rendering of controls for media widgets until container element fully expands. 
Adds omitted call to `renderWhenAnimationDone()` which was missed when this code was copied from the Text widget.

Amends [40656].
See #40750.

Built from https://develop.svn.wordpress.org/trunk@40660


git-svn-id: http://core.svn.wordpress.org/trunk@40523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-12 22:01:42 +00:00
Adam Silverstein
cb2eac9e06 Users: Update name in toolbar when changing user display name. 
When changing the user name in Users -> Your Profile, update the name displayed in the toolbar dynamically using JavaScript.

Props menakas, lukecavanagh, maguiar.
Fixes #40342.


Built from https://develop.svn.wordpress.org/trunk@40657


git-svn-id: http://core.svn.wordpress.org/trunk@40520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-12 20:06:42 +00:00
Weston Ruter
020ffded1a Widgets: Defer rendering controls for media widgets until container element fully expands. 
Fixes issue with MediaElement.js failing to build the player in an animating container that doesn't have established dimensions.
Also utilizes MediaElement.js for the video widget instead of using a native player.

See #32417.
Fixes #40750.

Built from https://develop.svn.wordpress.org/trunk@40656


git-svn-id: http://core.svn.wordpress.org/trunk@40519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-12 19:56:43 +00:00
Adam Silverstein
d1ec180619 Taxonomy: Add a "delete" button on term edit page. 
Add a 'delete' link next to the update button on the term edit screen so you can delete a term while you are reviewing it's details. 

Props cklosows, bradt, ocean90, johnbillion, DrewAPicture, ryan, MatheusGimenez, maguiar.
Fixes #9777.


Built from https://develop.svn.wordpress.org/trunk@40655


git-svn-id: http://core.svn.wordpress.org/trunk@40518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-12 19:26:41 +00:00
Andrea Fercia
705ecf3312 Customize: Make the media control buttons natural-width. 
Natural-width buttons are better for translations, and don't feel as
overpowering as the half-width (and full-width) buttons.

Props melchoyce, timmydcrawford, afercia.
Fixes #40220.

Built from https://develop.svn.wordpress.org/trunk@40653


git-svn-id: http://core.svn.wordpress.org/trunk@40516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-12 17:50:44 +00:00
Konstantin Obenland
7328d561b1 Dashboard: Persist location for community events 
Fixes a bug where cached events & location data was not accessible because the
cache key could not be regenerated without latitude and longitude information.

Discovered and fixed during #wcber contributor day.

Props soean, kubik-rubik, obenland.
See #40702.
 

Built from https://develop.svn.wordpress.org/trunk@40651


git-svn-id: http://core.svn.wordpress.org/trunk@40514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-12 15:53:46 +00:00
Andrea Fercia
8a07db035d Add missing semicolons after [40646]. 
See #40453.

Built from https://develop.svn.wordpress.org/trunk@40648


git-svn-id: http://core.svn.wordpress.org/trunk@40511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-12 07:05:41 +00:00
Andrea Fercia
55b6ee7e56 Media: Clean-up some MediaElementJS CSS: no more needed after [40642]. 
See #40707, #32417, #39994, #39995, #30281.

Built from https://develop.svn.wordpress.org/trunk@40647


git-svn-id: http://core.svn.wordpress.org/trunk@40510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-12 07:00:45 +00:00
Andrea Fercia
bab7eb143e Accessibility: Change the "Show details" links in the update core screen to buttons. 
These controls toggle the visibility of the update progress: they perform an action
therefore they should be buttons. Also:
- uses `aria-expanded` to communicate the toggle button state
- removes some inline JavaScript
- when clicking the toggle buttons, the progress details get moved with JavaScript after the button: this helps users of assistive technologies in finding them and makes the UI a bit more intuitive

Props Cheffheid, afercia.
See #26504.
Fixes #40453.

Built from https://develop.svn.wordpress.org/trunk@40646


git-svn-id: http://core.svn.wordpress.org/trunk@40507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-11 23:50:41 +00:00
Andrea Fercia
274596b8ef Accessibility: Add "(opens in a new window)" screen reader text to the "News-Nearby Events" dashboard widget footer links. 
- standardizes similar messages in core to always use `(opens in a new window)`
- adds translators comments
- hides the dashicons with `aria-hidden="true"`, see #40428

Fixes #40733.

Built from https://develop.svn.wordpress.org/trunk@40643


git-svn-id: http://core.svn.wordpress.org/trunk@40504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-11 22:47:41 +00:00
Weston Ruter
26a5058f43 Widgets: Utilize WP REST API oEmbed proxy endpoint in media widgets. 
Props timmydcrawford.
See #32417, #40450.

Built from https://develop.svn.wordpress.org/trunk@40641


git-svn-id: http://core.svn.wordpress.org/trunk@40502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-11 21:24:42 +00:00
Weston Ruter
31d4d81039 Widgets: Introduce media widgets for images, audio, and video with extensible base for additional media widgets in the future. 
The last time a new widget was introduced, Vuvuzelas were a thing, Angry Birds started taking over phones, and WordPress stopped shipping with Kubrick. Seven years and 17 releases without new widgets have been enough, time to spice up your sidebar!

Props westonruter, melchoyce, obenland, timmydcrawford, adamsilverstein, gonom9, wonderboymusic, Fab1en, DrewAPicture, sirbrillig, joen, matias, samikeijonen, afercia, celloexpressions, designsimply, michelleweber, ranh, kjellr, karmatosed.
Fixes #32417, #39993, #39994, #39995.

Built from https://develop.svn.wordpress.org/trunk@40640


git-svn-id: http://core.svn.wordpress.org/trunk@40501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-11 21:11:44 +00:00
Pascal Birchler
33047ba14e Upgrade/Install: After [40394], rename wp_disallow_file_mods() to wp_is_file_mod_allowed(). 
This makes it more clear what this function is about.

Props Mte90.
Fixes #38673.

Built from https://develop.svn.wordpress.org/trunk@40638


git-svn-id: http://core.svn.wordpress.org/trunk@40499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-11 19:24:41 +00:00
Pascal Birchler
9af735e863 Themes: Avoid PHP warnings in the admin when no theme directory exists. 
Props iseulde, chris_dev, swissspidy.
Fixes #35521.

Built from https://develop.svn.wordpress.org/trunk@40636


git-svn-id: http://core.svn.wordpress.org/trunk@40497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-11 19:21:44 +00:00
Pascal Birchler
fc1350ebe5 Administration: Ensure validateForm also validates other input fields. 
With this change, textareas and select inputs will be checked as well.

Props shadyvb.
Fixes #37540.

Built from https://develop.svn.wordpress.org/trunk@40634


git-svn-id: http://core.svn.wordpress.org/trunk@40495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-11 19:18:42 +00:00
Dominik Schilling
0cd74a6d6e Plugins: Don't strip line breaks and blockquote elements in the plugin information modal. 
Fixes #40679.
Built from https://develop.svn.wordpress.org/trunk@40633


git-svn-id: http://core.svn.wordpress.org/trunk@40494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-11 19:16:42 +00:00
Pascal Birchler
c000e99d6f Mail: Ensure entities are decoded in email change notifications on Multisite. 
Adds new tests to ensure this bug does not pop up again.

Props stephenharris.
Fixes #40015.

Built from https://develop.svn.wordpress.org/trunk@40632


git-svn-id: http://core.svn.wordpress.org/trunk@40493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-11 19:15:44 +00:00
Weston Ruter
40ebb188cd Widgets: Extend the Text widget with TinyMCE. 
Introduces rich text formatting: bold, italic, lists, links.

Props westonruter, azaozz, timmydcrawford, obenland, melchoyce.
See #35760.
Fixes #35243.

Built from https://develop.svn.wordpress.org/trunk@40631


git-svn-id: http://core.svn.wordpress.org/trunk@40492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-11 18:55:43 +00:00
Weston Ruter
2353930f90 Customize: Wait for processing state to clear before starting to captureSettingModifiedDuringSave. 
See #32941.
Fixes #40729.

Built from https://develop.svn.wordpress.org/trunk@40627


git-svn-id: http://core.svn.wordpress.org/trunk@40488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-11 06:42:43 +00:00
Andrew Ozz
b952bf4eae Dashboard: Update the existing WordPress News dashboard widget to also include upcoming meetup events and WordCamps near the current user’s location. 
Props @afercia, @andreamiddleton, @azaozz, @camikaos, @coreymckrill, @chanthaboune, @courtneypk, @dd32, @iandunn, @iseulde, @mapk, @mayukojpn, @melchoyce, @nao, @obenland, @pento, @samuelsidler, @stephdau, @tellyworth.
See #40702.
Built from https://develop.svn.wordpress.org/trunk@40607


git-svn-id: http://core.svn.wordpress.org/trunk@40477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-10 20:04:42 +00:00
Andrew Ozz
19ed296008 Editor: Update wp.editor.remove() to use the new Quicktags instance removep(). 
Fixes: #35760
Built from https://develop.svn.wordpress.org/trunk@40599


git-svn-id: http://core.svn.wordpress.org/trunk@40469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-10 02:50:44 +00:00
Mike Schroder
391145df30 Media: Optionally return attachment id from media_sideload_image(). 
Introduces option to `$return` parameter to return the attachment id created after a successful image sideload.

Props slbmeh, kawauso, alexkingorg, SergeyBiryukov, georgestephanis, DrewAPicture, nacin, trepmal, mattheu, kraftbj, whyisjake, dotancohen, MrGregWaugh, danielbachhuber.
Fixes #19629.
Built from https://develop.svn.wordpress.org/trunk@40597


git-svn-id: http://core.svn.wordpress.org/trunk@40467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-09 23:26:42 +00:00
Andrew Ozz
cbf3b2cff5 Editor: Add wp.editor.remove() for editors that were dynamically instantiated from JS. 
Fixes: #35760
Built from https://develop.svn.wordpress.org/trunk@40588


git-svn-id: http://core.svn.wordpress.org/trunk@40458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-09 03:41:42 +00:00
Andrea Fercia
cc9d3cfbb3 Themes: Fix missing search field in the Theme Install screen after [40572]. 
Props desrosj, cristianozanca for reporting.
Fixes #34881.

Built from https://develop.svn.wordpress.org/trunk@40586


git-svn-id: http://core.svn.wordpress.org/trunk@40456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-08 15:59:44 +00:00
Andrew Ozz
dd0d110520 TinyMCE: update to 4.6.0. Has many new features and bug fixes, changelog: https://www.tinymce.com/docs/changelog/#version460-may42017. 
Fixes #40690.
Built from https://develop.svn.wordpress.org/trunk@40583


git-svn-id: http://core.svn.wordpress.org/trunk@40453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-08 05:32:46 +00:00
Andrea Fercia
98402b7c15 Administration: Restore missing spinner when installing a new language. 
Fixes #40478.

Built from https://develop.svn.wordpress.org/trunk@40579


git-svn-id: http://core.svn.wordpress.org/trunk@40449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-07 12:01:42 +00:00
Andrea Fercia
fe96a729a0 Accessibility: Make the Get Shortlink button be a real button. 
Worth noting, as of WordPress 4.4, the Get Shortlink button is hidden by default
but it can be restored via filters.

Props Cheffheid.
See #26504.
Fixes #40448.

Built from https://develop.svn.wordpress.org/trunk@40578


git-svn-id: http://core.svn.wordpress.org/trunk@40448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-07 11:47:41 +00:00
Pascal Birchler
7fd55738be Administration: Remove unit and prefixed version from a CSS declaration. 
The prefixed version gets added by Autoprefixer already.

Props MatheusFD.
Fixes #35358.

Built from https://develop.svn.wordpress.org/trunk@40576


git-svn-id: http://core.svn.wordpress.org/trunk@40446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-06 14:37:44 +00:00
Pascal Birchler
064e62cbea Cron API: Add a new wp_doing_cron() helper function. 
This replaces `DOING_CRON` checks via the constant.

Props tfrommen.
Fixes #39591.

Built from https://develop.svn.wordpress.org/trunk@40575


git-svn-id: http://core.svn.wordpress.org/trunk@40445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-06 14:30:40 +00:00
Andrea Fercia
471f1e7201 Accessibility: Wrap the installed themes search field within a form element. 
Valid code is important not just to formally meet the specification, but also to
ensure user agents, including assistive technologies, can accurately interpret
and parse content. When HTML elements are not used in the recommended way,
user agents may render them in unexpected ways. It can also become a problem for
compatibility with older or even future browsers, devices, or other software.
See W3C WCAG 4.1.1.

Props takayukister, aryamaaru.
Fixes #34881.

Built from https://develop.svn.wordpress.org/trunk@40572


git-svn-id: http://core.svn.wordpress.org/trunk@40442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-05 19:02:45 +00:00
Andrea Fercia
3dab32af54 Accessibility: Improve the color contrast ratio of the dismiss notice buttons. 
Props chris_dev.
Fixes #39970.

Built from https://develop.svn.wordpress.org/trunk@40570


git-svn-id: http://core.svn.wordpress.org/trunk@40440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-04 22:32:46 +00:00
Andrea Fercia
3c7698808f Customize: Fix a visual glitch on the widget control animation introduced in [40480]. 
Also, restores the original design intent that was meant to "compact widget-tops
on smaller laptops, but not tablets".

See #27112.
Fixes #31476.

Built from https://develop.svn.wordpress.org/trunk@40569


git-svn-id: http://core.svn.wordpress.org/trunk@40439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-03 22:39:44 +00:00
Andrea Fercia
1ca3b70929 Accessibility: Avoid a keyboard trap on the date and time custom format settings. 
Using the `focus` event on the date and time custom format fields made impossible
to navigate through all the form fields using only the keyboard without actually
selecting the custom format setting. Instead, using `click` and `input` preserves
the original functionality when using any kind of pointing or input device.

Fixes #40515.

Built from https://develop.svn.wordpress.org/trunk@40568


git-svn-id: http://core.svn.wordpress.org/trunk@40436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-02 20:03:42 +00:00
Weston Ruter
91a8af0ef6 Customize: Allow select dropdowns to stretch full width in widened controls pane. 
Props timmydcrawford.
Amends [40511].
Fixes #32296.

Built from https://develop.svn.wordpress.org/trunk@40567


git-svn-id: http://core.svn.wordpress.org/trunk@40435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-02 19:30:46 +00:00