Commit Graph

49 Commits

Author SHA1 Message Date
Sergey Biryukov 47ed56f38f Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant.
This avoids the performance overhead of the function call every time `dirname( __FILE__ )` was used instead of `__DIR__`.

This commit also includes:

* Removing unnecessary parentheses from `include`/`require` statements. These are language constructs, not function calls.
* Replacing `include` statements for several files with `require_once`, for consistency:
 * `wp-admin/admin-header.php`
 * `wp-admin/admin-footer.php`
 * `wp-includes/version.php`

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.
Built from https://develop.svn.wordpress.org/trunk@47198


git-svn-id: http://core.svn.wordpress.org/trunk@46998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-06 06:33:11 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Andrew Nacin fd57b239d2 Don't rely on include_path to include files.
Always use dirname() or, once available, ABSPATH.

props ketwaroo, hakre.
fixes #17092.

Built from https://develop.svn.wordpress.org/trunk@25616


git-svn-id: http://core.svn.wordpress.org/trunk@25533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 00:18:11 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
nacin a717edca97 Always exit after wp_redirect. props filosofo, fixes #15518.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-09 18:02:54 +00:00
ryan 21e3f0f7fa Network Admin, first pass. see #14435
git-svn-id: http://svn.automattic.com/wordpress/trunk@15481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-07-30 20:34:54 +00:00
nacin 34c1fa6d0b target=blank for help. props jorbin, see #13467
git-svn-id: http://svn.automattic.com/wordpress/trunk@15132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-03 21:00:39 +00:00
ryan 17129fb62e Cut 'em out, move 'em on, trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@15116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-02 20:04:07 +00:00
nacin f80b6092f8 MS help fixes. props dougwrites, see #13467.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-02 05:53:24 +00:00
nacin 8caed1c2a1 Help for multisite. props andrea_r, dougwrites, duck_. see #13467.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-27 21:20:23 +00:00
markjaquith 253c82d9b7 Misc HTML validation fixes. see #13383. props jshreve
git-svn-id: http://svn.automattic.com/wordpress/trunk@14737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-19 05:32:39 +00:00
markjaquith 3ed394e3af Revert accidental inclusion of another patch in [14734]. Doh. Reviewing that one next!
git-svn-id: http://svn.automattic.com/wordpress/trunk@14735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-19 05:15:06 +00:00
markjaquith dfc9923e59 Cast global_terms_enabled to bool before doing checked() so that FALSE matches as well as 0.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-19 05:12:01 +00:00
nacin c6d21e7fbb Introduce _ex(), a hybrid between _e() and _x() -- translate with context, then echo. props westi, see #13395.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-14 21:46:25 +00:00
nacin c13744a051 Valid HTML in ms-users and ms-sites. props Utkarsh, see #13383.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-14 15:03:23 +00:00
nbachiyski bebd1b8ea6 Differentiate spam strings by subject: comments, sites, and users. Props dimadin. Fixes #13199
git-svn-id: http://svn.automattic.com/wordpress/trunk@14407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 20:37:07 +00:00
ryan 7b7243d94a Strip trailing whites.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 20:26:11 +00:00
ryan 172aa06718 Revert [14347] and [14372]. It broke more than we expected. Try again in 3.1. see #13051
git-svn-id: http://svn.automattic.com/wordpress/trunk@14374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 18:16:22 +00:00
ryan 91354eefee Escape links by default. Props alexkingorg. see #13051
git-svn-id: http://svn.automattic.com/wordpress/trunk@14347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-02 22:53:59 +00:00
ryan bc0947b075 Introduce get_super_admins(). Allow hard-coding a global super_admins array and bypassing site options. fixes #12815
git-svn-id: http://svn.automattic.com/wordpress/trunk@14206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-23 20:34:03 +00:00
ryan f4ccd9cac3 Fix paging numbers. Props ocean90. fixes #13082
git-svn-id: http://svn.automattic.com/wordpress/trunk@14188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-22 17:59:21 +00:00
nacin 53e0be05cb Remove references to the old .fade class for message divs.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-08 03:36:52 +00:00
nacin c449adb237 File-level phpdoc for multisite files.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-04 13:29:35 +00:00
nacin 2361cdd745 Some more MS cleanups. see #12460
git-svn-id: http://svn.automattic.com/wordpress/trunk@13965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-03 11:15:51 +00:00
nacin eb14ca3036 More MS cleanups. props ocean90. see #12460
git-svn-id: http://svn.automattic.com/wordpress/trunk@13953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-03 00:10:44 +00:00
nacin 7b55c4688a Move add/remove super admin out of bulk edit and into user-edit.php. Introduce grant_super_admin() and revoke_super_admin(). Link to profile.php in ms-users user row for current user. Add defensive check by forcing IS_PROFILE_PAGE on user-edit if trying to edit your own user_id. see #12460
git-svn-id: http://svn.automattic.com/wordpress/trunk@13941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-02 06:46:07 +00:00
markjaquith d510d0bdc7 Huge MS refactoring and code cleanup. see #12460. props ocean90.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-01 21:21:27 +00:00
ryan e25a65b36a Trim trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@13733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-17 16:27:25 +00:00
wpmuguru 27cf16f442 add second set of Network admin buttons, See #11644
git-svn-id: http://svn.automattic.com/wordpress/trunk@13443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-26 20:23:25 +00:00
wpmuguru 2403d9e05a switch super admin to network admin in multisite UI, See #11644
git-svn-id: http://svn.automattic.com/wordpress/trunk@13442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-26 20:16:16 +00:00
wpmuguru e667fb14e0 move super admin list maintenance from ms-options to ms-users, See #11644
git-svn-id: http://svn.automattic.com/wordpress/trunk@13419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-25 22:11:54 +00:00
wpmuguru 9ee37eb920 more multisite UX rebranding, See #11644
git-svn-id: http://svn.automattic.com/wordpress/trunk@13379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-24 19:56:10 +00:00
wpmuguru a5a9f32b73 multisite UX, see #11644, add manage_ caps for super_admin, fixes #11803
git-svn-id: http://svn.automattic.com/wordpress/trunk@13301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-22 18:41:38 +00:00
nacin 5656a345b9 Use esc_url() instead of clean_url(). See #12309
git-svn-id: http://svn.automattic.com/wordpress/trunk@13297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-22 18:15:10 +00:00
wpmuguru 1961703968 move ms css to ms.css, fixes #11790
git-svn-id: http://svn.automattic.com/wordpress/trunk@12949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-04 19:03:08 +00:00
ryan 4b6278340c Fix warnings. see #11644
git-svn-id: http://svn.automattic.com/wordpress/trunk@12801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-22 22:27:26 +00:00
ryan 4ef834c4b1 Screen icons for site admin pages. Using temp icon until new ones are done. see #11644
git-svn-id: http://svn.automattic.com/wordpress/trunk@12781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-20 22:35:21 +00:00
ryan a06a4c6b70 Formatting cleanups
git-svn-id: http://svn.automattic.com/wordpress/trunk@12760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-19 17:01:39 +00:00
ryan 8760e7da1b Coding standards, space after if
git-svn-id: http://svn.automattic.com/wordpress/trunk@12752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-18 20:34:48 +00:00
wpmuguru 04803e826d change ms-blogs.php refs to ms-sites.php, remove extraneous character, See #11644
git-svn-id: http://svn.automattic.com/wordpress/trunk@12725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-14 19:42:55 +00:00
ryan 4c92a634a3 User is_super_admin(). Props GIGALinux. see #11644
git-svn-id: http://svn.automattic.com/wordpress/trunk@12646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-07 15:52:22 +00:00
ryan adf017f6b9 Strip trailing whites from ms files. see #11644
git-svn-id: http://svn.automattic.com/wordpress/trunk@12632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-07 04:27:46 +00:00
ryan 92257b49ec Cleanup titles. see #11644
git-svn-id: http://svn.automattic.com/wordpress/trunk@12627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-07 03:24:24 +00:00
ryan fd475d2b38 s/wpmu/ms/ in file refs. Props Denis-de-Bernardy. see #11644
git-svn-id: http://svn.automattic.com/wordpress/trunk@12622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-07 00:30:53 +00:00
ryan b13380665b Add esc_attr to ms-users.php. see #11792
git-svn-id: http://svn.automattic.com/wordpress/trunk@12621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-07 00:25:02 +00:00
wpmuguru 8ab77e04e7 Change references to wpmu-edit.php - See #11644
git-svn-id: http://svn.automattic.com/wordpress/trunk@12620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-07 00:24:03 +00:00
westi 53d810f260 Remove svn:executable property on new files. Fixes #11743 props Denis-de-Bernardy.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-06 22:22:45 +00:00
ryan f5e12260d4 Introduce is_multisite(). see #11644
git-svn-id: http://svn.automattic.com/wordpress/trunk@12609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-06 20:19:35 +00:00
wpmuguru d07d6c5717 Add mu only (inactive) files
git-svn-id: http://svn.automattic.com/wordpress/trunk@12603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-06 04:02:57 +00:00