Sergey Biryukov
f9ff030127
I18N: Replace hardcoded file name in a translatable string in convert_to_screen()
with a placeholder.
...
Props ramiy.
Fixes #41668 .
Built from https://develop.svn.wordpress.org/trunk@41906
git-svn-id: http://core.svn.wordpress.org/trunk@41740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 15:46:52 +00:00
Sergey Biryukov
82dd23d36f
I18N: Make context for "Schedule" string added in [41898] more accurate.
...
Props ocean90.
Fixes #42165 .
Built from https://develop.svn.wordpress.org/trunk@41905
git-svn-id: http://core.svn.wordpress.org/trunk@41739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 15:39:52 +00:00
Sergey Biryukov
16bee559d4
I18N: Replace hardcoded file name in translatable strings in wp-admin/setup-config.php
with a placeholder.
...
Props ramiy, danieltj.
Fixes #42161 .
Built from https://develop.svn.wordpress.org/trunk@41904
git-svn-id: http://core.svn.wordpress.org/trunk@41738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 15:27:53 +00:00
Konstantin Obenland
d8f98b3649
Customize: Unstick filter pane in Theme selector
...
Prevents the filter pane from blocking the view of theme search results when it's open.
Users are now able to just scroll to view results.
Props rclations.
Fixes #42212 .
Built from https://develop.svn.wordpress.org/trunk@41903
git-svn-id: http://core.svn.wordpress.org/trunk@41737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 15:11:46 +00:00
Sergey Biryukov
ac5096d8bd
Embeds: Avoid "Division by zero" warning in embed-content.php
template if a thumbnail has a zero height.
...
Props stevenlinx, aegis123.
Fixes #40931 .
Built from https://develop.svn.wordpress.org/trunk@41902
git-svn-id: http://core.svn.wordpress.org/trunk@41736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 15:09:48 +00:00
Sergey Biryukov
a859b46e92
I18N: Replace function name in error message in WP_Http_Curl::request()
and WP_Http_Streams::request()
with a placeholder.
...
Props ramiy.
Fixes #41666 .
Built from https://develop.svn.wordpress.org/trunk@41901
git-svn-id: http://core.svn.wordpress.org/trunk@41735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 15:04:51 +00:00
Gary Pendergast
a2bd3e23d1
Dashboard: Ensure the "Dismiss" button on the Gutenberg callout is clickable.
...
Who likes z-index? We like z-index!
Props joemcgill.
See #41316 .
Built from https://develop.svn.wordpress.org/trunk@41900
git-svn-id: http://core.svn.wordpress.org/trunk@41734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 14:55:48 +00:00
Konstantin Obenland
261f0d8ef2
Customize: Allow menu creation in locations pane
...
Adds a link to the menu creation workflow from the locations selector in the nav menu control.
Props bpayton, westonruter, Travel_girl, melchoyce, celloexpressions.
Fixes #36279 .
Built from https://develop.svn.wordpress.org/trunk@41899
git-svn-id: http://core.svn.wordpress.org/trunk@41733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 14:51:47 +00:00
Sergey Biryukov
97bab0459a
I18N: Add a context for "Schedule" string.
...
Props Mirucon.
Fixes #42165 .
Built from https://develop.svn.wordpress.org/trunk@41898
git-svn-id: http://core.svn.wordpress.org/trunk@41732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 14:45:51 +00:00
Mel Choyce
0c73d35816
Code Editors: Fix display of "help" cursor.
...
Props studionashvegas .
Fixes #42210 .
Built from https://develop.svn.wordpress.org/trunk@41897
git-svn-id: http://core.svn.wordpress.org/trunk@41731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 13:11:49 +00:00
Gary Pendergast
df8ab820ef
Dashboard: Remove a rogue comma introduced in [41895].
...
See #41316 .
Built from https://develop.svn.wordpress.org/trunk@41896
git-svn-id: http://core.svn.wordpress.org/trunk@41730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 12:39:46 +00:00
Gary Pendergast
3981736cd6
Dashboard: Introduce a "Try Gutenberg" callout.
...
To encourage more people to try Gutenberg, this new Dashboard box allows site users to easily install and try out Gutenberg.
Props pento, melchoyce, joen, karmatosed.
Fixes #41316 .
Built from https://develop.svn.wordpress.org/trunk@41895
git-svn-id: http://core.svn.wordpress.org/trunk@41729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 10:04:47 +00:00
Weston Ruter
e914c0447c
Customize: Add missing filter docs in WP_Customize_Nav_Menu_Item_Setting::sanitize()
.
...
Props dlh.
Fixes #42257 .
Built from https://develop.svn.wordpress.org/trunk@41894
git-svn-id: http://core.svn.wordpress.org/trunk@41728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 04:57:50 +00:00
Weston Ruter
43b4a2577d
Customize: Improve theme browsing UI on small screens.
...
Props Mahvash-Fatima, melchoyce, celloexpressions.
See #37661 .
Fixes #42215 .
Built from https://develop.svn.wordpress.org/trunk@41893
git-svn-id: http://core.svn.wordpress.org/trunk@41727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 04:06:47 +00:00
Weston Ruter
41bb2125b0
Customize: Remove incorrect test assertions for the post_date
of customization drafts.
...
Amends [41887].
See #42220 .
Built from https://develop.svn.wordpress.org/trunk@41892
git-svn-id: http://core.svn.wordpress.org/trunk@41726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 02:41:49 +00:00
Weston Ruter
b4edf21599
Media: Add missing mediaelement-migrate.js
script to get uglified.
...
Amends [41877].
See #42189 , #39686 .
Built from https://develop.svn.wordpress.org/trunk@41891
git-svn-id: http://core.svn.wordpress.org/trunk@41725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 02:26:48 +00:00
Weston Ruter
7ee77760af
Widgets: Use a foreach
loop instead of The Loop to iterate over posts in Recent Posts widget to avoid needing to reset a polluted global $post
.
...
Props welcher, westonruter.
Amends [14607].
See #12320 .
Fixes #37312 .
Built from https://develop.svn.wordpress.org/trunk@41890
git-svn-id: http://core.svn.wordpress.org/trunk@41724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 00:34:46 +00:00
Weston Ruter
dce5306603
Media: Use user locale as ME.js language in admin and add mejsL10n
inline script before mediaelement-core
so WP-exported translation strings are used.
...
See #39686 .
Fixes #42241 .
Built from https://develop.svn.wordpress.org/trunk@41889
git-svn-id: http://core.svn.wordpress.org/trunk@41723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 00:08:45 +00:00
David A. Kennedy
b6539fb5a0
Twenty Seventeen: Fix double bottom-margins below embeds
...
Corrects an issue where both the containing paragraph and embed had bottom margins, causing unwanted extra space.
Props westonruter.
Fixes #42118 .
Built from https://develop.svn.wordpress.org/trunk@41888
git-svn-id: http://core.svn.wordpress.org/trunk@41722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-17 22:50:51 +00:00
Weston Ruter
bd9d1d9178
Customize: Allow post/page stubs to be edited in WP Admin as "customization drafts" when changeset is saved as draft or scheduled.
...
* Update stubs to have draft status when changeset is saved as draft, instead of preventing auto-draft garbage collection by giving them a far-future `post_date`.
* Show notice in publish metabox when editing a customization draft indicating that it will be published automatically with its changeset; a link to Customizer is included.
* Include a new "Customization Draft" display post state in the post list table.
* Disconnect stubs from their changesets when they are updated with a status other than "Draft".
* Trash customization drafts when their related changeset is trashed or deleted.
* Add a `_customize_changeset_uuid` postmeta to stubs to link them with their associated changeset.
* Include `customize_changeset_uuid` as context when requesting to insert a new auto-draft.
Props westonruter, melchoyce.
See #39896 , #39752 , #34923 .
Fixes #42220 .
Built from https://develop.svn.wordpress.org/trunk@41887
git-svn-id: http://core.svn.wordpress.org/trunk@41721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-17 20:15:52 +00:00
Weston Ruter
955d5b0ab1
Widgets: Prevent MediaElement.js player from overflowing sidebar in Audio widget.
...
Props bradyvercher.
See #39686 .
Fixes #42244 .
Built from https://develop.svn.wordpress.org/trunk@41886
git-svn-id: http://core.svn.wordpress.org/trunk@41720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 23:02:47 +00:00
Felix Arntz
021afced82
Role/Capability: Prevent a fatal error when checking a language capability early or in the frontend.
...
The meta capabilities `install_languages` and `update_languages` rely on the admin function `wp_can_install_language_pack()`. That function in turn relies on `request_filesystem_credentials()`, so it needs to be ensured that this function is available as well.
Fixes #42230 .
Built from https://develop.svn.wordpress.org/trunk@41885
git-svn-id: http://core.svn.wordpress.org/trunk@41719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 22:54:57 +00:00
Felix Arntz
3f8621b632
Multisite: Revert [41698] and [41743].
...
In order for `get_site_by()` to be truly beneficial, caching in `WP_Site_Query` needs to be improved to account for common use-cases and have them be invalidated less aggressively.
See #40180 , #40228 , #42091 .
Built from https://develop.svn.wordpress.org/trunk@41884
git-svn-id: http://core.svn.wordpress.org/trunk@41718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 22:35:47 +00:00
Felix Arntz
18789739c1
Multisite: Revert [41719].
...
While `get_site_by()` makes sense as a more explicit and less complex replacement for `get_blog_details()`, it is not ready yet in terms of caching, where it currently falls short of the older function under specific circumstances.
See #40180 , #40228 .
Built from https://develop.svn.wordpress.org/trunk@41883
git-svn-id: http://core.svn.wordpress.org/trunk@41717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 22:29:48 +00:00
Helen Hou-Sandí
bb66a52a14
Code Editors: Minor style improvements.
...
props melchoyce.
see #42214 .
Built from https://develop.svn.wordpress.org/trunk@41882
git-svn-id: http://core.svn.wordpress.org/trunk@41716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 21:36:48 +00:00
Boone Gorges
af960204b6
Taxonomy: Add note about $number
inconsistency to WP_Term_Query
docs.
...
Fixes #41796 .
Built from https://develop.svn.wordpress.org/trunk@41881
git-svn-id: http://core.svn.wordpress.org/trunk@41715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 18:38:48 +00:00
Boone Gorges
9f73875705
Don't force distinct term queries when specifying number
and object_ids
.
...
This reverts [41377], which caused performance problems on sites with a large
number of terms.
See #41796 .
Built from https://develop.svn.wordpress.org/trunk@41880
git-svn-id: http://core.svn.wordpress.org/trunk@41714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 18:35:47 +00:00
John Blackbourn
24783cfc3e
Media: Allow the unminified mediaelement script to be enqueued when SCRIPT_DEBUG
is true.
...
Props dsawardekar
Fixes #42229
Built from https://develop.svn.wordpress.org/trunk@41879
git-svn-id: http://core.svn.wordpress.org/trunk@41713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 18:15:47 +00:00
Andrea Fercia
575e60e96c
Administration: Improve consistency of the "not found" strings.
...
Partially reverts [41608] restoring the original strings without the word `query`.
See #37430 .
Fixes #42231 .
Built from https://develop.svn.wordpress.org/trunk@41878
git-svn-id: http://core.svn.wordpress.org/trunk@41712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 18:14:48 +00:00
Weston Ruter
2e602a8560
Media: Add MediaElement.js 2.2 back-compat for MediaElement.js 4.2
...
* Introduces `mediaelement-migrate.js`.
* Upgrades ME.js from 4.2.5-74e01a40 to 4.2.6-78496d1.
Props rafa8626, bradyvercher.
See #39686 .
Fixes #42189 .
Built from https://develop.svn.wordpress.org/trunk@41877
git-svn-id: http://core.svn.wordpress.org/trunk@41711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 18:07:52 +00:00
Andrea Fercia
4085a1b266
Accessibility: Improve the File Editors interstitial warning.
...
The warning displayed upon first visit on the File Editors introduced in [41774]
needs to be the only perceivable content in the page for users of assistive
technologies. It looks like a modal but it's not exactly an ARIA dialog, not an
ARIA alert either, and needs some special treatment.
- constrains tabbing within the modal
- uses `wp.a11y.speak()` to make screen readers announce the modal message
- hides all the other page content from assistive technologies using `aria-hidden="true"`
This way, even if users miss the speak message, the warning is actually the only
perceivable content in the page.
Fixes #42110 .
Built from https://develop.svn.wordpress.org/trunk@41876
git-svn-id: http://core.svn.wordpress.org/trunk@41710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 17:59:52 +00:00
Jeremy Felt
e362e61ae5
Multisite: Explicitly globalize global variables in ms-settings.php
.
...
Explicitly globalize and document `$domain`, `$path`, `$site_id`, and `$public` in `ms-settings.php.
Props csloisel, danielbachhuber.
Fixes #39419 .
Built from https://develop.svn.wordpress.org/trunk@41875
git-svn-id: http://core.svn.wordpress.org/trunk@41709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 17:06:48 +00:00
Sergey Biryukov
a88704d026
Administration: Remove punctuation from the link text in "Site Address" option description.
...
Props Presskopp.
Fixes #42190 .
Built from https://develop.svn.wordpress.org/trunk@41874
git-svn-id: http://core.svn.wordpress.org/trunk@41708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 14:02:50 +00:00
Weston Ruter
862e8c1807
Customize: Use keydown
instead of keyup
for listening for enter key to add page stub via dropdown-pages control.
...
Fixes issue with Japanese input.
Props miyauchi.
Amends [38906].
See #34923 .
Fixes #42233 .
Built from https://develop.svn.wordpress.org/trunk@41873
git-svn-id: http://core.svn.wordpress.org/trunk@41707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 07:57:48 +00:00
Weston Ruter
4150e805d7
Widgets: Update preview for Gallery widget when one of its attachments is modified in the media modal, outside the customized state.
...
* Ensure that changes to captions are shown in preview when modified in media modal.
* Also keep `wp.customize.widgetsPreview.renderedWidgets` updated when widgets are added or removed.
See #41914 , #37887 , #40403 .
Fixes #41979 .
Built from https://develop.svn.wordpress.org/trunk@41872
git-svn-id: http://core.svn.wordpress.org/trunk@41706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 06:46:48 +00:00
Weston Ruter
94f9c7e789
Customize: Prevent theme details modal from being clipped in Safari.
...
Props afercia.
See #42052 , #37661 .
Built from https://develop.svn.wordpress.org/trunk@41871
git-svn-id: http://core.svn.wordpress.org/trunk@41705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 04:41:45 +00:00
Sergey Biryukov
c79492540a
Build/Test Tools: Pass correct $message
argument to WP_UnitTestCase::setExpectedException()
in Tests_Ajax_CompressionTest::test_logged_out()
and Tests_Ajax_TagSearch::test_no_results()
.
...
PHPUnit 6.4.1 and earlier versions ignored the `'0'` value, causing the issue to go unnoticed.
Fixes #42232 .
Built from https://develop.svn.wordpress.org/trunk@41870
git-svn-id: http://core.svn.wordpress.org/trunk@41704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 04:06:49 +00:00
Weston Ruter
2e184426c0
Customize: Add 'save-request-params'
event on wp.customize
for plugins to inject/modify params in save
requests.
...
Allows feature plugins, for example, to supply a `customize_changeset_title` param instead of having to wrap `wp.customize.previewer.query`.
Props dlh.
Fixes #42206 .
Built from https://develop.svn.wordpress.org/trunk@41869
git-svn-id: http://core.svn.wordpress.org/trunk@41703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-15 22:42:48 +00:00
Weston Ruter
12f647679b
Widgets: Rename "Custom Menu" widget to "Navigation Menu".
...
Props gk.loveweb, ChrisHardie, ajayghaghretiya1, melchoyce.
Fixes #40442 .
Built from https://develop.svn.wordpress.org/trunk@41868
git-svn-id: http://core.svn.wordpress.org/trunk@41702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-15 22:23:47 +00:00
Sergey Biryukov
46ff957961
Widgets: Move empty title checks out of the apply_filters( 'widget_title' )
calls for clarity.
...
See #42226 .
Built from https://develop.svn.wordpress.org/trunk@41867
git-svn-id: http://core.svn.wordpress.org/trunk@41701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-15 21:43:47 +00:00
Sergey Biryukov
0ae79ece9f
Widgets: In WP_Widget_Media
, apply widget_title
filter regardless of whether the title is empty, same as other widgets do.
...
Props Bsop.
Fixes #42226 .
Built from https://develop.svn.wordpress.org/trunk@41866
git-svn-id: http://core.svn.wordpress.org/trunk@41700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-15 21:29:51 +00:00
Weston Ruter
ad8c9f0170
File Editor: Move inline to external style to fix extra padding in RTL page direction.
...
Props afercia.
Fixes #42221 .
Built from https://develop.svn.wordpress.org/trunk@41865
git-svn-id: http://core.svn.wordpress.org/trunk@41699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-15 05:51:49 +00:00
Weston Ruter
191beede5e
File Editor: Prevent the scrolling of current-file into view to also change initially-focused element in Chrome.
...
Props afercia.
Fixes #24048 .
Built from https://develop.svn.wordpress.org/trunk@41864
git-svn-id: http://core.svn.wordpress.org/trunk@41698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-15 05:37:51 +00:00
Weston Ruter
8562e4bfac
Customize: Fix visibility of theme browser header in Safari.
...
Props benoitchantre, afercia.
See #42052 , #37661 .
Built from https://develop.svn.wordpress.org/trunk@41863
git-svn-id: http://core.svn.wordpress.org/trunk@41697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-15 04:59:10 +00:00
Felix Arntz
e4550efbb7
Multisite: Return get_current_blog_id()
value instead of hard-coded 1 in get_main_site_id()
for non-multisite environments.
...
See #41936 .
Built from https://develop.svn.wordpress.org/trunk@41862
git-svn-id: http://core.svn.wordpress.org/trunk@41696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-14 22:46:48 +00:00
Felix Arntz
5ea3d62192
Multisite: Take WP_Network::$blog_id
into account in get_main_site_id()
.
...
When the `WP_Network::$blog_id` property is set manually, for example in the multisite bootstrap process, `get_main_site_id()` should use that value instead of running its own logic. The main logic for the function was therefore moved into the internal `WP_Network::get_main_site_id()` method, which is now being accessed by the function through the magic property handling for `WP_Network::$blog_id` (and its equivalent `WP_Network::$site_id`).
Props spacedmonkey, jeremyfelt.
Fixes #41936 .
Built from https://develop.svn.wordpress.org/trunk@41861
git-svn-id: http://core.svn.wordpress.org/trunk@41695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-14 22:42:54 +00:00
Weston Ruter
24d304a0a1
Customize: Fix positioning of device-previewed window when publish settings are open.
...
* Update date control padding.
* Collapse publish settings section when opening panes for available widgets or nav menus.
* Remove save and cog buttons in mobile preview only mode.
* Move definition of `wp.customize.previewedDevice` to `wp.customize.state('previewedDevice')` for centralization, maintaining old alias.
* Remove unused CSS because the section is inside form now.
Props sayedwp, westonruter.
See #39896 .
Fixes #42027 , #42199 .
Built from https://develop.svn.wordpress.org/trunk@41860
git-svn-id: http://core.svn.wordpress.org/trunk@41694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-13 21:21:55 +00:00
Helen Hou-Sandí
e48b16d96a
File editor warning: Add a "Go back" button.
...
see #42100 , #31779 .
Built from https://develop.svn.wordpress.org/trunk@41859
git-svn-id: http://core.svn.wordpress.org/trunk@41693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-13 20:56:50 +00:00
Weston Ruter
d975dccac9
Code Editor: Fix syntax error in PHP 5.2 and PHP 5.3 after [41855].
...
See #41871 .
Built from https://develop.svn.wordpress.org/trunk@41858
git-svn-id: http://core.svn.wordpress.org/trunk@41692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-13 19:43:49 +00:00
Mel Choyce
e5db49d607
Settings: Widen time/day input fields on General Settings page, and move the preview onto the next line.
...
Props desrosj, afercia.
Fixes #41603 .
Built from https://develop.svn.wordpress.org/trunk@41857
git-svn-id: http://core.svn.wordpress.org/trunk@41691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-13 18:39:48 +00:00