Andrew Ozz
2f0c58960a
Separate the nonces update from checking the post lock. Fix scheduling the logged out check. See #23697 , see #23295 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-16 03:47:09 +00:00
Sergey Biryukov
421f66a7bb
Add file header to post-formats.php. props DrewAPicture. fixes #24349 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-15 23:14:45 +00:00
Andrew Ozz
7255abb66c
Fix showing and hiding of UI elements when disabling the Post Formats UI, props kovshenin, see #24327
...
git-svn-id: http://core.svn.wordpress.org/trunk@24264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-15 20:43:09 +00:00
Dominik Schilling
cf47737813
Revisions: Correct check for ensuring comparison always from newer to older revision. props adamsilverstein. fixes #24340 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-15 19:09:39 +00:00
Dominik Schilling
6d0173ba11
RTL support for the new post Format UI. see #24326 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-14 19:01:57 +00:00
Ryan Boren
66472f11a0
phpdoc improvements for wp_dashboard_quota()
...
Props DrewAPicture, h4ck3rm1k3
git-svn-id: http://core.svn.wordpress.org/trunk@24246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-14 12:37:30 +00:00
Andrew Nacin
46097dec37
Pass blog_id to the wpmu_drop_tables filter. props mitchoyoshitaka. see #24320 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-11 21:58:40 +00:00
Sergey Biryukov
4b174612ab
Prevent menu items with '0' label from being removed on menu saving. props MikeHansenMe, kovshenin. fixes #23051 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-10 18:03:09 +00:00
Sergey Biryukov
7aca821e4c
Display consistent labels in Image post format UI for users with and without unfiltered_html capability. props tollmanz. fixes #24304 . see #24291 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-10 14:41:58 +00:00
Sergey Biryukov
013d0d06c6
Remove debug cruft. props kovshenin. see #23930 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-10 12:26:46 +00:00
Sergey Biryukov
c5a028821b
Use esc_textarea(), not esc_html(), for escaping textarea content. props johnbillion. fixes #24300 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-10 02:06:34 +00:00
Sergey Biryukov
74638ccb5a
Fix typos in phpdoc. props TheLastCicada. fixes #24302 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-10 01:39:30 +00:00
Sergey Biryukov
fb6293b714
Use correct escaping function. props tollmanz. fixes #24300 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-09 23:53:24 +00:00
Mark Jaquith
f63001eb2c
Improve the UX and flow of the Image post format.
...
* Drag-and-drop
* Textarea for HTML/URL hidden to start
* Bigger click target for entering Media modal
* Image preview height-contrained to 300 pixels
* Hid the alignment, size, etc options that didn't have an effect anyway
* Got wp-format-{format} into the <body> class
props DrewAPicture, aaroncampbell, markjaquith, azaozz. see #24291 .
git-svn-id: http://core.svn.wordpress.org/trunk@24226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-09 22:45:14 +00:00
Sergey Biryukov
415a5c60da
* Pass ellipsis as a parameter to wp_html_excerpt() instead of appending it manually.
...
* Consolidate the logic to avoid appending ellipsis if the entire string is shown.
* Show ellipsis after truncated filenames and post titles.
props solarissmoke, bpetty, SergeyBiryukov. fixes #11446 .
git-svn-id: http://core.svn.wordpress.org/trunk@24214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-09 00:22:02 +00:00
Sergey Biryukov
08bef7a3cb
Use wp_trim_words() in Recent Drafts widget. fixes #24292 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 23:06:41 +00:00
Andrew Ozz
d0c5c59c94
Post locks and autosave:
...
- Move nonces refreshing from autosave to lock checking.
- Do autosave only when there is something to save.
See #23295
git-svn-id: http://core.svn.wordpress.org/trunk@24209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 22:52:55 +00:00
Sergey Biryukov
57c10eadbb
Use ellipsis instead of three dots. props tjsingleton, jordie23, wojtek.szkutnik, DrewAPicture, SergeyBiryukov. see #8714 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 21:27:31 +00:00
Mark Jaquith
5ee1a961a4
Ensure that draft posts cannot be given a non-unique post slug when using Quick Edit.
...
fixes #22902 . props SergeyBiryukov.
git-svn-id: http://core.svn.wordpress.org/trunk@24206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 21:26:17 +00:00
Dominik Schilling
cbec9880a7
Revisions UI: RTL support. (And inline docs.)
...
props DrewAPicture, adamsilverstein. fixes #23897 .
git-svn-id: http://core.svn.wordpress.org/trunk@24205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 21:22:01 +00:00
Mark Jaquith
57b1dd212b
Go back to plain text diffs between revisions instead of attempting partial rendering.
...
fixes #24254
git-svn-id: http://core.svn.wordpress.org/trunk@24192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 20:34:58 +00:00
Andrew Nacin
a518fb0c94
Fix usage of undeclared variables.
...
* the_weekday_date() needs the global $currentday
* ms_site_check() needs the global $current_site
* media list table does not need to check for $total_orphans
* upgrader has no $feedback variable, appears to be copypasta from other upgrade APIs
* install_themes_feature_list() has no $features variable, return array() instead of a new return type of WP_Error
see #24210 .
git-svn-id: http://core.svn.wordpress.org/trunk@24189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 16:35:03 +00:00
Andrew Nacin
3b4a087007
remove_filter() only accepts three arguments: filter, callback, and priority. An accepted args parameter is only used for adds.
...
props rlerdorf.
see #24210 .
git-svn-id: http://core.svn.wordpress.org/trunk@24188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 15:55:31 +00:00
Andrew Nacin
b34ca3234e
Remove manual printing of userSettings as utils.js receives this as inline script data (since 3.5). see #24210 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 15:49:20 +00:00
Sergey Biryukov
e2dde2765c
Update the instructions on Edit Menus screen. props DrewAPicture. fixes #24261 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 14:55:14 +00:00
Ryan Boren
164b3e71e6
Update some copy in the Post Formats UI.
...
see #24227
git-svn-id: http://core.svn.wordpress.org/trunk@24184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 13:56:07 +00:00
Sergey Biryukov
23479edf3f
Avoid PHP notices in Media Library if an attachment parent does not exist. props trepmal, viniciusmassuchetto, alex-ye, adamsilverstein for initial patches. fixes #22312 . fixes #23154 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 11:46:35 +00:00
Dominik Schilling
8ebc1c654e
Revisions: Mark deprecated arguments in wp_list_post_revisions()
.
...
* Second argument is now a string, which controls the revision type
* Back compat for $args['type']
* Remove lines for the old form-table format, since it's now just a list
props a.hoereth. fixes #24213 .
git-svn-id: http://core.svn.wordpress.org/trunk@24175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-04 12:54:00 +00:00
Dominik Schilling
ea1cecebee
Revisions UI: Add translation contexts and remove unneeded lines.
...
props nao. fixes #23917 .
git-svn-id: http://core.svn.wordpress.org/trunk@24157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-02 10:12:19 +00:00
Andrew Nacin
2ea564da8b
Terms list table:
...
* Don't call single_row() with an undeclared and unused $taxonomy argument.
* Don't define optional parameters before required parameters in the _rows() method. Make them required.
* Move empty( $terms ) check above other operations. This function was improperly returning an else case until [24123].
props rlerdorf.
see #24210 .
git-svn-id: http://core.svn.wordpress.org/trunk@24127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-29 13:39:28 +00:00
Andrew Nacin
17ddaa8de0
delete_user_setting() and remove_action() were getting called with too many args. props rlerdorf. see #24210 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-29 13:25:15 +00:00
Sergey Biryukov
dace3f0b6d
Remove redundant echo calls from list tables. Don't mix string concatenation with direct output. see #24210 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-29 01:10:50 +00:00
Mark Jaquith
1b554db95a
Post format UI refresh.
...
* Post format switcher does not go away after clicking
* Refresh of format switcher style
* Highlighting of active post format
* Prompt text goes under the switcher
* Better animations
see #24046 . props wonderboymusic, johnjamesjacoby, aaroncampbell, PeteMall.
Also, because I forgot it on [24006]: props saracannon.
git-svn-id: http://core.svn.wordpress.org/trunk@24098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-26 12:22:55 +00:00
Mark Jaquith
082e067a2d
Screen option for Post Format UI.
...
props nacin. see #23930 .
git-svn-id: http://core.svn.wordpress.org/trunk@24092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-25 07:28:33 +00:00
Mark Jaquith
90fc15e6d9
post-new.php?format=X will pre-fill the format, to allow for Post-Format-chosen-first editor jump-starting.
...
props kovshenin, wonderboymusic. fixes #24116 .
git-svn-id: http://core.svn.wordpress.org/trunk@24081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-25 02:44:23 +00:00
Andrew Nacin
e7b2915ecd
dbDelta: When parsing out the DEFAULT value, avoid being too greedy. props hbanken, fixes #15948 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 22:00:50 +00:00
Andrew Nacin
00b7fa589a
Remove ancient 'lookup' quicktag from the text editor. This had called up answers.com.
...
props mboynes, jonbishop, SergeyBiryukov.
fixes #23322 .
git-svn-id: http://core.svn.wordpress.org/trunk@24052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 20:17:25 +00:00
Andrew Nacin
b11654ce74
Revert [23871] - Customize should be added to the menu, but not hacked in as first. see #21413 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 19:33:39 +00:00
Andrew Nacin
d095eac796
Ensure that the resulting post time is localized after the date is changed. props SergeyBiryukov. fixes #24072 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 19:04:02 +00:00
Andrew Ozz
d2a8f064aa
Post locks:
...
- Show 'Saving revision...' while autosaving after a post has been taken over. Change to 'Your latest changes were saved as a revision.' when autosave completes.
- Make sure a user exists before using $user->display_name.
- Add 'post_lock_text' action for extending the message text.
git-svn-id: http://core.svn.wordpress.org/trunk@24042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 03:08:51 +00:00
Dominik Schilling
9313710f79
Post Formats: Change post screen icon on selection. props markjaquith. fixes #24140 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-19 22:00:10 +00:00
Mark Jaquith
2d382c1a5c
Post Formats: use the content body for the body of the Quote post format.
...
* Searchable, better editing tools
* Less cluttered Post Format UI
props kovshenin, DrewAPicture. see #24009
git-svn-id: http://core.svn.wordpress.org/trunk@24034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-18 18:07:58 +00:00
Andrew Nacin
ef3d64ccd9
Pass $post to display_post_states filter (in _post_states()).
...
git-svn-id: http://core.svn.wordpress.org/trunk@24028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-18 15:02:30 +00:00
Sergey Biryukov
5f2f48135b
Rename some variables for consistency. Remove redundant absint() call. see #24010 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-18 00:40:36 +00:00
Mark Jaquith
412161de03
Standardize post format postmeta keys around the ones already used by the Crowd Favorite plugin.
...
props wonderboymusic. fixes #24010 .
git-svn-id: http://core.svn.wordpress.org/trunk@24021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-17 20:57:44 +00:00
Dominik Schilling
45a9b723ee
Revisions: Clean up JavaScript variable names, see #23901 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-17 19:34:21 +00:00
Mark Jaquith
56d5d62a19
New Post Format UI chooser treatment in response to testing.
...
* Bigger icons
* Format description under each
* UI hides after choice
* Saving without choosing implies "Standard"
* Helpful text, with "Change format" link
see #24046 . props lessbloat, wonderboymusic.
git-svn-id: http://core.svn.wordpress.org/trunk@24006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-17 04:08:46 +00:00
Dominik Schilling
731f040664
Revisions UI: Remove the "To:" prefix from the header when viewing a single revision. Also prefix a revision field with a label.
...
props SergeyBiryukov, adamsilverstein, faishal. fixes #23903 .
git-svn-id: http://core.svn.wordpress.org/trunk@23994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-15 18:40:17 +00:00
Mark Jaquith
21bb61466a
Only say we accept a raw video/audio embed code for unfiltered_html users.
...
props wonderboymusic. see #23961
git-svn-id: http://core.svn.wordpress.org/trunk@23985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-14 01:21:47 +00:00
Andrew Ozz
e315287283
Fix accidental revert of revisions comparison in [23981]
...
git-svn-id: http://core.svn.wordpress.org/trunk@23982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-13 00:45:47 +00:00
Andrew Ozz
76302d7d3c
Post locks: make sure we never overwrite a draft when it's locked, clean up wp_ajax_autosave() and make wp-refresh-post-lock a bit more robust, see #23697
...
git-svn-id: http://core.svn.wordpress.org/trunk@23981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-13 00:41:15 +00:00
Mark Jaquith
94c5f0aca1
Use ID3 data for audio and video
...
fixes #23926 . props wonderboymusic, SergeyBiryukov, johnbillion.
git-svn-id: http://core.svn.wordpress.org/trunk@23979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-12 22:27:24 +00:00
Andrew Ozz
44752d0dad
Revisions: compare revisions by date in wp_ajax_revisions_data(), deprecate the $parent arg in wp_list_post_revisions() as now revisions always include a copy of the current post, props adamsilverstein, see #23901
...
git-svn-id: http://core.svn.wordpress.org/trunk@23975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-12 19:29:21 +00:00
Sergey Biryukov
97e19c7c3a
Fix typo in upgrade_100(). props tivnet, bpetty. fixes #24020 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-10 16:04:36 +00:00
Sergey Biryukov
e3e667056d
Add alt attribute for selected image. see #19570 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-09 17:12:47 +00:00
Sergey Biryukov
af0815a45c
Fix inconsistent id attributes. props kovshenin. fixes #24006 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-09 17:08:25 +00:00
Helen Hou-Sandí
bd4cc15d68
Remove unnecessary label, placeholder, and class for a hidden input. see #23938 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-07 16:49:56 +00:00
Andrew Ozz
33dd4b3d69
Revisions:
...
- Store the post format as meta on revisions (including autosaves).
- Add post formats data (post meta) when autosaving.
- Only add non-empty post formats data to revisions.
- Correct the post format when previewing a published post.
Props kovshenin, see #19570 , see #20564 .
git-svn-id: http://core.svn.wordpress.org/trunk@23928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-06 23:18:52 +00:00
Andrew Ozz
50ff2315a6
Post formats: connect labels with fields, move the two css blocks dealing with formats next to each other, see #23938
...
git-svn-id: http://core.svn.wordpress.org/trunk@23926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-06 21:40:58 +00:00
Sergey Biryukov
8d546ad739
Avoid an undefined index notice in wp_read_video_metadata(). props ocean90. fixes #23953 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-06 00:29:12 +00:00
Helen Hou-Sandí
42412f66b1
Show labels and remove improperly-used placeholders for post format fields. props Ipstenu, azaozz. see #23938 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-05 02:37:13 +00:00
Andrew Nacin
bc7082a7c3
WP_Upgrader: Add upgrader_process_complete hooks and add a abort_if_destination_exists flag (default is true). props dd32. see #18200 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-04 21:10:54 +00:00
Andrew Nacin
3015605cae
Use get_post() in lieu of direct query in wp_ajax_replyto_comment(). fixes #23940 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-04 18:44:38 +00:00
Mark Jaquith
90c2110475
A little more revisions js/php cleanup. see #23901 . props kovshenin, ocean90.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-04 16:03:21 +00:00
Andrew Nacin
14e31c8ec6
Use correct option name when deleting embed_autourls. props SergeyBiryukov. see #23715 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-04 15:55:53 +00:00
Mark Jaquith
2a38966a97
Further cleanup of revisions code. Probably not the last.
...
see #23901 . props adamsilverstein, azaozz, ocean90.
git-svn-id: http://core.svn.wordpress.org/trunk@23898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-04 07:53:49 +00:00
Andrew Nacin
10d898ecbb
Remove _wp_delete_nav_menu(). wp_delete_nav_menu() should instead remove the menu from theme locations, which was the only difference between the functions. see #23119 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-04 04:28:12 +00:00
Andrew Nacin
b62d398742
Replace $user_id removed in [23889] with a direct function call. see #23665 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-03 04:37:50 +00:00
Andrew Nacin
b77e90c5bf
No need to check for the presence of a current user in a privileged ajax action. see #23665 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-03 04:34:14 +00:00
Sergey Biryukov
ea4acee9f9
Use correct escaping function. see #23900 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 22:20:18 +00:00
Helen Hou-Sandí
c08fb9d182
Since post format meta for images now takes an attachment ID only, make sure we label it appropriately and don't do things like esc_url() the value. fixes #23900 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 20:56:18 +00:00
Mark Jaquith
fec4b66f5b
Sanity checks on image metadata to avoid warnings, etc.
...
fixes #23733 . props wonderboymusic.
git-svn-id: http://core.svn.wordpress.org/trunk@23873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 20:51:35 +00:00
Mark Jaquith
925e7f5bd6
Make sure the first revision is seen as coming from emptiness, so it can be restored.
...
props adamsilverstein. fixes #23898 .
git-svn-id: http://core.svn.wordpress.org/trunk@23872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 20:50:09 +00:00
Mark Jaquith
8c4aeb9188
Add "Customize" as first item under Appearance menu.
...
fixes #21413 . props ryanhellyer, obenland, DrewAPicture
git-svn-id: http://core.svn.wordpress.org/trunk@23871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 20:39:54 +00:00
Mark Jaquith
1127ad37a8
Use the revisioned post format metadata when previewing.
...
fixes #23539 . props kovshenin.
git-svn-id: http://core.svn.wordpress.org/trunk@23862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 12:08:42 +00:00
Sergey Biryukov
fc26b5e683
Remove duplicate array keys. props kovshenin. see #19570 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 11:07:09 +00:00
Mark Jaquith
fb78aa819e
Use jQuery.on() properly. Add some slideUp()/slideDown() transitions to ease post format switches. see #19570
...
git-svn-id: http://core.svn.wordpress.org/trunk@23853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 07:06:21 +00:00
Mark Jaquith
c93e0231af
Post Format UI.
...
* Icons
* Selection
* Prompt text
* Special fields
* Styling
* Sparkles
This is going to need testing, polish, and love.
see #19570 . props melchoyce, helen, wonderboymusic, lessbloat, rachelbaker, aaroncampbell, DrewAPicture, ryelle.
git-svn-id: http://core.svn.wordpress.org/trunk@23843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 03:35:41 +00:00
Mark Jaquith
ab9b0206c8
Make sure that the ID of the right revision is not less than the ID of the left revision
...
see #23497
git-svn-id: http://core.svn.wordpress.org/trunk@23832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-28 02:49:55 +00:00
Mark Jaquith
6b79783e63
correct a revision/tooltip mismatch.
...
props adamsilverstein. see #23497
git-svn-id: http://core.svn.wordpress.org/trunk@23831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-28 01:51:12 +00:00
Mark Jaquith
271030746c
RTL for Nav Menu tweaks. see #23641 . see #23645 . props lessbloat
...
git-svn-id: http://core.svn.wordpress.org/trunk@23808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-27 08:53:26 +00:00
Peter Westwood
9d6988a221
Revisions: UI Update.
...
* Refines the UI to make it clearer and easier to use
* Introduces weighted tickmarks
* Fixes comparison bugs.
See #23497 props adamsilverstein
git-svn-id: http://core.svn.wordpress.org/trunk@23769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-21 15:54:11 +00:00
Mark Jaquith
ebdcf967a3
Show a playable audio/video preview on the Edit Attachment screen.
...
props wonderboymusic. fixes #23726
git-svn-id: http://core.svn.wordpress.org/trunk@23768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-21 05:17:25 +00:00
Mark Jaquith
12d3fc7999
Add functions for generating metadata for video and audio, using the
...
ID3 library. Also allows themes/plugins to add thumbnail support
to these media types. Think stuff like album art, movie covers, and
video freeze-frames.
props wonderboymusic. fixes #23673
git-svn-id: http://core.svn.wordpress.org/trunk@23766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-21 04:55:42 +00:00
Helen Hou-Sandí
d6fee50fd3
Lose the added column for post formats in the posts list table and add an icon before the title instead. Icons are clickable to filter the list table down to posts of that post type and format. props melchoyce for the icons. fixes #16047 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-21 03:23:39 +00:00
Andrew Ozz
667e779968
Post locks: contain focus inside the dialog when tabbing, remove outline when focus is on the text, see #23697
...
git-svn-id: http://core.svn.wordpress.org/trunk@23763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-21 00:57:27 +00:00
Ryan Boren
9890179bce
Make the before() and after() methods in Bulk_Plugin_Upgrader_Skin and Bulk_Theme_Upgrader_Skin declarations match Bulk_Upgrader_Skin. Eliminates strict standards warning.
...
Props charlestonsw
fixes #23807
git-svn-id: http://core.svn.wordpress.org/trunk@23749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-19 03:24:51 +00:00
Ryan Boren
dfd8479246
Fix i18n for revision diff strings displaying human time.
...
Props johnbillion
fixes #23723
git-svn-id: http://core.svn.wordpress.org/trunk@23743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-18 17:58:30 +00:00
Ryan Boren
830c802c90
Don't allow changing the post format from quick edit and bulk edit. These do not have sufficient context to set the post format.
...
Props kovshenin
fixes #23426
git-svn-id: http://core.svn.wordpress.org/trunk@23742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-18 17:24:24 +00:00
Ryan Boren
469d1a3099
Escape form action urls with esc_url() rather than esc_attr().
...
Props SergeyBiryukov
fixes #23266
git-svn-id: http://core.svn.wordpress.org/trunk@23739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-18 14:01:25 +00:00
Andrew Ozz
30ad180d6a
Create one autosave per user rather than a single autosave for all users. Remove unused code from autosave.js and wp_ajax_autosave(). See #23665 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-16 21:15:43 +00:00
Andrew Ozz
10f565cd6c
Post locks: when a dialog is shown move focus to the text, see #23697
...
git-svn-id: http://core.svn.wordpress.org/trunk@23733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-16 20:46:37 +00:00
Mark Jaquith
53d12e91bc
Introduce [audio] and [video] shortcodes, and use MediaElement.js to play them.
...
props wonderboymusic. see #23282 .
git-svn-id: http://core.svn.wordpress.org/trunk@23729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-16 05:25:44 +00:00
Mark Jaquith
9bd740f616
Accessibility revamp for nav menus.
...
props lessbloat. fixes #14045
git-svn-id: http://core.svn.wordpress.org/trunk@23727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-16 04:47:19 +00:00
Andrew Ozz
99488cb638
Post locks: add Preview button when post is locked, fix the suggested places, see #23312
...
git-svn-id: http://core.svn.wordpress.org/trunk@23725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 21:09:20 +00:00
Sergey Biryukov
63dfa74c9f
Remove unused variables. props GaryJ. fixes #23789 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 17:08:04 +00:00
Sergey Biryukov
099c3c6422
Remove unused variable. props DrewAPicture. fixes #23782 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 16:23:36 +00:00
Mark Jaquith
83bb916b81
Turn the Nav Menu meta boxes into an accordion. Less sprawling and overwhelming.
...
* Registration stays the same — they're meta boxes
* Call `do_accordion_sections()` instead of `do_meta_boxes()` and they render as an accordion
props DrewAPicture, lessbloat, jkudish. fixes #23450 . see #23449
git-svn-id: http://core.svn.wordpress.org/trunk@23707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 13:16:38 +00:00
Andrew Ozz
21c2d8662c
Logged out warnings: remove the logged out warning from autosave when in login_grace_period, see #23295
...
git-svn-id: http://core.svn.wordpress.org/trunk@23699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-14 21:31:02 +00:00
Andrew Ozz
d46102d258
Logged out warnings, heartbeat: remove nopriv_autosave as it doubles the functionality of the logged out warnings, move wp_ajax_nopriv_heartbeat() under No-privilege Ajax handlers in ajax-actions.php, see #23295 , see #23216
...
git-svn-id: http://core.svn.wordpress.org/trunk@23692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-13 23:54:12 +00:00
Andrew Ozz
e9245269a7
Autosave to the browser's sessionStorage, compare this autosave to the post content on page load and let the user restore it when the data is not the same. First run, see #23220
...
git-svn-id: http://core.svn.wordpress.org/trunk@23683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-13 10:08:16 +00:00
Andrew Ozz
3b4b058275
Post locks on the posts list screen: new icons for the lock, props empireoflight, show avatar for the user currently editing, props dh-shredder, see #23312
...
git-svn-id: http://core.svn.wordpress.org/trunk@23681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-13 00:28:07 +00:00
Sergey Biryukov
28248c1b08
Make get_home_path() return consistent slashes. fixes #23175 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-12 11:04:14 +00:00
Sergey Biryukov
f86b1502a0
Fix fatal error in WP_User_Query when searching users by URL. Move wp_is_large_network() to wp-includes. fixes #23683 for trunk.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-12 09:19:55 +00:00
Sergey Biryukov
f29bb91f05
Fix missing i18n in auto-draft titles. fixes #23565 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-12 08:57:27 +00:00
Andrew Ozz
edb9333d40
Check post locks with heartbeat and display modal notifications when a post is locked or a user takes over editing, props dh-shredder, see #23697
...
git-svn-id: http://core.svn.wordpress.org/trunk@23661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-12 03:22:30 +00:00
Sergey Biryukov
539ad97c8b
Replace deprecated WP_Screen::is_network property with WP_Screen::in_admin( 'network' ). props bpetty. fixes #23215 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-09 03:52:27 +00:00
Peter Westwood
51db623107
Revisions: Updates to the new Revisions UI.
...
Various Updates including:
* i18n fixes
* Added tracking of what revision ID was restored
* async fetching of diffs so that slider works sooner even with many revisions
See #23497 props adamsilverstein, ethitter
git-svn-id: http://core.svn.wordpress.org/trunk@23639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-07 15:32:26 +00:00
Sergey Biryukov
831afad92c
When adding a new user in the admin, strip slashes from the password sent to the user by email. props hakre for initial patch. fixes #17018 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-07 06:00:16 +00:00
Sergey Biryukov
caf591b7aa
Declare the variable before using it. props danielbachhuber. fixes #23710 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-07 04:46:19 +00:00
Ryan Boren
da7db424de
Call them network upgrades rather than network updates to better indicate that they are DB upgrades rather than code/file upgrades.
...
Improve the contextual help for the Network Upgrade screen.
Props DrewAPicture
fixes #23540
git-svn-id: http://core.svn.wordpress.org/trunk@23619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-05 17:02:31 +00:00
Helen Hou-Sandí
fffc2e1ab1
Prevent an unseemly gap on the edit screen when nothing else displays before normal meta boxes. Give better HTML and visual structure to items added via edit_form_after_title
and edit_form_after_editor
. Using a class of .edit-form-section
will now get you a 20px bottom margin; perfect for your additions to the post edit screen. fixes #23240 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-04 23:22:17 +00:00
Sergey Biryukov
581975e9bf
Add description for wp_dashboard_rss_output(). props aaronholbrook for initial patch. fixes #23301 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-04 04:34:39 +00:00
Sergey Biryukov
f288da4b7b
Use correct variable. see [23575]. see #21767 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-02 21:10:12 +00:00
Andrew Nacin
7b47322e22
Ensure the referer functions operate completely on unslashed data: wp_referer_field(), wp_original_referer_field(), wp_get_referer(), wp_get_original_referer().
...
Use wp_slash() instead of addslashes().
see #21767 .
git-svn-id: http://core.svn.wordpress.org/trunk@23578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:58:43 +00:00
Andrew Nacin
76c03073d9
Remove an unslash in the deprecated WP_User_Search, as search_term is already unslashed in the constructor. see #21767 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:57:49 +00:00
Andrew Nacin
237f810852
Unslash early, directly on the superglobal. see #21767 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:57:08 +00:00
Andrew Nacin
4e06d41b9f
Assume that url_shorten() receives unslashed data, as it does in core usage. see #21767 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:56:31 +00:00
Ryan Boren
f3a83744e9
Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
...
git-svn-id: http://core.svn.wordpress.org/trunk@23567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:14:09 +00:00
Ryan Boren
68b11a7c8f
Use prepare instead of escape.
...
see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:01:01 +00:00
Ryan Boren
5f809d1d22
Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
...
see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:00:25 +00:00
Sergey Biryukov
4aca3c1e89
Consistently apply 'preview_post_link' filter. fixes #19378 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:46:25 +00:00
Ryan Boren
43a7e695e9
Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
...
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:28:40 +00:00
Sergey Biryukov
0bb47182a4
Remove redundant esc_url() call. props pauldewouters. fixes #23643 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:27:03 +00:00
Andrew Nacin
401e88e387
Ignore protected meta keys in meta_form(). see #18786 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-28 19:51:29 +00:00
Andrew Nacin
afd9cbced9
Make Twenty Thirteen the default theme.
...
Has the added benefit of ensuring the WordPress Beta Tester plugin allows updates of Twenty Thirteen.
props JustinSainton.
fixes #23573 .
git-svn-id: http://core.svn.wordpress.org/trunk@23529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-28 19:01:07 +00:00
Peter Westwood
5c533c9b27
Revisions: Fix up some half renamed variables that break the view and display a mismash of split and combined views. See #23497 props adamsilverstein.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-28 16:48:33 +00:00
Peter Westwood
5133b4990b
Revisions: Fix up some bugs I introduced while reviewing the mega revisions patch - when comparing two historical revisions only one half of the diff would load
...
See #23497 props adamsilverstein.
git-svn-id: http://core.svn.wordpress.org/trunk@23508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-28 16:10:45 +00:00
Peter Westwood
9bd192fab3
Revisions: First pass an implementing a new UI/UX for reviewing the revisions of posts. See #23497 props adamsilverstein for the initial patch.
...
This implements a new revisions ui using Backbone and preserves all the old methods of "integration" so the change should be transparent to plugins using revisi
ons with CPTs.
This is the first pass and so there are a number of things still to be resolved, more details in the ticket. Feedback welcomed.
git-svn-id: http://core.svn.wordpress.org/trunk@23506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-28 15:14:34 +00:00
Sergey Biryukov
ccd6e6aeec
Don't override filtered screen options on Widgets screen. props bradyvercher. fixes #23239 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-28 07:40:11 +00:00
Andrew Ozz
9a827a485e
Post locks: use heartbeat to dynamically update locked posts on the Posts screen, first run, see #23312
...
git-svn-id: http://core.svn.wordpress.org/trunk@23487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-25 23:17:10 +00:00
Sergey Biryukov
5777e5a949
Rename 'no_tagcloud' taxonomy label to 'not_found', for consistency with the post type label of the same key. fixes #23597 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-25 19:39:38 +00:00
Sergey Biryukov
bf1ca6b9ca
Move 'no_tagcloud' argument to the taxonomy labels object. props DrewAPicture for initial patch. fixes #23597 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-25 18:35:05 +00:00
Andrew Ozz
9c2ebc4c60
Heartbeat API: add nopriv actions, add JS 'heartbeat-send' event, see #23216
...
git-svn-id: http://core.svn.wordpress.org/trunk@23481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-25 02:32:22 +00:00
Sergey Biryukov
b5c34dc411
Fix typo in phpdoc. see #17515 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-19 23:40:03 +00:00
Helen Hou-Sandí
ad85d07189
Edit screen UI for post formats: a first run for functionality.
...
* Adds a very basic tabbed interface for selecting a post format (requires JS).
* Extra fields, which are post meta, are shown/hidden based on the selected format.
* Introduce a helper function for retrieving formats-specific metadata: `get_post_format_meta()`.
* Image selection uses the media modal, although without filtering or from URL support at the moment.
props rachelbaker, wonderboymusic, aaroncampbell, helen. see #19570 .
git-svn-id: http://core.svn.wordpress.org/trunk@23449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-18 19:11:24 +00:00
Andrew Nacin
83e0ce2ac1
Remove unused variables reset by wp_reset_vars(). Many of these haven't been used since b2. see #21767 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-16 18:28:41 +00:00
Mark Jaquith
52c46736df
Improve the UX of the Nav Menus screen. Kill the tabs, and change to a
...
dropdown, unless you have zero or one menus (which is the most common),
in which case you jump right into editing your sole menu.
Do assignment to location using checkboxes in the main menu editing
section instead of the backwards menu => location assignment in a
random meta box.
More to come, but this gets us started.
props lessbloat, DrewAPicture, jkudish. see #23119
git-svn-id: http://core.svn.wordpress.org/trunk@23441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-16 04:53:59 +00:00
Sergey Biryukov
bc2ff9d342
Deprecate wp_convert_bytes_to_hr() in favor of size_format(). props F J Kaiser. fixes #19067 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-16 03:07:56 +00:00
Sergey Biryukov
6bcd1665eb
Add missing inline descriptions. see #19067 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-16 02:52:57 +00:00
Sergey Biryukov
34862544fe
Correct return value for comment_exists(). fixes #20494 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-15 18:49:07 +00:00
Sergey Biryukov
2312092aad
Allow filtering attachments by Author name in Media Library. props greuben. fixes #16044 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-15 17:33:28 +00:00
Mark Jaquith
d48d025403
"LGPL License" is redundant.
...
props wonderboymusic, jakub.tyrcha. fixes #15585
git-svn-id: http://core.svn.wordpress.org/trunk@23425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-15 16:26:46 +00:00
Ryan Boren
cc5ed3a485
Change all core API to expect unslashed rather than slashed arguments.
...
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.
Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.
Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.
Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.
Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.
Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.
Plugins should use wp_unslash() on data being passed to core API.
Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.
Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.
Remove many no longer necessary calls to $wpdb->escape() and esc_sql().
In wp_get_referer() and wp_get_original_referer(), return unslashed data.
Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.
Switch several queries over to prepare().
Expect something to break.
Props alexkingorg
see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:51:06 +00:00
Mark Jaquith
00dbfdf89e
Document the mysterious seventh parameter of add_meta_box().
...
props wonderboymusic, markjaquith. fixes #17515
git-svn-id: http://core.svn.wordpress.org/trunk@23397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:37:34 +00:00
Mark Jaquith
ddd1b94184
Link post formats in posts list table. Use a dash for standard, like we do for absence of tags. see #16047 Next: use icons, not text descriptions.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:34:51 +00:00
Mark Jaquith
dab5a6ef7d
Fix some tabbing issues on the post editing screen. Add Media no longer skipped when going backwards from content. Save Draft no longer skipped when going forwards from content.
...
props adamsilverstein. fixes #23195 and #22933
git-svn-id: http://core.svn.wordpress.org/trunk@23395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:30:09 +00:00
Helen Hou-Sandí
1c816c795b
Open external links to plugin homepages, plugin author homepages, and theme author homepages in a new window/tab. props SergeyBiryukov. fixes #20839 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 16:20:01 +00:00
Mark Jaquith
2fb915f860
Display post formats in the posts list table.
...
props nacin, garyc40, DrewAPicture, wonderboymusic, aaroncampbell.
fixes #16047
git-svn-id: http://core.svn.wordpress.org/trunk@23392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 16:10:05 +00:00
Andrew Ozz
6c41e93fec
Heartbeat API: throttle down when the window looses focus or when the user is inactive, always send 'screen_id', change the interval settings to 'fast' (5sec), 'standard' (15sec) and 'slow' (60sec), the interval can be changed from PHP, see #23216
...
git-svn-id: http://core.svn.wordpress.org/trunk@23382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-03 07:03:27 +00:00
Andrew Nacin
55ba72f46e
Confirm a user exists before deleting them in wp_delete_user() and wpmu_delete_user(). props scribu, fixes #23067 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 04:41:02 +00:00
Sergey Biryukov
2967871d34
Return WP_Error from wp_crop_image() if saving has failed. props macbrink. fixes #23325 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 02:01:59 +00:00
Andrew Nacin
91e3f2b866
Clean up rendering of the title column in the posts list table. Simplify branching. Use get_userdata() rather than get_user_by( 'id' ). Change string to '%s is currently editing'. see #23312 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 01:54:06 +00:00
Andrew Ozz
0674bbfa8a
Posts screen: show when a post is "locked", hide the checkbox, Quick Edit and Trash links, props dh-shredder, see #23312
...
git-svn-id: http://core.svn.wordpress.org/trunk@23371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 01:31:06 +00:00
Andrew Ozz
98bf511b56
Heartbeat API: first run, see #23216
...
git-svn-id: http://core.svn.wordpress.org/trunk@23355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-29 06:15:25 +00:00
Helen Hou-Sandí
28f6c5bcf4
Remove the long-broken and questionably useful [more]/[less] toggle for hierarchical taxonomies in Quick/Bulk Edit. Nobody seems to have noticed in the nearly 3 years it's been broken. fixes #23006
...
git-svn-id: http://core.svn.wordpress.org/trunk@23354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 22:36:15 +00:00
Sergey Biryukov
72784ad6c2
Consistently use a helper function instead of directly printing the disabled attribute.
...
Remove an erroneous esc_attr() call.
fixes #23194 .
git-svn-id: http://core.svn.wordpress.org/trunk@23352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 03:23:01 +00:00
Sergey Biryukov
3e917ac75f
Make sure the post exists before checking its ID. fixes #23026 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 02:55:06 +00:00
Sergey Biryukov
3d8a1289d2
Add missing inline descriptions.
...
props momo360modena, aaronholbrook.
see #20494 , fixes #23304 .
git-svn-id: http://core.svn.wordpress.org/trunk@23350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 02:20:47 +00:00
Sergey Biryukov
428e9baba7
Correct return value for WP_Filesystem_Base::gethchmod(). props bananastalktome. fixes #23121 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 01:55:39 +00:00
Dion Hulse
33d913220b
Core Update: Fix a issue which caused automatic upgrades from 2.7 to 3.5+ to fail. Pre-2.7 WP_Filesystem::wp_content_dir() returned unslashed paths. Introduced in [22227]. See #23177
...
git-svn-id: http://core.svn.wordpress.org/trunk@23297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-11 10:16:45 +00:00
Andrew Nacin
1fa8476425
Ensure we wp_die() at the end of an ajax action. see #23055 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-07 03:59:44 +00:00
Andrew Nacin
5d980a8e8e
Whenever we have compat fields to render, send a dummy menu_order field (which was always sent in 3.4) to ensure an unchecked checkbox can still be processed by attachment_fields_to_save. fixes #22868 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-05 03:50:28 +00:00
Peter Westwood
f683fc7677
Tighten our braces. Fixes #23118 props evansolomon.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-04 10:13:51 +00:00
Dion Hulse
9f6638747d
Upgrade: When upgrading from WordPress 3.5, if an empty twentytwelve theme directory exists, remove it to allow the installation of Twenty Twelve. See #22856 . For trunk
...
git-svn-id: http://core.svn.wordpress.org/trunk@23253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-03 07:42:16 +00:00
Andrew Nacin
f0a8acc6b6
Don't stomp existing sizes inside wp_save_image().
...
props markoheijnen.
see #22985 .
for trunk.
git-svn-id: http://core.svn.wordpress.org/trunk@23246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-03 05:23:36 +00:00
Andrew Nacin
5491a56363
Remove deleted files on upgrade, including wp-app.php and class-wp-atom-server.php.
...
props duck_
see #22855
for trunk
git-svn-id: http://core.svn.wordpress.org/trunk@23203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-26 20:34:30 +00:00
Helen Hou-Sandí
b1f1579604
its <=> it's in documentation, along with a rogue the, The, and looses. props trepmal. fixes #22665 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-20 15:55:32 +00:00
Dion Hulse
39a19e1d76
When copying new bundled themes & plugins, bail early if the distro doesn't include the bundled item. This prevents us from creating an empty directory in the destination when the source doesn't exist. See #22856
...
git-svn-id: http://core.svn.wordpress.org/trunk@23179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-15 03:09:50 +00:00
Andrew Nacin
de3a5b8694
Use 3 * HOUR_IN_SECONDS rather than 10800.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-12 07:30:28 +00:00
Andrew Nacin
cfe6e9ed09
Rip keyboard shortcuts out of the image editor help. props helenyhou. fixes #22786 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 09:21:27 +00:00
Mark Jaquith
1419b404a8
Add the ability to click "Edit" and kick out to the advanced image editor from within the Media modal. New window, with "Refresh" offered on your return. fixes #22743 . props koopersmith, nacin, helenyhou.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 05:52:19 +00:00
Mark Jaquith
68524f7c6f
Run the attachment_fields_to_save filter even if we don't get the fields we used to get. props nacin. fixes #22774
...
git-svn-id: http://core.svn.wordpress.org/trunk@23094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 05:34:17 +00:00
Andrew Nacin
08401b9e3c
Fix branchhing in edit_post() where attachment_fields_to_save would only run when the alt text was sent. It should run whenever an attachment is saved. props sc0ttclark. fixes #22774 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 03:50:31 +00:00
Daryl Koopersmith
8efc323e2e
Add hidden fields via attachment_fields_to_edit to the existing compat output. props nacin. fixes #22769 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 03:28:21 +00:00
Andrew Nacin
173806d7a1
Restore the Description field to the media UI in 3.5.
...
We tried in vain -- a noble but ultimately failed effort -- to reduce the number of fields for attachments from four (title, caption, alt, description) to one (caption for images, title otherwise). Alternative text needed to stay for accessibility reasons, of course.
Eventually title returned due to heavy plugin reliance. Description is too used by too many plugins (often times incorrectly -- the caption is more likely the proper field), hence its less-than-triumphant return today.
Version 3.5 has tried to streamline media in a number of ways. Removing fields may have been too much at once, as it forced not only a user interface change, but a paradigm change as well.
Finally, on upload we populate the description field with IPTC/EXIF captions, rather than the caption field. See #22768 , this should be fixed. For now, Description stays.
This commit also restores 'Title' attribute editing to the main tab of the Edit Image dialog. The "Title" field no longer populates title attributes for <img> tags by design (for accessibility and other purposes, see #18984 ). So, here is a more obvious 'workaround' for the tooltip community.
Finally, this:
* Cleans up the post.php attachment editor, including by showing a prettier form of the mime type.
* Enables plugins to specifically hide attachment_fields_to_edit from either post.php (where you can create meta boxes) or the modal (which you may not want to clutter), for compatibility reasons.
* Hides the 'Describe this file...' placeholder when a field is read-only in the modal.
props nacin, helenyhou.
fixes #22759 .
git-svn-id: http://core.svn.wordpress.org/trunk@23083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 00:41:06 +00:00
Andrew Nacin
a13a011265
Translate the 'First Steps with WordPress' Codex link. props SergeyBiryukov, fixes #22767 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 22:51:24 +00:00
Andrew Nacin
ce11438e77
Media list table: Fix the categories column, hidden thanks to a typo. props eddiemoya, fixes #22764 . see #21240 , #21391 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 22:49:51 +00:00
Mark Jaquith
bc8ddb3e64
Intelligently make media fields readonly when the user cannot update or do anything with them. props koopersmith, helenyhou, nacin. fixes #22613
...
git-svn-id: http://core.svn.wordpress.org/trunk@23072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 10:29:24 +00:00
Andrew Nacin
40ae89369f
Admin ajax: Roll back new-style error sending in set-post-thumbnail. The JS handlers know to parse an unrecognized response (like -1 or 0) as a failure. see #21776 . see #22750 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 02:34:00 +00:00
Andrew Nacin
0bd02ac6bb
Use correct button class hierarchy to ensure the 'Update' button is button-large. see #21598 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 22:02:25 +00:00
Ryan Boren
a200c702e0
Only show Delete in media modal if the user can delete.
...
Props nacin, koopersmith
fixes #22711
git-svn-id: http://core.svn.wordpress.org/trunk@23032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 18:33:51 +00:00
Ryan Boren
63662a9b7b
In the QuickPress media modal, use the new post id when a post is published.
...
Props nacin, koopersmith
fixes #22673
git-svn-id: http://core.svn.wordpress.org/trunk@22994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 07:17:10 +00:00
Andrew Nacin
5d0933d884
Bring Featured Images back into the main media dialog.
...
Most users don't realize that the Featured Image meta box exists; if they do, few use it.
Restores the old meta box UI, including the admin_post_thumbnail_html filter. If a plugin is using _wp_post_thumbnail_html() in conjunction with Thickbox elsewhere, it will also magically still work.
Specific underlying changes:
* Converts the modal view to use the view manager, which means that a call to open() will automatically call render and attach if necessary.
* Doesn't automatically set a state in wp.media, to allow code to customize the states to be added before activation.
props koopersmith.
fixes #21776 .
git-svn-id: http://core.svn.wordpress.org/trunk@22979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 02:38:10 +00:00
Andrew Nacin
27bf82201b
Allow the 'Uploaded to this post' view to be sorted, saving the resulting order as menu_order.
...
This functionality is designed to be backwards compatible with manual querying for attachments by menu_order.
props koopersmith.
see #22607 .
git-svn-id: http://core.svn.wordpress.org/trunk@22967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-02 16:06:31 +00:00
Ryan Boren
b7b54c00e9
Namespace the dashboard widget nonce to avoid collisions with plugins.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-02 00:12:43 +00:00
Andrew Nacin
cb3b72f3be
Remove stray single quote in attachment_submit_meta_box(). props Yogi T. fixes #22674 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-01 18:59:16 +00:00
Ryan Boren
22bc8cc437
Properly pass WordPress uploading errors to wp.Uploader.
...
Props koopersmith
fixes #22655
git-svn-id: http://core.svn.wordpress.org/trunk@22954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 15:40:09 +00:00
Ryan Boren
f07c7f5163
Refine media state machine methods.
...
* state( id ) becomes setState( id )
* get( id ) becomes state( id )
* state() stays the same
* previous() becomes lastState()
Props koopersmith
fixes #22652
git-svn-id: http://core.svn.wordpress.org/trunk@22952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 15:19:11 +00:00
Ryan Boren
ea3e47bc08
Add a create_posts check to _wp_translate_postdata(). Move the edit_post check to the top of the function.
...
Props nacin
fixes #22417
git-svn-id: http://core.svn.wordpress.org/trunk@22950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 14:03:47 +00:00
Ryan Boren
d4abd95449
Scope button classes so they can be used on the frontend without interfering with theme styles.
...
Props helenyhou, koopersmith
fixes #22644
git-svn-id: http://core.svn.wordpress.org/trunk@22948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 13:40:59 +00:00
Andrew Nacin
24b82f2c3b
Nonces for dashboard controls.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 00:01:02 +00:00
Ryan Boren
27d943786b
Introduce API to add back the description field in the new media popup.
...
Props nacin
fixes #22642
git-svn-id: http://core.svn.wordpress.org/trunk@22929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 23:52:30 +00:00
Andrew Nacin
a8d599eae5
Fix disabling of the link manager on upgrade from 3.4.2 when there are no links.
...
In the 3.4 branch we bumped the DB version past the version used for disabling links in trunk, preventing it from running. In the future, we must avoid increasing branch DB version bumps to HEAD.
props SergeyBiryukov.
fixes #22626 .
git-svn-id: http://core.svn.wordpress.org/trunk@22911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 00:37:30 +00:00
Andrew Nacin
346e45c56b
Adjust size of the 'Clear List' list table button. Fix placement of other buttons next to bulk actions. props johnbillion, SergeyBiryukov, fixes #22621 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 22:20:45 +00:00
Andrew Nacin
fe3ace4f05
Feature pointers:
...
* Finalize the text for the media pointer. Offer it for translation.
* Remove the favorites pointer.
fixes #22454 .
git-svn-id: http://core.svn.wordpress.org/trunk@22874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 18:58:07 +00:00
Ryan Boren
cc9b248937
Always send nocache_headers() for admin-ajax.php. This prevents iOS from caching ajax calls. http://stackoverflow.com/questions/12506897/is-safari-on-ios-6-caching-ajax-results
...
Turn off multi selection uploads for mobile devices. Currently Plupload cannot upload multiple files in iOS Safari. Only the first file makes it to the queue.
Empty wp on unload to work around caching in iOS Safari.
Props azaozz, miqrogroove, nacin
fixes #22552
git-svn-id: http://core.svn.wordpress.org/trunk@22872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 16:17:53 +00:00
Ryan Boren
939a47ba48
Add a delete link to the media modal.
...
Props merty, nacin, koopersmith
fixes #22524
git-svn-id: http://core.svn.wordpress.org/trunk@22869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 15:50:59 +00:00
Ryan Boren
11c5f2c1fc
Only show the image edit button for image attachments. Props markoheijnen. fixes #22596
...
git-svn-id: http://core.svn.wordpress.org/trunk@22867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 15:06:02 +00:00
Ryan Boren
d4159bf041
In wp_image_editor(), use wp_image_editor_supports() to check for rotation capabilities rather than directly checking the existence of the imagerotate function.
...
In WP_Image_Editor_GD::test(), check for existence of imagerotate if the rotate capability is required.
Props DH-Shredder
fixes #22597
git-svn-id: http://core.svn.wordpress.org/trunk@22863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 14:36:55 +00:00