Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-27 19:47:42 +01:00
Code Issues Projects Releases Wiki Activity
40,973 Commits 50 Branches 749 Tags 806 MiB
02d01de6c5
Commit Graph

14677 Commits

Author SHA1 Message Date
Sergey Biryukov
d273235abd Login/Registration: Pass the error data to the wp_login_failed action. 
Props hamedmoodi, rixeo.
Fixes #49007.
Built from https://develop.svn.wordpress.org/trunk@46971


git-svn-id: http://core.svn.wordpress.org/trunk@46771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-17 15:36:01 +00:00
Sergey Biryukov
a79636f82a Docs: Correct @type for timeout argument in WP_Http::request(). 
Props georgestephanis, benedictsinger.
Fixes #49005.
Built from https://develop.svn.wordpress.org/trunk@46970


git-svn-id: http://core.svn.wordpress.org/trunk@46770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-17 15:25:01 +00:00
Sergey Biryukov
18b0cd4f7d Date/Time: Add a unit test for [46968]. 
See #48145.
Built from https://develop.svn.wordpress.org/trunk@46969


git-svn-id: http://core.svn.wordpress.org/trunk@46769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-17 14:37:02 +00:00
Sergey Biryukov
c0b6dffffc Date/Time: In wp_insert_post(), when checking the post date to set future or publish status, use a proper delta comparison. 
[3525] allowed a difference up to 59 seconds between the post date/time and the current time to consider the post published instead of scheduled, but that didn't take start of a new minute into account.

Rapidly creating post fixtures in unit tests could encounter a one-second discrepancy between `current_time( 'mysql' )` and `gmdate( 'Y-m-d H:i:s' )`, returning values like `2019-12-16 23:43:00` vs. `2019-12-16 23:42:59`, respectively, and setting the post to a `future` status instead of `publish`.

[45851], while working as intended, made the issue somewhat more likely to occur.

This caused all sorts of occasional random failures in various tests on Travis, mostly on PHP 7.1.

Fixes #48145.
Built from https://develop.svn.wordpress.org/trunk@46968


git-svn-id: http://core.svn.wordpress.org/trunk@46768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-17 02:25:03 +00:00
Andrew Ozz
c67c3ee6a0 Fix the colors in all color schemes for the .active class for buttons. 
Props ryelle, audrasjb.
Fixes #49003 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46967


git-svn-id: http://core.svn.wordpress.org/trunk@46767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-17 00:15:03 +00:00
Andrew Ozz
ef7326129f Upload: Fix the final file name collision test in wp_unique_filename() when uploading a file with upper case extension. Add a unit test to catch that in the future. 
Fixes #48975 for trunk.

Built from https://develop.svn.wordpress.org/trunk@46966


git-svn-id: http://core.svn.wordpress.org/trunk@46766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-16 23:44:04 +00:00
Andrew Ozz
e0ace80488 Upload: 
- Fix PHP warnings in `wp_unique_filename()` when the destination directory is unreadable.
- Run the final name collision test only for files that are saved to the uploads directory.
- Update the unit tests to match.

Props eden159, audrasjb, azaozz.
Fixes #48960 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46965


git-svn-id: http://core.svn.wordpress.org/trunk@46765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-16 23:23:06 +00:00
Sergey Biryukov
8894c0f1a2 Coding Standards: Use strict comparison in wp-admin/widgets.php. 
Props jenilk.
Fixes #49000.
Built from https://develop.svn.wordpress.org/trunk@46964


git-svn-id: http://core.svn.wordpress.org/trunk@46764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-16 12:55:03 +00:00
Sergey Biryukov
5b9fd2d7e7 Coding Standards: Use strict comparison in wp-admin/includes/network.php. 
Props ataurr.
Fixes #48994.
Built from https://develop.svn.wordpress.org/trunk@46963


git-svn-id: http://core.svn.wordpress.org/trunk@46763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-16 12:37:06 +00:00
Sergey Biryukov
6d40400756 Coding Standards: Use strict comparison in wp-admin/edit-tags.php. 
Props passoniate.
Fixes #48985.
Built from https://develop.svn.wordpress.org/trunk@46962


git-svn-id: http://core.svn.wordpress.org/trunk@46762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-15 10:46:02 +00:00
Sergey Biryukov
087282e810 Coding Standards: Use strict comparison in wp-admin/term.php. 
Props vinita29.
Fixes #48983.
Built from https://develop.svn.wordpress.org/trunk@46961


git-svn-id: http://core.svn.wordpress.org/trunk@46761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-15 09:45:01 +00:00
Sergey Biryukov
35b29f11b3 Coding Standards: Add missing braces to if conditions in js/_enqueues/wp/util.js. 
Props ankitmaru.
Fixes #48980.
Built from https://develop.svn.wordpress.org/trunk@46960


git-svn-id: http://core.svn.wordpress.org/trunk@46760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-15 08:45:05 +00:00
Sergey Biryukov
1b675c6e4a Formatting: Return early from wp_kses_attr_check() if the element is not in the list of allowed elements and attributes. 
Props krynes, tristanleboss.
Fixes #48549.
Built from https://develop.svn.wordpress.org/trunk@46959


git-svn-id: http://core.svn.wordpress.org/trunk@46759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-14 15:53:06 +00:00
Sergey Biryukov
8260786e64 Docs: Clarify descriptions for get_gmt_from_date() and get_date_from_gmt(). 
Props johnbillion, Rarst.
Fixes #48650.
Built from https://develop.svn.wordpress.org/trunk@46958


git-svn-id: http://core.svn.wordpress.org/trunk@46757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-13 21:45:02 +00:00
Sergey Biryukov
0b8438a6d2 I18N: Replace file names in translatable strings on Permalink Settings screen with placeholders. 
Props ramiy.
Fixes #48863.
Built from https://develop.svn.wordpress.org/trunk@46957


git-svn-id: http://core.svn.wordpress.org/trunk@46756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-13 21:27:05 +00:00
ianbelanger
48692b6524 Bundled Themes: Bump version number and update changelog in Twenty Twenty for WordPress 5.3.1. 
This bumps the Twenty Twenty version number to `1.1` and update the `readme.txt` changelog.

Props audrasjb, sinatrateam, SergeyBiryukov
Fixes #48944.
Built from https://develop.svn.wordpress.org/trunk@46902


git-svn-id: http://core.svn.wordpress.org/trunk@46702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-12 18:26:03 +00:00
whyisjake
317465e2fe Prevent stored XSS in the block editor. 
Prevent escaped unicode characters become unescaped in unsafe HTML during JSON decoding.

Props: aduth, epiqueras, 

Built from https://develop.svn.wordpress.org/trunk@46896


git-svn-id: http://core.svn.wordpress.org/trunk@46696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-12 18:02:03 +00:00
whyisjake
84e4c8531a Update wp_kses_bad_protocol() to recognize : on uri attributes, 
`wp_kses_bad_protocol()` makes sure to validate that uri attributes don’t contain invalid/or not allowed protocols. While this works fine in most cases, there’s a risk that by using the colon html5 named entity, one is able to bypass this function.

Props: xknown, nickdaugherty, peterwilsoncc.

Built from https://develop.svn.wordpress.org/trunk@46895


git-svn-id: http://core.svn.wordpress.org/trunk@46695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-12 17:55:05 +00:00
whyisjake
80eab318eb Prevent stored XSS through wp_targeted_link_rel(). 
Props: vortfu, whyisjake, peterwilsoncc, xknown,  SergeyBiryukov, flaviozavan.


Built from https://develop.svn.wordpress.org/trunk@46894


git-svn-id: http://core.svn.wordpress.org/trunk@46694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-12 17:54:02 +00:00
whyisjake
9e87c5b7b4 Ensure that a user can publish_posts before making a post sticky. 
Props: danielbachhuber, whyisjake, peterwilson, xknown.


Built from https://develop.svn.wordpress.org/trunk@46893


git-svn-id: http://core.svn.wordpress.org/trunk@46693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-12 17:52:02 +00:00
Sergey Biryukov
99f11a6af2 Docs: Update description for get_categories() to avoid suggesting the deprecated type argument. 
Follow-up to [13754].

Props dingo_d.
Fixes #48913.
Built from https://develop.svn.wordpress.org/trunk@46891


git-svn-id: http://core.svn.wordpress.org/trunk@46691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-12 16:47:05 +00:00
Sergey Biryukov
db18e7d50b Upgrade/Install: Improve the appearance of language selection on install: 
* Remove a stray chevron.
* Improve focus and hover styles.

Props garrett-eclipse, audrasjb.
Fixes #48927.
Built from https://develop.svn.wordpress.org/trunk@46887


git-svn-id: http://core.svn.wordpress.org/trunk@46687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 23:03:03 +00:00
Sergey Biryukov
c87fccd74f Comments: Avoid a PHP notice in comment_form() if the email field is not set. 
Follow-up to [46090].

Props mat-lipe.
Fixes #48943.
Built from https://develop.svn.wordpress.org/trunk@46885


git-svn-id: http://core.svn.wordpress.org/trunk@46685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 22:14:02 +00:00
Andrew Ozz
eb38423e22 Fixes in admin-bar.js: 
- Silence errors when a node doesn't exist similarly to jQuery.
- Add "feature testing" and fallbacks for old browsers as this may run on the front-end.
- Improve inline docs.

Props dinhtungdu, azaozz.
Fixes #47069.
Built from https://develop.svn.wordpress.org/trunk@46883


git-svn-id: http://core.svn.wordpress.org/trunk@46683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 18:56:03 +00:00
Sergey Biryukov
f8964463c1 Tests: Docs: Correct @param formatting in SpeedTrapListener after [35226] and [45607]. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46882


git-svn-id: http://core.svn.wordpress.org/trunk@46682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 15:48:03 +00:00
Sergey Biryukov
c48b359227 Tests: Correct the slowThreshold option name for SpeedTrapListener. 
The previous change in [45607] appears to be accidental.

Props Rarst.
Fixes #48933.
Built from https://develop.svn.wordpress.org/trunk@46881


git-svn-id: http://core.svn.wordpress.org/trunk@46681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 15:42:06 +00:00
Sergey Biryukov
9b91ffde04 Docs: Improve documentation for wp_dashboard_browser_nag() and dashboard_browser_nag_class(). 
Props grapplerulrich.
Fixes #48932.
Built from https://develop.svn.wordpress.org/trunk@46880


git-svn-id: http://core.svn.wordpress.org/trunk@46680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 10:59:05 +00:00
Andrew Ozz
b639963d7a TinyMCE: remove CSS map reference from /tinymce/skins/lightgray/skin.min.css. 
Props AlexHolsgrove.
Fixes #48577.
Built from https://develop.svn.wordpress.org/trunk@46879


git-svn-id: http://core.svn.wordpress.org/trunk@46679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-10 18:33:05 +00:00
Sergey Biryukov
aa919cd160 Comments: Optimize the query for pending comments count in wp_notify_moderator() for better performance on large tables. 
Props sgoen.
Fixes #48514.
Built from https://develop.svn.wordpress.org/trunk@46878


git-svn-id: http://core.svn.wordpress.org/trunk@46678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-10 13:47:00 +00:00
Sergey Biryukov
ee58f3f3d3 Coding Standards: Fix WPCS and JSHint issues in [46872]. 
See #47069.
Built from https://develop.svn.wordpress.org/trunk@46874


git-svn-id: http://core.svn.wordpress.org/trunk@46674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-10 01:34:01 +00:00
Andrew Ozz
d617011afd Fix the admin toolbar js when jQuery is not present and replace the jQuery based hoverIntent.js with a native implementation. Introduces the "hoverintent" (no dependencies) package. 
Props dinhtungdu, audrasjb, azaozz.
Fixes #47069.
Built from https://develop.svn.wordpress.org/trunk@46872


git-svn-id: http://core.svn.wordpress.org/trunk@46672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-10 01:03:02 +00:00
Sergey Biryukov
0524d9b781 Block Editor: Resolve @wordpress/block-directory to the expected version, 1.0.6. 
Follow-up to [46860].

Props aduth, garrett-eclipse, audrasjb, azaozz.
Fixes #48884.
Built from https://develop.svn.wordpress.org/trunk@46870


git-svn-id: http://core.svn.wordpress.org/trunk@46670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 22:29:08 +00:00
Sergey Biryukov
6ddf02b188 Menus: Avoid a PHP warning in add_submenu_page() when the same value is passed for both $parent_slug and $menu_slug parameters. 
Props welcher, ispreview, ayeshrajans, NextScripts, adamsilverstein, garrett-eclipse, 123host.
Fixes #48599.
Built from https://develop.svn.wordpress.org/trunk@46868


git-svn-id: http://core.svn.wordpress.org/trunk@46668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 21:03:02 +00:00
Sergey Biryukov
a209908501 Administration: Standardize form control height and alignment across the admin. 
This improves the appearance of various form controls in the admin and addresses some visual inconsistencies in WordPress 5.3.

Props afercia, audrasjb, jameskoster, GDragoN, azaozz, michaelarestad, murgroland, SamuelFernandez, chetan200891, veminom, dlh.
Fixes #48420.
Built from https://develop.svn.wordpress.org/trunk@46866


git-svn-id: http://core.svn.wordpress.org/trunk@46666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 20:26:03 +00:00
Sergey Biryukov
1dcf3eef7a Date/Time: XML-RPC: Сalculate the proper offset for GMT in wp.newPost, wp.editComment, mw.newPost, mw.editPost when post_date or comment_date is set. 
Previously, `post_date` or `comment_date` was assumed to be GMT, which is only true if the timezone string for the site matches GMT.

Add unit tests.

Props Rarst, smerriman, justdaiv, wonderboymusic, noyle.
Fixes #30429.
Built from https://develop.svn.wordpress.org/trunk@46864


git-svn-id: http://core.svn.wordpress.org/trunk@46664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 19:56:05 +00:00
Sergey Biryukov
098273f1d3 Date/Time: When determining whether to decline the month name in wp_maybe_decline_date(), take word boundaries into account. 
Add more unit tests.

Props Rarst, Clorith, timon33, Xendo, SergeyBiryukov.
Fixes #48606.
Built from https://develop.svn.wordpress.org/trunk@46862


git-svn-id: http://core.svn.wordpress.org/trunk@46662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 18:50:06 +00:00
Sergey Biryukov
a227c231a2 Block Editor: Bug fixes targeted for WordPress 5.3.1. 
The list of included fixes:

- Edge scrolling issues https://github.com/WordPress/gutenberg/pull/17707
- Intermittent JavaScript issues https://github.com/WordPress/gutenberg/pull/18559
- Remove embed CollegeHumor https://github.com/WordPress/gutenberg/pull/18591 

Updated packages:

- @wordpress/block-directory@1.0.6
- @wordpress/block-editor@3.2.5
- @wordpress/block-library@2.9.6
- @wordpress/core-data@2.7.5
- @wordpress/edit-post@3.8.6
- @wordpress/editor@9.7.6
- @wordpress/format-library@1.9.5

Props youknowriad, ellatrix, epiqueras, audrasjb, gziolo, mcsf, kyliesabra.
Fixes #48884.
Built from https://develop.svn.wordpress.org/trunk@46860


git-svn-id: http://core.svn.wordpress.org/trunk@46660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 17:37:10 +00:00
Sergey Biryukov
d4ef90b236 Upgrade/Install: Update sodium_compat to v1.12.1. 
This includes a speedup for signature verification on most platforms and bugfixes for 32-bit platforms.

Props paragoninitiativeenterprises, lukaswaudentio.
Fixes #48371.
Built from https://develop.svn.wordpress.org/trunk@46858


git-svn-id: http://core.svn.wordpress.org/trunk@46658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 16:42:04 +00:00
Sergey Biryukov
dd47d5aa81 Media: Use consistent width for Scale and Crop inputs. 
Follow-up to [46359].

Props sabernhardt, audrasjb.
Fixes #48907.
Built from https://develop.svn.wordpress.org/trunk@46856


git-svn-id: http://core.svn.wordpress.org/trunk@46656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 16:23:02 +00:00
Sergey Biryukov
303180b392 Twenty Twenty: Adjust the comment in [46851] per the documentation standards. 
See #48876.
Built from https://develop.svn.wordpress.org/trunk@46854


git-svn-id: http://core.svn.wordpress.org/trunk@46654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 16:18:02 +00:00
Sergey Biryukov
9648c368f0 Help/About: Add a hover effect for links on About pages. 
* Add a color that passes WCAG color contrast criteria to every link.
* Add an underline for links in credits list only on hover/focus.

Props audrasjb, ixkaito, mukesh27, melchoyce, SergeyBiryukov.
Fixes #48582.
Built from https://develop.svn.wordpress.org/trunk@46852


git-svn-id: http://core.svn.wordpress.org/trunk@46652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 15:31:05 +00:00
ianbelanger
48fbea17d6 Bundled Themes: Misaligned input placeholder text Twenty Twenty. 
This fixes placeholder misalignment in Firefox when a `height` is added as an inline style to the input field.

Props aljullu, subratamal.
Fixes #48876.
Built from https://develop.svn.wordpress.org/trunk@46851


git-svn-id: http://core.svn.wordpress.org/trunk@46651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 15:10:00 +00:00
Sergey Biryukov
35985cbf38 Twenty Twenty: Remove redundant echo for bloginfo() call in footer.php. 
Props acosmin.
Fixes #48918.
Built from https://develop.svn.wordpress.org/trunk@46849


git-svn-id: http://core.svn.wordpress.org/trunk@46649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 15:00:01 +00:00
Sergey Biryukov
dcf0cb68a2 Administration: Correct checkbox width in list tables on smaller screens. 
Previously, checkboxes for pending comments were partially hidden due to an added `4px` border.

Props audrasjb, jeremyfelt, talldanwp, melchoyce, marcelo2605, waleedt93.
Fixes #48815.
Built from https://develop.svn.wordpress.org/trunk@46845


git-svn-id: http://core.svn.wordpress.org/trunk@46645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 14:26:02 +00:00
ianbelanger
b051b9a0d4 Bundled Themes: Make checkbox in comment form larger Twenty Twenty. 
This makes the checkbox in the comment form larger and more consistent with other checkboxes.

Props kharisblank, audrasjb.
Fixes #48652.
Built from https://develop.svn.wordpress.org/trunk@46844


git-svn-id: http://core.svn.wordpress.org/trunk@46644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 14:08:03 +00:00
Sergey Biryukov
ac690426eb Accessibility: Menus: Properly disable form controls on the Menus screen that cannot be used until at least one menu is created. 
This ensures that the actual UI controls state matches the visually conveyed state.

Props afercia, audrasjb, dinhtungdu, sathyapulse, simonjanin, welcher, SergeyBiryukov.
Fixes #48409.
Built from https://develop.svn.wordpress.org/trunk@46842


git-svn-id: http://core.svn.wordpress.org/trunk@46642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 13:49:03 +00:00
Sergey Biryukov
23f45f0346 Twenty Twenty: Correct alignment for embedded Instagram posts. 
Props SGr33n, audrasjb, nielslange, JarretC.
Fixes #48688.
Built from https://develop.svn.wordpress.org/trunk@46840


git-svn-id: http://core.svn.wordpress.org/trunk@46640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 13:39:03 +00:00
Sergey Biryukov
87a759b81c Users: Introduce admin_email_remind_interval filter for dismissing the admin email confirmation screen. 
Props desrosj, birgire.
Fixes #48334.
Built from https://develop.svn.wordpress.org/trunk@46838


git-svn-id: http://core.svn.wordpress.org/trunk@46638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 13:26:02 +00:00
Sergey Biryukov
adf1792adc Docs: Correct DocBlock formatting for admin_email_confirm and admin_email_confirm_form hooks. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46837


git-svn-id: http://core.svn.wordpress.org/trunk@46637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 13:10:01 +00:00
Sergey Biryukov
4b333de597 Tests: Change group annotation for test_unique_filename_with_dimension_like_filename() to `ticket. 
See #42437.
Built from https://develop.svn.wordpress.org/trunk@46835


git-svn-id: http://core.svn.wordpress.org/trunk@46635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 12:18:01 +00:00
Sergey Biryukov
6c49066de7 Twenty Twenty: Pass $post_meta and $location values to twentytwenty_start_of_post_meta_list and twentytwenty_end_of_post_meta_list actions to provide better context. 
Props msaari, SergeyBiryukov.
Fixes #48906.
Built from https://develop.svn.wordpress.org/trunk@46832


git-svn-id: http://core.svn.wordpress.org/trunk@46632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 11:49:02 +00:00
Sergey Biryukov
8da965a5b8 Tests: Make sure network factory returns an integer ID for created objects, for consistency with other factories and the documented value. 
See #48145.
Built from https://develop.svn.wordpress.org/trunk@46831


git-svn-id: http://core.svn.wordpress.org/trunk@46631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 11:31:01 +00:00
Sergey Biryukov
e70c88213f Tests: Pad incrementors used in factories with leading zeros to make sure MySQL sorting works as expected. 
Previously, tests could create sequential objects with names like `Term 99`, `Term 100`, which by default would be returned in reverse order when sorted by name alphabetically, causing seemingly random test failures that are extremely hard to debug.

See #48145.
Built from https://develop.svn.wordpress.org/trunk@46830


git-svn-id: http://core.svn.wordpress.org/trunk@46630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 10:41:05 +00:00
Sergey Biryukov
860fc16954 Tests: Speed up comment submission unit tests by creating less fixtures and reusing them where possible. 
See #30017, #48145.
Built from https://develop.svn.wordpress.org/trunk@46829


git-svn-id: http://core.svn.wordpress.org/trunk@46629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-08 18:02:07 +00:00
Sergey Biryukov
f11d28a779 Twenty Twenty: Use duplicate hook references for page_css_class and page_menu_link_attributes filters in TwentyTwenty_Walker_Page. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46828


git-svn-id: http://core.svn.wordpress.org/trunk@46628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-07 14:03:03 +00:00
Sergey Biryukov
6677070a13 Bundled Themes: Correct @since tags to refer to the theme version instead of WordPress version. 
This makes `@since` notations in Twenty Seventeen, Twenty Nineteen, and Twenty Twenty consistent with the previous bundled themes.

See #48303.
Built from https://develop.svn.wordpress.org/trunk@46827


git-svn-id: http://core.svn.wordpress.org/trunk@46627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-07 13:56:06 +00:00
John Blackbourn
d53103ed62 Docs: Further docblock corrections and improvements. 
See #48303
Built from https://develop.svn.wordpress.org/trunk@46826


git-svn-id: http://core.svn.wordpress.org/trunk@46626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-07 13:23:01 +00:00
Sergey Biryukov
0f971e68ec Twenty Twenty: Replace Smooth Scroll JS implementation with scroll-behavior CSS property. 
The JS implementation had multiple issues and did not work as expected.

This change includes an accessibility enhancement by using `prefers-reduced-motion: reduce` media query property for users that don't want motion effects. For further explanation on this media query, see MDN documentation: https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-behavior#Accessibility_concerns

Props audrasjb, melchoyce, joostdevalk, Anlino, mauteri, sergiomdgomes, littlebigthing, williampatton, netweb, andraganescu, joyously, acosmin, mukesh27, hareesh-pillai.
Fixes #48763, #48551, #48866.
Built from https://develop.svn.wordpress.org/trunk@46824


git-svn-id: http://core.svn.wordpress.org/trunk@46624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-07 11:05:01 +00:00
John Blackbourn
f93ee2ca76 Docs: Increase the specificity of various docblock parameter types and return types. 
See #48303
Built from https://develop.svn.wordpress.org/trunk@46823


git-svn-id: http://core.svn.wordpress.org/trunk@46623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-06 22:43:04 +00:00
Andrew Ozz
15a566edef Upload: fix wp_unique_filename() to prevent name collisions with existing or future image sub-size file names, and add unit tests. 
Props Viper007Bond, pbiron, azaozz.
Fixes #42437.
Built from https://develop.svn.wordpress.org/trunk@46822


git-svn-id: http://core.svn.wordpress.org/trunk@46622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-06 22:28:00 +00:00
John Blackbourn
aa1fdcbd52 Docs: Correct various docblocks documentation. 
See #48303
Built from https://develop.svn.wordpress.org/trunk@46821


git-svn-id: http://core.svn.wordpress.org/trunk@46621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-06 22:23:04 +00:00
Aaron Jorbin
7d84502589 Text Changes: Rename Comment Blacklist option to be more inclusive 
This doesn't change the underlying option name as that would be a backcompat break, but it makes the UI a bit more inclusive.

Props dartiss, jeremyfelt, aaronjorbin.
Fixes #48900.


Built from https://develop.svn.wordpress.org/trunk@46820


git-svn-id: http://core.svn.wordpress.org/trunk@46620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-06 18:12:02 +00:00
Sergey Biryukov
c375d23ef5 Tests: Remove duplicate test_get_page_by_path_priority() test. 
The test was moved into its own file in [37478], but never removed from its previous location.

See #36711.
Built from https://develop.svn.wordpress.org/trunk@46819


git-svn-id: http://core.svn.wordpress.org/trunk@46619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-06 17:27:05 +00:00
Sergey Biryukov
2165eef44c Accessibility: Administration: Correct active button color for the alternative color schemes. 
Follow-up to [46815].

Props melchoyce, ryelle, larrach, audrasjb, studiotwee, afercia, azaozz.
Fixes #48598.
Built from https://develop.svn.wordpress.org/trunk@46817


git-svn-id: http://core.svn.wordpress.org/trunk@46617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-05 22:12:03 +00:00
Sergey Biryukov
20e18613d0 Accessibility: Administration: Apply a unified design to all secondary buttons across all color schemes. 
This ensures that secondary buttons have an appropriate color contrast in the alternative color schemes.

Props melchoyce, ryelle, audrasjb, ate-up-with-motor, afercia, sabernhardt.
Fixes #48585.
Built from https://develop.svn.wordpress.org/trunk@46815


git-svn-id: http://core.svn.wordpress.org/trunk@46615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-05 21:32:03 +00:00
Sergey Biryukov
23abf27b1a XML-RPC: Unify some "could not be created/updated/deleted" error messages for consistency. 
Props ramiy, SergeyBiryukov.
Fixes #48883.
Built from https://develop.svn.wordpress.org/trunk@46814


git-svn-id: http://core.svn.wordpress.org/trunk@46614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-05 13:48:03 +00:00
ianbelanger
8d6912dd27 Bundled Themes: Adds Customizer option to show or hide author bio Twenty Twenty. 
This adds an option to the Customizer that allows you to turn the author bio on or off, sitewide.

Props williampatton, nielslange acosmin, dlh.
Fixes #48550.
Built from https://develop.svn.wordpress.org/trunk@46813


git-svn-id: http://core.svn.wordpress.org/trunk@46613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-04 15:59:03 +00:00
Sergey Biryukov
38ad319fdf I18N: Change context for the "Add New" string on Themes screen for consistency with other similar strings. 
Props ramiy.
Fixes #48875.
Built from https://develop.svn.wordpress.org/trunk@46812


git-svn-id: http://core.svn.wordpress.org/trunk@46612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-04 10:36:01 +00:00
Sergey Biryukov
a5e52e04ee Docs: Move the canonical DocBlock for handle_bulk_actions-{$screen} action to wp-admin/edit.php. 
* Document accepted values for the `$items` parameter.
* Use interpolated syntax for the filter name.

Props dilipbheda, johnbillion, SergeyBiryukov.
Fixes #48857.
Built from https://develop.svn.wordpress.org/trunk@46811


git-svn-id: http://core.svn.wordpress.org/trunk@46611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-03 13:58:05 +00:00
Sergey Biryukov
6d1ed93c91 Taxonomy: Remove redundant caching from get_all_category_ids(), deprecated in favor of get_terms() in [28679]. 
The `all_category_ids` cache key it relied on was removed in [5555] and never repopulated, causing invalid or unexpected results when using a persistent object cache.

Props itowhid06, johnjamesjacoby.
Fixes #48176.
Built from https://develop.svn.wordpress.org/trunk@46810


git-svn-id: http://core.svn.wordpress.org/trunk@46610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-02 14:49:01 +00:00
Andrew Ozz
135e608b46 Upload: Exclude PNG images from scaling after uploading. Fixes a case where resizing a very large PNG may create a scaled image that has smaller dimensions but larger file size than the original. 
Fixes #48736.
Built from https://develop.svn.wordpress.org/trunk@46809


git-svn-id: http://core.svn.wordpress.org/trunk@46609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-01 18:26:05 +00:00
Sergey Biryukov
221287f626 Widgets: Remove WP_Widget_Factory::$hashed_class_counts property, unused since [46220]. 
The `spl_object_hash()` function was introduced in PHP 5.2.0. As of PHP 5.3, the PHP SPL extension can no longer be disabled, so the `WP_Widget_Factory::hash_object()` workaround was removed in [46220].

See #48074.
Built from https://develop.svn.wordpress.org/trunk@46808


git-svn-id: http://core.svn.wordpress.org/trunk@46608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-01 12:13:01 +00:00
Sergey Biryukov
0221a593b9 Administration: Correct font size for comment count in "At a Glance" dashboard widget on mobile. 
Props donmhico, jeremyfelt.
Fixes #48799.
Built from https://develop.svn.wordpress.org/trunk@46807


git-svn-id: http://core.svn.wordpress.org/trunk@46607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-30 00:42:01 +00:00
Sergey Biryukov
585af17b7c Tests: Merge [24251] from _wp_filter_build_unique_id() to _test_filter_build_unique_id(), for consistency. 
See #47407.
Built from https://develop.svn.wordpress.org/trunk@46806


git-svn-id: http://core.svn.wordpress.org/trunk@46606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-29 22:17:01 +00:00
Sergey Biryukov
3047531f6a Plugins: In _wp_filter_build_unique_id(), remove $wp_filter global and $filter_id_count static variable, unused since [46220]. 
See #47407, #48074.
Built from https://develop.svn.wordpress.org/trunk@46805


git-svn-id: http://core.svn.wordpress.org/trunk@46605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-29 22:14:01 +00:00
Sergey Biryukov
1d1c74385f REST API: Use strict in_array() checks for the list of usernames blacklisted via illegal_user_logins filter. 
See #48839.
Built from https://develop.svn.wordpress.org/trunk@46804


git-svn-id: http://core.svn.wordpress.org/trunk@46604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-29 22:04:02 +00:00
Sergey Biryukov
86c441140b REST API: Use a strict in_array() check in WP_REST_Request::get_parameter_order(). 
See #48839.
Built from https://develop.svn.wordpress.org/trunk@46803


git-svn-id: http://core.svn.wordpress.org/trunk@46603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-29 22:01:03 +00:00
Sergey Biryukov
d33571f7d5 REST API: Use a strict in_array() check in WP_REST_Meta_Fields::get_registered_fields(). 
Props dkarfa.
Fixes #48839.
Built from https://develop.svn.wordpress.org/trunk@46802


git-svn-id: http://core.svn.wordpress.org/trunk@46602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-29 21:59:03 +00:00
Sergey Biryukov
49401759f3 Docs: Correct @param type for the function parameter in tests_add_filter() and _test_filter_build_unique_id(). 
Synchronize documentation for `add_filter()`, `tests_add_filter()`, `_wp_filter_build_unique_id()`, `_test_filter_build_unique_id()`.

Add a note that `$tag` and `$priority` are no longer used in `_wp_filter_build_unique_id()` since [46220], and the function always returns a string now.

Props donmhico, remcotolsma, SergeyBiryukov.
Fixes #47407. See #48303.
Built from https://develop.svn.wordpress.org/trunk@46801


git-svn-id: http://core.svn.wordpress.org/trunk@46601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-29 21:42:01 +00:00
Sergey Biryukov
2a0489ec49 Docs: Replace @returns tags in JS docs with @return. 
Per the documentation standards, `@returns` is an unsupported synonym, `@return` should be used instead:
https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/

See #48303.
Built from https://develop.svn.wordpress.org/trunk@46800


git-svn-id: http://core.svn.wordpress.org/trunk@46600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-29 18:01:03 +00:00
Sergey Biryukov
4a4afbd68c Docs: Add missing full stops to @returns tags in JS docs, per the documentation standards. 
Props shital-patel, kalpshit.
Fixes #48305.
Built from https://develop.svn.wordpress.org/trunk@46799


git-svn-id: http://core.svn.wordpress.org/trunk@46599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-29 16:56:02 +00:00
Sergey Biryukov
acd0a3ca99 Site Health: Add a test for PHP default timezone. 
The test reports a failure if the default timezone was changed with `date_default_timezone_set()` to anything other than `UTC`.

WordPress historically uses `UTC` as the default timezone for calculating date and time offsets, overriding it is not recommended and can cause widespread and obscure issues.

Props Rarst, Clorith, TimothyBlynJacobs.
Fixes #48692.
Built from https://develop.svn.wordpress.org/trunk@46797


git-svn-id: http://core.svn.wordpress.org/trunk@46597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-28 15:48:03 +00:00
Sergey Biryukov
9d14355bf5 Date/Time: Make get_permalink() more resilient against PHP timezone changes. 
Overriding default PHP timezone with `date_default_timezone_set()`, while not recommended, should not inadvertently result in changing existing permalinks.

Add a unit test.

Props Rarst, steevithak, archon810, maciejmackowiak, Ov3rfly, Cybr, hometowntrailers, scvleon, miette49.
Fixes #48623.
Built from https://develop.svn.wordpress.org/trunk@46795


git-svn-id: http://core.svn.wordpress.org/trunk@46595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-28 13:42:00 +00:00
Sergey Biryukov
7acfab22b8 KSES: Add support for gradient backgrounds. 
Props jorgefilipecosta.
Fixes #48376.
Built from https://develop.svn.wordpress.org/trunk@46793


git-svn-id: http://core.svn.wordpress.org/trunk@46593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-28 00:29:02 +00:00
Sergey Biryukov
0aef4faacd Plugins: Correct default value of $replacement parameter in do_action_deprecated() and apply_filters_deprecated(). 
This addresses an inconsistency with `_deprecated_hook()`, which uses `is_null()` to check if `$replacement` was provided, however the previous default value was `false`.

Props shaampk1, felipeelia.
Fixes #48817.
Built from https://develop.svn.wordpress.org/trunk@46792


git-svn-id: http://core.svn.wordpress.org/trunk@46592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-27 23:55:01 +00:00
Sergey Biryukov
6f86cedb09 Menus: Improve the wording of instructions for dragging the items into the preferred order. 
Props amolv, equin0x80, dlh.
Fixes #48184.
Built from https://develop.svn.wordpress.org/trunk@46791


git-svn-id: http://core.svn.wordpress.org/trunk@46591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-27 19:51:01 +00:00
Sergey Biryukov
d8b251f0af Administration: Properly wrap long titles in list tables on smaller screens. 
Props mukesh27, iihglobal, wpamitkumar.
Fixes #48805.
Built from https://develop.svn.wordpress.org/trunk@46790


git-svn-id: http://core.svn.wordpress.org/trunk@46590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-27 16:52:02 +00:00
Sergey Biryukov
e2c2fb64bf Users: Display admin email verification screen in user's locale instead of site locale. 
Props sathyapulse, TimothyBlynJacobs.
Fixes #48313.
Built from https://develop.svn.wordpress.org/trunk@46788


git-svn-id: http://core.svn.wordpress.org/trunk@46588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-27 14:35:02 +00:00
ianbelanger
c74c8cf5f1 Bundled Themes: Fixes JS TypeError in Twenty Twenty. 
On mobile devices using a webkit browser, the menu and search modals could not be opened due to a `TypeError: document.body is null`. This commit fixes that issue by adding a `touch-enabled` class to the body for browsers that do not support media queries.

Props quicoto, poena, Boga86, acosmin, macmanx.
Fixes #48601.
Built from https://develop.svn.wordpress.org/trunk@46786


git-svn-id: http://core.svn.wordpress.org/trunk@46586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-26 18:21:03 +00:00
Sergey Biryukov
5af0c2989b Tests: Add feed group for get_feed_build_date() test added in [46756]. 
See #48675.
Built from https://develop.svn.wordpress.org/trunk@46785


git-svn-id: http://core.svn.wordpress.org/trunk@46585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-26 16:19:03 +00:00
Dominik Schilling
f4165a697d Upgrade/Install: Provide a default label for "Continue" button in language selection form. 
Prevents an empty continue button if a translation isn't yet available.

Props sathyapulse.
Fixes #48776.
Built from https://develop.svn.wordpress.org/trunk@46784


git-svn-id: http://core.svn.wordpress.org/trunk@46584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-26 15:19:04 +00:00
Sergey Biryukov
63fefb540a Users: Use correct variable when displaying the Additional Capabilities list in user profile. 
Addresses a regression in [45926].

Props wpgurudev, aravindajith, anantajitjg, davidbaumwald.
Fixes #48725.
Built from https://develop.svn.wordpress.org/trunk@46782


git-svn-id: http://core.svn.wordpress.org/trunk@46582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-25 14:01:03 +00:00
Sergey Biryukov
e0830ac7bc Options, Meta APIs: Update @since version for the $force_cache parameter added for wp_load_alloptions() in [46753] to 5.3.1. 
See #31245.
Built from https://develop.svn.wordpress.org/trunk@46779


git-svn-id: http://core.svn.wordpress.org/trunk@46579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-25 13:44:02 +00:00
Sergey Biryukov
012ddf095a Media: Avoid a PHP notice in image_downsize() when trying to replace a non-image URL with a rendered image from its meta. 
Props Mte90, jrf, hareesh-pillai.
Fixes #48324.
Built from https://develop.svn.wordpress.org/trunk@46772


git-svn-id: http://core.svn.wordpress.org/trunk@46572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-25 10:07:02 +00:00
Sergey Biryukov
2a85fe21d8 Accessibility: Administration: Underline links on Dashboard that are located within a line of text and thus need to be underlined: 
* "change your theme completely"
* Active theme in the "At a Glance" box
* "View all drafts" in the Quick Draft box

Split "Manage widgets or menus" into separate items for consistency with other links.

For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished.

Per accessibility coding standards:
> When links can be identified as such by the context, for example because they’re part of a menu, or a set of links clearly identified as user interface controls, they don’t necessarily need to be underlined. In all the other cases, especially for links surrounded by other text (in a line or block of text), links need to be always underlined.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/#links-underline-or-no-underline
https://make.wordpress.org/accessibility/handbook/design/use-of-color/#not-by-color-alone

Props afercia, audrasjb, karmatosed.
Fixes #48406.
Built from https://develop.svn.wordpress.org/trunk@46770


git-svn-id: http://core.svn.wordpress.org/trunk@46570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-24 19:57:05 +00:00
Sergey Biryukov
a1ad168857 Twenty Twenty: Remove duplicate array key/value in TwentyTwenty_Non_Latin_Languages::get_non_latin_css(). 
Props manikmist09.
Fixes #48624.
Built from https://develop.svn.wordpress.org/trunk@46765


git-svn-id: http://core.svn.wordpress.org/trunk@46565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-24 10:55:02 +00:00
Sergey Biryukov
c786eaa1df Coding Standards: Fix WPCS issue in [46763]. 
See #48777.
Built from https://develop.svn.wordpress.org/trunk@46764


git-svn-id: http://core.svn.wordpress.org/trunk@46564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-23 19:21:03 +00:00
Sergey Biryukov
26a750e162 Docs: Add missing @since tags for functions in wp-admin/includes/update.php. 
Props sathyapulse, zodiac1978.
Fixes #48777.
Built from https://develop.svn.wordpress.org/trunk@46763


git-svn-id: http://core.svn.wordpress.org/trunk@46563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-23 18:51:01 +00:00
Sergey Biryukov
0b5f3acd9f Twenty Twenty: Correctly align the author bio and bottom post meta on single posts on mobile. 
Props nielslange, Anlino.
Fixes #48619.
Built from https://develop.svn.wordpress.org/trunk@46762


git-svn-id: http://core.svn.wordpress.org/trunk@46562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-23 14:54:04 +00:00
Sergey Biryukov
8e9c4a116a Embeds: Remove CollegeHumor oEmbed provider, as the service does not exist anymore. 
Props audrasjb, youknowriad.
Fixes #48696.
Built from https://develop.svn.wordpress.org/trunk@46761


git-svn-id: http://core.svn.wordpress.org/trunk@46561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-23 10:15:03 +00:00
Sergey Biryukov
58aa1cc8c5 Docs: Adjust wp_is_json_request() and wp_is_xml_request() return value descriptions for consistency. 
See #48771, #48303.
Built from https://develop.svn.wordpress.org/trunk@46760


git-svn-id: http://core.svn.wordpress.org/trunk@46560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-22 18:28:04 +00:00
Sergey Biryukov
597b22c99c Docs: Correct spelling and capitalization in wp-includes/load.php: 
* Fix typo in `is_blog_admin()` description.
* Capitalize PHP correctly in `enable_wp_debug_mode_checks` filter description.
* Capitalize XML correctly in `wp_is_xml_request()` return value description.

Props stevegrunwell.
Fixes #48771.
Built from https://develop.svn.wordpress.org/trunk@46759


git-svn-id: http://core.svn.wordpress.org/trunk@46559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-22 18:16:03 +00:00
Sergey Biryukov
56af5db74f Editor: Improve the appearance of tag cloud in Tags meta box in classic editor. 
Props sathyapulse, Spaceshipone, tmatsuur, audrasjb, afercia.
Fixes #48592.
Built from https://develop.svn.wordpress.org/trunk@46758


git-svn-id: http://core.svn.wordpress.org/trunk@46558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-22 00:04:02 +00:00
Sergey Biryukov
882be65f94 Date/Time: Correct the time format in get_feed_build_date() to use 24-hour format. 
Follow-up to [46756].

See #48675.
Built from https://develop.svn.wordpress.org/trunk@46757


git-svn-id: http://core.svn.wordpress.org/trunk@46557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-21 16:27:03 +00:00
Sergey Biryukov
d13ce45ff6 Date/Time: Remove mysql2date() usage in get_feed_build_date() to ensure the output includes correct timezone offset. 
With the changes in [45908], `mysql2date()` works correctly for all local time inputs, but should not be used for UTC time inputs.

Add a unit test.

Props Rarst, lisota.
Fixes #48675.
Built from https://develop.svn.wordpress.org/trunk@46756


git-svn-id: http://core.svn.wordpress.org/trunk@46556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-21 13:18:00 +00:00
Sergey Biryukov
44d5372825 I18N: Correct translator comment for By %s string in Plugins list table. 
Follow-up to [44541].

See #45898.
Built from https://develop.svn.wordpress.org/trunk@46755


git-svn-id: http://core.svn.wordpress.org/trunk@46555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-21 00:08:02 +00:00
Sergey Biryukov
d5434d7cc7 Customize: If the return URL for Close button is a page added to the Appearance menu by a deactivated theme, fall back to the Themes screen. 
Props JarretC, Jean-David, SergeyBiryukov.
Fixes #46686.
Built from https://develop.svn.wordpress.org/trunk@46754


git-svn-id: http://core.svn.wordpress.org/trunk@46554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-20 18:49:03 +00:00
Sergey Biryukov
285d38bd83 Options, Meta APIs: Avoid a race condition causing the first of two subsequent requests updating different options at the same time to lose changes. 
Every time an autoloaded option is updated or deleted, the `alloptions` cache is similarly updated. Due to the race condition, on any autoloaded option being updated, every other autoloaded option had its value set to the value at load time, causing a mismatch between the data in the persistent cache and the database.

This change introduces a `$force_cache` parameter for `wp_load_alloptions()` to force an update of the local `alloptions` cache from the persistent cache when an option is added, updated, or deleted, to minimize the chance of affecting other options.

Props fabifott, rmccue, tollmanz, johnjamesjacoby, spacedmonkey, dd32, jipmoors, tellyworth, jeremyclarke, joehoyle, boonebgorges, danielbachhuber, flixos90, jeichorn, mihdan, Grzegorz.Janoszka, SergeyBiryukov.
See #31245.
Built from https://develop.svn.wordpress.org/trunk@46753


git-svn-id: http://core.svn.wordpress.org/trunk@46553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-20 13:42:03 +00:00
Sergey Biryukov
b0a0f62727 Docs: Fix typo in README.md. 
Props dkarfa.
Fixes #48737.
Built from https://develop.svn.wordpress.org/trunk@46752


git-svn-id: http://core.svn.wordpress.org/trunk@46552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-20 08:33:01 +00:00
Sergey Biryukov
cca5c825ed Docs: Clarify that WP_Theme::get(), ::display(), and several related methods treat the Tags theme header as an array. 
Props david.binda.
Fixes #48005.
Built from https://develop.svn.wordpress.org/trunk@46751


git-svn-id: http://core.svn.wordpress.org/trunk@46551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-20 08:31:03 +00:00
Sergey Biryukov
8e4b0c2c45 XML-RPC: Pass correct variable as the URL parameter to http_headers_useragent filter in wp_xmlrpc_server::pingback_ping(). 
Props wpgurudev, andreaitm.
Fixes #48721. See #42186.
Built from https://develop.svn.wordpress.org/trunk@46750


git-svn-id: http://core.svn.wordpress.org/trunk@46550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-19 11:07:03 +00:00
Sergey Biryukov
a6cecef42f Login and Registration: Pass $user_data parameter to the lostpassword_post action in retrieve_password(). 
Props wpgurudev, pagewidth, lukecavanagh, johnbillion, kkarpieszuk.
Fixes #38334.
Built from https://develop.svn.wordpress.org/trunk@46749


git-svn-id: http://core.svn.wordpress.org/trunk@46549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-19 10:01:04 +00:00
Andrea Fercia
c0950c1d50 Accessibility: Media: Add an aria-pressed attribute to active button within a button group. 
The `aria-pressed` attribute communicates semantically the "active" state of buttons that otherwise only look "active".

Fixes #48355.

Built from https://develop.svn.wordpress.org/trunk@46748


git-svn-id: http://core.svn.wordpress.org/trunk@46548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-18 22:23:03 +00:00
Sergey Biryukov
06ab7e3f6b Twenty Twenty: Fix typos in a variable name and inline comment in assets/js/color-calculations.js. 
Props tanvirul.
Fixes #48704.
Built from https://develop.svn.wordpress.org/trunk@46747


git-svn-id: http://core.svn.wordpress.org/trunk@46547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-18 17:07:01 +00:00
Andrea Fercia
71725aeb95 Accessibility: Add an aria-current attribute to the Media Library switch links. 
The `aria-current` attribute is a simple, effective, way to help assistive technology users orientate themselves within a set of items.

Props mayanksonawat, afercia.
Fixes #48271.

Built from https://develop.svn.wordpress.org/trunk@46746


git-svn-id: http://core.svn.wordpress.org/trunk@46546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-18 16:51:02 +00:00
Andrea Fercia
eec579dd86 Widgets: Avoid to move focus to the Image Widget "Insert from URL" field. 
Fixes a bug after [45499], where the backbone view element isn't the input field any longer. Also, managing focus programmatically is often an assumption on a specific user flow and should generally be avoided, see #43169.

Props dufresnesteven.
See #43169.
Fixes #48588.

Built from https://develop.svn.wordpress.org/trunk@46745


git-svn-id: http://core.svn.wordpress.org/trunk@46545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-18 16:23:02 +00:00
Sergey Biryukov
306045277e Administration: Switch rgb() CSS property for paused plugin error message in Plugins list table to rgba(). 
While technically correct as is, the latter is more consistent with other admin styles and causes less confusion.

Props manikmist09.
Fixes #48629.
Built from https://develop.svn.wordpress.org/trunk@46744


git-svn-id: http://core.svn.wordpress.org/trunk@46544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-18 13:18:03 +00:00
Sergey Biryukov
f32831bf6d Taxonomy: Correct the initial value for WP_Taxonomy::$labels to match get_taxonomy_labels() return type. 
Improve documentation for consistency with `WP_Post_Type::$labels`.

Props alpipego.
Fixes #48681.
Built from https://develop.svn.wordpress.org/trunk@46743


git-svn-id: http://core.svn.wordpress.org/trunk@46543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-18 07:58:59 +00:00
Sergey Biryukov
5aa3a51264 Docs: Update broken source code link in WP_Filesystem_SSH2 class. 
Props mryoga, finchps.
Fixes #48467.
Built from https://develop.svn.wordpress.org/trunk@46742


git-svn-id: http://core.svn.wordpress.org/trunk@46542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-17 16:16:02 +00:00
Sergey Biryukov
96e163473e Docs: Update broken source code link in imgAreaSelect jQuery plugin. 
Props mryoga, finchps.
See #48467.
Built from https://develop.svn.wordpress.org/trunk@46741


git-svn-id: http://core.svn.wordpress.org/trunk@46541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-17 16:14:03 +00:00
Sergey Biryukov
0d8e11db06 Docs: Replace Codex URLs with corresponding HelpHub articles in wp-config-sample.php. 
Props sebastienserre.
Fixes #48680.
Built from https://develop.svn.wordpress.org/trunk@46740


git-svn-id: http://core.svn.wordpress.org/trunk@46540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-17 11:11:04 +00:00
Sergey Biryukov
418db0297e Docs: Correct spelling of "subclass" and "overridden" in various docblocks and error messages. 
Props garrett-eclipse.
Fixes #48676.
Built from https://develop.svn.wordpress.org/trunk@46739


git-svn-id: http://core.svn.wordpress.org/trunk@46539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-17 07:43:01 +00:00
Sergey Biryukov
927aa4b44c Docs: Fix typo in wp_credits_section_title() description. 
Switch descriptions for `wp_credits_section_title()` and `wp_credits_section_list()` to third-person singular verbs, per the documentation standards.

Props hareesh-pillai.
Fixes #48674.
Built from https://develop.svn.wordpress.org/trunk@46738


git-svn-id: http://core.svn.wordpress.org/trunk@46538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-16 21:04:01 +00:00
Sergey Biryukov
0f90f6a739 Editor: Pass $editor_id parameter to tiny_mce_plugins, mce_external_plugins, and mce_external_languages filters, for consistency with teeny_mce_plugins. 
Document the `classic-block` value passed to various editor filters in `wp_tinymce_inline_scripts()`.

Add missing `@since` entries for the existing `$editor_id` parameter in various filters.

Props djp424, johnbillion, SergeyBiryukov.
Fixes #48441.
Built from https://develop.svn.wordpress.org/trunk@46737


git-svn-id: http://core.svn.wordpress.org/trunk@46537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-16 16:36:02 +00:00
Sergey Biryukov
9bf98c307b Security: Add WordPress 5.3.x to the "Supported Versions" section of GitHub Security Policy. 
Props imath.
Fixes #48667. See #48521.
Built from https://develop.svn.wordpress.org/trunk@46736


git-svn-id: http://core.svn.wordpress.org/trunk@46536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-16 11:19:03 +00:00
whyisjake
a761a23464 Security: Add a GitHub Security Policy. 
As part of more responsible security disclosure, we are adding a security policy to GitHub.

Fixes #48521.
Props whyisjake, ayeshrajans.

Built from https://develop.svn.wordpress.org/trunk@46735


git-svn-id: http://core.svn.wordpress.org/trunk@46535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-15 23:46:01 +00:00
whyisjake
ba7170de9c Toolbar: Properly escape the onclick attribute. 
The onclick attribute was being escaped twice, once with `esc_js` and again with `esc_attr`.

Fixes #48117.
Props tmatsuur, dinhtungdu.


Built from https://develop.svn.wordpress.org/trunk@46734


git-svn-id: http://core.svn.wordpress.org/trunk@46534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-15 23:24:02 +00:00
Sergey Biryukov
3a735ec87a Docs: Improve a comment about $doing_wp_cron global in wp-cron.php. 
Props chinteshprajapati, subrataemfluence, nielslange.
Fixes #46104.
Built from https://develop.svn.wordpress.org/trunk@46733


git-svn-id: http://core.svn.wordpress.org/trunk@46533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-15 08:59:01 +00:00
Sergey Biryukov
4ec53dc54c Docs: Remove incorrect @return tags. 
Props diddledan.
Fixes #48613, #48614.
Built from https://develop.svn.wordpress.org/trunk@46732


git-svn-id: http://core.svn.wordpress.org/trunk@46532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-14 09:57:03 +00:00
Sergey Biryukov
04ba6a1d8f Docs: Correct parameter type for $item in WP_REST_Terms_Controller::prepare_item_for_response(). 
Props diddledan, TimothyBlynJacobs.
Fixes #48616.
Built from https://develop.svn.wordpress.org/trunk@46731


git-svn-id: http://core.svn.wordpress.org/trunk@46531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-14 08:55:02 +00:00
Sergey Biryukov
d4cec569fe Docs: Fix typo in @return value for PO::trim_quotes(). 
Props diddledan.
Fixes #48572.
Built from https://develop.svn.wordpress.org/trunk@46730


git-svn-id: http://core.svn.wordpress.org/trunk@46530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-13 13:45:02 +00:00
John Blackbourn
3def77672d Docs: Correct some invalid hook docblocks. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46729


git-svn-id: http://core.svn.wordpress.org/trunk@46529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-12 22:42:02 +00:00
Sergey Biryukov
6ceb0279af Help/About: Move images to the CDN. 
Props ryelle.
Fixes #47708.
Built from https://develop.svn.wordpress.org/trunk@46724


git-svn-id: http://core.svn.wordpress.org/trunk@46524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-12 18:30:03 +00:00
Sergey Biryukov
3696fadc2d Bundled Themes: Update Twenty Twenty. 
This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46715], see fa8c3fc...a9e73ab.

Props Anlino, karmatosed, williampatton, poena, joyously, ianbelanger, chetan200891.
See #48110, #48386, #48450, #48505, #48557.
Fixes #48571.
Built from https://develop.svn.wordpress.org/trunk@46722


git-svn-id: http://core.svn.wordpress.org/trunk@46522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-12 18:24:03 +00:00
Sergey Biryukov
7ce88a02cd Bundled Themes: Update copyright year in readme.txt for Twenty Twelve and Twenty Twenty. 
Follow-up to [46719].

See #48566.
Built from https://develop.svn.wordpress.org/trunk@46720


git-svn-id: http://core.svn.wordpress.org/trunk@46520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-12 17:51:02 +00:00
Sergey Biryukov
7de0113520 Bundled Themes: Update copyright year in readme.txt. 
Add a unit test to ensure the year stays up to date.

Props dkarfa, SergeyBiryukov.
Fixes #48566.
Built from https://develop.svn.wordpress.org/trunk@46719


git-svn-id: http://core.svn.wordpress.org/trunk@46519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-12 17:36:02 +00:00
Sergey Biryukov
46c8d07046 Bundled Themes: Update Twenty Twenty. 
* Add `.has-background` excluding condition to wide and full group-blocks.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46714], see 162edc0...fa8c3fc.

Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Fixes #48557.
Built from https://develop.svn.wordpress.org/trunk@46715


git-svn-id: http://core.svn.wordpress.org/trunk@46515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-12 02:06:01 +00:00
Sergey Biryukov
01685e57be Bundled Themes: Update Twenty Twenty. 
* Add a11y-friendly default text-colors when selecting a background-color.
* Remove margins for the group block when a background-color is set.
* Excluding pullquote block from width resize rules.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46711], see ab5fa23...162edc0.

Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Fixes #48557.
Built from https://develop.svn.wordpress.org/trunk@46713


git-svn-id: http://core.svn.wordpress.org/trunk@46513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-12 01:44:02 +00:00
Sergey Biryukov
128147ccd5 Twenty Twenty: Make CSS adjustments to account for the latest editor changes and ensure that group blocks work in expected ways. 
Props williampatton, allancole, karmatosed, pierlo, joen, ianbelanger.
Fixes #48557.
Built from https://develop.svn.wordpress.org/trunk@46711


git-svn-id: http://core.svn.wordpress.org/trunk@46511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 20:56:02 +00:00
Sergey Biryukov
2265c36568 Help/About: Update the 5.3 About page. 
* Remove extra padding on the Credits tab.

Previously [46556], [46572], [46616], [46705].
Props ryelle.
See #47708.
Built from https://develop.svn.wordpress.org/trunk@46709


git-svn-id: http://core.svn.wordpress.org/trunk@46509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 20:45:04 +00:00
whyisjake
5f5ab66a6b Tests: Fix a typo in an inline comment. 
Fix a regression from [46568].

Props david.binda.
See #48312.

Built from https://develop.svn.wordpress.org/trunk@46707


git-svn-id: http://core.svn.wordpress.org/trunk@46507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 18:50:04 +00:00
Sergey Biryukov
ba249d8951 Help/About: Update the 5.3 About page. 
* Remove the SVG from the upper right corner.
* Make sure admin notices that should be hidden stay hidden.
* Address a11y issues with contrast.
* Fix an issue with the active nav tab hover.
* Prevent names on the credits from breaking out of the box.
* Update two strings with a more accurate information.

Previously [46556], [46572], [46616].

Props ryelle, afercia, audrasjb, francina, mapk, desrosj, YordanSoares, melchoyce, azaozz, johnbillion, davidbaumwald, luminuu, bwmarkle, la-geek, SergeyBiryukov.
See #47708.
Built from https://develop.svn.wordpress.org/trunk@46705


git-svn-id: http://core.svn.wordpress.org/trunk@46505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 16:07:03 +00:00
Sergey Biryukov
1fceddf46b Script Loader: In wp_default_packages_inline_scripts(), make sure the root URL middleware is registered before using the media middleware. 
This allows for requests to retry post-processing large images using the `post-process` REST API endpoint to work as expected.

Props azaozz, mikeschroder, TimothyBlynJacobs, epiqueras, johnbillion, youknowriad.
Fixes #48542.
Built from https://develop.svn.wordpress.org/trunk@46703


git-svn-id: http://core.svn.wordpress.org/trunk@46503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 15:10:02 +00:00
Sergey Biryukov
9fa094ea50 Twenty Twenty: Fix WPCS issue in [46701]. 
See #48557.
Built from https://develop.svn.wordpress.org/trunk@46702


git-svn-id: http://core.svn.wordpress.org/trunk@46502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 12:59:00 +00:00
Sergey Biryukov
f29206f73c Bundled Themes: Update Twenty Twenty. 
This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC4, see c267289...898792b.

Props williampatton, poena, andersnoren, desrosj, schlessera, leprincenoir, alextran, aristath, b-07.
See #48110, #48386, #48450, #48505.
Fixes #48557.
Built from https://develop.svn.wordpress.org/trunk@46701


git-svn-id: http://core.svn.wordpress.org/trunk@46501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 12:29:01 +00:00
Sergey Biryukov
6c4b808137 Comments: Check if comment form element exists before adding a key handler to detect the cmd/ctrl-enter key press. 
Follow-up to [45790].

Props raamdev.
Fixes #48543. See #41545.
Built from https://develop.svn.wordpress.org/trunk@46700


git-svn-id: http://core.svn.wordpress.org/trunk@46500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 11:51:03 +00:00
Sergey Biryukov
f67b1a6385 Customize: Remove the deprecated -precomposed suffix from apple-touch-icon link in wp_site_icon(). 
Props mukto90, khag7.
Fixes #48555.
Built from https://develop.svn.wordpress.org/trunk@46698


git-svn-id: http://core.svn.wordpress.org/trunk@46498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 10:00:01 +00:00
Sergey Biryukov
323e25b2bc Networks and Sites: Pass the $blog_id parameter to the newblog_notify_siteadmin filter. 
Props mukto90, virgodesign.
Fixes #48554.
Built from https://develop.svn.wordpress.org/trunk@46697


git-svn-id: http://core.svn.wordpress.org/trunk@46497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 09:53:02 +00:00
Sergey Biryukov
3d623995a8 Docs: In various @return tags, list the expected type first, instead of WP_Error. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46696


git-svn-id: http://core.svn.wordpress.org/trunk@46496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 02:43:03 +00:00
Sergey Biryukov
82dfb2d151 Docs: Miscellaneous docblock corrections in wp-admin/includes/plugin.php. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46695


git-svn-id: http://core.svn.wordpress.org/trunk@46495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 00:05:01 +00:00
Sergey Biryukov
2af39e45cb Docs: Improve documentation for deactivate_plugins() and activate_plugins(). 
Props marekdedic, spenserhale, SergeyBiryukov.
Fixes #48352.
Built from https://develop.svn.wordpress.org/trunk@46694


git-svn-id: http://core.svn.wordpress.org/trunk@46494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-10 23:05:03 +00:00
Sergey Biryukov
7b6d73a9ff Tests: Don't skip the tests intended for Multisite when running on single site, add them to the ms-required group instead. 
See #43438.
Built from https://develop.svn.wordpress.org/trunk@46693


git-svn-id: http://core.svn.wordpress.org/trunk@46493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-10 01:55:02 +00:00
Sergey Biryukov
adf35e9217 Coding Standards: Fix WPCS issue in [46690]. 
See #41880.
Built from https://develop.svn.wordpress.org/trunk@46692


git-svn-id: http://core.svn.wordpress.org/trunk@46492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-10 01:45:02 +00:00
Sergey Biryukov
b0ddfb2435 Docs: Move the @link tag for Customize API in WP_Customize_Manager::add_setting() and WP_Customize_Setting to a more appropriate place. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46691


git-svn-id: http://core.svn.wordpress.org/trunk@46491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-10 01:43:02 +00:00
Sergey Biryukov
5fb34a0a1c Docs: Improve documentation for WP_Http per the documentation standards. 
Props hareesh-pillai, adnan.limdi, isabel_brison.
Fixes #41880.
Built from https://develop.svn.wordpress.org/trunk@46690


git-svn-id: http://core.svn.wordpress.org/trunk@46490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-10 01:18:02 +00:00
Sergey Biryukov
4d8a0a8b33 Docs: Use 3-digit, x.x.x style semantic versioning for $version argument in do_action_deprecated() and apply_filters_deprecated() calls. 
Props jrf.
Fixes #48255.
Built from https://develop.svn.wordpress.org/trunk@46689


git-svn-id: http://core.svn.wordpress.org/trunk@46489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-09 13:57:03 +00:00
Sergey Biryukov
6ed1a7b615 Docs: Correct the documentation placement for wp_print_styles and shortcode_atts_{$shortcode} hooks. 
Props jrf.
See #48255.
Built from https://develop.svn.wordpress.org/trunk@46688


git-svn-id: http://core.svn.wordpress.org/trunk@46488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-09 13:43:01 +00:00
Sergey Biryukov
0e79d4d101 Coding Standards: Fix WPCS issue in [46684]. 
See #48255.
Built from https://develop.svn.wordpress.org/trunk@46687


git-svn-id: http://core.svn.wordpress.org/trunk@46487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-09 13:33:02 +00:00
Sergey Biryukov
81490ddbb1 Coding Standards: Revert the change to wp-includes/class-wp-xmlrpc-server.php in [46684] to investigate unit test failures. 
See #48255.
Built from https://develop.svn.wordpress.org/trunk@46686


git-svn-id: http://core.svn.wordpress.org/trunk@46486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-09 13:31:01 +00:00
Sergey Biryukov
1f816ad18d Docs: Use the {@see ...} tag for the replacement in @deprecated tags, so that Developer Reference could automatically link to the replacement. 
Props jrf.
See #48255.
Built from https://develop.svn.wordpress.org/trunk@46685


git-svn-id: http://core.svn.wordpress.org/trunk@46485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-09 13:05:02 +00:00
Sergey Biryukov
f60094679f Coding Standards: Consistently use do_action_deprecated() and apply_filters_deprecated() for deprecated hooks. 
Props jrf.
See #48255.
Built from https://develop.svn.wordpress.org/trunk@46684


git-svn-id: http://core.svn.wordpress.org/trunk@46484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-09 12:59:03 +00:00
Sergey Biryukov
5c094564a7 Test: Don't skip the tests intended for single site when running on Multisite, add them to the ms-excluded group instead. 
See #39776, #45747.
Built from https://develop.svn.wordpress.org/trunk@46683


git-svn-id: http://core.svn.wordpress.org/trunk@46483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-09 03:46:02 +00:00
Sergey Biryukov
c8f6d05c64 Tests: Skip test_readme() if the HTTP request to secure.php.net or dev.mysql.com failed on timeout. 
Move `skipTestOnTimeout()` to `WP_UnitTestCase_Base` to avoid duplication.

See #44613.
Built from https://develop.svn.wordpress.org/trunk@46682


git-svn-id: http://core.svn.wordpress.org/trunk@46482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-09 03:38:00 +00:00
Sergey Biryukov
ba21b391f6 Docs: Correct some inconsistencies in comments with Dashicon class references in wp-admin/css/customize-widgets.css. 
Prepend all class name references with `dashicons-` for clarity.

Props 1naveengiri, marcio-zebedeu, hareesh-pillai, SergeyBiryukov.
Fixes #48417.
Built from https://develop.svn.wordpress.org/trunk@46681


git-svn-id: http://core.svn.wordpress.org/trunk@46481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-09 00:03:02 +00:00
Sergey Biryukov
15a4289c8d Docs: Correct description for $recursive parameter of ::chmod() and ::delete() methods in WP_Filesystem implementations. 
Props skithund.
Fixes #48422.
Built from https://develop.svn.wordpress.org/trunk@46679


git-svn-id: http://core.svn.wordpress.org/trunk@46479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-08 22:56:02 +00:00
John Blackbourn
84a1922e18 Toolbar: Un-deprecate the WP_Admin_Bar::add_menu() method. 
This is only a wrapper for the `add_node()` method, but it's in widespread use both in core until [46642] and in thousands of plugins and themes. Deprecating it would have made sense when #19647 was originally opened but that's no longer the case.

Props whyisjake

Fixes #19647 

Built from https://develop.svn.wordpress.org/trunk@46678


git-svn-id: http://core.svn.wordpress.org/trunk@46478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-08 13:19:04 +00:00
Andrew Ozz
60c2966222 Upload: When an image was scaled because it is larger than the big image threshold, use the originally uploaded image's dimensions in wp_get_missing_image_subsizes(). Fixes an edge case/inconsistent behaviour when a registered image sub-size is also larger than the big image threshold. 
Props desrosj, azaozz.
Fixes #48518 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46677


git-svn-id: http://core.svn.wordpress.org/trunk@46477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-07 18:51:02 +00:00
desrosj
24f21d628d Bundled Themes: Standardize the Required PHP and Tested Up To headers. 
This change makes several changes to ensure consistency and accuracy for default theme headers:

- Removes `WordPress` from `Requires at least` headers.
- Ensures the `Requires at least` and `Requires PHP` headers are present in every default theme’s `style.css` file.
- Ensures `Tested up to` is present in every `readme.txt` file.
- Removes any headers not processed in both the `style.css` and `readme.txt` files for each theme.

Props Otto42, afragen.
Fixes #48517.
Built from https://develop.svn.wordpress.org/trunk@46676


git-svn-id: http://core.svn.wordpress.org/trunk@46476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-07 15:19:04 +00:00
Sergey Biryukov
9088bea749 Docs: Make @param tags in mce_buttons and related filters consistent with the variable names. 
Props upadalavipul, isabel_brison.
Fixes #41456.
Built from https://develop.svn.wordpress.org/trunk@46675


git-svn-id: http://core.svn.wordpress.org/trunk@46475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-07 07:12:06 +00:00
Sergey Biryukov
4a2dc1a1a2 Tests: Properly mark test_submenu_helpers_priority() as skipped for multisite, so it's not categorized as "risky". 
See #39776.
Built from https://develop.svn.wordpress.org/trunk@46674


git-svn-id: http://core.svn.wordpress.org/trunk@46474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-06 01:17:03 +00:00
Sergey Biryukov
46caa0bfe8 Coding Standards: Fix WPCS issues in [46670]. 
See #48145.
Built from https://develop.svn.wordpress.org/trunk@46671


git-svn-id: http://core.svn.wordpress.org/trunk@46471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 23:18:02 +00:00
John Blackbourn
a02c91ca17 REST API: Use explicit dates in a post ordering test to avoid indeterminate ordering. 
See #48145

Built from https://develop.svn.wordpress.org/trunk@46670


git-svn-id: http://core.svn.wordpress.org/trunk@46470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 22:41:01 +00:00
desrosj
ffbde837e0 Bundled Themes: Update Twenty Twenty. 
This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC3, see dea9290...c267289.

Props williampatton, poena, andersnoren.
See #48110, #48386, #48450, #48293.
Fixes #48505.
Built from https://develop.svn.wordpress.org/trunk@46668


git-svn-id: http://core.svn.wordpress.org/trunk@46468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 22:22:01 +00:00
desrosj
b8a473c834 Emoji: Upgrade Twemoji to 12.1.3. 
This point release does not add any images and only slightly modifies a few images without changing their meanings. Because of this, the same CDN location can be used and has been updated.

Props matstars, desrosj, Otto42, pento.
Fixes #48293.
Built from https://develop.svn.wordpress.org/trunk@46665


git-svn-id: http://core.svn.wordpress.org/trunk@46465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 22:04:02 +00:00
John Blackbourn
9716848c87 Block Editor: Revert [46663] which was itself an erroneous revert. 
See #48502

Built from https://develop.svn.wordpress.org/trunk@46664


git-svn-id: http://core.svn.wordpress.org/trunk@46464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 21:59:03 +00:00
John Blackbourn
13f3142222 Block Editor: Bug fixes targeted for WordPress 5.3 RC4. 
Merges [46656] to the 5.3 branch.
Fixes #48502

Built from https://develop.svn.wordpress.org/trunk@46663


git-svn-id: http://core.svn.wordpress.org/trunk@46463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 21:53:03 +00:00
John Blackbourn
eda6a9e111 Docs: Docs on docs. Further improve documentation of known return types, plus other docs fixes. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46662


git-svn-id: http://core.svn.wordpress.org/trunk@46462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 21:30:03 +00:00
John Blackbourn
9ac1d82f23 Docs: Further improve documentation of known return types, plus other docs fixes. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46661


git-svn-id: http://core.svn.wordpress.org/trunk@46461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 21:27:02 +00:00
John Blackbourn
f545bb3f63 Docs: Improve documentation of known return types, plus other docs fixes. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46660


git-svn-id: http://core.svn.wordpress.org/trunk@46460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 21:23:02 +00:00
Andrew Ozz
f9e81c83d5 Media: Remove the variable number (from the big image threshold value) when generating file names for scaled images. This makes it easier to "calculate" the full size file name from the name of an intermediate size image. 
Props ianmjones, azaozz.
Fixes #48453 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46658


git-svn-id: http://core.svn.wordpress.org/trunk@46458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 20:53:03 +00:00
Sergey Biryukov
ee7ec873ce REST API: Speed up pagination unit tests by creating less fixtures and reusing them where possible. 
Includes minor documentation and code layout fixes for better readability.

See #30017, #48145.
Built from https://develop.svn.wordpress.org/trunk@46657


git-svn-id: http://core.svn.wordpress.org/trunk@46457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 20:43:04 +00:00
jorgefilipecosta
6cdb9d0a37 Block Editor: Bug fixes targeted for WordPress 5.3 RC4. 
The list of included fixes is:

https://github.com/WordPress/gutenberg/pull/18183
https://github.com/WordPress/gutenberg/pull/18194
https://github.com/WordPress/gutenberg/pull/18230
https://github.com/WordPress/gutenberg/pull/18275
https://github.com/WordPress/gutenberg/pull/18287

Updated packages:
 - @wordpress/block-editor@3.2.4
 - @wordpress/block-library@2.9.5
 - @wordpress/edit-post@3.8.5
 - @wordpress/editor@9.7.5
 - @wordpress/format-library@1.9.4

Props @aduth, @mcsf, @youknowriad, @johnbillion.
Fixes #48502.
Built from https://develop.svn.wordpress.org/trunk@46656


git-svn-id: http://core.svn.wordpress.org/trunk@46456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 19:36:07 +00:00
whyisjake
5b4fe55ee8 REST API: Fix for Yoda condition. 
Little coding standards fix for the REST API.

Props mukesh27, spenserhale.

Fixes #48337.

Built from https://develop.svn.wordpress.org/trunk@46654


git-svn-id: http://core.svn.wordpress.org/trunk@46454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 17:38:03 +00:00
John Blackbourn
2e22c8292d Docs: Correct and improve the readability of some parameters of WP_Term_Query. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46652


git-svn-id: http://core.svn.wordpress.org/trunk@46452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-04 17:50:02 +00:00
Andrew Ozz
43ed67661a Upload: Ensure the new image meta is always saved before starting post-processing of an uploaded image, even if there was an error while scaling or rotating it. 
See #48472.
Built from https://develop.svn.wordpress.org/trunk@46651


git-svn-id: http://core.svn.wordpress.org/trunk@46451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-04 17:07:03 +00:00
Sergey Biryukov
4ef6154be2 Login and Registration: Simplify the test for wp_signon() added in [46640]. 
Make sure it actually tests the change in behavior, previously it passed both before and after the patch.

Add `wp_unslash()` to the last remaining instance of `$_POST['user_login']` that didn't have it.

See #38744.
Built from https://develop.svn.wordpress.org/trunk@46650


git-svn-id: http://core.svn.wordpress.org/trunk@46450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-04 15:06:02 +00:00
Sergey Biryukov
b5bf852dfe Build/Test Tools: Adjust the test for wp_redirect() status codes added in [46641] per the documentation and coding standards. 
Move the test to a more appropriate place for consistency with `wp_sanitize_redirect()` and `wp_validate_redirect()` tests.

See #44317.
Built from https://develop.svn.wordpress.org/trunk@46649


git-svn-id: http://core.svn.wordpress.org/trunk@46449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-04 12:59:01 +00:00
Sergey Biryukov
8dc75b569c REST API: Set orderby parameter in tax relation unit tests added in [46646]. 
The default value of `date` caused a race condition resulting in random test failures.

See #44326.
Built from https://develop.svn.wordpress.org/trunk@46648


git-svn-id: http://core.svn.wordpress.org/trunk@46448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-04 12:36:04 +00:00
Sergey Biryukov
8b76312eb3 Docs: Correct some array hash notations added in [46644]. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46647


git-svn-id: http://core.svn.wordpress.org/trunk@46447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-04 09:37:02 +00:00
TimothyBlynJacobs
5124c542e1 REST API: Add tax relation parameter to posts collection. 
The REST API supports filtering by terms across multiple taxonomies using an AND relation. This adds support for an OR relation by adding "tax_relation=OR" as a query parameter.

Props earnjam.
Fixes #44326.

Built from https://develop.svn.wordpress.org/trunk@46646


git-svn-id: http://core.svn.wordpress.org/trunk@46446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 23:14:02 +00:00
Aaron Jorbin
a4687f9134 Remove Failing Tests added in r46641 
The tests for good redirects send headers that we can't handle in the test suite, so let's just remove them.

Unprops Jorbin.
Fixes #44317.


Built from https://develop.svn.wordpress.org/trunk@46645


git-svn-id: http://core.svn.wordpress.org/trunk@46445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 22:49:03 +00:00
John Blackbourn
b3d6acd6a4 Docs: Fix some incorrect return tags in docblocks. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46644


git-svn-id: http://core.svn.wordpress.org/trunk@46444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 22:23:01 +00:00
whyisjake
441a4d752e Coding Standards: Clean up the tests around test_that_you_can_login_with_an_email_that_has_apostrophe. 
Let's use the proper coding standards for the comments.

Fixes #38744.
Props cafenoirdesign.

Built from https://develop.svn.wordpress.org/trunk@46643


git-svn-id: http://core.svn.wordpress.org/trunk@46443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 22:17:58 +00:00
whyisjake
5e7876622e Toolbar: Use add_node() instead of add_menu() in core. 
This patch replaces all references to the add_menu() method with the add_node() one. (Also some code structure modifications for wp_admin_bar_appearance_menu().)

Fixes: #19647
Props: linuxologos, paulschreiber, morganestes, akibjorklund, nacin, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@46642


git-svn-id: http://core.svn.wordpress.org/trunk@46442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 22:14:01 +00:00
Aaron Jorbin
946217dcca General: wp_safe_redirect() and wp_redirect() shouldn't allow non-3xx status codes 
Redirects should use redirect status codes and if you attempt to call wp_safe_redirect or wp_redirect with a non redirect status it can lead to undesired behavior and head scratching.

Fixes #44317.
Props spenserhale, johnbillion, mjnewman for initial patch.


Built from https://develop.svn.wordpress.org/trunk@46641


git-svn-id: http://core.svn.wordpress.org/trunk@46441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 22:10:02 +00:00
whyisjake
a87271af60 Login and Registration: Allow email logins to be more flexible. 
Allows a login to have an apostorphe. Which would normally be created as a mistake, but this allows the login to happen.

Fixes #38744
Props wpkuf, desrosj, socalchristina, bibliofille, santilinwp, nsubugak, sncoker, cafenoirdesign, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@46640


git-svn-id: http://core.svn.wordpress.org/trunk@46440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 20:12:02 +00:00
desrosj
44db7e4f6f External Libraries: Revert [46634-46635]. 
On further investigation, Plupload changed it’s license to a non-GPL compatible license. The newest, GPL compatible version is being used already in Core.

Unprops desrosj.
See #48277.
Built from https://develop.svn.wordpress.org/trunk@46638


git-svn-id: http://core.svn.wordpress.org/trunk@46438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 17:09:02 +00:00
desrosj
583e49d95f Customize: Formally deprecate unused Customizer classes. 
The `WP_Customize_New_Menu_Control` and `WP_Customize_New_Menu_Section` PHP classes and `wp.customize.Menus.NewMenuControl` JS class were deprecated in 4.9 through [42034] with the intention of removing them in 5.0. Since more time has passed than originally intended, this change leaves `WP_Customize_New_Menu_Control` and `WP_Customize_New_Menu_Section` to prevent any potential backwards compatibility issues, and formally deprecates them. The `wp.customize.Menus.NewMenuControl` JS class is removed.

Props weston.ruter, matthias-reuter, jrf.
Fixes #42364.
Built from https://develop.svn.wordpress.org/trunk@46637


git-svn-id: http://core.svn.wordpress.org/trunk@46437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 16:48:00 +00:00
desrosj
be164bf6f4 Add svn:auto-props for eol-style and mime-type to trunk. 
`svn:eol-style` and `svn:mime-type` property default values are now provided for all file types currently in `trunk`.

This also reverts the `eol-style` change to `wp-config-sample.php` made in [46586].

Fixes #42594.
Built from https://develop.svn.wordpress.org/trunk@46636


git-svn-id: http://core.svn.wordpress.org/trunk@46436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 16:21:03 +00:00
desrosj
df7a0f7879 Remove unintended change to svn:ignore in [46634]. 
Built from https://develop.svn.wordpress.org/trunk@46635


git-svn-id: http://core.svn.wordpress.org/trunk@46435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 15:34:00 +00:00
desrosj
d825155631 External Libraries: Update Plupload from 2.1.9 to 2.3.6. 
This change also updates the MoxieJS dependency from 1.3.5 to 1.5.7, converts Plupload to a dependency in NPM, and integrates all relevant parts into the build process.

For a full list of upstream changes, see https://github.com/moxiecode/plupload/compare/v2.1.9...v2.3.6.

Props desrosj, hareesh-pillai.
Fixes #48277.
Built from https://develop.svn.wordpress.org/trunk@46634


git-svn-id: http://core.svn.wordpress.org/trunk@46434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 15:31:02 +00:00
Sergey Biryukov
265bc4fe74 General: Wrap the error message in _deprecated_constructor() in <code> tags instead of <pre>. 
Props aftabmuni.
Fixes #48483.
Built from https://develop.svn.wordpress.org/trunk@46633


git-svn-id: http://core.svn.wordpress.org/trunk@46433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 10:56:03 +00:00
Sergey Biryukov
24650cbd68 Code Modernization: Call PHP 5 constructors in methods extending POMO_Reader. 
Follow-up to [46629].

See #48252.
Built from https://develop.svn.wordpress.org/trunk@46632


git-svn-id: http://core.svn.wordpress.org/trunk@46432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-02 20:49:01 +00:00
Sergey Biryukov
6cd00d098e Docs: Correct version number in @deprecated tags for PHP 4 constructors in pomo/entry.php and pomo/streams.php. 
Follow-up to [46629].

Props jrf.
See #48252.
Built from https://develop.svn.wordpress.org/trunk@46631


git-svn-id: http://core.svn.wordpress.org/trunk@46431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-02 20:30:01 +00:00
Sergey Biryukov
85db3b5090 Docs: Correct @see references for PHP 4 constructors in wp-includes/class-json.php. 
See #48252, #48303.
Built from https://develop.svn.wordpress.org/trunk@46630


git-svn-id: http://core.svn.wordpress.org/trunk@46430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-02 20:13:02 +00:00
Sergey Biryukov
a0e7056387 Docs: Add missing @deprecated tags to PHP 4 constructors in pomo/entry.php and pomo/streams.php. 
Props jrf.
Fixes #48252.
Built from https://develop.svn.wordpress.org/trunk@46629


git-svn-id: http://core.svn.wordpress.org/trunk@46429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-02 20:11:04 +00:00
Sergey Biryukov
8aae5cb572 Twenty Eleven: Add missing @deprecated tag to PHP 4 constructor in Twenty_Eleven_Ephemera_Widget. 
Props jrf.
See #48252.
Built from https://develop.svn.wordpress.org/trunk@46628


git-svn-id: http://core.svn.wordpress.org/trunk@46428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-02 20:08:00 +00:00
Sergey Biryukov
6be425959a Docs: Add missing @deprecated tags to PHP 4 constructors in WP_Widget and WP_Widget_Factory(). 
Correct version number in `_deprecated_constructor()` call in `WP_Widget_Factory()`, see [32990].

Props jrf.
See #48252.
Built from https://develop.svn.wordpress.org/trunk@46627


git-svn-id: http://core.svn.wordpress.org/trunk@46427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-02 20:06:03 +00:00
Sergey Biryukov
2651ff3ae8 Docs: Update URLs in some @link tags and switch them to HTTPS. 
Props tsuyoring.
Fixes #48479.
Built from https://develop.svn.wordpress.org/trunk@46626


git-svn-id: http://core.svn.wordpress.org/trunk@46423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-01 14:57:02 +00:00
Sergey Biryukov
979a526902 Code Modernization: Pass an appropriate error level to trigger_error() in _doing_it_wrong() and related functions: 
* `_deprecated_function()`
* `_deprecated_argument()`
* `_deprecated_constructor()`
* `_deprecated_file()`

The error level passed is `E_USER_DEPRECATED` for the deprecated function group and `E_USER_NOTICE` for `_doing_it_wrong()`.

Props jrf.
Fixes #36561.
Built from https://develop.svn.wordpress.org/trunk@46625


git-svn-id: http://core.svn.wordpress.org/trunk@46422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-01 00:41:01 +00:00
John Blackbourn
be91e3e1b9 Docs: Correct some more invalid inline docs. 
See https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#summary-formerly-short-description

See #48303

Built from https://develop.svn.wordpress.org/trunk@46624


git-svn-id: http://core.svn.wordpress.org/trunk@46421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-31 21:20:02 +00:00
John Blackbourn
d1b23193dd Docs: Correct some incorrect docblock tags. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46623


git-svn-id: http://core.svn.wordpress.org/trunk@46420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-31 17:51:01 +00:00
Sergey Biryukov
3d76b537d6 Docs: Add @since tag for the $context parameter added to wp_generate_attachment_metadata filter in [46621]. 
See #48472.
Built from https://develop.svn.wordpress.org/trunk@46622


git-svn-id: http://core.svn.wordpress.org/trunk@46419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-31 00:13:01 +00:00
Andrew Ozz
ed651b17a4 Upload: 
- Run the `wp_generate_attachment_metadata` filter at the end in `wp_update_image_subsizes()` when new metadata was generated and additional image sub-sizes were created.
- Add another arg in the `wp_generate_attachment_metadata` filter for additional context.
- Fix inline docs and ensure the new image meta is always saved before starting post-processing.

Fixes #48472 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46621


git-svn-id: http://core.svn.wordpress.org/trunk@46418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-30 21:10:04 +00:00
Sergey Biryukov
e678d5bf28 Docs: Document $error, $interim_login, and $action globals in login_header() and login_footer(). 
Props priyankabehera155, faisal03, mukesh27, SergeyBiryukov.
Fixes #45777.
Built from https://develop.svn.wordpress.org/trunk@46620


git-svn-id: http://core.svn.wordpress.org/trunk@46417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-30 02:59:03 +00:00
desrosj
0b94025ba9 Help/About: Update the 5.3 About page for RC3. 
Previously [46556], [46572].
Props ryelle, SergeyBiryukov, afercia, desrosj, davidbaumwald, azaozz.
See #47708.
Built from https://develop.svn.wordpress.org/trunk@46616


git-svn-id: http://core.svn.wordpress.org/trunk@46413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-29 20:10:04 +00:00
desrosj
b5cc5b37f7 Bundled Themes: Update Twenty Twenty. 
This brings trunk’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46571], see 4549fd9...dea9290.

Props anlino, ianbelanger, poena, williampatton, collet, erikkroes, torres126, intimez, byalextran, mehidi258, swapnild, nielslange.
Fixes #48450.
Built from https://develop.svn.wordpress.org/trunk@46613


git-svn-id: http://core.svn.wordpress.org/trunk@46410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-29 14:55:05 +00:00
Sergey Biryukov
4935555c70 Build/Test Tools: Ignore EOL differences in tests using multiline string assertions. 
Unix vs. Windows EOL style mismatches can cause misleading failures in tests using the heredoc syntax (`<<<`) or multiline strings as the expected result.

Fixes #31432. See #42594, #47411.
Built from https://develop.svn.wordpress.org/trunk@46612


git-svn-id: http://core.svn.wordpress.org/trunk@46409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-29 14:28:06 +00:00
John Blackbourn
057f661ce3 Docs: Miscellaneous docblock corrections. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46610


git-svn-id: http://core.svn.wordpress.org/trunk@46407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-28 19:48:01 +00:00
John Blackbourn
c08dbe5236 Docs: Coding standards fix after [46608]. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46609


git-svn-id: http://core.svn.wordpress.org/trunk@46406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-28 19:35:07 +00:00
John Blackbourn
817807e5be Docs: Remove some funky nested filters. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46608


git-svn-id: http://core.svn.wordpress.org/trunk@46405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-28 19:04:05 +00:00
Sergey Biryukov
3a257f4018 Docs: Restore correct placement for duplicate hook reference in render_block_core_latest_comments(). 
Previously fixed in [46604], accidentally reverted in [46606].

See #48447, #48303.
Built from https://develop.svn.wordpress.org/trunk@46607


git-svn-id: http://core.svn.wordpress.org/trunk@46404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-28 15:17:03 +00:00
youknowriad
6a713e53bc Block Editor: Bug fixes targetted for WordPress 5.3 RC3. 
The list of included fixes is:

- https://github.com/WordPress/gutenberg/pull/18108
- https://github.com/WordPress/gutenberg/pull/18051
- https://github.com/WordPress/gutenberg/pull/18106
- https://github.com/WordPress/gutenberg/pull/18102

Updated packages:
 - @wordpress/api-fetch@3.6.4
 - @wordpress/block-directory@1.0.4
 - @wordpress/block-library@2.9.4
 - @wordpress/core-data@2.7.4
 - @wordpress/data-controls@1.3.4
 - @wordpress/edit-post@3.8.4
 - @wordpress/editor@9.7.4
 - @wordpress/list-reusable-blocks@1.8.4
 - @wordpress/media-utils@1.2.4
 - @wordpress/server-side-render@1.3.4

Props desrosj.
See #48447.

Built from https://develop.svn.wordpress.org/trunk@46606


git-svn-id: http://core.svn.wordpress.org/trunk@46403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-28 14:13:09 +00:00
whyisjake
7542543e26 Build/Test Tools: Don't hardcode the directory name of the repo 
When Travis builds the directory, it was looking for a hardcoded `wordpress-develop` directory. If the repo is sitting in another directory, the memcache install will fail. This allows a dynamic path for the directory.

Fixes #48444.
Props pento, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@46605


git-svn-id: http://core.svn.wordpress.org/trunk@46402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-28 04:17:02 +00:00
John Blackbourn
f243cd573c Docs: Correct invalid hook docblock placement. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46604


git-svn-id: http://core.svn.wordpress.org/trunk@46401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-27 19:35:01 +00:00
John Blackbourn
c8f91f77ac Docs: Correct invalid hook docblocks. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46603


git-svn-id: http://core.svn.wordpress.org/trunk@46400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-27 19:11:02 +00:00
Sergey Biryukov
c283f8b1ed Docs: Remove "private" designation from _doing_it_wrong() and related functions: 
* `_deprecated_function()`
* `_deprecated_argument()`
* `_deprecated_constructor()`
* `_deprecated_file()`

Plugins and themes should be allowed to use these functions to throw appropriate error notices.

This brings them in line with newer `do_action_deprecated()` and `apply_filters_deprecated()` functions, which are not marked as private.

Props jrf.
Fixes #48251.
Built from https://develop.svn.wordpress.org/trunk@46602


git-svn-id: http://core.svn.wordpress.org/trunk@46399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-27 14:21:03 +00:00
Sergey Biryukov
e015fbd8bb Editor: Fix typo in an error message in WP_Block_Styles_Registry::register(). 
Props man4toman, alishankhan, shaampk1.
Fixes #48437.
Built from https://develop.svn.wordpress.org/trunk@46601


git-svn-id: http://core.svn.wordpress.org/trunk@46398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-27 14:09:02 +00:00
Sergey Biryukov
bb57520713 Docs: Improve DocBlock formatting in WP_Block_Styles_Registry per the documentation standards. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46600


git-svn-id: http://core.svn.wordpress.org/trunk@46397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-27 14:07:02 +00:00
John Blackbourn
d599314349 Docs: Correct and improve inline docs for the file type functions. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46599


git-svn-id: http://core.svn.wordpress.org/trunk@46396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 23:49:03 +00:00
John Blackbourn
ac6bf7666c Docs: Add missing docs for the auth_cookie_bad_session_token action. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46598


git-svn-id: http://core.svn.wordpress.org/trunk@46395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 23:46:00 +00:00
John Blackbourn
9e2b6902b3 Docs: Update the docs for the error parameter that gets passed around during filesystem credential collection. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46597


git-svn-id: http://core.svn.wordpress.org/trunk@46394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 23:16:04 +00:00
John Blackbourn
3caaa40fc6 Docs: Switch more docs over to typed array notation, plus some fixes. 
See #48303, #41756

Built from https://develop.svn.wordpress.org/trunk@46596


git-svn-id: http://core.svn.wordpress.org/trunk@46393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 21:09:04 +00:00
John Blackbourn
9890e68661 Docs: Switch to typed array notation for the docs for asset dependency functions. 
Props marekdedic

See #48303

Built from https://develop.svn.wordpress.org/trunk@46595


git-svn-id: http://core.svn.wordpress.org/trunk@46392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 21:02:02 +00:00
John Blackbourn
7c2b9f2a2e Docs: Miscellaneous docblock fixes and improvements. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46594


git-svn-id: http://core.svn.wordpress.org/trunk@46391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 20:43:04 +00:00
Sergey Biryukov
552852d887 Docs: Improve documentation for esc_attr_e(), esc_html_e(), esc_attr_x(), esc_html_x(). 
Props atachibana.
Fixes #48383.
Built from https://develop.svn.wordpress.org/trunk@46593


git-svn-id: http://core.svn.wordpress.org/trunk@46390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 17:30:03 +00:00
Sergey Biryukov
ac3ff7eb1a Docs: Improve documentation for wptexturize(). 
Props atachibana.
Fixes #48397.
Built from https://develop.svn.wordpress.org/trunk@46592


git-svn-id: http://core.svn.wordpress.org/trunk@46389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 00:58:04 +00:00
Sergey Biryukov
67ce1885db Docs: Improve formatting of various WP_Screen DocBlocks. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46591


git-svn-id: http://core.svn.wordpress.org/trunk@46388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 00:36:05 +00:00
Sergey Biryukov
67c73ea3ea Docs: Improve documentation for WP_Screen::add_help_tab(). 
Props atachibana.
Fixes #48395.
Built from https://develop.svn.wordpress.org/trunk@46590


git-svn-id: http://core.svn.wordpress.org/trunk@46387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 00:34:07 +00:00
Sergey Biryukov
49007e52bc Build/Test Tools: Add banner to RTL CSS and minified JS files. 
Patches occasionally come in on generated files. We should be kind to new contributors and give them a hint that these files are auto-generated.

This is a follow-up to [41271], which added the banner to minified CSS files.

Fixes #48424. See #30666.
Built from https://develop.svn.wordpress.org/trunk@46589


git-svn-id: http://core.svn.wordpress.org/trunk@46386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 00:17:07 +00:00
desrosj
b51327d391 Ensure svn:mime-type is consistently set for appropriate files. 
Continuation of [46586], [46587]

See #42594.
Built from https://develop.svn.wordpress.org/trunk@46588


git-svn-id: http://core.svn.wordpress.org/trunk@46385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 19:33:04 +00:00
desrosj
09d8704f0f Ensure svn:eol-style is consistently set for all files (part 2). 
Continuation of [46586]

See #42594.
Built from https://develop.svn.wordpress.org/trunk@46587


git-svn-id: http://core.svn.wordpress.org/trunk@46384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 19:29:04 +00:00
desrosj
eca853c79e Ensure svn:eol-style is consistently set for all files. 
See #42594.
Built from https://develop.svn.wordpress.org/trunk@46586


git-svn-id: http://core.svn.wordpress.org/trunk@46383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 16:38:07 +00:00
desrosj
43c6bc6805 Remove the svn:executable property from files that don't need it. 
See #42594.
Built from https://develop.svn.wordpress.org/trunk@46585


git-svn-id: http://core.svn.wordpress.org/trunk@46382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 15:36:05 +00:00
Sergey Biryukov
9ebaa9d522 Date/Time: Remove incomplete and redundant test for get_post_time() added in [46580]. 
There is no functional difference between `gmt_offset` and `timezone_string` timezone modes for the issue.

See #48384.
Built from https://develop.svn.wordpress.org/trunk@46583


git-svn-id: http://core.svn.wordpress.org/trunk@46380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 15:11:04 +00:00
desrosj
a922509f96 Trunk is now 5.4 alpha. 
Built from https://develop.svn.wordpress.org/trunk@46582


git-svn-id: http://core.svn.wordpress.org/trunk@46379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 14:24:04 +00:00
Sergey Biryukov
75c183c248 Date/Time: Make sure get_post_time() keeps UTC time on timezone change. 
Add `$source` parameter to `get_post_datetime()` to instantiate from local or UTC time in database.

Props Rarst, david.binda.
Reviewed by azaozz, SergeyBiryukov.
Fixes #48384.
Built from https://develop.svn.wordpress.org/trunk@46580


git-svn-id: http://core.svn.wordpress.org/trunk@46377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 13:08:05 +00:00
Sergey Biryukov
7e11e9d732 Posts, Post Types: Remove unintended change from [46578]. 
See #48384.
Built from https://develop.svn.wordpress.org/trunk@46579


git-svn-id: http://core.svn.wordpress.org/trunk@46376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 12:54:03 +00:00
Sergey Biryukov
0b83bffd45 Date/Time: Correct the logic in WP_Posts_List_Table::column_date() and WP_Media_List_Table::column_date() to check for a valid post timestamp. 
Props Rarst.
Reviewed by azaozz, SergeyBiryukov.
See #48384.
Built from https://develop.svn.wordpress.org/trunk@46578


git-svn-id: http://core.svn.wordpress.org/trunk@46375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 12:51:03 +00:00
Sergey Biryukov
8410526528 Date/Time: Make sure date_i18n() correctly handles zero timestamp after [45901]. 
Props soulseekah, gravityview, Rarst.
Reviewed by azaozz, SergeyBiryukov.
Fixes #28636.
Built from https://develop.svn.wordpress.org/trunk@46577


git-svn-id: http://core.svn.wordpress.org/trunk@46374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 11:05:07 +00:00