Commit Graph

16657 Commits

Author SHA1 Message Date
Sergey Biryukov
771b1048be Help/About: Move trailing punctuation in the jQuery Migrate Helper plugin link outside of the HTML tag.
Props psmits1567, audrasjb, tobifjellner, fierevere, markscottrobson.
Fixes #51813.
Built from https://develop.svn.wordpress.org/trunk@49685


git-svn-id: http://core.svn.wordpress.org/trunk@49408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-23 19:35:03 +00:00
Sergey Biryukov
5f9cf0141e Plugins: Check if _error_nonce is set before attempting to verify it.
This avoids a PHP notice on the Plugins screen when `error` query string is added to the URL.

Props wponlinesupport.
Fixes #43876.
Built from https://develop.svn.wordpress.org/trunk@49683


git-svn-id: http://core.svn.wordpress.org/trunk@49406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-23 13:36:07 +00:00
Sergey Biryukov
8312762816 Docs: Update syntax for multi-line comment in core_auto_updates_settings() per the documentation standards.
Follow-up to [49677].

See #51827.
Built from https://develop.svn.wordpress.org/trunk@49681


git-svn-id: http://core.svn.wordpress.org/trunk@49404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-22 15:59:05 +00:00
Sergey Biryukov
3af1bfdbfa Docs: Add documentation for the $type and $mime_type properties in WP_Customize_Image_Control.
Follow-up to [20319], [30309], [31698], [32023], [49679].

Props subrataemfluence.
Fixes #44411.
Built from https://develop.svn.wordpress.org/trunk@49680


git-svn-id: http://core.svn.wordpress.org/trunk@49403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-22 15:53:03 +00:00
Sergey Biryukov
f31f929a5b Docs: Add documentation for the $type, $mime_type, and $button_labels properties in WP_Customize_Upload_Control.
Follow-up to [20319], [30309], [31698], [32023].

Props subrataemfluence.
See #44411.
Built from https://develop.svn.wordpress.org/trunk@49679


git-svn-id: http://core.svn.wordpress.org/trunk@49402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-22 15:51:03 +00:00
Sergey Biryukov
dda5dcd028 Docs: Correct @since tag for the class-wp-widget-area-customize-control.php file.
Per the documentation standards, the file header `@since` tag is supposed to specify when the file was introduced.

Follow-up to [35389].

See #51800.
Built from https://develop.svn.wordpress.org/trunk@49678


git-svn-id: http://core.svn.wordpress.org/trunk@49401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-22 15:12:03 +00:00
Andrew Ozz
991114fb57 Upgrade/Install: Replace the conditionals that check the AUTOMATIC_UPDATER_DISABLED constant and the automatic_updater_disabled filter in update-core.php with a call to WP_Automatic_Updater::is_disabled(). This prevents a PHP warning, fixes the logic, and considers wp_is_file_mod_allowed( 'automatic_updater' ) when determining the UI state.
Props jamesros161, pbiron, audrasjb, azaozz.
Fixes #51827.
Built from https://develop.svn.wordpress.org/trunk@49677


git-svn-id: http://core.svn.wordpress.org/trunk@49400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-22 13:03:06 +00:00
Sergey Biryukov
9150652fed Site Health: Check if $core_updates is an array before iterating on it.
This avoids a PHP warning if `get_core_updates()` returns `false`.

Props paulschreiber.
Fixes #51818.
Built from https://develop.svn.wordpress.org/trunk@49676


git-svn-id: http://core.svn.wordpress.org/trunk@49399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-21 14:39:03 +00:00
Sergey Biryukov
5ab5b3e73b Docs: Add missing @since tags for WP_Upgrader_Skin methods.
See #51800.
Built from https://develop.svn.wordpress.org/trunk@49675


git-svn-id: http://core.svn.wordpress.org/trunk@49398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-21 12:08:05 +00:00
ryelle
7ded4af960 Help/About: Clarify accessibility features.
* Captions are uploaded in the block editor, and not created in the editor.
* Avoid making an invalid claim of WCAG 2.1 conformance or trivialize the efforts still required to build an accessible and compliant site.

Follow-up to [49640].
Props joedolson.
See #51415.


Built from https://develop.svn.wordpress.org/trunk@49674


git-svn-id: http://core.svn.wordpress.org/trunk@49397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-21 00:13:07 +00:00
Sergey Biryukov
d86f6bde55 Docs: Correct $fire_after_hooks parameter name in @since tags.
Follow-up to [49172], [49173].

See #45114.
Built from https://develop.svn.wordpress.org/trunk@49673


git-svn-id: http://core.svn.wordpress.org/trunk@49396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-20 11:58:06 +00:00
John Blackbourn
35f6c356c1 Docs: Document parameters that accept an array of integers using typed array notation.
While many of these parameters also technically accept an array of numerical strings, they are all ultimately cast to an array of integers. Documenting them as such assists developers in understanding the expected types.

See #51800, #41756

Built from https://develop.svn.wordpress.org/trunk@49672


git-svn-id: http://core.svn.wordpress.org/trunk@49395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-19 18:24:09 +00:00
John Blackbourn
6e472178d1 Docs: Add missing @since tags.
See #51800

Built from https://develop.svn.wordpress.org/trunk@49671


git-svn-id: http://core.svn.wordpress.org/trunk@49394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-19 17:54:05 +00:00
John Blackbourn
792c53ac8c Docs: Clarify and standardise on terminology used for rewrite rule endpoint masks.
See #51800

Built from https://develop.svn.wordpress.org/trunk@49670


git-svn-id: http://core.svn.wordpress.org/trunk@49393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-19 16:15:08 +00:00
Sergey Biryukov
aab7112b09 Docs: Use more specific type in parameter descriptions for in_category() and is_object_in_term().
This better aligns with `is_category()` and other conditional tags and their `WP_Query` counterpart methods.

Follow-up to [47402].

Props princeahmed.
Fixes #51825.
Built from https://develop.svn.wordpress.org/trunk@49669


git-svn-id: http://core.svn.wordpress.org/trunk@49392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-19 15:20:05 +00:00
Sergey Biryukov
da6ab833d5 Coding Standards: Remove redundant isset() check in core_upgrade_preamble().
`isset()` can be safely used to check properties and subproperties of objects directly.

Follow-up to [49638].

See #51799.
Built from https://develop.svn.wordpress.org/trunk@49668


git-svn-id: http://core.svn.wordpress.org/trunk@49391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-19 12:05:06 +00:00
Sergey Biryukov
6cde96263b Help/About: Correct placeholder for the accessibility statement feature plugin link.
Add missing translator comment.

Props audrasjb.
See #51415.
Built from https://develop.svn.wordpress.org/trunk@49651


git-svn-id: http://core.svn.wordpress.org/trunk@49388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-18 15:51:04 +00:00
Sergey Biryukov
05125ed8bf Site Health: Add missing i18n for the App Passwords documentation link.
Follow-up to [49334].

Props tai.
Fixes #51815.
Built from https://develop.svn.wordpress.org/trunk@49650


git-svn-id: http://core.svn.wordpress.org/trunk@49387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-18 15:04:05 +00:00
Andrew Ozz
e261cf0d1e External Libraries: Update jQuery Migrate to 3.3.2.
Props mgol, azaozz.
Fixes #50564.
Built from https://develop.svn.wordpress.org/trunk@49649


git-svn-id: http://core.svn.wordpress.org/trunk@49386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-18 09:06:06 +00:00
Helen Hou-Sandí
7c5a072f38 Trunk is now really 5.7-alpha.
Built from https://develop.svn.wordpress.org/trunk@49645


git-svn-id: http://core.svn.wordpress.org/trunk@49383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 22:57:03 +00:00
Helen Hou-Sandí
a434baf9e8 Trunk is now 5.7-alpha.
Built from https://develop.svn.wordpress.org/trunk@49644


git-svn-id: http://core.svn.wordpress.org/trunk@49382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 22:52:03 +00:00
Helen Hou-Sandí
5ac21f5fbc Post WordPress 5.6 RC 1 version bump.
Built from https://develop.svn.wordpress.org/trunk@49642


git-svn-id: http://core.svn.wordpress.org/trunk@49380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 22:39:05 +00:00
Helen Hou-Sandí
c267ad2fde WordPress 5.6 RC 1.
Built from https://develop.svn.wordpress.org/trunk@49641


git-svn-id: http://core.svn.wordpress.org/trunk@49379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 22:01:02 +00:00
ryelle
6214f61cb1 Help/About: WordPress 5.6 About Page.
This change introduces the new About page for WordPress 5.6.

Props elmastudio, ryelle, melchoyce, karmatosed, webcommsat, marybaum, meher, OGlekler, lmurillom, vimes1984, sabrinazeidan, nalininonstopnewsuk, afshanadiya, michelleames, bmcdede, yvettesonneveld, sarahricker, isabel_brison, helen, hellofromtonya, poena, chanthaboune, cbringmann, joedolson, sabernhardt, garrett-eclipse, audrasjb, marks99.
See #51415.


Built from https://develop.svn.wordpress.org/trunk@49640


git-svn-id: http://core.svn.wordpress.org/trunk@49378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 21:34:04 +00:00
Sergey Biryukov
700c9455ab I18N: Avoid PHP notices for relative URLs in load_script_textdomain().
Props hellofromTonya, SeBsZ, archon810, nourma, justinahinon, SergeyBiryukov.
Fixes #49145.
Built from https://develop.svn.wordpress.org/trunk@49639


git-svn-id: http://core.svn.wordpress.org/trunk@49377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 20:52:09 +00:00
Helen Hou-Sandí
b456e9c9c8 Upgrade/Install: Consistent layout and accurate messages on the update screen.
* Clarifies that if you are on maintenance/security auto-updates that you are only on those and therefore there are more options available.
* Adds a message if a version control system has been detected, as automatic updates are disabled in that case.
* Ensures only one heading between `update available`, `you are on a dev version`, and `you are on latest` appears at any given time, falling back to `you are on latest` if something strange happens with the returned update data.
* Removes some older strings related to auto-updates, which greatly simplifies the above.
* Strips the `core-major-auto-updates-saved` query arg from the URL, as it is related to a dismissible notice.

Props audrasjb, pbiron, helen.
Fixes #51742.

Built from https://develop.svn.wordpress.org/trunk@49638


git-svn-id: http://core.svn.wordpress.org/trunk@49376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 20:28:04 +00:00
Sergey Biryukov
cce65c9baf Users: Use do_action_ref_array() for pre_get_users and pre_get_terms actions.
This brings some consistency with the other similar actions:

* `pre_get_comments`
* `pre_get_networks`
* `pre_get_posts`
* `pre_get_sites`
* `pre_user_query`

Follow-up to [29363] and [37572].

Props andy, adamsilverstein, hellofromTonya, desrosj, SergeyBiryukov.
Fixes #50961.
Built from https://develop.svn.wordpress.org/trunk@49637


git-svn-id: http://core.svn.wordpress.org/trunk@49375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 20:09:05 +00:00
desrosj
bcb9027236 Build/Test Tools: Update the package.json engines to point to the new LTS versions of Node/NPM.
Props mkaz, jorbin.
Fixes #51749.
Built from https://develop.svn.wordpress.org/trunk@49636


git-svn-id: http://core.svn.wordpress.org/trunk@49374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 19:52:00 +00:00
Sergey Biryukov
dfc3eeff10 General: Rename the wp_error_checked action to is_wp_error_instance for clarity.
Follow-up to [49022], [49023].

Props johnbillion, helen, johnjamesjacoby, Mte90, alexstandiford, hellofromTonya, jnylen0, SergeyBiryukov.
Fixes #40568.
Built from https://develop.svn.wordpress.org/trunk@49635


git-svn-id: http://core.svn.wordpress.org/trunk@49373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 19:21:05 +00:00
desrosj
50bf937ebb Build/Test Tools: Update several NPM dependencies.
These updates were applied when running `npm install`.

See #50769.
Built from https://develop.svn.wordpress.org/trunk@49634


git-svn-id: http://core.svn.wordpress.org/trunk@49372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 19:19:06 +00:00
desrosj
634e6b16c8 Twenty Twenty-One: Sync the latest changes for 5.6 RC1.
For a full list of changes since [49574-49577], see https://github.com/WordPress/twentytwentyone/compare/aa284fd...trunk.

Props poena, luminuu, kjellr, ryelle, aristath.
See #51526.
Built from https://develop.svn.wordpress.org/trunk@49633


git-svn-id: http://core.svn.wordpress.org/trunk@49371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 19:00:08 +00:00
Sergey Biryukov
cf75a715c4 App Passwords: Regenerate the .htaccess file to add a new rule.
Application Passwords introduced a new Rewrite Rule to handle the Authorization header on certain systems.

This bumps the database version and updates the file so the change is applied to sites upon upgrading to 5.6.

Follow-up to [49534].

Props pbiron, TimothyBlynJacobs, SergeyBiryukov.
Fixes #51723.
Built from https://develop.svn.wordpress.org/trunk@49632


git-svn-id: http://core.svn.wordpress.org/trunk@49370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 17:24:06 +00:00
Sergey Biryukov
f97647c207 Plugins: Make sure the HTML ID attributes for plugin checkboxes are unique.
Follow-up to [48374].

Props helen, sabernhardt, kishanjasani, mukesh27, hareesh-pillai.
Fixes #51256.
Built from https://develop.svn.wordpress.org/trunk@49631


git-svn-id: http://core.svn.wordpress.org/trunk@49369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 16:48:09 +00:00
Sergey Biryukov
7860b364fe Docs: Further remove tautology from comments in recurse_dirsize() tests.
Follow-up to [49212], [49616], [49628].

See #19879.
Built from https://develop.svn.wordpress.org/trunk@49630


git-svn-id: http://core.svn.wordpress.org/trunk@49368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 15:50:06 +00:00
Sergey Biryukov
5801fc9a93 Multisite: Rename the calculate_current_dirsize filter to pre_recurse_dirsize.
Set the default value to `false`. This brings some consistency with the `pre_get_space_used` filter.

Follow-up to [49212], [49616], [49628].

See #19879.
Built from https://develop.svn.wordpress.org/trunk@49629


git-svn-id: http://core.svn.wordpress.org/trunk@49367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 15:44:07 +00:00
Sergey Biryukov
e123448589 Docs: Adjust comments for recurse_dirsize() and related tests per the documentation standards.
Follow-up to [49212], [49616].

See #19879.
Built from https://develop.svn.wordpress.org/trunk@49628


git-svn-id: http://core.svn.wordpress.org/trunk@49366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 15:38:10 +00:00
Sergey Biryukov
f7d3a8b5c4 App Passwords: Add missing i18n for an error message.
Follow-up to [49617].

See #51513.
Built from https://develop.svn.wordpress.org/trunk@49627


git-svn-id: http://core.svn.wordpress.org/trunk@49365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 10:21:08 +00:00
Sergey Biryukov
1642f9bb1d Docs: Document the $args parameter of wp_oembed_get().
Link to `wp_oembed_get()` as the canonical source when documenting additional arguments in various `WP_oEmbed` methods.

Follow-up to [49620].

See #51269.
Built from https://develop.svn.wordpress.org/trunk@49626


git-svn-id: http://core.svn.wordpress.org/trunk@49364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 10:11:11 +00:00
noisysocks
9f065de733 Customize: Temporary fix for autosave restore notice not being removed
Fixes the "There is a more recent autosave of your changes" notice from not
being removed when the dismiss button is clicked.

The problem is caused by the notice being initialized twice: once by the
`common` script and then again by the `customize-controls` script.

This temporary fix prevents `customize-controls` from initializing a notice if
it has already been initialized.

A better fix would be to not initialize notices twice. This can be done by
removing `common` as a dependency of `updates` when `deprecateL10nObject` is
removed.

When this happens (est: 5.7), this temporary fix should be reverted.

Fixes #51425.
See #51317.
Props karthikbhatb, dlh, SergeyBiryukov.

Built from https://develop.svn.wordpress.org/trunk@49625


git-svn-id: http://core.svn.wordpress.org/trunk@49363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 04:45:11 +00:00
noisysocks
a3c8b3ddea Customize: Ensure multiple CSS classes are passed to nav_menu_link_attributes as an array
When multiple CSS classes are added to a menu item, the nav_menu_link_attributes
filter should be called with $item->classes set to an array of CSS class names.

When previewing in the Customizer, however, a single string was being passed to
$item->classes because WP_Customize_Nav_Menu_Item_Setting::preview() bypasses
wp_update_nav_menu_item() and instead uses filter_wp_get_nav_menu_items().

The fix is to make filter_wp_get_nav_menu_items() match what
wp_update_nav_menu_item() does and split the string into an array.

Fixes #43113.
Props dlh.

Built from https://develop.svn.wordpress.org/trunk@49624


git-svn-id: http://core.svn.wordpress.org/trunk@49362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 04:31:08 +00:00
noisysocks
fb2f5a743b Editor: Update WordPress packages for RC1
@wordpress/block-directory: 1.17.3 -> 1.17.4
@wordpress/block-library: 2.26.3 -> 2.26.4
@wordpress/edit-post: 3.25.3 -> 3.25.4

Fixes #51793.
Props isabel_brison.

Built from https://develop.svn.wordpress.org/trunk@49623


git-svn-id: http://core.svn.wordpress.org/trunk@49361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 04:13:29 +00:00
Peter Wilson
30b79ebd28 Permalinks: Prevent attachment pages 404ing following [49563].
This largely reverts [49563] due to attachment pages returning 404: File not found errors when they use the `inherit` status.

Permalink changes to attachment pages are retained when they are descendants of trashed or deleted posts.

Props Toro_Unit, helen, johnbillion, peterwilsoncc.
Fixes #51776.
See #5272.


Built from https://develop.svn.wordpress.org/trunk@49622


git-svn-id: http://core.svn.wordpress.org/trunk@49360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 03:29:12 +00:00
desrosj
03eba7beb2 Code Modernization: Only call libxml_disable_entity_loader() in PHP < 8.
This function has been deprecated in PHP 8.0 because in libxml 2.9.0, external entity loading is disabled by default, so this function is no longer needed to protect against XXE attacks.

This change fixes an instance of `libxml_disable_entity_loader()` within the getID3 library that has not yet been included in a tagged release for the library.

Props jrf, hellofromtonya.
Fixes #50898.
Built from https://develop.svn.wordpress.org/trunk@49621


git-svn-id: http://core.svn.wordpress.org/trunk@49359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 01:00:08 +00:00
Helen Hou-Sandí
85b28a939f Embeds: Document $args in wp_oembed_get().
Props hellofromTonya, audrasjb, SergeyBiryukov.
Fixes #51269.

Built from https://develop.svn.wordpress.org/trunk@49620


git-svn-id: http://core.svn.wordpress.org/trunk@49358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-16 23:13:08 +00:00
whyisjake
3c51950baf Feeds: Add an early exit when calling RSS functions directly.
While this file is depracated, it shouldn't throw errors when called directly.

Fixes #35835.

Props thib3113, dd32, TheGP, flymike, zodiac1978, williampatton.

Built from https://develop.svn.wordpress.org/trunk@49619


git-svn-id: http://core.svn.wordpress.org/trunk@49357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-16 22:52:05 +00:00
whyisjake
ec9434735a Build/Test Tools: Update several NPM dependencies.
These updates were applied by running `npm i`. These are changing some `http` links to `https`.

See #50769.

Built from https://develop.svn.wordpress.org/trunk@49618


git-svn-id: http://core.svn.wordpress.org/trunk@49356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-16 22:47:06 +00:00
TimothyBlynJacobs
d9b35c8e98 App Passwords: Unify availability language.
Previously App Passwords used a mix of "enabled" and "available". We've now standardized on using "available".

Additionally, we now use a 501 status code when indicating that App Passwords is not available.

Props SergeyBiryukov, ocean90, TimothyBlynJacobs.
Fixes #51513.

Built from https://develop.svn.wordpress.org/trunk@49617


git-svn-id: http://core.svn.wordpress.org/trunk@49355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-16 22:42:04 +00:00
Helen Hou-Sandí
aceaf33edd Multisite: More consistency for clean_dirsize_cache().
Props SergeyBiryukov.
Fixes #19879.

Built from https://develop.svn.wordpress.org/trunk@49616


git-svn-id: http://core.svn.wordpress.org/trunk@49354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-16 22:31:06 +00:00
Sergey Biryukov
7712866212 Script Loader: Correct version for jQuery Migrate.
Follow-up to [49338].

See #51621, #50564.
Built from https://develop.svn.wordpress.org/trunk@49615


git-svn-id: http://core.svn.wordpress.org/trunk@49353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-16 21:36:05 +00:00
Helen Hou-Sandí
14bd8cc469 Posts, Post Types: Go back to "Auto Draft" for CPTs without title support.
Reverts [49288] due to late point in 5.6 cycle and lack of update in Gutenberg package to account for the string change.
See #45516.

Built from https://develop.svn.wordpress.org/trunk@49614


git-svn-id: http://core.svn.wordpress.org/trunk@49352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-16 19:44:07 +00:00
Helen Hou-Sandí
ee48cca207 Media: Avoid fatal error in `wp_prepare_attachment_for_js().
In certain contexts, in particular on the front-end, `get_media_states()` is not availble.

Props rebasaurus.
Fixes #51791.

Built from https://develop.svn.wordpress.org/trunk@49613


git-svn-id: http://core.svn.wordpress.org/trunk@49351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-16 19:20:09 +00:00
Sergey Biryukov
801152b9d7 Docs: Fix typo in wp_get_object_terms filter DocBlock.
Follow-up to [49597].

See #50768.
Built from https://develop.svn.wordpress.org/trunk@49612


git-svn-id: http://core.svn.wordpress.org/trunk@49350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-16 17:28:08 +00:00
Sergey Biryukov
6a8f9bf499 Docs: Add missing full stop for a comment in create_initial_rest_routes().
Follow-up to [49154].

Props david.binda.
Fixes #51788.
Built from https://develop.svn.wordpress.org/trunk@49611


git-svn-id: http://core.svn.wordpress.org/trunk@49349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-16 16:48:12 +00:00
John Blackbourn
753ae723ad Docs: Corrections and improvements to inline docs relating to the REST API.
See #50768

Built from https://develop.svn.wordpress.org/trunk@49610


git-svn-id: http://core.svn.wordpress.org/trunk@49348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-16 11:04:12 +00:00
Sergey Biryukov
b51eeb4eef Docs: Drop src/ from pre_render_block duplicate hook reference.
Follow-up to [49608].

See #51612.
Built from https://develop.svn.wordpress.org/trunk@49609


git-svn-id: http://core.svn.wordpress.org/trunk@49347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-16 10:53:11 +00:00
noisysocks
341704d640 Editor: Move pre_render_block, render_block_data, render_block_context
Move the pre_render_block, render_block_data, and render_block_context
filters from render_block() to WP_Block. This ensures that they are
called for all blocks, including nested blocks, not just top-level
blocks.

Fixes #51612.
Props gaambo, gziolo, TimothyBlynJacobs.

Built from https://develop.svn.wordpress.org/trunk@49608


git-svn-id: http://core.svn.wordpress.org/trunk@49346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-16 00:47:11 +00:00
TimothyBlynJacobs
44125fc590 App Passwords: Include authorization rewrite rule in default multisite .htaccess
This rule was previously added to `WP_Rewrite`, but multisite uses a different .htaccess generation mechanism.

Props pbiron.
Fixes #51772.
See [49109].

Built from https://develop.svn.wordpress.org/trunk@49607


git-svn-id: http://core.svn.wordpress.org/trunk@49345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-15 17:46:06 +00:00
John Blackbourn
14d60739d1 Build/Test Tools: Misc test enhancements.
See #51344

Built from https://develop.svn.wordpress.org/trunk@49606


git-svn-id: http://core.svn.wordpress.org/trunk@49344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-15 17:19:10 +00:00
John Blackbourn
bd52453064 Built/Test Tools: Switch to a data provider for the default user role and capability tests.
This test previously performed 1,010 assertions, and a failure in any one would prevent the other assertions from running. Using a data provider means simultaneous failures will all be reported at once.

See #51344, #32394

Built from https://develop.svn.wordpress.org/trunk@49605


git-svn-id: http://core.svn.wordpress.org/trunk@49343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-15 14:59:06 +00:00
John Blackbourn
2062b81430 Build/Test Tools: Ensure user capability assertions are performed for all default roles.
The existing assertions were erroneously placed outside the iteration of all users, and therefore were only run against the last user in the list, which is the Subscriber role.

See #51344, #32394

Built from https://develop.svn.wordpress.org/trunk@49604


git-svn-id: http://core.svn.wordpress.org/trunk@49342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-15 14:19:08 +00:00
John Blackbourn
ffe8f1cba4 Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.
This brings consistency to this often-used method, and allows IDEs to provide help to developers when using its `$factory` parameter.

See #51344

Built from https://develop.svn.wordpress.org/trunk@49603


git-svn-id: http://core.svn.wordpress.org/trunk@49341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-15 14:01:06 +00:00
Sergey Biryukov
b618452411 Twenty Nineteen: Remove unnecessary references to some variables in twentynineteen_hsl_hex() before they are defined.
Props ankitmaru, sabernhardt.
Fixes #49052.
Built from https://develop.svn.wordpress.org/trunk@49602


git-svn-id: http://core.svn.wordpress.org/trunk@49340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-15 12:16:09 +00:00
John Blackbourn
1daf22cae6 Build/Test Tools: Improve the reliability of the test that ensures correct dependency order when inline scripts are used.
This test already ensures `WP_Scripts->do_concat` is true, therefore it has no dependency on `SCRIPT_DEBUG` being false. This means the test can run in an environment where the `.min` suffix is not used.

This change allows for the test to pass in this situation.

See #36392, #51734, #51344

Built from https://develop.svn.wordpress.org/trunk@49601


git-svn-id: http://core.svn.wordpress.org/trunk@49339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-14 17:22:05 +00:00
John Blackbourn
48f35e42fc Docs: For clarity, add some information about the return types of get_option().
Props ReneHermi, johannadevos

See #51278

Built from https://develop.svn.wordpress.org/trunk@49600


git-svn-id: http://core.svn.wordpress.org/trunk@49338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-14 17:02:05 +00:00
Sergey Biryukov
df2644a14a Docs: Add missing descriptions for _WP_List_Table_Compat methods.
Props johannadevos, SaeedFard, swissspidy, desrosj, SergeyBiryukov.
Fixes #46842.
Built from https://develop.svn.wordpress.org/trunk@49599


git-svn-id: http://core.svn.wordpress.org/trunk@49337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-14 16:54:08 +00:00
John Blackbourn
429079a9b2 Docs: Revert an accidental revert of this package name.
See #51414, #50768

Built from https://develop.svn.wordpress.org/trunk@49598


git-svn-id: http://core.svn.wordpress.org/trunk@49336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-14 16:40:07 +00:00
John Blackbourn
170ca32007 Docs: Various docblock corrections and improvements.
See #50768

Built from https://develop.svn.wordpress.org/trunk@49597


git-svn-id: http://core.svn.wordpress.org/trunk@49335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-14 16:35:06 +00:00
Sergey Biryukov
185607c417 Docs: Add missing descriptions for Automatic_Upgrader_Skin methods.
Props johannadevos, dilipbheda.
Fixes #44546.
Built from https://develop.svn.wordpress.org/trunk@49596


git-svn-id: http://core.svn.wordpress.org/trunk@49334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-14 16:23:10 +00:00
Sergey Biryukov
ec051cfb3e Docs: Clarify that get_pages() returns an array of pages, not an HTML list.
Props ben.meredith@gmail.com, ovenall, johannadevos.
Fixes #39049. See #51768.
Built from https://develop.svn.wordpress.org/trunk@49595


git-svn-id: http://core.svn.wordpress.org/trunk@49333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-14 15:01:13 +00:00
John Blackbourn
1260493569 Docs: Correct the Chocolatey package name for Node in the local environment setup instructions.
Props pbearne

See #51414

Built from https://develop.svn.wordpress.org/trunk@49594


git-svn-id: http://core.svn.wordpress.org/trunk@49332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-14 10:17:08 +00:00
Andrew Ozz
d817ad9b55 Upgrade/Install: Ensure the current user can update core when saving the auto-update options.
See #51742.
Built from https://develop.svn.wordpress.org/trunk@49593


git-svn-id: http://core.svn.wordpress.org/trunk@49331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-13 16:57:13 +00:00
Sergey Biryukov
0bc22bb1fc Upgrade/Install: Account for the automatic_updater_disabled filter in core auto-update settings UI.
Follow-up to [49587].

Props markparnell, audrasjb.
See #51742.
Built from https://develop.svn.wordpress.org/trunk@49592


git-svn-id: http://core.svn.wordpress.org/trunk@49330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-13 11:14:08 +00:00
Sergey Biryukov
d6a597efe2 I18N: Remove HTML tags from translatable strings on WordPress Updates screen.
Follow-up to [49587].

Props fierevere.
See #51742.
Built from https://develop.svn.wordpress.org/trunk@49591


git-svn-id: http://core.svn.wordpress.org/trunk@49329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-13 10:50:08 +00:00
Helen Hou-Sandí
845371edab Post-WordPress 5.6 Beta 4 bump.
Built from https://develop.svn.wordpress.org/trunk@49590


git-svn-id: http://core.svn.wordpress.org/trunk@49328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 23:45:10 +00:00
Helen Hou-Sandí
81659521ad WordPress 5.6 Beta 4, for real.
Built from https://develop.svn.wordpress.org/trunk@49589


git-svn-id: http://core.svn.wordpress.org/trunk@49327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 23:08:08 +00:00
Helen Hou-Sandí
16feb07916 WordPress 5.6 Beta 4.
Built from https://develop.svn.wordpress.org/trunk@49588


git-svn-id: http://core.svn.wordpress.org/trunk@49326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 23:02:09 +00:00
Helen Hou-Sandí
582ca50733 Upgrade/Install: Better UI for auto-update settings on update screen.
This adds clearer messages about what your current settings mean for updates, uses a more compact link-based action instead of a checkbox to change the setting, and respects constants and filters.

Props audrasjb, karmatosed, helen, azaozz, hedgefield, marybaum.
Fixes #51742.

Built from https://develop.svn.wordpress.org/trunk@49587


git-svn-id: http://core.svn.wordpress.org/trunk@49325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 22:37:10 +00:00
Sergey Biryukov
c5257328b7 Customize: Exclude widget ID attributes from search.
Having search terms match the ID attributes leads to confusing results, specifically when the admin interface is set to a language other than English.

Follow-up to [27650].

Props afercia, dlh, noisysocks.
Fixes #46456.
Built from https://develop.svn.wordpress.org/trunk@49586


git-svn-id: http://core.svn.wordpress.org/trunk@49324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 22:05:09 +00:00
Sergey Biryukov
7baab642c1 Bundled Themes: Add block-patterns tag to Twenty Nineteen and Twenty Twenty.
Follow-up to [49347], [49348].

See #51098, #51099.
Built from https://develop.svn.wordpress.org/trunk@49585


git-svn-id: http://core.svn.wordpress.org/trunk@49323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 21:56:12 +00:00
Sergey Biryukov
87fbad7286 Bundled Themes: Introduce block patterns for Twenty Seventeen.
Props melchoyce, kjellr, onemaggie, ryelle, beafialho, bridgetwillard, poena.
Fixes #51100.
Built from https://develop.svn.wordpress.org/trunk@49584


git-svn-id: http://core.svn.wordpress.org/trunk@49322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 21:22:12 +00:00
Sergey Biryukov
b6f30e3009 Bundled Themes: Introduce block patterns for Twenty Sixteen.
Props melchoyce, kjellr, onemaggie, ryelle, beafialho, bridgetwillard, poena, jffng.
Fixes #51101.
Built from https://develop.svn.wordpress.org/trunk@49583


git-svn-id: http://core.svn.wordpress.org/trunk@49321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 21:14:12 +00:00
Sergey Biryukov
f2364f163b Administration: Make sure auto-update counts properly update when bulk deleting plugins or themes.
Props pbiron, noisysocks, desrosj, audrasjb, hellofromTonya.
Fixes #50870.
Built from https://develop.svn.wordpress.org/trunk@49582


git-svn-id: http://core.svn.wordpress.org/trunk@49320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 20:42:10 +00:00
Helen Hou-Sandí
d5fd3bd452 Upgrade/Install: Enable all core autoupdates for new installs.
Likely needs more work for multisite installs.

Reference: https://make.wordpress.org/core/2020/11/10/wp5-6-auto-update-implementation-change/

Props audrasjb, azaozz.
See #51743.

Built from https://develop.svn.wordpress.org/trunk@49581


git-svn-id: http://core.svn.wordpress.org/trunk@49319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 20:22:09 +00:00
John Blackbourn
9115246f72 General: Convert wp_array_get() to a "private" function and add tests.
This function may be promoted in the future if it's deemed useful enough.

Props dd32, jorgefilipecosta, Hareesh Pillai

Fixes #51720

Built from https://develop.svn.wordpress.org/trunk@49580


git-svn-id: http://core.svn.wordpress.org/trunk@49318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 20:20:12 +00:00
Sergey Biryukov
1d738052b1 Editor: Update packages.
The following package versions were changed:

@wordpress/block-directory: 1.17.2 -> 1.17.3
@wordpress/block-editor: 5.1.2 -> 5.1.3
@wordpress/block-library: 2.26.2 -> 2.26.3
@wordpress/edit-post: 3.25.2 -> 3.25.3
@wordpress/editor: 9.24.2 -> 9.24.3
@wordpress/format-library: 1.25.2 -> 1.25.3
@wordpress/reusable-blocks: 1.0.2 -> 1.0.3

See https://github.com/WordPress/gutenberg/pull/26874 for the list of fixed bugs.

Props isabel_brison.
Fixes #51696.
Built from https://develop.svn.wordpress.org/trunk@49579


git-svn-id: http://core.svn.wordpress.org/trunk@49317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 19:36:36 +00:00
desrosj
6703f8efee Twenty Twenty-One: Use consistent casing in strings.
This converts strings using Title Case to sentence case, which is currently preferred for consistency (see discussions on #40244).

Also included is the replacement of an escaped apostrophe with `&#8217;`, which is also preferred per the Internationalization guidelines.

See #51526.
Built from https://develop.svn.wordpress.org/trunk@49578


git-svn-id: http://core.svn.wordpress.org/trunk@49316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 19:30:11 +00:00
desrosj
5de5b186f3 Twenty Twenty-One: Ignore the node_modules folder in SVN.
[49576] mistakenly partially reverted [49250].

See #51526.
Built from https://develop.svn.wordpress.org/trunk@49577


git-svn-id: http://core.svn.wordpress.org/trunk@49315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 19:07:10 +00:00
desrosj
d23292b3c0 Twenty Twenty-One: Ignore .css.map files.
These are generated when Sass is compiled, but should never be committed.

See #51526.
Built from https://develop.svn.wordpress.org/trunk@49576


git-svn-id: http://core.svn.wordpress.org/trunk@49314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 19:00:10 +00:00
desrosj
ee888ad547 Twenty Twenty-One: Convert inline ESLint comments to JSHint.
WordPress Core currently uses JSHint instead of ESlint.

See #51526.
Built from https://develop.svn.wordpress.org/trunk@49575


git-svn-id: http://core.svn.wordpress.org/trunk@49313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 18:48:08 +00:00
desrosj
967d29d83d Twenty Twenty-One: Merge the latest changes changes from GitHub for Beta 4.
In addition to syncing the latest changes, this change also merges the theme’s `.scss` files and other related build tool configurations required to compile the theme’s CSS.

This will allow development of the theme to continue on Trac after 5.6 is released and the GitHub repository is archived.

For a full list of changes since [], see e7d5991...aa284fd.

Props poena, luminuu kjellr, aristath, justinahinon.
See #51526.
Built from https://develop.svn.wordpress.org/trunk@49574


git-svn-id: http://core.svn.wordpress.org/trunk@49312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 18:36:15 +00:00
TimothyBlynJacobs
5ee48d6915 App Passwords: MOAR accessibility improvements.
Corrects the "Application Name" field's aria-describedby attribute and makes the description visible.

Props alexstine, SergeyBiryukov.
Fixes #51580.

Built from https://develop.svn.wordpress.org/trunk@49573


git-svn-id: http://core.svn.wordpress.org/trunk@49311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 18:14:08 +00:00
Sergey Biryukov
d772517fcc Database: Clean up the post_category column removed from DB schema for new installations in WordPress 2.8.
Its presence may conflict with `WP_Post::__get()`, which should generally fill the non-existent `post_category` property, but is not triggered if the column exists in the database.

Follow-up to [10895].

Props leogermani, davidbaumwald, hellofromTonya.
Fixes #51288.
Built from https://develop.svn.wordpress.org/trunk@49572


git-svn-id: http://core.svn.wordpress.org/trunk@49310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 17:55:11 +00:00
Sergey Biryukov
250d0660b2 Build/Test Tools: Only enforce PHP extension requirements when running core tests.
This allows other users of the WordPress unit test suite framework to run their own unit tests without needing the GD extension, which should only be a requirement if running core tests.

Follow-up to [49535].

Props jamescollins.
Fixes #50640.
Built from https://develop.svn.wordpress.org/trunk@49571


git-svn-id: http://core.svn.wordpress.org/trunk@49309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 17:25:13 +00:00
Sergey Biryukov
8e58e38ef9 Build/Tests Tools: Restore [49491], accidentally reverted in [49566].
See #39210.
Built from https://develop.svn.wordpress.org/trunk@49570


git-svn-id: http://core.svn.wordpress.org/trunk@49308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 17:15:08 +00:00
Sergey Biryukov
6ac50d705c Build/Tests Tools: Restore [49535], accidentally reverted in [49566].
See #39210.
Built from https://develop.svn.wordpress.org/trunk@49569


git-svn-id: http://core.svn.wordpress.org/trunk@49307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 17:08:11 +00:00
antpb
522a7a5d40 Media: Allow users to switch from media grid to list mode in media library.
Fixes issue where media modal would open when switching from grid to list mode.

Props mista-flo, mukesh27.

Fixes #51396.

Built from https://develop.svn.wordpress.org/trunk@49568


git-svn-id: http://core.svn.wordpress.org/trunk@49306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 15:46:07 +00:00
antpb
8efbef867c Media: Improve count in Media Library pagination.
Deleting all visible items on the last page of the media library previously left a blank page with no media items available. Using `wp_count_attachements` instead of `found_posts` solves the problem.

Props donsony, karmatosed, desrosj, mista-flo, justinahinon.

Fixes #39968.

Built from https://develop.svn.wordpress.org/trunk@49567


git-svn-id: http://core.svn.wordpress.org/trunk@49305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 15:40:09 +00:00
Dominik Schilling
abc9d961d5 I18N: Revert [49236] for now to investigate alternative implementations.
See #39210, #51678, #26511.
Built from https://develop.svn.wordpress.org/trunk@49566


git-svn-id: http://core.svn.wordpress.org/trunk@49304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 14:43:09 +00:00
Sergey Biryukov
4446e597a7 Feeds: Register transient feed cache handler using the recommended method for SimplePie 1.3 or later.
This fixes a "Non-static method cannot be called statically" fatal error when calling `fetch_feed()` on PHP 8.

Follow-up to [21644], [21652], [22366], [22599].

Props dd32, afragen, Senning, markoheijnen, ComputerGuru, useStrict, Ipstenu, nacin, l3rady, HoaSi, NathanAtmoz, fabifott, jfoulquier, thefarlilacfield, subscriptiongroup, rogerlos, Mte90, mopsyd, dossy, stulab, MadtownLems, roikles, justlevine, joostdevalk, OptimizingMatters, hellofromTonya, bph, ayeshrajans, SergeyBiryukov.
Fixes #29204.
Built from https://develop.svn.wordpress.org/trunk@49565


git-svn-id: http://core.svn.wordpress.org/trunk@49303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 14:36:10 +00:00
Sergey Biryukov
9c6f41419c Coding Standards: Pass an empty string instead of null as the $replacement parameter to _deprecated_file().
Follow-up to [48327].

See #50767.
Built from https://develop.svn.wordpress.org/trunk@49564


git-svn-id: http://core.svn.wordpress.org/trunk@49302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 11:17:07 +00:00