Scott Taylor
032ea5b132
Add access modifier to WP_Upgrader::clear_destination()
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32871
git-svn-id: http://core.svn.wordpress.org/trunk@32842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:53:25 +00:00
Scott Taylor
23e02fafce
Edit Post screen messages need to run preview URLs through the preview_post_link
filter.
...
Props pareshradadiya.
Fixes #32191 .
Built from https://develop.svn.wordpress.org/trunk@32870
git-svn-id: http://core.svn.wordpress.org/trunk@32841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:49:25 +00:00
Scott Taylor
86beb35f6d
Use <button>
instead of <a>
for non-link links in Quick Edit.
...
Props afercia.
Fixes #32213 .
Built from https://develop.svn.wordpress.org/trunk@32869
git-svn-id: http://core.svn.wordpress.org/trunk@32840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:42:27 +00:00
Scott Taylor
38037c8d62
Add get_language_attributes()
, which is then used by (...drum roll...) language_attributes()
.
...
Props johnbillion, posykrat, PeterRKnight.
Fixes #28180 .
Built from https://develop.svn.wordpress.org/trunk@32868
git-svn-id: http://core.svn.wordpress.org/trunk@32839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:36:28 +00:00
Scott Taylor
0c866cfa79
Check is_callable()
in do_shortcode_tag()
, not add_shortcode()
.
...
Add a `_doing_it_wrong()` in `do_shortcode_tag()` when `is_callable()` is `false`.
Props aaroncampbell.
See #32445 .
Built from https://develop.svn.wordpress.org/trunk@32867
git-svn-id: http://core.svn.wordpress.org/trunk@32838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:33:25 +00:00
Scott Taylor
ec6dfc7f2b
Add a filter in wp_get_attachment_image_src()
called attachment_image_src
.
...
Props eclev91, MikeHansenMe.
Fixes #32363 .
Built from https://develop.svn.wordpress.org/trunk@32866
git-svn-id: http://core.svn.wordpress.org/trunk@32837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:27:25 +00:00
Scott Taylor
cfe78e0e95
Cleanup (ms-)?admin-filters.php
...
Props johnjamesjacoby.
Fixes #32529 .
Built from https://develop.svn.wordpress.org/trunk@32865
git-svn-id: http://core.svn.wordpress.org/trunk@32836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:18:25 +00:00
Scott Taylor
5e1d796cae
Ugrade MediaElement to 2.17.0
...
Changelog: https://github.com/johndyer/mediaelement/compare/2.16.4...2.17.0
Fixes #32698 .
Built from https://develop.svn.wordpress.org/trunk@32864
git-svn-id: http://core.svn.wordpress.org/trunk@32835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 20:42:26 +00:00
Scott Taylor
777d3ba7e2
wptexturize()
improvements:
...
* Make sure that strings ending with a number and quotation mark get the proper smart quotes
* Introduce `wptexturize_primes()`, a logic tree to determine whether or not "7'." represents seven feet, then converts the special char into either a prime char or a closing quote char.
Adds unit tests.
Props miqrogroove.
Fixes #29256 .
Built from https://develop.svn.wordpress.org/trunk@32863
git-svn-id: http://core.svn.wordpress.org/trunk@32834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 20:06:25 +00:00
Scott Taylor
b212ee67e7
Media Library Bulk Select
button size should be smaller.
...
Props afercia.
Fixes #32325 .
Built from https://develop.svn.wordpress.org/trunk@32862
git-svn-id: http://core.svn.wordpress.org/trunk@32833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 18:56:27 +00:00
Scott Taylor
c5e088bf0f
Improve focus when previewing an oEmbed from Add Media Panel
...
Props afercia.
Fixes #28820 .
Built from https://develop.svn.wordpress.org/trunk@32861
git-svn-id: http://core.svn.wordpress.org/trunk@32832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 18:49:27 +00:00
Scott Taylor
32dabc1f90
Don't strip \0
(backslash+zero) from post content for users without "unfiltered_html"
...
Adds unit tests.
Props miqrogroove.
Fixes #28699 .
Built from https://develop.svn.wordpress.org/trunk@32860
git-svn-id: http://core.svn.wordpress.org/trunk@32831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 18:47:27 +00:00
Dominik Schilling
a28586a6d7
Customizer: Improve accessibility of the toggle button in the available menu items panel.
...
Prevents focus lost in Safari because the button was "invisible" until it got focused.
fixes #32709 .
Built from https://develop.svn.wordpress.org/trunk@32859
git-svn-id: http://core.svn.wordpress.org/trunk@32830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 17:24:24 +00:00
Konstantin Obenland
898bb2ed34
Remove allowed tags from comment form.
...
It can be confusing to users and for most it is not relevant.
Commenters comfortable with HTML will know which tags are likely
to be accepted.
Props krogsgard, rachelbaker.
Fixes #30157 .
Built from https://develop.svn.wordpress.org/trunk@32858
git-svn-id: http://core.svn.wordpress.org/trunk@32829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 14:15:26 +00:00
Konstantin Obenland
4e7c057a5a
Check that current changes can be lost before editing another comment.
...
When replying to or editing a comment, double-clicking another comment will
open it in quick edit and changes to the current comment are lost.
Props pareshradadiya, chriscct7.
Fixes #21845 .
Built from https://develop.svn.wordpress.org/trunk@32857
git-svn-id: http://core.svn.wordpress.org/trunk@32828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 13:48:25 +00:00
Ella Iseulde Van Dorpe
fd95002b2a
Editor: restructure word count
...
* The WordCounter should only do one thing: count words. This makes it also easier to test.
* Add some really basic unit tests.
* Instead of only refreshing the count on enter and delete, refresh the count when the user stops typing. Also look at paste and content changes in TinyMCE.
* Use `match` instead of `replace` when it is appropriate.
* More readable code.
See #30966 . Fixes #26620 .
Built from https://develop.svn.wordpress.org/trunk@32856
git-svn-id: http://core.svn.wordpress.org/trunk@32827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 10:35:26 +00:00
Konstantin Obenland
50e32a1969
Keep WP_Customize_Nav_Menus_Panel
with other panels rather than controls.
...
Accidentally merged into the wrong file in [32806].
H/t celloexpressions for noticing.
See https://wordpress.slack.com/archives/core-customize/p1434696254000258 .
See #32576 .
Built from https://develop.svn.wordpress.org/trunk@32855
git-svn-id: http://core.svn.wordpress.org/trunk@32826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 08:37:27 +00:00
Dion Hulse
8593dc3172
When updating plugins/themes verify that the files to be deleted can be modified before starting the deletion process.
...
This will avoid partially deleting an item during update which has inconsistent permissions.
This change only affects those using the direct & ssh transports as FTP's is_writable() currently always returns `true`.
Fixes #30921
Built from https://develop.svn.wordpress.org/trunk@32854
git-svn-id: http://core.svn.wordpress.org/trunk@32825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 03:49:25 +00:00
Dion Hulse
a21f890abb
Remove a redundant index drop, it'll be dropped and re-created a few lines further down.
...
Fixes a warning during updating from 4.0 or earlier.
Fixes #31388 for trunk
Built from https://develop.svn.wordpress.org/trunk@32852
git-svn-id: http://core.svn.wordpress.org/trunk@32823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 03:18:26 +00:00
Andrew Ozz
503b80be0b
Fix using htmlspecialchars()
whit the $double_encode
parameter. PHP < 5.4 doesn't validate the entities.
...
Props miqrogroove. Fixes #17780 .
Built from https://develop.svn.wordpress.org/trunk@32851
git-svn-id: http://core.svn.wordpress.org/trunk@32822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 01:53:26 +00:00
Scott Taylor
d8c93a081d
Since PHP 5.2.3, the htmlspecialchars()
function has an optional $double_encode
parameter, which we can now use. This will save us a few expensive kses/html decoding calls.
...
Adds unit tests.
Props miqrogroove.
Fixes #17780 .
Built from https://develop.svn.wordpress.org/trunk@32850
git-svn-id: http://core.svn.wordpress.org/trunk@32821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 22:00:26 +00:00
John Blackbourn
f632756f16
Correct the docs for the post_type_labels_{$post_type}
filter.
...
Fixes #32707
Props dlh
Built from https://develop.svn.wordpress.org/trunk@32849
git-svn-id: http://core.svn.wordpress.org/trunk@32820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 21:33:27 +00:00
Dominik Schilling
f5fa907f77
Customizer: Improve accessibility of Add Menu Items button and its panel.
...
props afercia, ocean90.
fixes #32682 .
Built from https://develop.svn.wordpress.org/trunk@32848
git-svn-id: http://core.svn.wordpress.org/trunk@32819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 20:52:24 +00:00
Dominik Schilling
f39edce68d
Autoprefixer for [32844].
...
Built from https://develop.svn.wordpress.org/trunk@32847
git-svn-id: http://core.svn.wordpress.org/trunk@32818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 20:49:26 +00:00
Aaron Jorbin
4b7ce555d0
Add singular.php to template hierarchy
...
Singular is the only template context conditional that lacks a corresponding template. This allows some themes to simplify.
Fixes #22314 .
Props chipbennett.
Built from https://develop.svn.wordpress.org/trunk@32846
git-svn-id: http://core.svn.wordpress.org/trunk@32817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 19:01:26 +00:00
Scott Taylor
09c4444150
Make sure that all Gravatars are generated by get_avatar()
or at least run through apply_filters( 'get_avatar', $avatar )
for the sake of extensibility.
...
Props miqrogroove, GlennM, SergeyBiryukov.
Fixes #22650 .
Built from https://develop.svn.wordpress.org/trunk@32845
git-svn-id: http://core.svn.wordpress.org/trunk@32816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 18:36:25 +00:00
Konstantin Obenland
c1a9c4b7b8
Semanticize Help and Screen Options toggle.
...
Links used as UI controls that are not real links but act as buttons, should be buttons.
Props afercia.
Fixes #32494 .
Built from https://develop.svn.wordpress.org/trunk@32844
git-svn-id: http://core.svn.wordpress.org/trunk@32815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 16:36:25 +00:00
Konstantin Obenland
81df9bffc5
Use https for Google API external libraries.
...
Google recommends it and users are more likely to have the https version cached in their browser already.
Props rommelxcastro.
Fixes #32552 .
Built from https://develop.svn.wordpress.org/trunk@32843
git-svn-id: http://core.svn.wordpress.org/trunk@32814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 15:51:26 +00:00
Konstantin Obenland
d872f38c31
Show the posts meta box by default in Appearance > Menus.
...
Lessens user confusion and the likelyhood of misusing custom links
to add menu items for posts.
Props bcole808.
Fixes #32440 .
Built from https://develop.svn.wordpress.org/trunk@32842
git-svn-id: http://core.svn.wordpress.org/trunk@32813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 15:04:26 +00:00
Konstantin Obenland
f7f14ae558
More consistent spacing around the excerpt textarea.
...
Props paulwilde.
Fixes #32242 .
Built from https://develop.svn.wordpress.org/trunk@32841
git-svn-id: http://core.svn.wordpress.org/trunk@32812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 14:19:25 +00:00
Boone Gorges
dd3b146546
Use assertFalse()
rather than assertNull()
in Tests_WP_Customize_Setting::test_is_current_blog_previewed()
.
...
`is_current_blog_previewed()` returns a boolean.
See #31428 .
Built from https://develop.svn.wordpress.org/trunk@32840
git-svn-id: http://core.svn.wordpress.org/trunk@32811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 14:08:25 +00:00
Boone Gorges
92123c15bf
Make sure $_SERVER['SERVER_NAME']
is set whenever wp_mail()
is called in PHPUnit tests.
...
This eliminates PHP notices when `wp_mail()` needs to determine its own From header.
See [25381] for a previous fix, which focused only on the mail-specific tests.
Fixes #32702 .
Built from https://develop.svn.wordpress.org/trunk@32839
git-svn-id: http://core.svn.wordpress.org/trunk@32810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 13:53:25 +00:00
Boone Gorges
2e5e0bdc78
When updating a user, only send email-change notification if email address is passed.
...
The notification, introduced in [32380], was firing incorrectly (and throwing
a PHP notice) when `wp_update_user()` was called without including 'user_email'
in the update data.
Props imath.
Fixes #32684 . See #32430 .
Built from https://develop.svn.wordpress.org/trunk@32838
git-svn-id: http://core.svn.wordpress.org/trunk@32809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 13:30:26 +00:00
Boone Gorges
6105fca015
Add filters to wp_unique_term_slug()
.
...
This changeset adds two new filters:
* 'wp_unique_term_slug_is_bad_slug' lets developers control whether a test slug needs to be made unique, before the queries required to build a suffix are performed.
* 'wp_unique_term_slug' filters the output of the function.
These changes introduce parity with the filters in `wp_unique_post_slug()`.
Props coffee2code, bolo1988, boonebgorges.
Fixes #20783 .
Built from https://develop.svn.wordpress.org/trunk@32837
git-svn-id: http://core.svn.wordpress.org/trunk@32808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 13:20:26 +00:00
Ella Iseulde Van Dorpe
ecec2b61cf
TinyMCE: wptextpattern: escape should undo
...
Props azaozz.
See #31441 .
Built from https://develop.svn.wordpress.org/trunk@32836
git-svn-id: http://core.svn.wordpress.org/trunk@32807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 12:59:28 +00:00
Konstantin Obenland
437b1c2b6a
Revert [32834].
...
It's not ready yet and was a product of misusing vim.
See #30729 .
Built from https://develop.svn.wordpress.org/trunk@32835
git-svn-id: http://core.svn.wordpress.org/trunk@32806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 12:27:25 +00:00
Konstantin Obenland
598f4cc4ca
Emphasise previewing new themes
...
Built from https://develop.svn.wordpress.org/trunk@32834
git-svn-id: http://core.svn.wordpress.org/trunk@32805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 12:24:27 +00:00
Konstantin Obenland
c9e1e2be9b
Make posts in the 'Most recent' tab of post type meta boxes filterable.
...
Provides parity with the 'View All' tab of post type meta boxes in Appearance > Menus.
Props jpyper, chriscct7.
Fixes #19365 .
Built from https://develop.svn.wordpress.org/trunk@32833
git-svn-id: http://core.svn.wordpress.org/trunk@32804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 11:35:28 +00:00
Ella Iseulde Van Dorpe
8b6ff40038
TinyMCE: wptextpattern: fix issue that removes content
...
* If the resulting text node is empty, don't remove all the content from the paragraph.
* If there's an empty text node at the start of the paragraph, ignore it and consider the next node to be the start.
See #31441 .
Built from https://develop.svn.wordpress.org/trunk@32832
git-svn-id: http://core.svn.wordpress.org/trunk@32803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 11:34:25 +00:00
Ella Iseulde Van Dorpe
1c586b9390
TinyMCE: show inline toolbar after scroll/resize
...
Also:
* Reduce the amount of callbacks.
* Move everything under `preinit` (but prepend to the callback). The API shouldn't be availbale earlier, and some UI is not available yet, neither is `editor.dom`.
* Hide the toolbar if the target is out of view.
See #32604 .
Built from https://develop.svn.wordpress.org/trunk@32831
git-svn-id: http://core.svn.wordpress.org/trunk@32802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 11:10:25 +00:00
Konstantin Obenland
326c106159
Recommend a user updates keys/salts in maint/repair.php
.
...
Since they are already going into `wp-config.php`, we should also encourage
them to update their unique phrases for keys and salts, assuming they do not
have a complete set of 8 unique ones already.
Props nacin, chriscct7.
Fixes #20779 .
Built from https://develop.svn.wordpress.org/trunk@32830
git-svn-id: http://core.svn.wordpress.org/trunk@32801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 11:07:25 +00:00
John Blackbourn
768d8507e5
Correct a typo in the inline docs for add_action()
.
...
Props nabil_kadimi, swissspidy
Fixes #32697
Built from https://develop.svn.wordpress.org/trunk@32829
git-svn-id: http://core.svn.wordpress.org/trunk@32800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 08:37:25 +00:00
Andrew Ozz
bc2630e099
Press This: Check the embeds list against all of the oembed providers.
...
Props stephdau. Fixes #32069 .
Built from https://develop.svn.wordpress.org/trunk@32828
git-svn-id: http://core.svn.wordpress.org/trunk@32799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 00:12:26 +00:00
Andrew Ozz
b77a3a33f5
Press This: show error message when the user is attempting to add a category that already exists.
...
Fixes #32339 .
Built from https://develop.svn.wordpress.org/trunk@32827
git-svn-id: http://core.svn.wordpress.org/trunk@32798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 23:13:26 +00:00
John Blackbourn
b14c6bea0b
Correct a unit test name.
...
See #21212
Built from https://develop.svn.wordpress.org/trunk@32826
git-svn-id: http://core.svn.wordpress.org/trunk@32797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 23:10:25 +00:00
Dominik Schilling
6e44f060ee
Customizer: Remove an overflow: hidden
declaration to prevent cutting off the left and right edge focus style of the "Add a Menu" input field.
...
props paulwilde.
fixes #32680 .
Built from https://develop.svn.wordpress.org/trunk@32825
git-svn-id: http://core.svn.wordpress.org/trunk@32796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 21:43:26 +00:00
Dominik Schilling
5864a7ad44
Customizer: Fix keyboard events for the menu items search field.
...
Replace the `change` event with `keyup`, see https://core.trac.wordpress.org/ticket/26600#comment:59 for background.
props tywayne.
fixes #32677 .
Built from https://develop.svn.wordpress.org/trunk@32824
git-svn-id: http://core.svn.wordpress.org/trunk@32795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 21:37:27 +00:00
Dominik Schilling
504db9233b
Customizer: Revert the blue on hover color which was introduced in [32649].
...
Blue is meant to be the primary action which isn't the case in this context. Colors need to be revised in #29158 .
see #31336 .
Built from https://develop.svn.wordpress.org/trunk@32823
git-svn-id: http://core.svn.wordpress.org/trunk@32794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 21:07:27 +00:00
Dominik Schilling
2d2445516c
Customizer: Decode HTML entities of panel/section titles.
...
Titles are now passed into Underscore templates but HTML-escaped, see #30737 .
fixes #32670 .
Built from https://develop.svn.wordpress.org/trunk@32822
git-svn-id: http://core.svn.wordpress.org/trunk@32793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 19:48:25 +00:00
Dominik Schilling
a1f7f4fe17
Customizer: Replace usage of calc()
with box-sizing: border-box
.
...
IE8 doesn't support `calc()`.
props afercia.
see #31336 .
fixes #32664 .
Built from https://develop.svn.wordpress.org/trunk@32821
git-svn-id: http://core.svn.wordpress.org/trunk@32792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 19:35:28 +00:00