Commit Graph

21004 Commits

Author SHA1 Message Date
Andrew Nacin
51f2e14b46 Use a variable that is set a few lines up. $post_id is set only in post.php, not post-new.php. fixes #21092.
git-svn-id: http://core.svn.wordpress.org/trunk@22742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 09:35:23 +00:00
Daryl Koopersmith
a763641235 Media: Remove debug cruft. props ocean90. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 09:28:58 +00:00
Bot (Assets)
76d4e0c954 Compress scripts/styles: 3.5-beta3-22740.
git-svn-id: http://core.svn.wordpress.org/trunk@22740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 08:58:30 +00:00
Daryl Koopersmith
693404f946 Media: Ensure icons stay within the bounds of their surrounding view. fixes #22522, see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 08:44:22 +00:00
Daryl Koopersmith
46bc46d88a Media: Dropping images on the edit gallery view will automatically add those images to the gallery. fixes #22521, see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 08:17:45 +00:00
Daryl Koopersmith
c717bb47e2 Media: Prevent type and search attachments filters from short circuiting.
Moves the reference to the source collection out of the props model. If it was translated over to a query (which was potentially possible) which then fired an ajax request, jQuery would attempt to serialize an object recursively, which caused an infinite loop and much sadness for my browser.

see #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 08:09:28 +00:00
Mark Jaquith
4fcb87234b Remove trailing slashes from UPLOADS before trying a str_replace() in wp_upload_dir(). props jbrinley. fixes #22469
* In 3.4.x, both $url and UPLOADS had trailing slashes
* Due to refactoring, $url is no longer expected to have a trailing slash
* Because of the mismatch, the str_replace() was not working, resulting in an incorrectly verbose upload dir URL

git-svn-id: http://core.svn.wordpress.org/trunk@22736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 07:08:38 +00:00
Andrew Nacin
418c9985f7 Media: For pages, use 'Insert into page' rather than 'Insert into post'.
Custom post types can use the media_view_strings filter. No new post type "labels" for now.

see #22712. see #21092 (and #19696).



git-svn-id: http://core.svn.wordpress.org/trunk@22735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 23:22:03 +00:00
Bot (Assets)
6764610cbb Compress scripts/styles: 3.5-beta3-22734.
git-svn-id: http://core.svn.wordpress.org/trunk@22734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 22:58:28 +00:00
Daryl Koopersmith
ae52867831 Media: Set a max width on select elements in the sidebar. fixes #22517, see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 22:51:35 +00:00
Andrew Nacin
0b8e9af39a Color picker: Instant feedback when typing a color. Strengthens alt + arrows for moving around the palette. props mattwiebe. fixes #22475. fixes #22388.
git-svn-id: http://core.svn.wordpress.org/trunk@22732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 22:02:09 +00:00
Andrew Nacin
e9f355e623 Customizer: Let return/enter fire click events for dropdowns and links. Remove errant focus event. Re-add box shadow and border for the overlay header. props lessbloat. see #21283.
git-svn-id: http://core.svn.wordpress.org/trunk@22731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 21:25:54 +00:00
Andrew Ozz
769e1236af Skip To links: visually hide by only setting top: -1000em; (this should make them work well in all screen readers), fixes #21312
git-svn-id: http://core.svn.wordpress.org/trunk@22730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 21:14:49 +00:00
Bot (Assets)
4d00db15b4 Compress scripts/styles: 3.5-beta3-22729.
git-svn-id: http://core.svn.wordpress.org/trunk@22729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 20:58:28 +00:00
Andrew Ozz
cddc116653 Toolbar: sync jQuery and non-jQuery JS behaviour when there's a hash in the url, props tlovett1, fixes #22520
git-svn-id: http://core.svn.wordpress.org/trunk@22728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 20:45:03 +00:00
Andrew Nacin
0656bbd3ab Use standard link colors with the skip links. see #21310.
git-svn-id: http://core.svn.wordpress.org/trunk@22727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 20:25:54 +00:00
Andrew Ozz
32ef39f0f6 Skip links: simplified look with more contrast, props sabreuse, fixes #21310
git-svn-id: http://core.svn.wordpress.org/trunk@22726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 19:58:47 +00:00
Andrew Ozz
0e38402629 Don't load autosave.js on the attachment editing screen, add simple AYS on unload if there are changes, props helenyhou, fixes #22491
git-svn-id: http://core.svn.wordpress.org/trunk@22725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 19:46:38 +00:00
Bot (Assets)
0bc99fe9f5 Compress scripts/styles: 3.5-beta3-22724.
git-svn-id: http://core.svn.wordpress.org/trunk@22724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 18:58:31 +00:00
Andrew Nacin
3da5e3a7fc Fix up the 'Attach' dialog on upload.php.
We are de-emphasising attaching (see [22630]) but this is existing
core functionality and will remain for now. This commit just cleans
it up a bit so as to be less embarrassing.

props lessbloat, helenyhou.
fixes #20164.



git-svn-id: http://core.svn.wordpress.org/trunk@22723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 18:50:15 +00:00
Ryan Boren
a2edda4b6a Don't bail from get_the_terms() if the post type is not registed for the taxonomy. This can break back compat when add_post_type_support( 'page', 'post-formats' ) is called but register_taxonomy_for_object_type( 'postr_-format', 'page' ) is not.
Props SergeyBiryukov
fixes #22473


git-svn-id: http://core.svn.wordpress.org/trunk@22722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 18:31:06 +00:00
Andrew Nacin
d6c85b1373 IE RTL fixes for .screen-reader-text. props lessbloat. see #22467.
git-svn-id: http://core.svn.wordpress.org/trunk@22721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 18:26:32 +00:00
Andrew Nacin
e11afb7c07 RTL media-views fixes. props ocean90. fixes #22453.
git-svn-id: http://core.svn.wordpress.org/trunk@22720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 18:22:19 +00:00
Andrew Nacin
7e0061375a No-JS fixes.
* Hide QuickPress.
 * Hide the gap between the title and content editor.
 * Hide 'select all' checkboxes in list tables.
 * Hide a non-functioning link in the custom fields metabox.
 * Hide non-functioning buttons in the featured image box (same as in 3.4).
 * RTL and miscellany.

props TobiasBg, lessbloat, ocean90. fixes #22456.



git-svn-id: http://core.svn.wordpress.org/trunk@22719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 18:20:14 +00:00
Andrew Nacin
fa10ccba23 Account for taxonomies tied to specific kinds of attachments when setting up post types for a taxonomy query.
props jondavidjohn. see #21290.



git-svn-id: http://core.svn.wordpress.org/trunk@22718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 17:33:21 +00:00
Bot (Assets)
530d5248f7 Compress scripts/styles: 3.5-beta3-22717.
git-svn-id: http://core.svn.wordpress.org/trunk@22717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 14:58:32 +00:00
Daryl Koopersmith
d63026f2ba Media: Maintain event bindings in the main embed view. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 14:44:23 +00:00
Daryl Koopersmith
00377a42f4 Media: Remove default gallery shortcode attributes when generating shortcode output. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 14:38:20 +00:00
Daryl Koopersmith
3f630bf0fa Media: Correctly fetch the default post ID when editing a gallery. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 14:33:48 +00:00
Daryl Koopersmith
e25565f4b7 Media: Allow all galleries to be sortable. fixes #22488, see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 14:04:59 +00:00
Daryl Koopersmith
6fb316b1fb Media: Add filters to the media library. fixes #22514, see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 13:49:35 +00:00
Bot (Assets)
7f377032aa Compress scripts/styles: 3.5-beta3-22711.
git-svn-id: http://core.svn.wordpress.org/trunk@22711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 12:58:29 +00:00
Daryl Koopersmith
9350f67e28 Media: Refresh the attachment display settings when the active attachment finishes uploading. fixes #22452, see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 11:57:08 +00:00
Daryl Koopersmith
fd78be75d9 Media Uploader: Change an uploaded attachment's 'updating' key with the rest of the returned attributes to allow events bound to 'change:updating' to access the new properties. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 11:52:08 +00:00
Daryl Koopersmith
31c525b289 Media: Remove dead dropdown code from button view. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 11:29:00 +00:00
Daryl Koopersmith
5a0f702f29 Buttons: Remove unused button arrows and dropdowns. see #21598, #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 11:26:26 +00:00
Daryl Koopersmith
220a5175d5 Media: Attachment checkboxes now function as such. fixes #22462, see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 11:10:04 +00:00
Bot (Assets)
c2cec9c4f2 Compress scripts/styles: 3.5-beta3-22705.
git-svn-id: http://core.svn.wordpress.org/trunk@22705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 04:58:34 +00:00
Daryl Koopersmith
1d8c49a48c Buttons: Ensure correct disabled submit button state in iOS. props johnbillion, fixes #22490.
git-svn-id: http://core.svn.wordpress.org/trunk@22704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 03:20:17 +00:00
Daryl Koopersmith
1bafce0dbb Media: Allow textareas to be vertically resized. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 02:59:31 +00:00
Andrew Nacin
3ac8cab666 Add media_view_settings and media_view_strings hooks. fixes #21092 for 3.5. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 02:58:33 +00:00
Bot (Assets)
38b7b820aa Compress scripts/styles: 3.5-beta3-22701.
git-svn-id: http://core.svn.wordpress.org/trunk@22701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 02:58:28 +00:00
Daryl Koopersmith
b75ec467b2 Media: Whoops. Remove error_log. see [22699], #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 02:40:31 +00:00
Daryl Koopersmith
b1f720c616 Media: Improve media buttons on the front end.
* Use a less specific selector (the body, actually) to delegate opening the media dialog.
* Allow the editor ID to be the empty string so the `media_buttons` action can be called without arguments.

see #22284, #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 02:35:30 +00:00
Andrew Nacin
ded6e7ae57 Fix HiDPI pointer arrows used in the feature pointers. props lessbloat. fixes #22510.
git-svn-id: http://core.svn.wordpress.org/trunk@22698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 02:09:37 +00:00
Andrew Nacin
cb9485a772 Color Picker keyboard accessibility. So awesome. props lessbloat, mattwiebe. see #22475.
git-svn-id: http://core.svn.wordpress.org/trunk@22697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 02:02:07 +00:00
Andrew Nacin
1d7a837f38 Welcome panel IE fixes. props SergeyBiryukov, see #19687.
git-svn-id: http://core.svn.wordpress.org/trunk@22696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 01:56:45 +00:00
Andrew Nacin
83eeb80dfb Custom Header: Remove Farbtastic-era "Reset Text Color" button. Show default color when JS is disabled. props DrewAPicture. fixes #22461.
git-svn-id: http://core.svn.wordpress.org/trunk@22695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 01:53:59 +00:00
Daryl Koopersmith
d4744fda0a Media: Prevent undefined errors when media scripts are enqueued outside of wp_enqueue_media(). fixes #22495, see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 01:48:37 +00:00
Bot (Assets)
ef6ff8b4a8 Compress scripts/styles: 3.5-beta3-22693.
git-svn-id: http://core.svn.wordpress.org/trunk@22693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 00:58:32 +00:00