Sergey Biryukov
7932193708
Coding Standards: Use strict comparison where static strings are involved.
...
This reduces the number of `WordPress.PHP.StrictComparisons.LooseComparison` issues in half, from 1897 to 890.
Includes minor code layout fixes for better readability.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47808
git-svn-id: http://core.svn.wordpress.org/trunk@47584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 18:42:12 +00:00
Sergey Biryukov
38676936ba
Coding Standards: Use strict type check for in_array()
and array_search()
where strings are involved.
...
This reduces the number of `WordPress.PHP.StrictInArray.MissingTrueStrict` issues from 486 to 50.
Includes minor code layout fixes for better readability.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47550
git-svn-id: http://core.svn.wordpress.org/trunk@47325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-05 03:02:11 +00:00
Sergey Biryukov
001ffe81fb
Docs: Improve inline comments per the documentation standards.
...
Includes minor code layout fixes for better readability.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47122
git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
Sergey Biryukov
e199663322
I18N: Capitalize translator comments consistently, add trailing punctuation.
...
Includes minor code layout fixes.
See #44360 .
Built from https://develop.svn.wordpress.org/trunk@45932
git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-03 00:41:05 +00:00
Gary Pendergast
0d23be600e
Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments
violations in the default themes.
...
See #47632
Built from https://develop.svn.wordpress.org/trunk@45581
git-svn-id: http://core.svn.wordpress.org/trunk@45392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 08:23:57 +00:00
Adam Silverstein
18ccaf962e
Bundled Theme: add a wp_body_open
shim for older WordPress versions.
...
WordPress 5.2 adds the `wp_body_open()` function, and the default themes make use of it. This patch adds a shim for `wp_body_open` to bundled themes so this function will also work in older versions of WordPress.
Props lgedeon, johnbillion, timph, ramiy, pento.
Fixes #46679 .
Built from https://develop.svn.wordpress.org/trunk@45256
git-svn-id: http://core.svn.wordpress.org/trunk@45065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-23 13:04:56 +00:00
Gary Pendergast
7a617078fa
Coding Standards: Upgrade WPCS to 1.2.1.
...
This upgrade fixes quite a few false positives, as well as auto-fixing some indenting issues.
Fixes #45956 .
Built from https://develop.svn.wordpress.org/trunk@44574
git-svn-id: http://core.svn.wordpress.org/trunk@44405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 06:41:52 +00:00
Gary Pendergast
56c162fbc9
Coding Standards: Upgrade WPCS to 1.0.0
...
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.
This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script.
- Auto-fixable coding standards issues will now cause Travis failures.
Fixes #44600 .
Built from https://develop.svn.wordpress.org/trunk@43571
git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast
aaf99e6913
Code is Poetry.
...
WordPress' code just... wasn't.
This is now dealt with.
Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057 .
Built from https://develop.svn.wordpress.org/trunk@42343
git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Sergey Biryukov
203b275658
Bundled Themes: Change tag cloud format to a list (<ul>
) for better semantics and accessibility.
...
List markup allows screen reader users to know in advance how many tags are within the list.
Props xkon, davidakennedy.
Fixes #40138 .
Built from https://develop.svn.wordpress.org/trunk@41756
git-svn-id: http://core.svn.wordpress.org/trunk@41590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-04 23:53:47 +00:00
David A. Kennedy
ca0274c2ce
Bundled Themes: Allow category display in post preview even when only one category
...
The category is not shown in the preview. And because of how `themename_categorized_blog()` function in each theme returns false for 1 or fewer categories, and in this case it won't show the new category.
The patch uses `is_preview()` to fix that in Twenty Fourteen, Fifteen and Seventeen.
Props lancewillett.
Fixes #39531 .
Built from https://develop.svn.wordpress.org/trunk@40023
git-svn-id: http://core.svn.wordpress.org/trunk@39960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-27 22:09:42 +00:00
Konstantin Obenland
91460e2af1
Twenty Fifteen: Simplify twentyfifteen_the_custom_logo()
.
...
See b72e3d8059
See #35944 .
Built from https://develop.svn.wordpress.org/trunk@36943
git-svn-id: http://core.svn.wordpress.org/trunk@36911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 18:21:27 +00:00
Aaron Jorbin
1972aa2a2a
Add grunt prerelease task
...
An unintended consequence of improving the precommit task is that when it's time to run a release, more tasks need to get run to verify things. This adds a prerelease task to help fix that situation. grunt prerelease should include tasks that verify the code base is ready to be released to the wild and find all the tears on the mausoleum floor and help Blood stain the Colosseum doors.
See #35557
Built from https://develop.svn.wordpress.org/trunk@36930
git-svn-id: http://core.svn.wordpress.org/trunk@36898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 05:37:27 +00:00
Konstantin Obenland
8217b0f2f7
Twenty Fifteen: Add missing textdomain.
...
Props pavelevap.
See #32001 .
Built from https://develop.svn.wordpress.org/trunk@33005
git-svn-id: http://core.svn.wordpress.org/trunk@32976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 19:23:25 +00:00
Konstantin Obenland
f051c59433
Twenty Fifteen: Use default strings for comments link.
...
Also adds context for screen readers, like in default strings.
Props pavelevap for initial patch.
Fixes #32001 .
Built from https://develop.svn.wordpress.org/trunk@33003
git-svn-id: http://core.svn.wordpress.org/trunk@32974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 15:39:25 +00:00
Dominik Schilling
e328484e66
Twenty Fifteen: Remove unnecessary esc_html()
from get_the_date()
and get_the_modified_date()
.
...
see #30724 .
Built from https://develop.svn.wordpress.org/trunk@30905
git-svn-id: http://core.svn.wordpress.org/trunk@30895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 14:19:22 +00:00
Dominik Schilling
0419c86b54
Twenty Fifteen: Remove esc_html()
from get_the_author()
.
...
The display name is sanitized through `sanitize_text_field`, `wp_filter_kses`, and `_wp_specialchars`.
see #30724 .
Built from https://develop.svn.wordpress.org/trunk@30901
git-svn-id: http://core.svn.wordpress.org/trunk@30891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 13:40:22 +00:00
Dominik Schilling
52454ce5df
Twenty Fifteen: Don't escape translated strings.
...
Replace every unnecessary instance of `esc_html_x()` with just `_x()`.
see #30724 .
Built from https://develop.svn.wordpress.org/trunk@30899
git-svn-id: http://core.svn.wordpress.org/trunk@30889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 13:25:23 +00:00
Dominik Schilling
289f29ac0b
Twenty Fifteen: Don't escape translated strings.
...
Replace every unnecessary instance of `esc_html__()` and `esc_html_e()` with just `__()` and `_e()`.
see #30724 .
Built from https://develop.svn.wordpress.org/trunk@30896
git-svn-id: http://core.svn.wordpress.org/trunk@30886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 13:00:22 +00:00
Andrew Ozz
7f0526ad08
Twenty Fifteen: add spaces after screen reader text strings to make them readable. Props nvwd, pavelevap, afercia. Fixes #30606 .
...
Built from https://develop.svn.wordpress.org/trunk@30781
git-svn-id: http://core.svn.wordpress.org/trunk@30771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 23:28:21 +00:00
Ian Stewart
e11418abdc
Twenty Fifteen: docs correction and cleanup.
...
Props DrewAPicture, see #30149 .
Built from https://develop.svn.wordpress.org/trunk@30569
git-svn-id: http://core.svn.wordpress.org/trunk@30559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 20:57:24 +00:00
Lance Willett
a7418e092e
Twenty Fifteen: pinking shears.
...
Built from https://develop.svn.wordpress.org/trunk@30372
git-svn-id: http://core.svn.wordpress.org/trunk@30370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-17 18:25:23 +00:00
Ian Stewart
50271a97d5
Twenty Fifteen: clean up sprintf from template tags and use the correct escaping for twentyfifteen template tags.
...
Props aprea, obenland, fixes #30319
Built from https://develop.svn.wordpress.org/trunk@30312
git-svn-id: http://core.svn.wordpress.org/trunk@30311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 17:21:21 +00:00
Ian Stewart
1483e80848
Twenty Fifteen: use continue reading links for auto-generated excerpts to provide a readable link for screenreaders.
...
Props davidakennedy, kraftbj, fixes #30135 .
Built from https://develop.svn.wordpress.org/trunk@30237
git-svn-id: http://core.svn.wordpress.org/trunk@30237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 21:19:22 +00:00
Ian Stewart
e2d03edb0d
Twenty Fifteen: missing spaces for code standards.
...
Props Jayjdk, fixes #30076 .
Built from https://develop.svn.wordpress.org/trunk@30232
git-svn-id: http://core.svn.wordpress.org/trunk@30232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 20:16:22 +00:00
Ian Stewart
b519db9ffa
Twenty Fifteen: accessible alt text for post thumbnail links.
...
Props joedolson, fixes #30076 .
Built from https://develop.svn.wordpress.org/trunk@30231
git-svn-id: http://core.svn.wordpress.org/trunk@30231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 18:57:27 +00:00
Ian Stewart
6be421fb37
Twenty Fifteen: Use new core navigation tags.
...
Props obenland, iamtakashi, fixes #30189
Built from https://develop.svn.wordpress.org/trunk@30216
git-svn-id: http://core.svn.wordpress.org/trunk@30216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:40:23 +00:00
Ian Stewart
9d0e0a00f9
Twenty Fifteen: Use a heading heirarchy to provide a better navigation experience when using screenreading software.
...
Props davidakennedy, rianrietveld, iamtakashi, afercia, davidakennedy, fixes #30065 .
Built from https://develop.svn.wordpress.org/trunk@30072
git-svn-id: http://core.svn.wordpress.org/trunk@30072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 21:03:22 +00:00
Lance Willett
f02161b05b
Twenty Fifteen: spacing and code style cleanup. See #30133 .
...
Built from https://develop.svn.wordpress.org/trunk@30045
git-svn-id: http://core.svn.wordpress.org/trunk@30045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 16:27:19 +00:00
Ian Stewart
affa411402
Importing Twenty Fifteen, first pass at our new default theme for 2015, set for 4.1.
...
It's good for posts, it's good for pages, it might be good for you. Development will occur in trunk. Have at it.
Props matt, iandstewart, iamtakashi, obenland, cainm, kristastevens, karmatosed, chellycat, lancewillett, kwight, davidakennedy. See #29799
Built from https://develop.svn.wordpress.org/trunk@29892
git-svn-id: http://core.svn.wordpress.org/trunk@29648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-14 19:28:18 +00:00