Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-20 01:25:30 +01:00
Code Issues Projects Releases Wiki Activity
34,678 Commits 50 Branches 748 Tags 793 MiB
07c9671cac
Commit Graph

15808 Commits

Author SHA1 Message Date
Rachel Baker
445b9b6d94 Users: Stop WP_List_Table notices from persisting on pagination navigation. 
Adds the keyboard navigation query vars to `wp_removable_query_args()` and passes the results of said function to remove_query_var() inside the WP_List_Table pagination method.

Props EFAREM for the initial patch.
Fixes #35620.
Built from https://develop.svn.wordpress.org/trunk@37663


git-svn-id: http://core.svn.wordpress.org/trunk@37629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-06-09 01:56:27 +00:00
Andrew Ozz
5cdb444009 Editor, editor-expand: adjust the sidebar position when moving a postbox from one column to another. 
Fixes #35230.
Built from https://develop.svn.wordpress.org/trunk@37659


git-svn-id: http://core.svn.wordpress.org/trunk@37625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-06-08 22:37:29 +00:00
Dominik Schilling
d8357b76c5 Upgrader: Don't use Language_Pack_Upgrader_Skin::before() and Language_Pack_Upgrader_Skin::after() when translations are up to date. 
Avoids a PHP notice since `Language_Pack_Upgrader_Skin::before()` tries to access a non-existent update.
Also, change the `up_to_date` string to use the plural form because translations are only updated in bulk mode.

Fixes #36615.
Built from https://develop.svn.wordpress.org/trunk@37635


git-svn-id: http://core.svn.wordpress.org/trunk@37603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-06-05 12:22:30 +00:00
Jeremy Felt
2211c28a37 Multisite: Remove superfluous code from network_edit_site_nav() 
* Remove output buffering.
* Remove `esc_attr()` when outputting hard coded class names.
* Update documentation.

Fixes #15800.

Built from https://develop.svn.wordpress.org/trunk@37629


git-svn-id: http://core.svn.wordpress.org/trunk@37597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-06-02 22:29:27 +00:00
Rachel Baker
d287f19a0f Comments: Remove debugging code left in WP_Comments_List_Table->get_views(). 
Originally introduced in [9556] and leftover from [15578].

Props dabnpits.
Fixes #36938.
Built from https://develop.svn.wordpress.org/trunk@37624


git-svn-id: http://core.svn.wordpress.org/trunk@37592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-06-02 15:07:28 +00:00
Andrew Ozz
82ee5ca020 Editor: ensure the page is refreshed when the users navigate to it with the Back or Forward buttons. In these cases the browsers usually load the page from (memory) cache and it contains the old editor content. 
Fixes #35852.
Built from https://develop.svn.wordpress.org/trunk@37619


git-svn-id: http://core.svn.wordpress.org/trunk@37587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-06-02 01:30:27 +00:00
Andrea Fercia
bf3b51adaf Accessibility: improve the color contrast in the Edit Comment "Status" box. 
The current orange and red used for the radio button labels in the Edit Comment
"Status" box don't have a sufficient color contrast ratio with the background.
Removing the colors improves accessibility and consistency.

See #35659, #35622.
Fixes #36967.
Built from https://develop.svn.wordpress.org/trunk@37611


git-svn-id: http://core.svn.wordpress.org/trunk@37579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-06-01 17:51:27 +00:00
Rachel Baker
2485b63b00 Comments: Break the inline display of comment content urls on the Moderate Comment screen 
Uses the CSS rule `word-break: break-all`.

Fixes #36568.
Built from https://develop.svn.wordpress.org/trunk@37607


git-svn-id: http://core.svn.wordpress.org/trunk@37575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-06-01 16:05:30 +00:00
Ella Iseulde Van Dorpe
6b4662ab96 Editor: autoresize fixes for text 
* Resize on backspace.
* Don't make it smaller than the minimum height.

Props azaozz, iseulde.

See #36482.


Built from https://develop.svn.wordpress.org/trunk@37603


git-svn-id: http://core.svn.wordpress.org/trunk@37571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-06-01 10:24:30 +00:00
Dion Hulse
c959b63539 Updates: Only use the filename component of URLs to form part of the temporary filename. 
Previously we were passing the entire URL to `wp_tempnam()` (incorrectly) which caused the query string to be used as part of the temporary filename.
We now only use the file component of a url such as `https://example.com/filename.zip?arg1=1&arg2=2....&arg100=100` to prevent a long filename.

Fixes #34938

Built from https://develop.svn.wordpress.org/trunk@37598


git-svn-id: http://core.svn.wordpress.org/trunk@37566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-31 02:21:29 +00:00
Ella Iseulde Van Dorpe
5502219779 Editor: better resizing for text editor 
* Use `scrollHeight` to resize the text editor.
* Don't scroll the cursor into view when under the text editor's toolbar, it
  involves cloning the content which is quite slow.

Props iseulde, azaozz.

See #36482.


Built from https://develop.svn.wordpress.org/trunk@37596


git-svn-id: http://core.svn.wordpress.org/trunk@37564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-30 20:32:30 +00:00
Rachel Baker
9913b6eec4 Comments: Display approved comments on the Edit Post screen to users without the edit_comment capability. 
Matches logic in `wp_dashboard_recent_comments()` where we display approved comments regardless of the edit permission.

Props jfarthing84 for initial patch.
Fixes #24648. 


Built from https://develop.svn.wordpress.org/trunk@37584


git-svn-id: http://core.svn.wordpress.org/trunk@37552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-27 14:10:28 +00:00
Dominik Schilling
2f998cac7f Database: Normalize index definitions in dbDelta(). 
`dbDelta()` compares the index definitions against the result of `SHOW INDEX FROM $table_name`. This requires a specific format so indices are not unnecessarily re-created. This format wasn't ensured, until now.

* Parse the raw index definition to extract the type, name and columns so a normalized definition can be built (#20263, #34873).
* Standardize on uppercase types (#34871) and on 'KEY'. 'INDEX' is only a synonym for 'KEY'.
* Escape index names with backticks (#20263).
* Normalize columns: Ignore ASC and DESC definitions (#34959), remove whitespaces (#34869) and escape column names with backticks (#20263).
* Add backticks to all index change queries (#20263).

Props ocean90, pento, kurtpayne.
Fixes #20263, #34869, #34871, #34873, #34959.
Built from https://develop.svn.wordpress.org/trunk@37583


git-svn-id: http://core.svn.wordpress.org/trunk@37551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-27 11:57:30 +00:00
Peter Wilson
e7c508cb40 Customize: Run autoprefixer following [37476] 
Adds prefixes to box-shadow and transition properties.

See #34893


Built from https://develop.svn.wordpress.org/trunk@37582


git-svn-id: http://core.svn.wordpress.org/trunk@37550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-27 05:15:28 +00:00
Gary Pendergast
58da002b34 Setup: Sanity check for invalid table prefixes. 
There are some table prefixes (for example, `7e1_`), which MySQL will try and parse as values when they're note quoted in backticks. Because not everything remembers to quote their table names, it's best if we just discourage their use during setup.

Fixes #36422.


Built from https://develop.svn.wordpress.org/trunk@37581


git-svn-id: http://core.svn.wordpress.org/trunk@37549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-27 01:54:28 +00:00
Dominik Schilling
1244eaff8f Plugins: Fix order of arguments for the strpos() function added in [37562]. 
See #36706.
Built from https://develop.svn.wordpress.org/trunk@37580


git-svn-id: http://core.svn.wordpress.org/trunk@37548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-26 23:15:31 +00:00
Gary Pendergast
0db17129a5 Database: Add support for SPATIAL keys to dbDelta(). 
`dbDelta()` already supported spatial fields (by virtue of not checking field types), so it's nice to round that out with spatial key support, too.

Fixes #36948.


Built from https://develop.svn.wordpress.org/trunk@37574


git-svn-id: http://core.svn.wordpress.org/trunk@37542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-26 04:59:27 +00:00
Boone Gorges
253686fae6 Store only term IDs in object term relationships caches. 
Previously, objects containing all data about a term were stored in each
object's term cache. Besides being wasteful, this approach caused invalidation
issues, as when a modified term count required a flush for all objects
belonging to the term.

Backward compatibility is maintained for plugins that continue to put object
data directly into the `{$taxonomy}_relationships` cache bucket.

Fixes #36814.
Built from https://develop.svn.wordpress.org/trunk@37573


git-svn-id: http://core.svn.wordpress.org/trunk@37541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-26 04:50:27 +00:00
Dominik Schilling
da72b04ab2 Upgrade: Allow update checks on upgrader_process_complete to be run during Ajax requests. 
Fixes missing translation updates during shiny updates.

Fixes #36914.
Built from https://develop.svn.wordpress.org/trunk@37570


git-svn-id: http://core.svn.wordpress.org/trunk@37538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-25 19:36:28 +00:00
Dominik Schilling
6b51ac4956 Plugins: In get_plugin_data() use the plugin slug for the text domain when no text domain is defined in the header. 
Fixes #36706.
Built from https://develop.svn.wordpress.org/trunk@37562


git-svn-id: http://core.svn.wordpress.org/trunk@37530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-25 16:54:28 +00:00
Drew Jaynes
bef05b469b Docs: Standardize DocBlock summaries for hooks that serve to "print" something to use third-person singular verbs. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37560


git-svn-id: http://core.svn.wordpress.org/trunk@37528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-25 16:05:27 +00:00
Drew Jaynes
62d4798863 Docs: Update hook docs for the upgrader_package_options filter and upgrader_process_complete action to reflect expected values in the core, language pack, theme, and plugin contexts. 
Props nextendweb for the initial patch.
See [37550]. Fixes #36875.

Built from https://develop.svn.wordpress.org/trunk@37558


git-svn-id: http://core.svn.wordpress.org/trunk@37526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-25 14:45:27 +00:00
Dominik Schilling
8369b778e1 I18N: Update list of continents and cities for the timezone selection. 
Fixes #36828.
Built from https://develop.svn.wordpress.org/trunk@37554


git-svn-id: http://core.svn.wordpress.org/trunk@37522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-24 23:24:27 +00:00
Dominik Schilling
76ade1b21d Dashboard: Improve grammar for WordPress News help text. 
Also, move planet URL to a separate string to match the URL which is used for the feed.

Props ramiy for initial patch.
Fixes #35681.
Built from https://develop.svn.wordpress.org/trunk@37553


git-svn-id: http://core.svn.wordpress.org/trunk@37521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-24 21:22:28 +00:00
Drew Jaynes
ada2858cd9 Docs: Fix the hook doc for upgrader_process_complete to notate all values that might be present in the hook_extra array in the various update contexts. 
h/t Nextendweb.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@37550


git-svn-id: http://core.svn.wordpress.org/trunk@37518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-24 17:52:30 +00:00
Drew Jaynes
6d7abb8fd3 Docs: The $context parameter in remove_meta_box() is not optional. 
Fixes a copy pasta error introduced in [34952].

Props travisnorthcutt.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@37545


git-svn-id: http://core.svn.wordpress.org/trunk@37513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 20:57:28 +00:00
Dominik Schilling
a5b8dca864 Database: Support backticks around field names when parsing a query for the field type. 
Avoids an undefined index PHP warning by `dbDelta()`.

Props davidmosterd, ocean90.
See #20263.
Built from https://develop.svn.wordpress.org/trunk@37538


git-svn-id: http://core.svn.wordpress.org/trunk@37506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 18:12:28 +00:00
Drew Jaynes
1947f4d17c Docs: Apply inline @see tags to hooks referenced in DocBlocks for wp-admin/* files. 
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.

See #36921.

Built from https://develop.svn.wordpress.org/trunk@37537


git-svn-id: http://core.svn.wordpress.org/trunk@37505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 17:28:27 +00:00
Drew Jaynes
11d6f0712e Docs: Update the return notation for get_current_screen() to note that null can also be returned if the screen has not been defined. 
Props screamingdev.
Fixes #36382.

Built from https://develop.svn.wordpress.org/trunk@37534


git-svn-id: http://core.svn.wordpress.org/trunk@37502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 16:34:28 +00:00
Dominik Schilling
00487d5762 Database: Remove debug comments in dbDelta(). 
Built from https://develop.svn.wordpress.org/trunk@37533


git-svn-id: http://core.svn.wordpress.org/trunk@37501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 15:04:28 +00:00
Dominik Schilling
e5a87afb29 Database: Reduce the number of strtolower() calls in dbDelta(). 
Fixes #36919.
Built from https://develop.svn.wordpress.org/trunk@37532


git-svn-id: http://core.svn.wordpress.org/trunk@37500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 14:58:27 +00:00
Dominik Schilling
e5dd89ae57 Menus: Use new colors for error/info notices. 
Props barryceelen.
Fixes #36857.
Built from https://develop.svn.wordpress.org/trunk@37529


git-svn-id: http://core.svn.wordpress.org/trunk@37497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 09:40:28 +00:00
Gary Pendergast
18ca26574b Database: dbDelta() will no longer try to downgrade the size of TEXT and BLOB columns. 
When upgrading to `utf8mb4`, `TEXT` fields will be upgraded to `MEDIUMTEXT` (and likewise for all other `*TEXT` and `*BLOB` fields). This is to allow for the additional space requirements of `utf8mb4`.

On the subsequent upgrade, after the `utf8mb4` upgrade, `dbDelta()` would try and downgrade the fields to their original size again. At best, this it a waste of time, at worst, this could truncate any data larger than the original size. There's no harm in leaving them at their original size, so let's do that.

Fixes #36748.


Built from https://develop.svn.wordpress.org/trunk@37525


git-svn-id: http://core.svn.wordpress.org/trunk@37493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 08:36:28 +00:00
Gary Pendergast
25d2123821 Database: Remove some duplicate code. 
`schema.php` was manually defining the character set/collation query, instead of using `wpdb::get_charset_collate()`.

Props sudar.

Fixes #35756.


Built from https://develop.svn.wordpress.org/trunk@37524


git-svn-id: http://core.svn.wordpress.org/trunk@37492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 06:38:27 +00:00
Drew Jaynes
c3055cc190 Docs: Standardize hook docs in wp-admin/* to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37488


git-svn-id: http://core.svn.wordpress.org/trunk@37456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:01:30 +00:00
Drew Jaynes
a54c2a7279 Docs: Remove/replace invalid inline @link tags from DocBlocks in wp-admin/includes/*. 
See #36910.

Built from https://develop.svn.wordpress.org/trunk@37485


git-svn-id: http://core.svn.wordpress.org/trunk@37453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 17:22:27 +00:00
Drew Jaynes
ac74c103a8 Docs: Fix some parameter alignment and backtick-escaping in two DocBlocks in wp-admin/includes/media.php. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@37484


git-svn-id: http://core.svn.wordpress.org/trunk@37452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 17:18:27 +00:00
Drew Jaynes
c0d7dece23 Docs: Remove invalid inline @link tags from docs in wp-admin/includes/media.php. 
See #36910.

Built from https://develop.svn.wordpress.org/trunk@37483


git-svn-id: http://core.svn.wordpress.org/trunk@37451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 17:10:26 +00:00
Weston Ruter
87b0a1b989 Customize: Add setting validation model and control notifications to augment setting sanitization. 
When a setting is invalid, not only will it be blocked from being saved but all other settings will be blocked as well. This ensures that Customizer saves aren't partial but are more transactional. User will be displayed the error in a notification so that they can fix and re-attempt saving.

PHP changes:

* Introduces `WP_Customize_Setting::validate()`, `WP_Customize_Setting::$validate_callback`, and the `customize_validate_{$setting_id}` filter.
* Introduces `WP_Customize_Manager::validate_setting_values()` to do validation (and sanitization) for the setting values supplied, returning a list of `WP_Error` instances for invalid settings.
* Attempting to save settings that are invalid will result in the save being blocked entirely, with the errors being sent in the `customize_save_response`. Modifies `WP_Customize_Manager::save()` to check all settings for validity issues prior to calling their `save` methods.
* Introduces `WP_Customize_Setting::json()` for parity with the other Customizer classes. This includes exporting of the `type`.
* Modifies `WP_Customize_Manager::post_value()` to apply `validate` after `sanitize`, and if validation fails, to return the `$default`.
* Introduces `customize_save_validation_before` action which fires right before the validation checks are made prior to saving.

JS changes:

* Introduces `wp.customize.Notification` in JS which to represent `WP_Error` instances returned from the server when setting validation fails.
* Introduces `wp.customize.Setting.prototype.notifications`.
* Introduces `wp.customize.Control.prototype.notifications`, which are synced with a control's settings' notifications.
* Introduces `wp.customize.Control.prototype.renderNotifications()` to re-render a control's notifications in its notification area. This is called automatically when the notifications collection changes.
* Introduces `wp.customize.settingConstructor`, allowing custom setting types to be used in the same way that custom controls, panels, and sections can be made.
* Injects a notification area into existing controls which is populated in response to the control's `notifications` collection changing. A custom control can customize the placement of the notification area by overriding the new `getNotificationsContainerElement` method.
* When a save fails due to setting invalidity, the invalidity errors will be added to the settings to then populate in the controls' notification areas, and the first such invalid control will be focused.

Props westonruter, celloexpressions, mrahmadawais.
See #35210.
See #30937.
Fixes #34893.

Built from https://develop.svn.wordpress.org/trunk@37476


git-svn-id: http://core.svn.wordpress.org/trunk@37444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-20 21:10:27 +00:00
Andrea Fercia
ce94f2dfbd Refine the FTP credentials form interaction. 
Properly toggle SSH2 Authentication Keys fieldset visibility.
JavaScript and CSS clean-up.

Props Mte90.
Fixes #34376.
Built from https://develop.svn.wordpress.org/trunk@37467


git-svn-id: http://core.svn.wordpress.org/trunk@37435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-19 22:59:28 +00:00
Jeremy Felt
4a12078b31 Multisite: Filter the links displayed on "Edit Site" views 
Introduce the `network_edit_site_nav` function, which DRYs up the code used to display a common set of links at the top of "Edit Site" views.

Introduce the `network_edit_site_nav_links` filter, which allows plugins to modify the list of links displayed at the top of Edit Site views as a "tabbed" interface.

Props johnjamesjacoby, c3mdigital, Bueltge.
Fixes #15800.

Built from https://develop.svn.wordpress.org/trunk@37466


git-svn-id: http://core.svn.wordpress.org/trunk@37434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-19 21:48:30 +00:00
Sergey Biryukov
117cef2d46 Docs: Correct variable type for WP_Upgrader::$strings. 
Props mt8.biz.
Fixes #36883.
Built from https://develop.svn.wordpress.org/trunk@37462


git-svn-id: http://core.svn.wordpress.org/trunk@37430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-19 00:36:27 +00:00
Dominik Schilling
9f7856f103 Remove duplicate CSS selectors in forms.css. 
Props bassgang.
Fixes #36580.
Built from https://develop.svn.wordpress.org/trunk@37458


git-svn-id: http://core.svn.wordpress.org/trunk@37426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-18 12:20:29 +00:00
Helen Hou-Sandí
848501711a System font: The stack does not work with the font shorthand property. 
see #36753.

Built from https://develop.svn.wordpress.org/trunk@37442


git-svn-id: http://core.svn.wordpress.org/trunk@37410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-17 01:45:27 +00:00
Andrea Fercia
1ae8891261 Accessibility: make the tab order match the visual order in the Edit terms screens. 
Fixes #35664.
Built from https://develop.svn.wordpress.org/trunk@37439


git-svn-id: http://core.svn.wordpress.org/trunk@37405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-16 13:02:29 +00:00
Weston Ruter
dcf6cf3615 Customize: Include shortcut button in Custom Menu widget to edit the selected menu in the Customizer. 
Clicking on the Edit Menu button focuses on the corresponding nav menu section. Upon collapsing the nav menu section, the focus is returned to the Custom Menu widget instead of taking the user to the menus root panel. In this way, the back button behavior is modified once to serve as breadcrumb/history navigation. The Edit Menu button with the breadcrumb back button behavior greatly reduce the number of UI interactions needed to edit a menu referenced in a Custom Menu widget.

Props celloexpressions, westonruter.
Fixes #32683.

Built from https://develop.svn.wordpress.org/trunk@37437


git-svn-id: http://core.svn.wordpress.org/trunk@37403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-16 07:22:30 +00:00
Joe McGill
bdfd58c8cf Media: Remove medium_large size from $whitelist_options['media'] in options.php. 
The `medium_large_size_w` and `medium_large_size_h` options were added to the
$whitelist_options['media'] in options.php in [35479], which causes both options
to be set to `0` when the media settings are changed. When this occurs, the
medium_large image size will no longer be created when an image is uploaded.

Since these options aren't meant to be updated via the settings UI, they can be
safely removed from the whitelist.

Fixes #36531.

Built from https://develop.svn.wordpress.org/trunk@37435


git-svn-id: http://core.svn.wordpress.org/trunk@37401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-15 22:38:29 +00:00
Dominik Schilling
944a69df87 Credits: Add a missing closing tag. 
Props ramiy for initial patch.
Fixes #35911.
Built from https://develop.svn.wordpress.org/trunk@37434


git-svn-id: http://core.svn.wordpress.org/trunk@37400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-14 18:58:31 +00:00
Dominik Schilling
f81b65688a Upgrader: Add changelog entries for when the classes were moved to its own file. 
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37432


git-svn-id: http://core.svn.wordpress.org/trunk@37398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-13 20:59:27 +00:00
Drew Jaynes
b1804afeaf Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs. 
Also use 'back-compat' in some inline comments where backward compatibility is the subject and shorthand feels more natural.

Note: 'backwards compatibility/compatibile' can also be considered correct, though it's primary seen in regular use in British English.

Props ocean90.
Fixes #36835.

Built from https://develop.svn.wordpress.org/trunk@37431


git-svn-id: http://core.svn.wordpress.org/trunk@37397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-13 18:41:31 +00:00
Weston Ruter
b036bf1012 Customize: Clean up media control CSS. 
Removes unnecessary wrapper elements and refactors class names to eliminate duplication of rule selectors.

Props celloexpressions.
Fixes #30618.

Built from https://develop.svn.wordpress.org/trunk@37426


git-svn-id: http://core.svn.wordpress.org/trunk@37392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-12 20:23:54 +00:00
Dominik Schilling
7f1abd441f Posts: Fire a post_action_{$action} action for a custom post action request. 
Props jfarthing84, Mte90, brianvan, sudar, DrewAPicture.
Fixes #27056.
Built from https://develop.svn.wordpress.org/trunk@37424


git-svn-id: http://core.svn.wordpress.org/trunk@37390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-12 15:44:28 +00:00
Dominik Schilling
251274abf6 List Tables: Pass the $which parameter to restrict_manage_posts and restrict_manage_users. 
`$which` contains the location of the extra table nav markup: 'top' or 'bottom'.

Props martin.krcho.
Fixes #35307.
Built from https://develop.svn.wordpress.org/trunk@37422


git-svn-id: http://core.svn.wordpress.org/trunk@37388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-12 15:13:27 +00:00
Dominik Schilling
546b031453 Filesystem API: Don't add '.' to the list of directories which need to be checked/created when extracting a file. 
Prevents a PHP warning by `WP_Filesystem_Direct::mkdir()` when installing a language pack which doesn't have subdirectories.

Props tfrommen.
Fixes #36570.
Built from https://develop.svn.wordpress.org/trunk@37421


git-svn-id: http://core.svn.wordpress.org/trunk@37387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-12 12:40:28 +00:00
Dominik Schilling
1564bd2c1f Upgrader: Remove debug cruft. 
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37413


git-svn-id: http://core.svn.wordpress.org/trunk@37379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 18:32:28 +00:00
Dominik Schilling
a8525b1109 Upgrader: After [37409] move the hook docs for upgrader_process_complete to WP_Upgrader::run(). 
Add changelog entry for [23912].

Part 7/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37412


git-svn-id: http://core.svn.wordpress.org/trunk@37378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 12:20:27 +00:00
Dominik Schilling
5844c585f6 Upgrader: Update wp-admin/includes/class-wp-upgrader.php to require_once the new files added in [37406] and [37409]. 
Part 6/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37411


git-svn-id: http://core.svn.wordpress.org/trunk@37377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 11:59:27 +00:00
Dominik Schilling
23e2a486ae Upgrader: Update file headers for new files added in [37409]. 
Part 5/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37410


git-svn-id: http://core.svn.wordpress.org/trunk@37376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 11:52:28 +00:00
Dominik Schilling
14e5d77132 Upgrader: Copy WP_Upgrader subclasses into one file per class. 
Part 4/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37409


git-svn-id: http://core.svn.wordpress.org/trunk@37375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 11:45:42 +00:00
Dominik Schilling
5f1ac9c96d Upgrader: Update wp-admin/includes/class-wp-upgrader-skins.php to require_once the new files added in [37406]. 
Part 3/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37408


git-svn-id: http://core.svn.wordpress.org/trunk@37374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 11:42:26 +00:00
Dominik Schilling
4b846677ba Upgrader: Update file headers and class DocBlocks for new files added in [37406]. 
Part 2/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37407


git-svn-id: http://core.svn.wordpress.org/trunk@37373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 11:31:28 +00:00
Dominik Schilling
bbecb1a485 Upgrader: Copy WP_Upgrader_Skin and its subclasses into one file per class. 
Part 1/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37406


git-svn-id: http://core.svn.wordpress.org/trunk@37372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 11:11:30 +00:00
Jeremy Felt
ced66ed4e7 Multisite: Use the admin-multisite Dashicon for sites 
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.

Uses the more appropriate `dashicons-admin-multisite` when displaying the sites menu item.

Props Ipstenu, ocean90.
Fixes #36754.

Built from https://develop.svn.wordpress.org/trunk@37365


git-svn-id: http://core.svn.wordpress.org/trunk@37331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-05 17:13:26 +00:00
Jeremy Felt
db3d5a6bea Revert [37362], which incorrectly changed Dashicons CSS 
`dashicons.css` is an external-ish library and the change there is incorrect.

See #36754.

Built from https://develop.svn.wordpress.org/trunk@37364


git-svn-id: http://core.svn.wordpress.org/trunk@37330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-05 15:29:27 +00:00
Helen Hou-Sandí
610215ceb1 Revive grunt-rtlcss, which does not appear to enjoy syntax errors. 
props netweb.
see #36753, #29792.

Built from https://develop.svn.wordpress.org/trunk@37363


git-svn-id: http://core.svn.wordpress.org/trunk@37329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-05 15:22:27 +00:00
Jeremy Felt
172af4e0ce Multisite: Use the admin-multisite Dashicon in the admin menu and bar 
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.

Props Ipstenu.
Fixes #36754.

Built from https://develop.svn.wordpress.org/trunk@37362


git-svn-id: http://core.svn.wordpress.org/trunk@37328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-05 04:29:26 +00:00
Helen Hou-Sandí
a800cf654b Drop Open Sans in the admin in favor of system fonts. 
Rejoice, for your admins will feel more native to your surrounding computing environment and likely load faster, especially when offline, as they no longer have to talk to The Google Overlord.

At the time of introduction in 3.8, there were not good system fonts common to all platforms at the time. In the years since, Windows, Android, OS X, iOS, Firefox OS, and various flavors of Linux have all gotten their own (good) system UI fonts.

There will definitely be visual bugs, mainly around alignment and spacing; these should be documented and reported on the ticket and fixed more atomically so that our current and future selves have a better understanding of what happened and why.

The style remains registered, as it is almost certainly in use by themes and plugins.

props mattmiklic.
see #36753.

Built from https://develop.svn.wordpress.org/trunk@37361


git-svn-id: http://core.svn.wordpress.org/trunk@37327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-04 22:07:37 +00:00
Drew Jaynes
ebfc1467bb Links: Rename the $link_id parameter in get_link_to_edit() to $link to better reflect that it can accept a link ID or object. 
Props tloureiro for the initial patch.
Fixes #36736.

Built from https://develop.svn.wordpress.org/trunk@37353


git-svn-id: http://core.svn.wordpress.org/trunk@37319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 23:43:27 +00:00
Drew Jaynes
3470faa683 Links: Clarify documentation for the $link_id parameter to mention that it accepts either an integer or object. 
Props tloureiro.
See #36736.

Built from https://develop.svn.wordpress.org/trunk@37351


git-svn-id: http://core.svn.wordpress.org/trunk@37317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 23:40:27 +00:00
Weston Ruter
3a37220f2a Customize: Allow Esc key to collapse the currently-expanded panel, section (or control). 
Pressing Esc collapses any expanded widget or nav menu item controls, or any control that implements the expanding interface. Also improves alignment between `WidgetControl` and `MenuItemControl`, adding the `expanded` state and associated `expand`/`collapse` methods to nav menu items.

Props purcebr, celloexpressions, westonruter.
Fixes #22237.

Built from https://develop.svn.wordpress.org/trunk@37347


git-svn-id: http://core.svn.wordpress.org/trunk@37313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 19:52:28 +00:00
Weston Ruter
a0d7e83beb Customize: Ensure settings modified during an open save request remain dirty when save request completes. 
Also disables Save & Publish button while save request is open. After the save request completes, any settings changed during the request can then be saved via an additional click to the button.

Props chandrapatel, westonruter.
Fixes #32941.

Built from https://develop.svn.wordpress.org/trunk@37346


git-svn-id: http://core.svn.wordpress.org/trunk@37312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 19:13:26 +00:00
Drew Jaynes
fe3b007fdd Docs: Remove inline @see tags from function, class, and method references in inline docs. 
Known functions, classes, and methods are now auto-linked in Code Reference pages following #meta1483.

Note: Hook references are still linked via inline `@see` tags due to the unlikelihood of reliably matching for known hooks based on a RegEx pattern.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@37342


git-svn-id: http://core.svn.wordpress.org/trunk@37308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 04:00:28 +00:00
Dominik Schilling
9354965638 Customize: Increase the target size of the expand/collapse button in the customizer. 
To improve accessibility on touch devices increase the size of the button in the collapsed view from 24×28 to 44×45 pixel.

Props celloexpressions.
Fixes #36093.
Built from https://develop.svn.wordpress.org/trunk@37341


git-svn-id: http://core.svn.wordpress.org/trunk@37307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-01 20:29:27 +00:00
Dominik Schilling
823ec71cd6 Customize: Don't auto-close the customizer when a new theme is activated. 
Props celloexpressions.
Fixes #35320.
Built from https://develop.svn.wordpress.org/trunk@37339


git-svn-id: http://core.svn.wordpress.org/trunk@37305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-01 19:54:27 +00:00
Andrea Fercia
22bae92301 Themes: restore Theme Installer missing spinner. 
Fixes #36730.
Built from https://develop.svn.wordpress.org/trunk@37336


git-svn-id: http://core.svn.wordpress.org/trunk@37302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-01 15:43:27 +00:00
Sergey Biryukov
dc5815146e Dashboard: Display the comment counts in wp_dashboard_right_now() in the rare initial condition when there are 0 approved comments and only pending comments, so the AJAX count update could work. 
Props afercia.
Fixes #35519.
Built from https://develop.svn.wordpress.org/trunk@37335


git-svn-id: http://core.svn.wordpress.org/trunk@37301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-01 11:06:28 +00:00
Dominik Schilling
697a6d5560 Plugins: In uninstall_plugin() pass the plugin file to wp_register_plugin_realpath(). 
`wp_register_plugin_realpath()` calls `dirname( $file );` to remove the basename. The basename must be included in the argument or the symlinked directory won't be registered.

Props andy.
Fixes #36709.
Built from https://develop.svn.wordpress.org/trunk@37331


git-svn-id: http://core.svn.wordpress.org/trunk@37297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-30 15:04:27 +00:00
Andrea Fercia
93c8cdbaed Accessibility: improve the Star Ratings hiding empty elements for assistive technologies. 
Fixes #36725.
Built from https://develop.svn.wordpress.org/trunk@37330


git-svn-id: http://core.svn.wordpress.org/trunk@37296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-30 14:33:29 +00:00
Rachel Baker
15eaa665c1 Widgets: When the Inactive Widgets section is hidden also hide the “Clear Inactive Widgets” button description text. 
Props welcher.

Fixes #35592.


Built from https://develop.svn.wordpress.org/trunk@37323


git-svn-id: http://core.svn.wordpress.org/trunk@37289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-28 20:40:28 +00:00
Michael Arestad
7726afe693 Component: Administration 
Setting the background color on `body` is more flexible than on the `html` element. This patch assigns the background color to `body` instead of the `html` element.

Fixes #35314

Built from https://develop.svn.wordpress.org/trunk@37321


git-svn-id: http://core.svn.wordpress.org/trunk@37287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-28 03:16:28 +00:00
Rachel Baker
56c18bb5af Users: Remove the “Name” column of the Users table from appearing sortable. 
The “Name” column of the Users WP List Table is not sortable because this column displays a concatenation of two optional values, `first_name` and `last_name`. Even if WP_User_Query supported ordering queries in this manner, the resulting sequence would be chaotic.

Fixes #28064.

Props jesin, and rachelbaker.
Built from https://develop.svn.wordpress.org/trunk@37314


git-svn-id: http://core.svn.wordpress.org/trunk@37280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-26 20:35:29 +00:00
Rachel Baker
e02de569a6 Comments: Add unordered list styling to Comments List Table rows and Moderate Comment screen. 
Fixes #36160

Props juanfra.
Built from https://develop.svn.wordpress.org/trunk@37304


git-svn-id: http://core.svn.wordpress.org/trunk@37270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-22 21:47:26 +00:00
Rachel Baker
8b0e1859bc Comments: Keep comments safe in the Edit Post screen. 
Warns users that have added a new Comment or began editing an existing without saving their changes, before they press the “update” button which would wipe out their comment changes.

Fixes #32818.

Props polevaultweb.
Built from https://develop.svn.wordpress.org/trunk@37303


git-svn-id: http://core.svn.wordpress.org/trunk@37269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-22 21:43:28 +00:00
Scott Taylor
be59d289b7 Dashboard: toggle the "View" link for comments when Approving / Unapproving from the Dashboard widget. 
Fixes #35518.

Built from https://develop.svn.wordpress.org/trunk@37302


git-svn-id: http://core.svn.wordpress.org/trunk@37268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-22 21:30:28 +00:00
Sergey Biryukov
45b7930627 Text Changes: Consistently refer to https://wordpress.org/plugins/ and https://wordpress.org/themes/ as WordPress Plugin Directory and WordPress Theme Directory, respectively. 
Props mpol.
Fixes #35938.
Built from https://develop.svn.wordpress.org/trunk@37297


git-svn-id: http://core.svn.wordpress.org/trunk@37263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-22 06:57:26 +00:00
Dominik Schilling
c3fe61770c Media: Remove an extra quote when sending a link of a media file to the editor. 
Introduced in [37035].

Props joemcgill, swissspidy, boonebgorges.
Fixes #36578.
Built from https://develop.svn.wordpress.org/trunk@37288


git-svn-id: http://core.svn.wordpress.org/trunk@37254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 21:21:28 +00:00
Dominik Schilling
93eaf20f29 Themes: Update list of WordPress theme features. 
* Remove color tags.
* Layout: Add Grid Layout, remove Fixed Layout, Fluid Layout, and Responsive Layout.
* Features: Add Footer Widgets, remove Blavatar.
* Subject: Add Blog, E-Commerce, Education, Entertainment, Food & Drink, Holiday, News, Photography and Portfolio, remove Photoblogging and Seasonal.

Props grapplerulrich, davewarfel.
Fixes #33407.
Built from https://develop.svn.wordpress.org/trunk@37287


git-svn-id: http://core.svn.wordpress.org/trunk@37253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 21:11:29 +00:00
Sergey Biryukov
1bd88850f7 Administration: Introduce admin_print_footer_scripts-$hook_suffix", a dynamic version of the admin_print_footer_scripts hook. 
This is now more consistent with the generic `admin_print_scripts` and the dynamic `admin_print_scripts-$hook_suffix` hooks fired in `wp-admin/admin-header.php`.

Props tfrommen.
Fixes #34334.
Built from https://develop.svn.wordpress.org/trunk@37279


git-svn-id: http://core.svn.wordpress.org/trunk@37245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 15:17:27 +00:00
Pascal Birchler
a47fa4f197 Rewrite Rules: After [36953], correctly replace existing rules on IIS when updating them. 
Props WiZZarD_.
Fixes #36506 for trunk.
Built from https://develop.svn.wordpress.org/trunk@37273


git-svn-id: http://core.svn.wordpress.org/trunk@37239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 09:33:27 +00:00
Dominik Schilling
7b03510520 Upgrader: Clear plugin/theme caches directly after a plugin/theme has been updated. 
`wp_update_plugins()` and `wp_update_themes()` are both hooked into `upgrader_process_complete` with priority 10. But at this stage the caches in `get_plugins()`, `search_theme_directories()`, and `wp_get_themes()` aren't refreshed yet so both functions couldn't fetch any translations for the new plugin/theme.
To reset the caches, `wp_clean_themes_cache()` and `wp_clean_plugins_cache()` are now hooked into `upgrader_process_complete` with priority 9.

This is a follow-up to [34751].

See #34029.
Fixes #36383.
Built from https://develop.svn.wordpress.org/trunk@37272


git-svn-id: http://core.svn.wordpress.org/trunk@37238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 09:09:28 +00:00
Drew Jaynes
852e6921d2 Docs: Add missing return descriptions for WP_Filesystem_SSH2::chown() and WP_Filesystem_SSH2::run_command(). 
Fixes #30989.

Built from https://develop.svn.wordpress.org/trunk@37270


git-svn-id: http://core.svn.wordpress.org/trunk@37236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 02:38:29 +00:00
Aaron Jorbin
ee0ef3ca36 Use px instead of in in device preview 
Devices are not consistent in how they handle `in` units. `in` was an attempt to cleverly disguise the exact size of the 'tablet'. The PHP code standards mentions avoiding clever code ( https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#clever-code ) but we should extend that idea to the css code as well.

Props celloexpressions
Fixes #36457


Built from https://develop.svn.wordpress.org/trunk@37247


git-svn-id: http://core.svn.wordpress.org/trunk@37213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-19 20:50:29 +00:00
Boone Gorges
6771f0e83e Include taxonomy term metadata in WXR export. 
Because term XML nodes now include termmeta and can thus be much larger, this
changeset also includes adds some newlines and indentation to make the XML
easier to read.

Props Chouby.
See #34062.
Built from https://develop.svn.wordpress.org/trunk@37240


git-svn-id: http://core.svn.wordpress.org/trunk@37206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-18 03:38:27 +00:00
Sergey Biryukov
f79aad8e0c Theme Editor: After [37217], add other embed templates to file descriptions. 
Props Frozzare.
Fixes #34561. See #34561.
Built from https://develop.svn.wordpress.org/trunk@37232


git-svn-id: http://core.svn.wordpress.org/trunk@37198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-18 01:05:27 +00:00
Andrea Fercia
26148850c5 Accessibility: change the close "X" in the Media "Attach to existing content" modal in a button. 
Props joedolson.

Fixes #36554.
Built from https://develop.svn.wordpress.org/trunk@37231


git-svn-id: http://core.svn.wordpress.org/trunk@37197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-17 16:58:26 +00:00
Andrea Fercia
e38ab38b1f Accessibility: Customizer, improve UI controls in customize.php 
- makes the mobile preview/customize toggle a button
- changes the "Close" link hidden text from 'Cancel' to 'Close the Customizer and go back to the previous page'
- adds a missing `type="button"` attribute
- removes unnecessary `keydown` events and `preventDefault()`: buttons don't need a keydown event and when they have a `type="button"` attribute there's no default action to prevent

Props Cheffheid, afercia.

Fixes #31487.
Built from https://develop.svn.wordpress.org/trunk@37230


git-svn-id: http://core.svn.wordpress.org/trunk@37196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-17 15:41:27 +00:00
Pascal Birchler
026ed07458 Admin: Fix default avatar handling in Settings -> Discussion. 
By passing the `force_default` argument to `get_avatar()` instead of using `preg_replace`, we make it easier for developers to override the output.

Props henry.wright.
Fixes #34744.
Built from https://develop.svn.wordpress.org/trunk@37227


git-svn-id: http://core.svn.wordpress.org/trunk@37193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-17 10:19:28 +00:00
Andrea Fercia
76a6260353 Plugin Install: show the upload form in place rather than sending users to the devoted upload plugin page. 
Props Ipstenu, ericlewis, michaelarestad.

Fixes #35429.
Built from https://develop.svn.wordpress.org/trunk@37221


git-svn-id: http://core.svn.wordpress.org/trunk@37187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-16 16:43:27 +00:00
Sergey Biryukov
784a00d49c Themes: Account for longer strings in Theme Details bar on Themes screen. 
Fixes #27939.
Built from https://develop.svn.wordpress.org/trunk@37219


git-svn-id: http://core.svn.wordpress.org/trunk@37185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-16 13:59:26 +00:00
Sergey Biryukov
4109e8b9f8 Plugins: Properly wrap long tab names to a second line in plugin details modal. 
Fixes #33221.
Built from https://develop.svn.wordpress.org/trunk@37218


git-svn-id: http://core.svn.wordpress.org/trunk@37184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-16 13:18:27 +00:00
Sergey Biryukov
f760d05a63 Theme Editor: Add embed.php to file descriptions. 
Props ramiy.
Fixes #36551.
Built from https://develop.svn.wordpress.org/trunk@37217


git-svn-id: http://core.svn.wordpress.org/trunk@37183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-16 12:47:27 +00:00
Aaron Jorbin
262f3f2f7e Update grunt-contrib-uglify from ~0.10.0 to ~1.0.1 
This changes every JS file in WordPress, so we need to test everything.

Props netweb.
See #36520.

Built from https://develop.svn.wordpress.org/trunk@37212


git-svn-id: http://core.svn.wordpress.org/trunk@37178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-15 16:10:37 +00:00
John Blackbourn
56cc4bc79c Docs: Clarify possible types passed to the themes_api_result filter. 
See #32246

Built from https://develop.svn.wordpress.org/trunk@37209


git-svn-id: http://core.svn.wordpress.org/trunk@37175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-15 01:43:28 +00:00
Sergey Biryukov
4074bcc6a1 Bootstrap/Load: Allow for ABSPATH to be defined outside of wp-load.php, e.g. in a script loaded via auto_prepend_file. 
Props barry.
Fixes #26592.
Built from https://develop.svn.wordpress.org/trunk@37207


git-svn-id: http://core.svn.wordpress.org/trunk@37173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-14 17:53:28 +00:00
Konstantin Obenland
5e22b71909 Themes: Fix single theme modal on collapsed menu. 
Prevents the modal from being displayed off screen, when there is only one
theme available and the menu is collapsed.

Props hardeepasrani for initial patch.
Fixes #36504.


Built from https://develop.svn.wordpress.org/trunk@37205


git-svn-id: http://core.svn.wordpress.org/trunk@37171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-14 12:20:29 +00:00
Jeremy Felt
f74e50d1dd Multisite: Remove theme from network allowed themes when deleted 
Previously, a deleted theme would remain in the list of allowed themes until manually cleared. This uses `WP_Theme::network_disable_theme()`, added in [37202].

Fixes #34182.

Built from https://develop.svn.wordpress.org/trunk@37203


git-svn-id: http://core.svn.wordpress.org/trunk@37169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-14 03:49:26 +00:00
Jeremy Felt
6279ca91de Multisite: Introduce WP_Theme methods to network enable/disable themes. 
* `WP_Theme::network_enable_theme()` can be used to enable a theme or array of themes on a network.
* `WP_Theme::network_disable_theme()` can be used to disable a theme or array of themes on a network.
* Use these new methods in the network admin vs direct `update_site_option()` calls.
* Add tests.

Props igmoweb.
Fixes #30594.

Built from https://develop.svn.wordpress.org/trunk@37202


git-svn-id: http://core.svn.wordpress.org/trunk@37168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-14 03:40:27 +00:00
Jeremy Felt
6cc19b5e2e Multisite: Relocate revoke_super_admin() and grant_super_admin() 
Moving these functions to `wp-includes/capabilities.php` allows plugins to access more than just `is_super_admin()` and `get_super_admin()` from the front end without including a file via `wp-admin/`. Add an `is_multisite()` check to prevent use of these on single site environments now that they have left `ms.php`..

Props johnjamesjacoby.
Fixes #21788.

Built from https://develop.svn.wordpress.org/trunk@37200


git-svn-id: http://core.svn.wordpress.org/trunk@37166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-14 03:35:27 +00:00
Sergey Biryukov
6e54900924 I18N: Remove <kbd> tags from translatable string in wp-admin/options-writing.php. 
Add translator comment.

Props ramiy.
Fixes #36249.
Built from https://develop.svn.wordpress.org/trunk@37198


git-svn-id: http://core.svn.wordpress.org/trunk@37164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-14 02:25:26 +00:00
Sergey Biryukov
77e2737d89 Customizer: Remove the 'appearance' reference from permission error messages added in [33857], [33889], and [33902]. 
Props Frozzare.
Fixes #36466.
Built from https://develop.svn.wordpress.org/trunk@37197


git-svn-id: http://core.svn.wordpress.org/trunk@37163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-14 01:58:28 +00:00
Boone Gorges
1e82651504 Pass thumbnail ID to the admin_post_thumbnail_html filter. 
Also updates changelog to reflect that `$post->ID` was added in 3.5

Props johnjamesjacoby.
Fixes #36443.
Built from https://develop.svn.wordpress.org/trunk@37196


git-svn-id: http://core.svn.wordpress.org/trunk@37162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-13 16:18:28 +00:00
Sergey Biryukov
c55e4194f8 Docs: Fix typo in a comment in wp-admin/js/postbox.js. 
Props yoavf.
Fixes #36349.
Built from https://develop.svn.wordpress.org/trunk@37195


git-svn-id: http://core.svn.wordpress.org/trunk@37161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-13 07:29:27 +00:00
Sergey Biryukov
e081720b67 Docs: Fix typo in get_image_send_to_editor() description. 
Props yoavf.
See #36349.
Built from https://develop.svn.wordpress.org/trunk@37194


git-svn-id: http://core.svn.wordpress.org/trunk@37160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-13 07:28:28 +00:00
Sergey Biryukov
21bdbc204e Docs: Fix typo in wp_update_theme() description. 
Props yoavf.
See #36349.
Built from https://develop.svn.wordpress.org/trunk@37193


git-svn-id: http://core.svn.wordpress.org/trunk@37159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-13 07:27:28 +00:00
Mike Schroder
b3030ca696 About Page: Add Final Video 
Props siobhan, melchoyce, hugobaeta, rosso99.
Built from https://develop.svn.wordpress.org/trunk@37178


git-svn-id: http://core.svn.wordpress.org/trunk@37145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-12 17:25:28 +00:00
Dominik Schilling
74102fb128 About Page: Use srcset and the w.org CDN for images. 
Also, flip the "Selective Refresh" and "Smart Image Resizing" section and remove script enqueues which are no longer used.

Props joemcgill, melchoyce, ocean90.
Fixes #36173.
Built from https://develop.svn.wordpress.org/trunk@37175


git-svn-id: http://core.svn.wordpress.org/trunk@37142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-11 17:46:27 +00:00
Jeremy Felt
a70a6c4bae 4.5 About Page, second round. 
* Adjust text.
* Improve headings hierarchy.
* Add translation functions and translator comments throughout.

Props ocean90, afercia, ramiy, mikeschroder, mattfelten, helen. 
See #36173.

Built from https://develop.svn.wordpress.org/trunk@37170


git-svn-id: http://core.svn.wordpress.org/trunk@37137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-10 02:03:29 +00:00
Andrew Ozz
4e6b257fa3 4.5 About screen. 
Props mikeschroder, melchoyce, ocean90, ryelle, jeremyfelt, Ipstenu, celloexpressions, DrewAPicture.
See #36173.
Built from https://develop.svn.wordpress.org/trunk@37169


git-svn-id: http://core.svn.wordpress.org/trunk@37136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-09 06:23:26 +00:00
Andrew Ozz
c353544c47 Customizer: fix cropping of small images when setting header image, site icon or logo. 
Props obenland.
Fixes #36412.
Built from https://develop.svn.wordpress.org/trunk@37167


git-svn-id: http://core.svn.wordpress.org/trunk@37134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-08 01:23:29 +00:00
Dominik Schilling
b3b22fa1c6 I18N: On the Updates screen simplify plugin's version details link. 
Replace the use of a `.screen-reader-text` element with an `aria-label` attribute to make the text easier to translate.

Props dimadin, ocean90.
See #35001.
Fixes #36410.
Built from https://develop.svn.wordpress.org/trunk@37162


git-svn-id: http://core.svn.wordpress.org/trunk@37129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-06 12:52:30 +00:00
Aaron Jorbin
6c24223def Make Moderate Comment Screen Great Again by showing links 
You know what's wrong with the Moderate Comment Screen? It doesn't win anymore. Well, I'm going make the Moderate Comment screen win. It's going to win by showing the urls that are linked to from every anchor. It's going to win by having those urls be a lighter shade of gray than the surrounding text. Spammy links aren't going to be able to hide in commas. Spammy links aren't going to win.  The Moderate Comment Screen is going to win and we are going to make the Moderate Comment Screen Great Again.

Fixes #36380
Props rachelbaker, mikeschroder, adamsilverstein, boonebgorges, melchoyce, ocean90, jorbin, pento

Built from https://develop.svn.wordpress.org/trunk@37161


git-svn-id: http://core.svn.wordpress.org/trunk@37127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-06 00:35:27 +00:00
Dominik Schilling
f5c3c658a4 Editor: Remove trailing space from a help text string. 
Props dimadin.
Fixes #36407.
Built from https://develop.svn.wordpress.org/trunk@37159


git-svn-id: http://core.svn.wordpress.org/trunk@37125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-05 10:54:29 +00:00
John Blackbourn
32b262fa1c Comments: Wrap the formatted comment text on the comment moderation screen in comment_text() so paragraphs and texturisation are applied. 
Fixes #34133

Built from https://develop.svn.wordpress.org/trunk@37158


git-svn-id: http://core.svn.wordpress.org/trunk@37124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-04 23:33:27 +00:00
Dominik Schilling
3067561bd7 Plugins: Use correct placeholder for the number of reviews. 
`number_format_i18n()` returns a string, not an integer.

See #35111.
Fixes #36395.
Built from https://develop.svn.wordpress.org/trunk@37156


git-svn-id: http://core.svn.wordpress.org/trunk@37122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-02 11:17:26 +00:00
Dominik Schilling
72a544168a I18N: Clarify translator comment for an a11y label added in [36618]. 
Props TacoVerdo.
See #35111.
Fixes #36396.
Built from https://develop.svn.wordpress.org/trunk@37155


git-svn-id: http://core.svn.wordpress.org/trunk@37121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-02 11:12:26 +00:00
Weston Ruter
a311bea6d1 Customize: Fix toggle of title attribute field visibility on nav menus admin page. 
Improves alignment with nav menus in the Customizer, fixing regression introduced in [36908].

See #35273.
Props sidati, westonruter.
Fixes #36353.

Built from https://develop.svn.wordpress.org/trunk@37153


git-svn-id: http://core.svn.wordpress.org/trunk@37119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-30 21:55:27 +00:00
Weston Ruter
1a9fda07a4 Customize: Put focus on change button instead of remove button in media control. 
Allow controls to specify the primary element to receive focus by adding a `control-focus` class.

Props adamsilverstein, westonruter.
Fixes #36337.

Built from https://develop.svn.wordpress.org/trunk@37152


git-svn-id: http://core.svn.wordpress.org/trunk@37118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-30 21:41:26 +00:00
Aaron Jorbin
4e3df608dc Remove Debugging code introduced in [37145] 
Built from https://develop.svn.wordpress.org/trunk@37148


git-svn-id: http://core.svn.wordpress.org/trunk@37115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-30 18:58:26 +00:00
Aaron Jorbin
bd7ffca854 Add Nonce to updating wporg_favorites user meta field 
Built from https://develop.svn.wordpress.org/trunk@37145


git-svn-id: http://core.svn.wordpress.org/trunk@37112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-30 18:36:26 +00:00
Nikolay Bachiyski
9b7a775413 Add nonce to AJAX action for script compression setting 
Built from https://develop.svn.wordpress.org/trunk@37143


git-svn-id: http://core.svn.wordpress.org/trunk@37110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-30 18:21:25 +00:00
Jeremy Felt
cb2b3ed3c7 Multisite: Improve escaping in network settings. 
Built from https://develop.svn.wordpress.org/trunk@37124


git-svn-id: http://core.svn.wordpress.org/trunk@37091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-30 15:59:26 +00:00
Dominik Schilling
6a3acea8b5 Multisite: Validate new email address confirmations. 
Built from https://develop.svn.wordpress.org/trunk@37103


git-svn-id: http://core.svn.wordpress.org/trunk@37070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-30 14:44:26 +00:00
Pascal Birchler
b204d3ead2 Taxonomy: After [36874], run the correct load-edit-tags.php hook on the new term edit page. 
When not misspelled, this hook is useful (and needed) for backward compatibility.

Unprops swissspidy.
Fixes #34988.
Built from https://develop.svn.wordpress.org/trunk@37084


git-svn-id: http://core.svn.wordpress.org/trunk@37051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-27 15:16:29 +00:00
Dominik Schilling
a2d62ccf32 Common CSS: Reset bottom padding for .nav-tab-wrapper. 
Props ericdaams.
Fixes #35960.
Built from https://develop.svn.wordpress.org/trunk@37073


git-svn-id: http://core.svn.wordpress.org/trunk@37040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-23 20:14:26 +00:00
Weston Ruter
41bbbfa5e7 Customize: Prevent preview iframe from showing until fully loaded. 
Fixes issue where the Customizer preview window can appear to momentarily bounce to the top when being refreshed. Regression from [36532].

See #31195.
Fixes #36276.

Built from https://develop.svn.wordpress.org/trunk@37060


git-svn-id: http://core.svn.wordpress.org/trunk@37027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-23 00:53:28 +00:00
Dominik Schilling
6c81a0cbf6 Users: In edit_user() check for a blank password when adding a user. 
Props wesleye, gitlost, adamsilverstein.
Fixes #35715.
Built from https://develop.svn.wordpress.org/trunk@37059


git-svn-id: http://core.svn.wordpress.org/trunk@37026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-22 23:07:27 +00:00
Weston Ruter
f3f84d2f21 Customize: Require opt-in for selective refresh of widgets. 
* Introduces `customize-selective-refresh-widgets` theme support feature and adds to themes.
* Introduces `customize_selective_refresh` arg for `WP_Widget::$widget_options` and adds to all core widgets.
* Remove `selective_refresh` from being a component that can be removed via `customize_loaded_components` filter.
* Add `WP_Customize_Widgets::get_selective_refreshable_widgets()` and `WP_Customize_Widgets::is_widget_selective_refreshable()`.
* Fix default `selector` for `Partial` instances.
* Implement and improve Masronry sidebar refresh logic in Twenty Thirteen and Twenty Fourteen, including preservation of initial widget position after refresh.
* Re-initialize ME.js when refreshing `Twenty_Fourteen_Ephemera_Widget`.

See #27355.
Fixes #35855.

Built from https://develop.svn.wordpress.org/trunk@37040


git-svn-id: http://core.svn.wordpress.org/trunk@37007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-21 21:59:29 +00:00
Andrew Ozz
d47a15ed3c Media: fix erroneously inserting a rel attribute in get_image_send_to_editor(). Reverts most of [34259] and [34260] and adds a unit test. 
Props joemcgill, azaozz.
Fixes #36084.
Built from https://develop.svn.wordpress.org/trunk@37035


git-svn-id: http://core.svn.wordpress.org/trunk@37002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-18 20:05:26 +00:00
Dominik Schilling
6a90070793 I18N: Move translatable Codex URLs to separate strings in wp-admin/includes/meta-boxes.php. 
Props ramiy.
Fixes #35751.
Built from https://develop.svn.wordpress.org/trunk@37016


git-svn-id: http://core.svn.wordpress.org/trunk@36983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-16 16:58:26 +00:00
Andrew Ozz
d529800cba Editor: fix exiting DFW with the keyboard shortcut on Mac (Opt+Ctrl+W). 
Fixes #36222.
Built from https://develop.svn.wordpress.org/trunk@37003


git-svn-id: http://core.svn.wordpress.org/trunk@36970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-16 02:48:25 +00:00
John Blackbourn
852f085d19 Docs: The $update_result parameter passed to WP_Automatic_Updater::after_core_update() is never a WP_Error. If an error is returned, the error object lives in the result property of the paramter. 
See #32246

Built from https://develop.svn.wordpress.org/trunk@36995


git-svn-id: http://core.svn.wordpress.org/trunk@36962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-14 22:43:27 +00:00
Sergey Biryukov
138b2abcf5 Media: Fix typo introduced in [36887]. 
Props claudiosanches.
Fixes #36230. See #36089.
Built from https://develop.svn.wordpress.org/trunk@36987


git-svn-id: http://core.svn.wordpress.org/trunk@36954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-14 09:00:28 +00:00
Andrew Ozz
13c885bdce TinyMCE, inline link: 
- Remove unused user setting for wpLink.
- Remove redundant text and variable from wp_link_dialog().

Props afercia, azaozz.
See #33301.
Built from https://develop.svn.wordpress.org/trunk@36985


git-svn-id: http://core.svn.wordpress.org/trunk@36952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-14 01:39:26 +00:00
Eric Lewis
8592072857 Editor: Fix Mac keyboard shortcut for distraction free writing. 
Fixes #36214.

Built from https://develop.svn.wordpress.org/trunk@36973


git-svn-id: http://core.svn.wordpress.org/trunk@36941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-12 17:44:26 +00:00
Andrew Ozz
70ac7ab943 Editor: hide the Move to Trash link for auto-drafts until they are auto-saved. 
Props iseulde.
Fixes #16116.
Built from https://develop.svn.wordpress.org/trunk@36972


git-svn-id: http://core.svn.wordpress.org/trunk@36940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-12 17:22:26 +00:00
Andrew Ozz
91d2354e7c Editor: correct and update the Visual and Text editors description in the screen help. 
Props arush, adamsilverstein, azaozz.
Fixes #35479.
Built from https://develop.svn.wordpress.org/trunk@36971


git-svn-id: http://core.svn.wordpress.org/trunk@36939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-12 16:43:26 +00:00
Dominik Schilling
d8f3325c14 Docs: Correct grammar when referring to "a URL" vs "an URL" in several places. 
Fixes #36218.
Built from https://develop.svn.wordpress.org/trunk@36970


git-svn-id: http://core.svn.wordpress.org/trunk@36938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-12 12:39:27 +00:00
Pascal Birchler
9462ab0576 Taxonomy: After [36874], rename $term_id to $tag_ID in wp-admin/edit-tag-form.php. 
This ensures that no variables changed in the process of introducing `wp-admin/term.php`, improving overall backward compatibility.

Props Chouby for initial patch.
Fixes #34988.
Built from https://develop.svn.wordpress.org/trunk@36969


git-svn-id: http://core.svn.wordpress.org/trunk@36937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-11 08:52:29 +00:00
Andrea Fercia
0020bcd796 Coding standards after [36510]. 
Built from https://develop.svn.wordpress.org/trunk@36967


git-svn-id: http://core.svn.wordpress.org/trunk@36935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-10 23:18:26 +00:00
Andrea Fercia
fd1f45a7cf Accessibility: Improve accessibility for the Plugin details modal. 
The plugin details modal can be invoked from several screens. There's now a new
`.open-plugin-details-modal` CSS class to be used in combination with the
`.thickbox` CSS class that adds everything needed for accessibility.

- Adds an ARIA role `dialog` and an `aria-label` attribute to the modal
- Adds a `title` attribute to the iframe inside the modal
- Constrains tabbing within the modal
- Restores focus back in a proper place when closing the modal

Also, improves a bit the native Thickbox implementation: it should probably be
replaced with some more modern tool but at least keyboard focus should be moved
inside the modal.

Fixes #33305.
Built from https://develop.svn.wordpress.org/trunk@36964


git-svn-id: http://core.svn.wordpress.org/trunk@36932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-10 22:37:26 +00:00