Sergey Biryukov
0d2ce875d7
Tests: Use more appropriate assertions in various tests.
...
This replaces instances of `assertTrue( is_object( ... ) )` with `assertIsObject()` to use native PHPUnit functionality.
Follow-up to [51331], [51335].
See #53363 .
Built from https://develop.svn.wordpress.org/trunk@51337
git-svn-id: http://core.svn.wordpress.org/trunk@50946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-06 12:32:57 +00:00
Sergey Biryukov
5bef1b8001
Tests: Use more appropriate assertions in various tests.
...
This replaces instances of `assertTrue( is_array( ... ) )` with `assertIsArray()` to use native PHPUnit functionality.
Follow-up to [51331].
See #53363 .
Built from https://develop.svn.wordpress.org/trunk@51335
git-svn-id: http://core.svn.wordpress.org/trunk@50944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-06 12:26:56 +00:00
Sergey Biryukov
7a836ad413
Tests: Move loading compatibility layers for PHPUnit 6+ and 7.5+ closer together.
...
Follow-up to [40536], [44701], [50986].
See #53363 .
Built from https://develop.svn.wordpress.org/trunk@51333
git-svn-id: http://core.svn.wordpress.org/trunk@50942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-06 11:35:00 +00:00
Aaron Jorbin
228f2d9d39
Update the IRC link from Freenode to Libera.chat.
...
Update follows the update to https://make.wordpress.org/support/handbook/appendix/other-support-locations/introduction-to-irc/ .
Fixes #53590 .
Props empatogen, audrasjb.
Built from https://develop.svn.wordpress.org/trunk@51332
git-svn-id: http://core.svn.wordpress.org/trunk@50941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-05 19:31:59 +00:00
Sergey Biryukov
94c6df96bc
Build/Test Tools: Replace assertInternalType()
usage in unit tests.
...
The `assertInternalType()` and `assertNotInternalType()` methods are deprecated in PHPUnit 8 and removed in PHPUnit 9.
While WordPress test suite currently only supports PHPUnit up to 7.5.x, this allows us to switch to newer assertions ahead of adding full support for PHPUnit 8+.
These methods introduced in PHPUnit 7.5 should be used as an alternative:
* `assertIsArray()`
* `assertIsBool()`
* `assertIsFloat()`
* `assertIsInt()`
* `assertIsNumeric()`
* `assertIsObject()`
* `assertIsResource()`
* `assertIsString()`
* `assertIsScalar()`
* `assertIsCallable()`
* `assertIsIterable()`
* `assertIsNotArray()`
* `assertIsNotBool()`
* `assertIsNotFloat()`
* `assertIsNotInt()`
* `assertIsNotNumeric()`
* `assertIsNotObject()`
* `assertIsNotResource()`
* `assertIsNotString()`
* `assertIsNotScalar()`
* `assertIsNotCallable()`
* `assertIsNotIterable()`
As WordPress currently uses PHPUnit 5.7.x to run tests on PHP 5.6, polyfills for these methods are now added to the `WP_UnitTestCase` class for PHPUnit < 7.5.
Props pbearne, jrf, dd32, SergeyBiryukov.
Fixes #53491 . See #46149 .
Built from https://develop.svn.wordpress.org/trunk@51331
git-svn-id: http://core.svn.wordpress.org/trunk@50940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-05 17:22:57 +00:00
John Blackbourn
2e6a782a5f
Docs: Miscellaneous docblock improvements.
...
See #53399
Built from https://develop.svn.wordpress.org/trunk@51330
git-svn-id: http://core.svn.wordpress.org/trunk@50939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-05 15:48:00 +00:00
Sergey Biryukov
0dadbcab6b
Docs: Correct description for the upgrader_pre_install
filter.
...
Props ilovecats7.
Fixes #53546 .
Built from https://develop.svn.wordpress.org/trunk@51329
git-svn-id: http://core.svn.wordpress.org/trunk@50938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-04 10:06:57 +00:00
Sergey Biryukov
ca92ebece3
Docs: Add @since
tags for WP_Theme
class properties.
...
Document WordPress versions Twenty Twelve and later bundled themes were introduced in.
See #53399 .
Built from https://develop.svn.wordpress.org/trunk@51328
git-svn-id: http://core.svn.wordpress.org/trunk@50937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-04 09:58:58 +00:00
John Blackbourn
efaf4a8938
Docs: Add and correct examples of common names for various dynamic hooks.
...
See #53581
Built from https://develop.svn.wordpress.org/trunk@51327
git-svn-id: http://core.svn.wordpress.org/trunk@50936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-03 21:42:59 +00:00
John Blackbourn
6b78871b4a
Docs: Document common names for dynamic hooks relating to metadata.
...
See #53581
Built from https://develop.svn.wordpress.org/trunk@51326
git-svn-id: http://core.svn.wordpress.org/trunk@50935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-03 21:32:58 +00:00
Sergey Biryukov
39cb388519
Docs: Correct @see
references for hooks in the get_option()
description.
...
Follow-up to [51050].
See #52628 , #53461 .
Built from https://develop.svn.wordpress.org/trunk@51324
git-svn-id: http://core.svn.wordpress.org/trunk@50933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-03 11:31:58 +00:00
Sergey Biryukov
9c0611e9c0
Bundled Themes: Correct @since
tags for block patterns.
...
Follow-up to [49347], [49348], [49583], [49584], [49763], [51103].
See #52628 , #53461 .
Built from https://develop.svn.wordpress.org/trunk@51323
git-svn-id: http://core.svn.wordpress.org/trunk@50932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-03 09:41:58 +00:00
Sergey Biryukov
af7a04318d
Twenty Twenty: Add missing documentation for some filters.
...
Add missing `@since` tags for some functions.
Correct alignment of some `@param` tags.
Follow-up to [46271], [46278], [51304].
See #52628 , #53461 .
Built from https://develop.svn.wordpress.org/trunk@51322
git-svn-id: http://core.svn.wordpress.org/trunk@50931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-03 09:14:58 +00:00
Aaron Jorbin
bf92ee343c
Remove unnecessary function_exists check in get_the_block_template_html
...
WordPress can be confident that WordPress functions exist.
I forgot this function existed.
And I thought that it would fatal, but it didn't
And it was so nice
So peaceful and quiet
I forgot this function existed
It isn't love, it isn't hate, it's just indifference
Introduced in [51003].
Props walbo.
Fixes #53578 . See #53176 .
Built from https://develop.svn.wordpress.org/trunk@51321
git-svn-id: http://core.svn.wordpress.org/trunk@50930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-02 21:52:57 +00:00
desrosj
3e271ba7a7
Editor: Ensure global styles are loaded in the footer when loading core assets individually.
...
This fixes the logic in `wp_enqueue_global_styles()` to ensure that global styles are loaded in the footer when a site opts-in to loading Core block assets individually.
This fixes a bug where styles defined in `themes.json` are not respected.
Props walbo, nosolosw, mcsf, aristath, desrosj.
Fixes #53494 .
Built from https://develop.svn.wordpress.org/trunk@51309
git-svn-id: http://core.svn.wordpress.org/trunk@50918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-02 18:47:58 +00:00
desrosj
bc5908011b
Editor: Ensure the Query block pattern category is translatable.
...
Because the `__()` translation function was used here, the Query block pattern category string is not translatable. `_x()` is the correct function here as that passes the second parameter as context and not text domain.
Follow up to [50948].
Props walbo.
Fixes #53577 .
Built from https://develop.svn.wordpress.org/trunk@51307
git-svn-id: http://core.svn.wordpress.org/trunk@50916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-02 14:35:58 +00:00
desrosj
433448f1d8
Editor: Remove the experimental experimental-link-color
feature.
...
This has been plugin only so far and should remain so.
Follow up to [50959].
Props nosolosw.
Fixes #53175 .
Built from https://develop.svn.wordpress.org/trunk@51306
git-svn-id: http://core.svn.wordpress.org/trunk@50915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-02 13:02:58 +00:00
Sergey Biryukov
d0c596c992
Twenty Twenty-One: Add missing documentation for some filters.
...
Add missing `@since` tags for some functions.
Follow-up to [49216], [49220], [49854], [51294].
See #52628 , #53461 .
Built from https://develop.svn.wordpress.org/trunk@51304
git-svn-id: http://core.svn.wordpress.org/trunk@50913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-02 08:57:57 +00:00
Sergey Biryukov
7ec8606aeb
Docs: Correct description for the $image
parameter of the wp_save_image_file
filter.
...
Follow-up to [27357], [48798], [51302].
See #53399 .
Built from https://develop.svn.wordpress.org/trunk@51303
git-svn-id: http://core.svn.wordpress.org/trunk@50912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-02 07:11:58 +00:00
John Blackbourn
ec4eb88e0f
Docs: Further type corrections and improvements for various docblocks.
...
See #53399
Built from https://develop.svn.wordpress.org/trunk@51302
git-svn-id: http://core.svn.wordpress.org/trunk@50911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-01 22:02:57 +00:00
John Blackbourn
e4cfebe92e
Docs: Undo the accidental revert of [51299] made in [51300].
...
See #53399
Built from https://develop.svn.wordpress.org/trunk@51301
git-svn-id: http://core.svn.wordpress.org/trunk@50910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-01 21:29:56 +00:00
John Blackbourn
ea60cd8191
Docs: Descriptive improvements and corrections for various docblocks.
...
See #53399
Built from https://develop.svn.wordpress.org/trunk@51300
git-svn-id: http://core.svn.wordpress.org/trunk@50909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-01 21:12:58 +00:00
John Blackbourn
9146628ae1
Docs: Miscellaneous formatting corrections for docblocks.
...
See #53399
Built from https://develop.svn.wordpress.org/trunk@51299
git-svn-id: http://core.svn.wordpress.org/trunk@50908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-01 21:10:56 +00:00
John Blackbourn
79685db062
Docs: Corrections and improvements to types used in docblocks for symbols, properties, and filters.
...
See #53399
Built from https://develop.svn.wordpress.org/trunk@51298
git-svn-id: http://core.svn.wordpress.org/trunk@50907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-01 21:02:57 +00:00
John Blackbourn
00a0c0f3d5
Docs: Fix the documentation for the $tests
parameter of the site_status_tests
filter.
...
Tests are contained within `direct` and `async` properties of this array, not directly in the array itself. This also clarifies the properties that differ between direct and async tests.
See #53399 , #46573
Built from https://develop.svn.wordpress.org/trunk@51297
git-svn-id: http://core.svn.wordpress.org/trunk@50906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-01 20:37:57 +00:00
desrosj
a54727d936
Twenty Twenty-One: Ensure the dropdown arrow displays for <select>
elements when focused.
...
Props isabel_brison, zieladam, poena.
Fixes #53560 .
Built from https://develop.svn.wordpress.org/trunk@51296
git-svn-id: http://core.svn.wordpress.org/trunk@50905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-01 19:55:58 +00:00
Sergey Biryukov
61b5311c57
Twenty Twenty-One: Improve documentation per the documentation standards:
...
* Remove unnecessary `@access` tags that were previously removed from core.
* Remove an empty line between `@param` and `@return` tags.
* Correct alignment of `@param` tags.
Follow-up to [41161], [41162], [41168], [49216], [49220].
See #52628 , #53461 .
Built from https://develop.svn.wordpress.org/trunk@51294
git-svn-id: http://core.svn.wordpress.org/trunk@50903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-01 12:59:57 +00:00
Sergey Biryukov
4871e33916
Docs: Correct documentation for rest_{$post_type}_query
and rest_{$taxonomy}_query
filters.
...
Synchronize documentation for related `rest_{$object_type}_query` filters for consistency.
Props dlh.
Fixes #53568 .
Built from https://develop.svn.wordpress.org/trunk@51293
git-svn-id: http://core.svn.wordpress.org/trunk@50902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-01 09:12:59 +00:00
Sergey Biryukov
d999568ae4
Docs: Improve documentation for optional parameters in WP_Theme_JSON
methods per the documentation standards.
...
Additionally:
* Remove an empty line between `@param` and `@return` tags.
* Correct alignment of `@param` tags.
Follow-up to [50959], [50973], [51149], [51284], [51289].
See #52628 , #53461 .
Built from https://develop.svn.wordpress.org/trunk@51292
git-svn-id: http://core.svn.wordpress.org/trunk@50901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 19:00:58 +00:00
Sergey Biryukov
1b749d971a
Docs: Remove an empty line between @param
and @return
tags in some newly added REST API methods, per the documentation standards.
...
Follow-up to [48242], [49925], [51003], [51021].
See #52628 , #53461 .
Built from https://develop.svn.wordpress.org/trunk@51289
git-svn-id: http://core.svn.wordpress.org/trunk@50898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 18:43:58 +00:00
desrosj
9e3049477c
Script Loader: Revert [51267].
...
This was missed in [51268] when reverting [51259-51260,51265].
Props pbiron.
See #53397 .
Built from https://develop.svn.wordpress.org/trunk@51288
git-svn-id: http://core.svn.wordpress.org/trunk@50897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 18:26:03 +00:00
Sergey Biryukov
df662d1e24
Coding Standards: Add missing visibility keywords to WP_Theme
, WP_Theme_JSON
, and WP_Theme_JSON_Resolver
tests.
...
Follow-up to [50959], [50960], [50967].
See #52627 .
Built from https://develop.svn.wordpress.org/trunk@51287
git-svn-id: http://core.svn.wordpress.org/trunk@50896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 18:22:57 +00:00
Sergey Biryukov
8f4593b124
Docs: List the expected type first instead of WP_Error
in some REST API methods added in 5.8.
...
Follow-up to [46696], [49929], [50995], [51021].
See #52628 , #53461 .
Built from https://develop.svn.wordpress.org/trunk@51286
git-svn-id: http://core.svn.wordpress.org/trunk@50895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 17:59:58 +00:00
Sergey Biryukov
e7b6a4dce8
Coding Standards: Remove redundant type casting to array in WP_Query::get_posts()
.
...
This brings some consistency with other instances of using `get_post_stati()` in core.
`get_post_stati()` always returns an array, so the type casting is not needed.
Follow-up to [13172].
See #53359 .
Built from https://develop.svn.wordpress.org/trunk@51285
git-svn-id: http://core.svn.wordpress.org/trunk@50894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 17:44:58 +00:00
Sergey Biryukov
a58c86abd8
Docs: Improve documentation for optional parameters in WP_Theme_JSON_Resolver
methods per the documentation standards.
...
Move `add_action()` call to `wp-includes/default-filters.php`.
Follow-up to [50959], [51221].
See #52628 , #53461 .
Built from https://develop.svn.wordpress.org/trunk@51284
git-svn-id: http://core.svn.wordpress.org/trunk@50893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 17:20:58 +00:00
Sergey Biryukov
40ff2751bc
Docs: Add missing @since
tags for some WP_Theme_JSON
methods.
...
Docs: Update syntax for multi-line comments per the documentation standards.
Follow-up to [50959], [50967], [50973], [51051], [51089], [51149].
See #52628 , #53461 .
Built from https://develop.svn.wordpress.org/trunk@51283
git-svn-id: http://core.svn.wordpress.org/trunk@50892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 16:23:57 +00:00
Sergey Biryukov
b10b4a2586
Docs: Adjust wp_dashboard_browser_nag()
DocBlock per the documentation standards.
...
Follow-up to [51117], [51119], [51120].
See #52628 , #53461 .
Built from https://develop.svn.wordpress.org/trunk@51282
git-svn-id: http://core.svn.wordpress.org/trunk@50891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 16:07:57 +00:00
Sergey Biryukov
7884c33821
Docs: Add @ticket
references to some WP_Theme_JSON
tests.
...
Follow-up to [50973], [51054].
See #52628 , #53461 .
Built from https://develop.svn.wordpress.org/trunk@51281
git-svn-id: http://core.svn.wordpress.org/trunk@50890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 15:59:58 +00:00
Sergey Biryukov
598c337f4b
Docs: Add missing @since
tags for some REST API methods added in 5.8.
...
Follow-up to [50995], [51021].
See #52628 , #53461 .
Built from https://develop.svn.wordpress.org/trunk@51280
git-svn-id: http://core.svn.wordpress.org/trunk@50889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 13:58:59 +00:00
Sergey Biryukov
a2f00a677c
Docs: Document the globals used in WP_REST_Widget_Types_Controller
and WP_REST_Widgets_Controller
.
...
Follow-up to [50995].
See #52628 , #53461 .
Built from https://develop.svn.wordpress.org/trunk@51279
git-svn-id: http://core.svn.wordpress.org/trunk@50888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 12:55:57 +00:00
Sergey Biryukov
d72eb14abf
Docs: Document the globals used in some REST API methods.
...
See #53399 .
Built from https://develop.svn.wordpress.org/trunk@51278
git-svn-id: http://core.svn.wordpress.org/trunk@50887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 12:34:56 +00:00
Sergey Biryukov
ffafbefc36
REST API: Allow multiple widgets to be deleted in a single batch request.
...
This resets the `WP_Widget::$updated` flag when deleting a widget, to avoid blocking all future updates in a request.
Props noisysocks, andraganescu.
Fixes #53557 .
Built from https://develop.svn.wordpress.org/trunk@51277
git-svn-id: http://core.svn.wordpress.org/trunk@50886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 10:41:58 +00:00
Peter Wilson
4c598d36b1
Query: Check each post-type's capabilities when querying multiple post-types.
...
When querying multiple post types, check the `read_private_posts` capability for each post type when determining which post statuses to return. This ensures private posts appear in search results and archives for users permitted to read them.
Props leogermani, hellofromTonya, jeffpaul, peterwilsoncc.
Fixes #48556 .
Built from https://develop.svn.wordpress.org/trunk@51276
git-svn-id: http://core.svn.wordpress.org/trunk@50885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 05:00:56 +00:00
desrosj
7344160c11
Security: Add 5.8 to the list of versions receiving security updates.
...
Built from https://develop.svn.wordpress.org/trunk@51274
git-svn-id: http://core.svn.wordpress.org/trunk@50883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 04:02:57 +00:00
desrosj
a610e9675b
Build/Test Tools: Add the 5.8 branch to the workflow for testing branches.
...
Built from https://develop.svn.wordpress.org/trunk@51273
git-svn-id: http://core.svn.wordpress.org/trunk@50882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 03:58:58 +00:00
desrosj
4f26a88360
Post branching 5.8 version bump.
...
`trunk` is now `5.9-alpha`.
Built from https://develop.svn.wordpress.org/trunk@51272
git-svn-id: http://core.svn.wordpress.org/trunk@50881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 03:55:56 +00:00
desrosj
2c1f2bf1e4
Post WordPress 5.8 RC1 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@51270
git-svn-id: http://core.svn.wordpress.org/trunk@50879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 03:44:58 +00:00
desrosj
77d0f6114f
WordPress 5.8 RC1.
...
Built from https://develop.svn.wordpress.org/trunk@51269
git-svn-id: http://core.svn.wordpress.org/trunk@50878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 03:16:56 +00:00
desrosj
8c3e1e9aa8
Build/Test Tools: Revert [51259-51256,51265].
...
[51259] introduced a PHP notice that was not actually fixed by [51265]. Reverting these changes in order to investigate further.
See #53397 .
Built from https://develop.svn.wordpress.org/trunk@51268
git-svn-id: http://core.svn.wordpress.org/trunk@50877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 02:14:56 +00:00
desrosj
e7387a9ace
Script Loader: Fix PHP notice caused by the viewScript
for the core/file
block.
...
This fixes a PHP notice caused by the `viewScript` for the `core/file` block having `.min.js` instead of just `.js`.
`register_block_script_handle()` was incorrectly looking for `view.min.asset.php`, which does not exist, and caused the `_doing_it_wrong()` notice.
This adds a check for `.min.js` in the `viewScript` field of `block.json` and corrects it to `.js` in order to match the expected pattern of `view.asset.php` until a more permanent fix can be created.
Follow up to [51259].
Props ipstenu, pbiron, peterwilsoncc.
See #53397 .
Built from https://develop.svn.wordpress.org/trunk@51267
git-svn-id: http://core.svn.wordpress.org/trunk@50876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-30 01:46:57 +00:00