Commit Graph

49131 Commits

Author SHA1 Message Date
Joe McGill
5f2e2f85f7 Docs: Improve docblock for WP_Block_Patterns_Registry::register.
This documents the new `filePath` property supported by `WP_Block_Patterns_Registry::register` and also updates the property name to camel case formatting to be consistent with other block pattern properties.

Props thekt12, spacedmonkey, joemcgill.
See #59532.

Built from https://develop.svn.wordpress.org/trunk@57731


git-svn-id: http://core.svn.wordpress.org/trunk@57232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 21:05:11 +00:00
Aaron Jorbin
845a537170 Site Icon/Customizer: Update strings in customizer to align with options-general.php.
This uses the new strings for alt text and site icon description that were introduced in [57713] as a part of #54370.

The strings are translated in PHP and then use `wp.i18n.sprintf` since the alt text strings live in a PHP file even though they are output as part of a template that is used in JavaScript.

Props westonruter, swissspidy, jorbin.
Fixes #60641.

Built from https://develop.svn.wordpress.org/trunk@57730


git-svn-id: http://core.svn.wordpress.org/trunk@57231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 20:21:14 +00:00
Pascal Birchler
023f523bda Build/Test Tools: Add unit tests for _delete_option_fresh_site().
Props pbearne, costdev, desrosj.
Fixes #57191.
Built from https://develop.svn.wordpress.org/trunk@57729


git-svn-id: http://core.svn.wordpress.org/trunk@57230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 19:09:04 +00:00
Pascal Birchler
a871d84dec Build/Test Tools: Add unit tests for maybe_hash_hex_color().
Props pbearne.
Fixes #60272.
Built from https://develop.svn.wordpress.org/trunk@57728


git-svn-id: http://core.svn.wordpress.org/trunk@57229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 18:53:05 +00:00
Pascal Birchler
0a5ac751d2 Build/Test Tools: Add unit tests for sanitize_hex_color_no_hash().
Props pbearne.
Fixes #60271.
Built from https://develop.svn.wordpress.org/trunk@57727


git-svn-id: http://core.svn.wordpress.org/trunk@57228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 18:51:04 +00:00
Pascal Birchler
49bc4f9e77 Build/Test Tools: Add unit tests for sanitize_hex_color().
Props pbearne.
Fixes #60270.
Built from https://develop.svn.wordpress.org/trunk@57726


git-svn-id: http://core.svn.wordpress.org/trunk@57227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 18:49:12 +00:00
Pascal Birchler
69a2411a72 Build/Test Tools: Add unit tests for wp_parse_slug_list().
Props pbearne.
Fixes #60217.
Built from https://develop.svn.wordpress.org/trunk@57725


git-svn-id: http://core.svn.wordpress.org/trunk@57226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 17:17:09 +00:00
Pascal Birchler
4d821203f6 Build/Test Tools: Add unit tests for absint().
Props pbearne.
Fixes #60101.
Built from https://develop.svn.wordpress.org/trunk@57724


git-svn-id: http://core.svn.wordpress.org/trunk@57225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 17:15:13 +00:00
Pascal Birchler
569bff821c Post WordPress 6.5 Beta 3 version bump.
Built from https://develop.svn.wordpress.org/trunk@57723


git-svn-id: http://core.svn.wordpress.org/trunk@57224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 16:26:09 +00:00
Pascal Birchler
3eed37d157 WordPress 6.5 Beta 3.
Built from https://develop.svn.wordpress.org/trunk@57722


git-svn-id: http://core.svn.wordpress.org/trunk@57223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 16:14:11 +00:00
youknowriad
d3204b3e7e Editor: Update Packages with the latest bug fixes for 6.5 beta 3
It includes all the backports from this Gutenberg PR https://github.com/WordPress/gutenberg/pull/59394/

Props get_dave, youknowriad.
See #60315.
Built from https://develop.svn.wordpress.org/trunk@57721


git-svn-id: http://core.svn.wordpress.org/trunk@57222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 14:48:23 +00:00
youknowriad
e88758878e Font face resolver: print font faces from font families defined in all theme.json origins.
This commit updates the theme.json style generation to allow a font family name to be repeated across theme.json origins (default, theme, custom).

Props mmaattiiaass, hellofromtonya, arthur791004, ironprogrammer.
Fixes #60605.
Built from https://develop.svn.wordpress.org/trunk@57720


git-svn-id: http://core.svn.wordpress.org/trunk@57221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 12:06:10 +00:00
Pascal Birchler
4fbb3d6975 Docs: Improve wording and add missing full stops in a few docblocks.
Props shailu25, sabernhardt.
Fixes #60323.
Built from https://develop.svn.wordpress.org/trunk@57719


git-svn-id: http://core.svn.wordpress.org/trunk@57220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 10:29:11 +00:00
Pascal Birchler
139a4c2dc8 Build/Test Tools: Add PHPUnit test for the _mce_set_direction function.
The new test checks the functionality of the text direction setting, ensuring it correctly switches between `rtl` and `ltr` options.

Props pbearne, SergeyBiryukov.
Fixes #60219.
Built from https://develop.svn.wordpress.org/trunk@57718


git-svn-id: http://core.svn.wordpress.org/trunk@57219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 10:25:05 +00:00
Pascal Birchler
29a2c3a05a Editor: add shadow.defaultPresets to appearance tools opt-ins.
Props madhudollu.
Fixes #60633.
Built from https://develop.svn.wordpress.org/trunk@57717


git-svn-id: http://core.svn.wordpress.org/trunk@57218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 10:22:11 +00:00
youknowriad
9f0595ab4a Editor: Check for null values in Theme JSON to cater for blockGap.
When resolving theme.json preset variables, add a check to make sure the value is not empty before we run it through strpos() and preg_match_all().

Props ramonopoly, mukesh27, get_dave.
Fixes #60613.
Built from https://develop.svn.wordpress.org/trunk@57716


git-svn-id: http://core.svn.wordpress.org/trunk@57217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 10:15:13 +00:00
ryelle
f274631e5c Help/About: Update the About page for 6.5.
Introducing the new content & design for the 6.5 About page & related pages. This style is simplified, with no header images, and brings back the illustrations from previous versions for Contribute, Freedoms, and Privacy.

This also includes a fix for heading hierarchy on the Get Involved page.

Props laurlittle, dansoschin, benjamin_zekavica, richtabor, joen, annezazu, swissspidy, marybaum, ryelle, huzaifaalmesbah.
See #60303.


Built from https://develop.svn.wordpress.org/trunk@57715


git-svn-id: http://core.svn.wordpress.org/trunk@57216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-26 23:51:12 +00:00
Pascal Birchler
8cdbaf4aeb Upgrade/Install: Improve localized strings related to plugin/theme installation and activation.
Adds context to strings where applicable to disambiguate them, coherently throughout the admin. Also improves some of the strings introduced in [57545] to ease localization.

Props swissspidy, costdev.
Fixes #60630. See #22316.
Built from https://develop.svn.wordpress.org/trunk@57714


git-svn-id: http://core.svn.wordpress.org/trunk@57215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-26 20:35:08 +00:00
Aaron Jorbin
7173bb9a94 Site icon: Polish up Site Icon on the general settings screen.
This fixes a number of issues, chief among them:
- Updates to the site title are reflected in the preview.
- Improve alt text for preview
- Make string describing site icon more succinct.
- Add inline documentation to JavaScript

Props kebbet, jorbin, swissspidy, afercia, mukesh27, alexstine, jameskoster, andraganescu.
Fixes #54370.


Built from https://develop.svn.wordpress.org/trunk@57713


git-svn-id: http://core.svn.wordpress.org/trunk@57214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-26 20:18:09 +00:00
Sergey Biryukov
0eb0449db0 Twenty Nineteen: Further adjust CSS selectors used to change the primary color.
This aims to make the file, button, quote, pullquote, and search block selectors work on multiple WordPress versions.

Follow-up to [57637].

Props poena, mukesh27.
Fixes #59922.
Built from https://develop.svn.wordpress.org/trunk@57712


git-svn-id: http://core.svn.wordpress.org/trunk@57213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-26 16:27:12 +00:00
Pascal Birchler
60b72e87d7 Login and Registration: Slash email address when updating an existing user.
Addresses an issue with password reset keys when the email address contains special characters such as apostrophes.

Props emirpprime, rajinsharwar, fnpen, hellofromTonya, oglekler, nicolefurlan.
Fixes #52529.
Built from https://develop.svn.wordpress.org/trunk@57711


git-svn-id: http://core.svn.wordpress.org/trunk@57212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-26 10:43:06 +00:00
Pascal Birchler
4096795c61 Tests: Update incorrect assertion message added in [57366].
Props david.binda.
Fixes #60358.
Built from https://develop.svn.wordpress.org/trunk@57710


git-svn-id: http://core.svn.wordpress.org/trunk@57211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-26 10:29:13 +00:00
joedolson
28c8ff0d1b Code Standards: Fix alignment in tests.
Fix variable alignment in changed tests. Follow-up to [r57708]. Because I edited the wrong local copy when I fixed that.

Props joedolson.
See #34668.
Built from https://develop.svn.wordpress.org/trunk@57709


git-svn-id: http://core.svn.wordpress.org/trunk@57210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-26 01:00:09 +00:00
joedolson
059878b96d Toolbar: Accessibility: Keyboard navigation for screen readers.
Change the admin toolbar to have `role="menu"` and support opening for screen readers. Remove screen reader only log out link and collapse duplicate profile links into one link. This is an imperfect solution to a complex problem in the adminbar, but the lack of screen reader access to submenus is a major accessibility problem, and this fix provides access, even if the mechanism is imperfect.

Screen reader log out added in [21452].

Props abletec, Cheffheid, sabernhardt, alexstine, joedolson, afercia, sparklingrobots, danieltj, swissspidy, netweb, dionysous.
Fixes #34668, #43633.
Built from https://develop.svn.wordpress.org/trunk@57708


git-svn-id: http://core.svn.wordpress.org/trunk@57209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-26 00:52:10 +00:00
Peter Wilson
25ae4b9733 Upgrade/Install: Normalize major versions in is_wp_version_compatible().
Modify `is_wp_version_compatible()` to return the expected result for major WordPress versions formatted as either `x.x` or `x.x.0` (for example `6.5` and `6.5.0`).

The WordPress project currently documents major version numbers in both formats leading to confusion for developers using the `is_wp_version_compatible()` function. As the PHP function `version_compare()` treats `x.x` and `x.x.0` as different version numbers this leads to unexpected results in the WP function.

This change removes a trailing `.0` from major version numbers to account for the WordPress project using the two formats interchangeably.

Props afragen, azaozz, costdev, joemcgill, jorbin, kkmuffme, sessioncookiemonster, swissspidy, wazeter.
Fixes #59448.

Built from https://develop.svn.wordpress.org/trunk@57707


git-svn-id: http://core.svn.wordpress.org/trunk@57208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-25 22:17:13 +00:00
Sergey Biryukov
448030d355 Tests: Use assertSame() in new_admin_email_subject filter test.
This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.

Follow-up to [57283].

See #59655.
Built from https://develop.svn.wordpress.org/trunk@57706


git-svn-id: http://core.svn.wordpress.org/trunk@57207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-25 15:27:12 +00:00
Sergey Biryukov
08d311ae83 Tests: Use assertSame() in comment_exists() tests.
This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.

Follow-up to [34456], [34460].

Props costdev.
See #59655.
Built from https://develop.svn.wordpress.org/trunk@57705


git-svn-id: http://core.svn.wordpress.org/trunk@57206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-24 19:30:12 +00:00
Pascal Birchler
f5487209cb I18N: Do not set translation controller locale in bootstrap.
Removes the `WP_Translation_Controller::set_locale()` call from `wp-settings.php`, which happened before the current user was loaded.
That caused translations to be missing when the site locale and user locale were different, as the translation was associated with the wrong locale.

Turns out this call was not needed at all, as the locale will be set/updated when calling `load_textdomain()` anyway.

Props oglekler.
See #59656.
Built from https://develop.svn.wordpress.org/trunk@57704


git-svn-id: http://core.svn.wordpress.org/trunk@57205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-24 09:48:13 +00:00
Joe McGill
c5f64356af Editor: Improve PHPUnit tests for block pattern registration.
This is a followup to [57683], which adds additional unit test coverage to ensure block pattern content is not loaded from files during registration, but instead when those patterns are accessed. This also improves the `set_up` and `tear_down` methods for the `Tests_Blocks_wpBlockPattersRegistry` test class to ensure that any modifications made to registered blocks during the tests are reset after each test.

Props thekt12, joemcgill.
See #59532.

Built from https://develop.svn.wordpress.org/trunk@57703


git-svn-id: http://core.svn.wordpress.org/trunk@57204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-23 16:55:13 +00:00
Pascal Birchler
bad9e9669d Build/Test Tools: Update JSHint config to remove deprecated options.
Removes deprecated options that no longer have any effect, and updates the targeted ES version in line with WordPress’ browser support.

This change mostly allows new code to properly use trailing commas, as added by the Prettier formatter.

Future efforts should rather go towards adopting ESLint for code formatting, see #31823.

Props netweb.
Fixes #28236.
Built from https://develop.svn.wordpress.org/trunk@57702


git-svn-id: http://core.svn.wordpress.org/trunk@57203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-23 10:38:13 +00:00
Sergey Biryukov
096df041b6 Docs: Add a @since note for $preferred_ext parameter in wp_mime_type_icon().
Follow-up to [57687].

See #31352.
Built from https://develop.svn.wordpress.org/trunk@57701


git-svn-id: http://core.svn.wordpress.org/trunk@57202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-23 09:43:12 +00:00
gziolo
4084114eab Editor: Add id to the supported Image's binding attributes
Syncs changes from the Gutenberg plugin: https://github.com/WordPress/gutenberg/pull/59194.

Fixes #60577.
Props kevin940726, ankit-k-gupta, sonali844, harshalkadu, gziolo.


Built from https://develop.svn.wordpress.org/trunk@57700


git-svn-id: http://core.svn.wordpress.org/trunk@57201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-23 09:20:12 +00:00
K. Adam White
9a3210759f Script Loader: Inject wp_remove_surrounding_empty_script_tags function name in returned error string using sprintf.
The name of this function should not be editable by the translator in the internationalized return error string.

Props naoki0h, swissspidy, kirasong.
Fixes #60590.

Built from https://develop.svn.wordpress.org/trunk@57699


git-svn-id: http://core.svn.wordpress.org/trunk@57200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-23 05:45:12 +00:00
hellofromTonya
648cab6abe General: Handle missing field in WP_List_Util::pluck().
Handles when the `$field` (i.e. key or property) is missing in one of the `$input_list` items by checking the key (array) or property (object) exists before using it for assignment.

Resolves the following bugs:

* a PHP warning for undefined key|property.
* `null` being set for that array or object within the returned list.

The changes resolve the issues in both `WP_List_Util::pluck()` (if invoked directly) and `wp_list_pluck()`.

Also includes an additional test for the scenario where the `wp_list_pluck()` `$index_key` is not `null`, the `$field` is missing in one of the `$input_list` items.

Follow-up to [55423], [51663], [42527], [38928].

Props iamarunchaitanyajami, davidbinda, hellofromTonya, helgatheviking.
Fixes #59774.
Built from https://develop.svn.wordpress.org/trunk@57698


git-svn-id: http://core.svn.wordpress.org/trunk@57199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-22 21:52:10 +00:00
Pascal Birchler
0006dd82d8 Upgrade/Install: Improve plugin install button appearance.
Fixes a misaligned spinner icon when opening the plugin details information in a new tab rather than the modal, and then installing the plugin in that window.

Props huzaifaalmesbah, zunaid321, swissspidy.
Fixes #60494.
Built from https://develop.svn.wordpress.org/trunk@57697


git-svn-id: http://core.svn.wordpress.org/trunk@57198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-22 18:04:09 +00:00
Pascal Birchler
601999951c Upgrade/Install: Fix upgrade count decrement on Updates page.
Fixes a JavaScript error that caused the update count bubble not to decrement when updating a plugin.

Props nendeb55, swissspidy.
Fixes #60589.
Built from https://develop.svn.wordpress.org/trunk@57696


git-svn-id: http://core.svn.wordpress.org/trunk@57197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-22 17:58:08 +00:00
Pascal Birchler
e86c1971d4 Shortcodes: Fix small typo in inline documentation.
Props shailu25, mukesh27.
Fixes #60603.
Built from https://develop.svn.wordpress.org/trunk@57695


git-svn-id: http://core.svn.wordpress.org/trunk@57196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-22 15:53:13 +00:00
Sergey Biryukov
117fdc548e Coding Standards: Correct alignment in wp_get_attachment_image_src().
This resolves a WPCS warning:
{{{
Equals sign not aligned with surrounding statements
}}}
so that the output of `composer format` is clean.

Follow-up to [57687].

See #59650.
Built from https://develop.svn.wordpress.org/trunk@57694


git-svn-id: http://core.svn.wordpress.org/trunk@57195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-22 11:56:10 +00:00
Pascal Birchler
292af16439 Docs: Improve docblock for $x_redirect_by param in wp_redirect().
The `$x_redirect_by` parameter is supported by `wp_redirect()` and `wp_safe_redirect()` to set the `X-Redirect-By` header.
It can be modified via the `x_redirect_by` filter.

This updates the docblock to clarify that `false` can be passed to disable sending the header, which was previously undocumented behavior.

Props kkmuffme, swissspidy.
Fixes #60209.
Built from https://develop.svn.wordpress.org/trunk@57693


git-svn-id: http://core.svn.wordpress.org/trunk@57194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-22 10:58:12 +00:00
Pascal Birchler
299b8ee2a1 Docs: Use more inclusive term in rest_filter_response_fields docblock.
See #59651.
Built from https://develop.svn.wordpress.org/trunk@57692


git-svn-id: http://core.svn.wordpress.org/trunk@57193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-22 09:54:08 +00:00
joedolson
f95f3e8334 Media: Fix broken media modal following [57688]
Fix undefined TypeError overlooked in [57688].

Props antpb, swissspidy, joedolson.
Fixes #58973.
Built from https://develop.svn.wordpress.org/trunk@57691


git-svn-id: http://core.svn.wordpress.org/trunk@57192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-21 20:57:12 +00:00
joedolson
83ba8ad091 Twenty Twenty-Three: Update XX-large font-sizes for accessibility.
Update XX-large font-sizes so that the responsive typography meets the minimum ratio between the min and max font-sizes of 0.61 required for accessible responsive typography.

Props mikachan, ryokuhi, poena, dhruvishah2203, joedolson.
Fixes #58603.
Built from https://develop.svn.wordpress.org/trunk@57690


git-svn-id: http://core.svn.wordpress.org/trunk@57191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-21 20:08:06 +00:00
hellofromTonya
5c49b1cc7b Build/Test Tools: Revert r57684.
Changes to the `test_readme_mariadb_version()` test were made in an effort to stabilize the connection tests and CI failures. After the changeset, all multisite tests CI jobs connected and passed, but oddly all single site tests CI jobs repeatedly and consistently failed.

Reverting to unblock the CI jobs while continued investigation happens.

See #59647.
Built from https://develop.svn.wordpress.org/trunk@57689


git-svn-id: http://core.svn.wordpress.org/trunk@57190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-21 20:06:12 +00:00
joedolson
53f5646b75 Media: Prevent Media Library sidebar from showing with no actions.
Fix an issue where the actions sidebar in the media library could appear when there are no relevant actions available.

Props sruthi89, nithi22, ivanzhuck, dhruvishah2203, joemcgill, ukdrahul, joedolson, shailu25.
Fixes #58973.
Built from https://develop.svn.wordpress.org/trunk@57688


git-svn-id: http://core.svn.wordpress.org/trunk@57189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-21 19:46:08 +00:00
joedolson
5fd767d87d Media: Ensure wp_mine_type_icon() returns expected file type.
Add an argument to `wp_mime_type_icon()` to control the file type returned. Following [57638], there are two file formats in the media icons directory. Different systems would pull up different files by default dependent on the order loaded into the cached array, causing intermittent test failures and unpredictable behavior.

Function update allows core usages to always return the `.svg` while maintaining backwards compatibility for any extended usage that expects a `.png`. Follow up to [57638].

Also handles a missed case in media list view.

Props SergeyBiryukov, sabernhardt, joedolson, antpb.
Fixes #31352.
Built from https://develop.svn.wordpress.org/trunk@57687


git-svn-id: http://core.svn.wordpress.org/trunk@57188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-21 19:29:04 +00:00
Pascal Birchler
4ee39b4d76 Editor: Ensure font collection metadata can be properly localized.
Updates `wp_register_font_collection()` and `WP_Font_Collection` so that only font families can be loaded from a file or URL.
All metadata, such as name, description, and list of font categories, needs to be passed directly in PHP so that it can be properly localized.

Props swissspidy, mmaattiiaass, grantmkin, youknowriad.
Fixes #60509.
Built from https://develop.svn.wordpress.org/trunk@57686


git-svn-id: http://core.svn.wordpress.org/trunk@57187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-21 19:27:14 +00:00
Joe McGill
716b7d4d26 Themes: Use original template paths when switching blogs.
This fixes a bug introduced by [57129] and [56635] in which deprecating the previous  `TEMPLATEPATH` and `STYLESHEETPATH` constants in favor of `get_template_directory()` and `get_stylesheet_directory()` functions caused the active theme template path to change when using `switch_to_blog()`.

This introduces a new function, `wp_set_template_globals()`, which is called during the bootstrap process to store the template paths to new globals values `$wp_template_path` and `$wp_stylesheet_path`. This restores behavior to how things worked prior to [56635] but retains the ability for template values to be reset for better testability.

Related #18298, #60025.

Props joemcgill, flixos90, mukesh27, swissspidy, manfcarlo, metropolis_john, jeremyfelt.
Fixes #60290.

Built from https://develop.svn.wordpress.org/trunk@57685


git-svn-id: http://core.svn.wordpress.org/trunk@57186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-21 19:26:08 +00:00
costdev
308a42fe40 Tests: Query mariadb.org instead of mariadb.com in README test.
The `test_readme_mariadb_version()` test method has been experiencing HTTP failures that result in test and CI failures.

This switches to mariadb.org which may result in more stable test runs.

Some additional safety assertions are also included.

Props hellofromTonya, SergeyBiryukov, costdev.
See #59647.
Built from https://develop.svn.wordpress.org/trunk@57684


git-svn-id: http://core.svn.wordpress.org/trunk@57185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-21 19:01:11 +00:00
Joe McGill
f599968388 Editor: Load pattern content only when used.
Previously, the content for all registered patterns would get loaded on each request when the patterns are registered. Instead, this stores the path the pattern file during registration and reads the content the first time the pattern is used, which is a performance optimization.

Props thekt12, spacedmonkey, gziolo, aristath, joemcgill.
Fixes #59532.

Built from https://develop.svn.wordpress.org/trunk@57683


git-svn-id: http://core.svn.wordpress.org/trunk@57184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-21 18:50:07 +00:00
Pascal Birchler
26673814df Script Loader: Fix small typo in wp_remove_surrounding_empty_script_tags docblock.
Props shailu25.
Fixes #60591.
Built from https://develop.svn.wordpress.org/trunk@57682


git-svn-id: http://core.svn.wordpress.org/trunk@57183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-21 18:39:09 +00:00