John Blackbourn
e2a0c6a86d
Improve keyboard control of Edit Selection mode in the media manager.
...
See #29326
Props adamsilverstein
Built from https://develop.svn.wordpress.org/trunk@30374
git-svn-id: http://core.svn.wordpress.org/trunk@30371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-18 03:34:25 +00:00
Scott Taylor
d5a9d63114
Improve wp.media
documentation.
...
Props ericlewis.
See #28459 .
Built from https://develop.svn.wordpress.org/trunk@30245
git-svn-id: http://core.svn.wordpress.org/trunk@30245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 19:39:22 +00:00
Scott Taylor
8fa0755584
Add some docs to wp.media.view.EditorUploader
.
...
Props ericlewis.
See #29951 .
Built from https://develop.svn.wordpress.org/trunk@30234
git-svn-id: http://core.svn.wordpress.org/trunk@30234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 20:48:23 +00:00
Scott Taylor
7eefc4d1e1
JSHint after [30124].
...
Built from https://develop.svn.wordpress.org/trunk@30125
git-svn-id: http://core.svn.wordpress.org/trunk@30125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:38:21 +00:00
Scott Taylor
a6cb067481
JSHint after [30120].
...
Built from https://develop.svn.wordpress.org/trunk@30124
git-svn-id: http://core.svn.wordpress.org/trunk@30124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:35:22 +00:00
Dominik Schilling
2e76a697f6
Fix JSHint errors introduced in [30120].
...
see #30193 .
Built from https://develop.svn.wordpress.org/trunk@30123
git-svn-id: http://core.svn.wordpress.org/trunk@30123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:28:24 +00:00
Scott Taylor
999e0fbd99
Add verbose docs to media-views.js
.
...
Props ericlewis.
See #30193 .
Built from https://develop.svn.wordpress.org/trunk@30120
git-svn-id: http://core.svn.wordpress.org/trunk@30120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 15:20:23 +00:00
Scott Taylor
fb019893f9
In wp.Uploader
, when uploader:ready
is triggered, set ready
to true
on the instance. This allows media workflows to check for an existing uploaded instance when opening.
...
Without this check, workflows might wait for `uploader:ready`, which could already have been fired. This would result in an unresponsive editor dropzone.
Fixes #29689 .
Built from https://develop.svn.wordpress.org/trunk@29917
git-svn-id: http://core.svn.wordpress.org/trunk@29669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 05:54:18 +00:00
Andrew Ozz
7f2f3dcb5d
Media modal: fix reordering of the thumbnails while creating or editing a gallery, props avryl, fixes #29606 for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@29876
git-svn-id: http://core.svn.wordpress.org/trunk@29633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-11 23:24:23 +00:00
Scott Taylor
821f9f40ec
For attachment-compat
fields, show a spinner while wp.media.model.Attachment.saveCompat()
is firing.
...
Fixes #27028 .
Built from https://develop.svn.wordpress.org/trunk@29831
git-svn-id: http://core.svn.wordpress.org/trunk@29595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-03 18:43:20 +00:00
Scott Taylor
d8c913b3f9
Add the date
filter from media grid to the media modal.
...
Props janhenckens, wonderboymusic.
Fixes #28990 .
Built from https://develop.svn.wordpress.org/trunk@29813
git-svn-id: http://core.svn.wordpress.org/trunk@29579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-02 04:32:16 +00:00
Scott Taylor
202ede7696
After [29811], combine 2 if
statements.
...
Built from https://develop.svn.wordpress.org/trunk@29812
git-svn-id: http://core.svn.wordpress.org/trunk@29578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-02 04:16:17 +00:00
Scott Taylor
b885885b67
Media Grid/List Table parity: when MEDIA_TRASH
is true
and trash
is the current filter for the grid, add a second bulk action button: "Delete Selected"
...
Fixes #29742 .
Built from https://develop.svn.wordpress.org/trunk@29811
git-svn-id: http://core.svn.wordpress.org/trunk@29577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-02 04:13:16 +00:00
Scott Taylor
f30266acb9
Media Grid:
...
* In Bulk Edit mode, don't attempt to delete or trash an attachment that doesn't have a `delete` nonce. The subsequent `_requery()` will then properly display the attachment still present in the library.
* Remove all updated models from the selection at the same time to avoid async race conditions. The selection is reset when the grid's `select` mode is deactivated, but this allows this view instance to be more portable.
This fix allows users to set caps on individual attachments without confusing the grid's library. This issue was present for bulk actions in general, had nothing to do with `MEDIA_TRASH` specifically.
Fixes #29597 .
Built from https://develop.svn.wordpress.org/trunk@29755
git-svn-id: http://core.svn.wordpress.org/trunk@29527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-21 18:52:16 +00:00
Sergey Biryukov
9f066b2a1d
Correct some @since values added in [29739].
...
see #28459 .
Built from https://develop.svn.wordpress.org/trunk@29743
git-svn-id: http://core.svn.wordpress.org/trunk@29517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-13 12:18:18 +00:00
Scott Taylor
836e0f8cd5
Add some @since
annotations to media-views.js
.
...
Props DrewAPicture.
See #28459 .
Built from https://develop.svn.wordpress.org/trunk@29739
git-svn-id: http://core.svn.wordpress.org/trunk@29513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-12 03:36:16 +00:00
Sergey Biryukov
39b859c21e
Add 'Unattached' filter for galleries.
...
props pento.
fixes #29329 .
Built from https://develop.svn.wordpress.org/trunk@29722
git-svn-id: http://core.svn.wordpress.org/trunk@29496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-09 07:14:16 +00:00
Andrew Nacin
b0f6b888b9
Media: Avoid repeated thumbnail resizing.
...
props avryl, wonderboymusic, azaozz.
fixes #27423 .
Built from https://develop.svn.wordpress.org/trunk@29686
git-svn-id: http://core.svn.wordpress.org/trunk@29461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-03 06:10:19 +00:00
Andrew Nacin
4cfdb9851f
Media Modal: Fix 'Insert from URL' oEmbed previews.
...
props johnbillion, azaozz.
fixes #29473 .
Built from https://develop.svn.wordpress.org/trunk@29680
git-svn-id: http://core.svn.wordpress.org/trunk@29455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-03 00:37:16 +00:00
Helen Hou-Sandí
7586e15e0d
Media: only apply wp-filter
class to the grid view toolbar.
...
props gcorne.
fixes #29381 .
Built from https://develop.svn.wordpress.org/trunk@29629
git-svn-id: http://core.svn.wordpress.org/trunk@29403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 19:06:15 +00:00
Helen Hou-Sandí
9e8b9a78ca
Media library: Unify headers between view modes.
...
Includes back compat for `views_upload` links. These look a little awkward, but do not appear to be commonly used. Also prevents the view mode links from being dropped on smaller screens so a user doesn't get "stuck" in the list view.
This is different from other list tables, but aligns well with other uploaded content management screens (themes, plugins).
props pento, helen.
fixes #28946 .
Built from https://develop.svn.wordpress.org/trunk@29625
git-svn-id: http://core.svn.wordpress.org/trunk@29399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 15:58:15 +00:00
Dominik Schilling
32030a073f
RTL: Fix modal alignments.
...
* Prevent horizontal scrollbars in Chrome.
* URL fields should be always LTR.
* Force the plugin details to be LTR for all screens, see #19778 .
fixes #29352 .
Built from https://develop.svn.wordpress.org/trunk@29623
git-svn-id: http://core.svn.wordpress.org/trunk@29397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 12:55:16 +00:00
Scott Taylor
80bda02c0f
Media Modal:
...
* the Image Details frame does not have a menu, indicate that by setting `menu: false` when adding states.
* mimic the default router rendering by toggling a `hide-menu` class on the frame when the region for menu is `null`
* remove the dead render code for the Image Details frame
See #29339 .
Built from https://develop.svn.wordpress.org/trunk@29613
git-svn-id: http://core.svn.wordpress.org/trunk@29387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 04:22:16 +00:00
Helen Hou-Sandí
60c6399d1c
Media Grid: Show upload errors above the grid rather than as a popup.
...
props pento, stephdau, helen. fixes #29141 .
Built from https://develop.svn.wordpress.org/trunk@29612
git-svn-id: http://core.svn.wordpress.org/trunk@29386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 04:18:17 +00:00
Andrew Ozz
04e28b468c
Media modal: fix the progress bar in the attachment thumbnail. Props gcorne, fixes #29367
...
Built from https://develop.svn.wordpress.org/trunk@29609
git-svn-id: http://core.svn.wordpress.org/trunk@29383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 22:45:16 +00:00
Scott Taylor
d869fe0603
Media: cleanup recent changes to media.view.FocusManager
.
...
* Adjusts the focus method to target the menu for the current modal
* Refactor the FocusManager so that the method names and the functionality matches more closely with how it currently works. The changes in 4.0 to the FocusManager change the purpose of the focus manager entirely — instead of being a way to save and restore focus state, the new FocusManager is about constraining keyboard navigation via the tab key to inside the modal.
Props gcorne.
See #23560 .
Built from https://develop.svn.wordpress.org/trunk@29602
git-svn-id: http://core.svn.wordpress.org/trunk@29376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 18:23:16 +00:00
Scott Taylor
db0b4c5b4d
Media: when activating a mode after [29056], don't trigger the {mode}:activate
event twice in a row.
...
See #29366 .
Built from https://develop.svn.wordpress.org/trunk@29601
git-svn-id: http://core.svn.wordpress.org/trunk@29375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 18:07:15 +00:00
Scott Taylor
1335ff3e40
Media Grid: Don't make checkboxes tabbable when in bulk select media grid mode, fixes tabbing in bulk select mode.
...
Props adamsilverstein.
See #28822 .
Built from https://develop.svn.wordpress.org/trunk@29585
git-svn-id: http://core.svn.wordpress.org/trunk@29359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:55:15 +00:00
Scott Taylor
d5d0b37c35
Media Grid: restore focus to the selected item when shift-tab away from the attachment details sidebar.
...
Fixes #29303 .
Built from https://develop.svn.wordpress.org/trunk@29584
git-svn-id: http://core.svn.wordpress.org/trunk@29358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:43:16 +00:00
Helen Hou-Sandí
8a545bf05e
Media: Only fire keyboard events for the Attachments view once.
...
Firing them twice was breaking arrow key navigation in media attachment grids.
props gcorne.
fixes #29304 .
Built from https://develop.svn.wordpress.org/trunk@29582
git-svn-id: http://core.svn.wordpress.org/trunk@29356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:17:16 +00:00
Scott Taylor
31e599943d
Media Grid: after [29566], account for Trash and Delete.
...
See #28842 .
Built from https://develop.svn.wordpress.org/trunk@29568
git-svn-id: http://core.svn.wordpress.org/trunk@29342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 04:42:16 +00:00
Scott Taylor
7029af94e7
Media Grid: after completing a Bulk action, switch from select
to edit
mode.
...
Fixes #28842 .
Built from https://develop.svn.wordpress.org/trunk@29566
git-svn-id: http://core.svn.wordpress.org/trunk@29340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 04:20:16 +00:00
Scott Taylor
ca180e2544
Media Grid: don't auto-select attachments upon upload.
...
Props ocean90.
See #28842 .
Built from https://develop.svn.wordpress.org/trunk@29565
git-svn-id: http://core.svn.wordpress.org/trunk@29339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 03:54:14 +00:00
Scott Taylor
8f810cbaa4
media.view.Attachment
: set all of the view attributes in the same hash.
...
See [29299], #23560 .
Built from https://develop.svn.wordpress.org/trunk@29562
git-svn-id: http://core.svn.wordpress.org/trunk@29337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 02:53:14 +00:00
Scott Taylor
6352d703a0
Media Grid/Modal Keyboard navigation improvements:
...
* Add focus to arrows on Next/Previous in the grid's modal on left/right keypress, and add the necessary CSS for `:focus`
* When in a disabled input in the grid modal, allow the left/right keys to work
* Make the image editor return a `$.Deferred` so that there isn't a race condition with UI loading.
* Assign focus when the edit image mode is rendered so that the modal can be closed on Esc press
Props wonderboymusic, adamsilverstein (for the initial patch).
See #23560 .
Built from https://develop.svn.wordpress.org/trunk@29560
git-svn-id: http://core.svn.wordpress.org/trunk@29335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 02:35:17 +00:00
Scott Taylor
557861446f
Cleanup after [29220]:
...
`media.controller.Library` is State/Backbone Model and should not touch views.
See #23560 .
Built from https://develop.svn.wordpress.org/trunk@29558
git-svn-id: http://core.svn.wordpress.org/trunk@29333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 20:00:16 +00:00
Scott Taylor
a43cfb4f96
Cleanup after [29220]:
...
* `media.view.Attachment` should not reach outside itself with global jQuery selectors
* `media.view.Attachment.Details` will re-render when `media.view.Attachment`'s single status changes. Add a `ready` callback to apply initial input focus
See #23560 .
Built from https://develop.svn.wordpress.org/trunk@29556
git-svn-id: http://core.svn.wordpress.org/trunk@29331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 19:29:17 +00:00
Scott Taylor
31bb46d0fc
Initial cleanup after [29220]:
...
* Alter/remove some jQuery global selectors, views should only manage themselves
* Trigger an event for attachments when arrow keys are pressed: `attachment:keydown:arrow`
* `media.view.Attachments` should listen for `attachment:keydown:arrow`
* Favor scoped selectors over globals
See #23560 .
Built from https://develop.svn.wordpress.org/trunk@29555
git-svn-id: http://core.svn.wordpress.org/trunk@29330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 19:14:15 +00:00
Dominik Schilling
9f91625fb6
Insert Media: Don't select a model if it's already selected.
...
props avryl, adamsilverstein.
fixes #29152 .
Built from https://develop.svn.wordpress.org/trunk@29553
git-svn-id: http://core.svn.wordpress.org/trunk@29328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 17:20:15 +00:00
Dominik Schilling
6e0ab38b9e
Media Library: Set max value of columns to 12.
...
fixes #29275 .
Built from https://develop.svn.wordpress.org/trunk@29547
git-svn-id: http://core.svn.wordpress.org/trunk@29323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 16:17:19 +00:00
Dominik Schilling
a28bc71819
Media Modal: Restore to the previous filter and search error message.
...
fixes #28963 .
Built from https://develop.svn.wordpress.org/trunk@29532
git-svn-id: http://core.svn.wordpress.org/trunk@29308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 16:28:19 +00:00
Scott Taylor
29a73daa74
Media Grid: Don't show attachment details in the "sidebar" for errors.
...
Props ocean90.
Fixes #29037 .
Built from https://develop.svn.wordpress.org/trunk@29527
git-svn-id: http://core.svn.wordpress.org/trunk@29303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 02:26:16 +00:00
Scott Taylor
4d20246173
Media Grid: $.when
expects a splat. Disambiguation: change cache
to refresh
as the arg name for _requery()
.
...
See [29490], #29145 .
Built from https://develop.svn.wordpress.org/trunk@29507
git-svn-id: http://core.svn.wordpress.org/trunk@29284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-15 19:00:16 +00:00
Andrew Ozz
81815c4d03
Some pre-commit cleanup of media-grid.js and media-views.js
...
Built from https://develop.svn.wordpress.org/trunk@29494
git-svn-id: http://core.svn.wordpress.org/trunk@29272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-15 01:13:16 +00:00
Scott Taylor
b0c782bf08
Media Grid, support MEDIA_TRASH
: add AYS to bulk actions.
...
See #29145 .
Built from https://develop.svn.wordpress.org/trunk@29492
git-svn-id: http://core.svn.wordpress.org/trunk@29270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-14 19:08:14 +00:00
Scott Taylor
df4cc86671
Media Grid, support MEDIA_TRASH
:
...
* Only use the special `trashAttachment` logic when in `edit-metadata` mode.
* Don't support the `trash` filter in the Add Media modal for now.
* Properly toggle trash/untrash logic in the Attachment Details sidebar
See #29145 .
Built from https://develop.svn.wordpress.org/trunk@29491
git-svn-id: http://core.svn.wordpress.org/trunk@29269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-14 18:51:19 +00:00
Scott Taylor
571111022e
Media Grid, support MEDIA_TRASH
:
...
* Add a setting to `_wpMediaViewsL10n.settings`: `mediaTrash`
* In the attachment edit modal, properly toggle between Trash/Untrash
* In `media.view.Attachment`, add a method for `untrashAttachment`
* When creating the grid toolbar, switch the setting order of subviews so that `media.view.DeleteSelectedButton` can listen to the instance of `media.view.AttachmentFilters.All` to update the text in its UI.
* Add a new filter to `media.view.AttachmentFilters.All`, `trash`, when `settings.mediaTrash` is true
* Allow the cached queries in `Query.get()` to be flushed when race conditions exist and collections need to be refreshed. This is currently only being used when `MEDIA_TRASH` is set, to refresh the filtered/mirrored collections related to `all`, `trash`, and any already queried filter.
* Cleanup the bootstrapping of `media.view.MediaFrame.Manage`
* Allow `wp_ajax_query_attachments()` to return items from the trash when `MEDIA_TRASH` is `true`
* Allow `wp_ajax_save_attachment()` to set `post_status` when `MEDIA_TRASH` is `true`. It allows `wp_delete_post()` to be called, which will trash the attachment instead of deleting when the flag is set.
Props koop for the knowledge sharing and thought partnership.
See #29145 .
Built from https://develop.svn.wordpress.org/trunk@29490
git-svn-id: http://core.svn.wordpress.org/trunk@29268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-14 18:31:19 +00:00
Scott Taylor
9c08ad236a
Media Grid: add Bulk Selection mode for deleting attachments.
...
* Toolbar is sticky when `select` mode is active
* Selection is toggled when clicking an attachment preview
* Unselected attachments fade out, selected fade in.
See #28842 .
Built from https://develop.svn.wordpress.org/trunk@29484
git-svn-id: http://core.svn.wordpress.org/trunk@29262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-13 22:45:15 +00:00
Drew Jaynes
d33c807723
Fix some documentation typos in various core files.
...
Props vlajos.
Fixes #29199 .
Built from https://develop.svn.wordpress.org/trunk@29479
git-svn-id: http://core.svn.wordpress.org/trunk@29257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-13 03:56:17 +00:00
Andrew Ozz
ce14155edf
Media modal: make sure the Close button is focused after attempting to close the onscreen keyboard on touch devices. Props celloexpressions, fixes #29166 .
...
Built from https://develop.svn.wordpress.org/trunk@29473
git-svn-id: http://core.svn.wordpress.org/trunk@29251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-12 21:58:15 +00:00
Andrew Ozz
2f4bd918b2
TinyMCE: fix the 'editimage' plugin for touch devices. Better attempt to hide the onscreen keyboard when the media modal opens and TinyMCE is in focus. See #28595 , #29166
...
Built from https://develop.svn.wordpress.org/trunk@29471
git-svn-id: http://core.svn.wordpress.org/trunk@29249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-12 04:27:18 +00:00
Andrew Ozz
d11bb9bc50
Media at small screens:
...
- Show the image details/settings as an overlay.
- Better styling for the frame drop-down.
- Remove the multi-select by default on the Insert frame.
See #27423
Built from https://develop.svn.wordpress.org/trunk@29452
git-svn-id: http://core.svn.wordpress.org/trunk@29230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-09 05:09:16 +00:00
Andrew Ozz
b8198ecf64
Media: improve the media modal at small screen sizes and make it usable on phones, first run. Part-props gcorne, see #27423 .
...
Built from https://develop.svn.wordpress.org/trunk@29446
git-svn-id: http://core.svn.wordpress.org/trunk@29224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-08 03:46:17 +00:00
Scott Taylor
34e3377d42
JSHint after [29437].
...
Built from https://develop.svn.wordpress.org/trunk@29439
git-svn-id: http://core.svn.wordpress.org/trunk@29217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 21:21:16 +00:00
Scott Taylor
8c96874742
Media Grid:
...
* Use a `media.view.Label` instance in the toolbar for the screen reader text for the "all" dropdown.
* Adjust the spinner's priority.
Fixes #29026 .
Built from https://develop.svn.wordpress.org/trunk@29438
git-svn-id: http://core.svn.wordpress.org/trunk@29216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 21:01:15 +00:00
Scott Taylor
ccd0499d96
Media Grid: use a media.view.Label
instance in the toolbar for the screen reader text for Search.
...
See #29026 .
Built from https://develop.svn.wordpress.org/trunk@29437
git-svn-id: http://core.svn.wordpress.org/trunk@29215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 20:54:15 +00:00
Helen Hou-Sandí
485229bc64
Revert styling changes to the Attachment Details modal from [29289]. fixes #28844 .
...
Built from https://develop.svn.wordpress.org/trunk@29436
git-svn-id: http://core.svn.wordpress.org/trunk@29214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 20:32:16 +00:00
Scott Taylor
8593f7b5e9
Media Grid: add screen reader text in a subview on the toolbar, a media.view.Label
instance before media.view.DateFilter
.
...
See #29026 .
Built from https://develop.svn.wordpress.org/trunk@29435
git-svn-id: http://core.svn.wordpress.org/trunk@29213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 20:25:16 +00:00
Scott Taylor
3f17e7040e
Create a new Backbone view, media.view.Label
, which can be used as a subview in things like toolbars, which need screen reader text.
...
Make an initial instance of it for the label for Bulk Actions in Media Grid.
See #29026 .
Built from https://develop.svn.wordpress.org/trunk@29434
git-svn-id: http://core.svn.wordpress.org/trunk@29212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 20:09:17 +00:00
Scott Taylor
c5dff42d51
Revert [29428] to avoid errors with Add Media for now.
...
See #29026 .
Built from https://develop.svn.wordpress.org/trunk@29432
git-svn-id: http://core.svn.wordpress.org/trunk@29210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 19:40:15 +00:00
Scott Taylor
afb0b3e4ef
Media Grid: add screen reader labels with more context to filters and bulk actions. Ditto for list view.
...
Props afercia.
Fixes #29026 .
Built from https://develop.svn.wordpress.org/trunk@29428
git-svn-id: http://core.svn.wordpress.org/trunk@29206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 05:20:16 +00:00
Scott Taylor
8ed123c97f
In media.view.AttachmentFilters.All
, make uploaded
conditional upon media.view.settings.post.id
and include a new filter: unattached
.
...
Drop the `mime-types` filter and related class (which was added for Media Grid) and use `all` instead.
Props ocean90, wonderboymusic.
Fixes #29065 .
Built from https://develop.svn.wordpress.org/trunk@29426
git-svn-id: http://core.svn.wordpress.org/trunk@29204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 04:44:17 +00:00
Scott Taylor
935f10413e
Media Grid: expose the $.Deffered()
object in media.view.AttachmentsBrowser.updateContent()
so the grid can call Backbone.history.start()
when models actually exist.
...
This is a lot better then `_.delay( this.pray, 1000 )`, but needs continued study.
See #29052 .
Built from https://develop.svn.wordpress.org/trunk@29420
git-svn-id: http://core.svn.wordpress.org/trunk@29198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 21:44:17 +00:00
Scott Taylor
a58a4da852
Media Grid: display upload errors in a dismissable sidebar.
...
See #29037 .
Built from https://develop.svn.wordpress.org/trunk@29415
git-svn-id: http://core.svn.wordpress.org/trunk@29193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 19:13:15 +00:00
Andrew Ozz
8fc01225ac
Media modal/grid: get the proper .attachment width in arrow navigation. Props avryl, see #27423 .
...
Built from https://develop.svn.wordpress.org/trunk@29379
git-svn-id: http://core.svn.wordpress.org/trunk@29157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-05 19:37:15 +00:00
Andrew Ozz
e6b0d0c9ee
Media modal/grid: remove thumbnail resizing from JS, only keep setting number of columns. Props avryl, see #27423 .
...
Built from https://develop.svn.wordpress.org/trunk@29376
git-svn-id: http://core.svn.wordpress.org/trunk@29154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-05 05:20:18 +00:00
Dominik Schilling
e6513fe33b
Media Modal: Restore uploader view, when no items are found.
...
see #28963 .
Built from https://develop.svn.wordpress.org/trunk@29364
git-svn-id: http://core.svn.wordpress.org/trunk@29140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-02 20:47:16 +00:00
Dominik Schilling
fb9084eed3
Disable background page scrolling when modals are open.
...
props celloexpressions.
fixes #29074 .
Built from https://develop.svn.wordpress.org/trunk@29346
git-svn-id: http://core.svn.wordpress.org/trunk@29124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 20:15:15 +00:00
Andrew Ozz
4bff4ff2d6
Use node.nodeName instead of tagName for better consistency/compatibility, see #28704 .
...
Built from https://develop.svn.wordpress.org/trunk@29332
git-svn-id: http://core.svn.wordpress.org/trunk@29112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-30 17:49:16 +00:00
Helen Hou-Sandí
2ca11ebf72
Prevent key event handlers from firing when in input areas in the media modal, as people understandably want to type inside said inputs. props kovshenin. fixes #28704 .
...
Built from https://develop.svn.wordpress.org/trunk@29331
git-svn-id: http://core.svn.wordpress.org/trunk@29111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-30 17:39:15 +00:00
Dominik Schilling
7bbbbe44c7
Media Grid: Improve lazy loading.
...
props kovshenin.
see #24716 .
Built from https://develop.svn.wordpress.org/trunk@29312
git-svn-id: http://core.svn.wordpress.org/trunk@29093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-27 17:58:15 +00:00
Scott Taylor
0e4c8b2b0c
Media Grid: when closing the modal, automatically focus the proper attachment by reading the model's ID, which is unique.
...
Props adamsilverstein (for the red), wonderboymusic (for the green).
Fixes #28857 .
Built from https://develop.svn.wordpress.org/trunk@29299
git-svn-id: http://core.svn.wordpress.org/trunk@29081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-25 01:00:16 +00:00
Scott Taylor
27866228af
Media Grid: UI improvements to Attachment modal.
...
Props ryelle.
See #28844 .
Built from https://develop.svn.wordpress.org/trunk@29289
git-svn-id: http://core.svn.wordpress.org/trunk@29071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 21:55:17 +00:00
Scott Taylor
9382741cbe
Don't render Attachment Display Settings when display
is set to false
. Currently, the value for display
in the media.view.AttachmentsBrowser
instance in the media.view.MediaFrame.Select
frame is set to the value for displaySettings
.
...
These values do different things, so check for the existence of `display` on the state before arbitrarily setting it to the `displaySettings` value.
Real world: this hides display settings when you select an image while editing a Gallery.
Fixes #28653 .
Built from https://develop.svn.wordpress.org/trunk@29285
git-svn-id: http://core.svn.wordpress.org/trunk@29067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 20:58:16 +00:00
Scott Taylor
5be43cfeb1
Media Grid: Manage focus when toggling between the grid and an edit attachment modal
...
Props adamsilverstein for the initial patch.
Fixes #28857 .
Built from https://develop.svn.wordpress.org/trunk@29282
git-svn-id: http://core.svn.wordpress.org/trunk@29064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 19:05:15 +00:00
Helen Hou-Sandí
795c97d08b
Add support for attachment_fields_to_edit
in the attachment details modal. props ericlewis. fixes #28991 , see #24716 .
...
Built from https://develop.svn.wordpress.org/trunk@29278
git-svn-id: http://core.svn.wordpress.org/trunk@29060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-23 22:09:18 +00:00
Dominik Schilling
270a57075c
Media Grid: Add a date filter.
...
props ericlewis.
fixes #28895 .
Built from https://develop.svn.wordpress.org/trunk@29271
git-svn-id: http://core.svn.wordpress.org/trunk@29053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 20:47:15 +00:00
Scott Taylor
0702527010
Media Grid: general JS cleanup.
...
Props ericlewis.
See #28965 .
Built from https://develop.svn.wordpress.org/trunk@29266
git-svn-id: http://core.svn.wordpress.org/trunk@29049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 16:21:15 +00:00
Helen Hou-Sandí
e8ade6be6e
Keyboard accessibility for the media modal:
...
* Arrow keys navigate between items in the grid.
* Transfer focus into the panel when selecting a tab along the side.
* Transfer focus into the details sidebar when selecting an item and vice versa.
* Set initial focus on the close button so that it is visible.
props celloexpressions, lessbloat, ericlewis. fixes #25100 , #25101 , #28704 . see #23560 .
Built from https://develop.svn.wordpress.org/trunk@29220
git-svn-id: http://core.svn.wordpress.org/trunk@29004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-18 07:57:15 +00:00
Helen Hou-Sandí
5267c64e5f
Fix jshint errors introduced in [29212]. see #28842 .
...
Built from https://develop.svn.wordpress.org/trunk@29213
git-svn-id: http://core.svn.wordpress.org/trunk@28997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 20:46:14 +00:00
Helen Hou-Sandí
06f5b5a490
Media Grid:
...
Instead of a separate bulk selection mode, persistently show a checkbox for each item. Restores the more familiar bulk actions dropdown + action button.
props ericlewis. see #28842 .
Built from https://develop.svn.wordpress.org/trunk@29212
git-svn-id: http://core.svn.wordpress.org/trunk@28996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 20:42:15 +00:00
Dominik Schilling
448422f8ae
Media Grid improvements:
...
* Remove fixed elements.
* Adjusts toolbar and search, fixes #28833 .
* Add link to Add New button, fixes #28825 .
* Add "Edit Metadata" tab to all items, "Edit Image" only for images
* Make strings translatable.
* First pass for help tab.
see #28850 .
Built from https://develop.svn.wordpress.org/trunk@29136
git-svn-id: http://core.svn.wordpress.org/trunk@28920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-13 16:16:15 +00:00
Scott Taylor
ba688f4ff9
In the Post/Select frames, for audio files:
...
* Show `artist` and `album` fields in the Attachment Details sidebar
* Sync their values on `change`
See #28839 .
Built from https://develop.svn.wordpress.org/trunk@29105
git-svn-id: http://core.svn.wordpress.org/trunk@28891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-11 21:02:15 +00:00
Scott Taylor
59ffcf668b
Media Grid, for audio files:
...
* Show `artist` and `album` fields in the Edit Attachment modal
* Sync their values on `change`
See #28839 .
Built from https://develop.svn.wordpress.org/trunk@29104
git-svn-id: http://core.svn.wordpress.org/trunk@28890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-11 20:55:15 +00:00
Scott Taylor
c22c49a1ba
Media Grid: "Add New" should open and close, not just open.
...
See #24716 .
Built from https://develop.svn.wordpress.org/trunk@29087
git-svn-id: http://core.svn.wordpress.org/trunk@28873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-11 05:44:14 +00:00
Scott Taylor
9978d473ef
Media Grid: make the Uploader closable.
...
Props ericlewis.
See #24716 .
Built from https://develop.svn.wordpress.org/trunk@29082
git-svn-id: http://core.svn.wordpress.org/trunk@28868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-10 23:06:15 +00:00
Scott Taylor
f6ced74287
Media Grid: while in Bulk Edit mode, any selected attachment should have the blue border, rather than just the last clicked one.
...
Props ericlewis.
See #24716 .
Built from https://develop.svn.wordpress.org/trunk@29081
git-svn-id: http://core.svn.wordpress.org/trunk@28867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-10 23:03:14 +00:00
Scott Taylor
a89060013b
Media Grid: Move toggling of visible fields to Screen Options. This moves us in a better direction... but this will probably need to be massaged again.
...
See #24716 .
Built from https://develop.svn.wordpress.org/trunk@29077
git-svn-id: http://core.svn.wordpress.org/trunk@28863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-10 21:00:17 +00:00
Scott Taylor
7f4716e1c3
Media Grid, add padding to "No Media Found" message.
...
Props michalzuber.
See #24716 .
Built from https://develop.svn.wordpress.org/trunk@29067
git-svn-id: http://core.svn.wordpress.org/trunk@28853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-10 17:31:15 +00:00
Scott Taylor
d297258d99
Media Grid, remove unnecessary abstraction: wp.media.controller._State
...
Props ericlewis.
See #24716 .
Built from https://develop.svn.wordpress.org/trunk@29066
git-svn-id: http://core.svn.wordpress.org/trunk@28852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-10 16:02:15 +00:00
Scott Taylor
dd9bfea6bb
Media Grid: make the edit attachment icon clickable.
...
Props ericlewis.
See #24716 .
Built from https://develop.svn.wordpress.org/trunk@29065
git-svn-id: http://core.svn.wordpress.org/trunk@28851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-10 15:56:15 +00:00
Helen Hou-Sandí
89dff37759
Media grid:
...
* Introduce the concept of bulk editing via a separate mode. Like the list view, only bulk deleting is available. The UI is a little funky, especially with the field display toggles there, but refinements will come.
* Up the max thumbnail size from 120px to 150px.
* Slide-down panel for the add new uploader. Known issue: it doesn't close again.
* Remove the toolbar region in the EditAttachment frame.
* Defer a function call so the grid fills available space.
* Give feedback when no results are found. Also needs styling.
props ericlewis. see #24716 .
Built from https://develop.svn.wordpress.org/trunk@29056
git-svn-id: http://core.svn.wordpress.org/trunk@28844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-10 03:50:17 +00:00
Scott Taylor
9a1ac73c34
Make media grid text fields (data) toggle-able. Checking/unchecking is saved in user settings cookie.
...
See #24716 .
Built from https://develop.svn.wordpress.org/trunk@28995
git-svn-id: http://core.svn.wordpress.org/trunk@28783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-04 04:48:15 +00:00
Helen Hou-Sandí
63f9cbd02a
Media grid, round 2. Expect much more to come.
...
* Instead of a sidebar for details, utilize a modal. The modal experience allows for a larger preview, editing images, audio/video previews, and previous/next navigation, like the theme browser. Think of it as an attachment browser.
* Show some details in the grid view to more easily distinguish items.
props ericlewis, wonderboymusic, JerrySarcastic. see #24716 .
Built from https://develop.svn.wordpress.org/trunk@28993
git-svn-id: http://core.svn.wordpress.org/trunk@28781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-04 03:39:15 +00:00
Scott Taylor
0546378ce8
Make a new file: media-grid.js
. This will be way more useful in later commits and help reduce churn and bloat in media-views.js
.
...
See #24716 .
Built from https://develop.svn.wordpress.org/trunk@28992
git-svn-id: http://core.svn.wordpress.org/trunk@28780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-04 02:18:14 +00:00
Scott Taylor
0510e0e589
Add more docs for media.view.MediaFrame.Select
methods.
...
Props ericlewis.
See #28459 .
Built from https://develop.svn.wordpress.org/trunk@28989
git-svn-id: http://core.svn.wordpress.org/trunk@28777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-04 01:43:17 +00:00
Scott Taylor
6ab2f15b0b
Dynamically prepend screen reader text to the attachment filters dropdown and the search box in the media modal.
...
Props SergeyBiryukov.
Fixes #25102 .
Built from https://develop.svn.wordpress.org/trunk@28839
git-svn-id: http://core.svn.wordpress.org/trunk@28643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-26 01:28:16 +00:00
Scott Taylor
6c3ce75b1c
Race conditions can cause .uploader-window
to be visible with opacity of 0
. It will cause the user to have to refresh the page or inspect the element to hide it. Add a delay in wp.media.view.UploaderWindow.hide()
to ensure that the uploader window is indeed hidden.
...
Props kovshenin.
Fixes #27341 .
Built from https://develop.svn.wordpress.org/trunk@28838
git-svn-id: http://core.svn.wordpress.org/trunk@28642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-26 01:20:15 +00:00
Scott Taylor
43320a5825
wp.mce.embedView.fetch()
and wp.media.view.EmbedLink.fetch()
need to pass the same parameters.
...
Fixes #28532 .
Built from https://develop.svn.wordpress.org/trunk@28816
git-svn-id: http://core.svn.wordpress.org/trunk@28623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-24 00:40:14 +00:00
Scott Taylor
46a4208f6b
Add "edit" mode for [embed]
and URL media previews.
...
See #28532 .
Built from https://develop.svn.wordpress.org/trunk@28752
git-svn-id: http://core.svn.wordpress.org/trunk@28566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-13 21:42:15 +00:00
Sergey Biryukov
5fb95760aa
Fix JSHint error.
...
props avryl.
see #24716 .
Built from https://develop.svn.wordpress.org/trunk@28697
git-svn-id: http://core.svn.wordpress.org/trunk@28514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-08 12:33:16 +00:00
Scott Taylor
1bb24133d9
Improve inline doc descriptions in media-views.js
.
...
Props ericlewis.
See #28459 .
Built from https://develop.svn.wordpress.org/trunk@28688
git-svn-id: http://core.svn.wordpress.org/trunk@28506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-06 14:13:17 +00:00
Helen Hou-Sandí
b5ef672c6b
Grid view for the media library, first pass. This is alpha; expect imperfection. We will be iterating further.
...
props ericlewis, shaunandrews, wonderboymusic.
see #24716 .
Built from https://develop.svn.wordpress.org/trunk@28682
git-svn-id: http://core.svn.wordpress.org/trunk@28500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-05 22:01:18 +00:00
Scott Taylor
5d89ee4b3b
Media modal documentation:
...
Add some clarity to default values for controllers.
Props ericlewis.
See #28459 .
Built from https://develop.svn.wordpress.org/trunk@28675
git-svn-id: http://core.svn.wordpress.org/trunk@28493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-05 14:54:14 +00:00
Helen Hou-Sandí
207bfa43b3
Fix a jshint error introduced in [28607]. see #23560 .
...
Built from https://develop.svn.wordpress.org/trunk@28617
git-svn-id: http://core.svn.wordpress.org/trunk@28441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-29 14:25:14 +00:00
Helen Hou-Sandí
78d90bd443
At long last, improved keyboard accessibility for the media modal.
...
props lessbloat, grahamarmfield, sharonaustin, bramd.
see #23560 .
Built from https://develop.svn.wordpress.org/trunk@28607
git-svn-id: http://core.svn.wordpress.org/trunk@28431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-29 03:39:15 +00:00
Scott Taylor
3c1723afd7
When adding a URL in the Insert from URL
state in the media modal, attempt to show a preview of the content. Drop the unused width and height fields.
...
This will probably be iterated upon.
Props helen, jtsternberg, wonderboymusic.
See #15490 .
Built from https://develop.svn.wordpress.org/trunk@28581
git-svn-id: http://core.svn.wordpress.org/trunk@28406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-26 23:57:14 +00:00
Scott Taylor
746397f18b
Allow the settings view for galleries to be disabled when instantiating wp.media.controller.GalleryEdit
.
...
Props nd987.
Fixes #23116 .
Built from https://develop.svn.wordpress.org/trunk@28577
git-svn-id: http://core.svn.wordpress.org/trunk@28402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-26 22:49:16 +00:00
Scott Taylor
5682d30b6e
In wp.media.view.Settings::update()
, when handling checkboxes, check for a value of 'false'
in addition to casting value
to boolean. !! 'false'
evaluates to true
.
...
Props adamsilverstein.
Fixes #23954 .
Built from https://develop.svn.wordpress.org/trunk@28371
git-svn-id: http://core.svn.wordpress.org/trunk@28199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 07:03:15 +00:00
Andrew Ozz
3eb1616925
Drag/drop on the editor to upload: don't trigger the uploader when selected test is being dragged from one window to another. See #27880 , for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@28189
git-svn-id: http://core.svn.wordpress.org/trunk@28019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-23 20:35:13 +00:00
Scott Taylor
baf754ce35
Use the proper translated string for Video Playlist "drag info" - the text displayed above the playlist's sortable attachments.
...
See #27937 .
Built from https://develop.svn.wordpress.org/trunk@28178
git-svn-id: http://core.svn.wordpress.org/trunk@28009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-21 19:37:14 +00:00
Andrew Nacin
d1e72b8e20
Image Details modal: Remember the last state of the advanced toggle.
...
props gcorne.
fixes #27366 .
Built from https://develop.svn.wordpress.org/trunk@28125
git-svn-id: http://core.svn.wordpress.org/trunk@27956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-14 23:56:16 +00:00
Andrew Ozz
0df02eb8ea
Add hooks to the wpeditimage tinymce plugin and to the image details portion of the media modal.
...
- Add wp.media.events which is intended to be a global media event bus.
- Add a post-render event to the ImageDetails view that third-party code can leverage to add subviews.
- Performance improvement for the initialization of the PostImage model.
- A bit more markup to the image details template to make it easier to add a view to the advanced options.
Props gcorne, fixes #27698
Built from https://develop.svn.wordpress.org/trunk@28095
git-svn-id: http://core.svn.wordpress.org/trunk@27926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-13 04:02:15 +00:00
Scott Taylor
2c963a82f7
Restore GalleryAdd()
and GalleryEdit()
in media-views.js
to ensure back-compat.
...
See [27362].
Built from https://develop.svn.wordpress.org/trunk@28048
git-svn-id: http://core.svn.wordpress.org/trunk@27878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 15:54:14 +00:00
Dominik Schilling
ad278c17e0
Move toolbar
declaration after the :visible
check, like it was before [28019].
...
props kovshenin.
fixes #24859 .
Built from https://develop.svn.wordpress.org/trunk@28046
git-svn-id: http://core.svn.wordpress.org/trunk@27876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 11:21:15 +00:00
Andrew Nacin
c870767d98
Header Images: Add suggested dimensions to the media workflow.
...
This updates [28030] to the latest patch.
props gcorne.
see #21785 .
Built from https://develop.svn.wordpress.org/trunk@28031
git-svn-id: http://core.svn.wordpress.org/trunk@27861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 01:57:16 +00:00
Andrew Nacin
6b41f728d4
Header Images: Add suggested dimensions to the media workflow.
...
props ehg, gcorne.
see #21785 .
Built from https://develop.svn.wordpress.org/trunk@28030
git-svn-id: http://core.svn.wordpress.org/trunk@27860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 01:55:15 +00:00
Helen Hou-Sandí
df49618d0e
Only show the media library loading spinner if we're scrolled toward the bottom. Prevents the spinner from flashing a second time when first loading the library due to a second query firing after initial load.
...
props kovshenin. fixes #24859 .
Built from https://develop.svn.wordpress.org/trunk@28019
git-svn-id: http://core.svn.wordpress.org/trunk@27849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 22:15:15 +00:00
Andrew Nacin
5e79b94d81
Header images: Handle cropping failures.
...
props ehg.
see #21785 .
Built from https://develop.svn.wordpress.org/trunk@27946
git-svn-id: http://core.svn.wordpress.org/trunk@27776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-04 15:48:16 +00:00
Andrew Ozz
a3650b68cd
Edit image modal:
...
- Make the calculation of the aspect ratio more robust.
- Better getting of the image height and width.
Props gcorne, see #27366
Built from https://develop.svn.wordpress.org/trunk@27942
git-svn-id: http://core.svn.wordpress.org/trunk@27772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-04 01:49:15 +00:00
Andrew Ozz
a2e1d9f4c8
Edit Image modal:
...
- Fix issue with adding a link to an image that didn't have one previously.
- Adjust the look-and-feel of the advance options toggle so that it becomes a section heading that can be open/closed.
- Add a Custom Size option to the size drop-down that reveals fields for soft-resizing the image inserted into the post.
Props gcorne, and props sdasse for the design help, see #27366
Built from https://develop.svn.wordpress.org/trunk@27918
git-svn-id: http://core.svn.wordpress.org/trunk@27748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-03 03:21:15 +00:00
Andrew Ozz
668235fb42
Drag and drop files on the editor to upload: add new argument to wp_editor() to enable, fixes #27465
...
Built from https://develop.svn.wordpress.org/trunk@27901
git-svn-id: http://core.svn.wordpress.org/trunk@27732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-02 02:42:16 +00:00
Andrew Ozz
56ede0bad7
Edit Image modal:
...
- Move all advanced options under a single “Show advanced options” toggle that mirrors the behavior and look-and-feel of the wplink modal.
- Switch to using <select> for the Size and Link To.
- Bring back the field for CSS Class for the image, but don’t incorporate the internally managed WordPress classes (size-, wp-image-, etc…).
- On larger screen sizes, float labels to the left. When the width drops below 900px, stack the label above the fields.
- Keep image at top on screen sizes where the two columns are stacked into a single column.
- Don't replace the nodes in the editor DOM so we don't stomp on any custom attributes that the user may have added via the Text editor or some other mechanism.
Props gcorne, see #27366
Built from https://develop.svn.wordpress.org/trunk@27898
git-svn-id: http://core.svn.wordpress.org/trunk@27729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-02 01:54:15 +00:00
Andrew Nacin
e87e153126
Media Manager: Hide 'Create Playlist' menu items until the user has uploaded audio or video.
...
props gcorne.
fixes #27554 .
Built from https://develop.svn.wordpress.org/trunk@27841
git-svn-id: http://core.svn.wordpress.org/trunk@27675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-29 08:02:14 +00:00
Andrew Nacin
e1e7e7dacc
Fix drag-and-drop upload in distraction-free writing.
...
props kovshenin.
fixes #27438 .
Built from https://develop.svn.wordpress.org/trunk@27840
git-svn-id: http://core.svn.wordpress.org/trunk@27674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-29 07:54:15 +00:00
Andrew Ozz
60435c4143
Edit Image modal:
...
- Bring back some of the advanced settings.
- Make the layout two-column for wider screens, remove the sidebar, and shrink the modal a bit.
- The image reflects the size as inserted in the post as long as it doesn't overflow the column and is not too tall. Changing the size to another intermediate will also update the image "preview."
- Rename "Edit Image" to "Edit Original" to try and better communicate that editing the image will modify the media library item not just the image inserted into the post that is being edited.
(updates two PNGs from precommit)
Props gcorne, see #27366
Built from https://develop.svn.wordpress.org/trunk@27797
git-svn-id: http://core.svn.wordpress.org/trunk@27632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 22:41:14 +00:00
Scott Taylor
26773541ab
Make sure Playlist states that are audio
are marked as such with proper localized strings.
...
See #27554 .
Built from https://develop.svn.wordpress.org/trunk@27789
git-svn-id: http://core.svn.wordpress.org/trunk@27625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 18:37:17 +00:00
Andrew Nacin
e1be2d21d8
Avoid JS errors when edit image is not available, such as outside of post editing.
...
props gcorne.
fixes #27551 .
Built from https://develop.svn.wordpress.org/trunk@27787
git-svn-id: http://core.svn.wordpress.org/trunk@27623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 18:15:15 +00:00
Scott Taylor
4f868ad882
There is no more video-playlist
shortcode. To use video, it is now [playlist type="video" ....]
. Also deleting core playlist styles. The style
attribute is still supported, defaulting to light
. Our core style support was 4-5 CSS rules.
...
See #27552 . Leaving open for comments and potential bugs.
Built from https://develop.svn.wordpress.org/trunk@27785
git-svn-id: http://core.svn.wordpress.org/trunk@27621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 17:58:15 +00:00
Andrew Nacin
ed993e4c5c
Properly render the image details modal when the image references an invalid attachment.
...
props gcorne.
fixes #27537 .
Built from https://develop.svn.wordpress.org/trunk@27756
git-svn-id: http://core.svn.wordpress.org/trunk@27593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 22:56:14 +00:00
Scott Taylor
86f4061b26
When an HTML5 fallback button is pressed in the Audio or Video Details state, filter the library by that specific mime-type when the Add Audio|Video Source is activated.
...
See #27389 .
Built from https://develop.svn.wordpress.org/trunk@27658
git-svn-id: http://core.svn.wordpress.org/trunk@27501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-23 03:16:14 +00:00
Scott Taylor
4ad3972f74
Fixes for jshint
...
Built from https://develop.svn.wordpress.org/trunk@27643
git-svn-id: http://core.svn.wordpress.org/trunk@27486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-20 22:27:15 +00:00
Scott Taylor
bcb54794ff
Move wp.media.view.MediaDetails
to media-audiovideo.js
. This should have moved over with the rest.
...
See [27608].
Built from https://develop.svn.wordpress.org/trunk@27631
git-svn-id: http://core.svn.wordpress.org/trunk@27474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-20 02:45:15 +00:00
Andrew Nacin
30fd56b3dc
Only enqueue the image editor in the media modal in the admin.
...
props gcorne.
see #21811 .
Built from https://develop.svn.wordpress.org/trunk@27625
git-svn-id: http://core.svn.wordpress.org/trunk@27468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-19 21:16:14 +00:00
Helen Hou-Sandí
7ede169d47
Ensure the media library spinner hides when displaying a cached result set. props kovshenin. see #24859 .
...
Built from https://develop.svn.wordpress.org/trunk@27621
git-svn-id: http://core.svn.wordpress.org/trunk@27464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-19 18:27:15 +00:00
Scott Taylor
a17dd704c4
Create a new file, media-audiovideo.js
, to house all of the audio and video JS code in core.
...
UX Changes:
* Don't add a menu item for "Add Audio|Video Source"
* In the Audio|Video Details modal, add buttons and some suggestive text for adding alternate playback sources
* Don't show "Create Audio|Video Playlist" menu items until the user has uploaded audio or video files
See #27437 .
Built from https://develop.svn.wordpress.org/trunk@27608
git-svn-id: http://core.svn.wordpress.org/trunk@27451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-19 05:31:15 +00:00
Scott Taylor
117d1bd31e
Move removePlayer()
and unsetPlayer()
to wp.media.mixin
so that other classes can take advantage of them.
...
* `removePlayer()` is an alternative to MediaElement's player removal method that does not re-add the audio|video element back to the DOM.
* `unsetPlayer()` will check for an existing `player` property on the passed instance and pause all players before calling `unsetPlayer()`
See #27389 .
Built from https://develop.svn.wordpress.org/trunk@27538
git-svn-id: http://core.svn.wordpress.org/trunk@27381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-14 13:48:15 +00:00
Scott Taylor
56b919e651
Make media.view.VideoDetails.prepareSrc
a static class method instead of an instance method. Properly pairs it with its incrementing instances
property.
...
See #27389 .
Built from https://develop.svn.wordpress.org/trunk@27535
git-svn-id: http://core.svn.wordpress.org/trunk@27378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-14 12:43:15 +00:00
Andrew Ozz
1ebf6bc9ee
Drag/drop upload: don't trigger on "local" dragging, hide the overlay on click. Props kovshenin, fixes #19845
...
Built from https://develop.svn.wordpress.org/trunk@27531
git-svn-id: http://core.svn.wordpress.org/trunk@27374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-14 00:42:14 +00:00
Scott Taylor
b4569b69dc
Revert [27528] until Flash in Firefox behaves :(
...
See #27389 .
Built from https://develop.svn.wordpress.org/trunk@27530
git-svn-id: http://core.svn.wordpress.org/trunk@27373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-13 23:39:16 +00:00
Scott Taylor
ba84f57083
Add MCE Views for audio and video. Please clear your browser cache so that you get the latest TinyMCE stylesheet.
...
* Move TinyMCE shortcode handling from `wpgallery` plugin to `mce-view.js`
* Force `preload="none"` when rendering media in the editor to ensure fast loading (I realize this sounds illogical)
* Move audio and video tag builder logic in `media-template.php` into PHP funcs that can be reused by any code passing `data.model` to an Underscore template
* Pause all players when moving between editor tabs and when moving from the editor to editing in the media modal.
* Rename `wp.media.audio|video.shortcode()` to the more appropriate `wp.media.audio|video.update()` that now returns a `wp.shortcode` object instead of a string.
* Add necessary MediaElement css files to `$mce_css`
* In `wp.mce.View.render()`, support multiple instances of the same shortcode
* When rendering `wp.mce.View`s, fire a ready event that passes the current MCE View root element as context
See #27389 .
Built from https://develop.svn.wordpress.org/trunk@27528
git-svn-id: http://core.svn.wordpress.org/trunk@27371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-13 23:10:14 +00:00
Scott Taylor
a945b2738f
Add a class property to wp.media.view.MediaDetails
called instances
that is incremented every time the class is invoked. This mimics what happens in the shortcodes: the sources receive an incremented cache-buster so that the browser won't ignore the file when preload="metadata"
is set.
...
See #26779 .
Built from https://develop.svn.wordpress.org/trunk@27520
git-svn-id: http://core.svn.wordpress.org/trunk@27363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-13 03:55:15 +00:00
Scott Taylor
8705921741
In wp.media.view.AttachmentFilters
, when creating its inner HTML content, pass filter.text
via .html( str )
instead of .text( str )
to allow more formatting options.
...
Props tlovett1.
Fixes #25010 .
Built from https://develop.svn.wordpress.org/trunk@27518
git-svn-id: http://core.svn.wordpress.org/trunk@27361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-13 03:19:15 +00:00
Helen Hou-Sandí
326f49688f
Ensure the correct model is selected when editing an image from gallery mode. props gcorne. fixes #27363 .
...
Built from https://develop.svn.wordpress.org/trunk@27517
git-svn-id: http://core.svn.wordpress.org/trunk@27360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-12 22:05:15 +00:00
Helen Hou-Sandí
9aafd2294d
Smooth out some display and race condition issues with the media modal loading spinner. props kadamwhite, gcorne. see #24859 .
...
Built from https://develop.svn.wordpress.org/trunk@27516
git-svn-id: http://core.svn.wordpress.org/trunk@27359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-12 21:07:14 +00:00
Andrew Nacin
69ccc8b53d
JS linting for [27497].
...
see #21785 .
Built from https://develop.svn.wordpress.org/trunk@27498
git-svn-id: http://core.svn.wordpress.org/trunk@27340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-11 04:20:14 +00:00
Andrew Nacin
a589d9d757
Add header image uploads with cropping to the customizer.
...
props mcsf, ehg, gcorne.
see #21785 .
Built from https://develop.svn.wordpress.org/trunk@27497
git-svn-id: http://core.svn.wordpress.org/trunk@27339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-11 04:13:16 +00:00
Scott Taylor
f078f3e10e
Video editing in the media modal:
...
* Add a state: `Add Subititles`
* Add `text/vtt` to the list of allowed mime-types, files end in `.vtt`. `.srt` files are served as `text/plain`.
* The content body of a video shortcode should be used for adding `<track>` elements only. This happens dynamically in the modal. If added by hand, they can still be parsed and managed.
See #27016 .
Built from https://develop.svn.wordpress.org/trunk@27481
git-svn-id: http://core.svn.wordpress.org/trunk@27325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-09 10:32:15 +00:00
Scott Taylor
8e2e99fd0c
Since audio and video shortcodes don't point at actual attachments, don't persist the library's selection. Move the media instructions in the block that scrolls.
...
See #27016 .
Built from https://develop.svn.wordpress.org/trunk@27480
git-svn-id: http://core.svn.wordpress.org/trunk@27324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-09 06:24:15 +00:00
Scott Taylor
90da8aab4a
Add wp.media.view.MediaFrame.MediaDetails
, which wp.media.view.MediaFrame.AudioDetails
and media.view.MediaFrame.VideoDetails
extend. The subclasses subsequently only need to set createStates()
and bindHandlers()
, as well as any missing toolbar views.
...
See #27016 .
Built from https://develop.svn.wordpress.org/trunk@27479
git-svn-id: http://core.svn.wordpress.org/trunk@27323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-09 06:05:14 +00:00
Scott Taylor
f7af18e1d6
Audio/Video shortcodes in the media modal:
...
* Make a generic model, `wp.media.model.PostMedia`, which replaces `wp.media.model.PostAudio` and `wp.media.model.PostVideo`
* Make a generic library, `wp.media.controller.MediaLibrary`, which replaces `wp.media.controller.ReplaceVideo` and `wp.media.controller.ReplaceAudio`
* `wp.media.controller.MediaLibrary` is used to create new states that want to load a library filtered by type, making it incredibly simple to add states to frames. See `wp.media.view.MediaFrame.VideoDetails` and `wp.media.view.MediaFrame.AudioDetails`.
UX changes:
* Add the ability to manage HTML5 fallbacks - add additional `<source>`s or remove specific `<source>`s
* In the Video Details state, add the ability to select a poster image
See #27016 .
Built from https://develop.svn.wordpress.org/trunk@27478
git-svn-id: http://core.svn.wordpress.org/trunk@27322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-09 05:25:15 +00:00
Scott Taylor
dc00fc7e7f
Audio/Video shortcodes in the media modal:
...
* Add `embedMimes` to `_wpMediaViewsL10n`
* Use `escape` instead of `interpolate` when setting attributes in Underscore templates
* When creating the `<audio>` and `<video>` tags dynamically, set inner `<source>` nodes instead of the `src` attribute and properly set the mime-type per source as the `type` attribute. This is also drastically reduces the amount of code used to generate the tags.
See #27016 .
Built from https://develop.svn.wordpress.org/trunk@27476
git-svn-id: http://core.svn.wordpress.org/trunk@27320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-09 01:01:14 +00:00
Andrew Ozz
c3212baa4d
Limit the drag/drop upload only to newer browsers (IE10+), add a fullscreen dropzone in DFW mode, props kovshenin, see #19845
...
Built from https://develop.svn.wordpress.org/trunk@27464
git-svn-id: http://core.svn.wordpress.org/trunk@27309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 01:35:15 +00:00
Scott Taylor
818bf7c6af
When MEDIA_TRASH
is true, show the proper context in the attachment-details
sidebar. Without this fix, it always showed "Delete Permanently."
...
Props toszcze.
Fixes #26783 .
Built from https://develop.svn.wordpress.org/trunk@27454
git-svn-id: http://core.svn.wordpress.org/trunk@27300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-07 16:42:14 +00:00
Scott Taylor
3b212f7e0f
JSHint addendum to [27450].
...
See #27016 .
Built from https://develop.svn.wordpress.org/trunk@27453
git-svn-id: http://core.svn.wordpress.org/trunk@27299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-07 08:44:15 +00:00
Scott Taylor
7f15998947
Videos in the media modal:
...
* Support rendering of chromeless YouTube when a video shortcode's `src` is a YouTube URL.
* Don't instantiate an instance of `MediaElementPlayer` until after the view has been attached to the DOM and the view's `ready` event has fired.
* Don't set `poster` for videos when its value is empty. Much like `src` in the `img` tag - when empty, it will assume and load the current window's URL.
* When removing a player instance, don't call the `pause` method if the playback is not native.
See #27016 .
Built from https://develop.svn.wordpress.org/trunk@27452
git-svn-id: http://core.svn.wordpress.org/trunk@27298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-07 08:32:14 +00:00
Scott Taylor
52fdb09e2d
Support the autoplay
attribute, even when the plugin type for a MediaElement instance is Flash. In the media modal, wp.media.view.VideoDetails
and wp.media.view.AudioDetails
now extend a unified wp.media.view.MediaDetails
class which contains all of the player creation and destruction logic. The remove()
method mimics the mejs.MediaElementPlayer.remove()
method, but does not re-add the audio/video tag to the DOM. The MEjs method is especially problematic when the tag has autoplay="true"
and the view has been detached but not destroyed.
...
Fixes #25077 .
See #27016 .
Built from https://develop.svn.wordpress.org/trunk@27450
git-svn-id: http://core.svn.wordpress.org/trunk@27296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-07 05:52:14 +00:00
Helen Hou-Sandí
4bb7e03548
At long last, a first pass at bringing the image editor into the media modal. props gcorne, DH-Shredder, tomauger. see #21811 .
...
Built from https://develop.svn.wordpress.org/trunk@27445
git-svn-id: http://core.svn.wordpress.org/trunk@27292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-06 22:55:14 +00:00
Scott Taylor
023b419727
Call the correct remove()
method on the MEjs instance when exiting the media modal.
...
See #27016 .
Built from https://develop.svn.wordpress.org/trunk@27443
git-svn-id: http://core.svn.wordpress.org/trunk@27290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-06 20:13:15 +00:00
Scott Taylor
eda85e17ca
Cleanup audio/video shortcodes in the media modal:
...
* On the controller's `update`, `replace`, and `close` events, call `detach()` on the frame
* Cleanup the HTML ouput of the Underscore templates.
* Move some logic from the Underscore template to the `VideoDetails` view class.
See #27016 .
Built from https://develop.svn.wordpress.org/trunk@27440
git-svn-id: http://core.svn.wordpress.org/trunk@27287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-06 19:06:16 +00:00
Scott Taylor
ba27ced46b
Add a loading indicator to the Media Library.
...
Props kadamwhite, gcorne, kovshenin.
Fixes #24859 .
Built from https://develop.svn.wordpress.org/trunk@27438
git-svn-id: http://core.svn.wordpress.org/trunk@27285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-06 17:46:15 +00:00
Scott Taylor
bc9838f86f
We shall pledge to run jshint
before committing.
...
Props nacin for the nudge.
Built from https://develop.svn.wordpress.org/trunk@27435
git-svn-id: http://core.svn.wordpress.org/trunk@27282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-06 16:06:14 +00:00
Scott Taylor
9aa05f8681
Add a timestamp to the urls passed to <audio>
and <video>
in the modal to ensure that cached view instances aren't referenced by MEjs. Pause the player when closing the controller's modal.
...
See #27016 , #26779 .
Built from https://develop.svn.wordpress.org/trunk@27420
git-svn-id: http://core.svn.wordpress.org/trunk@27267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-05 21:37:13 +00:00
Scott Taylor
09d8606428
Add some missing JSDoc blocks to media-related code.
...
See #27016 .
Built from https://develop.svn.wordpress.org/trunk@27415
git-svn-id: http://core.svn.wordpress.org/trunk@27262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-05 18:37:15 +00:00
Scott Taylor
0ccc1d52ac
Audio doesn't have the same quirks as video in the media modal. We don't have to aggressively destroy the mejs
instance.
...
See #27016 .
Built from https://develop.svn.wordpress.org/trunk@27414
git-svn-id: http://core.svn.wordpress.org/trunk@27261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-05 18:32:14 +00:00
Scott Taylor
ff8844deae
Add TinyMCE placeholders for audio
and video
shortcodes.
...
* Add `wp.media.mixin`.
* Add `wp.media.audio` and `wp.media.video`.
* Add `wp.media.model.PostAudio` and `wp.media.model.PostVideo`
* Add `wp.media.controller.AudioDetails` and `wp.media.controller.VideoDetails`.
* Add `wp.media.controller.ReplaceAudio` and `wp.media.controller.ReplaceVideo`.
* Add `wp.media.view.MediaFrame.AudioDetails` and `wp.media.view.MediaFrame.VideoDetails`.
* Add `wp.media.view.AudioDetails` and `wp.media.view.VideoDetails`.
* Update the `wpgallery` TinyMCE plugin.
* Display audio and video players in the media modal when shortcode is clicked.
* Provide a UI to edit shortcode attributes in the media modal.
* Provide a UI to replace the `src` media file in an `audio` or `video` shortcode.
See #27016 .
Built from https://develop.svn.wordpress.org/trunk@27411
git-svn-id: http://core.svn.wordpress.org/trunk@27258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-05 15:06:14 +00:00
Andrew Nacin
70d23fc559
Support multiple editor instances when drag-and-drop-uploading onto them.
...
Also reduces z-index to below the toolbar, and adds a comment.
props kovshenin.
see #19845 .
Built from https://develop.svn.wordpress.org/trunk@27378
git-svn-id: http://core.svn.wordpress.org/trunk@27227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 17:44:16 +00:00
Scott Taylor
cbe89d6710
Adjust the priority of the separator in the Edit Playlist and Edit Video Playlist menus to match the structure of the Edit Gallery menu.
...
Props gcorne.
See #26631 .
Built from https://develop.svn.wordpress.org/trunk@27363
git-svn-id: http://core.svn.wordpress.org/trunk@27213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-02 23:13:14 +00:00
Scott Taylor
c0a9ee8452
Make CollectionEdit
and CollectionAdd
less dynamically quirky. Rename some instance properties for disambiguation. Pass some properties from options
when creating instances in wp.media.view.MediaFrame.Post
.
...
See #26631 .
Props gcorne.
Built from https://develop.svn.wordpress.org/trunk@27362
git-svn-id: http://core.svn.wordpress.org/trunk@27212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-02 23:11:14 +00:00
Scott Taylor
330f27f095
Add some braces for jshint
in media-views.js
.
...
See #26631 .
Props gcorne.
Built from https://develop.svn.wordpress.org/trunk@27361
git-svn-id: http://core.svn.wordpress.org/trunk@27211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-02 23:07:15 +00:00
Sergey Biryukov
f01dc328c5
Remove extra comma. props jorbin. see #19845 .
...
Built from https://develop.svn.wordpress.org/trunk@27352
git-svn-id: http://core.svn.wordpress.org/trunk@27203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-02 19:01:13 +00:00
Andrew Nacin
482856e2e1
Add the ability to drag and drop files directly onto the editor.
...
The file will then begin to upload and the media manager will open.
props kovshenin.
see #19845 .
Built from https://develop.svn.wordpress.org/trunk@27343
git-svn-id: http://core.svn.wordpress.org/trunk@27195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-01 21:34:17 +00:00
Scott Taylor
3dc901a92a
Rather than extending media.controller.CollectionAdd
3 times, make it a constructor that dynamically extends media.controller.Library
and use instances of it instead.
...
See #26631 .
Built from https://develop.svn.wordpress.org/trunk@27322
git-svn-id: http://core.svn.wordpress.org/trunk@27174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-27 23:04:13 +00:00
Scott Taylor
abebb1fde2
Correct a misspelled property name in a media-views.js
annotation.
...
Props kovshenin.
See #26870 .
Built from https://develop.svn.wordpress.org/trunk@27309
git-svn-id: http://core.svn.wordpress.org/trunk@27162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-27 03:07:14 +00:00
Andrew Ozz
511f12f793
When closing the various "edit" media modals, remove the related views elements from the DOM. Props gcorne, fixes #27204 .
...
Built from https://develop.svn.wordpress.org/trunk@27276
git-svn-id: http://core.svn.wordpress.org/trunk@27132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 21:03:15 +00:00
Andrew Nacin
74f2a32f52
Fixed mixed spaces and tabs. Also remove trailing comma. see #26631 .
...
Built from https://develop.svn.wordpress.org/trunk@27266
git-svn-id: http://core.svn.wordpress.org/trunk@27123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 17:32:14 +00:00
Scott Taylor
943f295d2e
Add core support for Playlists and Video Playlists.
...
* Playlists operate like galleries in the admin.
* Provide default UI and JS support in themes using MediaElement and Backbone.
* The shortcodes are clickable, editable, and configurable using the media modal.
* Playlists support images for each item, whether or not the current theme supports images for `attachment:audio` and `attachment:video`
* Playlists respond to `$content_width` and resize videos accordingly.
* All playlist data is included inline, using a script tag with `type="application/json"`, allowing anyone to unenqueue the WP playlist JS and roll their own.
* Playlist styles are minimal and work out of the box in the last 5 default themes. They inherit and adapt to the current theme's font styles, and their rules are easily overrideable.
See #26631 .
Built from https://develop.svn.wordpress.org/trunk@27239
git-svn-id: http://core.svn.wordpress.org/trunk@27096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-24 18:08:16 +00:00
Scott Taylor
f319feb524
Register wp.media.controller.GalleryEdit
and wp.media.controller.GalleryAdd
using the new wp.media.controller.Collection*
abstraction code.
...
See #26631 .
Built from https://develop.svn.wordpress.org/trunk@27215
git-svn-id: http://core.svn.wordpress.org/trunk@27072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-20 18:34:12 +00:00
Scott Taylor
4193c7f6c3
In media-views.js
, add wp.media.controller.CollectionAdd
and wp.media.controller.CollectionEdit
to provide an abstraction for Add and Edit screens in the media modal for collection-type things.
...
There are currently no instances of this. Those will be forthcoming.
See #26631 .
Built from https://develop.svn.wordpress.org/trunk@27214
git-svn-id: http://core.svn.wordpress.org/trunk@27071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-20 18:25:14 +00:00
Andrew Nacin
ca4a29c002
Update media-views and wp.Backbone.View for Backbone 1.1.
...
* Collection set/add/remove/reset methods now return models, not `this`, so they can no longer be chained.
* Options passed to Backbone.View's constructor are no longer attached automatically. wp.Backbone.View now does this automatically.
See [27170] for Backbone 1.1 itself.
props gcorne.
fixes #26799 .
Built from https://develop.svn.wordpress.org/trunk@27171
git-svn-id: http://core.svn.wordpress.org/trunk@27036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-13 07:36:13 +00:00
Dominik Schilling
5d0f6bd98a
Use jQuery.prop('checked') instead of jQuery.attr('checked'), which is deprecated.
...
Built from https://develop.svn.wordpress.org/trunk@27164
git-svn-id: http://core.svn.wordpress.org/trunk@27030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-11 21:13:14 +00:00
Scott Taylor
f1fff8a2e9
Add some inline docs to media-views.js
and remove some unnecessary comments from a few super
calls.
...
Props gcorne.
See #26870 .
Built from https://develop.svn.wordpress.org/trunk@27126
git-svn-id: http://core.svn.wordpress.org/trunk@26993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 20:21:12 +00:00
Andrew Nacin
6169e8662b
JSHint fixes for media-views and Gruntfile.
...
props gcorne.
fixes #27032 , #27033 .
Built from https://develop.svn.wordpress.org/trunk@27105
git-svn-id: http://core.svn.wordpress.org/trunk@26972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-06 05:32:12 +00:00
Andrew Ozz
2f6d9d37cc
Consolidate "close on Escape" in the media modal, DFW, wpLink and Thickbox. Props kovshenin, fixes #26854 .
...
Built from https://develop.svn.wordpress.org/trunk@27080
git-svn-id: http://core.svn.wordpress.org/trunk@26953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-03 05:31:14 +00:00
Scott Taylor
e1759d668a
For starters, [27050] is rad. This just cleans up some extra new lines that were littered about, updates *some* of the inline docs (needs more), moves wp.media.controller.ImageDetails
closer to its parent class, and de-dupes some code in media-template.php
.
...
See #24409 .
Built from https://develop.svn.wordpress.org/trunk@27051
git-svn-id: http://core.svn.wordpress.org/trunk@26925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 23:21:13 +00:00
Andrew Ozz
33eedc570b
Introduce Edit Image (single mode) in the media modal and use it to edit images inserted in the editor. Adds new feature: replace an image in the editor. Props gcorne, see #24409 .
...
Built from https://develop.svn.wordpress.org/trunk@27050
git-svn-id: http://core.svn.wordpress.org/trunk@26924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 21:17:12 +00:00
Scott Taylor
328fc8bae8
Add initial JSDoc blocks to media-views.js
. The initial blocks are a baseline to work from and invite future iterations. Initial commit is to avoid commits this large in the future.
...
See #26870 .
Built from https://develop.svn.wordpress.org/trunk@26986
git-svn-id: http://core.svn.wordpress.org/trunk@26863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-20 23:42:11 +00:00
Andrew Nacin
a5d83b489b
Fix JSHint errors in media-views.js.
...
props kadamwhite.
fixes #25974 .
Built from https://develop.svn.wordpress.org/trunk@26161
git-svn-id: http://core.svn.wordpress.org/trunk@26072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 05:54:10 +00:00
Andrew Nacin
622709076b
Media: Fix embedding of audio/video players when the file was just uploaded.
...
While uploading, we know an attachment's filename but not its mime type. Check specifically for extensions. Check for type as a convenience when it is available.
fixes #24449 .
git-svn-id: http://core.svn.wordpress.org/trunk@24784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-23 17:29:55 +00:00
Andrew Nacin
2c67dea9bc
Media: Add awareness to Attachment Display Settings that audio and video can be embedded.
...
Also:
* Add file length metadata to Attachment Details.
* Round the kb/s bitrate on post.php.
fixes #24449 .
git-svn-id: http://core.svn.wordpress.org/trunk@24777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-23 05:39:08 +00:00
Daryl Koopersmith
452c0f4166
Add Backbone property to the wp-backbone namespace. See #24424 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-26 06:34:33 +00:00
Daryl Koopersmith
b8ce442044
Update the subview controller for the patterns found in Backbone 1.0.
...
Fixes #24424 .
git-svn-id: http://core.svn.wordpress.org/trunk@24361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-25 21:38:12 +00:00
Daryl Koopersmith
56a6cac328
Extract the base views from media.
...
See #24424 .
git-svn-id: http://core.svn.wordpress.org/trunk@24360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-25 21:03:04 +00:00
Mark Jaquith
262b3bd9b1
Don't allow images to be set as featured image until they have been processed.
...
props kadamwhite. fixes #23317 .
git-svn-id: http://core.svn.wordpress.org/trunk@23956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-10 22:26:55 +00:00
Daryl Koopersmith
2798e396e3
Media: Reset modal after gallery insertion.
...
Removes hardcoded (and vestigial) 'upload' states in favor of using the default modal state.
When a media toolbar action is triggered, reset the modal after switching to the new state (as opposed to beforehand).
fixes #23675 .
git-svn-id: http://core.svn.wordpress.org/trunk@23590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-03 07:36:21 +00:00
Daryl Koopersmith
00d88af87a
Update Backbone to 0.9.10. Update media to handle breaking changes.
...
* When overriding `Backbone.sync()`, ensure the `sync` and `error` events fire consistently.
* `Model#make()` has been removed. Use `$` instead, and be sure to grab the DOM node where necessary (using `[0]`).
* `Collection#get()` now accepts `cid`s. `Collection#getByCid()` has been removed.
* When overriding the `State` constructor, bind `change` callbacks after the default `Model` constructor is called, because the `Model` constructor no longer passes the `silent` flag when calling `set()` for the default attributes.
* In 'change' events, `options.changes` was removed. It can now be accessed through `model.changed`. Check if any attributes have changed by calling `model.hasChanged()`. Also, don't mess with `model.changed`; it persists beyond the scope of a single event.
* `options.index` is no longer be set in the `add` event callback. Use `collection.indexOf(model)` can be used to retrieve the index of a model instead.
props gcorne. fixes #23262 .
git-svn-id: http://core.svn.wordpress.org/trunk@23589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-03 07:04:06 +00:00
Andrew Nacin
9a7814c1a0
Don't unnecessarily re-render the attachment details view when editing the title and caption. Re-rendering causes issues with tabbing and focus, and is only necessary for other views (such as "Caption this image..." when editing a gallery).
...
props koopersmith.
fixes #23054 .
for trunk.
git-svn-id: http://core.svn.wordpress.org/trunk@23283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-04 23:29:20 +00:00
Daryl Koopersmith
a84cef4556
Media: Properly reset the "add to gallery" library to ensure it accurately reflects the current gallery. see #22815 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-04 08:28:12 +00:00
Andrew Nacin
c95ff91fe7
Media: Restore 3.4 behavior by consulting the old-school DB options for default align, size, and link properties.
...
This restores linking to media files as the default, over attachment pages. This 'default' cannot currently be changed by a user setting (per 3.4 behavior), due to the default database schema.
see #22841 , for trunk.
git-svn-id: http://core.svn.wordpress.org/trunk@23262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-04 08:02:16 +00:00
Daryl Koopersmith
da06cf3e2d
Media: Do not update attachment display user settings when a single attachment is inserted.
...
This is consistent with 3.4 behavior.
see #22841 .
git-svn-id: http://core.svn.wordpress.org/trunk@23261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-04 08:01:19 +00:00