Commit Graph

15930 Commits

Author SHA1 Message Date
Sergey Biryukov
128ba6a38a Script Loader: Change the jquery handle back to an alias for jquery-core.
This ensures that `wp_localize_script( 'jquery', ... )` continues to work as expected, since `WP_Scripts::localize()` rewrites the `jquery` handle to `jquery-core` internally.

Follow-up to [48323].

Props mukesh27, rajeshsingh520, johnbillion, TimothyBlynJacobs, TobiasBg.
Merges [48890] to the 5.5 branch.
Fixes #50919.
Built from https://develop.svn.wordpress.org/branches/5.5@48891


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-27 20:36:07 +00:00
desrosj
9fceb56948 Upgrade/Install: Pass details about the specific plugin and theme updates attempted to filters.
This adds an additional parameter to the `auto_plugin_update_send_email` and `auto_theme_update_send_email` filters to provide the additional context of which updates were attempted and their outcome. This will help plugin and theme auto-update emails to be better tailored to a site owner's liking.

Props audrasjb, Paddy Landau, desrosj.
Merges [48888] to the 5.5 branch.
Fixes #50988.
Built from https://develop.svn.wordpress.org/branches/5.5@48889


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-27 19:34:05 +00:00
desrosj
8096a67b7c Build/Test Tools: Update the package lock file.
Follow up to [48884].

Merges [48886] to the 5.5 branch.
See #51151.
Built from https://develop.svn.wordpress.org/branches/5.5@48887


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-27 19:07:05 +00:00
jorgefilipecosta
5228943449 Editor: update packages.
The following package versions were changed:
@wordpress/block-directory: 1.13.6 -> 1.13.7
@wordpress/block-editor: 4.3.6 -> 4.3.7
@wordpress/block-library: 2.22.6 -> 2.22.7
@wordpress/components: 10.0.5 -> 10.0.6
@wordpress/edit-post: 3.21.6 -> 3.21.7
@wordpress/editor: 9.20.6 -> 9.20.7
@wordpress/format-library: 1.22.6 -> 1.22.7
@wordpress/list-reusable-blocks: 1.21.5 -> 1.21.6
@wordpress/nux: 3.20.5 -> 3.20.6
@wordpress/server-side-render: 1.16.5 -> 1.16.6
Includes PR WordPress/gutenberg#24828

Props nosolosw, desrosj, SergeyBiryukov, youknowriad.
Merges [48884] to the 5.5 branch.
Fixes: #51151.
Built from https://develop.svn.wordpress.org/branches/5.5@48885


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-27 18:00:38 +00:00
Sergey Biryukov
5b5de79ffd REST API: Fix multi-type schemas with integer fields.
In [48306] support for multi-typed schemas was improved to first detect the data type of the value before applying further validation. The `integer` data type was detected using the new `rest_is_integer` function. This function used logic, however, that assumed that the value had already passed an `is_numeric` check. This meant that if `integer` and `string` were both acceptable types, the value would always be considered an `integer` causing the later accurate type validation to fail.

This commit fixes the `rest_is_integer` logic to include an `is_numeric` check.

Props rtagliento, TimothyBlynJacobs.
Merges [48881] to the 5.5 branch.
Fixes #51146.
Built from https://develop.svn.wordpress.org/branches/5.5@48883


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-27 14:45:05 +00:00
Sergey Biryukov
522904bde6 Taxonomy: Make sure wp_terms_checklist() and Walker_Category_Checklist::start_el() properly handle an array of strings as selected_cats or popular_cats values.
Even with these values documented as an array of integers, they can technically also accept an array of strings, e.g. as form results.

Add a unit test.

Props brianhogg, TimothyBlynJacobs, SergeyBiryukov.
Merges [48880] to the 5.5 branch.
Fixes #51137.
Built from https://develop.svn.wordpress.org/branches/5.5@48882


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-27 03:08:03 +00:00
Sergey Biryukov
8e1d2765d0 Tests: Update one more test to account for lazy-loading being disabled for custom logos by default.
Follow-up to [48870], [48874].

Props desrosj.
Merges [48878] to the 5.5 branch.
See #50933.
Built from https://develop.svn.wordpress.org/branches/5.5@48879


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-27 02:05:04 +00:00
Sergey Biryukov
466316ef95 Comments: Correct the check for reply element existence in comment-reply.js.
`document.getElementById()` returns `null` if no matching element was found, so the previous comparison didn't work as expected.

Follow-up to [47506].

Props mailnew2ster, sarahricker.
Merges [48876] to the 5.5 branch.
Fixes #38009.
Built from https://develop.svn.wordpress.org/branches/5.5@48877


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-27 02:01:04 +00:00
Sergey Biryukov
9135fd39a6 Tests: Update unit tests to account for lazy-loading being disabled for custom logos by default.
Follow-up to [48870].

Merges [48874] to the 5.5 branch.
See #50933.
Built from https://develop.svn.wordpress.org/branches/5.5@48875


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-27 01:58:04 +00:00
Peter Wilson
b0038c85f1 Sitemaps: Prevent incorrect redirection of paged sitemap requests.
Update `redirect_canonical()` to account for custom pagination and URL format used by sitemaps in order to follow standard practices.

Introduce the function `get_sitemap_url()` to simplify getting the index and provider URLs as needed.

Props jonathanstegall, pbiron, GamerZ, salvoaranzulla, peterwilsoncc.
Merges [48872] to the 5.5 branch.
Fixes #50910.


Built from https://develop.svn.wordpress.org/branches/5.5@48873


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-27 01:37:03 +00:00
desrosj
7c2369f292 Media: Disable lazy-loading for custom logos by default.
Custom site logos are most commonly displayed above the fold, so lazy-loading is unnecessary.

Props demetris, khag7, johnbillion, rebasaurus, audrasjb.
Merges [48870] to the 5.5 branch.
Fixes #50933.
Built from https://develop.svn.wordpress.org/branches/5.5@48871


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-27 01:10:07 +00:00
Sergey Biryukov
97bbea6001 Upgrade/Install: Make the check for empty home option in __get_option() more resilient.
This addresses a regression in [47808], where the `home` check expected an empty string to use `siteurl` as a fallback, but `wpdb::get_var()` returns `null` if the option is empty.

Props fjarrett.
Merges [48868] to the 5.5 branch.
Fixes #51011.
Built from https://develop.svn.wordpress.org/branches/5.5@48869


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-26 17:07:09 +00:00
Sergey Biryukov
559fcbdfed Quick/Bulk Edit: Revert [48134] to address the bottom "Bulk actions" dropdown not functioning properly on Posts and Users list tables.
A better solution for the original issue will be explored in a future release.

Props audrasjb, garrett-eclipse, webzunft, Krstarica, chunkysteveo, SergeyBiryukov.
Merges [48866] to the 5.5 branch.
Fixes #50882, #50998. See #46872.
Built from https://develop.svn.wordpress.org/branches/5.5@48867


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-26 14:21:04 +00:00
Sergey Biryukov
0ef27cd212 Editor: Remove some hardcoded text color values from patterns that have body text with no specific background color.
This ensures that the patterns respect the theme's default color for body text and avoids contrast issues, particularly in dark themes.

Props nrqsnchz, mapk, fullofcaffeine.
Merges [48864] to the 5.5 branch.
Fixes #50892.
Built from https://develop.svn.wordpress.org/branches/5.5@48865


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-26 13:36:04 +00:00
Sergey Biryukov
202f167106 Administration: Remove non-color related styling from Modern color scheme.
Color schemes should only affect colors, to avoid diverging from a consistent and predictable layout, especially if core CSS rules subsequently change.

Follow-up to [48277], [48286], [48345].

Props Joen, johnbillion, afercia, johnjamesjacoby.
Merges [48862] to the 5.5 branch.
Fixes #51127. See #50504.
Built from https://develop.svn.wordpress.org/branches/5.5@48863


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-26 13:21:03 +00:00
Sergey Biryukov
b923eed063 Editor: Make some hardcoded strings in block patterns translatable.
Follow-up to [48726].

Props justinahinon, audrasjb, nabilmoqbel, tobifjellner, yoavf, ramiy.
Merges [48859] to the 5.5 branch.
Fixes #50845.
Built from https://develop.svn.wordpress.org/branches/5.5@48860


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-25 12:42:09 +00:00
Sergey Biryukov
c3e02f4262 Bootstrap/Load: Add local environment type to wp_get_environment_type().
This gives developers a better control over their existing development workflow and ensures that `local` is not the exact same as `development` if it does not need to be.

Props claytoncollie, johnbillion, jeremyfelt, kreppar, dushakov, TimothyBlynJacobs, Ipstenu, khag7, knutsp, Clorith, markjaquith, joostdevalk, SergeyBiryukov.
Merges [48856] to the 5.5 branch.
Fixes #51064.
Built from https://develop.svn.wordpress.org/branches/5.5@48857


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-24 22:34:03 +00:00
Sergey Biryukov
3f25fa66be Docs: Add documentation and a @since note about the loading attribute added to wp_get_attachment_image().
Follow-up to [48272].

Props audrasjb.
Merges [48852] and [48853] to the 5.5 branch.
Fixes #51122.
Built from https://develop.svn.wordpress.org/branches/5.5@48854


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-24 22:14:03 +00:00
Sergey Biryukov
be19de843c Administration: Don't print the .php-error class in the admin header for PHP notices in wp-config.php.
Any notices in that file happen before `WP_DEBUG` takes effect, and should not be displayed with the `error_reporting` level previously set in `wp-load.php`.

Adding the class when there is no notice displayed results in extra padding under the admin bar, which should be avoided.

Follow-up to [20102], [21025], [26620], [47745].

Props akissz, tw2113, laxman-prajapati, sabernhardt, johnbillion, SergeyBiryukov.
Merges [48850] to the 5.5 branch.
Fixes #51073.
Built from https://develop.svn.wordpress.org/branches/5.5@48851


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-24 10:50:05 +00:00
Sergey Biryukov
fa9d78cc8c REST API: In WP_REST_Block_Directory_Controller::get_items(), make sure the blocks data for a plugin is not empty before proceeding.
This avoids a PHP notice if the API returns a plugin with empty data for `blocks` key.

Props khag7, TwentyZeroTwo, justinahinon, TimothyBlynJacobs, dd32, SergeyBiryukov.
Merges [48842] to the 5.5 branch.
Fixes #51018.
Built from https://develop.svn.wordpress.org/branches/5.5@48849


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-24 10:35:07 +00:00
Sergey Biryukov
aed2402ea9 Docs: Update documentation for get_custom_logo() and the_custom_logo() to mention the unlink-homepage-logo theme feature.
Follow-up to [48039], [48283], [48749], [48757], [48758].

Props sabernhardt.
Merges [48832] to the 5.5 branch.
Fixes #51075.
Built from https://develop.svn.wordpress.org/branches/5.5@48833


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-20 10:43:05 +00:00
Sergey Biryukov
4604f4766d Docs: Add a @since note to register_rest_route() about the _doing_it_wrong() notice when the required permission_callback argument is not set.
Follow-up to [48526].

Props psykro.
Merges [48827] to the 5.5 branch.
Fixes #51060.
Built from https://develop.svn.wordpress.org/branches/5.5@48828


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-19 12:33:05 +00:00
Sergey Biryukov
5ddabef439 Plugins: Avoid a PHP notice if the update-supported key in plugin data is not set.
Props sanzeeb3.
Merges [48820] to the 5.5 branch.
Fixes #51052.
Built from https://develop.svn.wordpress.org/branches/5.5@48821


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-18 20:40:04 +00:00
Sergey Biryukov
ea3c57f303 Formatting: Make the check for empty text in wp_trim_excerpt() more resilient.
This addresses a regression in [47808], which caused excerpts to be generated from post content if an empty string is passed, but not for other values considered empty, e.g. `null` or `false`.

Props riaanlom, laxman-prajapati, SergeyBiryukov.
Merges [48817] to the 5.5 branch.
Fixes #51042.
Built from https://develop.svn.wordpress.org/branches/5.5@48819


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-18 19:37:06 +00:00
Sergey Biryukov
65a1d15089 Docs: Add a @since note to get_the_archive_title() about the title part being wrapped in a <span> element.
Follow-up to [48294].

Props justinahinon, audrasjb.
Merges [48814] to the 5.5 branch.
Fixes #51050.
Built from https://develop.svn.wordpress.org/branches/5.5@48815


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-18 12:07:05 +00:00
Sergey Biryukov
62a5dbff7b Help/About: Revert [48811] from the 5.5 branch for now, to avoid displaying untranslated strings on the About page.
This should be merged back when 5.5.1 is about to be released.

See #51028.
Built from https://develop.svn.wordpress.org/branches/5.5@48813


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-18 03:02:08 +00:00
Sergey Biryukov
b2e4cc384d Help/About: Fix typo and remove trailing spaces from some strings.
Props mukesh27, casiepa, davidbaumwald.
Merges [48809] to the 5.5 branch.
Fixes #51028.
Built from https://develop.svn.wordpress.org/branches/5.5@48811


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-17 10:59:06 +00:00
Sergey Biryukov
f6dfc217e7 Site Health: Ensure that the tests returned by WP_Site_Health::get_tests() always have the required array keys: direct and async.
This avoids PHP notices if these keys were accidentally removed using the `site_status_tests` filter.

Props khag7, Ov3rfly, desrosj, Clorith.
Merges [48808] to the 5.5 branch.
Fixes #50858.
Built from https://develop.svn.wordpress.org/branches/5.5@48810


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-17 02:23:06 +00:00
Sergey Biryukov
2867dadfa7 REST API: Add uniqueItems as a permitted endpoint argument JSON Schema keyword.
Support for the `uniqueItems` keyword was added in [48357], but wasn't included in the list of permitted keywords for `WP_REST_Controller::get_endpoint_args_for_item_schema()`. This prevented the keyword from being automatically supported if specified in a controller's item schema.

Props TimothyBlynJacobs.
Merges [48796] to the 5.5 branch.
Fixes #51021.
Built from https://develop.svn.wordpress.org/branches/5.5@48807


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-17 01:42:05 +00:00
Sergey Biryukov
260dd52af5 Site Health: Only display the warning about the post_max_size PHP value when it's lower than upload_max_filesize.
Previously, the warning was displayed even if the value was higher than `upload_max_filesize`, which made the report inaccurate, as these values don't necessarily have to match.

Props oakesjosh, jeroenrotty, desrosj, Clorith.
Merges [48800] and [48801] to the 5.5 branch.
Fixes #50945.
Built from https://develop.svn.wordpress.org/branches/5.5@48806


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-17 01:29:03 +00:00
Sergey Biryukov
f86e37faae Site Health: Add site environment type to the debug information.
Follow-up to [47919], [48188], [48372].

Props joostdevalk, Clorith.
Merges [48802] to the 5.5 branch.
Fixes #50887.
Built from https://develop.svn.wordpress.org/branches/5.5@48805


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-17 01:25:04 +00:00
Sergey Biryukov
3557ce0af2 Site Health: Recognize define( 'WP_AUTO_UPDATE_CORE', 'minor' ) as an acceptable value.
Previously, it was only incidentally recognized as valid due to a loose comparison with `true`.

With the strict comparison added to `WP_Site_Health_Auto_Updates::test_constants()`, this was no longer the case.

Follow-up to [47841].

Props sterndata, mukesh27, avixansa, desrosj, SergeyBiryukov.
Merges [48792] to the 5.5 branch.
Fixes #50912.
Built from https://develop.svn.wordpress.org/branches/5.5@48804


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-17 01:04:04 +00:00
Sergey Biryukov
38da35836a Filesystem API: Use correct variable when closing the file handle in WP_Filesystem_FTPext::get_contents().
Props gothick@gothick.org.uk.
Merges [48797] to the 5.5 branch.
Fixes #51029.
Built from https://develop.svn.wordpress.org/branches/5.5@48803


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-17 00:57:07 +00:00
Sergey Biryukov
6c78faf991 Post WordPress 5.5 version bump.
Built from https://develop.svn.wordpress.org/branches/5.5@48787


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-11 19:35:06 +00:00
whyisjake
e9cf4f9c48 WordPress 5.5
Built from https://develop.svn.wordpress.org/branches/5.5@48785


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-11 18:14:05 +00:00
desrosj
abd91fb7c9 Help/About: Final adjustments to the 5.5 About page.
- Final CDN asset URLs.
- Some minor color adjustments.

Props ryelle, marybaum, davidbaumwald, audrasjb, estelaris, afercia, cbringmann, andreamiddleton, desrosj, SergeyBiryukov, ocean90, nrqsnchz, spacedmonkey, whyisjake, man4toman.
Merges [48783] to the 5.5 branch.
Fixes #50416.
Built from https://develop.svn.wordpress.org/branches/5.5@48784


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-11 16:57:06 +00:00
whyisjake
c5dca80b90 Post WordPress 5.5 RC 3 version bump.
Built from https://develop.svn.wordpress.org/branches/5.5@48781


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-10 16:55:03 +00:00
whyisjake
9c1800d57b WordPress 5.5 RC 3.
Built from https://develop.svn.wordpress.org/branches/5.5@48780


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-10 16:33:04 +00:00
Sergey Biryukov
5028fdb02b Options, Meta APIs: Update the docs around default metadata values.
Add a missing @since value for 5.5 and potential default filter names.

Props johnbillion.
Reviewed by whyisjake, SergeyBiryukov.
Merges [48777] and [48778] to the 5.5 branch.
Fixes #50891.
Built from https://develop.svn.wordpress.org/branches/5.5@48779


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-10 15:53:05 +00:00
desrosj
f2656febbf Bundled Themes: Bump theme versions ahead of WordPress 5.5.
The following theme versions will be released in coordination with WordPress 5.5:
- Twenty Ten: 3.1
- Twenty Eleven: 3.5
- Twenty Twelve: 3.2
- Twenty Thirteen: 3.1
- Twenty Fourteen: 2.9
- Twenty Fifteen: 2.7
- Twenty Sixteen: 2.2
- Twenty Seventeen: 2.4
- Twenty Nineteen: 1.7
- Twenty Twenty: 1.5

Props whyisjake, desrosj.
Reviewed by whyisjake, SergeyBiryukov, desrosj.
Merges [48775] to the 5.5 branch.
Fixes #50889.
Built from https://develop.svn.wordpress.org/branches/5.5@48776


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-10 15:37:02 +00:00
Sergey Biryukov
fa8f759dc2 Editor: update packages.
Props ellatrix.
Reviewed by whyisjake, SergeyBiryukov.
Merges [48772] to the 5.5 branch.
Fixes #50888.
Built from https://develop.svn.wordpress.org/branches/5.5@48773


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-10 14:22:29 +00:00
Sergey Biryukov
d5c3cd0293 I18N: Fix typo in a screen reader text string on the About page.
Follow-up to [48729].

Props pedromendonca.
Reviewed by desrosj, SergeyBiryukov.
Merges [48770] to the 5.5 branch.
Fixes #50884.
Built from https://develop.svn.wordpress.org/branches/5.5@48771


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-10 13:25:05 +00:00
Sergey Biryukov
d5b78890ed I18N: Fix typo in a string in rest_validate_value_from_schema().
Props pedromendonca.
Reviewed by TimothyBlynJacobs, SergeyBiryukov.
Merges [48767] to the 5.5 branch.
Fixes #50879.
Built from https://develop.svn.wordpress.org/branches/5.5@48768


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-09 02:02:02 +00:00
Sergey Biryukov
8e47fe0608 Help/About: Update videos and their descriptions on the About page.
Follow-up to [48675], [48686], [48721], [48729], [48730], [48736].

Props ryelle, marybaum, estelaris, desrosj, joen, afercia.
Reviewed by jorbin, SergeyBiryukov.
Merges [48761] to the 5.5 branch.
See #50416.
Built from https://develop.svn.wordpress.org/branches/5.5@48763


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-08 21:02:06 +00:00
whyisjake
e7f689b9a8 Themes: Add unlink-homepage-logo to the create_initial_theme_features() registration for the custom-logo theme feature.
Follow-up to [48039], [48283], [48749], [48757], [48758].

This brings the changes to the 5.5 branch.

Props TimothyBlynJacobs, SergeyBiryukov, whyisjake.
Fixes #37011.

Built from https://develop.svn.wordpress.org/branches/5.5@48759


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-07 21:22:05 +00:00
whyisjake
931826a203 Docs: Correct usage of the dynamic auto_update_{$type} filter.
This ensures that the canonical name of the filter is used in Site Health debug data, as well as on plugin and theme screens, so the developer reference site remains correct.

This brings the changes from [48750] to the 5.5 branch.

Props johnbillion.
Fixes #50868, see [48750].

Built from https://develop.svn.wordpress.org/branches/5.5@48756


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-07 19:25:02 +00:00
whyisjake
2460e1b0c8 Accessibility: Themes: Only unlink custom logo on the home page if the theme declares support for that.
To accommodate for the change, the custom-logo theme feature now accepts the unlink-homepage-logo parameter.

If and when the logo is linked on the home page, the link has the aria-current attribute for better accessibility.

Follow-up to [48039], [48283], see [48749].

This brings the changes to the 5.5 branch.

Props sabernhardt, audrasjb, johnstonphilip, demetris, SergeyBiryukov.
Fixes #37011.

Built from https://develop.svn.wordpress.org/branches/5.5@48755


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-07 19:20:07 +00:00
Sergey Biryukov
52b59a5f07 Comments: Update comment cache in the upgrade routine for changing the comment_type DB field value in comments table.
This ensures that comment object cache is cleared after changing the comment type to `comment` instead of an empty string.

Add a unit test for `_wp_batch_update_comment_type()`.

Follow-up to [47597], [47626], [48225], [48227].

Props imath, westonruter.
Reviewed by desrosj, SergeyBiryukov.
Merges [48748] and [48751] to the 5.5 branch.
Fixes #49236.
Built from https://develop.svn.wordpress.org/branches/5.5@48752


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-07 16:35:08 +00:00
desrosj
719ef3461b Site Health: Consistently pass an object to the auto_update_{$type} filter in Site Health debug data.
Previously, some instances of the filter received an array from a plugin or theme update response, potentially triggering PHP notices.

Merges [48745] to the 5.5 branch.
Reviewed by desrosj, SergeyBiryukov.
Props bpayton, pbiron.
Fixes #50852.
Built from https://develop.svn.wordpress.org/branches/5.5@48747


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-07 13:51:02 +00:00
desrosj
081d50e68f Site Health: Check if session_status() exists before calling it.
Merges [48742] to the 5.5 branch.
Reviewed by desrosj, SergeyBiryukov.
Props bgermann.
Fixes #50862.
Built from https://develop.svn.wordpress.org/branches/5.5@48746


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-07 13:43:05 +00:00