Commit Graph

60 Commits

Author SHA1 Message Date
Scott Taylor
12a5b389ab Eliminate use of extract() in get_bookmarks().
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28403


git-svn-id: http://core.svn.wordpress.org/trunk@28230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 01:58:15 +00:00
Scott Taylor
63a210e7c8 In wp-includes/bookmark.php, remove dead code:
* In `get_bookmarks()`, `$cache` is set twice before it is used. 
* In `sanitize_bookmark_field()`, `break` is unreachable after `return`

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28316


git-svn-id: http://core.svn.wordpress.org/trunk@28144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:22:16 +00:00
Andrew Nacin
803d4ff54d Remove old links_recently_updated_* DB options that never had a UI.
fixes #27649.

Built from https://develop.svn.wordpress.org/trunk@27916


git-svn-id: http://core.svn.wordpress.org/trunk@27746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-03 03:10:15 +00:00
Dion Hulse
90b6ccc88d Add some missing braces to get_bookmarks() which was causing an early return. Introduced in [25934]. See #25468. Fixes #25874
Built from https://develop.svn.wordpress.org/trunk@26046


git-svn-id: http://core.svn.wordpress.org/trunk@25971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-08 02:20:10 +00:00
Drew Jaynes
3c22a3fd6d Inline documentation for hooks in wp-includes/bookmark.php.
Props ShinichiN, kpdesign.
Fixes #25468.

Built from https://develop.svn.wordpress.org/trunk@25934


git-svn-id: http://core.svn.wordpress.org/trunk@25893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-26 16:53:09 +00:00
Jon Cave
5c57c78afa Fix potential SQLi through improper use of API functions.
git-svn-id: http://core.svn.wordpress.org/trunk@24875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-29 18:16:47 +00:00
Andrew Nacin
94c34141b3 Don't cache a non-existent link in get_bookmark(). props wonderboymusic, fixes #21159.
git-svn-id: http://core.svn.wordpress.org/trunk@21829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-13 16:41:43 +00:00
ryan
4cf5450a81 Use wp_cache_add() instead of wp_cache_set() when priming the object term cache in update_object_term_cache(). Pass the real post_type to clean_object_term_cache() instead of hard-coding post. Call clean_object_term_cache() from clean_bookmark_cache(). Props leewillis77. fixes #19690
git-svn-id: http://svn.automattic.com/wordpress/trunk@19729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-11 21:26:18 +00:00
ryan
e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
nacin
97c1b24db9 get_bookmarks() doc fix. props hearvox, fixes #19508.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-20 22:01:43 +00:00
nacin
acbc9144dd Allow 'id' to work in get_bookmarks(). Add link_notes even though such sorting is a bad idea. see #18068 for 3.3.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-30 17:03:46 +00:00
ryan
05b3172a32 Allow sorting by id in get_bookmarks(). Props SergeyBiryukov. see #18234 for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@18470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-26 21:22:13 +00:00
ryan
2010842d10 Sanitize order and orderby in get_bookmarks()
git-svn-id: http://svn.automattic.com/wordpress/trunk@18345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-27 15:46:11 +00:00
ryan
c626339cca link_notes and term_description escaping fixes. Props garyc40. fixes #15454
git-svn-id: http://svn.automattic.com/wordpress/trunk@17146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-25 22:45:09 +00:00
nacin
5a20c05d27 Phpdoc argument/@param cleanups. props duck_, see #14783.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-07 11:21:11 +00:00
ryan
37d86213db Fix array handling in sanitize_bookmark_field(). Props mdawaffe. fixes #13098
git-svn-id: http://svn.automattic.com/wordpress/trunk@14239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-26 14:10:12 +00:00
nacin
144af9f1a4 Allow orberby in wp_list_bookmarks to accept a comma-delimited list of fields, per docs. fixes #12421, props sorich87, scribu.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-18 04:45:09 +00:00
nacin
fd5f785cce Move deprecated functions to deprecated.php. Deprecate get_the_attachment_link() for wp_get_attachment_link(), get_attachment_icon_src() for wp_get_attachment_image_src(),
get_attachment_icon() and get_attachment_innerHTML() for wp_get_attachment_image(), get_link() for get_bookmark(). Add missing deprecated version numbers. Add inline documentation to pluggable functions that are deprecated. See #11388

git-svn-id: http://svn.automattic.com/wordpress/trunk@13093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-13 06:39:51 +00:00
westi
9a004ff9c8 Ensure we don't mangle the array of link categories when sanitising a link for editing. See #12168.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-07 21:59:24 +00:00
ryan
cedfa0181b Use array calling style. Props Denis-de-Bernardy. see #6647
git-svn-id: http://svn.automattic.com/wordpress/trunk@12515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-23 15:31:02 +00:00
ryan
2d10b58caf Do recently updated test only if show_updated. Avoids slow query.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-01 19:35:21 +00:00
markjaquith
d7b015645d esc_js(). Shorter, follows new escaping naming convention.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-09 07:27:22 +00:00
markjaquith
6c2ffddf31 _a(), _ea(), _xa(), attr() are now esc_attr__(), esc_attr_e(), esc_attr_x(), esc_attr() -- still short, but less cryptic. see #9650
git-svn-id: http://svn.automattic.com/wordpress/trunk@11204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-05 19:43:53 +00:00
ryan
2d489767bb s/attribute_escape/attr/. see #9650
git-svn-id: http://svn.automattic.com/wordpress/trunk@11109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-28 05:58:45 +00:00
ryan
90d7c33579 Return empty list if requests bookmark category does not exist. Props Viper007Bond. fixes #7507
git-svn-id: http://svn.automattic.com/wordpress/trunk@11064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-23 05:39:33 +00:00
ryan
5183a7e189 Make sure get_bookmarks cache is an array
git-svn-id: http://svn.automattic.com/wordpress/trunk@10229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-12-19 07:05:51 +00:00
ryan
e89192b1a8 Strip trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@10150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-12-09 18:03:31 +00:00
ryan
40c754df1d Unused var fixes. Props DD32. see #8220
git-svn-id: http://svn.automattic.com/wordpress/trunk@9716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-15 18:10:35 +00:00
ryan
9861eb1a85 Notice fixes from DD32. see #7509
git-svn-id: http://svn.automattic.com/wordpress/trunk@9699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-14 23:01:16 +00:00
ryan
bcdb29372d Add edit and delete links to the Content->Links rows. Add get_edit_bookmark_link(). Add caching for individual bookmarks. see #7552
git-svn-id: http://svn.automattic.com/wordpress/trunk@8758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-27 22:04:12 +00:00
westi
f7b32217a3 phpDoc corrections for wp-includes. See #7550 props santosj.
git-svn-id: http://svn.automattic.com/wordpress/trunk@8742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-27 06:45:13 +00:00
ryan
62784a594f phpdoc updates from jacobsantos. see #7038
git-svn-id: http://svn.automattic.com/wordpress/trunk@7990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-05-25 15:45:05 +00:00
ryan
b7f524580d Add sanitization to get_link() and get_link_to_edit(). Props mdawaffe. fixes #6125
git-svn-id: http://svn.automattic.com/wordpress/trunk@7193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-10 05:28:21 +00:00
ryan
1bd097fff0 Manage links redesign. Add link search.
git-svn-id: http://svn.automattic.com/wordpress/trunk@6798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-12 08:01:32 +00:00
ryan
d88983793b Trailing whitespace cleanup
git-svn-id: http://svn.automattic.com/wordpress/trunk@6726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-05 06:47:27 +00:00
westi
1aaec4ff30 Notice fixing for wp-includes. See #5607 props filosofo.
git-svn-id: http://svn.automattic.com/wordpress/trunk@6592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-10 20:51:07 +00:00
westi
b867ab06a0 Add documentation for bookmark.php. Fixes #5523 props darkdragon.
git-svn-id: http://svn.automattic.com/wordpress/trunk@6480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-12-24 07:01:47 +00:00
ryan
95fe4f48bd Use correct var. Props DD32. fixes #5419
git-svn-id: http://svn.automattic.com/wordpress/trunk@6353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-12-04 23:59:16 +00:00
ryan
c674a475d7 Use inner joins instead of left joins for taxonomy. Inner is faster. fixes #5179
git-svn-id: http://svn.automattic.com/wordpress/trunk@6224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-10-11 17:43:49 +00:00
markjaquith
47955b3fae prepare() for wp-includes/ bookmark.php, canonical.php, comment.php, comment-template.php. see #4553
git-svn-id: http://svn.automattic.com/wordpress/trunk@6173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-09-27 07:34:15 +00:00
ryan
321c310717 Remove trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@6026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-09-03 23:32:58 +00:00
ryan
87c4f3a17f Strip lines that contain only whitespace down to newlines.
git-svn-id: http://svn.automattic.com/wordpress/trunk@6025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-09-03 23:19:20 +00:00
ryan
277e5aa914 Don't use unavailable func. Props filosofo. fixes #4881
git-svn-id: http://svn.automattic.com/wordpress/trunk@5997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-08-31 22:36:16 +00:00
ryan
ba0f401390 bookmark sanitizer funcs and default filter cleanup. see #4546
git-svn-id: http://svn.automattic.com/wordpress/trunk@5906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-08-20 22:50:04 +00:00
ryan
8d75bcef27 Revert accidental commit.
git-svn-id: http://svn.automattic.com/wordpress/trunk@5897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-08-17 21:23:39 +00:00
ryan
0458d919c0 First cut of taxonomy API phpdoc from darkdragon. see #4742
git-svn-id: http://svn.automattic.com/wordpress/trunk@5896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-08-17 21:22:37 +00:00
ryan
aa1b4e8968 Set instead of add since the cache value has multiple keys that can change. Props josephscott. fixes #4743
git-svn-id: http://svn.automattic.com/wordpress/trunk@5879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-08-16 18:12:12 +00:00
ryan
9d3d20f063 Use EXTR_SKIP when extracting. see #4468
git-svn-id: http://svn.automattic.com/wordpress/trunk@5708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-06-14 22:45:40 +00:00
ryan
2f09416258 Trim empty lines. Nothing but newline.
git-svn-id: http://svn.automattic.com/wordpress/trunk@5700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-06-14 02:25:30 +00:00
ryan
333d77ea9c Typo fix from flinkflonk. fixes #4347 see #4189
git-svn-id: http://svn.automattic.com/wordpress/trunk@5561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-05-27 17:45:31 +00:00