Dominik Schilling
14e5d77132
Upgrader: Copy WP_Upgrader
subclasses into one file per class.
...
Part 4/8.
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37409
git-svn-id: http://core.svn.wordpress.org/trunk@37375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 11:45:42 +00:00
Dominik Schilling
5f1ac9c96d
Upgrader: Update wp-admin/includes/class-wp-upgrader-skins.php
to require_once
the new files added in [37406].
...
Part 3/8.
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37408
git-svn-id: http://core.svn.wordpress.org/trunk@37374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 11:42:26 +00:00
Dominik Schilling
4b846677ba
Upgrader: Update file headers and class DocBlocks for new files added in [37406].
...
Part 2/8.
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37407
git-svn-id: http://core.svn.wordpress.org/trunk@37373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 11:31:28 +00:00
Dominik Schilling
bbecb1a485
Upgrader: Copy WP_Upgrader_Skin
and its subclasses into one file per class.
...
Part 1/8.
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37406
git-svn-id: http://core.svn.wordpress.org/trunk@37372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 11:11:30 +00:00
Weston Ruter
574be8f2a8
Customize: Ensure that wp_setup_nav_menu_item
filter applies consistently on nav_menu_item
setting values.
...
The filter was being applied in `WP_Customize_Nav_Menu_Item_Setting::value()` but not in `WP_Customize_Nav_Menu_Item_Setting::value_as_wp_post_nav_menu_item()`.
Props celloexpressions, westonruter.
Fixes #35203 .
Built from https://develop.svn.wordpress.org/trunk@37405
git-svn-id: http://core.svn.wordpress.org/trunk@37371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 06:41:29 +00:00
Dominik Schilling
096d0ccd63
Tests: Don't create unused users in Tests_Ajax_DeleteComment
.
...
Fixes #36616 .
Built from https://develop.svn.wordpress.org/trunk@37404
git-svn-id: http://core.svn.wordpress.org/trunk@37370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-09 19:17:29 +00:00
Sergey Biryukov
ff37a3b730
Docs: Fix typo in a comment in check_and_publish_future_post()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@37403
git-svn-id: http://core.svn.wordpress.org/trunk@37369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-08 12:46:29 +00:00
Dominik Schilling
b5718124c3
External Libraries: Replace split()
with explode()
in the deprecated Atom and MagpieRSS files.
...
Before PHP7 `split()` was throwing a deprecated notice, in PHP7 the function is completely removed and throws a fatal error.
Props achbed.
Fixes #20673 .
Built from https://develop.svn.wordpress.org/trunk@37402
git-svn-id: http://core.svn.wordpress.org/trunk@37368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-07 15:59:29 +00:00
Nikolay Bachiyski
c33e975f46
External Libraries: Update plupload from upstream
...
Built from https://develop.svn.wordpress.org/trunk@37383
git-svn-id: http://core.svn.wordpress.org/trunk@37349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-06 18:02:26 +00:00
Dominik Schilling
a493dc0ab5
External Libraries: Update MediaElement.js from upstream.
...
Built from https://develop.svn.wordpress.org/trunk@37370
git-svn-id: http://core.svn.wordpress.org/trunk@37336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-06 17:51:36 +00:00
Sergey Biryukov
b65cbd6003
Options: After [33738], consistently pass option name as the second parameter to the 'default_option_' . $option
filter in add_option()
and update_option()
.
...
Props dlh.
Fixes #36761 .
Built from https://develop.svn.wordpress.org/trunk@37367
git-svn-id: http://core.svn.wordpress.org/trunk@37333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 20:24:29 +00:00
Drew Jaynes
2459e4e880
Docs: Remove backticks from the DocBlock summary for WP::$request
, added in [37356].
...
Markdown formatting is not supported in DocBlock summaries, per the inline documentation standards for PHP :-)
See #32246 . See #36674 .
Built from https://develop.svn.wordpress.org/trunk@37366
git-svn-id: http://core.svn.wordpress.org/trunk@37332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 20:03:27 +00:00
Jeremy Felt
ced66ed4e7
Multisite: Use the admin-multisite Dashicon for sites
...
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.
Uses the more appropriate `dashicons-admin-multisite` when displaying the sites menu item.
Props Ipstenu, ocean90.
Fixes #36754 .
Built from https://develop.svn.wordpress.org/trunk@37365
git-svn-id: http://core.svn.wordpress.org/trunk@37331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 17:13:26 +00:00
Jeremy Felt
db3d5a6bea
Revert [37362], which incorrectly changed Dashicons CSS
...
`dashicons.css` is an external-ish library and the change there is incorrect.
See #36754 .
Built from https://develop.svn.wordpress.org/trunk@37364
git-svn-id: http://core.svn.wordpress.org/trunk@37330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 15:29:27 +00:00
Helen Hou-Sandí
610215ceb1
Revive grunt-rtlcss
, which does not appear to enjoy syntax errors.
...
props netweb.
see #36753 , #29792 .
Built from https://develop.svn.wordpress.org/trunk@37363
git-svn-id: http://core.svn.wordpress.org/trunk@37329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 15:22:27 +00:00
Jeremy Felt
172af4e0ce
Multisite: Use the admin-multisite Dashicon in the admin menu and bar
...
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.
Props Ipstenu.
Fixes #36754 .
Built from https://develop.svn.wordpress.org/trunk@37362
git-svn-id: http://core.svn.wordpress.org/trunk@37328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 04:29:26 +00:00
Helen Hou-Sandí
a800cf654b
Drop Open Sans in the admin in favor of system fonts.
...
Rejoice, for your admins will feel more native to your surrounding computing environment and likely load faster, especially when offline, as they no longer have to talk to The Google Overlord.
At the time of introduction in 3.8, there were not good system fonts common to all platforms at the time. In the years since, Windows, Android, OS X, iOS, Firefox OS, and various flavors of Linux have all gotten their own (good) system UI fonts.
There will definitely be visual bugs, mainly around alignment and spacing; these should be documented and reported on the ticket and fixed more atomically so that our current and future selves have a better understanding of what happened and why.
The style remains registered, as it is almost certainly in use by themes and plugins.
props mattmiklic.
see #36753 .
Built from https://develop.svn.wordpress.org/trunk@37361
git-svn-id: http://core.svn.wordpress.org/trunk@37327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-04 22:07:37 +00:00
Boone Gorges
2d37a0ee17
Users: The 'who' parameter should not interfere with 'meta_key' + 'meta_value' in WP_User_Query
.
...
Props adrianosilvaferreira.
Fixes #36724 .
Built from https://develop.svn.wordpress.org/trunk@37360
git-svn-id: http://core.svn.wordpress.org/trunk@37326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-04 18:57:28 +00:00
Boone Gorges
3c70037d46
Tests: Correct 'meta_query' syntax in test related to WP_User_Query
'who' param.
...
The test, introduced in [32207], used the incorrect syntax for 'meta_query' -
one fewer level of array-nesting than what `WP_Meta_Query` requires. This
slip uncovered a bug introduced into `WP_User_Query` in [30094], whereby
an incorrectly formatted 'meta_query' parameter would be properly parsed by
`WP_User_Query` when passed alongside `who=authors`.
We need to fix the inconsistent syntax in order to resolve #36724 .
See #36724 , #32019 , #23849 , #27026 .
Built from https://develop.svn.wordpress.org/trunk@37359
git-svn-id: http://core.svn.wordpress.org/trunk@37325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-04 18:49:29 +00:00
Boone Gorges
4f4a45ca1c
Tests: Introduce reset_phpmailer_instance()
function.
...
This function provides a more convenient method for resetting the
PHPMailer instance than the previous technique of reaching into the global.
Props welcher.
Fixes #36658 .
Built from https://develop.svn.wordpress.org/trunk@37358
git-svn-id: http://core.svn.wordpress.org/trunk@37324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-04 03:49:26 +00:00
Boone Gorges
0469f12d7b
Add tests for is_serialized_string()
.
...
Props borgesbruno.
Fixes #35952 .
Built from https://develop.svn.wordpress.org/trunk@37357
git-svn-id: http://core.svn.wordpress.org/trunk@37323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-04 03:30:27 +00:00
Eric Lewis
98d5d4919c
Rewrite Rules: Add self-describing variables to rewrite matcher.
...
The rewrite rule matching code in WP::parse_request() used an unclear variable `$request` to represent the requested path (e.g. "2016/05/03") as well as a deceptively named variable `$request_uri`, which actually represents the requested file when an install used PATHINFO links.
Those variables are replaced with `$requested_path` and `$requested_file` respectively for clarity.
Fixes #36674 .
Built from https://develop.svn.wordpress.org/trunk@37356
git-svn-id: http://core.svn.wordpress.org/trunk@37322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-03 19:36:28 +00:00
Drew Jaynes
c7a2b7683b
Docs: Add a missing hook doc for the parse_comment_query
hook, added in [31793].
...
Props flixos90.
See #24826 . Fixes #36740 .
Built from https://develop.svn.wordpress.org/trunk@37355
git-svn-id: http://core.svn.wordpress.org/trunk@37321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-03 16:22:27 +00:00
Boone Gorges
2f66998e3f
date_query
should be a property on WP_Comment_Query
objects.
...
Instead of a local variable.
Props flixos90.
Fixes #36741 .
Built from https://develop.svn.wordpress.org/trunk@37354
git-svn-id: http://core.svn.wordpress.org/trunk@37320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-03 16:15:29 +00:00
Drew Jaynes
ebfc1467bb
Links: Rename the $link_id
parameter in get_link_to_edit()
to $link
to better reflect that it can accept a link ID or object.
...
Props tloureiro for the initial patch.
Fixes #36736 .
Built from https://develop.svn.wordpress.org/trunk@37353
git-svn-id: http://core.svn.wordpress.org/trunk@37319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 23:43:27 +00:00
Weston Ruter
4113ccfc47
Customize: Handle filtering sidebars_widgets
when the underlying option is non-existent.
...
Fixes warning related to a non-array argument for `array_merge()` in `WP_Customize_Widgets::customize_register()`.
See [37166].
See #36389 .
Fixes #36660 .
Built from https://develop.svn.wordpress.org/trunk@37352
git-svn-id: http://core.svn.wordpress.org/trunk@37318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 23:42:28 +00:00
Drew Jaynes
3470faa683
Links: Clarify documentation for the $link_id
parameter to mention that it accepts either an integer or object.
...
Props tloureiro.
See #36736 .
Built from https://develop.svn.wordpress.org/trunk@37351
git-svn-id: http://core.svn.wordpress.org/trunk@37317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 23:40:27 +00:00
Weston Ruter
f98a2ed41d
Customize: Pass WP_Customize_Setting
instance as second argument to customize_value_{$id_base}
filter.
...
Adds parity with setting instance being passed as second argument to `customize_sanitize_{$id}` and `customize_sanitize_js_{$id}`. Allows the actual ID of the (multidimensional) setting value being filtered to be inspected.
Props celloexpressions, westonruter.
Fixes #36452 .
Built from https://develop.svn.wordpress.org/trunk@37350
git-svn-id: http://core.svn.wordpress.org/trunk@37316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 22:42:26 +00:00
Drew Jaynes
5f62db2f21
Comments: Realign parameter documentation in the DocBlocks for comment_author_email_link()
and get_comment_author_email_link()
following [37348].
...
Also adds a missing return description for `get_comment_author_email_link()`.
Props flixos90 for the initial patch.
Fixes #36571 .
Built from https://develop.svn.wordpress.org/trunk@37349
git-svn-id: http://core.svn.wordpress.org/trunk@37315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 20:04:28 +00:00
Drew Jaynes
a6c393828d
Comments: Adjust comment_author_email_link()
and get_comment_author_email_link()
to each accept a new optional fourth parameter, $comment
, which enables overriding the $comment
global.
...
Adds tests.
Props flixos90, boonebgorges, DrewAPicture.
See #36571 .
Built from https://develop.svn.wordpress.org/trunk@37348
git-svn-id: http://core.svn.wordpress.org/trunk@37314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 19:59:27 +00:00
Weston Ruter
3a37220f2a
Customize: Allow Esc key to collapse the currently-expanded panel, section (or control).
...
Pressing Esc collapses any expanded widget or nav menu item controls, or any control that implements the expanding interface. Also improves alignment between `WidgetControl` and `MenuItemControl`, adding the `expanded` state and associated `expand`/`collapse` methods to nav menu items.
Props purcebr, celloexpressions, westonruter.
Fixes #22237 .
Built from https://develop.svn.wordpress.org/trunk@37347
git-svn-id: http://core.svn.wordpress.org/trunk@37313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 19:52:28 +00:00
Weston Ruter
a0d7e83beb
Customize: Ensure settings modified during an open save request remain dirty when save request completes.
...
Also disables Save & Publish button while save request is open. After the save request completes, any settings changed during the request can then be saved via an additional click to the button.
Props chandrapatel, westonruter.
Fixes #32941 .
Built from https://develop.svn.wordpress.org/trunk@37346
git-svn-id: http://core.svn.wordpress.org/trunk@37312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 19:13:26 +00:00
Eric Lewis
aba14233d9
Posts: Allow get_page_uri()
to be called without a $page argument.
...
`get_page_uri()` can now be called without an argument, which will return the page URI for the current post in the loop.
Props pollett.
Fixes #26284 .
Built from https://develop.svn.wordpress.org/trunk@37345
git-svn-id: http://core.svn.wordpress.org/trunk@37311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 18:29:29 +00:00
Drew Jaynes
f3a90cd1a6
Tests: Remove debug cruft left over from [34816].
...
See #17078 .
Built from https://develop.svn.wordpress.org/trunk@37344
git-svn-id: http://core.svn.wordpress.org/trunk@37310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 16:24:29 +00:00
Drew Jaynes
6683100d2c
Docs: Improve the class DocBlock for WP_Widget
to clarify which methods "should" vs "must" be overridden by extending sub-classes.
...
Props Frank-Klein.
Fixes #36703 .
Built from https://develop.svn.wordpress.org/trunk@37343
git-svn-id: http://core.svn.wordpress.org/trunk@37309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 04:53:27 +00:00
Drew Jaynes
fe3b007fdd
Docs: Remove inline @see
tags from function, class, and method references in inline docs.
...
Known functions, classes, and methods are now auto-linked in Code Reference pages following #meta1483.
Note: Hook references are still linked via inline `@see` tags due to the unlikelihood of reliably matching for known hooks based on a RegEx pattern.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@37342
git-svn-id: http://core.svn.wordpress.org/trunk@37308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 04:00:28 +00:00
Dominik Schilling
9354965638
Customize: Increase the target size of the expand/collapse button in the customizer.
...
To improve accessibility on touch devices increase the size of the button in the collapsed view from 24×28 to 44×45 pixel.
Props celloexpressions.
Fixes #36093 .
Built from https://develop.svn.wordpress.org/trunk@37341
git-svn-id: http://core.svn.wordpress.org/trunk@37307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 20:29:27 +00:00
Dominik Schilling
f0962c42ab
Travis CI: Include npm prune
in the before_script
command.
...
Caching of node modules was added in [37058]. `npm prune` removes extraneous packages so the cache contains only current modules.
Props netweb.
Fixes #36490 .
Built from https://develop.svn.wordpress.org/trunk@37340
git-svn-id: http://core.svn.wordpress.org/trunk@37306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 20:04:27 +00:00
Dominik Schilling
823ec71cd6
Customize: Don't auto-close the customizer when a new theme is activated.
...
Props celloexpressions.
Fixes #35320 .
Built from https://develop.svn.wordpress.org/trunk@37339
git-svn-id: http://core.svn.wordpress.org/trunk@37305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 19:54:27 +00:00
Drew Jaynes
664bb85f1b
Docs: Add backtick escaping for two inline code samples in docs.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@37338
git-svn-id: http://core.svn.wordpress.org/trunk@37304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 17:32:26 +00:00
Drew Jaynes
0055c9746c
Docs: Standardize on using ::
for Class::method()
references in WP_Customize_Control` inline docs.
...
See #32246 . See #meta1483.
Built from https://develop.svn.wordpress.org/trunk@37337
git-svn-id: http://core.svn.wordpress.org/trunk@37303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 17:28:27 +00:00
Andrea Fercia
22bae92301
Themes: restore Theme Installer missing spinner.
...
Fixes #36730 .
Built from https://develop.svn.wordpress.org/trunk@37336
git-svn-id: http://core.svn.wordpress.org/trunk@37302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 15:43:27 +00:00
Sergey Biryukov
dc5815146e
Dashboard: Display the comment counts in wp_dashboard_right_now()
in the rare initial condition when there are 0 approved comments and only pending comments, so the AJAX count update could work.
...
Props afercia.
Fixes #35519 .
Built from https://develop.svn.wordpress.org/trunk@37335
git-svn-id: http://core.svn.wordpress.org/trunk@37301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 11:06:28 +00:00
Sergey Biryukov
49a47bb255
Docs: Document the @return
value of wp_add_trashed_suffix_to_post_name_for_post()
.
...
Props Shelob9.
Fixes #36728 .
Built from https://develop.svn.wordpress.org/trunk@37334
git-svn-id: http://core.svn.wordpress.org/trunk@37300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 10:16:29 +00:00
Weston Ruter
6693acdb24
Widgets: Provide PHP 5.2 fallback for spl_object_hash()
if disabled in logic for registering and unregistering pre-instantiated widgets.
...
Fixes #28216 .
Built from https://develop.svn.wordpress.org/trunk@37333
git-svn-id: http://core.svn.wordpress.org/trunk@37299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-30 22:36:28 +00:00
Dominik Schilling
4b51bc18cc
Plugins: In plugin_basename()
normalize the file path before unresolving symlinks.
...
`$wp_plugin_paths` contains normalized paths, see `wp_register_plugin_realpath()`.
Props jdgrimes, voldemortensen, flyingdr, ocean90.
Fixes #29154 .
Built from https://develop.svn.wordpress.org/trunk@37332
git-svn-id: http://core.svn.wordpress.org/trunk@37298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-30 15:09:27 +00:00
Dominik Schilling
697a6d5560
Plugins: In uninstall_plugin()
pass the plugin file to wp_register_plugin_realpath()
.
...
`wp_register_plugin_realpath()` calls `dirname( $file );` to remove the basename. The basename must be included in the argument or the symlinked directory won't be registered.
Props andy.
Fixes #36709 .
Built from https://develop.svn.wordpress.org/trunk@37331
git-svn-id: http://core.svn.wordpress.org/trunk@37297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-30 15:04:27 +00:00
Andrea Fercia
93c8cdbaed
Accessibility: improve the Star Ratings hiding empty elements for assistive technologies.
...
Fixes #36725 .
Built from https://develop.svn.wordpress.org/trunk@37330
git-svn-id: http://core.svn.wordpress.org/trunk@37296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-30 14:33:29 +00:00
Weston Ruter
96104fdd30
Widgets: Allow WP_Widget
subclass instances (objects) to be registered/unregistered in addition to WP_Widget
subclass names (strings).
...
Allows widgets to be registered which rely on dependency injection. Also will allow for new widget types to be created dynamically (e.g. a Recent Posts widget for each registered post type).
See #35990 .
Props mdwheele, PeterRKnight, westonruter.
Fixes #28216 .
Built from https://develop.svn.wordpress.org/trunk@37329
git-svn-id: http://core.svn.wordpress.org/trunk@37295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-29 18:49:26 +00:00
Scott Taylor
fb82d557cd
Media/Unit Tests: ensure that image sizes are indeed removed when errors are raised before assertions in Tests_Media
.
...
See #36588 .
Built from https://develop.svn.wordpress.org/trunk@37328
git-svn-id: http://core.svn.wordpress.org/trunk@37294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-29 17:52:29 +00:00