Scott Taylor
03dda3b273
Introduce maybe_regenerate_attachment_metadata( $attachment )
. On the Edit Media screen, call it for Audio and Video files.
...
The functions checks if the item is lacking metadata altogether. If a video or audio file was uploaded prior to 3.6, it does not have any metadata. This tries to fix it. Implements locking via a transient to protect against this running in parallel with another request.
This is the minimum viable product for #26825 , but leaving the ticket open unless this function needs to be called in other places.
See #26825 .
Built from https://develop.svn.wordpress.org/trunk@27127
git-svn-id: http://core.svn.wordpress.org/trunk@26994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 22:41:12 +00:00
Scott Taylor
f1fff8a2e9
Add some inline docs to media-views.js
and remove some unnecessary comments from a few super
calls.
...
Props gcorne.
See #26870 .
Built from https://develop.svn.wordpress.org/trunk@27126
git-svn-id: http://core.svn.wordpress.org/trunk@26993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 20:21:12 +00:00
Scott Taylor
75d8688f60
When a term_id
matches in _get_term_children()
, recurse through its children until there is no more depth in the hierarchy. Since get_terms()
return terms with a count
of 0
when their children are not empty, we must return all children so that get_terms()
can check their count.
...
In [27108], #26903 was fixed, but only because we were using the example in the ticket, leaving out infinite depth for hierarchical taxonomies.
Adds unit tests, including `Tests_Term_getTerms::test_get_terms_seven_levels_deep()`.
Fixes #26903 . Again.
Built from https://develop.svn.wordpress.org/trunk@27125
git-svn-id: http://core.svn.wordpress.org/trunk@26992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 19:53:12 +00:00
Lance Willett
27097dea2c
Twenty Fourteen: fix Ephemera Widget to avoid showing full post content when displayed in single post or page. Restore the global $more
to its original value after the widget output to avoid any issues caused by changing a global variable.
...
Props obenland, mor10, Frank Klein. See #26961 .
Built from https://develop.svn.wordpress.org/trunk@27124
git-svn-id: http://core.svn.wordpress.org/trunk@26991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 18:03:13 +00:00
Lance Willett
ca16d41ac2
Twenty Fourteen: pinking shears.
...
Built from https://develop.svn.wordpress.org/trunk@27123
git-svn-id: http://core.svn.wordpress.org/trunk@26990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 18:02:13 +00:00
Lance Willett
c2f46ac811
Twenty Fourteen: translate featured
tag slug used to link to specific tags in Posts editor. See #26526 .
...
Built from https://develop.svn.wordpress.org/trunk@27122
git-svn-id: http://core.svn.wordpress.org/trunk@26989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 17:47:11 +00:00
Lance Willett
513202d24f
Twenty Fourteen: fix unreachable links when the content area is shorter than the sidebar in smaller viewpoints. Props celloexpressions, see #26782 .
...
Built from https://develop.svn.wordpress.org/trunk@27121
git-svn-id: http://core.svn.wordpress.org/trunk@26988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 17:43:11 +00:00
Lance Willett
88a2fe2986
Twenty Fourteen: delete the featured_content_ids
transient on theme switch to make sure child themes can override the Featured Content quantity value. Also remove quantity parameter so child themes can change the amount of featured posts with $max_posts
.
...
Props obenland, see #26660 .
Built from https://develop.svn.wordpress.org/trunk@27120
git-svn-id: http://core.svn.wordpress.org/trunk@26987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 17:39:13 +00:00
Sergey Biryukov
8363d0660b
Use .screen-reader-text class instead of an alt attribute for overlay button labels on Themes screen.
...
props bramd.
fixes #26603 for trunk.
Built from https://develop.svn.wordpress.org/trunk@27119
git-svn-id: http://core.svn.wordpress.org/trunk@26986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 17:33:12 +00:00
Lance Willett
31e9d97412
Twenty Fourteen: make sure featured
tag is hidden on front-end views as expected. Add a check for the tag name in case we're using default values and the default ID of 0
does not match the term id of the featured
tag.
...
Props obenland, fixes #26732 .
Built from https://develop.svn.wordpress.org/trunk@27118
git-svn-id: http://core.svn.wordpress.org/trunk@26985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 17:17:13 +00:00
Lance Willett
ab9e603c00
Twenty Fourteen: fix gap above static pages, props SergeyBiryukov. Fixes #26694 .
...
Built from https://develop.svn.wordpress.org/trunk@27117
git-svn-id: http://core.svn.wordpress.org/trunk@26984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 17:11:12 +00:00
Sergey Biryukov
1f86e0c1e1
Fix typo in wp_set_auth_cookie() description.
...
props drozdz.
fixes #27046 .
Built from https://develop.svn.wordpress.org/trunk@27116
git-svn-id: http://core.svn.wordpress.org/trunk@26983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 09:47:12 +00:00
Andrew Nacin
084a7b50cd
Use a float for last_changed microtime cache values.
...
microtime() by default returns a string with a space, which isn't allowed for keys in some cache backends.
props _jameslee, drozdz.
fixes #27000 . see #23448 .
Built from https://develop.svn.wordpress.org/trunk@27115
git-svn-id: http://core.svn.wordpress.org/trunk@26982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 08:14:12 +00:00
Andrew Nacin
d4f8de5c92
Revisions browser: The back button should return to the post you were editing (use replaceState instead of pushState).
...
props adamsilverstein.
fixes #26997 .
Built from https://develop.svn.wordpress.org/trunk@27114
git-svn-id: http://core.svn.wordpress.org/trunk@26981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-06 23:28:12 +00:00
Andrew Nacin
784d3071c9
Add imgur to the list of oEmbed providers.
...
props bradparbs.
fixes #21632 .
Built from https://develop.svn.wordpress.org/trunk@27113
git-svn-id: http://core.svn.wordpress.org/trunk@26980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-06 23:12:12 +00:00
Andrew Nacin
182903034b
Network install: When showing the path to wp-config.php make sure our slashes are normalized.
...
props VarunAgw.
fixes #27025 .
Built from https://develop.svn.wordpress.org/trunk@27112
git-svn-id: http://core.svn.wordpress.org/trunk@26979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-06 22:22:13 +00:00
Andrew Nacin
12a64b39db
Fix the conditional enqueueing/printing of colors stylesheets, without breaking dependencies.
...
fixes #18380 .
see #20729 which should properly fix this.
Built from https://develop.svn.wordpress.org/trunk@27111
git-svn-id: http://core.svn.wordpress.org/trunk@26978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-06 22:16:11 +00:00
Andrew Ozz
5ea367cfe1
Fix scrolling inside the Visual editor on MacOS, add the same functionality to the Text editor, see #27013
...
Built from https://develop.svn.wordpress.org/trunk@27110
git-svn-id: http://core.svn.wordpress.org/trunk@26977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-06 19:34:12 +00:00
Helen Hou-Sandí
b2e6ad7c32
Fix some hover/focus styling and specificity issues. see #18380 .
...
Built from https://develop.svn.wordpress.org/trunk@27109
git-svn-id: http://core.svn.wordpress.org/trunk@26976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-06 17:57:13 +00:00
Scott Taylor
c2b712e3b9
In get_terms()
, don't set automatically hierarchical
to false
when parent => 0
is passed. The default value for parent
is ''
.
...
In `_get_term_children()`, don't skip a top-level term without first including its children in the returned term list. Ironically, the call to `_get_term_children()` in `get_terms()` has a comment stating `"Make sure we show empty categories that have children."`, but it didn't work if you were retrieving top-level categories only.
All unit tests pass. Added a unit test based on the use case described in this ticket.
Fixes #26903 .
Built from https://develop.svn.wordpress.org/trunk@27108
git-svn-id: http://core.svn.wordpress.org/trunk@26975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-06 17:45:12 +00:00
Helen Hou-Sandí
9419dc2fe0
Some tweaks to [27106]:
...
* Add more @todo markings and remove one that's been resolved.
* Restore a missing comma in a `.wp-badge` background rule, and add a comment reminding us why it's there.
see #18380 .
Built from https://develop.svn.wordpress.org/trunk@27107
git-svn-id: http://core.svn.wordpress.org/trunk@26974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-06 07:08:13 +00:00
Helen Hou-Sandí
0100dd772a
Merge colors.css into wp-admin.css. Non-default color schemes became overloads rather than swaps in the 3.8 redesign. Benefits include:
...
* No more border-width, border-style, border-color insanity.
* Point releases are much less likely to require extra finagling to avoid rebuilding the color schemes.
* Yours truly has a better overall vision of ~14,000 lines of admin CSS and where we go from here.
1,065 net lines of red, y'all.
props helen, jorbin. fixes #18380 .
Built from https://develop.svn.wordpress.org/trunk@27106
git-svn-id: http://core.svn.wordpress.org/trunk@26973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-06 06:25:18 +00:00
Andrew Nacin
6169e8662b
JSHint fixes for media-views and Gruntfile.
...
props gcorne.
fixes #27032 , #27033 .
Built from https://develop.svn.wordpress.org/trunk@27105
git-svn-id: http://core.svn.wordpress.org/trunk@26972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-06 05:32:12 +00:00
Scott Taylor
5d03d8eb50
Regenerate the term hierarchy cache ({taxonomy}_children
) when it is out of sync with the passed taxonomy's last_changed
value.
...
Introduces `taxonomy_hierarchy_is_fresh()`, which is only called in `_get_term_hierarchy()`. The taxonomy's `last_changed` value is checked against the value of `wp_cache_get( 'hierarchy_last_changed', $taxonomy )`.
Adds a unit test - `Tests_Term:test_hierachy_invalidation()`.
See [27101], which makes this type of cache invalidation possible.
Fixes #14485 .
Built from https://develop.svn.wordpress.org/trunk@27102
git-svn-id: http://core.svn.wordpress.org/trunk@26971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-06 01:58:14 +00:00
Scott Taylor
578dbcd9f5
Add cache invalidation when updating a term, example: create a category, assign it to a post, edit the category. Currently, the post's term cache is not updated. When updating terms in a given taxonomy, invalidate the object term caches linked to that taxonomy.
...
Introduce `get_taxonomy_last_changed()`, `set_taxonomy_last_changed()`, and `post_taxonomy_is_fresh()`.
`post_taxonomy_is_fresh()` is only called in `get_object_term_cache()` - at which point the taxonomy's `last_changed` value is checked against the post's `{$taxonomy}_last_changed` value.
`set_taxonomy_last_changed()` is called whenever directory database queries are made that insert new terms or affect existing terms.
Fixes #22526 .
Built from https://develop.svn.wordpress.org/trunk@27101
git-svn-id: http://core.svn.wordpress.org/trunk@26970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-06 01:41:12 +00:00
Andrew Ozz
c4f8dede57
TinyMCE: set the proper caption width when clicking image resize handle on image with caption. Props gcorne, fixes #27009 , see #24067 .
...
Built from https://develop.svn.wordpress.org/trunk@27098
git-svn-id: http://core.svn.wordpress.org/trunk@26969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-05 02:07:13 +00:00
Scott Taylor
228fc639b9
When a video shortcode has content in its body, append it as inner HTML in the resulting <video>
.
...
Reverts [27096].
Fixes #26628 .
See #27016 .
Built from https://develop.svn.wordpress.org/trunk@27097
git-svn-id: http://core.svn.wordpress.org/trunk@26968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-05 01:43:12 +00:00
Andrew Ozz
5e08452f49
TinyMCE: don't scroll the main window when scrolling the editor content with a mouse wheel or trackpad and reaching the end. Fixes #27013 .
...
Built from https://develop.svn.wordpress.org/trunk@27095
git-svn-id: http://core.svn.wordpress.org/trunk@26967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-05 01:10:13 +00:00
Andrew Ozz
98cb4984c0
Consolidate handling of <object>, <audio> and <video> in wpautop() and add unit tests for them. Part props wonderboymusic, see #26864
...
Built from https://develop.svn.wordpress.org/trunk@27094
git-svn-id: http://core.svn.wordpress.org/trunk@26966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-05 00:46:12 +00:00
Andrew Ozz
5ce168941a
When using wp_editor(), make it easier to specify which editor is shown first, fixes #20822
...
Built from https://develop.svn.wordpress.org/trunk@27093
git-svn-id: http://core.svn.wordpress.org/trunk@26965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-05 00:34:12 +00:00
Andrew Nacin
9edfc740fd
Autosave: Fix typo in event namespace. props avryl, see #25272 .
...
Built from https://develop.svn.wordpress.org/trunk@27092
git-svn-id: http://core.svn.wordpress.org/trunk@26964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-04 16:07:12 +00:00
Andrew Nacin
c5802858cc
Default themes: Use the 'display' filter for get_bloginfo( 'name' ) attached to the wp_title filter.
...
props michelwppi.
fixes #26811 .
Built from https://develop.svn.wordpress.org/trunk@27091
git-svn-id: http://core.svn.wordpress.org/trunk@26963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-04 13:57:12 +00:00
Drew Jaynes
68f9370ae9
Inline documentation for hooks in wp-admin/includes/class-wp-ms-themes-list-table.php.
...
Also marks two hooks in wp-admin/includes/class-wp-themes-list-table.php as duplicates.
Props ShinichiN, kpdesign, DrewAPicture.
Fixes #25608 .
Built from https://develop.svn.wordpress.org/trunk@27090
git-svn-id: http://core.svn.wordpress.org/trunk@26962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-04 08:25:13 +00:00
Drew Jaynes
771f8dc244
Inline documentation for hooks in wp-admin/includes/class-wp-terms-list-table.php.
...
Props Ajay, kpdesign.
Fixes #26209 .
Built from https://develop.svn.wordpress.org/trunk@27089
git-svn-id: http://core.svn.wordpress.org/trunk@26961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-04 07:56:12 +00:00
Drew Jaynes
c858b251b6
Inline documentation for hooks in wp-admin/network/sites.php.
...
Props NikV, kpdesign.
Fixes #26124 .
Built from https://develop.svn.wordpress.org/trunk@27088
git-svn-id: http://core.svn.wordpress.org/trunk@26960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-04 07:49:14 +00:00
Scott Taylor
274d2925b9
Invalidate the post cache for posts associated with a user who has been removed from a blog in remove_user_from_blog()
. Adds a unit test.
...
Props nprasath002 for the initial patch.
Fixes #25545 .
Built from https://develop.svn.wordpress.org/trunk@27087
git-svn-id: http://core.svn.wordpress.org/trunk@26959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-04 04:13:12 +00:00
Andrew Ozz
93d3e3efb6
Minor cleanup (jshint) of wp-fullscreen.js and /wordpress/plugin.js, see #24067
...
Built from https://develop.svn.wordpress.org/trunk@27085
git-svn-id: http://core.svn.wordpress.org/trunk@26958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-03 21:31:13 +00:00
Andrew Ozz
2726713764
Add back missing var definition in wplink.js, props TobiasBg, see #24067
...
Built from https://develop.svn.wordpress.org/trunk@27084
git-svn-id: http://core.svn.wordpress.org/trunk@26957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-03 21:27:12 +00:00
Andrew Ozz
12b6085865
TinyMCE: don't replace <i> with <em> and <b> with <strong> and don't remove them when empty, see #24067 , see #23037 .
...
Built from https://develop.svn.wordpress.org/trunk@27083
git-svn-id: http://core.svn.wordpress.org/trunk@26956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-03 20:26:12 +00:00
Sergey Biryukov
e35d675558
Add braces around conditionals. props TobiasBg. fixes #25704 .
...
Built from https://develop.svn.wordpress.org/trunk@27082
git-svn-id: http://core.svn.wordpress.org/trunk@26955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-03 20:17:11 +00:00
Scott Taylor
4830eeb9ad
Properly invalidate the cache for wp_count_posts()
on insert, trash, or when transitioning post_status
inside of _transition_post_status()
. Introduces _count_posts_cache_key()
. Adds unit tests.
...
Props mark8barnes, for bringing this to our attention in an initial patch.
Fixes #21879 .
Built from https://develop.svn.wordpress.org/trunk@27081
git-svn-id: http://core.svn.wordpress.org/trunk@26954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-03 19:42:13 +00:00
Andrew Ozz
2f6d9d37cc
Consolidate "close on Escape" in the media modal, DFW, wpLink and Thickbox. Props kovshenin, fixes #26854 .
...
Built from https://develop.svn.wordpress.org/trunk@27080
git-svn-id: http://core.svn.wordpress.org/trunk@26953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-03 05:31:14 +00:00
Andrew Ozz
87c3c8adc0
Open previews of different posts in different windows/tabs. Prevent confusion when using a former preview window again if the user navigated to edit another post. If the first post is still being edited, clicking Preview there will use the current window to show the preview. Props ippetkov, fixes #20233 .
...
Built from https://develop.svn.wordpress.org/trunk@27079
git-svn-id: http://core.svn.wordpress.org/trunk@26952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 23:50:13 +00:00
Andrew Ozz
7e7723f1de
Editor: add :focus style for the Quicktags buttons, fixes #26932
...
Built from https://develop.svn.wordpress.org/trunk@27078
git-svn-id: http://core.svn.wordpress.org/trunk@26951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 22:38:12 +00:00
Andrew Nacin
39e32ed1eb
Consistently trim and unslash search queries for the users list tables.
...
props aubreypwd.
fixes #26115 .
Built from https://develop.svn.wordpress.org/trunk@27077
git-svn-id: http://core.svn.wordpress.org/trunk@26950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 22:10:12 +00:00
Andrew Nacin
fb3985663a
Remove an unnecessary variable passed to wpdb::prepare() during multisite load.
...
props jeremyfelt.
fixes #26941 .
Built from https://develop.svn.wordpress.org/trunk@27076
git-svn-id: http://core.svn.wordpress.org/trunk@26949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 22:09:12 +00:00
Andrew Nacin
43c7993c1a
When the MySQL server has "gone away," attempt to reconnect and retry the query.
...
props pento.
see #5932 .
Built from https://develop.svn.wordpress.org/trunk@27075
git-svn-id: http://core.svn.wordpress.org/trunk@26948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 22:07:12 +00:00
Andrew Nacin
17828876fa
Add a comment for [27073] as someone will inevitably complain it is tricked by % in a string. see #25604 .
...
Built from https://develop.svn.wordpress.org/trunk@27074
git-svn-id: http://core.svn.wordpress.org/trunk@26947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 21:48:13 +00:00
Andrew Nacin
9c4a97c676
Throw an incorrect usage notice when the query argument of wpdb::prepare() does not include a placeholder.
...
props ounziw.
fixes #25604 .
Built from https://develop.svn.wordpress.org/trunk@27073
git-svn-id: http://core.svn.wordpress.org/trunk@26946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 21:47:11 +00:00
Andrew Nacin
9f250b2ef7
Ensure compatibility with MySQL 5.6 which has stricter SQL modes by default.
...
Disables NO_ZERO_DATE, ONLY_FULL_GROUP_BY, STRICT_TRANS_TABLES, STRICT_ALL_TABLES, TRADITIONAL. Introduces wpdb::set_sql_mode() with an incompatible_sql_modes filter so a plugin can alter the set mode after the fact.
props pento.
fixes #26847 .
Built from https://develop.svn.wordpress.org/trunk@27072
git-svn-id: http://core.svn.wordpress.org/trunk@26945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 21:39:13 +00:00