Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-26 19:18:57 +01:00
Code Issues Projects Releases Wiki Activity
34,508 Commits 50 Branches 749 Tags 806 MiB
168eac2ed4
Commit Graph

8230 Commits

Author SHA1 Message Date
Drew Jaynes
6c34bf08a1 Docs: Add missing documentation for the style argument in the DocBlock for wp_list_categories(). 
Props birgire for the initial patch.
See #36693.

Built from https://develop.svn.wordpress.org/trunk@37569


git-svn-id: http://core.svn.wordpress.org/trunk@37537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-25 19:35:37 +00:00
Drew Jaynes
ecf5a924fe Docs: Add missing @access tags to methods in WP_oEmbed_Controller. 
See [34903].

Props ramiy.
Fixes #36297.

Built from https://develop.svn.wordpress.org/trunk@37568


git-svn-id: http://core.svn.wordpress.org/trunk@37536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-25 19:22:27 +00:00
Boone Gorges
267cc99293 Fix termmeta pre-fetching in wp_get_object_terms(). 
[34529] introduced logic intended to prime the termmeta cache for certain
values of the `fields` parameter. There were a few bugs:

* The `all_with_object_id` param was misspelled.
* `term_id` was used instead of `ids`.
* The values being passed to `update_termmeta_cache()` in the case where `fields=ids` was not correct.

All of these would result in a failure to pre-fetch termmeta in some cases.

Props dlh.
Fixes #36932.
Built from https://develop.svn.wordpress.org/trunk@37567


git-svn-id: http://core.svn.wordpress.org/trunk@37535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-25 18:44:29 +00:00
Drew Jaynes
a74fae7bd6 Posts: Add test coverage for get_preview_post_link(). 
Props swissspidy.
Fixes #35915.

Built from https://develop.svn.wordpress.org/trunk@37566


git-svn-id: http://core.svn.wordpress.org/trunk@37534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-25 18:31:28 +00:00
Boone Gorges
20301c4f6f In get_bookmarks(), don't cache if 'orderby=rand'. 
Props lukecavanagh, prettyboymp, c3mdigital, MikeHansenMe.
Fixes #18356.
Built from https://develop.svn.wordpress.org/trunk@37565


git-svn-id: http://core.svn.wordpress.org/trunk@37533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-25 18:29:28 +00:00
Drew Jaynes
e7e20e4b54 Docs: Update the return description for get_preview_post_link() to note that it can also return null. 
Props chris_dev, swissspidy.
See #35915.

Built from https://develop.svn.wordpress.org/trunk@37564


git-svn-id: http://core.svn.wordpress.org/trunk@37532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-25 18:25:28 +00:00
Boone Gorges
6c8bcef213 Add tests for get_bookmarks() cache. 
This changeset adds a unit test factory so that bookmark/link fixtures can be
created during tests.

Why are we writing tests for functionality that has been deprecated for years?
Because it's the Right Thing to Do.

See #18356.
Built from https://develop.svn.wordpress.org/trunk@37563


git-svn-id: http://core.svn.wordpress.org/trunk@37531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-25 18:21:30 +00:00
Dominik Schilling
6b51ac4956 Plugins: In get_plugin_data() use the plugin slug for the text domain when no text domain is defined in the header. 
Fixes #36706.
Built from https://develop.svn.wordpress.org/trunk@37562


git-svn-id: http://core.svn.wordpress.org/trunk@37530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-25 16:54:28 +00:00
Drew Jaynes
318f745808 Docs: Correct DocBlock descriptions for the $before, $after, $link_before, and $link_after arguments for wp_nav_menu(). 
* `$before` falls before the link markup starts
* `$after` falls after the link markup ends
* `$link_before` falls before the link text
* `$link_after` falls after the link text

Props wp_smith for the initial patch.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@37561


git-svn-id: http://core.svn.wordpress.org/trunk@37529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-25 16:17:27 +00:00
Drew Jaynes
bef05b469b Docs: Standardize DocBlock summaries for hooks that serve to "print" something to use third-person singular verbs. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37560


git-svn-id: http://core.svn.wordpress.org/trunk@37528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-25 16:05:27 +00:00
Ella Iseulde Van Dorpe
cf51b75834 TinyMCE: fix inline toolbar positioning 
Introduced in [37000].
See 2fb8aa48e9.
See 5734a8d880.

Fixes #36876.


Built from https://develop.svn.wordpress.org/trunk@37559


git-svn-id: http://core.svn.wordpress.org/trunk@37527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-25 15:13:28 +00:00
Drew Jaynes
62d4798863 Docs: Update hook docs for the upgrader_package_options filter and upgrader_process_complete action to reflect expected values in the core, language pack, theme, and plugin contexts. 
Props nextendweb for the initial patch.
See [37550]. Fixes #36875.

Built from https://develop.svn.wordpress.org/trunk@37558


git-svn-id: http://core.svn.wordpress.org/trunk@37526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-25 14:45:27 +00:00
Ella Iseulde Van Dorpe
294f2c98f1 Media: adjust test after [37556] 
See #36888.


Built from https://develop.svn.wordpress.org/trunk@37557


git-svn-id: http://core.svn.wordpress.org/trunk@37525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-25 14:06:27 +00:00
Ella Iseulde Van Dorpe
2934f338cf Media: unhide audio fallback 
Introduced in [28182].
Fixes #36888.


Built from https://develop.svn.wordpress.org/trunk@37556


git-svn-id: http://core.svn.wordpress.org/trunk@37524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-25 13:33:29 +00:00
Gary Pendergast
e8660d53a2 Tests: Upgrade the HHVM job to use Ubuntu Trusty, and a more recent version of HHVM. 
Also includes some tidying up of the `.travis.yml` file.

Props netweb.

Fixes #36930.


Built from https://develop.svn.wordpress.org/trunk@37555


git-svn-id: http://core.svn.wordpress.org/trunk@37523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-25 06:12:30 +00:00
Dominik Schilling
8369b778e1 I18N: Update list of continents and cities for the timezone selection. 
Fixes #36828.
Built from https://develop.svn.wordpress.org/trunk@37554


git-svn-id: http://core.svn.wordpress.org/trunk@37522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-24 23:24:27 +00:00
Dominik Schilling
76ade1b21d Dashboard: Improve grammar for WordPress News help text. 
Also, move planet URL to a separate string to match the URL which is used for the feed.

Props ramiy for initial patch.
Fixes #35681.
Built from https://develop.svn.wordpress.org/trunk@37553


git-svn-id: http://core.svn.wordpress.org/trunk@37521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-24 21:22:28 +00:00
Dominik Schilling
d23b1534b8 I18N: Add translators comments to wp-activate.php. 
Props ramiy.
Fixes #35734.
Built from https://develop.svn.wordpress.org/trunk@37552


git-svn-id: http://core.svn.wordpress.org/trunk@37520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-24 21:02:28 +00:00
Dominik Schilling
2d1c27e8b4 I18N: Add translators comments to wp-signup.php. 
Props ramiy.
Fixes #35730.
Built from https://develop.svn.wordpress.org/trunk@37551


git-svn-id: http://core.svn.wordpress.org/trunk@37519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-24 20:44:29 +00:00
Drew Jaynes
ada2858cd9 Docs: Fix the hook doc for upgrader_process_complete to notate all values that might be present in the hook_extra array in the various update contexts. 
h/t Nextendweb.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@37550


git-svn-id: http://core.svn.wordpress.org/trunk@37518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-24 17:52:30 +00:00
Gary Pendergast
733ccfe08a Embeds: Ensure embed widths are integers. 
This prevents a warning in PHP trunk when a non-integer width is passed.

See #36435.


Built from https://develop.svn.wordpress.org/trunk@37549


git-svn-id: http://core.svn.wordpress.org/trunk@37517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-24 06:15:28 +00:00
Gary Pendergast
2441b7b52f Database: Don't generate unnecessary warnings in wpdb::query(). 
In the event that the database has gone away for some reason, calls to `mysqli_errno()` and `mysqli_error()` (and their `ext/mysql` equivalents, of course), will generate PHP warnings, which are unsightly, and not how we do things in these parts.

Props mbijon, craig-ralston for the original patch.

Fixes #23085.


Built from https://develop.svn.wordpress.org/trunk@37548


git-svn-id: http://core.svn.wordpress.org/trunk@37516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-24 05:24:26 +00:00
Jeremy Felt
6c405b8f36 Multisite: Clean up WP_Error documentation and handling in wp-signup.php 
Fixes #36927.

Built from https://develop.svn.wordpress.org/trunk@37547


git-svn-id: http://core.svn.wordpress.org/trunk@37515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-24 04:16:27 +00:00
Jeremy Felt
a021ab4ce0 Multisite: Disable autocapitalize and autocorrect for user_name input on signup 
Props rafaelangeline.
Fixes #36833.

Built from https://develop.svn.wordpress.org/trunk@37546


git-svn-id: http://core.svn.wordpress.org/trunk@37514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-24 03:43:27 +00:00
Drew Jaynes
6d7abb8fd3 Docs: The $context parameter in remove_meta_box() is not optional. 
Fixes a copy pasta error introduced in [34952].

Props travisnorthcutt.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@37545


git-svn-id: http://core.svn.wordpress.org/trunk@37513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 20:57:28 +00:00
Drew Jaynes
9193013158 Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files. 
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.

Fixes #36921.

Built from https://develop.svn.wordpress.org/trunk@37544


git-svn-id: http://core.svn.wordpress.org/trunk@37512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 19:02:28 +00:00
Drew Jaynes
d28f1a08ef Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files. 
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.

See #36921.

Built from https://develop.svn.wordpress.org/trunk@37543


git-svn-id: http://core.svn.wordpress.org/trunk@37511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 19:01:27 +00:00
Drew Jaynes
da78aeffe9 Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files. 
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.

See #36921.

Built from https://develop.svn.wordpress.org/trunk@37542


git-svn-id: http://core.svn.wordpress.org/trunk@37510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 18:59:27 +00:00
Drew Jaynes
9549a46d7c Docs: Apply inline @see tags to hooks referenced in DocBlocks in wp-includes/general-template.php. 
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.

See #36921.

Built from https://develop.svn.wordpress.org/trunk@37541


git-svn-id: http://core.svn.wordpress.org/trunk@37509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 18:57:28 +00:00
Drew Jaynes
e0408b36ca Docs: Apply inline @see tags to hooks referenced in DocBlocks in wp-includes/ms-functions.php. 
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.

See #36921.

Built from https://develop.svn.wordpress.org/trunk@37540


git-svn-id: http://core.svn.wordpress.org/trunk@37508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 18:56:27 +00:00
Drew Jaynes
fb6d8bae49 Docs: Apply inline @see tags to hooks referenced in DocBlocks for core classes. 
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.

See #36921.

Built from https://develop.svn.wordpress.org/trunk@37539


git-svn-id: http://core.svn.wordpress.org/trunk@37507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 18:54:27 +00:00
Dominik Schilling
a5b8dca864 Database: Support backticks around field names when parsing a query for the field type. 
Avoids an undefined index PHP warning by `dbDelta()`.

Props davidmosterd, ocean90.
See #20263.
Built from https://develop.svn.wordpress.org/trunk@37538


git-svn-id: http://core.svn.wordpress.org/trunk@37506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 18:12:28 +00:00
Drew Jaynes
1947f4d17c Docs: Apply inline @see tags to hooks referenced in DocBlocks for wp-admin/* files. 
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.

See #36921.

Built from https://develop.svn.wordpress.org/trunk@37537


git-svn-id: http://core.svn.wordpress.org/trunk@37505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 17:28:27 +00:00
Drew Jaynes
e52762a725 Docs: Apply inline @see tags to hooks referenced in DocBlocks for root directory files. 
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as hooks.

See #36921.

Built from https://develop.svn.wordpress.org/trunk@37536


git-svn-id: http://core.svn.wordpress.org/trunk@37504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 17:07:28 +00:00
Drew Jaynes
f82641ad0e Docs: Standardize filter docs in root folder files to use third-person singular verbs per the inline documentation standards for PHP. 
Fixes #36913.

Built from https://develop.svn.wordpress.org/trunk@37535


git-svn-id: http://core.svn.wordpress.org/trunk@37503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 16:44:27 +00:00
Drew Jaynes
11d6f0712e Docs: Update the return notation for get_current_screen() to note that null can also be returned if the screen has not been defined. 
Props screamingdev.
Fixes #36382.

Built from https://develop.svn.wordpress.org/trunk@37534


git-svn-id: http://core.svn.wordpress.org/trunk@37502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 16:34:28 +00:00
Dominik Schilling
00487d5762 Database: Remove debug comments in dbDelta(). 
Built from https://develop.svn.wordpress.org/trunk@37533


git-svn-id: http://core.svn.wordpress.org/trunk@37501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 15:04:28 +00:00
Dominik Schilling
e5a87afb29 Database: Reduce the number of strtolower() calls in dbDelta(). 
Fixes #36919.
Built from https://develop.svn.wordpress.org/trunk@37532


git-svn-id: http://core.svn.wordpress.org/trunk@37500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 14:58:27 +00:00
Andrea Fercia
15ce1ec939 Accessibility: the Thickbox "Close" control should always be a button. 
Fix the last case where the "Close" control was still a link. All the other ones
were already changed in buttons.

Fixes #36267.
Built from https://develop.svn.wordpress.org/trunk@37531


git-svn-id: http://core.svn.wordpress.org/trunk@37499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 10:30:29 +00:00
Dominik Schilling
fa6346e409 Template: In wp_get_archives() use add_query_arg() instead of sprintf() to build the archive URL. 
Props tloureiro.
Fixes #36414.
Built from https://develop.svn.wordpress.org/trunk@37530


git-svn-id: http://core.svn.wordpress.org/trunk@37498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 10:23:30 +00:00
Dominik Schilling
e5dd89ae57 Menus: Use new colors for error/info notices. 
Props barryceelen.
Fixes #36857.
Built from https://develop.svn.wordpress.org/trunk@37529


git-svn-id: http://core.svn.wordpress.org/trunk@37497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 09:40:28 +00:00
Dominik Schilling
af76442848 Customize: Make sure that preview and return URLs are URLs. 
Built from https://develop.svn.wordpress.org/trunk@37527


git-svn-id: http://core.svn.wordpress.org/trunk@37495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 09:33:28 +00:00
Dominik Schilling
d510afedd8 External Libraries: Update jQuery to 1.12.4. 
Release post: https://blog.jquery.com/2016/05/20/jquery-1-12-4-and-2-2-4-released/
Changelog: https://github.com/jquery/jquery/compare/1.12.3...1.12.4

See [37433].
Fixes #36533.
Built from https://develop.svn.wordpress.org/trunk@37526


git-svn-id: http://core.svn.wordpress.org/trunk@37494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 09:00:29 +00:00
Gary Pendergast
18ca26574b Database: dbDelta() will no longer try to downgrade the size of TEXT and BLOB columns. 
When upgrading to `utf8mb4`, `TEXT` fields will be upgraded to `MEDIUMTEXT` (and likewise for all other `*TEXT` and `*BLOB` fields). This is to allow for the additional space requirements of `utf8mb4`.

On the subsequent upgrade, after the `utf8mb4` upgrade, `dbDelta()` would try and downgrade the fields to their original size again. At best, this it a waste of time, at worst, this could truncate any data larger than the original size. There's no harm in leaving them at their original size, so let's do that.

Fixes #36748.


Built from https://develop.svn.wordpress.org/trunk@37525


git-svn-id: http://core.svn.wordpress.org/trunk@37493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 08:36:28 +00:00
Gary Pendergast
25d2123821 Database: Remove some duplicate code. 
`schema.php` was manually defining the character set/collation query, instead of using `wpdb::get_charset_collate()`.

Props sudar.

Fixes #35756.


Built from https://develop.svn.wordpress.org/trunk@37524


git-svn-id: http://core.svn.wordpress.org/trunk@37492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 06:38:27 +00:00
Gary Pendergast
db3917d491 Database: Use the utf8mb4_unicode_520_ci collation, when available. 
The `utf8mb4_unicode_520_ci` (Unicode Collation Algorithm 5.2.0, October 2010) collation is an improvement over `utf8mb4_unicode_ci` (UCA 4.0.0, November 2003).

There is no word on when MySQL will support later UCAs.

Fixes #32105.


Built from https://develop.svn.wordpress.org/trunk@37523


git-svn-id: http://core.svn.wordpress.org/trunk@37491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 06:32:29 +00:00
Gary Pendergast
89d0b337e0 Tests: Remove a test for a function that can't be tested. 
`wpdb::init_charset()` doesn't lend itself to being tested, so the unit test added in [37521] won't work under most circumstances.

See #32405.


Built from https://develop.svn.wordpress.org/trunk@37522


git-svn-id: http://core.svn.wordpress.org/trunk@37490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 06:27:38 +00:00
Gary Pendergast
1aff99307f Database: Obey locale-specific utf8 collation settings. 
Some sites prefer to use locale-specific location settings. For example, the Swedish WordPress package use `utf8_swedish_ci`, instead of `utf8_unicode_ci`. When upgrading the connection to `utf8mb4`, we were overriding this to be `utf8mb4_unicode_ci`, instead of maintaining the use of the `_swedish_ci` variant.

The locale-specific collations do have extra collation rules just for that language, so it's useful to maintain compatibility.

Fixes #32405.



Built from https://develop.svn.wordpress.org/trunk@37521


git-svn-id: http://core.svn.wordpress.org/trunk@37489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 05:54:27 +00:00
Weston Ruter
116102089f Customize: Replace invalid reference to $_SERVER['customized'] with $_POST['customized']. 
Introduced in r31421.
Fixes #36852.

Built from https://develop.svn.wordpress.org/trunk@37520


git-svn-id: http://core.svn.wordpress.org/trunk@37488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 05:10:27 +00:00
Boone Gorges
ef97e9bee5 Tests: get_terms() 'search' test should have more precise fixtures.. 
Without a fixture that does not match the search term, it's possible for the
test to pass even if the search clause isn't built properly.

See #13992, #35381.
Built from https://develop.svn.wordpress.org/trunk@37519


git-svn-id: http://core.svn.wordpress.org/trunk@37487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 03:26:27 +00:00
Drew Jaynes
9cb5247392 Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37518


git-svn-id: http://core.svn.wordpress.org/trunk@37486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:50:28 +00:00
Drew Jaynes
558d5b371c Docs: Standardize filter docs in wp-includes/l10n.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37517


git-svn-id: http://core.svn.wordpress.org/trunk@37485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:48:28 +00:00
Drew Jaynes
46573c099d Docs: Standardize filter docs in wp-includes/feed.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37516


git-svn-id: http://core.svn.wordpress.org/trunk@37484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:47:27 +00:00
Drew Jaynes
03b342f22d Docs: Standardize filter docs in wp-includes/formatting.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37515


git-svn-id: http://core.svn.wordpress.org/trunk@37483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:45:28 +00:00
Drew Jaynes
fe3129f470 Docs: Standardize filter docs in wp-includes/class-http.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37514


git-svn-id: http://core.svn.wordpress.org/trunk@37482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:43:27 +00:00
Drew Jaynes
abbd18dbb7 Docs: Standardize filter docs in wp-includes/embed.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37513


git-svn-id: http://core.svn.wordpress.org/trunk@37481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:42:27 +00:00
Drew Jaynes
fd96e90758 Docs: Standardize filter docs in wp-includes/comment.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37512


git-svn-id: http://core.svn.wordpress.org/trunk@37480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:41:29 +00:00
Drew Jaynes
dabe5b1467 Docs: Standardize filter docs in wp-includes/ms-functions.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37511


git-svn-id: http://core.svn.wordpress.org/trunk@37479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:40:27 +00:00
Drew Jaynes
bc20a9288f Docs: Standardize filter docs in wp-includes/functions.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37510


git-svn-id: http://core.svn.wordpress.org/trunk@37478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:36:27 +00:00
Drew Jaynes
5ac8c4158c Docs: Standardize filter docs in wp-includes/query.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37509


git-svn-id: http://core.svn.wordpress.org/trunk@37477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:35:54 +00:00
Drew Jaynes
6c534918d4 Docs: Standardize filter docs in wp-includes/pluggable.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37508


git-svn-id: http://core.svn.wordpress.org/trunk@37476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:35:27 +00:00
Drew Jaynes
bde87c6fb2 Docs: Standardize filter docs in wp-includes/option.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37507


git-svn-id: http://core.svn.wordpress.org/trunk@37475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:34:26 +00:00
Drew Jaynes
ee2fb51f3a Docs: Standardize filter docs in wp-includes/taxonomy.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37506


git-svn-id: http://core.svn.wordpress.org/trunk@37474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:32:53 +00:00
Drew Jaynes
eb83bf3700 Docs: Standardize filter docs in wp-includes/media.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37505


git-svn-id: http://core.svn.wordpress.org/trunk@37473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:32:27 +00:00
Drew Jaynes
dcadd35728 Docs: Standardize filter docs in wp-includes/post.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37504


git-svn-id: http://core.svn.wordpress.org/trunk@37472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:31:28 +00:00
Drew Jaynes
043c4b1710 Docs: Standardize filter docs in wp-includes/user.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37503


git-svn-id: http://core.svn.wordpress.org/trunk@37471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:30:27 +00:00
Drew Jaynes
1f231c7293 Docs: Standardize filter docs in wp-includes/post-thumbnail-template.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37502


git-svn-id: http://core.svn.wordpress.org/trunk@37470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:29:27 +00:00
Drew Jaynes
42d1936336 Docs: Standardize filter docs in wp-includes/post-template.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37501


git-svn-id: http://core.svn.wordpress.org/trunk@37469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:28:53 +00:00
Drew Jaynes
e78209267f Docs: Standardize filter docs in wp-includes/nav-menu-template.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37500


git-svn-id: http://core.svn.wordpress.org/trunk@37468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:28:27 +00:00
Drew Jaynes
c1ba18d147 Docs: Standardize filter docs in wp-includes/link-template.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37499


git-svn-id: http://core.svn.wordpress.org/trunk@37467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:27:27 +00:00
Drew Jaynes
0f39ebdb77 Docs: Standardize filter docs in wp-includes/general-template.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37498


git-svn-id: http://core.svn.wordpress.org/trunk@37466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:26:53 +00:00
Drew Jaynes
34a8c37332 Docs: Standardize filter docs in wp-includes/comment-template.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37497


git-svn-id: http://core.svn.wordpress.org/trunk@37465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:26:27 +00:00
Drew Jaynes
c8c44a3111 Docs: Standardize filter docs in wp-includes/category-template.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37496


git-svn-id: http://core.svn.wordpress.org/trunk@37464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:25:52 +00:00
Drew Jaynes
317aa932f0 Docs: Standardize filter docs in wp-includes/author-template.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37495


git-svn-id: http://core.svn.wordpress.org/trunk@37463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:25:26 +00:00
Drew Jaynes
b7fc55237d Docs: Standardize filter docs in wp-includes/bookmark-template.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37494


git-svn-id: http://core.svn.wordpress.org/trunk@37462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:24:28 +00:00
Drew Jaynes
136296c111 Docs: Standardize filter docs in wp-includes/theme.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37493


git-svn-id: http://core.svn.wordpress.org/trunk@37461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:18:29 +00:00
Drew Jaynes
602b51a209 Docs: Standardize filter docs in core classes in wp-includes/* to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37492


git-svn-id: http://core.svn.wordpress.org/trunk@37460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:15:28 +00:00
Drew Jaynes
e2c18aaf64 Docs: Standardize filter docs in the Customizer classes to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37491


git-svn-id: http://core.svn.wordpress.org/trunk@37459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:10:29 +00:00
Drew Jaynes
f03eef071e Docs: Standardize hook docs in wp-includes/rest-api/* to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37490


git-svn-id: http://core.svn.wordpress.org/trunk@37458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:08:29 +00:00
Drew Jaynes
6b8248f3f7 Docs: Standardize hook docs in wp-includes/widgets/* to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37489


git-svn-id: http://core.svn.wordpress.org/trunk@37457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:06:28 +00:00
Drew Jaynes
c3055cc190 Docs: Standardize hook docs in wp-admin/* to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37488


git-svn-id: http://core.svn.wordpress.org/trunk@37456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:01:30 +00:00
Drew Jaynes
f52a8cb1fa Docs: Remove/replace invalid inline @link tags in DocBlocks in wp-includes/*. 
Fixes #36910.

Built from https://develop.svn.wordpress.org/trunk@37487


git-svn-id: http://core.svn.wordpress.org/trunk@37455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 17:39:28 +00:00
Drew Jaynes
549e33a599 Docs: Remove several invalid inline @link tags from the DocBlock for wp_list_categories(). 
See #36910.

Built from https://develop.svn.wordpress.org/trunk@37486


git-svn-id: http://core.svn.wordpress.org/trunk@37454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 17:24:28 +00:00
Drew Jaynes
a54c2a7279 Docs: Remove/replace invalid inline @link tags from DocBlocks in wp-admin/includes/*. 
See #36910.

Built from https://develop.svn.wordpress.org/trunk@37485


git-svn-id: http://core.svn.wordpress.org/trunk@37453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 17:22:27 +00:00
Drew Jaynes
ac74c103a8 Docs: Fix some parameter alignment and backtick-escaping in two DocBlocks in wp-admin/includes/media.php. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@37484


git-svn-id: http://core.svn.wordpress.org/trunk@37452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 17:18:27 +00:00
Drew Jaynes
c0d7dece23 Docs: Remove invalid inline @link tags from docs in wp-admin/includes/media.php. 
See #36910.

Built from https://develop.svn.wordpress.org/trunk@37483


git-svn-id: http://core.svn.wordpress.org/trunk@37451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 17:10:26 +00:00
Boone Gorges
e79d2a1bad Improve @return documentation for WP_Comment_Query::get_comments(). 
Props barryceelen.
Fixes #36896.
Built from https://develop.svn.wordpress.org/trunk@37482


git-svn-id: http://core.svn.wordpress.org/trunk@37450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 16:21:27 +00:00
Boone Gorges
4428a031a3 In get_page_by_path(), values fetched from cache should obey $output param. 
Introduced in [37479].

Props spacedmonkey.
Fixes #36711.
Built from https://develop.svn.wordpress.org/trunk@37481


git-svn-id: http://core.svn.wordpress.org/trunk@37449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 16:19:29 +00:00
Boone Gorges
9e6f52a03d Move get_the_terms() tests to their own file. 
See #36814.

Built from https://develop.svn.wordpress.org/trunk@37480


git-svn-id: http://core.svn.wordpress.org/trunk@37448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-21 17:57:26 +00:00
Boone Gorges
98050e404d Cache queries in get_page_by_path(). 
Props spacedmonkey.
Fixes #36711.
Built from https://develop.svn.wordpress.org/trunk@37479


git-svn-id: http://core.svn.wordpress.org/trunk@37447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-21 17:27:29 +00:00
Boone Gorges
c5c80b064d Tests: Improve tests for get_page_by_path(). 
* Move existing test into its own file.
* Add tests that cover most pieces of functionality.

See #36711.
Built from https://develop.svn.wordpress.org/trunk@37478


git-svn-id: http://core.svn.wordpress.org/trunk@37446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-21 02:41:27 +00:00
Jeremy Felt
2dd1e72f10 Multisite: Introduce WP_Site_Query 
Provides a consistent way to query `$wpdb->blogs` for `WP_Site` objects based on domain, path, site ID, network ID, and more.

Introduces and uses `update_site_cache()` and `_prime_site_caches()` to maintain a cached list of `WP_Site` objects for use in multiple queries.

Props spacedmonkey, flixos90, DrewAPicture, jeremyfelt, ocean90.
See #35791.

Built from https://develop.svn.wordpress.org/trunk@37477


git-svn-id: http://core.svn.wordpress.org/trunk@37445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-20 22:04:27 +00:00
Weston Ruter
87b0a1b989 Customize: Add setting validation model and control notifications to augment setting sanitization. 
When a setting is invalid, not only will it be blocked from being saved but all other settings will be blocked as well. This ensures that Customizer saves aren't partial but are more transactional. User will be displayed the error in a notification so that they can fix and re-attempt saving.

PHP changes:

* Introduces `WP_Customize_Setting::validate()`, `WP_Customize_Setting::$validate_callback`, and the `customize_validate_{$setting_id}` filter.
* Introduces `WP_Customize_Manager::validate_setting_values()` to do validation (and sanitization) for the setting values supplied, returning a list of `WP_Error` instances for invalid settings.
* Attempting to save settings that are invalid will result in the save being blocked entirely, with the errors being sent in the `customize_save_response`. Modifies `WP_Customize_Manager::save()` to check all settings for validity issues prior to calling their `save` methods.
* Introduces `WP_Customize_Setting::json()` for parity with the other Customizer classes. This includes exporting of the `type`.
* Modifies `WP_Customize_Manager::post_value()` to apply `validate` after `sanitize`, and if validation fails, to return the `$default`.
* Introduces `customize_save_validation_before` action which fires right before the validation checks are made prior to saving.

JS changes:

* Introduces `wp.customize.Notification` in JS which to represent `WP_Error` instances returned from the server when setting validation fails.
* Introduces `wp.customize.Setting.prototype.notifications`.
* Introduces `wp.customize.Control.prototype.notifications`, which are synced with a control's settings' notifications.
* Introduces `wp.customize.Control.prototype.renderNotifications()` to re-render a control's notifications in its notification area. This is called automatically when the notifications collection changes.
* Introduces `wp.customize.settingConstructor`, allowing custom setting types to be used in the same way that custom controls, panels, and sections can be made.
* Injects a notification area into existing controls which is populated in response to the control's `notifications` collection changing. A custom control can customize the placement of the notification area by overriding the new `getNotificationsContainerElement` method.
* When a save fails due to setting invalidity, the invalidity errors will be added to the settings to then populate in the controls' notification areas, and the first such invalid control will be focused.

Props westonruter, celloexpressions, mrahmadawais.
See #35210.
See #30937.
Fixes #34893.

Built from https://develop.svn.wordpress.org/trunk@37476


git-svn-id: http://core.svn.wordpress.org/trunk@37444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-20 21:10:27 +00:00
Jeremy Felt
19f988840f Multisite: Wrap the main bootstrap process in a function 
Introduce `ms_load_current_site_and_network`. This is used by core during the multisite bootstrap process to populate the `$current_site` and `$current_blog` globals based on a requested domain and path.

Return values from this function inform `ms-settings.php` as to whether a page view should continue, `ms_not_installed()` should fire, or a redirect to a new location should occur.

This was previously a procedural block in `ms-settings.php`. Wrapping this code and providing specific return values allows us to write tests that do not rely on the manual and repeated inclusion of `ms-settings.php`.

This should not be used by plugins or themes. Please.

See #34941.

Built from https://develop.svn.wordpress.org/trunk@37475


git-svn-id: http://core.svn.wordpress.org/trunk@37443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-20 20:57:28 +00:00
Boone Gorges
720e2af290 During password reset, user-submitted login/email should be stripslashed. 
This prevents errors when an email address contains an apostrophe. See [29966]
for similar treatment of a related problem.

Props dcavins.
Fixes #36322.
Built from https://develop.svn.wordpress.org/trunk@37474


git-svn-id: http://core.svn.wordpress.org/trunk@37442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-20 19:21:30 +00:00
Peter Wilson
a593be4403 Docs: Correct @since tag for Emoji SVG filters 
See [37471]

Fixes #36525

Built from https://develop.svn.wordpress.org/trunk@37473


git-svn-id: http://core.svn.wordpress.org/trunk@37441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-20 06:15:27 +00:00
Aaron Jorbin
2db9ac7a24 Update jQuery Migrate to 1.4.1 
http://blog.jquery.com/2016/05/19/jquery-migrate-1-4-1-released-and-the-path-to-jquery-3-0/

Unquoted selectors for attribute selectors should function once again (and output a warning so that plugins and themes using them can update).

Fixes #36892


Built from https://develop.svn.wordpress.org/trunk@37472


git-svn-id: http://core.svn.wordpress.org/trunk@37440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-20 06:11:28 +00:00
Peter Wilson
94290a843b Emoji: Use SVG in supported browsers 
Use SVG images in supporting browsers, otherwise fall back to PNG images. Add the filters `emoji_svg_url` and `emoji_svg_ext`.

Introduces unit tests to check the Emoji CDN filters.

Fixes #36525

Built from https://develop.svn.wordpress.org/trunk@37471


git-svn-id: http://core.svn.wordpress.org/trunk@37439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-20 06:03:27 +00:00
Gary Pendergast
b777ce5b89 Tests: Fix an incorrect @ticket header included in [37469]. 
See #36122.


Built from https://develop.svn.wordpress.org/trunk@37470


git-svn-id: http://core.svn.wordpress.org/trunk@37438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-20 05:30:27 +00:00
Gary Pendergast
7349a7a60e Emoji: Allow emoji in blogname and blogdescription on utf8 installs. 
When the options table is set to `utf8` instead of `utf8mb4`, emoji will be stripped from the blog name and description when they're saved. Instead of stripping them, they can be encode as HTML entities.

Fixes #36122.


Built from https://develop.svn.wordpress.org/trunk@37469


git-svn-id: http://core.svn.wordpress.org/trunk@37437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-20 04:54:27 +00:00
Jeremy Felt
9fa38fdc31 Multisite: Introduce get_site() 
Given a site ID or site object, `get_site()` retrieves site data in the same vein as `get_post()` or `get_comment()`. This will allow for clean retrieval of sites from a primed cache when `WP_Site_Query` is implemented.

Adds a `WP_Site::to_array()` method to support multiple return types within `get_site()`.

Props spacedmonkey.
See #35791.

Built from https://develop.svn.wordpress.org/trunk@37468


git-svn-id: http://core.svn.wordpress.org/trunk@37436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-20 04:41:27 +00:00
Andrea Fercia
ce94f2dfbd Refine the FTP credentials form interaction. 
Properly toggle SSH2 Authentication Keys fieldset visibility.
JavaScript and CSS clean-up.

Props Mte90.
Fixes #34376.
Built from https://develop.svn.wordpress.org/trunk@37467


git-svn-id: http://core.svn.wordpress.org/trunk@37435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-19 22:59:28 +00:00
Jeremy Felt
4a12078b31 Multisite: Filter the links displayed on "Edit Site" views 
Introduce the `network_edit_site_nav` function, which DRYs up the code used to display a common set of links at the top of "Edit Site" views.

Introduce the `network_edit_site_nav_links` filter, which allows plugins to modify the list of links displayed at the top of Edit Site views as a "tabbed" interface.

Props johnjamesjacoby, c3mdigital, Bueltge.
Fixes #15800.

Built from https://develop.svn.wordpress.org/trunk@37466


git-svn-id: http://core.svn.wordpress.org/trunk@37434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-19 21:48:30 +00:00
Boone Gorges
03fa635ba7 Introduce required argument for wp_dropdown_categories(). 
This allows the HTML5 `required` attribute to be added to the `select` element.

Props wzislam, pcarvalho.
Fixes #31909.
Built from https://develop.svn.wordpress.org/trunk@37465


git-svn-id: http://core.svn.wordpress.org/trunk@37433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-19 02:39:27 +00:00
Boone Gorges
3b24e53ba7 Move wp_dropdown_categories() tests into their own file. 
See #31909.

Built from https://develop.svn.wordpress.org/trunk@37464


git-svn-id: http://core.svn.wordpress.org/trunk@37432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-19 02:23:27 +00:00
Boone Gorges
805a1ebadb Beautify, simplify, lovelify, alignify the default argument array in wp_dropdown_categories(). 
See #31909.
Built from https://develop.svn.wordpress.org/trunk@37463


git-svn-id: http://core.svn.wordpress.org/trunk@37431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-19 02:17:27 +00:00
Sergey Biryukov
117cef2d46 Docs: Correct variable type for WP_Upgrader::$strings. 
Props mt8.biz.
Fixes #36883.
Built from https://develop.svn.wordpress.org/trunk@37462


git-svn-id: http://core.svn.wordpress.org/trunk@37430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-19 00:36:27 +00:00
Sergey Biryukov
9b56e3b7e4 External Libraries: After [37402], replace two more instances of split() with explode() in wp-includes/atomlib.php. 
Props josephscott.
Fixes #20673.
Built from https://develop.svn.wordpress.org/trunk@37461


git-svn-id: http://core.svn.wordpress.org/trunk@37429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-19 00:06:28 +00:00
Drew Jaynes
0016e4bb12 Docs: Fix an incorrect Codex link in the file header for wp-includes/cache.php. 
Introduced in [7990].

Props michaelbeil.
See #36880.

Built from https://develop.svn.wordpress.org/trunk@37460


git-svn-id: http://core.svn.wordpress.org/trunk@37428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-18 22:07:28 +00:00
Aaron Jorbin
ced4ef2144 Correct usage of @Covers for Tests_Post_Types 
When @covers is used with a plain alphanumeric string, PHPUnit assumes that it is covering a class. If there is no class, it fails and exits rather than continuing to generate coverage. To cover a global function, the name must start with ::. See https://phpunit.de/manual/5.3/en/appendixes.annotations.html#appendixes.annotations.covers

Introduced in [36768].

Fixes #36867. See #35985


Built from https://develop.svn.wordpress.org/trunk@37459


git-svn-id: http://core.svn.wordpress.org/trunk@37427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-18 17:14:29 +00:00
Dominik Schilling
9f7856f103 Remove duplicate CSS selectors in forms.css. 
Props bassgang.
Fixes #36580.
Built from https://develop.svn.wordpress.org/trunk@37458


git-svn-id: http://core.svn.wordpress.org/trunk@37426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-18 12:20:29 +00:00
Pascal Birchler
0afb5d0041 Customize: Change attachment condition in the site icon control to prevent errors. 
Props neverything.
Fixes #36749 for trunk.
Built from https://develop.svn.wordpress.org/trunk@37456


git-svn-id: http://core.svn.wordpress.org/trunk@37424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-17 20:39:30 +00:00
Pascal Birchler
d60b748652 Embeds: Change attachment metadata condition to prevent a warning in the embeds template. 
See #35237.
Fixes #36838 for trunk.
Built from https://develop.svn.wordpress.org/trunk@37452


git-svn-id: http://core.svn.wordpress.org/trunk@37420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-17 20:33:29 +00:00
Aaron Jorbin
6af8a5d48c Set a whitelist for PHPUnit code coverage. 
PHPUnit requires a whitelist as of version 5 in order to generate code coverage. See https://github.com/sebastianbergmann/phpunit-documentation/issues/335 .

Fixes #36867.


Built from https://develop.svn.wordpress.org/trunk@37449


git-svn-id: http://core.svn.wordpress.org/trunk@37417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-17 20:23:28 +00:00
Pascal Birchler
eeadf35fa9 Bootstrap/Load: Silence ini_set() in wp_debug_mode(). 
Props SergeyBiryukov.
Fixes #36708 for trunk.
Built from https://develop.svn.wordpress.org/trunk@37448


git-svn-id: http://core.svn.wordpress.org/trunk@37416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-17 20:22:28 +00:00
Aaron Jorbin
c4752b1bf9 Correct usage of Covers for Tests_Update_Comment_Count_Now 
When @covers is used with a plain alphanumeric string, PHPUnit assumes that it is covering a class. If there is no class, it fails and exits rather than continuing to generate coverage. To cover a global function, the name must start with ::. See https://phpunit.de/manual/5.3/en/appendixes.annotations.html#appendixes.annotations.covers

[37445] for trunk

See #35060, #36867


Built from https://develop.svn.wordpress.org/trunk@37447


git-svn-id: http://core.svn.wordpress.org/trunk@37415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-17 20:20:27 +00:00
Ella Iseulde Van Dorpe
6e72bc4ec5 TinyMCE: use new non-editable implementation 
Use TinyMCE's implementation of `contenteditable="false"` for views.

First pass.

See #36434.


Built from https://develop.svn.wordpress.org/trunk@37446


git-svn-id: http://core.svn.wordpress.org/trunk@37414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-17 18:49:30 +00:00
Ryan McCue
691d445d68 REST API: Use prepared JSON data correctly. 
This was modifying a variable that was never used. Oops.

Fixes #36358.
Props jrf.

Built from https://develop.svn.wordpress.org/trunk@37444


git-svn-id: http://core.svn.wordpress.org/trunk@37412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-17 03:55:29 +00:00
Boone Gorges
1cfeaada73 Tests: Use factory method to generate fixtures for wp_unique_post_slug() tests. 
Props mintindeed.
See #20419.
Built from https://develop.svn.wordpress.org/trunk@37443


git-svn-id: http://core.svn.wordpress.org/trunk@37411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-17 01:49:28 +00:00
Helen Hou-Sandí
848501711a System font: The stack does not work with the font shorthand property. 
see #36753.

Built from https://develop.svn.wordpress.org/trunk@37442


git-svn-id: http://core.svn.wordpress.org/trunk@37410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-17 01:45:27 +00:00
Dominik Schilling
693dfe3453 Editor: Merge two strings. 
Props pavelevap.
See #27756.
Built from https://develop.svn.wordpress.org/trunk@37441


git-svn-id: http://core.svn.wordpress.org/trunk@37407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-16 18:57:29 +00:00
Dominik Schilling
a673a71f94 I18N: In get_translations_for_domain() check if the global $l10n was set by _load_textdomain_just_in_time() before accessing it. 
Props danielhuesken.
Fixes #34114.
Built from https://develop.svn.wordpress.org/trunk@37440


git-svn-id: http://core.svn.wordpress.org/trunk@37406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-16 15:10:29 +00:00
Andrea Fercia
1ae8891261 Accessibility: make the tab order match the visual order in the Edit terms screens. 
Fixes #35664.
Built from https://develop.svn.wordpress.org/trunk@37439


git-svn-id: http://core.svn.wordpress.org/trunk@37405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-16 13:02:29 +00:00
Dominik Schilling
8c0c57b9f9 Version bump. 
Fixes #36845.
Built from https://develop.svn.wordpress.org/trunk@37438


git-svn-id: http://core.svn.wordpress.org/trunk@37404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-16 10:24:30 +00:00
Weston Ruter
dcf6cf3615 Customize: Include shortcut button in Custom Menu widget to edit the selected menu in the Customizer. 
Clicking on the Edit Menu button focuses on the corresponding nav menu section. Upon collapsing the nav menu section, the focus is returned to the Custom Menu widget instead of taking the user to the menus root panel. In this way, the back button behavior is modified once to serve as breadcrumb/history navigation. The Edit Menu button with the breadcrumb back button behavior greatly reduce the number of UI interactions needed to edit a menu referenced in a Custom Menu widget.

Props celloexpressions, westonruter.
Fixes #32683.

Built from https://develop.svn.wordpress.org/trunk@37437


git-svn-id: http://core.svn.wordpress.org/trunk@37403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-16 07:22:30 +00:00
Ryan McCue
6da21bc4f4 HTTP API: Pass array-like object to http_api_debug. 
This was mistakingly passing the Requests_Response object, which caused fatal errors with debugging tools.

See #33055.

Built from https://develop.svn.wordpress.org/trunk@37436


git-svn-id: http://core.svn.wordpress.org/trunk@37402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-16 06:12:29 +00:00
Joe McGill
bdfd58c8cf Media: Remove medium_large size from $whitelist_options['media'] in options.php. 
The `medium_large_size_w` and `medium_large_size_h` options were added to the
$whitelist_options['media'] in options.php in [35479], which causes both options
to be set to `0` when the media settings are changed. When this occurs, the
medium_large image size will no longer be created when an image is uploaded.

Since these options aren't meant to be updated via the settings UI, they can be
safely removed from the whitelist.

Fixes #36531.

Built from https://develop.svn.wordpress.org/trunk@37435


git-svn-id: http://core.svn.wordpress.org/trunk@37401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-15 22:38:29 +00:00
Dominik Schilling
944a69df87 Credits: Add a missing closing tag. 
Props ramiy for initial patch.
Fixes #35911.
Built from https://develop.svn.wordpress.org/trunk@37434


git-svn-id: http://core.svn.wordpress.org/trunk@37400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-14 18:58:31 +00:00
Dominik Schilling
52d30beb3c External Libraries: Update jQuery to 1.12.4-pre. 
This version includes a fix for the media library which didn't open under certain conditions. The issue was tracked upstream as "Specific table CSS style breaks `.is(':visible')`", see https://github.com/jquery/jquery/issues/3065.
Also fixed: "Element which is not in page is still :visible in IE8", see https://github.com/jquery/jquery/issues/3043.

Changelog: https://github.com/jquery/jquery/compare/1.12.3...376caf4d

See #36533.
Built from https://develop.svn.wordpress.org/trunk@37433


git-svn-id: http://core.svn.wordpress.org/trunk@37399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-13 21:15:27 +00:00
Dominik Schilling
f81b65688a Upgrader: Add changelog entries for when the classes were moved to its own file. 
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37432


git-svn-id: http://core.svn.wordpress.org/trunk@37398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-13 20:59:27 +00:00
Drew Jaynes
b1804afeaf Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs. 
Also use 'back-compat' in some inline comments where backward compatibility is the subject and shorthand feels more natural.

Note: 'backwards compatibility/compatibile' can also be considered correct, though it's primary seen in regular use in British English.

Props ocean90.
Fixes #36835.

Built from https://develop.svn.wordpress.org/trunk@37431


git-svn-id: http://core.svn.wordpress.org/trunk@37397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-13 18:41:31 +00:00
Ryan McCue
1e40ba291e HTTP API: Fix compatibility with cURL <7.22 
Ensure connections are closed after usage to fix an issue with WP.com URLs used in the tests.

Resynched from GitHub at 95518ce.

See #33055.

Built from https://develop.svn.wordpress.org/trunk@37430


git-svn-id: http://core.svn.wordpress.org/trunk@37396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-13 11:15:29 +00:00
Ryan McCue
dee1d583a7 HTTP API: Add browser compatibility hook for 3xx redirects. 
WordPress erroneously follows browser-style behaviour with 3xx redirects, where a POST to 302 becomes a GET. Requests instead follows the specification and keeps the same method. Requests also exposes a hook to allow changing the behaviour.

[37428] used the wrong method of adding this hook, now corrected.

See #33055.

Built from https://develop.svn.wordpress.org/trunk@37429


git-svn-id: http://core.svn.wordpress.org/trunk@37395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-13 05:11:27 +00:00
Ryan McCue
37f6e6813a HTTP API: Replace internals with Requests library. 
Requests is a library very similar to WP_HTTP, with a high level of unit test coverage, and has a common lineage and development team. It also supports parallel requests.

See #33055.

Built from https://develop.svn.wordpress.org/trunk@37428


git-svn-id: http://core.svn.wordpress.org/trunk@37394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-13 04:42:28 +00:00
Dominik Schilling
65f5fe6fb2 Widgets: Create WP_Widget_Mock as a mock of WP_Widget which can be used for widget tests. 
You cannot instantiate an abstract class. Not even in WordPress world.

See #35981.
Built from https://develop.svn.wordpress.org/trunk@37427


git-svn-id: http://core.svn.wordpress.org/trunk@37393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-12 21:25:27 +00:00
Weston Ruter
b036bf1012 Customize: Clean up media control CSS. 
Removes unnecessary wrapper elements and refactors class names to eliminate duplication of rule selectors.

Props celloexpressions.
Fixes #30618.

Built from https://develop.svn.wordpress.org/trunk@37426


git-svn-id: http://core.svn.wordpress.org/trunk@37392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-12 20:23:54 +00:00
Dominik Schilling
97fc82a879 Widgets: Make WP_Widget a real abstract class. 
This removes the `die()` call from `WP_Widget::widget()` and converts it to an abstract method.
`WP_Widgets` (later renamed to `WP_Widget`) was introduced in [10764] where the minimum PHP requirement was 4.3, thus no `abstract` was available.

Props johnbillion.
Fixes #35981.
Built from https://develop.svn.wordpress.org/trunk@37425


git-svn-id: http://core.svn.wordpress.org/trunk@37391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-12 20:23:28 +00:00
Dominik Schilling
7f1abd441f Posts: Fire a post_action_{$action} action for a custom post action request. 
Props jfarthing84, Mte90, brianvan, sudar, DrewAPicture.
Fixes #27056.
Built from https://develop.svn.wordpress.org/trunk@37424


git-svn-id: http://core.svn.wordpress.org/trunk@37390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-12 15:44:28 +00:00
Rachel Baker
00adb457d2 Comments: Add $data parameter to include the comment data in the edit_comment action. 
Props dshanske.

Fixes #36427.


Built from https://develop.svn.wordpress.org/trunk@37423


git-svn-id: http://core.svn.wordpress.org/trunk@37389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-12 15:37:27 +00:00
Dominik Schilling
251274abf6 List Tables: Pass the $which parameter to restrict_manage_posts and restrict_manage_users. 
`$which` contains the location of the extra table nav markup: 'top' or 'bottom'.

Props martin.krcho.
Fixes #35307.
Built from https://develop.svn.wordpress.org/trunk@37422


git-svn-id: http://core.svn.wordpress.org/trunk@37388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-12 15:13:27 +00:00
Dominik Schilling
546b031453 Filesystem API: Don't add '.' to the list of directories which need to be checked/created when extracting a file. 
Prevents a PHP warning by `WP_Filesystem_Direct::mkdir()` when installing a language pack which doesn't have subdirectories.

Props tfrommen.
Fixes #36570.
Built from https://develop.svn.wordpress.org/trunk@37421


git-svn-id: http://core.svn.wordpress.org/trunk@37387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-12 12:40:28 +00:00
Helen Hou-Sandí
a726a9f51f Admin font: Remove a redundant sans-serif declaration. 
props samantha-miller.
see #36753.

Built from https://develop.svn.wordpress.org/trunk@37419


git-svn-id: http://core.svn.wordpress.org/trunk@37385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-12 02:14:28 +00:00
Jeremy Felt
283c367df7 Tests: Set public to 1 in the default blog factory 
When no `$meta` arguments are passed to `wpmu_create_blog()`, `public` is set to `0` in the database for new sites. This is fine, but also does not match the default implied when most sites are created via `site-new.php`.

The only current use of the `$meta` argument in the tests is to (re)mark `public` as `0`. All existing tests pass with this change. Tests for `WP_Site_Query` can now rely on better default expectations.

See #36566.

Built from https://develop.svn.wordpress.org/trunk@37418


git-svn-id: http://core.svn.wordpress.org/trunk@37384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-11 19:22:27 +00:00
Weston Ruter
b074113016 Customize: Remove use of reserved word default in Underscore template which breaks IE8. 
Fixes regression introduced in r30712.

Props adamsilverstein.
Fixes #36793.

Built from https://develop.svn.wordpress.org/trunk@37417


git-svn-id: http://core.svn.wordpress.org/trunk@37383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-11 19:07:30 +00:00
Pascal Birchler
64fb1a9e90 I18N: Add changes missed in [37415]. 
See #34114.
Built from https://develop.svn.wordpress.org/trunk@37416


git-svn-id: http://core.svn.wordpress.org/trunk@37382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 20:31:27 +00:00
Pascal Birchler
751234a580 I18N: Remove the requirement to call load_plugin_textdomain() / load_theme_textdomain(). 
By initially scanning the `wp-content/languages` directory and loading available MO files just-in-time, plugins and themes do not need to manually load text domains anymore.

Props swissspidy, ocean90.
Fixes #34114
Built from https://develop.svn.wordpress.org/trunk@37415


git-svn-id: http://core.svn.wordpress.org/trunk@37381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 20:05:29 +00:00
Pascal Birchler
3f6966907b I18N: Reverse the order of loading plugin and theme translations. 
`load_theme_textdomain()`, `load_plugin_textdomain()` and `load_muplugin_textdomain()` now try to load the .mo file from the `wp-content/languages` directory first. After the introduction of language packs, translation files are more likely to be located there.

Props swissspidy, sebastian.pisula.
Fixes #34213.
Built from https://develop.svn.wordpress.org/trunk@37414


git-svn-id: http://core.svn.wordpress.org/trunk@37380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 18:50:27 +00:00
Dominik Schilling
1564bd2c1f Upgrader: Remove debug cruft. 
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37413


git-svn-id: http://core.svn.wordpress.org/trunk@37379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 18:32:28 +00:00
Dominik Schilling
a8525b1109 Upgrader: After [37409] move the hook docs for upgrader_process_complete to WP_Upgrader::run(). 
Add changelog entry for [23912].

Part 7/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37412


git-svn-id: http://core.svn.wordpress.org/trunk@37378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 12:20:27 +00:00
Dominik Schilling
5844c585f6 Upgrader: Update wp-admin/includes/class-wp-upgrader.php to require_once the new files added in [37406] and [37409]. 
Part 6/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37411


git-svn-id: http://core.svn.wordpress.org/trunk@37377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 11:59:27 +00:00
Dominik Schilling
23e2a486ae Upgrader: Update file headers for new files added in [37409]. 
Part 5/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37410


git-svn-id: http://core.svn.wordpress.org/trunk@37376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 11:52:28 +00:00
Dominik Schilling
14e5d77132 Upgrader: Copy WP_Upgrader subclasses into one file per class. 
Part 4/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37409


git-svn-id: http://core.svn.wordpress.org/trunk@37375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 11:45:42 +00:00
Dominik Schilling
5f1ac9c96d Upgrader: Update wp-admin/includes/class-wp-upgrader-skins.php to require_once the new files added in [37406]. 
Part 3/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37408


git-svn-id: http://core.svn.wordpress.org/trunk@37374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 11:42:26 +00:00
Dominik Schilling
4b846677ba Upgrader: Update file headers and class DocBlocks for new files added in [37406]. 
Part 2/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37407


git-svn-id: http://core.svn.wordpress.org/trunk@37373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 11:31:28 +00:00
Dominik Schilling
bbecb1a485 Upgrader: Copy WP_Upgrader_Skin and its subclasses into one file per class. 
Part 1/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37406


git-svn-id: http://core.svn.wordpress.org/trunk@37372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 11:11:30 +00:00
Weston Ruter
574be8f2a8 Customize: Ensure that wp_setup_nav_menu_item filter applies consistently on nav_menu_item setting values. 
The filter was being applied in `WP_Customize_Nav_Menu_Item_Setting::value()` but not in `WP_Customize_Nav_Menu_Item_Setting::value_as_wp_post_nav_menu_item()`.

Props celloexpressions, westonruter.
Fixes #35203.

Built from https://develop.svn.wordpress.org/trunk@37405


git-svn-id: http://core.svn.wordpress.org/trunk@37371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 06:41:29 +00:00
Dominik Schilling
096d0ccd63 Tests: Don't create unused users in Tests_Ajax_DeleteComment. 
Fixes #36616.
Built from https://develop.svn.wordpress.org/trunk@37404


git-svn-id: http://core.svn.wordpress.org/trunk@37370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-09 19:17:29 +00:00
Sergey Biryukov
ff37a3b730 Docs: Fix typo in a comment in check_and_publish_future_post(). 
See #32246.
Built from https://develop.svn.wordpress.org/trunk@37403


git-svn-id: http://core.svn.wordpress.org/trunk@37369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-08 12:46:29 +00:00
Dominik Schilling
b5718124c3 External Libraries: Replace split() with explode() in the deprecated Atom and MagpieRSS files. 
Before PHP7 `split()` was throwing a deprecated notice, in PHP7 the function is completely removed and throws a fatal error.

Props achbed.
Fixes #20673.
Built from https://develop.svn.wordpress.org/trunk@37402


git-svn-id: http://core.svn.wordpress.org/trunk@37368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-07 15:59:29 +00:00
Nikolay Bachiyski
c33e975f46 External Libraries: Update plupload from upstream 
Built from https://develop.svn.wordpress.org/trunk@37383


git-svn-id: http://core.svn.wordpress.org/trunk@37349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-06 18:02:26 +00:00
Dominik Schilling
a493dc0ab5 External Libraries: Update MediaElement.js from upstream. 
Built from https://develop.svn.wordpress.org/trunk@37370


git-svn-id: http://core.svn.wordpress.org/trunk@37336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-06 17:51:36 +00:00
Sergey Biryukov
b65cbd6003 Options: After [33738], consistently pass option name as the second parameter to the 'default_option_' . $option filter in add_option() and update_option(). 
Props dlh.
Fixes #36761.
Built from https://develop.svn.wordpress.org/trunk@37367


git-svn-id: http://core.svn.wordpress.org/trunk@37333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-05 20:24:29 +00:00
Drew Jaynes
2459e4e880 Docs: Remove backticks from the DocBlock summary for WP::$request, added in [37356]. 
Markdown formatting is not supported in DocBlock summaries, per the inline documentation standards for PHP :-)

See #32246. See #36674.

Built from https://develop.svn.wordpress.org/trunk@37366


git-svn-id: http://core.svn.wordpress.org/trunk@37332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-05 20:03:27 +00:00
Jeremy Felt
ced66ed4e7 Multisite: Use the admin-multisite Dashicon for sites 
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.

Uses the more appropriate `dashicons-admin-multisite` when displaying the sites menu item.

Props Ipstenu, ocean90.
Fixes #36754.

Built from https://develop.svn.wordpress.org/trunk@37365


git-svn-id: http://core.svn.wordpress.org/trunk@37331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-05 17:13:26 +00:00
Jeremy Felt
db3d5a6bea Revert [37362], which incorrectly changed Dashicons CSS 
`dashicons.css` is an external-ish library and the change there is incorrect.

See #36754.

Built from https://develop.svn.wordpress.org/trunk@37364


git-svn-id: http://core.svn.wordpress.org/trunk@37330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-05 15:29:27 +00:00
Helen Hou-Sandí
610215ceb1 Revive grunt-rtlcss, which does not appear to enjoy syntax errors. 
props netweb.
see #36753, #29792.

Built from https://develop.svn.wordpress.org/trunk@37363


git-svn-id: http://core.svn.wordpress.org/trunk@37329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-05 15:22:27 +00:00
Jeremy Felt
172af4e0ce Multisite: Use the admin-multisite Dashicon in the admin menu and bar 
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.

Props Ipstenu.
Fixes #36754.

Built from https://develop.svn.wordpress.org/trunk@37362


git-svn-id: http://core.svn.wordpress.org/trunk@37328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-05 04:29:26 +00:00
Helen Hou-Sandí
a800cf654b Drop Open Sans in the admin in favor of system fonts. 
Rejoice, for your admins will feel more native to your surrounding computing environment and likely load faster, especially when offline, as they no longer have to talk to The Google Overlord.

At the time of introduction in 3.8, there were not good system fonts common to all platforms at the time. In the years since, Windows, Android, OS X, iOS, Firefox OS, and various flavors of Linux have all gotten their own (good) system UI fonts.

There will definitely be visual bugs, mainly around alignment and spacing; these should be documented and reported on the ticket and fixed more atomically so that our current and future selves have a better understanding of what happened and why.

The style remains registered, as it is almost certainly in use by themes and plugins.

props mattmiklic.
see #36753.

Built from https://develop.svn.wordpress.org/trunk@37361


git-svn-id: http://core.svn.wordpress.org/trunk@37327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-04 22:07:37 +00:00
Boone Gorges
2d37a0ee17 Users: The 'who' parameter should not interfere with 'meta_key' + 'meta_value' in WP_User_Query. 
Props adrianosilvaferreira.
Fixes #36724.
Built from https://develop.svn.wordpress.org/trunk@37360


git-svn-id: http://core.svn.wordpress.org/trunk@37326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-04 18:57:28 +00:00
Boone Gorges
3c70037d46 Tests: Correct 'meta_query' syntax in test related to WP_User_Query 'who' param. 
The test, introduced in [32207], used the incorrect syntax for 'meta_query' -
one fewer level of array-nesting than what `WP_Meta_Query` requires. This
slip uncovered a bug introduced into `WP_User_Query` in [30094], whereby
an incorrectly formatted 'meta_query' parameter would be properly parsed by
`WP_User_Query` when passed alongside `who=authors`.

We need to fix the inconsistent syntax in order to resolve #36724.

See #36724, #32019, #23849, #27026.
Built from https://develop.svn.wordpress.org/trunk@37359


git-svn-id: http://core.svn.wordpress.org/trunk@37325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-04 18:49:29 +00:00
Boone Gorges
4f4a45ca1c Tests: Introduce reset_phpmailer_instance() function. 
This function provides a more convenient method for resetting the
PHPMailer instance than the previous technique of reaching into the global.

Props welcher.
Fixes #36658.
Built from https://develop.svn.wordpress.org/trunk@37358


git-svn-id: http://core.svn.wordpress.org/trunk@37324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-04 03:49:26 +00:00
Boone Gorges
0469f12d7b Add tests for is_serialized_string(). 
Props borgesbruno.
Fixes #35952.
Built from https://develop.svn.wordpress.org/trunk@37357


git-svn-id: http://core.svn.wordpress.org/trunk@37323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-04 03:30:27 +00:00
Eric Lewis
98d5d4919c Rewrite Rules: Add self-describing variables to rewrite matcher. 
The rewrite rule matching code in WP::parse_request() used an unclear variable `$request` to represent the requested path (e.g. "2016/05/03") as well as a deceptively named variable `$request_uri`, which actually represents the requested file when an install used PATHINFO links. 

Those variables are replaced with `$requested_path` and `$requested_file` respectively for clarity.

Fixes #36674.

Built from https://develop.svn.wordpress.org/trunk@37356


git-svn-id: http://core.svn.wordpress.org/trunk@37322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-03 19:36:28 +00:00
Drew Jaynes
c7a2b7683b Docs: Add a missing hook doc for the parse_comment_query hook, added in [31793]. 
Props flixos90.
See #24826. Fixes #36740.

Built from https://develop.svn.wordpress.org/trunk@37355


git-svn-id: http://core.svn.wordpress.org/trunk@37321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-03 16:22:27 +00:00
Boone Gorges
2f66998e3f date_query should be a property on WP_Comment_Query objects. 
Instead of a local variable.

Props flixos90.
Fixes #36741.
Built from https://develop.svn.wordpress.org/trunk@37354


git-svn-id: http://core.svn.wordpress.org/trunk@37320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-03 16:15:29 +00:00
Drew Jaynes
ebfc1467bb Links: Rename the $link_id parameter in get_link_to_edit() to $link to better reflect that it can accept a link ID or object. 
Props tloureiro for the initial patch.
Fixes #36736.

Built from https://develop.svn.wordpress.org/trunk@37353


git-svn-id: http://core.svn.wordpress.org/trunk@37319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 23:43:27 +00:00
Weston Ruter
4113ccfc47 Customize: Handle filtering sidebars_widgets when the underlying option is non-existent. 
Fixes warning related to a non-array argument for `array_merge()` in `WP_Customize_Widgets::customize_register()`. 

See [37166].
See #36389.
Fixes #36660.

Built from https://develop.svn.wordpress.org/trunk@37352


git-svn-id: http://core.svn.wordpress.org/trunk@37318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 23:42:28 +00:00
Drew Jaynes
3470faa683 Links: Clarify documentation for the $link_id parameter to mention that it accepts either an integer or object. 
Props tloureiro.
See #36736.

Built from https://develop.svn.wordpress.org/trunk@37351


git-svn-id: http://core.svn.wordpress.org/trunk@37317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 23:40:27 +00:00
Weston Ruter
f98a2ed41d Customize: Pass WP_Customize_Setting instance as second argument to customize_value_{$id_base} filter. 
Adds parity with setting instance being passed as second argument to `customize_sanitize_{$id}` and `customize_sanitize_js_{$id}`. Allows the actual ID of the (multidimensional) setting value being filtered to be inspected.

Props celloexpressions, westonruter.
Fixes #36452.

Built from https://develop.svn.wordpress.org/trunk@37350


git-svn-id: http://core.svn.wordpress.org/trunk@37316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 22:42:26 +00:00
Drew Jaynes
5f62db2f21 Comments: Realign parameter documentation in the DocBlocks for comment_author_email_link() and get_comment_author_email_link() following [37348]. 
Also adds a missing return description for `get_comment_author_email_link()`.

Props flixos90 for the initial patch.
Fixes #36571.

Built from https://develop.svn.wordpress.org/trunk@37349


git-svn-id: http://core.svn.wordpress.org/trunk@37315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 20:04:28 +00:00
Drew Jaynes
a6c393828d Comments: Adjust comment_author_email_link() and get_comment_author_email_link() to each accept a new optional fourth parameter, $comment, which enables overriding the $comment global. 
Adds tests.

Props flixos90, boonebgorges, DrewAPicture.
See #36571.

Built from https://develop.svn.wordpress.org/trunk@37348


git-svn-id: http://core.svn.wordpress.org/trunk@37314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 19:59:27 +00:00
Weston Ruter
3a37220f2a Customize: Allow Esc key to collapse the currently-expanded panel, section (or control). 
Pressing Esc collapses any expanded widget or nav menu item controls, or any control that implements the expanding interface. Also improves alignment between `WidgetControl` and `MenuItemControl`, adding the `expanded` state and associated `expand`/`collapse` methods to nav menu items.

Props purcebr, celloexpressions, westonruter.
Fixes #22237.

Built from https://develop.svn.wordpress.org/trunk@37347


git-svn-id: http://core.svn.wordpress.org/trunk@37313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 19:52:28 +00:00
Weston Ruter
a0d7e83beb Customize: Ensure settings modified during an open save request remain dirty when save request completes. 
Also disables Save & Publish button while save request is open. After the save request completes, any settings changed during the request can then be saved via an additional click to the button.

Props chandrapatel, westonruter.
Fixes #32941.

Built from https://develop.svn.wordpress.org/trunk@37346


git-svn-id: http://core.svn.wordpress.org/trunk@37312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 19:13:26 +00:00
Eric Lewis
aba14233d9 Posts: Allow get_page_uri() to be called without a $page argument. 
`get_page_uri()` can now be called without an argument, which will return the page URI for the current post in the loop.

Props pollett.
Fixes #26284.

Built from https://develop.svn.wordpress.org/trunk@37345


git-svn-id: http://core.svn.wordpress.org/trunk@37311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 18:29:29 +00:00
Drew Jaynes
f3a90cd1a6 Tests: Remove debug cruft left over from [34816]. 
See #17078.

Built from https://develop.svn.wordpress.org/trunk@37344


git-svn-id: http://core.svn.wordpress.org/trunk@37310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 16:24:29 +00:00
Drew Jaynes
6683100d2c Docs: Improve the class DocBlock for WP_Widget to clarify which methods "should" vs "must" be overridden by extending sub-classes. 
Props Frank-Klein.
Fixes #36703.

Built from https://develop.svn.wordpress.org/trunk@37343


git-svn-id: http://core.svn.wordpress.org/trunk@37309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 04:53:27 +00:00
Drew Jaynes
fe3b007fdd Docs: Remove inline @see tags from function, class, and method references in inline docs. 
Known functions, classes, and methods are now auto-linked in Code Reference pages following #meta1483.

Note: Hook references are still linked via inline `@see` tags due to the unlikelihood of reliably matching for known hooks based on a RegEx pattern.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@37342


git-svn-id: http://core.svn.wordpress.org/trunk@37308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 04:00:28 +00:00
Dominik Schilling
9354965638 Customize: Increase the target size of the expand/collapse button in the customizer. 
To improve accessibility on touch devices increase the size of the button in the collapsed view from 24×28 to 44×45 pixel.

Props celloexpressions.
Fixes #36093.
Built from https://develop.svn.wordpress.org/trunk@37341


git-svn-id: http://core.svn.wordpress.org/trunk@37307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-01 20:29:27 +00:00
Dominik Schilling
f0962c42ab Travis CI: Include npm prune in the before_script command. 
Caching of node modules was added in [37058]. `npm prune` removes extraneous packages so the cache contains only current modules.

Props netweb.
Fixes #36490.
Built from https://develop.svn.wordpress.org/trunk@37340


git-svn-id: http://core.svn.wordpress.org/trunk@37306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-01 20:04:27 +00:00
Dominik Schilling
823ec71cd6 Customize: Don't auto-close the customizer when a new theme is activated. 
Props celloexpressions.
Fixes #35320.
Built from https://develop.svn.wordpress.org/trunk@37339


git-svn-id: http://core.svn.wordpress.org/trunk@37305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-01 19:54:27 +00:00
Drew Jaynes
664bb85f1b Docs: Add backtick escaping for two inline code samples in docs. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@37338


git-svn-id: http://core.svn.wordpress.org/trunk@37304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-01 17:32:26 +00:00
Drew Jaynes
0055c9746c Docs: Standardize on using :: for Class::method() references in WP_Customize_Control` inline docs. 
See #32246. See #meta1483.

Built from https://develop.svn.wordpress.org/trunk@37337


git-svn-id: http://core.svn.wordpress.org/trunk@37303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-01 17:28:27 +00:00
Andrea Fercia
22bae92301 Themes: restore Theme Installer missing spinner. 
Fixes #36730.
Built from https://develop.svn.wordpress.org/trunk@37336


git-svn-id: http://core.svn.wordpress.org/trunk@37302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-01 15:43:27 +00:00
Sergey Biryukov
dc5815146e Dashboard: Display the comment counts in wp_dashboard_right_now() in the rare initial condition when there are 0 approved comments and only pending comments, so the AJAX count update could work. 
Props afercia.
Fixes #35519.
Built from https://develop.svn.wordpress.org/trunk@37335


git-svn-id: http://core.svn.wordpress.org/trunk@37301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-01 11:06:28 +00:00
Sergey Biryukov
49a47bb255 Docs: Document the @return value of wp_add_trashed_suffix_to_post_name_for_post(). 
Props Shelob9.
Fixes #36728.
Built from https://develop.svn.wordpress.org/trunk@37334


git-svn-id: http://core.svn.wordpress.org/trunk@37300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-01 10:16:29 +00:00
Weston Ruter
6693acdb24 Widgets: Provide PHP 5.2 fallback for spl_object_hash() if disabled in logic for registering and unregistering pre-instantiated widgets. 
Fixes #28216.

Built from https://develop.svn.wordpress.org/trunk@37333


git-svn-id: http://core.svn.wordpress.org/trunk@37299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-30 22:36:28 +00:00
Dominik Schilling
4b51bc18cc Plugins: In plugin_basename() normalize the file path before unresolving symlinks. 
`$wp_plugin_paths` contains normalized paths, see `wp_register_plugin_realpath()`.

Props jdgrimes, voldemortensen, flyingdr, ocean90.
Fixes #29154.
Built from https://develop.svn.wordpress.org/trunk@37332


git-svn-id: http://core.svn.wordpress.org/trunk@37298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-30 15:09:27 +00:00
Dominik Schilling
697a6d5560 Plugins: In uninstall_plugin() pass the plugin file to wp_register_plugin_realpath(). 
`wp_register_plugin_realpath()` calls `dirname( $file );` to remove the basename. The basename must be included in the argument or the symlinked directory won't be registered.

Props andy.
Fixes #36709.
Built from https://develop.svn.wordpress.org/trunk@37331


git-svn-id: http://core.svn.wordpress.org/trunk@37297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-30 15:04:27 +00:00
Andrea Fercia
93c8cdbaed Accessibility: improve the Star Ratings hiding empty elements for assistive technologies. 
Fixes #36725.
Built from https://develop.svn.wordpress.org/trunk@37330


git-svn-id: http://core.svn.wordpress.org/trunk@37296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-30 14:33:29 +00:00
Weston Ruter
96104fdd30 Widgets: Allow WP_Widget subclass instances (objects) to be registered/unregistered in addition to WP_Widget subclass names (strings). 
Allows widgets to be registered which rely on dependency injection. Also will allow for new widget types to be created dynamically (e.g. a Recent Posts widget for each registered post type).

See #35990.
Props mdwheele, PeterRKnight, westonruter.
Fixes #28216.

Built from https://develop.svn.wordpress.org/trunk@37329


git-svn-id: http://core.svn.wordpress.org/trunk@37295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-29 18:49:26 +00:00
Scott Taylor
fb82d557cd Media/Unit Tests: ensure that image sizes are indeed removed when errors are raised before assertions in Tests_Media. 
See #36588.

Built from https://develop.svn.wordpress.org/trunk@37328


git-svn-id: http://core.svn.wordpress.org/trunk@37294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-29 17:52:29 +00:00
Scott Taylor
188bea204b Media/Unit Tests: ensure that the GD absrtraction is used for GD unit tests for Images. Some of the procedural GD API functions can still throw ImagickException, which is fun. 
See #36588.

Built from https://develop.svn.wordpress.org/trunk@37327


git-svn-id: http://core.svn.wordpress.org/trunk@37293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-29 16:16:27 +00:00
Jeremy Felt
2e94a24e25 Multisite: Add the pre_get_blogs_of_user filter 
This allows a plugin to short circuit `get_blogs_of_user()` in cases where the default behavior of the function is unnecessary or slow. (e.g. A user is a member of thousands of sites.)

Props jsternberg.
See #31746, Fixes #36707.

Built from https://develop.svn.wordpress.org/trunk@37326


git-svn-id: http://core.svn.wordpress.org/trunk@37292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-29 15:53:28 +00:00
Scott Taylor
5efc557eb8 Comments: pass $comment to comment_text() in Walker_Comment::comment() instead of using a function which can skip the cache. 
Props rachelbaker.
Fixes #35433.

Built from https://develop.svn.wordpress.org/trunk@37325


git-svn-id: http://core.svn.wordpress.org/trunk@37291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-29 15:47:27 +00:00
Boone Gorges
9bf510260f Query: Discard non-scalar 'm' instead of attempting to sanitize. 
`WP_Query` discards most non-array date values ('year', 'monthnum', etc) by
casting to integer. Since [25138], the 'm' parameter has been handled
as a string; see #24884. However, the string-handling introduced in [25138]
blindly attempted to handle arrays and other non-scalar types as strings,
resulting in PHP notices and invalid MySQL syntax.

Props vortfu.
Fixes #36718.
Built from https://develop.svn.wordpress.org/trunk@37324


git-svn-id: http://core.svn.wordpress.org/trunk@37290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-29 13:15:30 +00:00
Rachel Baker
15eaa665c1 Widgets: When the Inactive Widgets section is hidden also hide the “Clear Inactive Widgets” button description text. 
Props welcher.

Fixes #35592.


Built from https://develop.svn.wordpress.org/trunk@37323


git-svn-id: http://core.svn.wordpress.org/trunk@37289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-28 20:40:28 +00:00
Weston Ruter
09860ae46c Customize: Remove format placeholders from widget templates and selectors, fixing a jQuery selector syntax error and the broken highlight/shift-click behaviors. 
The issues occur in themes that register sidebars that reference a single format placeholder (`%1$s` and `%2$s`) multiple times, such as in the `id` and `class` attributes for `$before_widget`.

Props martin.krcho, westonruter.
Fixes #36473.

Built from https://develop.svn.wordpress.org/trunk@37322


git-svn-id: http://core.svn.wordpress.org/trunk@37288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-28 18:20:29 +00:00
Michael Arestad
7726afe693 Component: Administration 
Setting the background color on `body` is more flexible than on the `html` element. This patch assigns the background color to `body` instead of the `html` element.

Fixes #35314

Built from https://develop.svn.wordpress.org/trunk@37321


git-svn-id: http://core.svn.wordpress.org/trunk@37287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-28 03:16:28 +00:00
Eric Lewis
cc1b2fae67 Database: Set MySQL connection collation. 
Fixes #36649.

Built from https://develop.svn.wordpress.org/trunk@37320


git-svn-id: http://core.svn.wordpress.org/trunk@37286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-28 01:39:26 +00:00
Eric Lewis
d6a377acdc Build/Test Tools: Document WP_UnitTestCase->go_to() 
Fixes #36679.

Built from https://develop.svn.wordpress.org/trunk@37319


git-svn-id: http://core.svn.wordpress.org/trunk@37285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-27 18:25:29 +00:00
Jeremy Felt
0df948da2d Tests: Reduce unnecessary count in create_many() in multisite user tests 
The tests for `is_blog_user()` and `is_user_member_of_blog()` should be refactored. Until then, we can shave several seconds from the test time by avoiding unnecessary loops of the same tests.

See #36566.

Built from https://develop.svn.wordpress.org/trunk@37318


git-svn-id: http://core.svn.wordpress.org/trunk@37284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-27 06:33:27 +00:00
Jeremy Felt
6226af307b Users: Prevent spammy users from resetting their passwords in multisite 
Props r-a-y, websupporter.
Fixes #24617.

Built from https://develop.svn.wordpress.org/trunk@37317


git-svn-id: http://core.svn.wordpress.org/trunk@37283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-27 05:55:27 +00:00
Jeremy Felt
98d8ad680b Users: Provide a full user object when checking for a spammy multisite user 
`is_user_spammy()` falls back to the current user if one is not provided. There is no current user during authentication, so the result is always `false`. Pass a user to fill the void.

Adds tests for `wp_authenticate_spam_check()`.

Props websupporter.
Fixes #36546.

Built from https://develop.svn.wordpress.org/trunk@37316


git-svn-id: http://core.svn.wordpress.org/trunk@37282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-27 05:36:28 +00:00
Eric Lewis
02a4e761f2 Users: Correct inline docs for cookie expiration. 
Props kjbenk.
Fixes #35568.

Built from https://develop.svn.wordpress.org/trunk@37315


git-svn-id: http://core.svn.wordpress.org/trunk@37281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-27 02:52:28 +00:00
Rachel Baker
56c18bb5af Users: Remove the “Name” column of the Users table from appearing sortable. 
The “Name” column of the Users WP List Table is not sortable because this column displays a concatenation of two optional values, `first_name` and `last_name`. Even if WP_User_Query supported ordering queries in this manner, the resulting sequence would be chaotic.

Fixes #28064.

Props jesin, and rachelbaker.
Built from https://develop.svn.wordpress.org/trunk@37314


git-svn-id: http://core.svn.wordpress.org/trunk@37280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-26 20:35:29 +00:00
Rachel Baker
ddbde15454 Post Thumbnails: Fix logic bug and tests from [37308] where post-thumbnails support wasn’t added if there were no previous post_types with support already. 
See #22080
Built from https://develop.svn.wordpress.org/trunk@37313


git-svn-id: http://core.svn.wordpress.org/trunk@37279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-26 20:29:27 +00:00
Rachel Baker
e510918b4e Tests: Fix typo current_theme_support() -> current_theme_supports() from [37308] 
Built from https://develop.svn.wordpress.org/trunk@37309


git-svn-id: http://core.svn.wordpress.org/trunk@37275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-26 17:31:29 +00:00
Rachel Baker
af5c5a9a25 Post Thumbnails: When using add_theme_support( ‘post-thumbnails’, array( $post_types) ) merge the supported post_types. 
Allow the adding of post-thumbnail support for one or more post_types without unsetting any previously added post_types. This matches the behavior of other uses of `add_theme_support()` and the expectations of a function with a prefix of “add”.
To unset post-thumbnail support use `remove_theme_support()` instead.

Fixes #22080

Props alexkingorg, jmichaelward, and flixos90.
Built from https://develop.svn.wordpress.org/trunk@37308


git-svn-id: http://core.svn.wordpress.org/trunk@37274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-26 17:05:31 +00:00
Sergey Biryukov
f3b7842281 Build/Test Tools: Reset the PHPMailer mock in Tests_Mail::tearDown(). 
Props welcher.
Fixes #36609.
Built from https://develop.svn.wordpress.org/trunk@37307


git-svn-id: http://core.svn.wordpress.org/trunk@37273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-23 08:16:29 +00:00
Scott Taylor
be6a91bf58 Unit Tests: prevent rewrite spillage from @group author unit tests. 
See #36587.

Built from https://develop.svn.wordpress.org/trunk@37306


git-svn-id: http://core.svn.wordpress.org/trunk@37272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-22 23:48:27 +00:00
Scott Taylor
8ec77ea445 Comments: add a $comment parameter to get_comment_author_url_link(). 
Add unit tests (none exist).

Props flixos90, wonderboymusic.
Fixes #36573.

Built from https://develop.svn.wordpress.org/trunk@37305


git-svn-id: http://core.svn.wordpress.org/trunk@37271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-22 22:45:27 +00:00
Rachel Baker
e02de569a6 Comments: Add unordered list styling to Comments List Table rows and Moderate Comment screen. 
Fixes #36160

Props juanfra.
Built from https://develop.svn.wordpress.org/trunk@37304


git-svn-id: http://core.svn.wordpress.org/trunk@37270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-22 21:47:26 +00:00
Rachel Baker
8b0e1859bc Comments: Keep comments safe in the Edit Post screen. 
Warns users that have added a new Comment or began editing an existing without saving their changes, before they press the “update” button which would wipe out their comment changes.

Fixes #32818.

Props polevaultweb.
Built from https://develop.svn.wordpress.org/trunk@37303


git-svn-id: http://core.svn.wordpress.org/trunk@37269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-22 21:43:28 +00:00
Scott Taylor
be59d289b7 Dashboard: toggle the "View" link for comments when Approving / Unapproving from the Dashboard widget. 
Fixes #35518.

Built from https://develop.svn.wordpress.org/trunk@37302


git-svn-id: http://core.svn.wordpress.org/trunk@37268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-22 21:30:28 +00:00
Andrew Ozz
59d388038e TinyMCE: prevent showing the placeholder URL when adding a link and clicking more than once on the Insert Link button. 
Props iseulde.
Fixes #36637 for trunk.
Built from https://develop.svn.wordpress.org/trunk@37301


git-svn-id: http://core.svn.wordpress.org/trunk@37267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-22 19:11:28 +00:00
Jeremy Felt
0fd08986dd Tests: Account for flexible IDs in main network deletion test 
After [37299], the network IDs encountered by this test may be larger than "100".

This adjusts the test to respond accordingly until we have a better way to delete networks.

See #36566.

Built from https://develop.svn.wordpress.org/trunk@37300


git-svn-id: http://core.svn.wordpress.org/trunk@37266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-22 15:22:27 +00:00
Boone Gorges
269c9fe421 Tests: Use the same incrementor for all fields belonging to a given text fixture. 
[35244] changed the way that `WP_UnitTest_Generator_Sequence()` created an
incrementor for object fields (like 'post_name' and 'user_email'), by making
incrementor static across the entire run of the test suite. While this helped
to enforce uniqueness across the tests, it has the side effect of bumping the
incrementor between fields on the same object (so that, eg, the same post might
have `post_name` "post-12" but `post_title` "Post 13". By switching to a
technique that uses the same incrementor for each field belonging to a given
fixture, we conform better to the expectations of developers using
`WP_UnitTest_Factory`.

Fixes #35199.
Built from https://develop.svn.wordpress.org/trunk@37299


git-svn-id: http://core.svn.wordpress.org/trunk@37265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-22 14:36:29 +00:00
Gary Pendergast
cb7ea89c8e Smilies: Move convert_smilies to happen later in the the_content filter. 
In particular, we want it to occur after shortcode handling. The smiley conversion routine doesn't have any concept of shortcode structure, so may inadvertantly replace a smiley with HTML inside a shortcode attribute, which will cause the shortcode to not be parsed correctly.

Props Unyson for the initial suggested fix.

Fixes #36306. 


Built from https://develop.svn.wordpress.org/trunk@37298


git-svn-id: http://core.svn.wordpress.org/trunk@37264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-22 07:08:27 +00:00
Sergey Biryukov
45b7930627 Text Changes: Consistently refer to https://wordpress.org/plugins/ and https://wordpress.org/themes/ as WordPress Plugin Directory and WordPress Theme Directory, respectively. 
Props mpol.
Fixes #35938.
Built from https://develop.svn.wordpress.org/trunk@37297


git-svn-id: http://core.svn.wordpress.org/trunk@37263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-22 06:57:26 +00:00
Gary Pendergast
33cb1be012 Emoji: The :roll: smiley is now an emoji. 
Unicode 8 added `U+1F644`, "Face with Rolling Eyes", which matches our `:roll:` smiley. Continuing our ever present quest to rid the world of legacy smilies, we now translate that smiley into its emoji form.

Sadly, `:mrgreen:` remains sorely under-represented in the Unicode standard, I'm inclined to think that we should buy a voting membership of the Unicode Consortium, in order to rectify that situation. (Personally, I'm hoping for a green skin tone modifier.)

Fixes #36365.
 


Built from https://develop.svn.wordpress.org/trunk@37296


git-svn-id: http://core.svn.wordpress.org/trunk@37262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-22 06:29:27 +00:00
Gary Pendergast
b45e906927 Database: Suppress connection error messages when WP_DEBUG isn't enabled. 
This is a partial revert of [35860], which has been causing un-catchable warnings to be generated on some server configurations.

Fixes #36629 for trunk.
See #21870.


Built from https://develop.svn.wordpress.org/trunk@37292


git-svn-id: http://core.svn.wordpress.org/trunk@37258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-22 05:19:27 +00:00
Dominik Schilling
c3fe61770c Media: Remove an extra quote when sending a link of a media file to the editor. 
Introduced in [37035].

Props joemcgill, swissspidy, boonebgorges.
Fixes #36578.
Built from https://develop.svn.wordpress.org/trunk@37288


git-svn-id: http://core.svn.wordpress.org/trunk@37254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 21:21:28 +00:00
Dominik Schilling
93eaf20f29 Themes: Update list of WordPress theme features. 
* Remove color tags.
* Layout: Add Grid Layout, remove Fixed Layout, Fluid Layout, and Responsive Layout.
* Features: Add Footer Widgets, remove Blavatar.
* Subject: Add Blog, E-Commerce, Education, Entertainment, Food & Drink, Holiday, News, Photography and Portfolio, remove Photoblogging and Seasonal.

Props grapplerulrich, davewarfel.
Fixes #33407.
Built from https://develop.svn.wordpress.org/trunk@37287


git-svn-id: http://core.svn.wordpress.org/trunk@37253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 21:11:29 +00:00
Dominik Schilling
3df07b17dd Media: Don't cache the results of wp_mkdir_p() in a persistent cache. 
To improve the performance of `wp_upload_dir()` the result of `wp_mkdir_p()` was stored in a persistent cache, introduced in [36565]. But this becomes an issue when WordPress is scaled horizontally. You may end up caching a value for a server where the directory doesn't exist which will prevent further uploads on other servers because of the persistent cache.
The fix is to use a non-persistent cache.

Props azaozz, ocean90.
See #34359.
Fixes #36621.
Built from https://develop.svn.wordpress.org/trunk@37285


git-svn-id: http://core.svn.wordpress.org/trunk@37251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 19:58:27 +00:00
Weston Ruter
959f1a07a6 Customize/Formatting: Move sanitize_hex_color(), sanitize_hex_color_no_hash(), and maybe_hash_hex_color() from class-wp-customize-manager.php into formatting.php. 
Adds missing braces.

See #33413.
Props downstairsdev, tollmanz.
Fixes #27583.

Built from https://develop.svn.wordpress.org/trunk@37283


git-svn-id: http://core.svn.wordpress.org/trunk@37249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 19:22:27 +00:00
John Blackbourn
a58ec423da Feeds: Revert [36230] which removed the rss-http feed content type. Removing this means that any feeds which are using this feed content type are now being served as application/octet-stream instead of text/xml. 
See #36620

Built from https://develop.svn.wordpress.org/trunk@37282


git-svn-id: http://core.svn.wordpress.org/trunk@37248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 18:57:28 +00:00
Sergey Biryukov
cf12011934 Docs: Move the clarification of is_tax() and WP_Query::is_tax() return value added in [37235] to @return description. 
Props DrewAPicture.
Fixes #36331.
Built from https://develop.svn.wordpress.org/trunk@37281


git-svn-id: http://core.svn.wordpress.org/trunk@37247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 17:47:28 +00:00
Boone Gorges
da08f6a3de Tests: More explicit fixture content when testing s=0 query string. 
After [36647], the unit test generator sequence can put a 0 into the
'post_excerpt' field of a post fixture, causing false positives.

See [36520] for a parallel fix involving 'post_content'.

Fixes #36622.
Built from https://develop.svn.wordpress.org/trunk@37280


git-svn-id: http://core.svn.wordpress.org/trunk@37246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 15:53:27 +00:00
Sergey Biryukov
1bd88850f7 Administration: Introduce admin_print_footer_scripts-$hook_suffix", a dynamic version of the admin_print_footer_scripts hook. 
This is now more consistent with the generic `admin_print_scripts` and the dynamic `admin_print_scripts-$hook_suffix` hooks fired in `wp-admin/admin-header.php`.

Props tfrommen.
Fixes #34334.
Built from https://develop.svn.wordpress.org/trunk@37279


git-svn-id: http://core.svn.wordpress.org/trunk@37245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 15:17:27 +00:00
Sergey Biryukov
31b896d1aa Docs: Reflect the new 'user' option for wp_new_user_notification()'s $notify parameter added in [37276] in wp_send_new_user_notifications() docs as well. 
Props ocean90.
Fixes #36009.
Built from https://develop.svn.wordpress.org/trunk@37278


git-svn-id: http://core.svn.wordpress.org/trunk@37244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 12:01:27 +00:00
Sergey Biryukov
d42602334f Users: Add a unit test for [37276]. 
See #36009.
Built from https://develop.svn.wordpress.org/trunk@37277


git-svn-id: http://core.svn.wordpress.org/trunk@37243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 11:52:27 +00:00
Sergey Biryukov
c371296223 Users: In wp_new_user_notification(), sdd 'user' option for the $notify parameter, which allows for sending notification only to the user created. 
Props akibjorklund.
Fixes #36009.
Built from https://develop.svn.wordpress.org/trunk@37276


git-svn-id: http://core.svn.wordpress.org/trunk@37242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 10:20:27 +00:00
Pascal Birchler
a47fa4f197 Rewrite Rules: After [36953], correctly replace existing rules on IIS when updating them. 
Props WiZZarD_.
Fixes #36506 for trunk.
Built from https://develop.svn.wordpress.org/trunk@37273


git-svn-id: http://core.svn.wordpress.org/trunk@37239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 09:33:27 +00:00
Dominik Schilling
7b03510520 Upgrader: Clear plugin/theme caches directly after a plugin/theme has been updated. 
`wp_update_plugins()` and `wp_update_themes()` are both hooked into `upgrader_process_complete` with priority 10. But at this stage the caches in `get_plugins()`, `search_theme_directories()`, and `wp_get_themes()` aren't refreshed yet so both functions couldn't fetch any translations for the new plugin/theme.
To reset the caches, `wp_clean_themes_cache()` and `wp_clean_plugins_cache()` are now hooked into `upgrader_process_complete` with priority 9.

This is a follow-up to [34751].

See #34029.
Fixes #36383.
Built from https://develop.svn.wordpress.org/trunk@37272


git-svn-id: http://core.svn.wordpress.org/trunk@37238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 09:09:28 +00:00
Drew Jaynes
7c5f77ece3 Tests: Pre-declare the $year_url property before initialization in Tests_Get_Archives::setUp(). 
Props pbearne.
Fixes #36611.

Built from https://develop.svn.wordpress.org/trunk@37271


git-svn-id: http://core.svn.wordpress.org/trunk@37237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 02:56:26 +00:00
Drew Jaynes
852e6921d2 Docs: Add missing return descriptions for WP_Filesystem_SSH2::chown() and WP_Filesystem_SSH2::run_command(). 
Fixes #30989.

Built from https://develop.svn.wordpress.org/trunk@37270


git-svn-id: http://core.svn.wordpress.org/trunk@37236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-21 02:38:29 +00:00
Jeremy Felt
bfaad85d86 Tests: Exclude ms-files test group from default PHPUnit config 
Multisite specific tests run as normal with `phpunit.xml.dist` and multisite constants defined. The `ms-files` group causes pollution when mixed with the rest of the tests, so it should be excluded here too.

See #36566.

Built from https://develop.svn.wordpress.org/trunk@37269


git-svn-id: http://core.svn.wordpress.org/trunk@37235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-20 17:11:27 +00:00
Aaron Jorbin
fd4829b1a5 Don't announce PR builds in Slack 
People may submit a PR to our travis build repo, we shouldn't notify slack when that happens.
See https://docs.travis-ci.com/user/notifications/#Slack-notifications

Fixes #36607


Built from https://develop.svn.wordpress.org/trunk@37268


git-svn-id: http://core.svn.wordpress.org/trunk@37234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-20 17:09:27 +00:00
Jeremy Felt
380128e053 Tests: Add speedTrapListener to multisite's PHPUnit config 
See #36566, #30017.

Built from https://develop.svn.wordpress.org/trunk@37267


git-svn-id: http://core.svn.wordpress.org/trunk@37233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-20 17:02:27 +00:00
Jeremy Felt
285d3406f8 Tests: Allow override of MULTISITE and SUBDOMAIN_INSTALL constants 
Props rmccue.
Fixes #36567.

Built from https://develop.svn.wordpress.org/trunk@37266


git-svn-id: http://core.svn.wordpress.org/trunk@37232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-20 16:52:29 +00:00