Scott Taylor
169db9dbb1
Comments: add a 'comment_excerpt_length'
filter to get_comment_excerpt()
.
...
Create the first ever unit tests for `get_comment_excerpt()`.
Props dannydehaan, wonderboymusic.
Fixes #27526 .
Built from https://develop.svn.wordpress.org/trunk@34520
git-svn-id: http://core.svn.wordpress.org/trunk@34484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 21:05:25 +00:00
John Blackbourn
92fb281b71
Use WP_TESTS_DOMAIN
where it should be used in tests in place of hard-coded uses of example.org
.
...
Also corrects a test value in the data provider for `Tests_Sanitize_Option::test_sanitize_option()` which was only consequentially passing.
Fixes #34000
Built from https://develop.svn.wordpress.org/trunk@34519
git-svn-id: http://core.svn.wordpress.org/trunk@34483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 21:02:26 +00:00
John Blackbourn
ee04cc0638
Another missed file from [34172].
...
See #33877
Built from https://develop.svn.wordpress.org/trunk@34518
git-svn-id: http://core.svn.wordpress.org/trunk@34482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 20:33:26 +00:00
Scott Taylor
44822831fe
Comments List Table JS: move the dynamic count functions into closure scope so that setCommentsList
AND commentReply
can access them. Update counts when replying inline.
...
Fixes #33403 .
Built from https://develop.svn.wordpress.org/trunk@34517
git-svn-id: http://core.svn.wordpress.org/trunk@34481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 20:16:49 +00:00
John Blackbourn
bef8977ea1
Add a @since
entry for the implementation of the $public
argument in register_taxonomy()
.
...
See #21949
Built from https://develop.svn.wordpress.org/trunk@34516
git-svn-id: http://core.svn.wordpress.org/trunk@34480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 20:16:26 +00:00
Scott Taylor
79974ac413
Edit Post: in the logic determining whether to display the Comments meta box, check for the current post status in get_post_stati( array( 'public' => true ) )
instead of just checking publish
and private
. Ensure that private
is checked in both instances.
...
Props Thaicloud, wonderboymusic.
Fixes #24486 .
Built from https://develop.svn.wordpress.org/trunk@34515
git-svn-id: http://core.svn.wordpress.org/trunk@34479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 20:02:24 +00:00
Scott Taylor
bf04b211a4
Widgets: use input[type="number"]
for the number
prop in the Recent Posts and Recent Comments widget forms.
...
Props helen, obenland, mordauk.
Fixes #22965 .
Built from https://develop.svn.wordpress.org/trunk@34514
git-svn-id: http://core.svn.wordpress.org/trunk@34478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 19:53:26 +00:00
John Blackbourn
949b6ee1df
Convert the $args
passed to register_post_type()
into an array before passing them to the new register_post_type_args
filter.
...
Fixes #17447
Built from https://develop.svn.wordpress.org/trunk@34513
git-svn-id: http://core.svn.wordpress.org/trunk@34477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 19:39:25 +00:00
Drew Jaynes
f84c653fad
Docs: Clarify the summary and optional $query
parameter description for remove_query_arg()
.
...
Props johnbillion.
Fixes #33912 .
Built from https://develop.svn.wordpress.org/trunk@34512
git-svn-id: http://core.svn.wordpress.org/trunk@34476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 19:34:24 +00:00
Drew Jaynes
92574015aa
Docs: Overhaul the DocBlock for add_query_arg()
to attempt to better explain the various call signatures it accepts.
...
Also adds a couple of in-DocBlock examples illustrating single key and value, and associative array usage. Retains the note about the unescaped return value.
Props johnbillion.
See #33912 .
Built from https://develop.svn.wordpress.org/trunk@34511
git-svn-id: http://core.svn.wordpress.org/trunk@34475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 19:32:24 +00:00
Drew Jaynes
a6c8b7aafa
Docs: Convert the $args
parameter description in the register_taxonomy()
DocBlock to a hash notation.
...
Also standardizes the DocBlock summary.
Props johnbillion.
Fixes #33991 .
Built from https://develop.svn.wordpress.org/trunk@34510
git-svn-id: http://core.svn.wordpress.org/trunk@34474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 19:12:26 +00:00
Drew Jaynes
4c7a4bfb25
Docs: Improve the summary and description for the pre_http_request
filter docs to better illustrate expected values.
...
The filter explicitly expects one of three passed value types:
* An array containing 'headers', 'body', 'response', 'cookies', and 'filename' elements
* A `WP_Error` instance
* Boolean false (to avoid short-circuiting the response)
Props johnbillion.
Fixes #33995 .
Built from https://develop.svn.wordpress.org/trunk@34509
git-svn-id: http://core.svn.wordpress.org/trunk@34473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 18:52:25 +00:00
Andrea Fercia
6fdd384fe0
Comments List Table: fix the translators comment for all count after [34506].
...
See #17275 .
Built from https://develop.svn.wordpress.org/trunk@34508
git-svn-id: http://core.svn.wordpress.org/trunk@34472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 18:40:24 +00:00
John Blackbourn
cb740147be
Add $depth
as a parameter in the nav_menu_item_args
filter.
...
Fixes #29417
Built from https://develop.svn.wordpress.org/trunk@34507
git-svn-id: http://core.svn.wordpress.org/trunk@34471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 17:59:24 +00:00
Scott Taylor
4671e03766
Comments List Table: include count for "All". Dynamically update.
...
Fixes #17275 .
Built from https://develop.svn.wordpress.org/trunk@34506
git-svn-id: http://core.svn.wordpress.org/trunk@34470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 17:57:25 +00:00
John Blackbourn
41edf2bc22
Correctly present an error to the user if the nickname field is empty when updating a user profile. It's strange that this field is required, but it is, so be it.
...
Fixes #33310
Props prasad-nevase, metodiew
Built from https://develop.svn.wordpress.org/trunk@34505
git-svn-id: http://core.svn.wordpress.org/trunk@34469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 17:49:25 +00:00
Scott Taylor
bc5eb3a623
Comments: add date
column to WP_Comments_List_Table
to allow sorting and to break out the date/time from the comment content column.
...
Props jshreve.
Fixes #15520 .
Built from https://develop.svn.wordpress.org/trunk@34504
git-svn-id: http://core.svn.wordpress.org/trunk@34468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 17:27:26 +00:00
Scott Taylor
595bad9f37
Comments: In comments_template()
, set $wp_query->comments_by_type
to empty array if not separating comments. The value becomes stale otherwise. Edge case.
...
Props jakub.tyrcha.
Fixes #14809 .
Built from https://develop.svn.wordpress.org/trunk@34503
git-svn-id: http://core.svn.wordpress.org/trunk@34467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 16:31:24 +00:00
Drew Jaynes
b818747870
Docs: Add more explicit optional parameter types and return descriptions in the DocBlocks for is_page()
, is_single()
, is_singular()
.
...
Also adds explicit types and return descriptions to the corresponding `WP_Query` methods: `WP_Query::is_page()`, `WP_Query::is_single()`, and `WP_Query::is_singular()`.
Props Shelob9 for the initial patch.
Fixes #33907 .
Built from https://develop.svn.wordpress.org/trunk@34502
git-svn-id: http://core.svn.wordpress.org/trunk@34466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 16:18:24 +00:00
Dominik Schilling
38b561e8df
Twenty Fifteen: Add a missing comma in rtl.css.
...
Props Toro_Unit.
Fixes #33985 .
Built from https://develop.svn.wordpress.org/trunk@34501
git-svn-id: http://core.svn.wordpress.org/trunk@34465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 16:03:24 +00:00
Scott Taylor
5b9af35c4c
Comments: update Comment counts dynamically in the Right Now widget based on moderation actions in the Activity widget.
...
Fixes #10422 .
Built from https://develop.svn.wordpress.org/trunk@34500
git-svn-id: http://core.svn.wordpress.org/trunk@34464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 15:53:25 +00:00
Drew Jaynes
9dba452afc
Docs: Standardize and clarify class DocBlocks for all of the Upgrade API classes.
...
Standardizes summaries and tags for the following classes:
* `WP_Upgrader`
* `Plugin_Upgrader`
* `Theme_Upgrader`
* `Language_Pack_Upgrader`
* `Core_Upgrader`
* `File_Upload_Upgrader`
* `WP_Automatic_Updater`
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34499
git-svn-id: http://core.svn.wordpress.org/trunk@34463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 14:54:25 +00:00
Drew Jaynes
dae68e1485
Docs: Clarify the file header for wp-admin/includes/class-wp-upgrader.php.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@34498
git-svn-id: http://core.svn.wordpress.org/trunk@34462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 14:44:25 +00:00
Drew Jaynes
8c0a805273
Docs: Mark the optional $upgrader
parameter as such and add a description in the DocBlock for Language_Pack_Upgrader::async_upgrade()
.
...
See [32655].
See #30989 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34497
git-svn-id: http://core.svn.wordpress.org/trunk@34461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 14:35:25 +00:00
Scott Taylor
9405b8b10e
Canonical/Rewrite: After [34492], fix rel="canonical"
URLs for paginated posts.
...
Props wonderboymusic, joostdevalk.
See #11694 .
Built from https://develop.svn.wordpress.org/trunk@34496
git-svn-id: http://core.svn.wordpress.org/trunk@34460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 14:30:24 +00:00
Drew Jaynes
0fc9bed46e
Docs: Add a summary, version, and parameter and return descriptions to the DocBlock for WP_Filesystem_ftpsockets::get_contents()
.
...
Also reverses the return types as `string` is expected, `false` is the outlier.
See [30978].
See #30989 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34495
git-svn-id: http://core.svn.wordpress.org/trunk@34459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 14:22:24 +00:00
Scott Taylor
b45178379b
After [34492], no need to import the global instance when we are, in fact, currently, that instance.
...
See #11694 .
Built from https://develop.svn.wordpress.org/trunk@34494
git-svn-id: http://core.svn.wordpress.org/trunk@34458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 14:20:24 +00:00
Drew Jaynes
fbb6ef1922
Docs: Add a summary, version, and parameter and return descriptions to the DocBlock for WP_Filesystem_FTPext::get_contents()
.
...
Also reverses the return types as `string` is expected, `false` is the outlier.
See [30978].
See #30989 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34493
git-svn-id: http://core.svn.wordpress.org/trunk@34457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 14:11:26 +00:00
Scott Taylor
175d476b0e
Canonical/Rewrite: sanity check posts that are paged with <!--nextpage-->
. Page numbers past the max number of pages are returning the last page of content and causing infinite duplicate content.
...
Awesome rewrite bug: the `page` query var was being set to `'/4'` in `$wp`. When cast to `int`, it returns `0` (Bless you, PHP). `WP_Query` calls `trim( $page, '/' )` when setting its own query var. The few places that were checking `page` before posts were queried now have sanity checks, so that these changes work without flushing rewrites.
Adds/updates unit tests.
Props wonderboymusic, dd32.
See #11694 .
Built from https://develop.svn.wordpress.org/trunk@34492
git-svn-id: http://core.svn.wordpress.org/trunk@34456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 14:04:24 +00:00
Drew Jaynes
f1532ccde8
Docs: Add a summary, version, and @access
tag to the property DocBlock for Custom_Image_Header->updated
.
...
See [14907] for where the property was initially introduced.
See [30187] for where the property was actually declared.
Props brentvr.
See #30224 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34491
git-svn-id: http://core.svn.wordpress.org/trunk@34455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 13:39:25 +00:00
Drew Jaynes
caf3df03bc
Docs: Add a summary, version, and @access
tag to the property DocBlock for Custom_Background->updated
.
...
See [13765] for where the property was initially introduced.
See [30186] for where the property was actually declared.
Props brentvr.
See #30224 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34490
git-svn-id: http://core.svn.wordpress.org/trunk@34454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 13:34:24 +00:00
Drew Jaynes
de5e9d01a9
Docs: Add a summary, version, and @access
tag to the property DocBlock for WP_Locale->number_format
.
...
See [5308] for where the property was initially introduced.
See [31083] for where the property was actually declared.
Props brentvr.
See #30224 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34489
git-svn-id: http://core.svn.wordpress.org/trunk@34453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 13:26:24 +00:00
Dominik Schilling
97146ee2cb
Customizer: Update tests for [34487].
...
Fixes #33634 .
Built from https://develop.svn.wordpress.org/trunk@34488
git-svn-id: http://core.svn.wordpress.org/trunk@34452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 11:32:26 +00:00
Dominik Schilling
833e92b7da
Customizer: Use the plural label for available menu item types.
...
Fixes #33634 .
Built from https://develop.svn.wordpress.org/trunk@34487
git-svn-id: http://core.svn.wordpress.org/trunk@34451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 09:16:25 +00:00
Dominik Schilling
340b7a5289
Edit Post: Add missing periods.
...
See #31858 .
Built from https://develop.svn.wordpress.org/trunk@34486
git-svn-id: http://core.svn.wordpress.org/trunk@34450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 08:54:26 +00:00
Drew Jaynes
e5e03e787c
Docs: Link up a hook reference with an inline @see
tag in the return description for get_locale()
.
...
Missed in [34484].
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34485
git-svn-id: http://core.svn.wordpress.org/trunk@34449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 05:51:23 +00:00
Drew Jaynes
81e135955a
Docs: Fix the summary for get_locale()
.
...
Also update the description to properly link up hook references with inline `@see` tags.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34484
git-svn-id: http://core.svn.wordpress.org/trunk@34448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 05:50:24 +00:00
Drew Jaynes
1c761505b6
Docs: Clarify the file header summary for wp-includes/l10n.php and add the version it was introduced.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34483
git-svn-id: http://core.svn.wordpress.org/trunk@34447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 05:47:24 +00:00
Drew Jaynes
f64c19aa95
Docs: Split the DocBlock summary for __()
into a summary and description.
...
Also, notate the default value for the optional `$domain` parameter.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34482
git-svn-id: http://core.svn.wordpress.org/trunk@34446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 05:43:26 +00:00
Drew Jaynes
90f61eff52
Docs: Add a summary to the hook doc for the nav_menu_item_args
filter, introduced in [34471].
...
Fixes #29417 .
Built from https://develop.svn.wordpress.org/trunk@34481
git-svn-id: http://core.svn.wordpress.org/trunk@34445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 05:09:24 +00:00
Scott Taylor
4e9c1692b0
Post Thumbnails: In get_the_post_thumbnail_url()
, return false
instead of empty string when no URL is available.
...
Fixes #33070 .
Built from https://develop.svn.wordpress.org/trunk@34480
git-svn-id: http://core.svn.wordpress.org/trunk@34444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 04:38:25 +00:00
Scott Taylor
03d630d705
Unit Tests: after [34477], make Tests_Link_GetPostCommentsFeedLink
more respectable.
...
See #33693 .
Built from https://develop.svn.wordpress.org/trunk@34479
git-svn-id: http://core.svn.wordpress.org/trunk@34443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 04:32:25 +00:00
Gary Pendergast
1b91141437
WPDB: When attempting to fall back to ext/mysql
in db_connect()
, return the result of the fall back.
...
While it doesn't affect Core, we should also be passing the `$allow_bail` parameter, for anything that uses it differently.
Props markoheijnen, johnbillion.
Fixes #33105 .
Built from https://develop.svn.wordpress.org/trunk@34478
git-svn-id: http://core.svn.wordpress.org/trunk@34442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 04:30:25 +00:00
Scott Taylor
43b7192e8e
Feeds/Links: after [34336], use a different meat cleaver to fix Rewrite spillage across test cases.
...
Fixes #33693 .
Built from https://develop.svn.wordpress.org/trunk@34477
git-svn-id: http://core.svn.wordpress.org/trunk@34441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 04:20:25 +00:00
Scott Taylor
7a154ca666
WP: after [34443], calling get_queried_object()
messes up unit tests. We can just clone the $post
prop and call it a day.
...
Fixes #20226 .
Built from https://develop.svn.wordpress.org/trunk@34476
git-svn-id: http://core.svn.wordpress.org/trunk@34440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 03:54:24 +00:00
Scott Taylor
b6e70baa04
Plugins: on the plugins admin screen, the "has been deleted" string needs a plural.
...
Props jmayhak.
Fixes #33239 .
Built from https://develop.svn.wordpress.org/trunk@34475
git-svn-id: http://core.svn.wordpress.org/trunk@34439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 03:42:25 +00:00
Scott Taylor
ffb8ae1a63
Date/Time: Add unit tests for the_date()
.
...
Props jubstuff.
Fixes #33750 .
Built from https://develop.svn.wordpress.org/trunk@34474
git-svn-id: http://core.svn.wordpress.org/trunk@34438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 03:34:24 +00:00
Scott Taylor
d6155dd405
Edit Post: After [33666], separate the translation string for pages, avoiding HTML usage.
...
Props ramiy.
Fixes #31858 .
Built from https://develop.svn.wordpress.org/trunk@34473
git-svn-id: http://core.svn.wordpress.org/trunk@34437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 03:28:24 +00:00
Scott Taylor
8cc5a142e4
Media Modal: move the translation strings for insertIntoPost
and uploadedToThisPost
to the get_post_type_labels()
array as insert_into_item
and uploaded_to_this_item
.
...
Props flixos90.
Fixes #33616 .
Built from https://develop.svn.wordpress.org/trunk@34472
git-svn-id: http://core.svn.wordpress.org/trunk@34436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 03:22:24 +00:00
Scott Taylor
0c1f92e301
Nav Menus: Add a 'nav_menu_item_args' filter to Walker_Nav_Menu::start_el()
.
...
Props bjornjohansen.
Fixes #29417 .
Built from https://develop.svn.wordpress.org/trunk@34471
git-svn-id: http://core.svn.wordpress.org/trunk@34435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 03:17:24 +00:00