Sergey Biryukov
00c60ccd33
CSS Coding Standards: Update unitless values for line-height
in wp-admin/css/widgets.css
with more precise calculations.
...
Props ianbelanger.
Fixes #46531 .
Built from https://develop.svn.wordpress.org/trunk@45415
git-svn-id: http://core.svn.wordpress.org/trunk@45226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 14:44:52 +00:00
Sergey Biryukov
962da3db60
CSS Coding Standards: Update unitless values for line-height
in wp-admin/css/nav-menus.css
with more precise calculations.
...
Props ianbelanger.
Fixes #46516 .
Built from https://develop.svn.wordpress.org/trunk@45414
git-svn-id: http://core.svn.wordpress.org/trunk@45225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 14:42:52 +00:00
Sergey Biryukov
693e90ac81
Editor: In edit-form-blocks.php
, check the result of wp_set_post_lock()
, which may return false
and cause a warning when passed to implode()
.
...
Props kakshak, aduth.
Fixes #47013 .
Built from https://develop.svn.wordpress.org/trunk@45413
git-svn-id: http://core.svn.wordpress.org/trunk@45224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 14:35:52 +00:00
Sergey Biryukov
35a2322d32
General: Update support forum links.
...
There are a lot of places in Core that link to https://wordpress.org/support/ for the support forums, but that's now the URL for HelpHub. The new forums link is https://wordpress.org/support/forums/ .
This is a follow-up to [45140], which changed the links in help tabs.
Props dilipbheda.
Fixes #47239 . See #46790 .
Built from https://develop.svn.wordpress.org/trunk@45412
git-svn-id: http://core.svn.wordpress.org/trunk@45223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 14:24:50 +00:00
Andrea Fercia
add6a8e13f
Accessibility: Fix the headings hierarchy in the legacy Custom Background and Custom Header pages.
...
Fixes #47386 .
Built from https://develop.svn.wordpress.org/trunk@45411
git-svn-id: http://core.svn.wordpress.org/trunk@45222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 13:32:53 +00:00
John Blackbourn
15dc9ab6ab
Build/Test Tools: Ignore generated RTL CSS files from Git version control.
...
Fixes #47078
Built from https://develop.svn.wordpress.org/trunk@45410
git-svn-id: http://core.svn.wordpress.org/trunk@45221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 12:30:52 +00:00
Sergey Biryukov
2a02b8fe5d
Docs: Remove full stop from ticket number.
...
See #46402 .
Built from https://develop.svn.wordpress.org/trunk@45409
git-svn-id: http://core.svn.wordpress.org/trunk@45220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 12:09:52 +00:00
Sergey Biryukov
a81dfbdf0e
Formatting: Don't run wp_targeted_link_rel()
on entirely serialized content.
...
Props birgire, elliotcondon.
Fixes #46402 .
Built from https://develop.svn.wordpress.org/trunk@45408
git-svn-id: http://core.svn.wordpress.org/trunk@45219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 12:05:52 +00:00
John Blackbourn
ca028cfc4c
Users: Allow Super Admins to remove themselves from a site on a Multisite network.
...
Props Mista-Flo, birgire
Fixes #41439
Built from https://develop.svn.wordpress.org/trunk@45407
git-svn-id: http://core.svn.wordpress.org/trunk@45218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 00:13:53 +00:00
Sergey Biryukov
eecfa3b4ed
Docs: Correct description for $seplocation
parameter of wp_title()
.
...
Props mukesh27, vladlu.
Fixes #47370 .
Built from https://develop.svn.wordpress.org/trunk@45406
git-svn-id: http://core.svn.wordpress.org/trunk@45217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 22:59:52 +00:00
John Blackbourn
61ed726067
Mail: Use the standardised spelling of email
in the password reset error message.
...
Fixes #39110
Built from https://develop.svn.wordpress.org/trunk@45405
git-svn-id: http://core.svn.wordpress.org/trunk@45216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 22:53:54 +00:00
John Blackbourn
b3e297925c
Mail: Improve the user experience when the password reset email cannot be sent.
...
This introduces a link to the support page for resetting your password, and improves the error by bringing it into the login page instead of a `wp_die()`.
Props neelpatel7295, estelaris, desrosj
Built from https://develop.svn.wordpress.org/trunk@45404
git-svn-id: http://core.svn.wordpress.org/trunk@45215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 22:14:52 +00:00
Sergey Biryukov
b77cf42c0b
Accessibility: Make sure layout tables across the admin are correctly linearized.
...
Adds `role="presentation"` to the `<table>` elements used for layout purposes.
Ideally, HTML tables should be used for tabular data. When tables are used for layout purposes, it's important to remove any native semantics so that assistive technologies can correctly announce the table content in a linearized fashion.
Props greatislander, afercia.
Fixes #46899 .
Built from https://develop.svn.wordpress.org/trunk@45403
git-svn-id: http://core.svn.wordpress.org/trunk@45214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 21:56:54 +00:00
John Blackbourn
01917b9f74
I18N: Add a language icon next to language selectors.
...
This change means that users who can't read the site's current language can more easily identify controls that allow them to change either the site language or their own admin area language.
Props janak007, atlasmahesh, afercia, birgire, JoshuaWold
Fixes #43144
Built from https://develop.svn.wordpress.org/trunk@45402
git-svn-id: http://core.svn.wordpress.org/trunk@45213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 20:43:52 +00:00
John Blackbourn
53794e9719
Administration: Replace references to "articles" with "posts" for greater consistency of terminology.
...
Props angelagibson
Fixes #38517
Built from https://develop.svn.wordpress.org/trunk@45401
git-svn-id: http://core.svn.wordpress.org/trunk@45212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 19:18:51 +00:00
Sergey Biryukov
27720e15a7
Bootstrap/Load: In wp_get_server_protocol()
, check if $_SERVER['SERVER_PROTOCOL']
is defined, to avoid a notice in CLI context.
...
Props thakkarhardik, malthert.
Fixes #47005 .
Built from https://develop.svn.wordpress.org/trunk@45400
git-svn-id: http://core.svn.wordpress.org/trunk@45211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:47:51 +00:00
Sergey Biryukov
729d4a4942
I18N: Remove PHP function name from translatable string in WP_Debug_Data
.
...
Props ramiy.
Fixes #47254 .
Built from https://develop.svn.wordpress.org/trunk@45399
git-svn-id: http://core.svn.wordpress.org/trunk@45210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:41:52 +00:00
Sergey Biryukov
e3bb526606
Login and Registration: Pass the action to site_url()
in wp_logout_url()
and wp_lostpassword_url()
:
...
* Make `site_url` filter in `wp_logout_url()` aware of the `logout` action.
* Make `network_site_url` filter in `wp_lostpassword_url()` aware of the `lostpassword` action.
Props jfarthing84.
Fixes #43407 .
Built from https://develop.svn.wordpress.org/trunk@45398
git-svn-id: http://core.svn.wordpress.org/trunk@45209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:33:52 +00:00
Sergey Biryukov
6dc1ced79c
Twenty Nineteen: Add missing icon to Edit link for pages.
...
Props mukesh27, ianbelanger, ounziw.
Fixes #47332 .
Built from https://develop.svn.wordpress.org/trunk@45397
git-svn-id: http://core.svn.wordpress.org/trunk@45208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:22:51 +00:00
Sergey Biryukov
e4ce9663a3
I18N: Merge two similar "you may need to press the Esc key twice" strings.
...
Props ramiy, tmatsuur, hareesh-pillai.
Fixes #47036 .
Built from https://develop.svn.wordpress.org/trunk@45396
git-svn-id: http://core.svn.wordpress.org/trunk@45207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:18:53 +00:00
Sergey Biryukov
44512b0753
I18N: Merge two similar "An unexpected error occurred" strings.
...
Props ramiy.
Fixes #47035 .
Built from https://develop.svn.wordpress.org/trunk@45395
git-svn-id: http://core.svn.wordpress.org/trunk@45206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:14:52 +00:00
Sergey Biryukov
a36f5d2295
Docs: Fix typos in DocBlocks and comments in wp-admin/includes/file.php
.
...
Props mukesh27.
Fixes #47026 .
Built from https://develop.svn.wordpress.org/trunk@45394
git-svn-id: http://core.svn.wordpress.org/trunk@45205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:08:51 +00:00
Sergey Biryukov
68fd25ff1a
Docs: Remove unused @global
reference in do_blocks()
DocBlock.
...
Props avinapatel.
Fixes #47055 .
Built from https://develop.svn.wordpress.org/trunk@45393
git-svn-id: http://core.svn.wordpress.org/trunk@45204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:05:52 +00:00
Sergey Biryukov
7cadbb50bf
Docs: Fix incorrect @see
notation in wp_localize_script()
DocBlock.
...
Props coffee2code, shamim51.
Fixes #47104 .
Built from https://develop.svn.wordpress.org/trunk@45392
git-svn-id: http://core.svn.wordpress.org/trunk@45203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:02:51 +00:00
Sergey Biryukov
726e77d97e
Networks and Sites: Readjust tabs in wp-admin/includes/network.php
for (more or less) consistent alignment.
...
See #47062 .
Built from https://develop.svn.wordpress.org/trunk@45391
git-svn-id: http://core.svn.wordpress.org/trunk@45202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 23:35:52 +00:00
Sergey Biryukov
139225ad7a
Networks and Sites: Remove extra whitespace in .htaccess
rules on Network Setup page.
...
Props riddhiehta02 for initial patch, sebastienserre, masterforwordpress.
Fixes #47062 .
Built from https://develop.svn.wordpress.org/trunk@45390
git-svn-id: http://core.svn.wordpress.org/trunk@45201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 23:28:53 +00:00
John Blackbourn
239a159ad2
Administration: Don't apply italic formatting to code blocks in setting descriptions.
...
Props chetan200891
Fixes #42651
Built from https://develop.svn.wordpress.org/trunk@45389
git-svn-id: http://core.svn.wordpress.org/trunk@45200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 23:14:53 +00:00
John Blackbourn
75a8adb0eb
Docs: Remove incorrect information about usage of the "from" filters in wp_mail()
, tidy up formatting.
...
See #47110
Built from https://develop.svn.wordpress.org/trunk@45388
git-svn-id: http://core.svn.wordpress.org/trunk@45199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 22:42:52 +00:00
John Blackbourn
f2ef36bb2d
I18N: Use a complete translatable string for the "Delete My Site" email subject.
...
Props thrijith
Fixes #46855
Built from https://develop.svn.wordpress.org/trunk@45387
git-svn-id: http://core.svn.wordpress.org/trunk@45198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 22:15:54 +00:00
John Blackbourn
9e891be893
Embeds: Remove the "Supports HTTPS" column from the whitelisted oEmbed provider list now that all supported providers use HTTPS.
...
See #28507
Built from https://develop.svn.wordpress.org/trunk@45386
git-svn-id: http://core.svn.wordpress.org/trunk@45197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 21:23:53 +00:00
John Blackbourn
5fe92586c0
Embeds: Use HTTPS for the Hulu oEmbed endpoint, as it redirects to HTTPS now.
...
Fixes #28507
Built from https://develop.svn.wordpress.org/trunk@45385
git-svn-id: http://core.svn.wordpress.org/trunk@45196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 21:20:52 +00:00
Sergey Biryukov
e32389fc04
I18N: Capitalize "Privacy Policy Page" heading to merge two similar strings.
...
Props ramiy, garrett-eclipse.
Fixes #47250 .
Built from https://develop.svn.wordpress.org/trunk@45384
git-svn-id: http://core.svn.wordpress.org/trunk@45195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 21:11:52 +00:00
Sergey Biryukov
aaa3e181a0
Twenty Nineteen: Correct function name in a function_exists()
check for twentynineteen_get_user_avatar_markup()
.
...
Props mukesh27, diego-la-monica.
Fixes #46410 .
Built from https://develop.svn.wordpress.org/trunk@45383
git-svn-id: http://core.svn.wordpress.org/trunk@45194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 01:31:54 +00:00
Sergey Biryukov
a3c363f8c2
I18N: Make punctuation in some wp-admin
strings more consistent.
...
Props pedromendonca.
Fixes #47358 .
Built from https://develop.svn.wordpress.org/trunk@45382
git-svn-id: http://core.svn.wordpress.org/trunk@45193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 01:12:53 +00:00
Sergey Biryukov
b29ef22665
Media: Correct closing </label>
tags in #tmpl-audio-details
and #tmpl-video-details
after [42444].
...
Props TravisSeitler.
Fixes #47355 .
Built from https://develop.svn.wordpress.org/trunk@45381
git-svn-id: http://core.svn.wordpress.org/trunk@45192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 00:49:53 +00:00
Sergey Biryukov
0cc6547e43
Docs: Adjust get_post_modified_time
filter DocBlock for consistency with get_post_time
.
...
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@45380
git-svn-id: http://core.svn.wordpress.org/trunk@45191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 00:41:51 +00:00
Sergey Biryukov
3c16bdc538
Date/Time: Return early from the_weekday()
and the_weekday_date()
if we're not in the loop.
...
Restore `$previousweekday` global usage in `the_weekday_date()`, so it could still be used simultaneously with `the_date()`.
Partially reverts [45378].
See #47354 .
Built from https://develop.svn.wordpress.org/trunk@45379
git-svn-id: http://core.svn.wordpress.org/trunk@45190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 00:38:52 +00:00
Sergey Biryukov
ed08643734
Date/Time: Bring some consistency to the_date()
and the_weekday_date()
:
...
* Make `the_date()` always apply the the filter and return a value.
* Use `is_new_day()` in `the_weekday_date()`.
* Add a unit test for `the_weekday_date()`.
Fixes #47354 .
Built from https://develop.svn.wordpress.org/trunk@45378
git-svn-id: http://core.svn.wordpress.org/trunk@45189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-22 21:58:50 +00:00
Sergey Biryukov
0b66be9cd7
Docs: Improve documentation for the_date()
and the_weekday_date()
.
...
Correct type for `$currentday` and `$previousday` globals.
See #47354 , #47110 .
Built from https://develop.svn.wordpress.org/trunk@45377
git-svn-id: http://core.svn.wordpress.org/trunk@45188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-22 21:48:52 +00:00
Andrea Fercia
74c0d658b4
Accessibility: Improve the media views upload Dismiss Errors button.
...
- makes the Dismiss Errors button visible in the media views inline uploader
- avoids a focus loss when activating the Dismiss Errors button
See the related GitHub issue from the WPCampus accessibility audit https://github.com/WordPress/gutenberg/issues/15354
Fixes #47113 .
Built from https://develop.svn.wordpress.org/trunk@45376
git-svn-id: http://core.svn.wordpress.org/trunk@45187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-22 19:33:53 +00:00
Sergey Biryukov
9785381a8c
Date/Time: Use strict comparison in is_new_day()
, add a unit test.
...
Props pbearne.
Fixes #46627 .
Built from https://develop.svn.wordpress.org/trunk@45375
git-svn-id: http://core.svn.wordpress.org/trunk@45186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-22 17:53:52 +00:00
desrosj
03148046b5
General: Add missing unit tests for wp_array_slice_assoc()
.
...
Props pbearne, desrosj.
Fixes #46638 .
Built from https://develop.svn.wordpress.org/trunk@45371
git-svn-id: http://core.svn.wordpress.org/trunk@45182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-21 14:49:05 +00:00
desrosj
ee92fc277c
Feeds: Ensure a feed’s <lastBuildDate>
has the correct date.
...
The maximum modified time for a is currently being determined after an arbitrary date format is applied. Because the string sort in `max()` is being used to return the highest (most recent) modified value, the incorrect date is sometimes returned. This was introduced in [45247].
Props onlanka, Rarsr, mukesh27.
Fixes #47304 .
Built from https://develop.svn.wordpress.org/trunk@45367
git-svn-id: http://core.svn.wordpress.org/trunk@45178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-20 14:43:02 +00:00
Sergey Biryukov
3b926e0b47
Upgrade/Install: As a follow-up to [45357], when linking to Update PHP support page in error messages, check if wp_get_update_php_url()
and wp_get_update_php_annotation()
exist.
...
`wp-admin/includes/update-core.php` runs in the context of the previous WordPress version. Any calls to newly introduced functions there need to be checked via `function_exists()`.
Reviewed by desrosj, earnjam, SergeyBiryukov.
Props dd32, imath.
Fixes #47323 .
Built from https://develop.svn.wordpress.org/trunk@45365
git-svn-id: http://core.svn.wordpress.org/trunk@45176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-20 14:29:55 +00:00
Peter Wilson
460e256026
KSES: Add flex
and related long form properties to safe CSS.
...
Allow `flex`, `flex-grow`, `flex-shrink` and `flex-basis` to be used in inline CSS. As of WordPress 5.3 the block editor is expected to use `flex-basis` inline to set the width in the column block.
Props aduth.
Fixes #47281 .
See #37248 .
Built from https://develop.svn.wordpress.org/trunk@45363
git-svn-id: http://core.svn.wordpress.org/trunk@45174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-18 04:34:52 +00:00
Sergey Biryukov
f29eba6662
Taxonomy: In wp_insert_term()
, handle an error if writing to the term_taxonomy
table fails.
...
This complements the check for successful writing to the `terms` table, added in [7430].
Props mbabker.
Fixes #47313 .
Built from https://develop.svn.wordpress.org/trunk@45362
git-svn-id: http://core.svn.wordpress.org/trunk@45173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 22:28:51 +00:00
Sergey Biryukov
f72cb6dc83
Upgrade/Install: Improve error messages displayed when WordPress update fails due to an incompatible PHP version by linking to the Update PHP support page.
...
Additionally, fix a regression in [44451] where the error message in `wp-admin/upgrade.php` was prepared, but never displayed.
Props afragen, netweb, hareesh-pillai, SergeyBiryukov.
Fixes #46937 .
Built from https://develop.svn.wordpress.org/trunk@45357
git-svn-id: http://core.svn.wordpress.org/trunk@45168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 18:11:51 +00:00
Sergey Biryukov
ea8078f73c
Media: Fix deletion of files on Windows.
...
`wp_delete_file_from_directory()` should always normalize file paths before comparing.
Props tonybogdanov, SergeyBiryukov.
Fixes #47185 .
Built from https://develop.svn.wordpress.org/trunk@45352
git-svn-id: http://core.svn.wordpress.org/trunk@45163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 13:30:02 +00:00
Sergey Biryukov
550bc5cad2
Build/Test Tools: Use a non-zero exit code in wp_check_php_mysql_versions()
when minimum PHP or MySQL requirements are not met.
...
This allows automated scripts and test suites to interpret the result correctly.
Props jrf, spacedmonkey.
Fixes #47169 .
Built from https://develop.svn.wordpress.org/trunk@45350
git-svn-id: http://core.svn.wordpress.org/trunk@45161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 12:34:52 +00:00
Sergey Biryukov
c1f6c6877c
Formatting: Adjust wp_targeted_link_rel()
to ensure JSON format is preserved and correct quotes are used when adding the missing rel
attribute.
...
Props birgire, TobiasBg, fierevere, audrasjb, SergeyBiryukov.
Fixes #46316 , #47244 .
Built from https://develop.svn.wordpress.org/trunk@45348
git-svn-id: http://core.svn.wordpress.org/trunk@45159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 12:10:02 +00:00