Scott Taylor
9382741cbe
Don't render Attachment Display Settings when display
is set to false
. Currently, the value for display
in the media.view.AttachmentsBrowser
instance in the media.view.MediaFrame.Select
frame is set to the value for displaySettings
.
...
These values do different things, so check for the existence of `display` on the state before arbitrarily setting it to the `displaySettings` value.
Real world: this hides display settings when you select an image while editing a Gallery.
Fixes #28653 .
Built from https://develop.svn.wordpress.org/trunk@29285
git-svn-id: http://core.svn.wordpress.org/trunk@29067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 20:58:16 +00:00
Scott Taylor
78518beb6b
When gallery settings are overridden, the JS-generated shortcodes need to check the new defaults before deleting attributes that it suspects are the same as the original default values.
...
`wp.media.collection` has a new method to do this: `setDefaults()`. Also flips the use of `_.extend` to allow this method to be overriden on instance creation.
See #28693 .
Built from https://develop.svn.wordpress.org/trunk@29284
git-svn-id: http://core.svn.wordpress.org/trunk@29066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 20:00:16 +00:00
Scott Taylor
58741e0909
The Underscore templates for Gallery settings should respect defaults when marking an <option>
as selected
.
...
See #28693 .
Built from https://develop.svn.wordpress.org/trunk@29283
git-svn-id: http://core.svn.wordpress.org/trunk@29065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 19:35:15 +00:00
Scott Taylor
5be43cfeb1
Media Grid: Manage focus when toggling between the grid and an edit attachment modal
...
Props adamsilverstein for the initial patch.
Fixes #28857 .
Built from https://develop.svn.wordpress.org/trunk@29282
git-svn-id: http://core.svn.wordpress.org/trunk@29064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 19:05:15 +00:00
Helen Hou-Sandí
6f44e96d70
Set default values for attachment meta and ID3 data when preparing for JS to avoid errors in rendering templates. props ericmann for the initial patch. fixes #29013 .
...
Built from https://develop.svn.wordpress.org/trunk@29281
git-svn-id: http://core.svn.wordpress.org/trunk@29063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 18:04:18 +00:00
Helen Hou-Sandí
448275cce4
Media Grid: Remove fields from showing in the grid itself.
...
All details are still available within the modal, and less-distinguishable non-image files still show the filename along with the file type icon.
Reverts [29079], [29078], [29077], and [28995]. see #24716 .
Built from https://develop.svn.wordpress.org/trunk@29280
git-svn-id: http://core.svn.wordpress.org/trunk@29062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 05:26:15 +00:00
Andrew Ozz
da0b98a8f0
Editor scrolling:
...
- Improve TinyMCE resizing when a floated block is at the end of the content.
- Improve setting the padding/margin under the toolbar on loading.
- Add custom event on TinyMCE resizing and use it to adjust the pinning (if needed).
Part props avryl, see #28328 .
Built from https://develop.svn.wordpress.org/trunk@29279
git-svn-id: http://core.svn.wordpress.org/trunk@29061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 01:33:15 +00:00
Helen Hou-Sandí
795c97d08b
Add support for attachment_fields_to_edit
in the attachment details modal. props ericlewis. fixes #28991 , see #24716 .
...
Built from https://develop.svn.wordpress.org/trunk@29278
git-svn-id: http://core.svn.wordpress.org/trunk@29060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-23 22:09:18 +00:00
Scott Taylor
cb2d88a092
After [29179], remove the last instance of this.isCompatibleSrc()
.
...
Props kovshenin.
See #28905 .
Built from https://develop.svn.wordpress.org/trunk@29277
git-svn-id: http://core.svn.wordpress.org/trunk@29059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-23 17:54:15 +00:00
Drew Jaynes
cc82d1bea4
Fix a typo in the PHPDoc for wp_register_sidebar_widget()
.
...
Props Jonnyauk.
Fixes #29007 .
Built from https://develop.svn.wordpress.org/trunk@29276
git-svn-id: http://core.svn.wordpress.org/trunk@29058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-23 17:21:18 +00:00
Drew Jaynes
e329b34f37
Fix a typo in the PHPDoc for get_stylesheet()
.
...
Props lgedeon.
Fixes #28985 .
Built from https://develop.svn.wordpress.org/trunk@29275
git-svn-id: http://core.svn.wordpress.org/trunk@29057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-23 05:11:16 +00:00
Helen Hou-Sandí
3cee43e6ce
Revert [29267], as it causes unit test breakage and appears unnecessary. see #28986 .
...
Built from https://develop.svn.wordpress.org/trunk@29274
git-svn-id: http://core.svn.wordpress.org/trunk@29056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-23 02:23:15 +00:00
Andrew Ozz
8e973f2c29
wpView: make sure the editor is focused before selecting/deselecting a view, or IE may throw an invalid range error, see #28595 .
...
Built from https://develop.svn.wordpress.org/trunk@29273
git-svn-id: http://core.svn.wordpress.org/trunk@29055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 21:53:16 +00:00
Andrew Ozz
c40feac4d9
wpView: consolidate pausePlayers() and unsetPlayers(), they are almost the same. Prevent errors when instead of a player ME.js shows only a "Download File" placeholder (in IE). See #28905 .
...
Built from https://develop.svn.wordpress.org/trunk@29272
git-svn-id: http://core.svn.wordpress.org/trunk@29054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 21:49:16 +00:00
Dominik Schilling
270a57075c
Media Grid: Add a date filter.
...
props ericlewis.
fixes #28895 .
Built from https://develop.svn.wordpress.org/trunk@29271
git-svn-id: http://core.svn.wordpress.org/trunk@29053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 20:47:15 +00:00
Dominik Schilling
de8961d631
Update the versions of several devDependencies in package.json
.
...
Run `npm update` in the project root to receive updates.
props mjbanks, jorbin, netweb.
see #27340 .
Built from https://develop.svn.wordpress.org/trunk@29270
git-svn-id: http://core.svn.wordpress.org/trunk@29052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 20:41:44 +00:00
Dominik Schilling
e78867dc88
Fix jshint errors introduced in [29259]. see #11325 .
...
Built from https://develop.svn.wordpress.org/trunk@29269
git-svn-id: http://core.svn.wordpress.org/trunk@29051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 20:03:15 +00:00
Dominik Schilling
f0bca68069
Media CSS: Fix typo in box-shadow
property for WebKit and update indentation to match the other ones.
...
Built from https://develop.svn.wordpress.org/trunk@29268
git-svn-id: http://core.svn.wordpress.org/trunk@29050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 19:58:18 +00:00
Scott Taylor
0702527010
Media Grid: general JS cleanup.
...
Props ericlewis.
See #28965 .
Built from https://develop.svn.wordpress.org/trunk@29266
git-svn-id: http://core.svn.wordpress.org/trunk@29049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 16:21:15 +00:00
Sergey Biryukov
fcb1687039
Media Grid: Fix missing padding in RTL in Attachment Details modal.
...
see #28980 .
Built from https://develop.svn.wordpress.org/trunk@29265
git-svn-id: http://core.svn.wordpress.org/trunk@29048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 03:18:15 +00:00
Sergey Biryukov
809baf442b
Media Grid: Swap arrow direction in RTL in Attachment Details modal.
...
props adamsilverstein.
fixes #28980 .
Built from https://develop.svn.wordpress.org/trunk@29264
git-svn-id: http://core.svn.wordpress.org/trunk@29047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 03:08:15 +00:00
Helen Hou-Sandí
89a8316946
Move the "view" link for attachment details to the sidebar and use more specific language. Removes an unnecessary JS handler. fixes #28977 .
...
Built from https://develop.svn.wordpress.org/trunk@29263
git-svn-id: http://core.svn.wordpress.org/trunk@29046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 02:20:15 +00:00
Sergey Biryukov
8923bb0c0e
Media Grid: Add a View button to Attachment Details modal.
...
props adamsilverstein.
fixes #28977 .
Built from https://develop.svn.wordpress.org/trunk@29262
git-svn-id: http://core.svn.wordpress.org/trunk@29045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 01:30:16 +00:00
Andrew Ozz
b9222c9e1e
TinyMCE: include 85e22b58e9
that and quote one more use of "float". This is "reserved as future keyword by older ECMAScript specifications" according to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar and can throw a syntax error. See #28576 .
...
Built from https://develop.svn.wordpress.org/trunk@29261
git-svn-id: http://core.svn.wordpress.org/trunk@29044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-21 23:05:15 +00:00
John Blackbourn
4d53ee7d45
Add a lang
attribute to each language listed on the language selector screen during installation. See #28858 , #28577 .
...
Built from https://develop.svn.wordpress.org/trunk@29260
git-svn-id: http://core.svn.wordpress.org/trunk@29043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-21 21:51:16 +00:00
Sergey Biryukov
51db702770
Remove requirement for a minimum image size in the image editor.
...
props ericlewis, solarissmoke.
fixes #11325 .
Built from https://develop.svn.wordpress.org/trunk@29259
git-svn-id: http://core.svn.wordpress.org/trunk@29042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-21 19:10:14 +00:00
Sergey Biryukov
f6206e5850
Don't always focus password field on interim login.
...
props johnbillion.
fixes #28961 .
Built from https://develop.svn.wordpress.org/trunk@29258
git-svn-id: http://core.svn.wordpress.org/trunk@29041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-21 16:21:14 +00:00
Sergey Biryukov
b3f6108438
Remove a redundant condition for comment feeds from WP_Query::get_posts().
...
props engelen.
fixes #28401 .
Built from https://develop.svn.wordpress.org/trunk@29257
git-svn-id: http://core.svn.wordpress.org/trunk@29040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-21 15:38:14 +00:00
Sergey Biryukov
a9c9827de4
Gruntfile: Change import rules to include RTL stylesheets when running CSSJanus.
...
see #28966 .
Built from https://develop.svn.wordpress.org/trunk@29256
git-svn-id: http://core.svn.wordpress.org/trunk@29039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-21 02:51:16 +00:00
Peter Westwood
1f147d24b1
XMLRPC: Switch the file deletion alias to be deleteFile to more closely make uploadFile.
...
Fixes #5310 props SergeyBiryukov.
Built from https://develop.svn.wordpress.org/trunk@29255
git-svn-id: http://core.svn.wordpress.org/trunk@29038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-20 14:02:15 +00:00
Peter Westwood
673916b39f
Post beta2 version bump to 4.0-beta2-29254
...
Built from https://develop.svn.wordpress.org/trunk@29254
git-svn-id: http://core.svn.wordpress.org/trunk@29037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-20 13:59:15 +00:00
Scott Taylor
0d387bf76e
WP_Dependencies->recurse_deps()
: tuck the recursion into elseif
so the foreach
doesn't break on the first item.
...
See [29252].
Built from https://develop.svn.wordpress.org/trunk@29253
git-svn-id: http://core.svn.wordpress.org/trunk@29036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-20 00:34:15 +00:00
Scott Taylor
f93abf2bea
wp_script_is( ..., 'enqueued' )
needs to check dependencies recursively - a single item's dependencies may only be a subset of the full dependency tree. Adds a new method on WP_Dependencies
called ->recurse_deps()
.
...
Adds unit test.
Props wonderboymusic, SergeyBiryukov, mikejolley.
Fixes #28404 .
Built from https://develop.svn.wordpress.org/trunk@29252
git-svn-id: http://core.svn.wordpress.org/trunk@29035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-20 00:29:16 +00:00
Scott Taylor
baf7f5604d
After [29200], switch back to using static
vars instead of adding 2 global
s, as per Sergey.
...
Fixes #28697 .
Built from https://develop.svn.wordpress.org/trunk@29250
git-svn-id: http://core.svn.wordpress.org/trunk@29034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 23:14:15 +00:00
Scott Taylor
021b07a161
Call untrailingslashit()
when adding a theme directory in register_theme_directory()
. This prevents double-slashing in generated URLs. Don't add a directory if it is already present.
...
Adds unit tests.
Props obenland, wonderboymusic.
Fixes #28662 .
Built from https://develop.svn.wordpress.org/trunk@29249
git-svn-id: http://core.svn.wordpress.org/trunk@29033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 23:07:15 +00:00
Scott Taylor
1cfbe0a8ce
In get_adjacent_post()
, make $excluded_terms
work as expected.
...
Adds unit tests.
Props jessepollak, kovshenin.
Fixes #22112 .
Built from https://develop.svn.wordpress.org/trunk@29248
git-svn-id: http://core.svn.wordpress.org/trunk@29032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 22:27:14 +00:00
Andrew Ozz
9175194785
Fix admin menu open/close issues on some mobile devices, props adamsilverstein, fixes #27980 .
...
Built from https://develop.svn.wordpress.org/trunk@29247
git-svn-id: http://core.svn.wordpress.org/trunk@29031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 18:55:16 +00:00
Andrew Ozz
16696e9ea8
TinyMCE wpView: better removal of views, replace a selected view when pasting. Props avryl, fixes #28913 .
...
Built from https://develop.svn.wordpress.org/trunk@29246
git-svn-id: http://core.svn.wordpress.org/trunk@29030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 07:30:15 +00:00
Andrew Ozz
47b735b0e4
TinyMCE wpVIew: use CSS3 currentcolor
for the fake carets, see #28595 .
...
Built from https://develop.svn.wordpress.org/trunk@29245
git-svn-id: http://core.svn.wordpress.org/trunk@29029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 06:29:14 +00:00
Sergey Biryukov
6628d7dd33
Remove redundant title attributes from get_calendar().
...
props joedolson.
fixes #26561 .
Built from https://develop.svn.wordpress.org/trunk@29244
git-svn-id: http://core.svn.wordpress.org/trunk@29028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 04:41:15 +00:00
Sergey Biryukov
81f912dd7a
Customizer: Remove "Add a Widget" button from tab order when reordering widgets.
...
fixes #28890 .
Built from https://develop.svn.wordpress.org/trunk@29243
git-svn-id: http://core.svn.wordpress.org/trunk@29027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 03:32:17 +00:00
Sergey Biryukov
37e51e558c
Customizer: When widget reorder button is actioned, transfer focus to the first Move control within the section.
...
fixes #28891 .
Built from https://develop.svn.wordpress.org/trunk@29242
git-svn-id: http://core.svn.wordpress.org/trunk@29026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 03:24:15 +00:00
Sergey Biryukov
fdd0756e5a
Add a class for get_comment_author_link() in Recent Comments widget.
...
props DrewAPicture, dannydehaan, 5um17.
fixes #27944 .
Built from https://develop.svn.wordpress.org/trunk@29241
git-svn-id: http://core.svn.wordpress.org/trunk@29025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 02:44:14 +00:00
Sergey Biryukov
440be3565d
Customizer: Add screen reader text to announce that panels and sections are expandable.
...
props joedolson, ocean90.
fixes #27591 .
Built from https://develop.svn.wordpress.org/trunk@29240
git-svn-id: http://core.svn.wordpress.org/trunk@29024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 02:37:16 +00:00
Sergey Biryukov
53c599563c
Add screen reader text to announce that menu item accordion sections are expandable. Remove redundant title attribute.
...
props joedolson.
fixes #28866 .
Built from https://develop.svn.wordpress.org/trunk@29239
git-svn-id: http://core.svn.wordpress.org/trunk@29023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 02:21:14 +00:00
Sergey Biryukov
9a02dabf34
Customizer: Add widget title to Move/Up/Down controls to provide context for screen readers when reordering or moving widgets.
...
fixes #28889 .
Built from https://develop.svn.wordpress.org/trunk@29238
git-svn-id: http://core.svn.wordpress.org/trunk@29022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 01:58:15 +00:00
Sergey Biryukov
53d2839324
Customizer: Avoid losing focus when adding widgets via keyboard.
...
props sathishn.
fixes #28835 .
Built from https://develop.svn.wordpress.org/trunk@29237
git-svn-id: http://core.svn.wordpress.org/trunk@29021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 01:19:14 +00:00
Andrew Ozz
1d637d85e0
TinyMCE wpView:
...
- Typing something replaces a selected view.
- Pressing backspace deletes the selection.
- Pressing enter also deletes the selection.
- Pasting something replaces the selection.
- Also merge the different 'keydown' handlers.
Props avryl, fixes #28913 .
Built from https://develop.svn.wordpress.org/trunk@29236
git-svn-id: http://core.svn.wordpress.org/trunk@29020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 00:34:15 +00:00
Sergey Biryukov
13d0a0a367
Revert [28963].
...
see #28006 .
Built from https://develop.svn.wordpress.org/trunk@29235
git-svn-id: http://core.svn.wordpress.org/trunk@29019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 00:26:16 +00:00
Sergey Biryukov
ef14aed9a2
Use an existing string.
...
see #19205 .
Built from https://develop.svn.wordpress.org/trunk@29234
git-svn-id: http://core.svn.wordpress.org/trunk@29018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-18 23:56:14 +00:00