Andrea Fercia
1d739a0925
Accessibility: Make some Widgets buttons real buttons.
...
Links used as UI controls that behave like buttons, should be buttons.
- changes the widgets "toggle", "Delete", and "Close" links to buttons
- uses `aria-expanded` to announce the state of the toggle buttons
- increases a bit the clickable area of the toggle
- ensures the "circular focus" doesn't get cut-off in some browsers by centering the toggle arrows
- uses a `<span>` element with an `aria-hidden` attribute to hide CSS generated font icons from assistive technologies
- standardizes on `.toggle-indicator:before` rather than `:after`
- changes two `#f00` reds in `#dc3232`, see #35622
Fixes #31476 .
Built from https://develop.svn.wordpress.org/trunk@40480
git-svn-id: http://core.svn.wordpress.org/trunk@40356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-19 21:14:44 +00:00
Andrew Ozz
d0e4448257
Editor: Provide API for the editor to be dynamically instantiated via JS. First run.
...
See: #35760
Built from https://develop.svn.wordpress.org/trunk@40476
git-svn-id: http://core.svn.wordpress.org/trunk@40352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-19 02:38:44 +00:00
Weston Ruter
cb6086ae9b
Customize: Use fixed-width illustrative placeholder for hex field in color picker to prevent truncation.
...
Props stormrockwell, sagarprajapati, Presskopp, afercia, tejas5989, westonruter, mayurk for testing.
Fixes #39096 .
Built from https://develop.svn.wordpress.org/trunk@40471
git-svn-id: http://core.svn.wordpress.org/trunk@40347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-18 00:31:43 +00:00
John Blackbourn
1e9446310a
Networks and Sites: Correct a capability check when accessing the Sites -> Add New screen.
...
Props flixos90
See #39156
Built from https://develop.svn.wordpress.org/trunk@40433
git-svn-id: http://core.svn.wordpress.org/trunk@40331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-15 17:30:48 +00:00
Sergey Biryukov
9fb2e79b57
Posts, Post Types: In wp_check_post_lock()
, check if the user with lock exists and return false otherwise.
...
Props arshidkv12, 1naveengiri.
Fixes #39888 .
Built from https://develop.svn.wordpress.org/trunk@40424
git-svn-id: http://core.svn.wordpress.org/trunk@40322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-13 23:09:43 +00:00
Sergey Biryukov
bef3ff1377
Posts, Post Types: Improve the docs for wp_check_post_lock()
and wp_set_post_lock()
.
...
See #39888 .
Built from https://develop.svn.wordpress.org/trunk@40423
git-svn-id: http://core.svn.wordpress.org/trunk@40321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-13 23:02:42 +00:00
Sergey Biryukov
902b91400d
Administration: Add "(link opens in a new window)" as a screen reader text for "Preview" link on Edit Post screen.
...
Props rianrietveld.
Fixes #40185 .
Built from https://develop.svn.wordpress.org/trunk@40422
git-svn-id: http://core.svn.wordpress.org/trunk@40320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-13 22:42:43 +00:00
Felix Arntz
45b64ba2ff
Multisite: Replace unnecessary is_super_admin()
check when setting up the initial network.
...
When using `is_super_admin()` in a non-multisite environment, the function is supposed to check for administrator capabilities. The process of querying all users and filtering them with that function can be optimized by only querying users with the administrator role instead.
Fixes #40406 . See #37616 .
Built from https://develop.svn.wordpress.org/trunk@40406
git-svn-id: http://core.svn.wordpress.org/trunk@40313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-10 22:00:43 +00:00
Weston Ruter
226e34effc
Customize: Verify availability of history.replaceState
(in IE9) before attempting to populate changeset_uuid
parameter.
...
Props westonruter, timmydcrawford for testing.
Amends [39686].
See #39227 .
Fixes #40405 .
Built from https://develop.svn.wordpress.org/trunk@40405
git-svn-id: http://core.svn.wordpress.org/trunk@40312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-10 21:15:41 +00:00
Felix Arntz
9354ea683f
Multisite: Introduce an upgrade_network
capability.
...
Prior to this change, a mix of `is_super_admin()` calls and `manage_network` capability checks was used to determine whether the current user could upgrade the network. With this changeset a dedicated capability is introduced that allows more granular handling.
Props dhanendran for the original patch.
Fixes #39205 . See #37616 .
Built from https://develop.svn.wordpress.org/trunk@40404
git-svn-id: http://core.svn.wordpress.org/trunk@40311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-10 21:11:43 +00:00
Joe McGill
4e1f22bf78
Fix broken audio/video functions when sanitizing ID3 data
...
This fixes a bug where running `wp_kses_post_deep()` on all the ID3
tag data corrupted blob data.
Fixes #40075 , #40085 .
Built from https://develop.svn.wordpress.org/trunk@40400
git-svn-id: http://core.svn.wordpress.org/trunk@40307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-10 01:28:47 +00:00
Weston Ruter
57b386ef1e
Customize: Fix behavior of clicking Delete Menu link and keep available nav menu items panel open when doing bulk deletion.
...
Props maguiar, adamsilverstein for testing.
Amends [39548].
Fixes #38953 .
Built from https://develop.svn.wordpress.org/trunk@40396
git-svn-id: http://core.svn.wordpress.org/trunk@40303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-07 20:22:43 +00:00
Weston Ruter
ad293eade7
Customize: Auto-expand a widget area section when expanding the Widgets panel if there is only one registered sidebar and it is active.
...
Introduces `WP_Customize_Panel::$auto_expand_sole_section` property which allows panels to opt-in to the behavior, which the Widgets panel is made to do by default.
Props delawski, westonruter, melchoyce.
Fixes #37471 .
Built from https://develop.svn.wordpress.org/trunk@40395
git-svn-id: http://core.svn.wordpress.org/trunk@40302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-07 19:27:40 +00:00
Pascal Birchler
8473f9ef66
Upgrade/Install: Introduce wp_disallow_file_mods()
helper function.
...
This is a wrapper around the checks for the `DISALLOW_FILE_MODS` constant to determine whether file modifications are disallowed.
Props MaximeCulea.
Fixes #38673 .
Built from https://develop.svn.wordpress.org/trunk@40394
git-svn-id: http://core.svn.wordpress.org/trunk@40301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-07 14:36:50 +00:00
John Blackbourn
0c2338fab2
Networks and Sites: Align the display of site statuses on the Sites listing screen with those of posts on the Posts listing screen.
...
Fixes #40290
Built from https://develop.svn.wordpress.org/trunk@40393
git-svn-id: http://core.svn.wordpress.org/trunk@40300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-07 13:51:43 +00:00
Felix Arntz
00e8704288
Multisite: Introduce a setup_network
capability for setting up multisite.
...
`setup_network` is a new meta capability that brings more granular control over the permissions to setup a multisite environment. In a non-multisite environment it falls back to `manage_options` while in a multisite it falls back to `manage_network_options`. The introduction of this capability furthermore allows replacing an `is_super_admin()` check.
Props ashokkumar24 for the original patch.
Fixes #39206 . See #37616 .
Built from https://develop.svn.wordpress.org/trunk@40390
git-svn-id: http://core.svn.wordpress.org/trunk@40297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-07 12:53:45 +00:00
Weston Ruter
162785c65f
Customize: Fix reversal of nav menu item's type
and object
properties for page stub added in customizer.
...
Amends [38906].
See #38164 .
Fixes #40277 .
Built from https://develop.svn.wordpress.org/trunk@40380
git-svn-id: http://core.svn.wordpress.org/trunk@40287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-05 23:29:42 +00:00
Pascal Birchler
e1a08e199a
Customize: User get_user_locale()
in customizer body class.
...
Otherwise CSS specific to the site's locale would be applied, even though the customizer is displayed in the user's locale.
See #29783 .
Fixes #40271 .
Built from https://develop.svn.wordpress.org/trunk@40368
git-svn-id: http://core.svn.wordpress.org/trunk@40275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-05 02:16:02 +00:00
Sergey Biryukov
f884d7973b
Posts, Post Types: Introduce post_date_column_status
filter for post status text in list tables' Date column.
...
Props pbearne.
Fixes #39545 .
Built from https://develop.svn.wordpress.org/trunk@40361
git-svn-id: http://core.svn.wordpress.org/trunk@40268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-01 14:07:44 +00:00
Andrea Fercia
822b8afb50
Accessibility: Improve the Media Library inline uploader accessibility.
...
For better accessibility, expandable panels should be placed immediately after
the control that expands them. This change moves the Media Library inline
uploader up, right after the "Add New" button, also introducing consistency with
the Plugin and Theme uploaders.
Adds a proper ARIA role on the button and an `aria-expanded` attribute to give
better feedback to assistive technologies users about the uploader's expanded state.
Improves the focus handling when closing the uploader, improves the focus style
and color contrast ratio of the uploader "close" button.
Props mantismamita, karmatosed, adamsilverstein, afercia.
Fixes #37188 .
Built from https://develop.svn.wordpress.org/trunk@40359
git-svn-id: http://core.svn.wordpress.org/trunk@40266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-31 17:38:43 +00:00
Andrea Fercia
9c360b1ab8
Administration: Fix minor misalignments caused by the button-link
CSS class.
...
After [40059] the CSS class `button-link` uses `text-align: left` by default.
This change now requires to limit as much as possible the use of `button-link`
to controls that should really look like links and to explicitly set
`text-align: center` in a few other cases.
Fixes #39983 .
Built from https://develop.svn.wordpress.org/trunk@40358
git-svn-id: http://core.svn.wordpress.org/trunk@40265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-31 16:51:45 +00:00
Andrea Fercia
35d8daf000
Quick/Bulk Edit: Fix the Tag suggestions position on the Bulk Edit textarea.
...
Always passes the complete `position` object to the jQuery autocomplete widget.
Also checks if an autocomplete instance already exists on the Bulk Edit textarea.
Props davidbenton.
Fixes #40242 .
Built from https://develop.svn.wordpress.org/trunk@40357
git-svn-id: http://core.svn.wordpress.org/trunk@40264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-31 16:35:45 +00:00
Sergey Biryukov
32e80d00c1
Press This: Reorder post format icon styles for consistency with get_post_format_strings()
.
...
See #40304 .
Built from https://develop.svn.wordpress.org/trunk@40356
git-svn-id: http://core.svn.wordpress.org/trunk@40263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-31 08:22:48 +00:00
Sergey Biryukov
3c86148c14
Press This: Add missing icons for Chat and Status post formats.
...
Props menakas, ejner69.
Fixes #40304 .
Built from https://develop.svn.wordpress.org/trunk@40355
git-svn-id: http://core.svn.wordpress.org/trunk@40262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-31 08:19:48 +00:00
Jeremy Felt
fa3dc867e7
Multisite: Add deleted_blog
action after site has been deleted.
...
Props pauldewouters, johnjamesjacoby.
Fixes #25584 .
Built from https://develop.svn.wordpress.org/trunk@40351
git-svn-id: http://core.svn.wordpress.org/trunk@40258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-30 04:31:44 +00:00
Sergey Biryukov
633ce094a1
Taxonomy: Fix typo in $aria_checked
variable name in Walker_Category_Checklist::start_el()
.
...
Props dhanendran.
Fixes #40295 .
Built from https://develop.svn.wordpress.org/trunk@40348
git-svn-id: http://core.svn.wordpress.org/trunk@40255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-29 11:22:47 +00:00
Weston Ruter
8256ecfecb
Customize: Improve i18n for strings in hidden widget area notices.
...
Amends [40312].
Props westonruter, ocean90, swissspidy, SergeyBiryukov, michelleweber for copywriting.
See #33567 , #33052 .
Fixes #39087 .
Built from https://develop.svn.wordpress.org/trunk@40330
git-svn-id: http://core.svn.wordpress.org/trunk@40237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-24 22:03:42 +00:00
John Blackbourn
37a638ae8a
Users: Don't push the current user's role to the top of the list in wp_dropdown_roles()
.
...
This brings consistency to the order in which roles are displayed in the `Roles` dropdown when editing users.
Props bor0
Fixes #40162
Built from https://develop.svn.wordpress.org/trunk@40323
git-svn-id: http://core.svn.wordpress.org/trunk@40230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-24 14:53:46 +00:00
John Blackbourn
3a4b5afa49
Login and Registration: Avoid a potentially incorrect value for the cookie hash on multisite installations that don't have a value in the siteurl
network option.
...
This reverts [38619].
See #34084
Fixes #39497
Built from https://develop.svn.wordpress.org/trunk@40320
git-svn-id: http://core.svn.wordpress.org/trunk@40227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-23 19:01:42 +00:00
Weston Ruter
e78707aad4
Customize: Prevent client-side validation from being cleared when no corresponding server-side validation is present.
...
See #36944 .
Fixes #39770 .
Built from https://develop.svn.wordpress.org/trunk@40319
git-svn-id: http://core.svn.wordpress.org/trunk@40226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-23 18:12:44 +00:00
Weston Ruter
84ed6f665f
Customize: Prevent links to customize.php
from being generated which have query vars from wp_removable_query_args()
present.
...
Props dlh.
See #23367 , #32692 .
Fixes #31850 .
Built from https://develop.svn.wordpress.org/trunk@40313
git-svn-id: http://core.svn.wordpress.org/trunk@40220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-22 23:04:42 +00:00
Weston Ruter
085b50b20d
Customize: Show notice in Widgets panel when there are additional widget areas not rendered in preview.
...
This extends the existing behavior which only showed a message only when there were no widget areas rendered in the preview. The number of non-rendered widget areas is indicated. Also removes needles deletion of `wp.customize.Widgets.data.l10n` property which hindered plugins.
See #33567 , #33052 .
Fixes #39087 .
Built from https://develop.svn.wordpress.org/trunk@40312
git-svn-id: http://core.svn.wordpress.org/trunk@40219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-22 19:03:45 +00:00
Sergey Biryukov
6a2b38ca6c
Docs: Add description for $mode
global in WP_MS_Sites_List_Table
and WP_MS_Users_List_Table
.
...
Fixes #40208 .
Built from https://develop.svn.wordpress.org/trunk@40310
git-svn-id: http://core.svn.wordpress.org/trunk@40217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-22 03:48:42 +00:00
Sergey Biryukov
0b7148ebbb
Docs: Add description for $mode
global in WP_Media_List_Table
and WP_Posts_List_Table
.
...
See #40208 .
Built from https://develop.svn.wordpress.org/trunk@40309
git-svn-id: http://core.svn.wordpress.org/trunk@40216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-22 03:47:07 +00:00
Sergey Biryukov
e51bc5fb6b
Docs: Add missing @global
entry for list table view mode in WP_Screen::render_view_mode()
.
...
Props priyankabehera155.
See #40208 .
Built from https://develop.svn.wordpress.org/trunk@40308
git-svn-id: http://core.svn.wordpress.org/trunk@40215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-22 03:46:28 +00:00
Sergey Biryukov
127a2c9998
Docs: Add missing @global
entry for list table view mode in wp_ajax_inline_save()
.
...
Props priyankabehera155.
See #40208 .
Built from https://develop.svn.wordpress.org/trunk@40307
git-svn-id: http://core.svn.wordpress.org/trunk@40214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-22 03:45:45 +00:00
Weston Ruter
e69b9b244c
Customize: Fix failure to collapse expanded sections and panels that become deactivated.
...
Improve jsdoc for `onChangeActive` function. Restores fix from [34557] which got dropped in [38648].
Props dlh, westonruter.
See #34391 , #33509 .
Fixes #39430 .
Built from https://develop.svn.wordpress.org/trunk@40304
git-svn-id: http://core.svn.wordpress.org/trunk@40211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-19 00:04:43 +00:00
Pascal Birchler
3e189479a7
List Tables: Hide 'Empty Trash' and 'Empty Spam' buttons when view is already empty.
...
Props ivantedja, Presskopp, printsachen1, Jaydeep Rami, mathieuhays, cazm.
Fixes #38341 .
Built from https://develop.svn.wordpress.org/trunk@40297
git-svn-id: http://core.svn.wordpress.org/trunk@40204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-17 16:54:42 +00:00
Pascal Birchler
62061bab56
Multisite: Ensure first page/post/comment content is not empty when setting up a new site.
...
This prevents creating page without any content when the options are populated with an empty string.
Props shadyvb.
Fixes #40036 .
Built from https://develop.svn.wordpress.org/trunk@40296
git-svn-id: http://core.svn.wordpress.org/trunk@40203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-17 15:49:42 +00:00
Sergey Biryukov
e9f73b06b6
Docs: Correct the description for wp.updates.deleteTheme
.
...
Props MattyRob.
Fixes #40110 .
Built from https://develop.svn.wordpress.org/trunk@40279
git-svn-id: http://core.svn.wordpress.org/trunk@40194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-11 16:13:46 +00:00
Andrea Fercia
6944c8f3a6
List Tables: After [38703], [38706], and [40118], adjust the jQuery selector to make the selection of a range of checkboxes work again.
...
Unprop afercia.
Fixes #40056 .
Built from https://develop.svn.wordpress.org/trunk@40268
git-svn-id: http://core.svn.wordpress.org/trunk@40187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-10 19:14:46 +00:00
John Blackbourn
263831a72d
Press This: Verify intent before fetching in-page resources using Press This.
...
Props vortfu
Built from https://develop.svn.wordpress.org/trunk@40195
git-svn-id: http://core.svn.wordpress.org/trunk@40134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-06 13:55:41 +00:00
John Blackbourn
9092fd01e1
Taxonomy: Correct the formatting of HTML entities when generating the screen reader text for tag removal.
...
Props adamsilverstein
Built from https://develop.svn.wordpress.org/trunk@40181
git-svn-id: http://core.svn.wordpress.org/trunk@40120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-06 13:14:41 +00:00
Aaron Campbell
4d80f8b3e1
Plugins: Add file check to plugin deletions.
...
Built from https://develop.svn.wordpress.org/trunk@40169
git-svn-id: http://core.svn.wordpress.org/trunk@40108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-06 12:55:41 +00:00
Jeremy Felt
28f838ca3e
Validate video and audio metadata.
...
Built from https://develop.svn.wordpress.org/trunk@40148
git-svn-id: http://core.svn.wordpress.org/trunk@40087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-06 08:01:43 +00:00
Boone Gorges
b6572af5d2
Taxonomy: Improve 'Parent' label when editing taxonomy terms.
...
Instead of the hardcoded 'Parent', use the `parent_item` label.
Props abrain, dlh.
Fixes #34545 .
Built from https://develop.svn.wordpress.org/trunk@40146
git-svn-id: http://core.svn.wordpress.org/trunk@40085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-03 02:54:42 +00:00
Joe McGill
d6bec79fe7
Media: Keep PDF previews from overwriting files.
...
Since support for PDF previews were added in [38949], it's possible
that the generated image file could overwrite an existing image file
with the same name. This uses `wp_unique_filename()` to avoid this
issue and adds a '-pdf' identifier on the end of filenames.
Props gitlost, derosj, mikeschroder, joemcgill.
Fixes #39875 . See #31050 .
Built from https://develop.svn.wordpress.org/trunk@40130
git-svn-id: http://core.svn.wordpress.org/trunk@40067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-02-27 15:39:47 +00:00
John Blackbourn
9e095f0791
Mail: Ensure entities in the site title are decoded when used in the body of the new user email.
...
Props ajoah
Fixes #39446
Built from https://develop.svn.wordpress.org/trunk@40127
git-svn-id: http://core.svn.wordpress.org/trunk@40064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-02-26 22:20:44 +00:00
Sergey Biryukov
d303e3d9ca
Plugins: After [38703], adjust the selector for checkbox selection to account for nested tables.
...
Props afercia, swissspidy, reldev.
Fixes #39739 .
Built from https://develop.svn.wordpress.org/trunk@40118
git-svn-id: http://core.svn.wordpress.org/trunk@40055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-02-24 23:10:44 +00:00
Adam Silverstein
bc1fc91ec8
REST API: JS client - QUnit tests for custom namespace route discovery.
...
Add QUnit tests for the parsing of custom namespace routes. Add a custom schema fixture based on the `wp-js-widgets` plugin. Test that the client can parse the widget namespace in the schema and correctly construct the expected group of models and collections. Also includes a small unrelated QUnit fix to ensure nav-menu test passes when it is loaded without its tests executing as well as a small jshint fix, adding a missing semicolon since [40107].
Props jnylen0.
Fixes #39561 .
Built from https://develop.svn.wordpress.org/trunk@40109
git-svn-id: http://core.svn.wordpress.org/trunk@40046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-02-24 18:40:40 +00:00