Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-02 16:59:35 +01:00
Code Issues Projects Releases Wiki Activity
33,273 Commits 50 Branches 747 Tags 785 MiB
1e1d1375b0
Commit Graph

6998 Commits

Author SHA1 Message Date
Eric Lewis
207ba54fed In wp.Backbone.Subviews, extract subviews with proper Underscore.js functions. 
Subviews are stored internally on the Subview manager as an object. The object 
is composed of key-value pairs where the key is a jQuery selector for a view,
and the value is an array of views that matching the selector.

To extract subviews, `_.flatten()` was used to collate the nested arrays of 
views into a single view. However, `_.flatten()` is not intended to be used 
for objects, and this unintended functionality breaks in newer versions of 
Underscore.js. 

Instead, we'll use `_.values()` to extract the arrays of views first, 
and then flatten the array of arrays.

Props adamsilverstein.
See #34350.

Built from https://develop.svn.wordpress.org/trunk@36305


git-svn-id: http://core.svn.wordpress.org/trunk@36272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-15 04:02:28 +00:00
Andrea Fercia
e41649c325 Accessibility: Improve focus handling on the Taxonomies Quick Edit. 
Moves focus back to a proper place when saving or closing the form.

Fixes #35460.
Built from https://develop.svn.wordpress.org/trunk@36304


git-svn-id: http://core.svn.wordpress.org/trunk@36271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-14 23:03:26 +00:00
Andrea Fercia
c6ec579751 Accessibility: Improve focus handling and audible feedback on the Posts Quick-Bulk Edit. 
Avoids a focus loss when saving or closing the form moving focus back to a proper place.
Uses `wp.a11y.speak()` to dispatch successful edits and error messages to screen readers.

Fixes #34756.
Built from https://develop.svn.wordpress.org/trunk@36303


git-svn-id: http://core.svn.wordpress.org/trunk@36270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-14 22:58:27 +00:00
Pascal Birchler
aaa11d6207 Allow searching for 0 throughout the admin. 
Fixes #31025.
Built from https://develop.svn.wordpress.org/trunk@36302


git-svn-id: http://core.svn.wordpress.org/trunk@36269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-14 20:06:25 +00:00
Pascal Birchler
d4b30f47bf Plugins: Prevent a warning when searching in the plugins list table. 
After [36182], plugin data contains compatibility info from the API, which is an array and cannot be searched.

Fixes #35461.
Built from https://develop.svn.wordpress.org/trunk@36301


git-svn-id: http://core.svn.wordpress.org/trunk@36268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-14 20:00:29 +00:00
Drew Jaynes
ca94aafb50 Docs: Add a changelog entry to the DocBlock for get_post_type_archive_link() denoting that posts support was added in 4.5. 
See [36225]. See #19902.

Built from https://develop.svn.wordpress.org/trunk@36300


git-svn-id: http://core.svn.wordpress.org/trunk@36267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-14 17:56:27 +00:00
Drew Jaynes
383b9a44de Docs: Adjust formatting for an added-parameter changelog entry in the hook doc for the cron_request filter. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36299


git-svn-id: http://core.svn.wordpress.org/trunk@36266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-14 17:30:28 +00:00
Andrea Fercia
2d76f3cb83 Accessibility: Remove title attributes from the Comments screen. 
Fixes #35304.
Built from https://develop.svn.wordpress.org/trunk@36298


git-svn-id: http://core.svn.wordpress.org/trunk@36265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-14 16:04:27 +00:00
Pascal Birchler
ded3a1d72f Plugins: Make sure the 'Beta testing' tab is first in the plugin installer. 
This makes feature plugins more discoverable for people running development builds.

Fixes #29631.
Built from https://develop.svn.wordpress.org/trunk@36297


git-svn-id: http://core.svn.wordpress.org/trunk@36264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-14 09:07:26 +00:00
Pascal Birchler
08693cd206 Administration: After [36295], mark postBoxL10n as a global to please JSHint. 
See #26399.
Built from https://develop.svn.wordpress.org/trunk@36296


git-svn-id: http://core.svn.wordpress.org/trunk@36263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-14 08:40:26 +00:00
John Blackbourn
9ae1736d01 Administration: Add a "Drag boxes here" message to empty dashboard meta boxes so it's clear to users that it's possible to drag meta boxes into empty spaces. 
Props xavortm
Fixes #26399

Built from https://develop.svn.wordpress.org/trunk@36295


git-svn-id: http://core.svn.wordpress.org/trunk@36262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-14 04:13:26 +00:00
Joe Hoyle
0f9b770b6c Add response status code aliases on WP_Http for convenience. 
These provide a more descriptive way to set response codes elsewhere,
so it's readable and less chance for the wrong response code to be
used such as 401 vs 403.

Props rmccue for the idea.
Fixes #35426.

Built from https://develop.svn.wordpress.org/trunk@36294


git-svn-id: http://core.svn.wordpress.org/trunk@36261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-14 03:16:27 +00:00
John Blackbourn
55bbcf0391 Networks and Sites: Clarify the docblock for get_current_site() so it's clear that it returns the current network object, not anything to do with the current site. As a further exercise, the reader is invited to fix the nomenclature surrounding blogs, sites, and networks in WordPress. 
Props ericlewis
Fixes #35414

Built from https://develop.svn.wordpress.org/trunk@36293


git-svn-id: http://core.svn.wordpress.org/trunk@36260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-14 00:02:25 +00:00
John Blackbourn
d6228b95b0 I18N: Introduce tests for WP_Locale. 
Props realloc, swissspidy
Fixes #34688

Built from https://develop.svn.wordpress.org/trunk@36292


git-svn-id: http://core.svn.wordpress.org/trunk@36259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-13 23:50:26 +00:00
Andrea Fercia
7ab88221fa Customizer: Aggregate similar CSS rules. 
Fixes #34333.
Built from https://develop.svn.wordpress.org/trunk@36291


git-svn-id: http://core.svn.wordpress.org/trunk@36258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-13 22:36:26 +00:00
John Blackbourn
045d7d3a18 I18N: Correct an argument description and return value for wp_dropdown_languages(). 
Props realloc
See #35294

Built from https://develop.svn.wordpress.org/trunk@36290


git-svn-id: http://core.svn.wordpress.org/trunk@36257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-13 20:33:25 +00:00
John Blackbourn
e56457f7fe Taxonomy: Correct the accetped types for the taxonomy element in the arguments passed to wp_dropdown_categories(). 
Props grapplerulrich
Fixes #35446

Built from https://develop.svn.wordpress.org/trunk@36289


git-svn-id: http://core.svn.wordpress.org/trunk@36256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-13 20:16:29 +00:00
Dominik Schilling
9cd5b76fbd jQuery: Replace $( document ).on( 'ready', fn ) with $( fn ). 
The 'ready' event is deprecated since jQuery 1.8.

See https://github.com/jquery/jquery-migrate/blob/1.3.0/warnings.md#jqmigrate-ready-event-is-deprecated.
See #35380.
Built from https://develop.svn.wordpress.org/trunk@36288


git-svn-id: http://core.svn.wordpress.org/trunk@36255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-13 17:39:25 +00:00
Dominik Schilling
b7df807589 jQuery: Replace use of the .load() method for the "load" event with .on( 'load', handler ). 
The shortcut is deprecated since jQuery 1.8.

See http://api.jquery.com/load-event/.
See #35380.
Built from https://develop.svn.wordpress.org/trunk@36287


git-svn-id: http://core.svn.wordpress.org/trunk@36254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-13 17:22:27 +00:00
Dominik Schilling
b3d8732c17 jQuery: Replace the use of the .size() method with the .length property. 
The `.size()` method is deprecated since jQuery 1.8. The `.length` property is preferred because it doesn't have the overhead of a function call.

See https://api.jquery.com/size/.
See #35380.
Built from https://develop.svn.wordpress.org/trunk@36286


git-svn-id: http://core.svn.wordpress.org/trunk@36253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-13 16:17:27 +00:00
Dominik Schilling
b1a9983584 External Libraries: Update jQuery to 1.12.0 and jQuery Migrate to 1.3.0. 
jQuery:
* Release post: http://blog.jquery.com/2016/01/08/jquery-2-2-and-1-12-released/
* Changes: https://github.com/jquery/jquery/compare/1.11.3...1.12.0

jQuery Migrate:
* Release post: http://blog.jquery.com/2016/01/13/jquery-migrate-1-3-0-released/
* Changes: https://github.com/jquery/jquery-migrate/compare/1.2.1...1.3.0

See #35380.
Built from https://develop.svn.wordpress.org/trunk@36285


git-svn-id: http://core.svn.wordpress.org/trunk@36252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-13 15:52:26 +00:00
Dominik Schilling
b8f2a138e7 Set svn:eol-style to native on "jquery-migrate.js" and "jquery-migrate.min.js". 
Built from https://develop.svn.wordpress.org/trunk@36284


git-svn-id: http://core.svn.wordpress.org/trunk@36251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-13 15:45:28 +00:00
Dominik Schilling
0a6f311922 Plugins: In _get_plugin_data_markup_translate() remove the fallback to the "default" textdomain for Akismet. 
Akismet has its own language files since WordPress 3.9.

Props jrf.
Fixes #35436.
Built from https://develop.svn.wordpress.org/trunk@36283


git-svn-id: http://core.svn.wordpress.org/trunk@36250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-13 13:56:26 +00:00
Dominik Schilling
a51129c2a6 Plugins: In _get_plugin_data_markup_translate() don't reload translations if they're already loaded. 
Props jrf.
Fixes #35439.
Built from https://develop.svn.wordpress.org/trunk@36282


git-svn-id: http://core.svn.wordpress.org/trunk@36249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-13 13:04:27 +00:00
Boone Gorges
2d136ce421 Use assertEqualSets() in comment_author test. 
The previous assertion was too specific, resulting in race conditions.

See #35377.
Built from https://develop.svn.wordpress.org/trunk@36279


git-svn-id: http://core.svn.wordpress.org/trunk@36246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-13 04:43:26 +00:00
Boone Gorges
2d74b18bea Support searching for '0' in WP_Query. 
Props swissspidy.
See #31025.
Built from https://develop.svn.wordpress.org/trunk@36278


git-svn-id: http://core.svn.wordpress.org/trunk@36245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-13 04:37:25 +00:00
Boone Gorges
98fb5f0bdb Use the post-filter WHERE clause when querying for comment descendants. 
The descendant query in `WP_Comment_Query::fill_descendants()` uses the clauses
of the main `get_comment_ids()` query as a basis, discarding the `parent`,
`parent__in`, and `parent__not_in` clauses. As implemented in WP 4.4 [34546],
the WHERE clause was assembled in such a way that any modifications applied
using the `comments_clauses` filter were not inherited by `fill_descendants()`.
This resulted in descendant queries that did not always properly filter
results, and sometimes contained syntax errors.

The current changeset fixes the problem by using the post-filter WHERE clause
as the basis for the `fill_descendants()` query. This change requires a new
approach for eliminating the unneeded parent-related clauses: instead of
eliminating values in an associative array, we must use regular expressions.

Props boonebgorges, firebird75.
Fixes #35192.
Built from https://develop.svn.wordpress.org/trunk@36277


git-svn-id: http://core.svn.wordpress.org/trunk@36244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-13 04:01:26 +00:00
Boone Gorges
4ac35f5713 Always respect $comments array passed to wp_list_comments(). 
[36157] fixed a bug whereby `wp_list_comments()` would not properly recognize
custom pagination arguments. See #35175. However, it inadvertently introduced
a bug that caused any `$comments` array explicitly passed to the function to be
ignored, when that array was accompanied by pagination arguments that differ
from those in `$wp_query`. We address this bug by moving the logic introduced
in [36157] inside a block that only fires when no `$comments` array has been
provided to the function.

Props ivankristianto.
Fixes #35356.
Built from https://develop.svn.wordpress.org/trunk@36276


git-svn-id: http://core.svn.wordpress.org/trunk@36243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-13 03:27:27 +00:00
Boone Gorges
294a164b15 Ignore hierarchy in pagination calculation when comment threading is disabled. 
In order to calculate comment pagination when newest comments are displayed
first, `comments_template()` must perform a separate query to determine the
total number of paginating comments available on a post. See [34729], #8071,
pagination calculation - can be defined as a top-level comment, or a comment
with `parent=0`. However, when comment threading is disabled, yet comments
exist in the database that have parents, all comments - even those with a
parent - are "paginating". (This typically happens when comments threading was
once enabled, but has since been turned off.) As such, the total-paginating-
comments query should only be limited to top-level comments when
'thread_comments' is disabled.

Props jmdodd.
Fixes #35419.
Built from https://develop.svn.wordpress.org/trunk@36275


git-svn-id: http://core.svn.wordpress.org/trunk@36242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-13 03:13:25 +00:00
Joe Hoyle
5036a79e73 Add missing HTTP status code descriptions (specifically 308 and 421.) 
Props kraftbj.
Fixes 35336.

Built from https://develop.svn.wordpress.org/trunk@36274


git-svn-id: http://core.svn.wordpress.org/trunk@36241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-13 02:55:26 +00:00
Joe Hoyle
dea447f04c Add support for 451 http status code (Unavailable For Legal Reasons.) 
Though this is technically still in the proposal stage, there is support from the core team and precedent in #16914

Props andizer.
Fixes #35333.

Built from https://develop.svn.wordpress.org/trunk@36273


git-svn-id: http://core.svn.wordpress.org/trunk@36240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-13 02:49:25 +00:00
Rachel Baker
87e7b4455d Comments: Restrict the maximum characters for input fields within the comments template. 
Added hardcoded maxlength attributes on the author, author_email, author_url, and comment_field input markup. These can be modified via the comment_form_defaults filter. Added logic in wp_handle_comment_submission() to return a WP_Error when the comment_author, comment_author_url, or comment_content values exceed the max length of their columns. Introduces wp_get_comment_column_max_length() which returns the max column length for a given column name, and is filterable. Unit tests included for the error conditions in wp_handle_comment_submission()

Fixes #10377.

Props westonruter rachelbaker.

Built from https://develop.svn.wordpress.org/trunk@36272


git-svn-id: http://core.svn.wordpress.org/trunk@36239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-13 01:25:26 +00:00
Eric Lewis
6bd2399382 Docs: Fix typo in wp-admin/admin.php. 
Props sebastian.pisula 
Fixes #35423.


Built from https://develop.svn.wordpress.org/trunk@36271


git-svn-id: http://core.svn.wordpress.org/trunk@36238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-12 20:43:28 +00:00
Konstantin Obenland
c0e903a040 Themes: Clear floated theme cards on Themes page. 
Also maintains visual separation for Broken Themes table on searches that
return no results.

See [36171] for `.wp-clearfix`.

Props 5um17, obenland, valendesigns, afercia.
Fixes #26646.


Built from https://develop.svn.wordpress.org/trunk@36270


git-svn-id: http://core.svn.wordpress.org/trunk@36237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-12 17:13:29 +00:00
Pascal Birchler
d0c1f44d21 Docs: Revert [36268] as the global is indeed used, just via the superglobal. 
Fixes #35413.
Built from https://develop.svn.wordpress.org/trunk@36269


git-svn-id: http://core.svn.wordpress.org/trunk@36236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-12 12:26:27 +00:00
Pascal Birchler
14f073a154 Docs: Fix incorrect DocBlock for wp_get_attachment_url(). 
The documented `$pagenow` global isn't used in the function.

Props sebastian.pisula.
Fixes #35413.
Built from https://develop.svn.wordpress.org/trunk@36268


git-svn-id: http://core.svn.wordpress.org/trunk@36235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-12 12:08:26 +00:00
Andrea Fercia
44ad0964b0 After [36263] escape filterable HTML output. 
Props adamsilverstein.
Fixes #35064.
Built from https://develop.svn.wordpress.org/trunk@36267


git-svn-id: http://core.svn.wordpress.org/trunk@36234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-12 08:58:26 +00:00
Pascal Birchler
e7660a104d Introduce wp_get_raw_referer() to retrieve unvalidated referer. 
For things like redirects `wp_get_referer()` should be used instead.

Props voldemortensen for initial patch.
Fixes #27152.
Built from https://develop.svn.wordpress.org/trunk@36266


git-svn-id: http://core.svn.wordpress.org/trunk@36233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-12 08:32:28 +00:00
Andrea Fercia
5bd888497d Accessibility: Remove title attributes from the Terms list table. 
Fixes #35187.
Built from https://develop.svn.wordpress.org/trunk@36265


git-svn-id: http://core.svn.wordpress.org/trunk@36232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-11 23:30:26 +00:00
Andrea Fercia
876ab5c293 Menus screen: improve responsiveness of select elements. 
Props Luan-Ramos, sagarjadhav.
Fixes #31826.
Built from https://develop.svn.wordpress.org/trunk@36264


git-svn-id: http://core.svn.wordpress.org/trunk@36231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-11 23:05:26 +00:00
Andrea Fercia
057ec3cec0 Accessibility: Remove title attributes from the General Settings screen. 
Date and time formats are now displayed in plain text and available for all
users. Also, lines up them with the "custom" date and time format fields to
help reinforce what these fields do.

Props afercia, perezlabs.
Fixes #35064.
Built from https://develop.svn.wordpress.org/trunk@36263


git-svn-id: http://core.svn.wordpress.org/trunk@36230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-11 22:54:28 +00:00
Weston Ruter
dd123ab2c0 Customizer: Re-use list of components to eliminate code duplication. 
Introduces protected `WP_Customize_Manager::$components` to store list of loaded core components filtered by `customize_loaded_components`.

Props DrewAPicture.
See #35242
See #33552.
Fixes #35354.

Built from https://develop.svn.wordpress.org/trunk@36262


git-svn-id: http://core.svn.wordpress.org/trunk@36229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-11 20:28:28 +00:00
Weston Ruter
3e35a7157f Customizer: Prevent erroneously directing user to login screen when closing. 
Fixes issue where user gets stuck at login screen after trying to close the app if previously they had to first login to access the Customizer. Prevents `WP_Customize_Manager::get_return_url()` from using `wp-login.php` as a referer.

Props chandrapatel.
See #32637.
Fixes #35355.

Built from https://develop.svn.wordpress.org/trunk@36261


git-svn-id: http://core.svn.wordpress.org/trunk@36228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-11 18:51:28 +00:00
Andrea Fercia
9b486acb9b Quick Edit: on the Taxonomies screens, prevent a page reload when pressing Enter on a focused field. 
Fixes #35401 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36260


git-svn-id: http://core.svn.wordpress.org/trunk@36227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-11 13:15:29 +00:00
Dion Hulse
abbcc01542 Multisite: The networks group should be global. 
Fixes #35251.

Built from https://develop.svn.wordpress.org/trunk@36258


git-svn-id: http://core.svn.wordpress.org/trunk@36225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-11 05:04:26 +00:00
Boone Gorges
2c96c289cf Add missing param to 'comments_template_query_args'. 
As introduced in [36235].

Props birgire.
See #34442.
Built from https://develop.svn.wordpress.org/trunk@36256


git-svn-id: http://core.svn.wordpress.org/trunk@36223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-11 02:28:27 +00:00
Pascal Birchler
d63ae29fac After [36254], commit all the necessary files and not just the unit test. 
Built from https://develop.svn.wordpress.org/trunk@36255


git-svn-id: http://core.svn.wordpress.org/trunk@36222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-10 19:07:26 +00:00
Pascal Birchler
34dfb47c4b Rewrite: Ensure WP_Rewrite::flush_rules() does not delete the 'rewrite_rules' option. 
Instead, the option gets updated to an empty string.
Adds unit tests.

Props SergeyBiryukov, jesin, voldemortensen.
Fixes #29107.
Built from https://develop.svn.wordpress.org/trunk@36254


git-svn-id: http://core.svn.wordpress.org/trunk@36221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-10 19:02:26 +00:00
Pascal Birchler
73317a33b6 Permalinks: Ensure the page hierarchy is correct for sample permalinks. 
Fixes #35368.
Built from https://develop.svn.wordpress.org/trunk@36253


git-svn-id: http://core.svn.wordpress.org/trunk@36220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-10 18:28:28 +00:00
Boone Gorges
909470db67 Don't reset index keys when trimming results of term queries. 
`array_slice()` must be told to preserve keys when the query results exceed the
limit specified the 'number' parameter, so that `id=>parent` and other
id-indexed return value formats don't get mangled.

Props fantasyworld, wpdelighter.
Fixes #35382.
Built from https://develop.svn.wordpress.org/trunk@36252


git-svn-id: http://core.svn.wordpress.org/trunk@36219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-10 04:06:25 +00:00
Boone Gorges
cfae56d2c2 Avoid invalid SQL when building ORDER BY clause using long search strings. 
The introduction of negative search terms in 4.4 [34934] introduced the
possibility that the ORDER BY clause of a search query could be assembled in
such a way as to create invalid syntax. The current changeset fixes this by
ensuring that the ORDER BY clause corresponding to the search terms is
excluded when it would otherwise be empty.

Props salvoaranzulla.
Fixes #35361.
Built from https://develop.svn.wordpress.org/trunk@36251


git-svn-id: http://core.svn.wordpress.org/trunk@36218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-10 03:26:26 +00:00
John Blackbourn
a4facedfee Docs: Various docblock corrections. 
See #32246

Built from https://develop.svn.wordpress.org/trunk@36250


git-svn-id: http://core.svn.wordpress.org/trunk@36217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-10 01:26:25 +00:00
John Blackbourn
877d14883e Emoji: Explictly use https as the scheme for emoji fallback images, as they're only served over HTTPS by the CDN anyway. 
Fixes #35376
Props ocean90

Built from https://develop.svn.wordpress.org/trunk@36249


git-svn-id: http://core.svn.wordpress.org/trunk@36216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-10 01:24:26 +00:00
John Blackbourn
f63dc802cb Comments: Correct the docblocks for various methods in the comment list table class. 
See #32246

Built from https://develop.svn.wordpress.org/trunk@36248


git-svn-id: http://core.svn.wordpress.org/trunk@36215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-10 00:52:25 +00:00
John Blackbourn
16fe7012dd Taxonomy: More tests for unregister_taxonomy(). 
See #35227

Built from https://develop.svn.wordpress.org/trunk@36247


git-svn-id: http://core.svn.wordpress.org/trunk@36214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-09 23:35:26 +00:00
Eric Lewis
c52af7470b Login is not a verb, change "login" to "log in". 
See #35387

Built from https://develop.svn.wordpress.org/trunk@36246


git-svn-id: http://core.svn.wordpress.org/trunk@36213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-09 21:08:26 +00:00
Eric Lewis
2f41867519 Users: Fix incorrect docs for user authentication and login functions. 
Fixes #35387

Built from https://develop.svn.wordpress.org/trunk@36245


git-svn-id: http://core.svn.wordpress.org/trunk@36212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-09 20:52:27 +00:00
Pascal Birchler
2e4210e209 Taxonomy: Use Invalid taxonomy instead of Invalid Taxonomy for error strings. 
Built from https://develop.svn.wordpress.org/trunk@36244


git-svn-id: http://core.svn.wordpress.org/trunk@36211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-09 15:16:25 +00:00
Pascal Birchler
710501dc53 Taxonomy: Introduce unregister_taxonomy(). 
This new function can be used to completely unregister non built-in taxonomies.

Fixes #35227.
Built from https://develop.svn.wordpress.org/trunk@36243


git-svn-id: http://core.svn.wordpress.org/trunk@36210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-09 14:58:26 +00:00
Pascal Birchler
d591f26ce7 Ensure wp_get_referer() returns false when the referrer URL is the current URL. 
Adds unit tests.

Fixes #19856.
Built from https://develop.svn.wordpress.org/trunk@36242


git-svn-id: http://core.svn.wordpress.org/trunk@36209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-09 14:36:26 +00:00
Pascal Birchler
fdb6bbfa10 Media: After [36240], remove some unneeded whitespace. 
Props ocean90.
See #35367.
Built from https://develop.svn.wordpress.org/trunk@36241


git-svn-id: http://core.svn.wordpress.org/trunk@36208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-09 14:29:26 +00:00
Pascal Birchler
8ee945d82f Media: Fix wp_audio_shortcode and wp_video_shortcode attributes handling. 
Although documented, the `class` and `style` attributes were simply ignored.
Adds unit tests.

Fixes #35367.
Built from https://develop.svn.wordpress.org/trunk@36240


git-svn-id: http://core.svn.wordpress.org/trunk@36207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-09 14:18:27 +00:00
Dion Hulse
43d8a30d0c Tests: Add more paged canonical tests for page_on_front. 
See #35344.

Built from https://develop.svn.wordpress.org/trunk@36238


git-svn-id: http://core.svn.wordpress.org/trunk@36205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-09 08:09:26 +00:00
Dion Hulse
84a3b4407f Canonical: Generate the correct canonical url for paged posts/pages when they're used as the page_on_front. 
This fixes an issue where pages become inacessible on a front page post.

Fixes #35344 for trunk.

Built from https://develop.svn.wordpress.org/trunk@36237


git-svn-id: http://core.svn.wordpress.org/trunk@36204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-09 07:33:27 +00:00
Dion Hulse
d57776b108 Tests: Remove some debug that's slipped in at some point. 
Built from https://develop.svn.wordpress.org/trunk@36236


git-svn-id: http://core.svn.wordpress.org/trunk@36203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-09 06:12:27 +00:00
Boone Gorges
72265e4a98 Introduce comments_template_query_args filter. 
This new filter gives developers a way to target the arguments used for comment
queries specifically when populating the main comment template.

Props birgire.
Fixes #34442.
Built from https://develop.svn.wordpress.org/trunk@36235


git-svn-id: http://core.svn.wordpress.org/trunk@36202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-09 04:44:26 +00:00
Boone Gorges
4ce9b93af9 Clarify return types in get_option() documentation. 
The new note specifies that scalar values will always be returned as strings.

Fixes #31820.
Built from https://develop.svn.wordpress.org/trunk@36234


git-svn-id: http://core.svn.wordpress.org/trunk@36201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-09 03:12:26 +00:00
Andrew Ozz
5a6be6d431 Media: fix undefined error that prevents showing a preview in the media modal when replacing video or audio. 
Fixes #35363.
Built from https://develop.svn.wordpress.org/trunk@36233


git-svn-id: http://core.svn.wordpress.org/trunk@36200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-09 02:22:26 +00:00
John Blackbourn
a5d44337b2 Docs: @param fixes for a variety of docblocks. 
See #32246

Built from https://develop.svn.wordpress.org/trunk@36232


git-svn-id: http://core.svn.wordpress.org/trunk@36199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-09 01:45:26 +00:00
John Blackbourn
7718e07129 Docs: Correct the parameter docs for various Heartbeat filters and functions. 
See #32246

Built from https://develop.svn.wordpress.org/trunk@36231


git-svn-id: http://core.svn.wordpress.org/trunk@36198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-09 01:37:26 +00:00
John Blackbourn
7931478595 Feeds: Remove the rss-http feed type, unused since r32468. 
See #15110

Built from https://develop.svn.wordpress.org/trunk@36230


git-svn-id: http://core.svn.wordpress.org/trunk@36197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-09 01:20:26 +00:00
Eric Lewis
b464b01c7e Add documentation for parseData() and ajaxDel() in wp-lists.js. 
Fixes #35360.

Built from https://develop.svn.wordpress.org/trunk@36229


git-svn-id: http://core.svn.wordpress.org/trunk@36196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-09 00:05:26 +00:00
Eric Lewis
7733ed2ddc Cron: Add the cron lock timestamp to the 'cron_request' filter arguments. 
Fixes #31307

Built from https://develop.svn.wordpress.org/trunk@36228


git-svn-id: http://core.svn.wordpress.org/trunk@36195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-08 23:54:26 +00:00
Boone Gorges
cbb245196c Use a more generous selector when setting up tag suggestion. 
This allows taxonomy metaboxes to be registered in a greater variety of
locations on the Dashboard.

Props johnjamesjacoby..
Fixes #35349.
Built from https://develop.svn.wordpress.org/trunk@36227


git-svn-id: http://core.svn.wordpress.org/trunk@36194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-08 23:18:25 +00:00
Boone Gorges
13629bf5d0 In comments_template(), don't run hierarchical queries if comment threading is disabled. 
When hierarchical=true, `WP_Comment_Query` will always fetch comments according
to the comment hierarchy, even if 'thread_comments' is disabled for the site.
This can cause problems when comment threading is disabled after threaded
comments have been recorded on the site; comments will no longer be returned in
a strictly chronological order.

We address the issue by refraining from querying hierarchically when comment
threading is disabled.

Props jmdodd.
Fixes #35378.
Built from https://develop.svn.wordpress.org/trunk@36226


git-svn-id: http://core.svn.wordpress.org/trunk@36193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-08 22:17:26 +00:00
Eric Lewis
d8e6199126 Permalinks: Make get_post_type_archive_link() work for the 'post' post type. 
Props jjj.
See #19902. 

Built from https://develop.svn.wordpress.org/trunk@36225


git-svn-id: http://core.svn.wordpress.org/trunk@36192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-08 22:01:26 +00:00
Boone Gorges
5b4b4fc479 Introduce 'author_url' param to WP_Comment_Query. 
Props swissspidy.
Fixes #35377.
Built from https://develop.svn.wordpress.org/trunk@36224


git-svn-id: http://core.svn.wordpress.org/trunk@36191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-08 21:52:27 +00:00
Andrea Fercia
ae1575bd80 Media: make the Image Editor usable with a keyboard. 
For accessibility, all interactive controls must be operable from the keyboard.
Replaces `<div>`s used as UI controls with buttons. Groups some logically-related
form elements.

Fixes #28864.
Built from https://develop.svn.wordpress.org/trunk@36223


git-svn-id: http://core.svn.wordpress.org/trunk@36190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-08 19:13:26 +00:00
Andrea Fercia
1f9c29d98f Accessibility: remove the title attribute from the get_search_form() HTML5 search field. 
It was added in [23801] as a workaround for issues with very old browser/screen reader combos (Jaws7/IE6).
No more necessary today. Reduces redundancy and noise for screen reader users.

See #16539.
Fixes #33952.
Built from https://develop.svn.wordpress.org/trunk@36222


git-svn-id: http://core.svn.wordpress.org/trunk@36189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-08 19:01:26 +00:00
Konstantin Obenland
c252e77ce3 Plugins: Use plugin file rather than slug as identifier 
The plugin file is unique while there can be more than one plugin with the
same slug. This also allows us to simplify the way updates from the plugin
detail iframe are executed.

See [36205].
Fixes #35350.


Built from https://develop.svn.wordpress.org/trunk@36221


git-svn-id: http://core.svn.wordpress.org/trunk@36188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-08 17:48:28 +00:00
Dion Hulse
07e9d22968 Update to Random_Compat 1.1.5 to fix an issue with older libSodium modules. 
Props sarciszewski.
Fixes #35327 for trunk.

Built from https://develop.svn.wordpress.org/trunk@36220


git-svn-id: http://core.svn.wordpress.org/trunk@36187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-08 03:28:28 +00:00
Weston Ruter
0b8c6eed83 Customizer: Improve _doing_it_wrong() message when widgets or nav_menus are manually removed via WP_Customize_Manager::remove_panel(). 
* Link to code reference page for `customize_loaded_components` instead of linking to a Trac comment.
* Remove HTML code from being included in translated string.
* Add missing translator comment for the specifiers in the translated string.

Amends [36216].
Props DrewAPicture.
Fixes #35242.

Built from https://develop.svn.wordpress.org/trunk@36219


git-svn-id: http://core.svn.wordpress.org/trunk@36186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-07 18:44:28 +00:00
Pascal Birchler
0075480202 Tests: Fix unit tests after [36217]. 
See #35236.
Built from https://develop.svn.wordpress.org/trunk@36218


git-svn-id: http://core.svn.wordpress.org/trunk@36185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-07 10:17:27 +00:00
Pascal Birchler
f079f57357 Rewrite: Add a remove_rewrite_tag() helper function. 
It can be used to properly remove registered rewrite tags. Adds unit tests.

Fixes #35236.
Built from https://develop.svn.wordpress.org/trunk@36217


git-svn-id: http://core.svn.wordpress.org/trunk@36184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-07 09:39:27 +00:00
Weston Ruter
668818e93d Customizer: Call _doing_it_wrong() if widgets or nav_menus are manually removed via WP_Customize_Manager::remove_panel(). 
Advise that the `customize_loaded_components` filter should be used instead.

Props voldemortensen.
See #33552.
Fixes #35242.

Built from https://develop.svn.wordpress.org/trunk@36216


git-svn-id: http://core.svn.wordpress.org/trunk@36183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-07 06:06:28 +00:00
Boone Gorges
74f83e1016 Allow comment agent and author IP to be set via wp_update_comment(). 
Props adamsilverstein, welcher.
Fixes #35276.
Built from https://develop.svn.wordpress.org/trunk@36215


git-svn-id: http://core.svn.wordpress.org/trunk@36182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-07 03:55:28 +00:00
Boone Gorges
0e0c6a7ee7 Ensure 'description' is a string in wp_insert_term(). 
Passing `'description' => null` when creating a term can cause MySQL notices,
as the description column in the terms table does not allow for null values.
We correct this by intepreting a `null` description as an empty string.

Props TimothyBlynJacobs.
Fixes #35321.
Built from https://develop.svn.wordpress.org/trunk@36214


git-svn-id: http://core.svn.wordpress.org/trunk@36181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-07 03:32:28 +00:00
Konstantin Obenland
0b9f825e29 Plugins: Avoid ID attribute collisions in plugins list table. 
Removes id attributes with non-unique plugin slug and adds a data attribute
with the unique plugin file.

Props khag7.
Fixes #18974.


Built from https://develop.svn.wordpress.org/trunk@36205


git-svn-id: http://core.svn.wordpress.org/trunk@36172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-06 22:40:26 +00:00
Konstantin Obenland
d5fd177b96 Themes: Avoid changing the count of themes with updates in network admin. 
Makes the count bubble selector a little more specific to avoid interfering
with the admin menu, but not too specific for installed theme searches not to
update the bubble.

See [29786], [31495].
Fixes #35332.


Built from https://develop.svn.wordpress.org/trunk@36204


git-svn-id: http://core.svn.wordpress.org/trunk@36171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-06 22:32:28 +00:00
Aaron Jorbin
7ab65139c6 Theme: Escape error messages 
Built from https://develop.svn.wordpress.org/trunk@36185


git-svn-id: http://core.svn.wordpress.org/trunk@36152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-06 17:23:28 +00:00
Dion Hulse
83059c3553 Unit Tests: Fix the unit test added in [36181] to include the index in the comparison. 
See #35235

Built from https://develop.svn.wordpress.org/trunk@36183


git-svn-id: http://core.svn.wordpress.org/trunk@36150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-06 08:10:26 +00:00
Dion Hulse
4a0e40a814 Updates: Don't perform an API call to WordPress.org for every plugin update displayed. The API has been updated to return this information with the update response. 
See #35301

Built from https://develop.svn.wordpress.org/trunk@36182


git-svn-id: http://core.svn.wordpress.org/trunk@36149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-06 07:53:26 +00:00
Pascal Birchler
dbe28bf8e3 Rewrite: Add a remove_permastruct() helper function. 
It can be used to remove permastructs that were added using `add_permastruct()`.

Fixes #35235.
Built from https://develop.svn.wordpress.org/trunk@36181


git-svn-id: http://core.svn.wordpress.org/trunk@36148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-06 07:40:26 +00:00
Dion Hulse
06a3f799e7 Background Updates: Remove the 7am/7pm background update check. This check was made redundant by [28129] as background updates are now run after a version check takes place. 
See #27772, #35323.

Built from https://develop.svn.wordpress.org/trunk@36180


git-svn-id: http://core.svn.wordpress.org/trunk@36147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-06 06:12:26 +00:00
Dominik Schilling
7d378fce01 Bundled Themes: Bump version number of Twenty Thirteen. 
Props davidakennedy.
Fixes #35319.
Built from https://develop.svn.wordpress.org/trunk@36179


git-svn-id: http://core.svn.wordpress.org/trunk@36146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-05 22:20:26 +00:00
Dominik Schilling
4cb341e82c Install: Use new colors for error notices. 
Props duaneblake, DBrumbaugh10Up.
Fixes #34704.
Built from https://develop.svn.wordpress.org/trunk@36178


git-svn-id: http://core.svn.wordpress.org/trunk@36145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-05 21:47:25 +00:00
Pascal Birchler
85bb9aa5fb Query: Add a WP::remove_query_var() helper function. 
This makes cleaning up public query vars easier.

Fixes #35234.
Built from https://develop.svn.wordpress.org/trunk@36177


git-svn-id: http://core.svn.wordpress.org/trunk@36144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-05 20:57:28 +00:00
Dominik Schilling
c9d7fb9b28 Install: Only enqueue scripts when necessary. 
Props flixos90 for initial patch.
Fixes #34700.
Built from https://develop.svn.wordpress.org/trunk@36176


git-svn-id: http://core.svn.wordpress.org/trunk@36143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-05 16:42:29 +00:00
Dominik Schilling
0929025aea Docs: Move the hook doc for the the_title filter in Walker_Page::start_el() to directly precede the apply_filters() line. 
See #32246.
Built from https://develop.svn.wordpress.org/trunk@36175


git-svn-id: http://core.svn.wordpress.org/trunk@36142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-05 16:35:26 +00:00
Dominik Schilling
0b6c5744dc Nav Menus: Apply the the_title filter on original post titles in wp_setup_nav_menu_item(). 
The filter is already used in `Walker_Nav_Menu_Checklist` and `Walker_Nav_Menu_Edit`. This ensures that titles are consistent across the admin and front end.

Fixes #35317.
Built from https://develop.svn.wordpress.org/trunk@36174


git-svn-id: http://core.svn.wordpress.org/trunk@36141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-05 16:27:26 +00:00