Commit Graph

25408 Commits

Author SHA1 Message Date
laurelfulford
1e73770c39 Twenty Seventeen: Fix issues with theme's Gutenberg support.
A handful of issues were missed in Twenty Seventeen's Gutenberg support, added in #45045. This commit includes the following fixes:

* Update editor placeholder text to use the correct font family.
* Center text and bullets in list-based widget blocks, when block itself is centered.
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Add spacing underneath the Media & Text block, but make sure the final paragraph in the block doesn't add too much space.
* Simplify selectors used to set editor width to just `.wp-block`.
* Prevent margin from theme's editor-style.css from interfering with editor alignment. 
 
Props pento, davidakennedy.
Fixes #45246.


Built from https://develop.svn.wordpress.org/branches/5.0@43876


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-06 06:17:47 +00:00
laurelfulford
c42f50371e Twenty Sixteen: Fix issues with theme's Gutenberg support.
A handful of issues were missed in Twenty Sixteen's Gutenberg support, added in #45044. This commit includes the following fixes:

* Center text and bullets in list-based widget blocks, when block itself is centered.
* Correct styles for the editor placeholder text, so it's not inheriting a darker gray from the theme's CSS. 
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Reset Cover blocks as `display: flex` when they are centered, to maintain their original appearance.
* Add spacing underneath the Media & Text block, but make sure the final paragraph in the block doesn't add too much space.
* Simplify selectors used to set editor width to just `.wp-block`.
* Prevent margin from theme's editor-style.css from interfering with editor alignment. 
 
Props pento, davidakennedy.
Fixes #45245.


Built from https://develop.svn.wordpress.org/branches/5.0@43875


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-06 06:06:48 +00:00
laurelfulford
115f10be59 Twenty Fifteen: Fix issues with theme's Gutenberg support.
A handful of issues were missed in Twenty Fifteen's Gutenberg support, added in #45043. This commit includes the following fixes:

* Center text and bullets in list-based widget blocks, when block itself is centered.
* Add a margin to blocks that are aligned to the left or to the right, to create space.
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Add spacing underneath the Media & Text block, but make sure the final paragraph in the block doesn't add too much space.
* Simplify selectors used to set editor width to just `.wp-block`.
* Prevent margin from theme's editor-style.css from interfering with editor alignment. 

Props pento, davidakennedy.
Fixes #45244.


Built from https://develop.svn.wordpress.org/branches/5.0@43874


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-06 05:57:46 +00:00
laurelfulford
720d54d544 Twenty Fourteen: Fix issues with theme's Gutenberg support.
A handful of issues were missed in Twenty Fourteen's Gutenberg support, added in #45042. This commit includes the following fixes:

* Update editor placeholder text to use the correct font family.
* Center text and bullets in list-based widget blocks, when block itself is centered.
* Remove unnecessary spacing from the Columns block.
* Add spacing underneath the Media & Text block, but make sure the final paragraph in the block doesn't add too much space.
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Simplify selectors used to set editor width to just `.wp-block`.

Props pento, davidakennedy.
Fixes #45243.


Built from https://develop.svn.wordpress.org/branches/5.0@43873


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-06 01:26:47 +00:00
laurelfulford
b61dd6109c Twenty Thirteen: Fix issues with theme's Gutenberg support.
A handful of issues were missed in Twenty Thirteen's Gutenberg support, added in #45041. This commit includes the following fixes:

* Center text and bullets in list-based widget blocks, when block itself is centered.
* Prevent full and wide aligned blocks from getting wider than Twenty Thirteen's design.
* Prevent wide aligned blocks from getting too wide, as they can seem out of proportion with the full aligned blocks.
* Make sure full and wide blocks display at the correct width in the editor.
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Make sure wide and full aligned Table blocks span the available width on the front end.
* Add spacing underneath the Media & Text block, but make sure the final paragraph in the block doesn't add too much space.
* Simplify selectors used to set editor width to just `.wp-block`.


Props pento, davidakennedy.
Fixes #45242.


Built from https://develop.svn.wordpress.org/branches/5.0@43872


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-06 01:22:48 +00:00
laurelfulford
8362e6601e Twenty Twelve: Fix issues with theme's Gutenberg support.
A handful of issues were missed in Twenty Twelve's Gutenberg support, added in #45040. This commit includes the following fixes:

* Update editor placeholder text to use the correct font family.
* Center text and bullets in list-based widget blocks, when block itself is centered.
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Add spacing underneath the Media & Text block, but make sure final paragraph in the block doesn't add too much space.
* Simplify selectors used to set editor width to just `.wp-block`.


Props pento, davidakennedy.
Fixes #45240.


Built from https://develop.svn.wordpress.org/branches/5.0@43871


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-06 01:10:47 +00:00
laurelfulford
f89d4e6bb2 Twenty Eleven: Fix issues with theme's Gutenberg support.
A handful of issues were missed in Twenty Eleven's Gutenberg support, added in #45039. This commit includes the following fixes:

* Center text and bullets in list-based widget blocks when block itself is centered.
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Add spacing underneath the Media & Text block, but make sure final paragraph in the block doesn't add too much space.
* Simplify selectors used to set editor width to just `.wp-block`.
* Prevent margin from theme's editor-style.css from interfering with editor alignment. 

Props pento, davidakennedy.
Fixes #45239.


Built from https://develop.svn.wordpress.org/branches/5.0@43870


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-06 01:01:48 +00:00
laurelfulford
8532f185b6 Twenty Ten: Fix issues with theme's Gutenberg support.
A handful of issues were missed in Twenty Ten's Gutenberg support, added in #45038. This commit includes the following fixes:

* Update editor placeholder text to use the correct font family and size.
* Remove unnecessary spacing from the Columns block.
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Add spacing underneath the Media & Text block.
* Simplify selectors used to set editor width to just `.wp-block`.

Fixes #45238.


Built from https://develop.svn.wordpress.org/branches/5.0@43869


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-06 00:50:48 +00:00
laurelfulford
6f076d4d51 Bundled Themes: Add theme support for responsive embeds
Add `add_theme_support( 'responsive-embeds' );` to all of the responsive default themes as part of their Gutenberg support. This makes sure any embeds coming from the new block-based editor maintain their aspect ratios at different screen sizes.

Fixes #45274.


Built from https://develop.svn.wordpress.org/branches/5.0@43868


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-06 00:25:50 +00:00
Andrew Ozz
23be3ef6e6 TinyMCE:
- Fix parsing of the init array in script-loader.
- Do not JSON encode the options object when outputting it from PHP.
- Remove JSON decoding of TinyMCE's `style_formats` option.

Fixes #45221.
Built from https://develop.svn.wordpress.org/branches/5.0@43867


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-05 08:39:49 +00:00
Gary Pendergast
3e1ae54884 Tests: Skip symlinked theme file tests if the links could not be created, or if symlink() is not available
Merges [42812,42819] to the 5.0 branch.

Props SergeyBiryukov.
Fixes #43508.

Built from https://develop.svn.wordpress.org/branches/5.0@43866


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-05 02:47:49 +00:00
Gary Pendergast
6d71fad8d3 Post WordPress 5.0 Beta 3 version bump.
Built from https://develop.svn.wordpress.org/branches/5.0@43865


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-05 00:19:47 +00:00
Gary Pendergast
47da460a3a WordPress 5.0 Beta 3.
Built from https://develop.svn.wordpress.org/branches/5.0@43864


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-05 00:07:47 +00:00
Gary Pendergast
a46a68ad7f Meta Boxes: Add curly brackets missed in [43861].
This was causing the custom meta box to be incorrectly added to post types that don't support it.

Props ocean90, epointal.
Fixes #45257,

Built from https://develop.svn.wordpress.org/branches/5.0@43863


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-04 23:23:49 +00:00
danielbachhuber
56842f36aa REST API: Prevent duplicate firing of rest(_after)?_insert_attachment actions.
Props danielbachhuber, peterwilsoncc.
Fixes #45269.
See #42864.

Built from https://develop.svn.wordpress.org/branches/5.0@43862


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-03 14:14:49 +00:00
Gary Pendergast
325cb107d1 Build Tools: Update the @wordpress packages.
This brings support for the custom fields meta box to the block editor.

The `webpack` and `copy-webpack-plugin` packages have also been updated.

See #45145.
Fixes #45257.


Built from https://develop.svn.wordpress.org/branches/5.0@43861


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-03 07:57:54 +00:00
allancole
c53ad88930 Importing Twenty Nineteen, our new default theme for 2019, set for 5.0.
Let Gutenberg shine with this simple, fast, and powerful theme. Initial development occurred on GitHub. See: https://github.com/WordPress/twentynineteen

Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, aaronjorbin, netweb, b-07, khleomix, blowery, dereksmart, jasmussen, audrasjb, nielslange, mmaumio, dimadin, joyously, anevins12, peterwilsoncc, dannycooper, icaleb, siriokun, technosiren, travel_girl, azchughtai, ianbelanger, nadim1992, ismailelkorchi, nativeinside, chetan200891, icaleb, grapplerulrich, ocean90, joshfeck, frankew, abdulwahab610, mendezcode, eliorivero, melchoyce, joen, laurelfulford, mdawaffe, kraftbj, dsmart, mukeshpanchal27, burhandodhy, crunnells, Ismail-elkorchi, aryaprakasa.

Built from https://develop.svn.wordpress.org/branches/5.0@43860


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-02 23:53:49 +00:00
herregroen
69867a34db I18N: Improve JavaScript translation support.
Improves upon [43825] by adding unit tests to cover additional use-cases and changes loading translations to only occur when outputting the script to allow setting translations on dependencies.

Props atimmer, omarreiss, nerrad, swissspidy, ocean90.
Fixes #45103.

Built from https://develop.svn.wordpress.org/branches/5.0@43859


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-01 13:51:47 +00:00
Gary Pendergast
e0664765b6 Editor: Cast the result of the default_content, default_title, and default_excerpt filters.
If a plugin returns a non-string value (or returns `null`) on these filters, it can cause errors in the block editor. Casting them as a string prevents these errors.

Props dd32.
See #45236.


Built from https://develop.svn.wordpress.org/branches/5.0@43858


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-01 05:20:47 +00:00
Gary Pendergast
6ad646a080 Block Editor: Remove CodeMirror settings.
CodeMirror is no longer used in the block editor, so we don't need to load the settings.

Props noisysocks.
Fixes #45248.


Built from https://develop.svn.wordpress.org/branches/5.0@43857


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-01 05:07:47 +00:00
Gary Pendergast
d9e31a1bb9 Block Editor: Don't show back compat or incompatible meta boxes in Options.
Meta boxes that exist for back compat, or that are incompatible with the block editor aren't displayed, so they don't need an option to display or hide them in the Options dialog.

Props noisysocks.
Fixes #45249.


Built from https://develop.svn.wordpress.org/branches/5.0@43856


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-01 04:33:46 +00:00
Gary Pendergast
049d3a6db8 Posts: Remove the slug from Quick Edit for posts that are not is_post_type_viewable().
This is a followup to [43728], which added the same check, but using the `publicly_queryable` option. This behaviour is incorrect for `_builtin` post types, which go by the logic in `is_post_type_viewable()`, instead.

See #43278.

Built from https://develop.svn.wordpress.org/branches/5.0@43855


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-01 02:35:46 +00:00
Gary Pendergast
eb4031a209 Blocks: Add "Export as JSON" action to the wp_block post list screen.
Remove the "Quick Edit" for `wp_block`s, too, as they don't need any of that functionality.

Props noisysocks.
Fixes #45247.


Built from https://develop.svn.wordpress.org/branches/5.0@43854


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-01 02:25:47 +00:00
Gary Pendergast
a3b620f104 Build Tools: Switch to Node 10.13.0.
Now that Node 10 is the LTS branch, with 10.13.0 as the first LTS release, let's use that for building WordPress.

See #45241.


Built from https://develop.svn.wordpress.org/branches/5.0@43853


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-01 02:02:47 +00:00
danielbachhuber
7c929a2922 REST API: Fix array syntax after [43851].
I thought I was writing JavaScript. Alas.

See #45196.

Built from https://develop.svn.wordpress.org/branches/5.0@43852


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-31 18:19:17 +00:00
danielbachhuber
40b2c11980 REST API: Regenerate fixure schema after introduction of new endpoints.
This fixture schema ensures `wp-api-generated.js` doesn't change when running tests in local dev environments.

Fixes #45196.

Built from https://develop.svn.wordpress.org/branches/5.0@43851


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-31 18:18:26 +00:00
danielbachhuber
d5e3670372 REST API: Restore access to audio/video metadata functions.
Ensures `wp_read_video_metadata()`/`wp_read_audio_metadata()` functions are available when uploading video and audio. Fixes error introduced in [43589].

Props ocean90.
See #43757.

Built from https://develop.svn.wordpress.org/branches/5.0@43850


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-31 18:17:35 +00:00
danielbachhuber
b277797add Blocks: Include necessary labels for the 'wp_block' post type.
See #45098

Built from https://develop.svn.wordpress.org/branches/5.0@43849


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-31 18:16:44 +00:00
Gary Pendergast
1fb36474cb FTP/PemFTP Library: Fix some PHP notices.
- `ftp_base::glob()` used `each()`, which is deprecated as of PHP 7.2.
- `ftp_base::fget()` was missing the decleration of its third parameter, `$rest`.

Props itowhid06.
See #44489.


Built from https://develop.svn.wordpress.org/branches/5.0@43848


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-31 18:15:54 +00:00
Gary Pendergast
59c4bcebcc Build Tools: Update the @wordpress packages.
Trunk now matches Gutenberg 4.2 RC1.

See #45145.


Built from https://develop.svn.wordpress.org/branches/5.0@43847


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-31 18:15:02 +00:00
danielbachhuber
bb2de34edb l10n: Avoid calling is_user_logged_in() in determine_locale().
`is_user_logged_in()` is a pluggable function, and loaded after plugins are loaded. If a plugin calls `__()` too early, `is_user_logged_in()` is missing and WordPress will fatal. `get_user_locale()` already handles this scenario for us, so it's safe to rely on exclusively.

See #44758.
Fixes #45235.

Built from https://develop.svn.wordpress.org/branches/5.0@43846


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-31 02:33:53 +00:00
Gary Pendergast
f21fbee21b Posts WordPress 5.0 Beta 2 version bump.
Built from https://develop.svn.wordpress.org/branches/5.0@43845


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-30 05:00:49 +00:00
Gary Pendergast
37177611f3 WordPress 5.0 Beta 2.
Built from https://develop.svn.wordpress.org/branches/5.0@43844


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-30 04:47:50 +00:00
Gary Pendergast
0014a77fa3 Build Tools: Update @wordpress packages.
See #45145.


Built from https://develop.svn.wordpress.org/branches/5.0@43843


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-30 03:09:58 +00:00
allancole
b8cb0e7058 Importing Twenty Nineteen, our new default theme for 2019, set for 5.0.
Let Gutenberg shine with this simple, fast, and powerful theme. Initial development occurred on GitHub. See: https://github.com/WordPress/twentynineteen

Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, aaronjorbin, netweb, b-07, khleomix, blowery, dereksmart, jasmussen, audrasjb, nielslange, mmaumio, dimadin, joyously, anevins12, peterwilsoncc, dannycooper, icaleb, siriokun, technosiren, travel_girl, azchughtai, ianbelanger, nadim1992, ismailelkorchi, nativeinside, chetan200891, icaleb, grapplerulrich, ocean90, joshfeck, frankew, abdulwahab610, mendezcode, eliorivero, melchoyce, joen, laurelfulford, mdawaffe, kraftbj, dsmart.

Built from https://develop.svn.wordpress.org/branches/5.0@43842


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-30 02:15:04 +00:00
Gary Pendergast
9b3cee6428 Tests: Fix failing unit tests caused by [43840].
See #45145.


Built from https://develop.svn.wordpress.org/branches/5.0@43841


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-29 08:37:29 +00:00
Gary Pendergast
ebb5e6dd0d Build Tools: Upgrade @wordpress packages to the latest version.
This also includes the new `@wordpress/format-library` and `@wordpress/notices` packages.

`package-lock.json` has been completely regenerated in this commit.

See #45145.


Built from https://develop.svn.wordpress.org/branches/5.0@43840


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-29 08:36:36 +00:00
Gary Pendergast
f2e3a6c1ac Meta boxes: Don't show the block editor incompatiblity message when it doesn't apply.
We should only be showing this message in the classic editor interface, for meta boxes that are marked as being incompatible with the block editor.

Fixes #45207.


Built from https://develop.svn.wordpress.org/branches/5.0@43839


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-29 08:31:06 +00:00
Gary Pendergast
3549683ca3 Meta boxes: Don't assume that callback args are an array.
While the documentation for `add_meta_box()` specifices that `$callback_args` should be an array, this has never been enforced, and we have workarounds in place for when it's passed as something other than an array.

Rather than break sites that are passing unexpected data, we can quietly just allow for it, instead.

Props johnjamesjacoby, birgire.
Fixes #45206.


Built from https://develop.svn.wordpress.org/branches/5.0@43838


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-29 08:30:14 +00:00
Gary Pendergast
742913ca97 Block Editor: Fix meta boxes not showing.
The block editor needs to duplicate the classic meta box behaviour, so it can extract the registered meta boxes, and import them into the block editor.

To match the classic editor behaviour as closely as possible, this moves the relevant code from the classic editor, into a new function, so it can be called by both.

Props pento, peterwilsoncc.
Fixes #45172.


Built from https://develop.svn.wordpress.org/branches/5.0@43837


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-29 08:29:23 +00:00
Gary Pendergast
d13ae6300c Build Tools: Add an npm script shortcut to run grunt.
Rather than needing to install grunt globally, this allows running grunt from `node_modules`, instead.

`npm run grunt ...` is effectively the equivalent of running `grunt ...`.

Props andrew.taylor.
See #45214.


Built from https://develop.svn.wordpress.org/branches/5.0@43836


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-29 08:28:32 +00:00
Gary Pendergast
91ce38b3d5 Build Tools: Revert [43826] and [43824].
Grabbing the packages directly from the Gutenberg repo was an interesting experiment, but it causes significant workflow issues, particular for folks using Windows.

See #45145.


Built from https://develop.svn.wordpress.org/branches/5.0@43835


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-29 08:27:39 +00:00
danielbachhuber
7136636db3 REST API: Improve performance by avoiding call_user_func().
The `get_compact_response_links()` method was introduced in WP 4.5, and this conditional is no longer necessary.

Props schlessera, timothyblynjacobs.
Fixes #45189.

Built from https://develop.svn.wordpress.org/branches/5.0@43834


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-29 00:49:40 +00:00
danielbachhuber
eea6942164 Block Editor: Preload wp/v2/media with OPTIONS for caps check.
Also introduces a `block_editor_preload_paths` filter for plugins and themes to preload additional data.

Props imath, mattheu.
Fixes #45194.

Built from https://develop.svn.wordpress.org/branches/5.0@43833


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-29 00:25:38 +00:00
Aaron Jorbin
8b7967db38 php7.3 compatibility: Fix compact throwing notices for multisite
In PHP 7.3, the compact() function has been changed to issue an E_NOTICE level error if a passed string refers to an unset variable. In previous versions of PHP, this notice was silently skipped. The full RFC can be viewed here: https://wiki.php.net/rfc/compact

By initializing these variables, they can be compacted.

Previously [43819].
See #44416.
Props desrosj.


Built from https://develop.svn.wordpress.org/branches/5.0@43832


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-26 20:18:38 +00:00
Gary Pendergast
97a88cdf69 Script Loader: Add translator comments and remove textdomains.
The inline script for `wp-date` incorrectly included a textdomain, and lacked translator comments.

Props mukesh27.
Fixes #45191, #45162.


Built from https://develop.svn.wordpress.org/branches/5.0@43831


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-26 08:16:42 +00:00
Gary Pendergast
0c54153886 Meta Boxes: Fix error when a meta box is rendered with a static method callback.
When `WP_DEBUG` is set, ensure that a static method callback is passed to `ReflectionMethod`, instead of `ReflectionFunction`.

Props DrewAPicture.
Fixes #45192.


Built from https://develop.svn.wordpress.org/branches/5.0@43830


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-26 08:12:39 +00:00
Gary Pendergast
e491b2bc6a Accessibility: Media: Improve the usage of a few label elements in the media templates.
Label elements should only be used for labelable elements.
- `Uploaded By` and `Uploaded To` aren't form controls and shouldn't be associated with labels
- changes the labels for media source, alternate sources, poster image, and tracks to solve a layout issue and explicitly associate the labels to their form fields (previously, the labels were wrapping also the Remove buttons)

Merges [42444] to the 5.0 branch.

Props Presskopp, afercia.
Fixes #38759, #40468.


Built from https://develop.svn.wordpress.org/branches/5.0@43829


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-26 07:41:45 +00:00
Sergey Biryukov
81131b0635 Tests: Use DIR_TESTDATA in test_wp_set_script_translation().
`__DIR__` is not available in PHP 5.2.x.

See #45103.
Built from https://develop.svn.wordpress.org/branches/5.0@43828


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-26 07:40:05 +00:00
Drew Jaynes
2f515c6db0 Docs: Link to the "Conditional Tags" article in the Theme Developer Handbook from the descriptions for a variety of core conditional tag functions.
These notations largely serve to direct consumers (of both the source and the parsed code reference) to extended information on individual and related conditional tags throughout WordPress. The changeset also standardizes corresponding DocBlock summaries to use third-person singular verbs.

Notations have been added for the following functions:

* comments_open()
* email exists()
* has_excerpt()
* has_post_thumbnail()
* has_tag()
* in_category()
* in_the_loop()
* is_404()
* is_active_sidebar()
* is_active_widget()
* is_admin()
* is_admin_bar_showing()
* is_archive()
* is_attachment()
* is_author()
* is_blog_installed()
* is_category()
* is_comments_popup()
* is_date()
* is_day()
* is_dynamic_sidebar()
* is_feed()
* is_front_page()
* is_home()
* is_local_attachment()
* is_main_query
* is_month()
* is_multi_author
* is_new_day()
* is_page()
* is_page_template()
* is_paged()
* is_plugin_active()
* is_plugin_active_for_network()
* is_plugin_inactive()
* is_plugin_page()
* is_post_type_archive()
* is_preview()
* is_rtl()
* is_search()
* is_single()
* is_singular()
* is_sticky()
* is_tag()
* is_tax()
* is_taxonomy_hierarchical()
* is_time()
* is_trackback()
* is_user_logged_in()
* is_year()
* pings_open()
* post_type_exists()
* taxonomy_exists()
* term_exists()
* username exists()
* wp_attachment_is_image()
* wp_script_is() 

Merges [42710] to the 5.0 branch.

Props janalwin.
Fixes #43254.

Built from https://develop.svn.wordpress.org/branches/5.0@43827


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-26 07:38:26 +00:00