Commit Graph

87 Commits

Author SHA1 Message Date
Andrew Nacin
85d4685894 Always pass integer expirations to cache backends.
props SergeyBiryukov, andreasnrb.
fixes #25308.

Built from https://develop.svn.wordpress.org/trunk@25451


git-svn-id: http://core.svn.wordpress.org/trunk@25372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-16 17:43:09 +00:00
Sergey Biryukov
566dd6e476 Correct inline docs for cache.php. props ocean90. fixes #23058.
git-svn-id: http://core.svn.wordpress.org/trunk@23328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-22 20:44:30 +00:00
Ryan Boren
06ee370814 Pinking shears
git-svn-id: http://core.svn.wordpress.org/trunk@22634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 15:11:29 +00:00
Ryan Boren
77518e9c71 Objects no longer need to be explicitly passed by ref to call_user_func*() to be callable. Props wonderboymusic. fixes #21865
git-svn-id: http://core.svn.wordpress.org/trunk@22118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-04 20:00:16 +00:00
Ryan Boren
7dc670fc8d Update phpdoc and deprecation for wp_cache_reset(). see #21434
git-svn-id: http://core.svn.wordpress.org/trunk@22111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-04 15:32:55 +00:00
Ryan Boren
9c9ecb315e Add @since to wp_cache_switch_to_blog(). Props SergeyBiryukov. fixes #21434
git-svn-id: http://core.svn.wordpress.org/trunk@22086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-30 14:02:59 +00:00
ryan
295ca4d76f Introduce wp_cache_switch_to_blog() and WP_Object_Cache::switch_to_blog() as a lighter/faster way to switch the cache to a new blog id.
Add the blog id to the cache keys for multisite installs.

Use wp_cache_switch_to_blog() instead of wp_cache_init() in switch_to_blog().

Use wp_cache_switch_to_blog() instead of wp_cache_reset() in wp_start_object_cache().

Deprecate wp_cache_reset().

This avoids the many queries needed to re-prime the cache after switch_to_blog() on multisite installs using the default cache backend.

fixes #21434



git-svn-id: http://core.svn.wordpress.org/trunk@21403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-02 18:31:14 +00:00
nacin
167124051b If $group is empty in WP_Object_Cache::decr(), consider it to be 'default'.
This is consistent with the rest of the cache methods wrapped by
functions; the functions pass an empty string by default, hence
the need for this check.

props bananastalktome.
fixes #21327.



git-svn-id: http://core.svn.wordpress.org/trunk@21294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-20 20:15:25 +00:00
nacin
5b2c145a4d Improve the performance of WP_Object_Cache's _exists() method.
Results showed a performance improvement on one admin screen of 90ms (~2%).

fixes #21320. see #20004.



git-svn-id: http://core.svn.wordpress.org/trunk@21285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-20 04:21:42 +00:00
duck_
c0892fbaf0 Prevent notices by checking if the $group key isset(). See #20004.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-02 21:57:03 +00:00
ryan
783e59e185 Fix NULL and FALSE in WP_Object_Cache and make found/not-found unambiguous. Props andy. fixes #20004
git-svn-id: http://svn.automattic.com/wordpress/trunk@20089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-02 21:10:37 +00:00
ryan
e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
ryan
83b131f8e3 User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302
git-svn-id: http://svn.automattic.com/wordpress/trunk@19687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:50:54 +00:00
ryan
07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
nacin
89c0895887 new does not require by reference.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-18 20:20:59 +00:00
duck_
e085f4f0d6 Remove the non_existent_objects property from WP_Object_Cache. Fixes #16274.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-15 20:28:06 +00:00
duck_
cda68f14f9 Introduce wp_suspend_cache_addition() to allow reduced memory usage when cache additions aren't useful. Fixes #5389.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-15 20:23:00 +00:00
ryan
5ebcc1d3ea Improve cron locking. Avoid multiple cron processes looping over the same events. fixes #17462
git-svn-id: http://svn.automattic.com/wordpress/trunk@18659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-09 19:59:44 +00:00
ryan
6e68c7bfd9 Update cache.php phpdoc. Props SergeyBiryukov. fixes #18607
git-svn-id: http://svn.automattic.com/wordpress/trunk@18653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-08 17:19:09 +00:00
ryan
4410168419 Standardize variable names. Consistently use and . fixes #18607
git-svn-id: http://svn.automattic.com/wordpress/trunk@18644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-06 21:13:11 +00:00
duck_
e4ed63fc6f Fix typos in documentation (wp-includes/[a-h]). See #18560.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-03 16:02:41 +00:00
ryan
c93728e287 Introduce wp_cache_incr() and wp_cache_decr(). fixes #18494
git-svn-id: http://svn.automattic.com/wordpress/trunk@18580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-22 17:39:44 +00:00
ryan
e3895262ef Deprecate wp_clone(). Call clone directly. Props hakre. fixes #16813
git-svn-id: http://svn.automattic.com/wordpress/trunk@17613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-06 17:44:29 +00:00
ryan
b60c345536 Remove PHP4 constructors. Props hakre. see #16768
git-svn-id: http://svn.automattic.com/wordpress/trunk@17604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-05 17:25:08 +00:00
nacin
b8ce0261df More param fixes, props duck_. see #14783.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-18 19:12:48 +00:00
westi
0027abcb1a Strip back the stats in the memory based object cache to something less verbose and useless.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-11 10:55:06 +00:00
nacin
d3451c6301 Fix html in WP_Object_Cache::stats. props Utkarsh, fixes #15183.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-21 13:15:24 +00:00
nacin
7bb63ebe44 esc_html in WP_Object_Cache::stats(). fixes #15003.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-09 11:38:12 +00:00
nacin
5a20c05d27 Phpdoc argument/@param cleanups. props duck_, see #14783.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-07 11:21:11 +00:00
nacin
f60838c8f9 s/echos/echoes/ in phpdoc. props demetris, fixes #13742.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-06 05:16:32 +00:00
ryan
f97aa91a68 Preload commonly loaded site options when running multisite without a persistent cache. Introduce wp_cache_reset() and call it instead of wp_cache_init() when re-initing after the blog ID chanages to avoid throwing out the entire cache. Pass cached site options through the site option filter when fetching.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-12 17:06:43 +00:00
ryan
c75817ca52 Fix typos. Fix assignment. Remove passing of non-existent arg. Props ScottMac. fixes #12193
git-svn-id: http://svn.automattic.com/wordpress/trunk@13054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-11 16:58:32 +00:00
ryan
f6c2de0141 Use clone to break object refs when setting and getting cache. see #8146 #8191
git-svn-id: http://svn.automattic.com/wordpress/trunk@9740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-17 21:01:12 +00:00
westi
f7b32217a3 phpDoc corrections for wp-includes. See #7550 props santosj.
git-svn-id: http://svn.automattic.com/wordpress/trunk@8742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-27 06:45:13 +00:00
ryan
35b18e5034 Trailing whitespace cleanup
git-svn-id: http://svn.automattic.com/wordpress/trunk@8600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-09 05:36:14 +00:00
ryan
62784a594f phpdoc updates from jacobsantos. see #7038
git-svn-id: http://svn.automattic.com/wordpress/trunk@7990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-05-25 15:45:05 +00:00
ryan
58e47dcb4a wp_cache_add_global_groups() and wp_cache_add_non_persistent_groups(). fixes #6740
git-svn-id: http://svn.automattic.com/wordpress/trunk@7986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-05-22 17:28:54 +00:00
ryan
8263948a96 Some notice fixes from Nazgul. fixes #3155
git-svn-id: http://svn.automattic.com/wordpress/trunk@6711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-02 18:42:09 +00:00
ryan
1d1c3cc6f5 phpdoc for cache.php from darkdragon. fixes #5511
git-svn-id: http://svn.automattic.com/wordpress/trunk@6543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-03 04:35:47 +00:00
ryan
60220997a6 Fix cache close. see #5570
git-svn-id: http://svn.automattic.com/wordpress/trunk@6540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-02 23:03:25 +00:00
ryan
bc53152043 Remove persistent object cache. fixes #5570
git-svn-id: http://svn.automattic.com/wordpress/trunk@6539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-02 22:13:16 +00:00
ryan
bd5d107814 Allow single post ID and comma delimited list of post IDs to be passed to update_postmeta_cache(). Fix default cache to allow storage of empty array. see #5194
git-svn-id: http://svn.automattic.com/wordpress/trunk@6247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-10-14 01:08:07 +00:00
ryan
13b23aa20a Space before slash to properly close br tag. Props tmountjr. fixes #4717
git-svn-id: http://svn.automattic.com/wordpress/trunk@5870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-08-14 03:12:24 +00:00
ryan
f2f6101e1c Comment caching. Reduce queries on edit-comments.php page. Add non-persistent cache groups. Hat tip to hovenko. fixes #4387
git-svn-id: http://svn.automattic.com/wordpress/trunk@5666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-06-08 00:20:22 +00:00
ryan
f7e5557f6e Don't load category cache from old tables. see #4189
git-svn-id: http://svn.automattic.com/wordpress/trunk@5544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-05-25 09:45:55 +00:00
rob1n
75efedc528 Delete the cache in tmp even if the copy failed. Props andy. fixes #4141
git-svn-id: http://svn.automattic.com/wordpress/trunk@5255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-04-12 16:31:47 +00:00
markjaquith
d0f79bb3f2 trailing tabs and whitespace cleanup.
git-svn-id: http://svn.automattic.com/wordpress/trunk@4953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-02-27 15:24:54 +00:00
markjaquith
36491e0980 make sure nothing going into the object cache is being passed by reference. fixes #3726
git-svn-id: http://svn.automattic.com/wordpress/trunk@4856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-02-01 09:16:15 +00:00
markjaquith
12e9cabfb7 Introduce Notoptions and Alloptions caching, so that all options (and previously attempted Notoptions) are read from the cache in one go. Should reduce cache misses to zero or close to it. fixes #3726
git-svn-id: http://svn.automattic.com/wordpress/trunk@4855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-02-01 08:53:08 +00:00
ryan
4d2ab530cb Fiddle with object destruction and shutdown. Curses upon php 5.2. fixes #3354
git-svn-id: http://svn.automattic.com/wordpress/trunk@4686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-01-06 23:36:51 +00:00