Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-09-11 07:08:14 +02:00
Code Issues Projects Releases Wiki Activity
30,410 Commits 49 Branches 747 Tags 864 MiB
1f7a3bc58d
Commit Graph

5435 Commits

Author SHA1 Message Date
Scott Taylor
60b8e86b36 In WP_Filesystem_Base::chdir|chgrp|chmod() (all mock abstract methods), modify @return to include string so that subclass @returns match. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32962


git-svn-id: http://core.svn.wordpress.org/trunk@32933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 00:43:24 +00:00
Scott Taylor
7537240d37 List tables: when post navigation links point to the current page, use <span>s and text instead of <a>s. 
Props afercia.
Fixes #32253.

Built from https://develop.svn.wordpress.org/trunk@32948


git-svn-id: http://core.svn.wordpress.org/trunk@32919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 20:32:26 +00:00
Scott Taylor
587c570efa After [32796], improve the accessibility and markup for instances of touch_time(). 
Props rianrietveld, afercia.
Fixes #31714.

Built from https://develop.svn.wordpress.org/trunk@32945


git-svn-id: http://core.svn.wordpress.org/trunk@32916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 19:30:25 +00:00
Andrew Ozz
7142248743 Press This: better screen reader text for the arrow part of the split button. 
Props afercia. See #32757.
Built from https://develop.svn.wordpress.org/trunk@32944


git-svn-id: http://core.svn.wordpress.org/trunk@32915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 19:24:25 +00:00
Scott Taylor
7453d12390 Remove unused code from WP_Press_This::html(). 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32939


git-svn-id: http://core.svn.wordpress.org/trunk@32910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 16:38:25 +00:00
Scott Taylor
d9bd43c702 Remove unused code from WP_MS_Sites_List_Table::display_rows(). 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32938


git-svn-id: http://core.svn.wordpress.org/trunk@32909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 16:36:29 +00:00
Andrew Ozz
d3ee649cb9 Press This: support passing i parameter to add an image src. 
Props stephdau, azaozz. Fixes #32173.
Built from https://develop.svn.wordpress.org/trunk@32936


git-svn-id: http://core.svn.wordpress.org/trunk@32907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 03:06:25 +00:00
Andrew Ozz
d4f3428d5f Press This, split button: wrap the sub-buttons in an unordered list to aid accessibility. 
Props afercia. See #32757.
Built from https://develop.svn.wordpress.org/trunk@32934


git-svn-id: http://core.svn.wordpress.org/trunk@32905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 01:55:30 +00:00
John Blackbourn
b5973e92ec Introduce a no_terms label for taxonomies. This label is used when indicating that there are no terms in the given taxonomy associated with an object. 
Fixes #32150
Props afercia

Built from https://develop.svn.wordpress.org/trunk@32933


git-svn-id: http://core.svn.wordpress.org/trunk@32904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 00:16:27 +00:00
Drew Jaynes
e9758d4e48 Fix a typo in the DocBlock for get_plugins(). 
Props onnimonni, swissspidy.
Fixes #32758.

Built from https://develop.svn.wordpress.org/trunk@32927


git-svn-id: http://core.svn.wordpress.org/trunk@32898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 12:22:27 +00:00
Dion Hulse
42fbb6568e WP Filesystem: Correctly set the @since for WP_Filesystem_Base::getchmod() added in r32923. 
This is 2.5.0 as that's when the function become available in all subclasses.
See #29548

Built from https://develop.svn.wordpress.org/trunk@32924


git-svn-id: http://core.svn.wordpress.org/trunk@32895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 04:52:25 +00:00
Dion Hulse
8f47efe7dc WP Filesystem: Correctly parse the permissions field in the directory listings, and actually set it in FTP environments 
Props mnelson4 for initial patch.
Fixes #29548

Built from https://develop.svn.wordpress.org/trunk@32923


git-svn-id: http://core.svn.wordpress.org/trunk@32894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 04:49:25 +00:00
Andrew Ozz
f8cf80e9b1 Press This: ensure proper tab order in the split button. Tweak padding and border color a bit. 
See #32757.
Built from https://develop.svn.wordpress.org/trunk@32921


git-svn-id: http://core.svn.wordpress.org/trunk@32892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 03:23:27 +00:00
Andrew Ozz
f4109b0c5d Press This: convert the Preview | Save | Publish buttons to a split button. 
See #32757.
Built from https://develop.svn.wordpress.org/trunk@32920


git-svn-id: http://core.svn.wordpress.org/trunk@32891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 02:46:27 +00:00
Scott Taylor
00de0e6341 In unregister_setting(), search for $option_name in a segment of $new_whitelist_options keyed by $option_group. 
Props nofearinc.
Fixes #26479.

Built from https://develop.svn.wordpress.org/trunk@32905


git-svn-id: http://core.svn.wordpress.org/trunk@32876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 20:51:26 +00:00
Scott Taylor
b8f49cebee List table views: fix missing current class for "All" when logged in as an author. 
Props afercia.
Fixes #32015.

Built from https://develop.svn.wordpress.org/trunk@32903


git-svn-id: http://core.svn.wordpress.org/trunk@32874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 20:39:27 +00:00
Helen Hou-Sandí
5a07e4bba4 Add "Scheduled" to post states. 
props rclations.
fixes #32131.

Built from https://develop.svn.wordpress.org/trunk@32902


git-svn-id: http://core.svn.wordpress.org/trunk@32873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 16:07:26 +00:00
Sergey Biryukov
4332d8dfc0 Avoid a PHP notice in WP_Press_This::get_suggested_content() after [32828]. 
props kraftbj.
fixes #32751.
Built from https://develop.svn.wordpress.org/trunk@32901


git-svn-id: http://core.svn.wordpress.org/trunk@32872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 15:20:28 +00:00
Scott Taylor
92d67bf395 Use valid markup in Walker_Nav_Menu_Edit::start_el() - replace <d(l|t)> with <div> for .menu-item-bar and .menu-item-handle. 
Props sagarjadhav.
Fixes #31817.

Built from https://develop.svn.wordpress.org/trunk@32879


git-svn-id: http://core.svn.wordpress.org/trunk@32850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 22:22:26 +00:00
Scott Taylor
032ea5b132 Add access modifier to WP_Upgrader::clear_destination() 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32871


git-svn-id: http://core.svn.wordpress.org/trunk@32842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 21:53:25 +00:00
Scott Taylor
86beb35f6d Use <button> instead of <a> for non-link links in Quick Edit. 
Props afercia.
Fixes #32213.

Built from https://develop.svn.wordpress.org/trunk@32869


git-svn-id: http://core.svn.wordpress.org/trunk@32840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 21:42:27 +00:00
Scott Taylor
cfe78e0e95 Cleanup (ms-)?admin-filters.php 
Props johnjamesjacoby.
Fixes #32529.

Built from https://develop.svn.wordpress.org/trunk@32865


git-svn-id: http://core.svn.wordpress.org/trunk@32836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 21:18:25 +00:00
Dion Hulse
8593dc3172 When updating plugins/themes verify that the files to be deleted can be modified before starting the deletion process. 
This will avoid partially deleting an item during update which has inconsistent permissions.
This change only affects those using the direct & ssh transports as FTP's is_writable() currently always returns `true`.
Fixes #30921

Built from https://develop.svn.wordpress.org/trunk@32854


git-svn-id: http://core.svn.wordpress.org/trunk@32825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 03:49:25 +00:00
Dion Hulse
a21f890abb Remove a redundant index drop, it'll be dropped and re-created a few lines further down. 
Fixes a warning during updating from 4.0 or earlier.
Fixes #31388 for trunk

Built from https://develop.svn.wordpress.org/trunk@32852


git-svn-id: http://core.svn.wordpress.org/trunk@32823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 03:18:26 +00:00
Konstantin Obenland
c1a9c4b7b8 Semanticize Help and Screen Options toggle. 
Links used as UI controls that are not real links but act as buttons, should be buttons.

Props afercia.
Fixes #32494.


Built from https://develop.svn.wordpress.org/trunk@32844


git-svn-id: http://core.svn.wordpress.org/trunk@32815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 16:36:25 +00:00
Konstantin Obenland
d872f38c31 Show the posts meta box by default in Appearance > Menus. 
Lessens user confusion and the likelyhood of misusing custom links
to add menu items for posts.

Props bcole808.
Fixes #32440.


Built from https://develop.svn.wordpress.org/trunk@32842


git-svn-id: http://core.svn.wordpress.org/trunk@32813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 15:04:26 +00:00
Konstantin Obenland
c9e1e2be9b Make posts in the 'Most recent' tab of post type meta boxes filterable. 
Provides parity with the 'View All' tab of post type meta boxes in Appearance > Menus.

Props jpyper, chriscct7.
Fixes #19365.


Built from https://develop.svn.wordpress.org/trunk@32833


git-svn-id: http://core.svn.wordpress.org/trunk@32804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 11:35:28 +00:00
Andrew Ozz
bc2630e099 Press This: Check the embeds list against all of the oembed providers. 
Props stephdau. Fixes #32069.
Built from https://develop.svn.wordpress.org/trunk@32828


git-svn-id: http://core.svn.wordpress.org/trunk@32799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 00:12:26 +00:00
Andrew Ozz
b77a3a33f5 Press This: show error message when the user is attempting to add a category that already exists. 
Fixes #32339.
Built from https://develop.svn.wordpress.org/trunk@32827


git-svn-id: http://core.svn.wordpress.org/trunk@32798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 23:13:26 +00:00
Boone Gorges
f62bf61b2c Bail out of 4.3 term splitting routine when no shared terms are found. 
Props dd32.
See #30261.
Built from https://develop.svn.wordpress.org/trunk@32819


git-svn-id: http://core.svn.wordpress.org/trunk@32790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 11:40:24 +00:00
Boone Gorges
290044ef15 Split all shared taxonomy terms on upgrade to 4.3. 
Dear Shared Terms, Welcome to Splitsville. Population: You.

See #30261.
Built from https://develop.svn.wordpress.org/trunk@32814


git-svn-id: http://core.svn.wordpress.org/trunk@32785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 01:53:26 +00:00
Helen Hou-Sandí
d159cc2272 Media list table: Avoid PHP notices by using the proper variables. 
Also visually tightens up the row actions.

props tyxla.
fixes #32657. see #29881.

Built from https://develop.svn.wordpress.org/trunk@32805


git-svn-id: http://core.svn.wordpress.org/trunk@32776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 21:33:25 +00:00
Scott Taylor
5c6b63d3a6 if is a statment, not a function. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32800


git-svn-id: http://core.svn.wordpress.org/trunk@32771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 20:01:25 +00:00
Helen Hou-Sandí
a49c192f37 Media list table: Restore row actions. 
see #29881, #32657.

Built from https://develop.svn.wordpress.org/trunk@32798


git-svn-id: http://core.svn.wordpress.org/trunk@32769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 19:47:24 +00:00
Dion Hulse
faf6383ebd Updates: Consistently use the same variable to refer to the plugin, avoids a potential PHP Notice when an external update script adds data without that key. 
Props mordauk. Fixes #31784

Built from https://develop.svn.wordpress.org/trunk@32784


git-svn-id: http://core.svn.wordpress.org/trunk@32755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 06:26:25 +00:00
Dion Hulse
c6bb637f89 Updats: Add a filter for the options params for the update being performed. 
Props nofearinc. Fixes #27754

Built from https://develop.svn.wordpress.org/trunk@32783


git-svn-id: http://core.svn.wordpress.org/trunk@32754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 05:35:26 +00:00
Dion Hulse
b881a541bb Updates: Remove redundant title tags from update outputs. 
Props afercia. Fixes #32530

Built from https://develop.svn.wordpress.org/trunk@32781


git-svn-id: http://core.svn.wordpress.org/trunk@32752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 05:09:25 +00:00
Dion Hulse
0eb8bfc464 Updates: When a error occurs during the connection phase, pass the error message back as the ajax failure message. 
See #32435

Built from https://develop.svn.wordpress.org/trunk@32778


git-svn-id: http://core.svn.wordpress.org/trunk@32749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 03:32:27 +00:00
Andrew Nacin
e7f618d86e Tweak the first post/page content to get with the times. 
props chriscct7.
fixes #22474.

Built from https://develop.svn.wordpress.org/trunk@32768


git-svn-id: http://core.svn.wordpress.org/trunk@32739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 18:56:50 +00:00
Scott Taylor
4348074f3a In WP_MS_Users_List_Table::display_rows(): 
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - there is a small amount of logic that requires overriding, otherwise it is largely the same as the parent method

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32757


git-svn-id: http://core.svn.wordpress.org/trunk@32728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 17:11:26 +00:00
Scott Taylor
3855cfbffd In WP_MS_Themes_List_Table::display_rows(): 
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32756


git-svn-id: http://core.svn.wordpress.org/trunk@32727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 16:54:26 +00:00
Scott Taylor
2bdcc71bc0 In WP_MS_Sites_List_Table::display_rows(): 
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - it could inherit from `WP_List_Table` if we can find a way to handle the `id` column. When that happens, we can ditch this method.

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32755


git-svn-id: http://core.svn.wordpress.org/trunk@32726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 16:23:25 +00:00
Scott Taylor
ba8cfcab71 In WP_Media_List_Table::display_rows(): 
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32754


git-svn-id: http://core.svn.wordpress.org/trunk@32725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 15:57:27 +00:00
Scott Taylor
a56576edfe In WP_Links_List_Table::display_rows(): 
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32753


git-svn-id: http://core.svn.wordpress.org/trunk@32724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 15:33:25 +00:00
Scott Taylor
b8eb353590 In WP_Posts_List_Table, move the <th> markup out of ->column_cb(). 
See #29881, [32740].

Built from https://develop.svn.wordpress.org/trunk@32752


git-svn-id: http://core.svn.wordpress.org/trunk@32723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 15:14:24 +00:00
Scott Taylor
18827ed337 In wp_ajax_hidden_columns(), don't explode() on an empty string. 
In `columns.hidden()`, which lives in `common.js`, don't return items with no `id`.

This was resulting in options like `manageedit-postcolumnshidden` containing a serialized array with random empty items.

Props afercia, wonderboymusic.
Fixes #32466.

Built from https://develop.svn.wordpress.org/trunk@32751


git-svn-id: http://core.svn.wordpress.org/trunk@32722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 15:00:25 +00:00
Scott Taylor
da0400e273 In WP_Posts_List_Table::column_title(), use is_post_type_hierarchical() instead of $this->hierarchical_display in the logic to determine whether the_excerpt() should be called. 
Fixes #32187.

Built from https://develop.svn.wordpress.org/trunk@32749


git-svn-id: http://core.svn.wordpress.org/trunk@32720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 14:42:26 +00:00
Scott Taylor
c11e433858 After [32740], in WP_Posts_List_Table::single_row() - $lock_holder is checked but unused, so the call to get_userdata() is unnecessary. 
See #29881.

Built from https://develop.svn.wordpress.org/trunk@32742


git-svn-id: http://core.svn.wordpress.org/trunk@32713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 20:48:26 +00:00
Scott Taylor
c1c7a7c14c After [32740], correct doc block typo. 
See #29881.

Built from https://develop.svn.wordpress.org/trunk@32741


git-svn-id: http://core.svn.wordpress.org/trunk@32712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 20:29:26 +00:00
Scott Taylor
3f4cadf4aa Override ->single_row_columns() in WP_Posts_List_Table. 
Break apart the giant `switch` statement in `->single_row()` into `column_{$column_name}` methods.
To maintain the `->single_row_columns( $item )` interface, add a property, `$current_level`, to allow access to `$level`.

This list table class is now easier to subclass.

Props joehoyle, wonderboymusic.
See #29881.

Built from https://develop.svn.wordpress.org/trunk@32740


git-svn-id: http://core.svn.wordpress.org/trunk@32711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 20:18:24 +00:00
Scott Taylor
d0aa8e4a6e In WP_Terms_List_Table::display_rows_or_placeholder(): 
* `get_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* The 2nd call to `get_terms()` can be removed, it is redundant #OPTIMIZATION

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32739


git-svn-id: http://core.svn.wordpress.org/trunk@32710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 18:55:25 +00:00
Scott Taylor
da4c3d0fe4 In WP_Posts_List_Table::single_row(): 
* `get_the_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* Correct the `@param` doc blocks

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32738


git-svn-id: http://core.svn.wordpress.org/trunk@32709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 18:50:25 +00:00
Scott Taylor
4835310a18 In WP_Media_List_Table::display_rows(), get_the_terms() can return WP_Error, so its return value should be checked before traversing. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32737


git-svn-id: http://core.svn.wordpress.org/trunk@32708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 18:45:25 +00:00
Scott Taylor
f88b42be94 In WP_Comments_List_Table::column_comment(), $post and $the_comment_status are unused, as is the $comment_status global. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32736


git-svn-id: http://core.svn.wordpress.org/trunk@32707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 18:39:25 +00:00
Scott Taylor
d2a00338f6 Don't loosely compare functions that return bool against a literal bool. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32730


git-svn-id: http://core.svn.wordpress.org/trunk@32701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 17:19:27 +00:00
Dion Hulse
c445d60a00 SSH2 Upgrade transport: Use ssh2_sftp_realpath() instead of shell commands to determine the current directory on the remote server. This should allow it to be used on chrooted SSH sessions. 
See #32345

Built from https://develop.svn.wordpress.org/trunk@32726


git-svn-id: http://core.svn.wordpress.org/trunk@32696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 06:31:28 +00:00
Konstantin Obenland
cb39d03501 Improve non-visual feedback for list table items without terms. 
Props karpstrucking, afercia.
Fixes #32150.


Built from https://develop.svn.wordpress.org/trunk@32725


git-svn-id: http://core.svn.wordpress.org/trunk@32695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-11 09:28:31 +00:00
Helen Hou-Sandí
c87224eaf6 List tables: Use a class instead of inline styles for hidden columns. 
fixes #32608.

Built from https://develop.svn.wordpress.org/trunk@32724


git-svn-id: http://core.svn.wordpress.org/trunk@32694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 19:47:27 +00:00
Helen Hou-Sandí
06ebd0a2aa List tables: 
Since the primary column is not going to be alterable for plugins and MS themes, we don't need to check in on it.

see #25408.

Built from https://develop.svn.wordpress.org/trunk@32723


git-svn-id: http://core.svn.wordpress.org/trunk@32693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 19:31:25 +00:00
Helen Hou-Sandí
51b5ed9fa4 List tables: Better primary column back-compat. 
Why are people manually setting `$_column_headers` other than because somebody else told them to? Maybe time will tell.

props kovshenin.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32722


git-svn-id: http://core.svn.wordpress.org/trunk@32692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 14:59:30 +00:00
Helen Hou-Sandí
3562ac028d List tables: Consolidate <td> output for posts. 
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32721


git-svn-id: http://core.svn.wordpress.org/trunk@32691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 14:01:28 +00:00
Konstantin Obenland
ce16fd8dca More semantic markup for the post formats metabox. 
Screen readers will now introduce the group of radio buttons.
Also brings the meta box to parity with Press This.

Props joedolson, afercia.
Fixes #26160.


Built from https://develop.svn.wordpress.org/trunk@32720


git-svn-id: http://core.svn.wordpress.org/trunk@32690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 09:09:25 +00:00
Jeremy Felt
0e76a2c570 Additional improvement to sites list table display 
* Build `$blogname` identically when creating action link messaging.
* Remove the trailing slash from URLs for a better UI.

See #32434.

Built from https://develop.svn.wordpress.org/trunk@32719


git-svn-id: http://core.svn.wordpress.org/trunk@32689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 07:28:26 +00:00
Jeremy Felt
93ff65e677 Improve information displayed in a network's sites list table 
* Better support for arbitrary domain/path combinations by displaying the URL in the primary column rather than Path or Domain.
* Show a cached count of total users per site as a more useful data point rather than the first 5 users.
* Clear that cached count of users for a site when a user is added to the site via `add_user_to_blog()`.

Props @ocean90.
Fixes #32434.

Built from https://develop.svn.wordpress.org/trunk@32718


git-svn-id: http://core.svn.wordpress.org/trunk@32688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 06:50:25 +00:00
Helen Hou-Sandí
005d937ce2 List tables: 
* Avoid notices in custom list tables that manually set `$_column_headers`. Any plugins using this for a specific purpose should update.
* Restore a special class name in the users list table.

props georgestephanis, stephdau.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32717


git-svn-id: http://core.svn.wordpress.org/trunk@32687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 01:46:27 +00:00
Konstantin Obenland
6d56231da3 Sort screen options for meta boxes according to the meta box's priority. 
Props swissspidy.
Fixes #32582.


Built from https://develop.svn.wordpress.org/trunk@32707


git-svn-id: http://core.svn.wordpress.org/trunk@32677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-08 12:35:26 +00:00
Konstantin Obenland
c20edc4df5 Remove title attributes in user list tables. 
They don't add valuable information and are redundant.
Reduces annoyance for screen reader users.

Props afercia.
Fixes #32535.


Built from https://develop.svn.wordpress.org/trunk@32694


git-svn-id: http://core.svn.wordpress.org/trunk@32664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-05 08:40:26 +00:00
Konstantin Obenland
5daf12dba4 Text improvements for screen readers in list table paginations. 
Removes title attributes where reasonable and uses accessible hidden text.
Screen readers will now correctly read out all available information.

Props afercia, rianrietveld.
Fixes #32028.


Built from https://develop.svn.wordpress.org/trunk@32693


git-svn-id: http://core.svn.wordpress.org/trunk@32663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-05 05:01:25 +00:00
Helen Hou-Sandí
0e77b693ac Nav menus: hide the title attribute field by default for new users and installs. 
It is still available in screen options. This also gives the "Navigation Label", a crucial field, the room it really deserves.

props paulwilde.
fixes #32218.

Built from https://develop.svn.wordpress.org/trunk@32691


git-svn-id: http://core.svn.wordpress.org/trunk@32661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-04 04:38:25 +00:00
Helen Hou-Sandí
6f6788c4af Media list view: ensure thumbnails are appropriately sized and constrained. 
see #29993.

Built from https://develop.svn.wordpress.org/trunk@32688


git-svn-id: http://core.svn.wordpress.org/trunk@32658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-03 15:23:25 +00:00
Helen Hou-Sandí
40fca44c89 Media: move the thumbnail into the title column in list view. 
This gives us more space for the title and row actions, and will make a responsive list table enhancement significantly easier.

props bradt for the initial patch.
fixes #29993 and #32255. see #32509 and #32395.

Built from https://develop.svn.wordpress.org/trunk@32687


git-svn-id: http://core.svn.wordpress.org/trunk@32657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-03 15:13:25 +00:00
Helen Hou-Sandí
2d3a637598 List tables: tighten up primary column handling for plugins and multisite themes. 
These shouldn't be able to have their primary column reassigned by default. Also removes the `has-row-actions` class as these list tables always have row actions visible and the JS for visual toggling conflicts. The `column-primary` class remains.

props stephdau.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32686


git-svn-id: http://core.svn.wordpress.org/trunk@32656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-03 15:08:28 +00:00
Andrew Ozz
b3d04247b7 Editor: 
- Remove the old DFW.
- Add back-compat stub for wp-fullscreen.js.
- Keep wp_ajax_wp_fullscreen_save_post() for now.
See #30949.
Built from https://develop.svn.wordpress.org/trunk@32677


git-svn-id: http://core.svn.wordpress.org/trunk@32647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-01 17:38:29 +00:00
John Blackbourn
02192cb53f Introduce featured_image, set_featured_image, remove_featured_image, and use_featured_image post type labels when registering a post type in order to override the 'Featured Image' text and its related phrases. 
Props johnbillion, mordauk, valendesigns.
Fixes #19257.

Built from https://develop.svn.wordpress.org/trunk@32673


git-svn-id: http://core.svn.wordpress.org/trunk@32643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 16:54:27 +00:00
Scott Taylor
42d51a4f89 Add doc blocks to functions that are missing them. 
If the function has no need for `@param` or `@return`, do an archeaological dig to find `@since`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32672


git-svn-id: http://core.svn.wordpress.org/trunk@32642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 03:18:25 +00:00
Drew Jaynes
9cb1017b3c Fix inline documentation formatting in wp-admin/includes/admin-filters.php, introduced in [32653]. 
See #32529.

Built from https://develop.svn.wordpress.org/trunk@32671


git-svn-id: http://core.svn.wordpress.org/trunk@32641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 02:00:26 +00:00
Drew Jaynes
0df0e0bf36 Fix syntax and add a missing return description for inline documentation introduced in [32644] for WP_Users_List_Table. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32670


git-svn-id: http://core.svn.wordpress.org/trunk@32640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:45:27 +00:00
Drew Jaynes
65f31bc52e Fix syntax and add missing return descriptions for inline documentation introduced in [32644] for WP_Terms_List_Table. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32669


git-svn-id: http://core.svn.wordpress.org/trunk@32639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:44:26 +00:00
Drew Jaynes
a69f867738 Fix syntax and add missing return descriptions for inline documentation introduced in [32644] for WP_Posts_List_Table. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32668


git-svn-id: http://core.svn.wordpress.org/trunk@32638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:42:25 +00:00
Drew Jaynes
5e2983a77e Fix formatting and add a missing return description for inline documentation introduced in [32644] for WP_Plugins_List_Table. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32667


git-svn-id: http://core.svn.wordpress.org/trunk@32637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:40:29 +00:00
Drew Jaynes
d7428fc35d Fix formatting and add missing return descriptions for inline documentation introduced in [32644] for WP_MS_Users_List_Table. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32666


git-svn-id: http://core.svn.wordpress.org/trunk@32636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:38:26 +00:00
Drew Jaynes
5e84c7004d Fix syntax and add a missing return description for inline documentation introduced in [32644] for WP_MS_Themes_List_Table. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32665


git-svn-id: http://core.svn.wordpress.org/trunk@32635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:36:27 +00:00
Drew Jaynes
88569734d8 Fix formatting and add missing return descriptions for inline documentation introduced in [32644] for WP_MS_Sites_List_Table. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32664


git-svn-id: http://core.svn.wordpress.org/trunk@32634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:34:25 +00:00
Drew Jaynes
42afe1d373 Fix formatting and add a missing return description for inline documentation introduced in [32644] for WP_Media_List_Table. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32663


git-svn-id: http://core.svn.wordpress.org/trunk@32633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:32:26 +00:00
Drew Jaynes
8bcf53cc68 Fix formatting and add missing return descriptions for inline documenation introduced in [32644] for WP_List_Table. 
Also fixes an error introduced in [32661] for `WP_Links_List_Table`.

See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32662


git-svn-id: http://core.svn.wordpress.org/trunk@32632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:29:26 +00:00
Drew Jaynes
2a0048b1fb Fix formatting and add a missing return description for inline documentation introduced in [32644] for WP_Links_List_Table. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32661


git-svn-id: http://core.svn.wordpress.org/trunk@32631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:23:26 +00:00
Drew Jaynes
5457eb4933 Add missing return descriptions and fix formatting of inline documentation introduced in [32644]. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32660


git-svn-id: http://core.svn.wordpress.org/trunk@32630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:18:26 +00:00
Scott Taylor
6a08b00632 Add @access annotations to methods that have no doc block in wp-admin/includes/*. 
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32656


git-svn-id: http://core.svn.wordpress.org/trunk@32626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 21:32:24 +00:00
Scott Taylor
b3e0cfd25d Add (more) missing doc blocks to wp-admin/includes/*. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32655


git-svn-id: http://core.svn.wordpress.org/trunk@32625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 21:17:27 +00:00
Scott Taylor
c6a4512b1b Add missing doc blocks to wp-admin/includes/*. 
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32654


git-svn-id: http://core.svn.wordpress.org/trunk@32624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 20:17:26 +00:00
Scott Taylor
a51dfa3971 In the style of #30947 and default-filters.php, add 2 new files to wp-admin/includes: 
`admin-filters.php`
`ms-admin-filters.php`

There are random actions and filters littered among files like `misc.php`. These files contain functions that won't work outside of admin context and are typically only loaded in files that have already loaded the admin bootstrap.

See #32529.

Built from https://develop.svn.wordpress.org/trunk@32653


git-svn-id: http://core.svn.wordpress.org/trunk@32623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 17:04:26 +00:00
Scott Taylor
9a29d8ac7b Add missing annotations to ajax-actions.php` 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32652


git-svn-id: http://core.svn.wordpress.org/trunk@32622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 16:01:27 +00:00
Helen Hou-Sandí
f5646cd9e5 Define a primary column for WP_Post_Comments_List_Table. 
props boonebgorges.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32651


git-svn-id: http://core.svn.wordpress.org/trunk@32621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 15:52:25 +00:00
Scott Taylor
19a3aacc94 Add @static* annotations where they are missing. 
Initialize all static vars that are not, most to `null`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32650


git-svn-id: http://core.svn.wordpress.org/trunk@32620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 15:43:29 +00:00
Helen Hou-Sandí
4c0c7fd7ba List tables: introduce the concept of a "primary" column. 
This becomes the column that contains the row actions, and allows for a more flexibility, particularly with custom post types and list tables. To (re)define the primary column, use the `list_table_primary_column` filter, which receives the column name and the screen ID as arguments.

props stephdau, DaveAl, jesin.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32644


git-svn-id: http://core.svn.wordpress.org/trunk@32614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 02:41:25 +00:00
Scott Taylor
282e28ad81 Add @global annotations to (the rest of the?) wp-admin/* files. 
Does not include list table file changes.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32643


git-svn-id: http://core.svn.wordpress.org/trunk@32613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 02:06:31 +00:00
Scott Taylor
b56b9b3e5c Add @global annotations for wp-admin/*. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32642


git-svn-id: http://core.svn.wordpress.org/trunk@32612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 21:41:30 +00:00
Jeremy Felt
a5c688e817 Use site objects rather than get_blog_status() in MS list tables. 
Removes several repetitive calls to `get_blog_status()` that are not needed, as the data is already available as part of each site's object.

Fixes #32512.

Built from https://develop.svn.wordpress.org/trunk@32630


git-svn-id: http://core.svn.wordpress.org/trunk@32600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 23:14:29 +00:00
Scott Taylor
19b8ef0c92 get_comments() can return int, so a few places need to check if the return value is traversable before passing what is assumed to be an array. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32600


git-svn-id: http://core.svn.wordpress.org/trunk@32570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 17:59:25 +00:00
Drew Jaynes
4c37f68b79 Fix inline documentation syntax in wp_xmlrpc_server. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32591


git-svn-id: http://core.svn.wordpress.org/trunk@32561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 06:25:25 +00:00